gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• pkg/sql/dml/update.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/catalog/catconfig/currency.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/customer/custattr/attribute.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/i18n/locale_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/i18n/currency.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/i18n/currency_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/sql/mycanal/canal.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/i18n/number.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/i18n/number_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/customer/custattr/address_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/eav/attribute_sql.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/eav/entity_type.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/util/cstrace/cstrace_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint90%

Golint is a linter for Go source code.

• pkg/util/codegen/common.go
  • Line 33: warning: exported method FormatError.ErrorKind should have comment or be unexported (golint)

• pkg/util/codegen/gogen.go
  • Line 26: warning: exported type Go should have comment or be unexported (golint)
  • Line 87: warning: exported method Go.GenerateFile should have comment or be unexported (golint)

• pkg/util/pseudo/general.go
  • Line 100: warning: comment on exported method Service.UUIDString should be of the form "UUIDString ..." (golint)
  • Line 117: warning: exported method Service.Float64 should have comment or be unexported (golint)

• pkg/email/config.go
  • Line 22: warning: exported var PackageConfiguration should have comment or be unexported (golint)

• pkg/util/csjwt/hmac_fast_blake2.go
  • Line 24: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• pkg/util/csjwt/rsa.go
  • Line 36: warning: exported method SigningMethodRSA.Alg should have comment or be unexported (golint)

• pkg/sql/myreplicator/parser.go
  • Line 16: warning: exported type BinlogParser should have comment or be unexported (golint)
  • Line 33: warning: exported function NewBinlogParser should have comment or be unexported (golint)
  • Line 41: warning: exported method BinlogParser.Stop should have comment or be unexported (golint)
  • Line 45: warning: exported method BinlogParser.Resume should have comment or be unexported (golint)
  • Line 49: warning: exported method BinlogParser.Reset should have comment or be unexported (golint)
  • Line 53: warning: exported type OnEventFunc should have comment or be unexported (golint)
  • Line 55: warning: exported method BinlogParser.ParseFile should have comment or be unexported (golint)
  • Line 149: warning: exported method BinlogParser.ParseReader should have comment or be unexported (golint)
  • Line 172: warning: exported method BinlogParser.SetRawMode should have comment or be unexported (golint)
  • Line 176: warning: exported method BinlogParser.SetParseTime should have comment or be unexported (golint)
  • Line 180: warning: exported method BinlogParser.SetTimestampStringLocation should have comment or be unexported (golint)
  • Line 184: warning: exported method BinlogParser.SetVerifyChecksum should have comment or be unexported (golint)
  • Line 285: warning: comment on exported method BinlogParser.Parse should be of the form "Parse ..." (golint)

• pkg/user/service.go
  • Line 17: warning: exported type Service should have comment or be unexported (golint)

• pkg/net/auth/doc.go
  • Line 48: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• pkg/net/internal/scopedservice/options_generic.go
  • Line 147: warning: comment on exported function WithTraceAttributes should be of the form "WithTraceAttributes ..." (golint)

• pkg/sql/myreplicator/replication_test.go
  • Line 389: warning: don't use underscores in Go names; var gtid_binlog_pos should be gtidBinlogPos (golint)

• pkg/email/doc.go
  • Line 15: warning: package comment should be of the form "Package email ..." (golint)

• pkg/sql/dmlgen/json.go
  • Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/sync/bgwork/scheduler.go
  • Line 10: warning: exported type ScheduleOptions should have comment or be unexported (golint)

• pkg/sql/dmltype/strings.go
  • Line 74: warning: exported method CSV.MarshalText should have comment or be unexported (golint)
  • Line 78: warning: exported method CSV.UnmarshalText should have comment or be unexported (golint)
  • Line 87: warning: exported method CSV.Bytes should have comment or be unexported (golint)

• pkg/sql/dml/condition.go
  • Line 366: warning: exported method Condition.Null should have comment or be unexported (golint)
  • Line 371: warning: exported method Condition.NotNull should have comment or be unexported (golint)
  • Line 376: warning: exported method Condition.In should have comment or be unexported (golint)
  • Line 381: warning: exported method Condition.NotIn should have comment or be unexported (golint)
  • Line 386: warning: exported method Condition.Between should have comment or be unexported (golint)
  • Line 391: warning: exported method Condition.NotBetween should have comment or be unexported (golint)
  • Line 396: warning: exported method Condition.Like should have comment or be unexported (golint)
  • Line 401: warning: exported method Condition.NotLike should have comment or be unexported (golint)
  • Line 406: warning: exported method Condition.Greatest should have comment or be unexported (golint)
  • Line 411: warning: exported method Condition.Least should have comment or be unexported (golint)
  • Line 416: warning: exported method Condition.Equal should have comment or be unexported (golint)
  • Line 421: warning: exported method Condition.NotEqual should have comment or be unexported (golint)
  • Line 426: warning: exported method Condition.Exists should have comment or be unexported (golint)
  • Line 431: warning: exported method Condition.NotExists should have comment or be unexported (golint)
  • Line 436: warning: exported method Condition.Less should have comment or be unexported (golint)
  • Line 441: warning: exported method Condition.Greater should have comment or be unexported (golint)
  • Line 446: warning: exported method Condition.LessOrEqual should have comment or be unexported (golint)
  • Line 451: warning: exported method Condition.GreaterOrEqual should have comment or be unexported (golint)
  • Line 456: warning: exported method Condition.Regexp should have comment or be unexported (golint)
  • Line 461: warning: exported method Condition.NotRegexp should have comment or be unexported (golint)
  • Line 466: warning: exported method Condition.Xor should have comment or be unexported (golint)
  • Line 471: warning: exported method Condition.SpaceShip should have comment or be unexported (golint)
  • Line 476: warning: exported method Condition.Coalesce should have comment or be unexported (golint)
  • Line 566: warning: exported method Condition.Int should have comment or be unexported (golint)
  • Line 575: warning: exported method Condition.Ints should have comment or be unexported (golint)
  • Line 584: warning: exported method Condition.Int64 should have comment or be unexported (golint)
  • Line 593: warning: exported method Condition.Int64s should have comment or be unexported (golint)
  • Line 602: warning: exported method Condition.Uint64 should have comment or be unexported (golint)
  • Line 611: warning: exported method Condition.Uint64s should have comment or be unexported (golint)
  • Line 623: warning: exported method Condition.Decimal should have comment or be unexported (golint)
  • Line 641: warning: exported method Condition.Float64 should have comment or be unexported (golint)
  • Line 650: warning: exported method Condition.Float64s should have comment or be unexported (golint)
  • Line 659: warning: exported method Condition.Str should have comment or be unexported (golint)
  • Line 668: warning: exported method Condition.Strs should have comment or be unexported (golint)
  • Line 677: warning: exported method Condition.Bool should have comment or be unexported (golint)
  • Line 686: warning: exported method Condition.Bools should have comment or be unexported (golint)
  • Line 707: warning: exported method Condition.BytesSlice should have comment or be unexported (golint)
  • Line 716: warning: exported method Condition.Time should have comment or be unexported (golint)
  • Line 725: warning: exported method Condition.Times should have comment or be unexported (golint)
  • Line 734: warning: exported method Condition.NullString should have comment or be unexported (golint)
  • Line 743: warning: exported method Condition.NullStrings should have comment or be unexported (golint)
  • Line 752: warning: exported method Condition.NullFloat64 should have comment or be unexported (golint)
  • Line 761: warning: exported method Condition.NullFloat64s should have comment or be unexported (golint)
  • Line 770: warning: exported method Condition.NullInt64 should have comment or be unexported (golint)
  • Line 779: warning: exported method Condition.NullInt64s should have comment or be unexported (golint)
  • Line 788: warning: exported method Condition.NullBool should have comment or be unexported (golint)
  • Line 797: warning: exported method Condition.NullBools should have comment or be unexported (golint)
  • Line 806: warning: exported method Condition.NullTime should have comment or be unexported (golint)
  • Line 815: warning: exported method Condition.NullTimes should have comment or be unexported (golint)

• pkg/util/byteconv/int.go
  • Line 73: warning: exported function LenInt should have comment or be unexported (golint)

• pkg/store/mock/service.go
  • Line 51: warning: exported function NewServiceEuroW11G11S19 should have comment or be unexported (golint)

• pkg/sql/mycanal/sync.go
  • Line 260: warning: exported method Canal.GetMasterPos should have comment or be unexported (golint)
  • Line 289: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/i18n/number.go
  • Line 71: warning: exported type Number should have comment or be unexported (golint)

• pkg/util/conv/cast.go
  • Line 10: warning: exported function ToBool should have comment or be unexported (golint)
  • Line 15: warning: exported function ToTime should have comment or be unexported (golint)
  • Line 20: warning: exported function ToDuration should have comment or be unexported (golint)
  • Line 25: warning: exported function ToFloat64 should have comment or be unexported (golint)
  • Line 30: warning: exported function ToUint should have comment or be unexported (golint)
  • Line 35: warning: exported function ToInt should have comment or be unexported (golint)
  • Line 40: warning: exported function ToInt64 should have comment or be unexported (golint)
  • Line 45: warning: exported function ToString should have comment or be unexported (golint)
  • Line 50: warning: exported function ToByte should have comment or be unexported (golint)
  • Line 55: warning: exported function ToStringMapString should have comment or be unexported (golint)
  • Line 60: warning: exported function ToStringMapStringSlice should have comment or be unexported (golint)
  • Line 65: warning: exported function ToStringMapBool should have comment or be unexported (golint)
  • Line 70: warning: exported function ToStringMap should have comment or be unexported (golint)
  • Line 75: warning: exported function ToSlice should have comment or be unexported (golint)
  • Line 80: warning: exported function ToStringSlice should have comment or be unexported (golint)
  • Line 85: warning: exported function ToDataSlice should have comment or be unexported (golint)
  • Line 90: warning: exported function ToIntSlice should have comment or be unexported (golint)

• pkg/email/service.go
  • Line 41: warning: comment on exported type ServiceOption should be of the form "ServiceOption ..." (with optional leading article) (golint)
  • Line 44: warning: comment on exported type Service should be of the form "Service ..." (with optional leading article) (golint)
  • Line 59: warning: comment on exported method Service.Option should be of the form "Option ..." (golint)
  • Line 71: warning: exported method Service.Send should have comment or be unexported (golint)
  • Line 128: warning: exported function NewService should have comment or be unexported (golint)

• pkg/sql/myreplicator/const.go
  • Line 4: warning: comment on exported const MinBinlogVersion should be of the form "MinBinlogVersion ..." (golint)
  • Line 9: warning: comment on exported var BinLogFileHeader should be of the form "BinLogFileHeader ..." (golint)
  • Line 12: warning: exported var SemiSyncIndicator should have comment or be unexported (golint)
  • Line 16: warning: exported const LOG_EVENT_BINLOG_IN_USE_F should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported const BINLOG_DUMP_NEVER_STOP should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported const BINLOG_ROW_IMAGE_FULL should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: exported type EventType should have comment or be unexported (golint)
  • Line 44: warning: exported const UNKNOWN_EVENT should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: don't use underscores in Go names; const WRITE_ROWS_EVENTv0 should be WRITEROWSEVENTv0 (golint)
  • Line 65: warning: don't use underscores in Go names; const UPDATE_ROWS_EVENTv0 should be UPDATEROWSEVENTv0 (golint)
  • Line 66: warning: don't use underscores in Go names; const DELETE_ROWS_EVENTv0 should be DELETEROWSEVENTv0 (golint)
  • Line 67: warning: don't use underscores in Go names; const WRITE_ROWS_EVENTv1 should be WRITEROWSEVENTv1 (golint)
  • Line 68: warning: don't use underscores in Go names; const UPDATE_ROWS_EVENTv1 should be UPDATEROWSEVENTv1 (golint)
  • Line 69: warning: don't use underscores in Go names; const DELETE_ROWS_EVENTv1 should be DELETEROWSEVENTv1 (golint)
  • Line 74: warning: don't use underscores in Go names; const WRITE_ROWS_EVENTv2 should be WRITEROWSEVENTv2 (golint)
  • Line 75: warning: don't use underscores in Go names; const UPDATE_ROWS_EVENTv2 should be UPDATEROWSEVENTv2 (golint)
  • Line 76: warning: don't use underscores in Go names; const DELETE_ROWS_EVENTv2 should be DELETEROWSEVENTv2 (golint)
  • Line 83: warning: comment on exported const MARIADB_ANNOTATE_ROWS_EVENT should be of the form "MARIADB_ANNOTATE_ROWS_EVENT ..." (golint)
  • Line 85: warning: exported const MARIADB_BINLOG_CHECKPOINT_EVENT should have comment (or a comment on this block) or be unexported (golint)
  • Line 179: warning: exported const BINLOG_CHECKSUM_ALG_OFF should have comment (or a comment on this block) or be unexported (golint)
  • Line 180: warning: comment on exported const BINLOG_CHECKSUM_ALG_CRC32 should be of the form "BINLOG_CHECKSUM_ALG_CRC32 ..." (golint)
  • Line 182: warning: comment on exported const BINLOG_CHECKSUM_ALG_UNDEF should be of the form "BINLOG_CHECKSUM_ALG_UNDEF ..." (golint)

• pkg/util/strs/ww.go
  • Line 36: warning: comment on exported function WordWrap should be of the form "WordWrap ..." (golint)

• pkg/eav/attribute_frontend.go
  • Line 44: warning: exported type AttributeFrontendConfig should have comment or be unexported (golint)
  • Line 73: warning: exported method AttributeFrontend.InputRenderer should have comment or be unexported (golint)
  • Line 74: warning: exported method AttributeFrontend.GetValue should have comment or be unexported (golint)
  • Line 75: warning: exported method AttributeFrontend.GetInputType should have comment or be unexported (golint)

• pkg/util/csjwt/hmac_fast_sha.go
  • Line 71: warning: exported method SigningMethodHSFast.Alg should have comment or be unexported (golint)

• pkg/net/runmode/code.go
  • Line 105: warning: receiver name a should be consistent with previous receiver name e for ProcessStoreCodeCookie (golint)
  • Line 127: warning: receiver name a should be consistent with previous receiver name e for ProcessStoreCodeCookie (golint)
  • Line 139: warning: receiver name a should be consistent with previous receiver name e for ProcessStoreCodeCookie (golint)
  • Line 153: warning: receiver name a should be consistent with previous receiver name e for ProcessStoreCodeCookie (golint)
  • Line 163: warning: receiver name a should be consistent with previous receiver name e for ProcessStoreCodeCookie (golint)

• pkg/util/csjwt/jwtclaim/map.go
  • Line 57: warning: comment on exported method Map.VerifyExpiresAt should be of the form "VerifyExpiresAt ..." (golint)
  • Line 63: warning: comment on exported method Map.VerifyIssuedAt should be of the form "VerifyIssuedAt ..." (golint)
  • Line 69: warning: comment on exported method Map.VerifyIssuer should be of the form "VerifyIssuer ..." (golint)
  • Line 76: warning: comment on exported method Map.VerifyNotBefore should be of the form "VerifyNotBefore ..." (golint)
  • Line 82: warning: comment on exported method Map.Valid should be of the form "Valid ..." (golint)
  • Line 108: warning: exported method Map.Set should have comment or be unexported (golint)
  • Line 118: warning: exported method Map.Keys should have comment or be unexported (golint)

• pkg/util/bufferpool/reader.go
  • Line 28: warning: comment on exported function GetReader should be of the form "GetReader ..." (golint)
  • Line 35: warning: comment on exported function PutReader should be of the form "PutReader ..." (golint)

• pkg/catalog/catattr/attribute.go
  • Line 57: warning: exported type WSASlice should have comment or be unexported (golint)
  • Line 158: warning: exported method Catalog.FrontendInputRenderer should have comment or be unexported (golint)
  • Line 161: warning: exported method Catalog.IsGlobal should have comment or be unexported (golint)
  • Line 164: warning: exported method Catalog.IsVisible should have comment or be unexported (golint)
  • Line 167: warning: exported method Catalog.IsSearchable should have comment or be unexported (golint)
  • Line 170: warning: exported method Catalog.IsFilterable should have comment or be unexported (golint)
  • Line 173: warning: exported method Catalog.IsComparable should have comment or be unexported (golint)
  • Line 176: warning: exported method Catalog.IsVisibleOnFront should have comment or be unexported (golint)
  • Line 179: warning: exported method Catalog.IsHTMLAllowedOnFront should have comment or be unexported (golint)
  • Line 182: warning: exported method Catalog.IsUsedForPriceRules should have comment or be unexported (golint)
  • Line 185: warning: exported method Catalog.IsFilterableInSearch should have comment or be unexported (golint)
  • Line 188: warning: exported method Catalog.UsedInProductListing should have comment or be unexported (golint)
  • Line 191: warning: exported method Catalog.UsedForSortBy should have comment or be unexported (golint)
  • Line 194: warning: exported method Catalog.IsConfigurable should have comment or be unexported (golint)
  • Line 197: warning: exported method Catalog.ApplyTo should have comment or be unexported (golint)
  • Line 200: warning: exported method Catalog.IsVisibleInAdvancedSearch should have comment or be unexported (golint)
  • Line 203: warning: exported method Catalog.Position should have comment or be unexported (golint)
  • Line 206: warning: exported method Catalog.IsWysiwygEnabled should have comment or be unexported (golint)
  • Line 209: warning: exported method Catalog.IsUsedForPromoRules should have comment or be unexported (golint)
  • Line 212: warning: exported method Catalog.SearchWeight should have comment or be unexported (golint)
  • Line 283: warning: exported function HandlerProduct should have comment or be unexported (golint)
  • Line 288: warning: exported function HandlerCategory should have comment or be unexported (golint)

• pkg/util/pseudo/names.go
  • Line 68: warning: comment on exported method Service.Suffix should be of the form "Suffix ..." (golint)

• pkg/sql/ddl/tables.go
  • Line 38: warning: comment on exported const PrefixView should be of the form "PrefixView ..." (golint)
  • Line 41: warning: exported const SuffixView should have comment (or a comment on this block) or be unexported (golint)

• pkg/util/hashpool/register.go
  • Line 141: warning: comment on exported function FromRegistryHMAC should be of the form "FromRegistryHMAC ..." (golint)

• pkg/customer/custattr/attribute.go
  • Line 26: warning: exported type WSASlice should have comment or be unexported (golint)
  • Line 83: warning: exported function NewCustomer should have comment or be unexported (golint)
  • Line 107: warning: exported method Customer.IsVisible should have comment or be unexported (golint)
  • Line 110: warning: exported method Customer.MultilineCount should have comment or be unexported (golint)
  • Line 113: warning: exported method Customer.InputFilter should have comment or be unexported (golint)
  • Line 116: warning: exported method Customer.Validate should have comment or be unexported (golint)
  • Line 119: warning: exported method Customer.IsSystem should have comment or be unexported (golint)
  • Line 122: warning: exported method Customer.SortOrder should have comment or be unexported (golint)
  • Line 125: warning: exported method Customer.DataModel should have comment or be unexported (golint)
  • Line 196: warning: exported function HandlerCustomer should have comment or be unexported (golint)
  • Line 201: warning: exported function HandlerAddress should have comment or be unexported (golint)

• pkg/eav/entity_type.go
  • Line 25: warning: exported const EntityTypeDatetime should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported type ValueIndex should have comment or be unexported (golint)
  • Line 132: warning: exported method TableEntityType.LoadByCode should have comment or be unexported (golint)
  • Line 180: warning: comment on exported method CSEntityType.GetEntityTablePrefix should be of the form "GetEntityTablePrefix ..." (golint)
  • Line 186: warning: comment on exported method CSEntityType.GetValueTablePrefix should be of the form "GetValueTablePrefix ..." (golint)

• pkg/util/pseudo/currencies.go
  • Line 15: warning: comment on exported method Service.Price should be of the form "Price ..." (golint)

• pkg/util/assert/errors.go
  • Line 10: warning: error var AnError should have name of the form ErrFoo (golint)

• pkg/net/csgrpc/auth/service.go
  • Line 15: warning: don't use an underscore in package name (golint)

• pkg/sql/dmlgen/table.go
  • Line 30: warning: comment on exported type Table should be of the form "Table ..." (with optional leading article) (golint)
  • Line 69: warning: exported method Table.IsFieldPublic should have comment or be unexported (golint)
  • Line 73: warning: exported method Table.IsFieldPrivate should have comment or be unexported (golint)
  • Line 77: warning: exported method Table.GoCamelMaybePrivate should have comment or be unexported (golint)
  • Line 85: warning: exported method Table.CollectionName should have comment or be unexported (golint)
  • Line 89: warning: exported method Table.EntityName should have comment or be unexported (golint)
  • Line 93: warning: exported method Table.EntityNameLCFirst should have comment or be unexported (golint)

• pkg/customer/custattr/address_source.go
  • Line 35: warning: comment on exported function AddressSourceRegion should be of the form "AddressSourceRegion ..." (golint)

• pkg/storage/lru/lru_cache.go
  • Line 17: warning: package comment should be of the form "Package lru ..." (golint)

• pkg/util/slices/int64.go
  • Line 23: warning: comment on exported type Int64 should be of the form "Int64 ..." (with optional leading article) (golint)

• pkg/customer/custattr/address_backend.go
  • Line 19: warning: comment on exported function AddressBackendRegion should be of the form "AddressBackendRegion ..." (golint)

• pkg/eav/attribute_data.go
  • Line 20: warning: exported const OutputFormatJSON should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported type AttributeData should have comment or be unexported (golint)
  • Line 58: warning: exported type AttributeDataConfig should have comment or be unexported (golint)
  • Line 79: warning: exported method AttributeData.Config should have comment or be unexported (golint)
  • Line 86: warning: exported method AttributeData.ExtractValue should have comment or be unexported (golint)
  • Line 87: warning: exported method AttributeData.ValidateValue should have comment or be unexported (golint)
  • Line 88: warning: exported method AttributeData.CompactValue should have comment or be unexported (golint)
  • Line 89: warning: exported method AttributeData.RestoreValue should have comment or be unexported (golint)
  • Line 90: warning: exported method AttributeData.OutputValue should have comment or be unexported (golint)

• pkg/i18n/currency.go
  • Line 257: warning: comment on exported method Currency.FmtFloat64 should be of the form "FmtFloat64 ..." (golint)

• pkg/i18n/language.go
  • Line 41: warning: exported function GetAllLanguages should have comment or be unexported (golint)

• pkg/i18n/lists.go
  • Line 19: warning: exported function AllCurrencies should have comment or be unexported (golint)

• pkg/util/conv/cast_test.go
  • Line 22: warning: don't use underscores in Go names; var i_8 should be i8 (golint)

• pkg/util/pseudo/dates.go
  • Line 86: warning: comment on exported method Service.TimeZone should be of the form "TimeZone ..." (golint)

• pkg/sql/urlvalues/values.go
  • Line 11: warning: exported method Values.Has should have comment or be unexported (golint)
  • Line 16: warning: exported method Values.SetDefault should have comment or be unexported (golint)
  • Line 22: warning: exported method Values.Strings should have comment or be unexported (golint)
  • Line 34: warning: exported method Values.Bool should have comment or be unexported (golint)
  • Line 45: warning: exported method Values.MaybeBool should have comment or be unexported (golint)
  • Line 50: warning: exported method Values.Int should have comment or be unexported (golint)
  • Line 58: warning: exported method Values.MaybeInt should have comment or be unexported (golint)
  • Line 63: warning: exported method Values.Int64 should have comment or be unexported (golint)
  • Line 71: warning: exported method Values.MaybeInt64 should have comment or be unexported (golint)
  • Line 76: warning: exported method Values.Float64 should have comment or be unexported (golint)
  • Line 84: warning: exported method Values.MaybeFloat64 should have comment or be unexported (golint)
  • Line 89: warning: exported method Values.Time should have comment or be unexported (golint)
  • Line 97: warning: exported method Values.MaybeTime should have comment or be unexported (golint)
  • Line 102: warning: exported method Values.Duration should have comment or be unexported (golint)
  • Line 110: warning: exported method Values.MaybeDuration should have comment or be unexported (golint)
  • Line 115: warning: exported method Values.Pager should have comment or be unexported (golint)

• pkg/net/csgrpc/scope/runmode.go
  • Line 15: warning: don't use an underscore in package name (golint)

• pkg/net/csgrpc/auth/doc.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/sql/myreplicator/event.go
  • Line 18: warning: exported const EventHeaderSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported type BinlogEvent should have comment or be unexported (golint)
  • Line 34: warning: exported method BinlogEvent.Dump should have comment or be unexported (golint)
  • Line 39: warning: exported type EventDecoder should have comment or be unexported (golint)
  • Line 46: warning: exported type EventError should have comment or be unexported (golint)
  • Line 60: warning: exported type EventHeader should have comment or be unexported (golint)
  • Line 101: warning: exported method EventHeader.Dump should have comment or be unexported (golint)
  • Line 145: warning: exported type FormatDescriptionEvent should have comment or be unexported (golint)
  • Line 194: warning: exported method FormatDescriptionEvent.Dump should have comment or be unexported (golint)
  • Line 203: warning: exported type RotateEvent should have comment or be unexported (golint)
  • Line 215: warning: exported method RotateEvent.Dump should have comment or be unexported (golint)
  • Line 221: warning: exported type XIDEvent should have comment or be unexported (golint)
  • Line 233: warning: exported method XIDEvent.Dump should have comment or be unexported (golint)
  • Line 241: warning: exported type QueryEvent should have comment or be unexported (golint)
  • Line 284: warning: exported method QueryEvent.Dump should have comment or be unexported (golint)
  • Line 297: warning: exported type GTIDEvent should have comment or be unexported (golint)
  • Line 324: warning: exported method GTIDEvent.Dump should have comment or be unexported (golint)
  • Line 333: warning: exported type BeginLoadQueryEvent should have comment or be unexported (golint)
  • Line 349: warning: exported method BeginLoadQueryEvent.Dump should have comment or be unexported (golint)
  • Line 355: warning: exported type ExecuteLoadQueryEvent should have comment or be unexported (golint)
  • Line 399: warning: exported method ExecuteLoadQueryEvent.Dump should have comment or be unexported (golint)
  • Line 415: warning: exported type MariadbAnnotateRowsEvent should have comment or be unexported (golint)
  • Line 424: warning: exported method MariadbAnnotateRowsEvent.Dump should have comment or be unexported (golint)
  • Line 429: warning: exported type MariadbBinlogCheckPointEvent should have comment or be unexported (golint)
  • Line 438: warning: exported method MariadbBinlogCheckPointEvent.Dump should have comment or be unexported (golint)
  • Line 443: warning: exported type MariadbGTIDEvent should have comment or be unexported (golint)
  • Line 456: warning: exported method MariadbGTIDEvent.Dump should have comment or be unexported (golint)
  • Line 461: warning: exported type MariadbGTIDListEvent should have comment or be unexported (golint)
  • Line 485: warning: exported method MariadbGTIDListEvent.Dump should have comment or be unexported (golint)

• pkg/sql/myreplicator/generic_event.go
  • Line 9: warning: comment on exported type GenericEvent should be of the form "GenericEvent ..." (with optional leading article) (golint)
  • Line 14: warning: exported method GenericEvent.Dump should have comment or be unexported (golint)

• pkg/net/csgrpc/scope/doc.go
  • Line 17: warning: don't use an underscore in package name (golint)

• pkg/store/entities_extended.go
  • Line 125: warning: exported method StoreWebsite.DefaultGroup should have comment or be unexported (golint)

• pkg/store/service.go
  • Line 57: warning: exported type Service should have comment or be unexported (golint)
  • Line 293: warning: exported method Service.Close should have comment or be unexported (golint)

• pkg/eav/attribute.go
  • Line 111: warning: exported type AttributeSliceGetter should have comment or be unexported (golint)
  • Line 251: warning: exported method Attribute.AttributeID should have comment or be unexported (golint)
  • Line 254: warning: exported method Attribute.EntityTypeID should have comment or be unexported (golint)
  • Line 257: warning: exported method Attribute.AttributeCode should have comment or be unexported (golint)
  • Line 260: warning: exported method Attribute.BackendModel should have comment or be unexported (golint)
  • Line 263: warning: exported method Attribute.BackendType should have comment or be unexported (golint)
  • Line 286: warning: exported method Attribute.FrontendModel should have comment or be unexported (golint)
  • Line 289: warning: exported method Attribute.FrontendInput should have comment or be unexported (golint)
  • Line 292: warning: exported method Attribute.FrontendLabel should have comment or be unexported (golint)
  • Line 295: warning: exported method Attribute.FrontendClass should have comment or be unexported (golint)
  • Line 298: warning: exported method Attribute.SourceModel should have comment or be unexported (golint)
  • Line 301: warning: exported method Attribute.IsRequired should have comment or be unexported (golint)
  • Line 304: warning: exported method Attribute.IsUserDefined should have comment or be unexported (golint)
  • Line 307: warning: exported method Attribute.DefaultValue should have comment or be unexported (golint)
  • Line 310: warning: exported method Attribute.IsUnique should have comment or be unexported (golint)
  • Line 313: warning: exported method Attribute.Note should have comment or be unexported (golint)

• pkg/eav/attribute_source.go
  • Line 46: warning: exported type AttributeSourceConfig should have comment or be unexported (golint)

• pkg/net/csgrpc/auth/metadata_test.go
  • Line 4: warning: don't use an underscore in package name (golint)

• pkg/sql/myreplicator/row_event.go
  • Line 17: warning: exported type TableMapEvent should have comment or be unexported (golint)
  • Line 185: warning: exported method TableMapEvent.Dump should have comment or be unexported (golint)
  • Line 200: warning: exported type RowsEvent should have comment or be unexported (golint)
  • Line 268: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 709: warning: exported const DATETIMEF_INT_OFS should have comment or be unexported (golint)
  • Line 758: warning: exported const TIMEF_OFS should have comment or be unexported (golint)
  • Line 759: warning: exported const TIMEF_INT_OFS should have comment or be unexported (golint)
  • Line 868: warning: exported method RowsEvent.Dump should have comment or be unexported (golint)
  • Line 887: warning: exported type RowsQueryEvent should have comment or be unexported (golint)
  • Line 897: warning: exported method RowsQueryEvent.Dump should have comment or be unexported (golint)

• pkg/sql/dml/connection.go
  • Line 809: warning: exported method ConnPool.CachedQueries should have comment or be unexported (golint)
  • Line 849: warning: exported method ConnPool.DeregisterByCacheKey should have comment or be unexported (golint)
  • Line 903: warning: comment on exported method ConnPool.WithPrepare should be of the form "WithPrepare ..." (golint)

• pkg/store/scope/perm.go
  • Line 141: warning: comment on exported method Perm.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)

• pkg/authorization/auth.go
  • Line 17: warning: exported type TokenAuthorizer should have comment or be unexported (golint)

• pkg/i18n/countries.go
  • Line 23: warning: exported type CountrySlice should have comment or be unexported (golint)

• pkg/sql/migration/run.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• pkg/util/codegen/proto.go
  • Line 26: warning: exported type Proto should have comment or be unexported (golint)
  • Line 42: warning: exported method Proto.AddOptions should have comment or be unexported (golint)
  • Line 69: warning: exported method Proto.GenerateFile should have comment or be unexported (golint)

• pkg/util/pseudo/fake.go
  • Line 1: warning: package comment should be of the form "Package pseudo ..." (golint)

• pkg/util/assert/diff.go
  • Line 12: warning: exported function DiffValues should have comment or be unexported (golint)
  • Line 35: warning: exported function DiffValuesDefault should have comment or be unexported (golint)

• pkg/net/csgrpc/auth/auth.go
  • Line 4: warning: don't use an underscore in package name (golint)

• pkg/sql/dml/builder.go
  • Line 51: warning: comment on exported type QuerySQLFn should be of the form "QuerySQLFn ..." (with optional leading article) (golint)

• pkg/sql/dml/dbr.go
  • Line 214: warning: exported method Insert.WithDBR should have comment or be unexported (golint)
  • Line 225: warning: exported method Delete.WithDBR should have comment or be unexported (golint)
  • Line 236: warning: exported method Update.WithDBR should have comment or be unexported (golint)
  • Line 247: warning: exported method Show.WithDBR should have comment or be unexported (golint)
  • Line 258: warning: exported method Union.WithDBR should have comment or be unexported (golint)
  • Line 269: warning: exported method With.WithDBR should have comment or be unexported (golint)
  • Line 290: warning: receiver name bc should be consistent with previous receiver name a for DBR (golint)
  • Line 296: warning: receiver name bc should be consistent with previous receiver name a for DBR (golint)
  • Line 1408: warning: comment on exported function DBRValidateMinAffectedRow should be of the form "DBRValidateMinAffectedRow ..." (golint)
  • Line 1425: warning: exported function DBRWithTx should have comment or be unexported (golint)
  • Line 1451: warning: exported method StaticSQLResult.LastInsertId should have comment or be unexported (golint)
  • Line 1453: warning: exported method StaticSQLResult.RowsAffected should have comment or be unexported (golint)

• pkg/util/gzippool/gzip.go
  • Line 33: warning: comment on exported function GetWriter should be of the form "GetWriter ..." (golint)

• pkg/sql/urlvalues/url_filter.go
  • Line 13: warning: comment on exported type Filter should be of the form "Filter ..." (with optional leading article) (golint)
  • Line 38: warning: exported function NewFilter should have comment or be unexported (golint)

• pkg/customer/address.go
  • Line 23: warning: exported type AddressModel should have comment or be unexported (golint)
  • Line 35: warning: exported method AddressModel.TBD should have comment or be unexported (golint)
  • Line 39: warning: exported method AddressModel.TableNameBase should have comment or be unexported (golint)
  • Line 43: warning: exported method AddressModel.TableNameValue should have comment or be unexported (golint)
  • Line 51: warning: comment on exported method AddressModel.TableAdditionalAttribute should be of the form "TableAdditionalAttribute ..." (golint)
  • Line 56: warning: comment on exported method AddressModel.TableEavWebsite should be of the form "TableEavWebsite ..." (golint)
  • Line 61: warning: exported function Address should have comment or be unexported (golint)

• pkg/eav/attribute_backend.go
  • Line 57: warning: exported type AttributeBackendConfig should have comment or be unexported (golint)
  • Line 86: warning: exported method AttributeBackend.IsStatic should have comment or be unexported (golint)
  • Line 87: warning: exported method AttributeBackend.GetTable should have comment or be unexported (golint)
  • Line 88: warning: exported method AttributeBackend.GetType should have comment or be unexported (golint)
  • Line 89: warning: exported method AttributeBackend.GetEntityIDField should have comment or be unexported (golint)
  • Line 90: warning: exported method AttributeBackend.Validate should have comment or be unexported (golint)
  • Line 91: warning: exported method AttributeBackend.IsScalar should have comment or be unexported (golint)

• pkg/email/daemon.go
  • Line 93: warning: comment on exported method Daemon.Worker should be of the form "Worker ..." (golint)

• pkg/net/cors/internal/corstest.go
  • Line 52: warning: exported function TestNoConfig should have comment or be unexported (golint)
  • Line 68: warning: exported function TestMatchAllOrigin should have comment or be unexported (golint)
  • Line 86: warning: exported function TestAllowedOrigin should have comment or be unexported (golint)
  • Line 104: warning: exported function TestWildcardOrigin should have comment or be unexported (golint)
  • Line 122: warning: exported function TestDisallowedOrigin should have comment or be unexported (golint)
  • Line 140: warning: exported function TestDisallowedWildcardOrigin should have comment or be unexported (golint)
  • Line 158: warning: exported function TestAllowedOriginFunc should have comment or be unexported (golint)
  • Line 174: warning: exported function TestAllowedMethodNoPassthrough should have comment or be unexported (golint)
  • Line 199: warning: exported function TestAllowedMethodPassthrough should have comment or be unexported (golint)
  • Line 221: warning: exported function TestDisallowedMethod should have comment or be unexported (golint)
  • Line 240: warning: exported function TestAllowedHeader should have comment or be unexported (golint)
  • Line 260: warning: exported function TestAllowedWildcardHeader should have comment or be unexported (golint)
  • Line 280: warning: exported function TestDisallowedHeader should have comment or be unexported (golint)
  • Line 300: warning: exported function TestOriginHeader should have comment or be unexported (golint)
  • Line 320: warning: exported function TestExposedHeader should have comment or be unexported (golint)
  • Line 338: warning: exported function TestAllowedCredentials should have comment or be unexported (golint)
  • Line 357: warning: exported function TestMaxAge should have comment or be unexported (golint)

• pkg/net/mw/middleware.go
  • Line 56: warning: comment on exported method MiddlewareSlice.ChainFunc should be of the form "ChainFunc ..." (golint)

• pkg/storage/null/time.go
  • Line 168: warning: exported method Time.SetProto should have comment or be unexported (golint)
  • Line 176: warning: exported method Time.Proto should have comment or be unexported (golint)

• pkg/util/cstrace/cstrace.go
  • Line 9: warning: exported var ErrorKey should have comment or be unexported (golint)
  • Line 31: warning: exported type Tracer should have comment or be unexported (golint)
  • Line 33: warning: exported var NewNoopTracerProvider should have comment or be unexported (golint)

• pkg/sql/dml/mapper.go
  • Line 705: warning: comment on exported method ColumnMap.NullUint64 should be of the form "NullUint64 ..." (golint)
  • Line 737: warning: comment on exported method ColumnMap.NullUint32 should be of the form "NullUint32 ..." (golint)
  • Line 769: warning: comment on exported method ColumnMap.NullUint16 should be of the form "NullUint16 ..." (golint)
  • Line 801: warning: comment on exported method ColumnMap.NullUint8 should be of the form "NullUint8 ..." (golint)
  • Line 1338: warning: exported method ColumnMap.Uint64s should have comment or be unexported (golint)
  • Line 1342: warning: exported method ColumnMap.Uint32s should have comment or be unexported (golint)
  • Line 1346: warning: exported method ColumnMap.Uint16s should have comment or be unexported (golint)
  • Line 1350: warning: exported method ColumnMap.Uint8s should have comment or be unexported (golint)
  • Line 1354: warning: exported method ColumnMap.Int64s should have comment or be unexported (golint)
  • Line 1358: warning: exported method ColumnMap.Int32s should have comment or be unexported (golint)
  • Line 1362: warning: exported method ColumnMap.Int16s should have comment or be unexported (golint)
  • Line 1366: warning: exported method ColumnMap.Int8s should have comment or be unexported (golint)
  • Line 1370: warning: exported method ColumnMap.Strings should have comment or be unexported (golint)
  • Line 1374: warning: exported method ColumnMap.Times should have comment or be unexported (golint)
  • Line 1378: warning: exported method ColumnMap.NullStrings should have comment or be unexported (golint)

• pkg/store/mock/finder.go
  • Line 35: warning: comment on exported function NewDefaultStoreID should be of the form "NewDefaultStoreID ..." (golint)
  • Line 69: warning: exported method Find.DefaultStoreID should have comment or be unexported (golint)
  • Line 79: warning: exported method Find.StoreIDbyCode should have comment or be unexported (golint)

• pkg/storage/objcache/service.go
  • Line 47: warning: exported type NewStorageFn should have comment or be unexported (golint)

• pkg/doc.go
  • Line 15: warning: package comment should be of the form "Package pkg ..." (golint)

• pkg/util/byteconv/float.go
  • Line 44: warning: comment on exported function ParseFloat should be of the form "ParseFloat ..." (golint)

• pkg/customer/customer.go
  • Line 23: warning: comment on exported type DataModeller should be of the form "DataModeller ..." (with optional leading article) (golint)
  • Line 42: warning: exported method Entity.TBD should have comment or be unexported (golint)
  • Line 46: warning: exported method Entity.TableNameBase should have comment or be unexported (golint)
  • Line 50: warning: exported method Entity.TableNameValue should have comment or be unexported (golint)
  • Line 58: warning: comment on exported method Entity.TableAdditionalAttribute should be of the form "TableAdditionalAttribute ..." (golint)
  • Line 63: warning: comment on exported method Entity.TableEavWebsite should be of the form "TableEavWebsite ..." (golint)
  • Line 68: warning: exported function Customer should have comment or be unexported (golint)

• pkg/util/validation/validator.go
  • Line 63: warning: exported const RF3339WithoutZone should have comment or be unexported (golint)

• pkg/net/csgrpc/auth/metadata.go
  • Line 4: warning: don't use an underscore in package name (golint)

• pkg/util/diff/doc.go
  • Line 15: warning: package comment should be of the form "Package diff ..." (golint)

• pkg/sql/myreplicator/json_binary.go
  • Line 13: warning: exported const JSONB_SMALL_OBJECT should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported const JSONB_NULL_LITERAL should have comment (or a comment on this block) or be unexported (golint)

• pkg/i18n/currency_dict.go
  • Line 24: warning: exported type CurrencyDictSlice should have comment or be unexported (golint)
  • Line 33: warning: exported function SetCurrencyDict should have comment or be unexported (golint)
  • Line 37: warning: exported function NewCurrencyDict should have comment or be unexported (golint)
  • Line 46: warning: exported function NewHeader should have comment or be unexported (golint)
  • Line 50: warning: exported function NewTagIndex should have comment or be unexported (golint)

• pkg/util/pseudo/jobs.go
  • Line 14: warning: comment on exported method Service.CompanyLegal should be of the form "CompanyLegal ..." (golint)

• pkg/sql/myreplicator/binlogsyncer.go
  • Line 259: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 318: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/config/doc.go
  • Line 15: warning: package comment should be of the form "Package config ..." (golint)

• pkg/storage/null/null.enc.go
  • Line 11: warning: exported method Decimal.Marshal should have comment or be unexported (golint)
  • Line 21: warning: exported method Decimal.MarshalTo should have comment or be unexported (golint)
  • Line 26: warning: exported method Decimal.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 81: warning: exported method Bool.Marshal should have comment or be unexported (golint)
  • Line 91: warning: exported method Bool.MarshalTo should have comment or be unexported (golint)
  • Line 96: warning: exported method Bool.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 124: warning: exported method Float64.Marshal should have comment or be unexported (golint)
  • Line 134: warning: exported method Float64.MarshalTo should have comment or be unexported (golint)
  • Line 139: warning: exported method Float64.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 163: warning: exported method Int64.Marshal should have comment or be unexported (golint)
  • Line 173: warning: exported method Int64.MarshalTo should have comment or be unexported (golint)
  • Line 178: warning: exported method Int64.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 201: warning: exported method Int32.Marshal should have comment or be unexported (golint)
  • Line 211: warning: exported method Int32.MarshalTo should have comment or be unexported (golint)
  • Line 216: warning: exported method Int32.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 239: warning: exported method Int16.Marshal should have comment or be unexported (golint)
  • Line 249: warning: exported method Int16.MarshalTo should have comment or be unexported (golint)
  • Line 254: warning: exported method Int16.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 277: warning: exported method Int8.Marshal should have comment or be unexported (golint)
  • Line 287: warning: exported method Int8.MarshalTo should have comment or be unexported (golint)
  • Line 292: warning: exported method Int8.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 315: warning: exported method Uint64.Marshal should have comment or be unexported (golint)
  • Line 325: warning: exported method Uint64.MarshalTo should have comment or be unexported (golint)
  • Line 330: warning: exported method Uint64.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 353: warning: exported method Uint32.Marshal should have comment or be unexported (golint)
  • Line 363: warning: exported method Uint32.MarshalTo should have comment or be unexported (golint)
  • Line 368: warning: exported method Uint32.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 391: warning: exported method Uint16.Marshal should have comment or be unexported (golint)
  • Line 401: warning: exported method Uint16.MarshalTo should have comment or be unexported (golint)
  • Line 406: warning: exported method Uint16.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 429: warning: exported method Uint8.Marshal should have comment or be unexported (golint)
  • Line 439: warning: exported method Uint8.MarshalTo should have comment or be unexported (golint)
  • Line 444: warning: exported method Uint8.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 467: warning: exported method String.Marshal should have comment or be unexported (golint)
  • Line 477: warning: exported method String.MarshalTo should have comment or be unexported (golint)
  • Line 482: warning: exported method String.MarshalToSizedBuffer should have comment or be unexported (golint)
  • Line 507: warning: exported method Time.Marshal should have comment or be unexported (golint)
  • Line 526: warning: exported method Decimal.Size should have comment or be unexported (golint)
  • Line 551: warning: exported method Bool.Size should have comment or be unexported (golint)
  • Line 563: warning: exported method Float64.Size should have comment or be unexported (golint)
  • Line 575: warning: exported method Int64.Size should have comment or be unexported (golint)
  • Line 587: warning: exported method Int32.Size should have comment or be unexported (golint)
  • Line 599: warning: exported method Int16.Size should have comment or be unexported (golint)
  • Line 611: warning: exported method Int8.Size should have comment or be unexported (golint)
  • Line 623: warning: exported method Uint64.Size should have comment or be unexported (golint)
  • Line 635: warning: exported method Uint32.Size should have comment or be unexported (golint)
  • Line 647: warning: exported method Uint16.Size should have comment or be unexported (golint)
  • Line 659: warning: exported method Uint8.Size should have comment or be unexported (golint)
  • Line 671: warning: exported method String.Size should have comment or be unexported (golint)
  • Line 688: warning: exported method Decimal.Unmarshal should have comment or be unexported (golint)
  • Line 872: warning: exported method Bool.Unmarshal should have comment or be unexported (golint)
  • Line 966: warning: exported method Float64.Unmarshal should have comment or be unexported (golint)
  • Line 1051: warning: exported method Int64.Unmarshal should have comment or be unexported (golint)
  • Line 1144: warning: exported method Int32.Unmarshal should have comment or be unexported (golint)
  • Line 1237: warning: exported method Int16.Unmarshal should have comment or be unexported (golint)
  • Line 1330: warning: exported method Int8.Unmarshal should have comment or be unexported (golint)
  • Line 1423: warning: exported method Uint64.Unmarshal should have comment or be unexported (golint)
  • Line 1516: warning: exported method Uint32.Unmarshal should have comment or be unexported (golint)
  • Line 1609: warning: exported method Uint16.Unmarshal should have comment or be unexported (golint)
  • Line 1702: warning: exported method Uint8.Unmarshal should have comment or be unexported (golint)
  • Line 1795: warning: exported method String.Unmarshal should have comment or be unexported (golint)
  • Line 1901: warning: exported method Time.Unmarshal should have comment or be unexported (golint)
  • Line 2021: warning: exported var ErrInvalidLengthNull should have comment or be unexported (golint)

• pkg/sql/ddl/foreign_key.go
  • Line 336: warning: comment on exported method KeyRelationShips.IsOneToOne should be of the form "IsOneToOne ..." (golint)
  • Line 497: warning: exported function DisableForeignKeys should have comment or be unexported (golint)

• pkg/sql/urlvalues/pager.go
  • Line 8: warning: exported type Pager should have comment or be unexported (golint)
  • Line 20: warning: exported function NewPager should have comment or be unexported (golint)
  • Line 26: warning: exported method Pager.FromValues should have comment or be unexported (golint)
  • Line 56: warning: exported method Pager.GetLimit should have comment or be unexported (golint)
  • Line 74: warning: exported method Pager.GetOffset should have comment or be unexported (golint)
  • Line 84: warning: exported method Pager.Pagination should have comment or be unexported (golint)

• pkg/net/auth/options_generic.go
  • Line 147: warning: comment on exported function WithTraceAttributes should be of the form "WithTraceAttributes ..." (golint)

• pkg/i18n/locale.go
  • Line 28: warning: comment on exported var LocaleAvailable should be of the form "LocaleAvailable ..." (golint)
  • Line 31: warning: comment on exported var LocaleSupported should be of the form "LocaleSupported ..." (golint)
  • Line 84: warning: comment on exported function GetLocaleTag should be of the form "GetLocaleTag ..." (golint)

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pkg/store/entities_extended.go
  • Line 154: warning: cyclomatic complexity 18 of function init() is high (> 15) (gocyclo)

• pkg/customer/custattr/address_test.go
  • Line 114: warning: cyclomatic complexity 21 of function (siCustomerAddressAttribute).ByID() is high (> 15) (gocyclo)
  • Line 160: warning: cyclomatic complexity 21 of function (siCustomerAddressAttribute).ByCode() is high (> 15) (gocyclo)

• pkg/net/jwt/service_mw_runmode.go
  • Line 45: warning: cyclomatic complexity 17 of function (*Service).WithRunMode() is high (> 15) (gocyclo)

• pkg/net/runmode/middleware.go
  • Line 124: warning: cyclomatic complexity 17 of function WithRunMode() is high (> 15) (gocyclo)

• pkg/sql/dml/select.go
  • Line 366: warning: cyclomatic complexity 29 of function (*Select).toSQL() is high (> 15) (gocyclo)

• pkg/sql/urlvalues/url_filter.go
  • Line 106: warning: cyclomatic complexity 19 of function addOperator() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/binlog_main.go
  • Line 48: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• pkg/util/byteconv/int.go
  • Line 73: warning: cyclomatic complexity 20 of function LenInt() is high (> 15) (gocyclo)

• pkg/util/translit/translit.go
  • Line 53: warning: cyclomatic complexity 17 of function URL() is high (> 15) (gocyclo)

• pkg/net/jwt/backendjwt/options.go
  • Line 28: warning: cyclomatic complexity 17 of function (*Configuration).PrepareOptionFactory() is high (> 15) (gocyclo)

• pkg/storage/null/null.enc.go
  • Line 688: warning: cyclomatic complexity 53 of function (*Decimal).Unmarshal() is high (> 15) (gocyclo)
  • Line 1914: warning: cyclomatic complexity 31 of function skipNull() is high (> 15) (gocyclo)
  • Line 1795: warning: cyclomatic complexity 29 of function (*String).Unmarshal() is high (> 15) (gocyclo)
  • Line 1144: warning: cyclomatic complexity 26 of function (*Int32).Unmarshal() is high (> 15) (gocyclo)
  • Line 1516: warning: cyclomatic complexity 26 of function (*Uint32).Unmarshal() is high (> 15) (gocyclo)
  • Line 1237: warning: cyclomatic complexity 26 of function (*Int16).Unmarshal() is high (> 15) (gocyclo)
  • Line 1702: warning: cyclomatic complexity 26 of function (*Uint8).Unmarshal() is high (> 15) (gocyclo)
  • Line 872: warning: cyclomatic complexity 26 of function (*Bool).Unmarshal() is high (> 15) (gocyclo)
  • Line 1423: warning: cyclomatic complexity 26 of function (*Uint64).Unmarshal() is high (> 15) (gocyclo)
  • Line 1330: warning: cyclomatic complexity 26 of function (*Int8).Unmarshal() is high (> 15) (gocyclo)
  • Line 1051: warning: cyclomatic complexity 26 of function (*Int64).Unmarshal() is high (> 15) (gocyclo)
  • Line 1609: warning: cyclomatic complexity 26 of function (*Uint16).Unmarshal() is high (> 15) (gocyclo)
  • Line 966: warning: cyclomatic complexity 23 of function (*Float64).Unmarshal() is high (> 15) (gocyclo)

• pkg/sql/dml/condition.go
  • Line 879: warning: cyclomatic complexity 63 of function (Conditions).write() is high (> 15) (gocyclo)
  • Line 76: warning: cyclomatic complexity 24 of function (Op).write() is high (> 15) (gocyclo)
  • Line 1129: warning: cyclomatic complexity 19 of function (Conditions).writeOnDuplicateKey() is high (> 15) (gocyclo)

• pkg/sql/dml/insert.go
  • Line 227: warning: cyclomatic complexity 32 of function (*Insert).toSQL() is high (> 15) (gocyclo)

• pkg/sync/bgwork/auto_scaling.go
  • Line 170: warning: cyclomatic complexity 16 of function AutoScaling() is high (> 15) (gocyclo)

• pkg/util/byteconv/uint.go
  • Line 26: warning: cyclomatic complexity 28 of function ParseUint() is high (> 15) (gocyclo)

• pkg/sql/dml/mapper_pub_test.go
  • Line 104: warning: cyclomatic complexity 26 of function (*baseTest).MapColumns() is high (> 15) (gocyclo)

• pkg/util/pseudo/fake.go
  • Line 408: warning: cyclomatic complexity 73 of function (*Service).getValue() is high (> 15) (gocyclo)
  • Line 694: warning: cyclomatic complexity 21 of function (*Service).setDataWithTag() is high (> 15) (gocyclo)

• pkg/util/pseudo/geo_test.go
  • Line 9: warning: cyclomatic complexity 22 of function TestGeo() is high (> 15) (gocyclo)

• pkg/store/options_import.go
  • Line 46: warning: cyclomatic complexity 16 of function WithLoadFromYAML() is high (> 15) (gocyclo)

• pkg/net/csgrpc/auth/service.go
  • Line 75: warning: cyclomatic complexity 21 of function WithBasicAuth() is high (> 15) (gocyclo)

• pkg/sql/dmltest/csv.go
  • Line 83: warning: cyclomatic complexity 17 of function LoadCSV() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/json_binary.go
  • Line 96: warning: cyclomatic complexity 17 of function (*jsonBinaryDecoder).decodeValue() is high (> 15) (gocyclo)
  • Line 137: warning: cyclomatic complexity 17 of function (*jsonBinaryDecoder).decodeObjectOrArray() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/parser.go
  • Line 197: warning: cyclomatic complexity 26 of function (*BinlogParser).parseEvent() is high (> 15) (gocyclo)

• pkg/sql/dml/benchmark_test.go
  • Line 116: warning: cyclomatic complexity 18 of function encodePlaceholder() is high (> 15) (gocyclo)

• pkg/util/strs/strings.go
  • Line 192: warning: cyclomatic complexity 21 of function LintName() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/const.go
  • Line 90: warning: cyclomatic complexity 42 of function (EventType).String() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/binlogsyncer.go
  • Line 196: warning: cyclomatic complexity 28 of function (*BinlogSyncer).registerSlave() is high (> 15) (gocyclo)
  • Line 636: warning: cyclomatic complexity 23 of function (*BinlogSyncer).onStream() is high (> 15) (gocyclo)
  • Line 728: warning: cyclomatic complexity 21 of function (*BinlogSyncer).parseEvent() is high (> 15) (gocyclo)

• pkg/store/service.go
  • Line 214: warning: cyclomatic complexity 27 of function (*Service).validate() is high (> 15) (gocyclo)
  • Line 303: warning: cyclomatic complexity 24 of function (*Service).IsAllowedStoreID() is high (> 15) (gocyclo)
  • Line 456: warning: cyclomatic complexity 22 of function (*Service).StoreIDbyCode() is high (> 15) (gocyclo)
  • Line 142: warning: cyclomatic complexity 18 of function (*Service).apply2ndLevelData() is high (> 15) (gocyclo)
  • Line 390: warning: cyclomatic complexity 17 of function (*Service).DefaultStoreID() is high (> 15) (gocyclo)

• pkg/config/route_trie.go
  • Line 187: warning: cyclomatic complexity 19 of function (*trieRoute).process() is high (> 15) (gocyclo)

• pkg/net/url/connection.go
  • Line 51: warning: cyclomatic complexity 17 of function ParseConnection() is high (> 15) (gocyclo)

• pkg/util/byteconv/float.go
  • Line 46: warning: cyclomatic complexity 32 of function ParseFloat() is high (> 15) (gocyclo)

• pkg/config/observer/validator_easyjson.go
  • Line 18: warning: cyclomatic complexity 20 of function easyjson32b9832cDecodeGithubComCorestoreioPkgConfigObserver() is high (> 15) (gocyclo)

• pkg/config/path.go
  • Line 407: warning: cyclomatic complexity 21 of function (Path).IsValid() is high (> 15) (gocyclo)

• pkg/sql/dml/dbr.go
  • Line 422: warning: cyclomatic complexity 46 of function (*DBR).prepareQueryAndArgs() is high (> 15) (gocyclo)
  • Line 569: warning: cyclomatic complexity 27 of function (*DBR).appendConvertedRecordsToArguments() is high (> 15) (gocyclo)
  • Line 669: warning: cyclomatic complexity 24 of function (*DBR).prepareQueryAndArgsInsert() is high (> 15) (gocyclo)

• pkg/sql/dml/interpolate.go
  • Line 447: warning: cyclomatic complexity 18 of function isEmoji() is high (> 15) (gocyclo)
  • Line 323: warning: cyclomatic complexity 16 of function writeInterpolateBytes() is high (> 15) (gocyclo)

• pkg/sql/dml/select_pub_test.go
  • Line 516: warning: cyclomatic complexity 18 of function TestSelect_Argument_Iterate() is high (> 15) (gocyclo)

• pkg/sql/ddl/columns.go
  • Line 362: warning: cyclomatic complexity 22 of function newColumn() is high (> 15) (gocyclo)
  • Line 432: warning: cyclomatic complexity 17 of function (*Column).GoString() is high (> 15) (gocyclo)

• pkg/locale/format.go
  • Line 35: warning: cyclomatic complexity 21 of function ExtractNumber() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/row_event.go
  • Line 366: warning: cyclomatic complexity 38 of function (*RowsEvent).decodeValue() is high (> 15) (gocyclo)

• pkg/net/cors/utils.go
  • Line 48: warning: cyclomatic complexity 16 of function parseHeaderList() is high (> 15) (gocyclo)

• pkg/util/validation/validator.go
  • Line 761: warning: cyclomatic complexity 17 of function IsHash() is high (> 15) (gocyclo)
  • Line 452: warning: cyclomatic complexity 16 of function isUUIDvX() is high (> 15) (gocyclo)

• pkg/i18n/number.go
  • Line 222: warning: cyclomatic complexity 31 of function (*Number).FmtNumber() is high (> 15) (gocyclo)
  • Line 489: warning: cyclomatic complexity 18 of function (*format).parse() is high (> 15) (gocyclo)

• pkg/config/service.go
  • Line 378: warning: cyclomatic complexity 19 of function (*Service).Get() is high (> 15) (gocyclo)

• pkg/sql/dml/delete.go
  • Line 180: warning: cyclomatic complexity 16 of function (*Delete).toSQL() is high (> 15) (gocyclo)

• pkg/net/signed/header_signature.go
  • Line 99: warning: cyclomatic complexity 21 of function (*ContentSignature).Parse() is high (> 15) (gocyclo)

• pkg/util/conv/caste.go
  • Line 235: warning: cyclomatic complexity 28 of function ToUintE() is high (> 15) (gocyclo)
  • Line 78: warning: cyclomatic complexity 26 of function ToBoolE() is high (> 15) (gocyclo)
  • Line 400: warning: cyclomatic complexity 26 of function ToStringE() is high (> 15) (gocyclo)
  • Line 519: warning: cyclomatic complexity 19 of function ToStringMapStringSliceE() is high (> 15) (gocyclo)
  • Line 303: warning: cyclomatic complexity 19 of function ToInt64E() is high (> 15) (gocyclo)
  • Line 152: warning: cyclomatic complexity 18 of function ToFloat64E() is high (> 15) (gocyclo)

• pkg/sql/myreplicator/backup.go
  • Line 17: warning: cyclomatic complexity 22 of function (*BinlogSyncer).StartBackup() is high (> 15) (gocyclo)

• pkg/util/pseudo/names_test.go
  • Line 9: warning: cyclomatic complexity 16 of function TestNames() is high (> 15) (gocyclo)

• pkg/storage/null/benchmark_test.go
  • Line 27: warning: cyclomatic complexity 16 of function BenchmarkSQLScanner() is high (> 15) (gocyclo)

• pkg/sql/dml/argument.go
  • Line 115: warning: cyclomatic complexity 103 of function writeInterfaceValue() is high (> 15) (gocyclo)
  • Line 452: warning: cyclomatic complexity 85 of function expandInterface() is high (> 15) (gocyclo)
  • Line 745: warning: cyclomatic complexity 21 of function iFaceToArgs() is high (> 15) (gocyclo)
  • Line 652: warning: cyclomatic complexity 17 of function driverValue() is high (> 15) (gocyclo)
  • Line 62: warning: cyclomatic complexity 17 of function sliceLen() is high (> 15) (gocyclo)

• pkg/sql/mycanal/sync.go
  • Line 91: warning: cyclomatic complexity 22 of function (*Canal).startSyncBinlog() is high (> 15) (gocyclo)

• pkg/sql/ddl/table.go
  • Line 463: warning: cyclomatic complexity 29 of function (*Table).LoadDataInfile() is high (> 15) (gocyclo)
  • Line 119: warning: cyclomatic complexity 25 of function newTable() is high (> 15) (gocyclo)

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• pkg/storage/null/easyjson_easyjson_test.go
  • Line 70: warning: ineffectual assignment to first (ineffassign)

• pkg/sql/dml/dbr.go
  • Line 1222: warning: ineffectual assignment to rowCount (ineffassign)
  • Line 1259: warning: ineffectual assignment to rowCount (ineffassign)
  • Line 1329: warning: ineffectual assignment to rowCount (ineffassign)

• pkg/config/observer/json_easyjson.go
  • Line 86: warning: ineffectual assignment to first (ineffassign)
  • Line 210: warning: ineffectual assignment to first (ineffassign)

• pkg/config/observer/modifier_easyjson.go
  • Line 78: warning: ineffectual assignment to first (ineffassign)

• pkg/sql/myreplicator/replication_test.go
  • Line 360: warning: ineffectual assignment to ok (ineffassign)

• pkg/sql/myreplicator/row_event.go
  • Line 767: warning: ineffectual assignment to frac (ineffassign)
  • Line 821: warning: ineffectual assignment to hms (ineffassign)

• pkg/util/strs/ww.go
  • Line 65: warning: ineffectual assignment to current (ineffassign)
  • Line 67: warning: ineffectual assignment to current (ineffassign)
  • Line 72: warning: ineffectual assignment to current (ineffassign)

• pkg/storage/objcache/options.go
  • Line 92: warning: ineffectual assignment to value (ineffassign)

• pkg/net/signed/options_generic.go
  • Line 47: warning: ineffectual assignment to sc (ineffassign)

• pkg/net/cors/options_generic.go
  • Line 47: warning: ineffectual assignment to sc (ineffassign)

• pkg/net/geoip/backendgeoip/options.go
  • Line 53: warning: ineffectual assignment to i (ineffassign)

• pkg/net/geoip/options_generic.go
  • Line 47: warning: ineffectual assignment to sc (ineffassign)

• pkg/net/internal/scopedservice/options_generic.go
  • Line 48: warning: ineffectual assignment to sc (ineffassign)

• pkg/util/byteconv/float.go
  • Line 106: warning: ineffectual assignment to i (ineffassign)

• pkg/sql/dml/dbr_test.go
  • Line 285: warning: ineffectual assignment to nextUnnamedArgPos (ineffassign)

• pkg/net/jwt/options_generic.go
  • Line 47: warning: ineffectual assignment to sc (ineffassign)

• pkg/config/observer/validator_easyjson.go
  • Line 156: warning: ineffectual assignment to first (ineffassign)
  • Line 280: warning: ineffectual assignment to first (ineffassign)

• pkg/sql/myreplicator/backup.go
  • Line 20: warning: ineffectual assignment to timeout (ineffassign)

• pkg/net/auth/options_generic.go
  • Line 48: warning: ineffectual assignment to sc (ineffassign)

• pkg/store/service_server.proto_test.go
  • Line 85: warning: ineffectual assignment to err (ineffassign)

• pkg/sql/myreplicator/event.go
  • Line 92: warning: ineffectual assignment to pos (ineffassign)

• pkg/net/ratelimit/options_generic.go
  • Line 47: warning: ineffectual assignment to sc (ineffassign)

• pkg/sql/migration/run.go
  • Line 22: warning: ineffectual assignment to err (ineffassign)

• pkg/storage/objcache/file.go
  • Line 203: warning: ineffectual assignment to err (ineffassign)

• pkg/net/signed/backendsigned/options.go
  • Line 90: warning: ineffectual assignment to i (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!