gofmt86%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• flink-on-k8s-operator/controllers/flinkcluster_converter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• flink-on-k8s-operator/controllers/flinkcluster_observer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• flink-on-k8s-operator/controllers/model/model.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• flink-on-k8s-operator/controllers/batchscheduler/volcano/volcano_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• flink-on-k8s-operator/controllers/flinkcluster_converter.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo80%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• flink-on-k8s-operator/api/v1beta1/zz_generated.deepcopy.go
  • Line 557: warning: cyclomatic complexity 24 of function (*JobSpec).DeepCopyInto() is high (> 15) (gocyclo)
  • Line 458: warning: cyclomatic complexity 22 of function (*JobManagerSpec).DeepCopyInto() is high (> 15) (gocyclo)
  • Line 748: warning: cyclomatic complexity 20 of function (*TaskManagerSpec).DeepCopyInto() is high (> 15) (gocyclo)
  • Line 169: warning: cyclomatic complexity 16 of function (*FlinkClusterSpec).DeepCopyInto() is high (> 15) (gocyclo)

• flink-on-k8s-operator/api/v1beta1/flinkcluster_validate.go
  • Line 285: warning: cyclomatic complexity 16 of function (*Validator).validateJobManager() is high (> 15) (gocyclo)
  • Line 114: warning: cyclomatic complexity 16 of function (*Validator).checkControlAnnotations() is high (> 15) (gocyclo)

• flink-on-k8s-operator/controllers/flinkcluster_updater.go
  • Line 188: warning: cyclomatic complexity 146 of function (*ClusterStatusUpdater).deriveClusterStatus() is high (> 15) (gocyclo)
  • Line 693: warning: cyclomatic complexity 25 of function (*ClusterStatusUpdater).getJobStatus() is high (> 15) (gocyclo)
  • Line 777: warning: cyclomatic complexity 21 of function (*ClusterStatusUpdater).isStatusChanged() is high (> 15) (gocyclo)
  • Line 87: warning: cyclomatic complexity 20 of function (*ClusterStatusUpdater).createStatusChangeEvents() is high (> 15) (gocyclo)

• flink-on-k8s-operator/controllers/flinkcluster_reconciler.go
  • Line 446: warning: cyclomatic complexity 23 of function (*ClusterReconciler).reconcileJob() is high (> 15) (gocyclo)

• flink-on-k8s-operator/controllers/flinkcluster_converter.go
  • Line 595: warning: cyclomatic complexity 20 of function getDesiredJob() is high (> 15) (gocyclo)

• flink-on-k8s-operator/controllers/flinkcluster_util.go
  • Line 430: warning: cyclomatic complexity 17 of function isComponentUpdated() is high (> 15) (gocyclo)

• flink-on-k8s-operator/controllers/flinkcluster_observer.go
  • Line 206: warning: cyclomatic complexity 17 of function (*ClusterStateObserver).observeJob() is high (> 15) (gocyclo)
  • Line 81: warning: cyclomatic complexity 16 of function (*ClusterStateObserver).observe() is high (> 15) (gocyclo)

golint69%

Golint is a linter for Go source code.

• flink-on-k8s-operator/controllers/history/controller_history.go
  • Line 46: warning: exported const ControllerRevisionManagedByLabel should have comment or be unexported (golint)
  • Line 204: warning: context.Context should be the first parameter of a function (golint)
  • Line 346: warning: exported function DeepHashObject should have comment or be unexported (golint)

• flink-on-k8s-operator/controllers/flinkclient/flink_client.go
  • Line 79: warning: exported method SavepointStatus.IsSuccessful should have comment or be unexported (golint)
  • Line 83: warning: exported method SavepointStatus.IsFailed should have comment or be unexported (golint)
  • Line 208: warning: exported method FlinkClient.TakeSavepointAsync should have comment or be unexported (golint)

• flink-on-k8s-operator/controllers/batchscheduler/factory.go
  • Line 51: warning: exported function GetRegisteredNames should have comment or be unexported (golint)

• flink-on-k8s-operator/controllers/batchscheduler/volcano/volcano.go
  • Line 39: warning: comment on exported type VolcanoBatchScheduler should be of the form "VolcanoBatchScheduler ..." (with optional leading article) (golint)
  • Line 44: warning: comment on exported function New should be of the form "New ..." (golint)

• flink-on-k8s-operator/api/v1beta1/flinkcluster_validate.go
  • Line 32: warning: exported const InvalidControlAnnMsg should have comment (or a comment on this block) or be unexported (golint)

• flink-on-k8s-operator/controllers/flinkcluster_converter.go
  • Line 828: warning: comment on exported function ToOwnerReference should be of the form "ToOwnerReference ..." (golint)
  • Line 1091: warning: exported const DefaultLog4jConfig should have comment (or a comment on this block) or be unexported (golint)

• flink-on-k8s-operator/controllers/flinkcluster_observer.go
  • Line 68: warning: exported type FlinkJobStatus should have comment or be unexported (golint)
  • Line 74: warning: exported type FlinkJobSubmitLog should have comment or be unexported (golint)
  • Line 526: warning: exported type RevisionStatus should have comment or be unexported (golint)

• flink-on-k8s-operator/controllers/flinkcluster_reconciler.go
  • Line 711: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• flink-on-k8s-operator/controllers/flinkcluster_util.go
  • Line 40: warning: exported const ControlSavepointTriggerID should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: comment on exported const SavepointAgeForJobUpdateSec should be of the form "SavepointAgeForJobUpdateSec ..." (golint)
  • Line 54: warning: exported type UpdateState should have comment or be unexported (golint)
  • Line 57: warning: exported const UpdateStatePreparing should have comment (or a comment on this block) or be unexported (golint)

• flink-on-k8s-operator/controllers/flinkclient/http_client.go
  • Line 34: warning: exported type HTTPError should have comment or be unexported (golint)

• flink-on-k8s-operator/api/v1beta1/flinkcluster_types.go
  • Line 532: warning: comment on exported type FlinkClusterControlStatus should be of the form "FlinkClusterControlStatus ..." (with optional leading article) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign88%

IneffAssign detects ineffectual assignments in Go code.

• flink-on-k8s-operator/controllers/flinkcluster_util_test.go
  • Line 615: warning: ineffectual assignment to submit (ineffassign)
  • Line 626: warning: ineffectual assignment to submit (ineffassign)

• flink-on-k8s-operator/controllers/batchscheduler/volcano/volcano.go
  • Line 131: warning: ineffectual assignment to err (ineffassign)
  • Line 135: warning: ineffectual assignment to err (ineffassign)

• flink-on-k8s-operator/controllers/flinkcluster_observer.go
  • Line 128: warning: ineffectual assignment to observedConfigMap (ineffassign)
  • Line 143: warning: ineffectual assignment to observedJmStatefulSet (ineffassign)
  • Line 158: warning: ineffectual assignment to observedJmService (ineffassign)
  • Line 173: warning: ineffectual assignment to observedJmIngress (ineffassign)
  • Line 188: warning: ineffectual assignment to observedTmStatefulSet (ineffassign)

• flink-on-k8s-operator/controllers/flinkcluster_reconciler.go
  • Line 111: warning: ineffectual assignment to err (ineffassign)

misspell91%

Misspell Finds commonly misspelled English words

• flink-on-k8s-operator/controllers/flinkclient/flink_client.go
  • Line 185: warning: "suceeds" is a misspelling of "succeeds" (misspell)

• flink-on-k8s-operator/api/v1beta1/flinkcluster_types_test.go
  • Line 45: warning: "additonal" is a misspelling of "additional" (misspell)

• flink-on-k8s-operator/controllers/flinkcluster_util.go
  • Line 328: warning: "Succesfully" is a misspelling of "Successfully" (misspell)
  • Line 512: warning: "emtpy" is a misspelling of "empty" (misspell)