Report for github.com/armon/go-metrics
A Great! Found 15 issues across 24 files
gofmt91%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go-metrics/prometheus/prometheus_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
go-metrics/inmem_endpoint_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint62%
Golint is a linter for Go source code.
-
-
go-metrics/inmem.go
- Line 83: warning: comment on exported method AggregateSample.Stddev should be of the form "Stddev ..." (golint)
- Line 93: warning: comment on exported method AggregateSample.Mean should be of the form "Mean ..." (golint)
- Line 159: warning: exported method InmemSink.SetGauge should have comment or be unexported (golint)
- Line 163: warning: exported method InmemSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 172: warning: exported method InmemSink.EmitKey should have comment or be unexported (golint)
- Line 182: warning: exported method InmemSink.IncrCounter should have comment or be unexported (golint)
- Line 186: warning: exported method InmemSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 205: warning: exported method InmemSink.AddSample should have comment or be unexported (golint)
- Line 209: warning: exported method InmemSink.AddSampleWithLabels should have comment or be unexported (golint)
-
-
go-metrics/inmem_endpoint.go
- Line 19: warning: exported type GaugeValue should have comment or be unexported (golint)
- Line 28: warning: exported type PointValue should have comment or be unexported (golint)
- Line 33: warning: exported type SampledValue should have comment or be unexported (golint)
-
-
go-metrics/metrics.go
- Line 11: warning: exported type Label should have comment or be unexported (golint)
- Line 16: warning: exported method Metrics.SetGauge should have comment or be unexported (golint)
- Line 20: warning: exported method Metrics.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 45: warning: exported method Metrics.EmitKey should have comment or be unexported (golint)
- Line 59: warning: exported method Metrics.IncrCounter should have comment or be unexported (golint)
- Line 63: warning: exported method Metrics.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 84: warning: exported method Metrics.AddSample should have comment or be unexported (golint)
- Line 88: warning: exported method Metrics.AddSampleWithLabels should have comment or be unexported (golint)
- Line 109: warning: exported method Metrics.MeasureSince should have comment or be unexported (golint)
- Line 113: warning: exported method Metrics.MeasureSinceWithLabels should have comment or be unexported (golint)
- Line 235: warning: comment on exported method Metrics.EmitRuntimeStats should be of the form "EmitRuntimeStats ..." (golint)
-
-
go-metrics/sink.go
- Line 30: warning: exported method BlackholeSink.SetGauge should have comment or be unexported (golint)
- Line 31: warning: exported method BlackholeSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 32: warning: exported method BlackholeSink.EmitKey should have comment or be unexported (golint)
- Line 33: warning: exported method BlackholeSink.IncrCounter should have comment or be unexported (golint)
- Line 34: warning: exported method BlackholeSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 35: warning: exported method BlackholeSink.AddSample should have comment or be unexported (golint)
- Line 36: warning: exported method BlackholeSink.AddSampleWithLabels should have comment or be unexported (golint)
- Line 41: warning: exported method FanoutSink.SetGauge should have comment or be unexported (golint)
- Line 45: warning: exported method FanoutSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 51: warning: exported method FanoutSink.EmitKey should have comment or be unexported (golint)
- Line 57: warning: exported method FanoutSink.IncrCounter should have comment or be unexported (golint)
- Line 61: warning: exported method FanoutSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 67: warning: exported method FanoutSink.AddSample should have comment or be unexported (golint)
- Line 71: warning: exported method FanoutSink.AddSampleWithLabels should have comment or be unexported (golint)
-
-
go-metrics/start.go
- Line 99: warning: comment on exported function SetGauge should be of the form "SetGauge ..." (golint)
- Line 104: warning: exported function SetGaugeWithLabels should have comment or be unexported (golint)
- Line 108: warning: exported function EmitKey should have comment or be unexported (golint)
- Line 112: warning: exported function IncrCounter should have comment or be unexported (golint)
- Line 116: warning: exported function IncrCounterWithLabels should have comment or be unexported (golint)
- Line 120: warning: exported function AddSample should have comment or be unexported (golint)
- Line 124: warning: exported function AddSampleWithLabels should have comment or be unexported (golint)
- Line 128: warning: exported function MeasureSince should have comment or be unexported (golint)
- Line 132: warning: exported function MeasureSinceWithLabels should have comment or be unexported (golint)
- Line 136: warning: exported function UpdateFilter should have comment or be unexported (golint)
-
-
go-metrics/statsd.go
- Line 43: warning: comment on exported method StatsdSink.Shutdown should be of the form "Shutdown ..." (golint)
- Line 48: warning: exported method StatsdSink.SetGauge should have comment or be unexported (golint)
- Line 53: warning: exported method StatsdSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 58: warning: exported method StatsdSink.EmitKey should have comment or be unexported (golint)
- Line 63: warning: exported method StatsdSink.IncrCounter should have comment or be unexported (golint)
- Line 68: warning: exported method StatsdSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 73: warning: exported method StatsdSink.AddSample should have comment or be unexported (golint)
- Line 78: warning: exported method StatsdSink.AddSampleWithLabels should have comment or be unexported (golint)
-
-
go-metrics/statsite.go
- Line 43: warning: comment on exported method StatsiteSink.Shutdown should be of the form "Shutdown ..." (golint)
- Line 48: warning: exported method StatsiteSink.SetGauge should have comment or be unexported (golint)
- Line 53: warning: exported method StatsiteSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 58: warning: exported method StatsiteSink.EmitKey should have comment or be unexported (golint)
- Line 63: warning: exported method StatsiteSink.IncrCounter should have comment or be unexported (golint)
- Line 68: warning: exported method StatsiteSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 73: warning: exported method StatsiteSink.AddSample should have comment or be unexported (golint)
- Line 78: warning: exported method StatsiteSink.AddSampleWithLabels should have comment or be unexported (golint)
-
-
go-metrics/datadog/dogstatsd.go
- Line 40: warning: comment on exported method DogStatsdSink.EnableHostNamePropagation should be of the form "EnableHostNamePropagation ..." (golint)
- Line 86: warning: exported method DogStatsdSink.SetGauge should have comment or be unexported (golint)
- Line 90: warning: exported method DogStatsdSink.IncrCounter should have comment or be unexported (golint)
- Line 99: warning: exported method DogStatsdSink.AddSample should have comment or be unexported (golint)
- Line 103: warning: comment on exported method DogStatsdSink.SetGaugeWithLabels should be of the form "SetGaugeWithLabels ..." (golint)
- Line 111: warning: exported method DogStatsdSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 117: warning: exported method DogStatsdSink.AddSampleWithLabels should have comment or be unexported (golint)
-
-
go-metrics/prometheus/prometheus.go
- Line 53: warning: exported type PrometheusSink should have comment or be unexported (golint)
- Line 260: warning: exported method PrometheusSink.SetGauge should have comment or be unexported (golint)
- Line 264: warning: exported method PrometheusSink.SetGaugeWithLabels should have comment or be unexported (golint)
- Line 302: warning: exported method PrometheusSink.AddSample should have comment or be unexported (golint)
- Line 306: warning: exported method PrometheusSink.AddSampleWithLabels should have comment or be unexported (golint)
- Line 347: warning: exported method PrometheusSink.IncrCounter should have comment or be unexported (golint)
- Line 351: warning: exported method PrometheusSink.IncrCounterWithLabels should have comment or be unexported (golint)
- Line 436: warning: exported method PrometheusPushSink.Shutdown should have comment or be unexported (golint)
gocyclo79%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-metrics/metrics_test.go
- Line 239: warning: cyclomatic complexity 28 of function TestMetrics_EmitRuntimeStats() is high (> 15) (gocyclo)
-
-
go-metrics/inmem_test.go
- Line 11: warning: cyclomatic complexity 23 of function TestInmemSink() is high (> 15) (gocyclo)
-
-
go-metrics/statsd_test.go
- Line 40: warning: cyclomatic complexity 20 of function TestStatsd_Conn() is high (> 15) (gocyclo)
-
-
go-metrics/statsite_test.go
- Line 39: warning: cyclomatic complexity 19 of function TestStatsite_Conn() is high (> 15) (gocyclo)
-
-
go-metrics/prometheus/prometheus_test.go
- Line 58: warning: cyclomatic complexity 19 of function TestDefinitions() is high (> 15) (gocyclo)
ineffassign91%
IneffAssign detects ineffectual assignments in Go code.
-
-
go-metrics/prometheus/prometheus_test.go
- Line 233: warning: ineffectual assignment to err (ineffassign)
-
-
go-metrics/metrics_test.go
- Line 461: warning: ineffectual assignment to key (ineffassign)
- Line 508: warning: ineffectual assignment to key (ineffassign)