Report for github.com/attic-labs/noms
A+ Excellent! Found 110 issues across 358 files
gofmt98%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
noms/go/marshal/encode_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
noms/cmd/noms/splore/out.js.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
noms/samples/go/csv/csv-import/importer.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
noms/samples/go/decent/lib/model_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
noms/samples/go/nomdex/nomdex_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
noms/go/marshal/decode_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint72%
Golint is a linter for Go source code.
-
-
noms/go/spec/spec.go
- Line 28: warning: exported const Separator should have comment or be unexported (golint)
- Line 32: warning: exported var GetAWSSession should have comment or be unexported (golint)
- Line 36: warning: exported type ProtocolImpl should have comment or be unexported (golint)
- Line 41: warning: exported var ExternalProtocols should have comment or be unexported (golint)
- Line 243: warning: exported method Spec.Close should have comment or be unexported (golint)
-
-
noms/go/types/path.go
- Line 33: warning: exported type PathPart should have comment or be unexported (golint)
- Line 163: warning: exported method Path.Equals should have comment or be unexported (golint)
- Line 190: warning: exported method Path.IsEmpty should have comment or be unexported (golint)
- Line 200: warning: exported function NewFieldPath should have comment or be unexported (golint)
- Line 204: warning: exported method FieldPath.Resolve should have comment or be unexported (golint)
- Line 238: warning: exported function NewIndexPath should have comment or be unexported (golint)
- Line 242: warning: exported function NewIndexIntoKeyPath should have comment or be unexported (golint)
- Line 246: warning: exported function ValueCanBePathIndex should have comment or be unexported (golint)
- Line 256: warning: exported method IndexPath.Resolve should have comment or be unexported (golint)
- Line 308: warning: comment on exported type HashIndexPath should be of the form "HashIndexPath ..." (with optional leading article) (golint)
- Line 322: warning: exported function NewHashIndexPath should have comment or be unexported (golint)
- Line 326: warning: exported function NewHashIndexIntoKeyPath should have comment or be unexported (golint)
- Line 335: warning: exported method HashIndexPath.Resolve should have comment or be unexported (golint)
- Line 380: warning: comment on exported function ParsePathIndex should be of the form "ParsePathIndex ..." (golint)
- Line 448: warning: exported method TypeAnnotation.Resolve should have comment or be unexported (golint)
- Line 460: warning: exported method TargetAnnotation.Resolve should have comment or be unexported (golint)
- Line 466: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 486: warning: exported function NewAtAnnotation should have comment or be unexported (golint)
- Line 490: warning: exported function NewAtAnnotationIntoKeyPath should have comment or be unexported (golint)
- Line 494: warning: exported method AtAnnotation.Resolve should have comment or be unexported (golint)
-
-
noms/go/types/value_store.go
- Line 60: warning: exported function PanicIfDangling should have comment or be unexported (golint)
- Line 108: warning: exported method ValueStore.SetEnforceCompleteness should have comment or be unexported (golint)
- Line 112: warning: exported method ValueStore.ChunkStore should have comment or be unexported (golint)
- Line 304: warning: exported method ValueStore.Root should have comment or be unexported (golint)
- Line 308: warning: exported method ValueStore.Rebase should have comment or be unexported (golint)
- Line 312: warning: comment on exported method ValueStore.Commit should be of the form "Commit ..." (golint)
-
-
noms/go/d/check_error.go
- Line 15: warning: exported function CheckError should have comment or be unexported (golint)
- Line 23: warning: exported function CheckErrorNoUsage should have comment or be unexported (golint)
-
-
noms/go/chunks/chunk.go
- Line 21: warning: exported var EmptyChunk should have comment or be unexported (golint)
- Line 23: warning: exported method Chunk.Hash should have comment or be unexported (golint)
- Line 27: warning: exported method Chunk.Data should have comment or be unexported (golint)
- Line 31: warning: exported method Chunk.IsEmpty should have comment or be unexported (golint)
- Line 52: warning: exported function NewChunkWriter should have comment or be unexported (golint)
- Line 68: warning: comment on exported method ChunkWriter.Chunk should be of the form "Chunk ..." (golint)
- Line 74: warning: comment on exported method ChunkWriter.Close should be of the form "Close ..." (golint)
-
-
noms/go/diff/diff.go
- Line 32: warning: exported method Difference.IsEmpty should have comment or be unexported (golint)
- Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
noms/go/ngql/types.go
- Line 958: warning: exported function MaybeGetScalar should have comment or be unexported (golint)
-
-
noms/samples/go/nomdex/parser.go
- Line 111: warning: exported function NewQueryScanner should have comment or be unexported (golint)
- Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
noms/go/types/list_editor.go
- Line 13: warning: exported type ListEditor should have comment or be unexported (golint)
- Line 18: warning: exported function NewListEditor should have comment or be unexported (golint)
- Line 22: warning: exported method ListEditor.Kind should have comment or be unexported (golint)
- Line 26: warning: exported method ListEditor.Value should have comment or be unexported (golint)
- Line 30: warning: exported method ListEditor.List should have comment or be unexported (golint)
- Line 164: warning: exported method ListEditor.Len should have comment or be unexported (golint)
- Line 173: warning: exported method ListEditor.Splice should have comment or be unexported (golint)
- Line 227: warning: exported method ListEditor.Set should have comment or be unexported (golint)
- Line 231: warning: exported method ListEditor.Append should have comment or be unexported (golint)
- Line 235: warning: exported method ListEditor.Insert should have comment or be unexported (golint)
- Line 239: warning: exported method ListEditor.Remove should have comment or be unexported (golint)
- Line 244: warning: exported method ListEditor.RemoveAt should have comment or be unexported (golint)
- Line 252: warning: exported method ListEditor.Get should have comment or be unexported (golint)
-
-
noms/go/constants/http.go
- Line 8: warning: exported const RootPath should have comment (or a comment on this block) or be unexported (golint)
-
-
noms/go/metrics/histogram.go
- Line 35: warning: exported type ToStringFunc should have comment or be unexported (golint)
- Line 139: warning: exported function NewTimeHistogram should have comment or be unexported (golint)
-
-
noms/go/util/progressreader/reader.go
- Line 15: warning: exported type Callback should have comment or be unexported (golint)
- Line 17: warning: exported function New should have comment or be unexported (golint)
-
-
noms/go/util/outputpager/page_output.go
- Line 23: warning: exported type Pager should have comment or be unexported (golint)
- Line 30: warning: exported function Start should have comment or be unexported (golint)
- Line 61: warning: exported method Pager.Stop should have comment or be unexported (golint)
- Line 80: warning: exported function RegisterOutputpagerFlags should have comment or be unexported (golint)
- Line 84: warning: exported function IsStdoutTty should have comment or be unexported (golint)
-
-
noms/go/datas/database.go
- Line 121: warning: exported function NewDatabase should have comment or be unexported (golint)
-
-
noms/go/hash/hash.go
- Line 117: warning: exported function NewHashSet should have comment or be unexported (golint)
-
-
noms/go/nbs/benchmarks/gen/gen.go
- Line 22: warning: exported const OffsetTupleLen should have comment (or a comment on this block) or be unexported (golint)
- Line 26: warning: exported function OpenOrGenerateDataFile should have comment or be unexported (golint)
- Line 47: warning: exported function OpenOrBuildChunkMap should have comment or be unexported (golint)
-
-
noms/go/config/config.go
- Line 19: warning: exported type Config should have comment or be unexported (golint)
- Line 24: warning: exported type DbConfig should have comment or be unexported (golint)
- Line 29: warning: exported const NomsConfigFile should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: error var NoConfig should have name of the form ErrFoo (golint)
- Line 33: warning: exported var NoConfig should have comment or be unexported (golint)
- Line 33: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 35: warning: comment on exported function FindNomsConfig should be of the form "FindNomsConfig ..." (golint)
- Line 62: warning: exported function ReadConfig should have comment or be unexported (golint)
- Line 75: warning: exported function NewConfig should have comment or be unexported (golint)
- Line 83: warning: exported method Config.WriteTo should have comment or be unexported (golint)
-
-
noms/go/marshal/encode.go
- Line 181: warning: exported type Opt should have comment or be unexported (golint)
-
-
noms/go/datas/http_chunk_store.go
- Line 60: warning: exported function NewHTTPChunkStore should have comment or be unexported (golint)
-
-
noms/go/types/blob_editor.go
- Line 17: warning: exported type BlobEditor should have comment or be unexported (golint)
- Line 23: warning: exported function NewBlobEditor should have comment or be unexported (golint)
- Line 27: warning: exported method BlobEditor.Kind should have comment or be unexported (golint)
- Line 31: warning: exported method BlobEditor.Value should have comment or be unexported (golint)
- Line 35: warning: exported method BlobEditor.Blob should have comment or be unexported (golint)
- Line 134: warning: exported method BlobEditor.Len should have comment or be unexported (golint)
- Line 143: warning: exported method BlobEditor.Splice should have comment or be unexported (golint)
- Line 193: warning: exported method BlobEditor.Seek should have comment or be unexported (golint)
-
-
noms/go/types/set.go
- Line 14: warning: exported type Set should have comment or be unexported (golint)
- Line 22: warning: exported function NewSet should have comment or be unexported (golint)
- Line 107: warning: exported method Set.WalkValues should have comment or be unexported (golint)
- Line 113: warning: exported method Set.First should have comment or be unexported (golint)
- Line 121: warning: exported method Set.At should have comment or be unexported (golint)
- Line 130: warning: exported method Set.Has should have comment or be unexported (golint)
- Line 137: warning: exported method Set.Iter should have comment or be unexported (golint)
- Line 146: warning: exported method Set.IterAll should have comment or be unexported (golint)
- Line 152: warning: exported method Set.Iterator should have comment or be unexported (golint)
- Line 156: warning: exported method Set.IteratorAt should have comment or be unexported (golint)
- Line 163: warning: exported method Set.IteratorFrom should have comment or be unexported (golint)
- Line 170: warning: exported method Set.Edit should have comment or be unexported (golint)
-
-
noms/go/nbs/benchmarks/chunker/main.go
- Line 18: warning: exported const KB should have comment (or a comment on this block) or be unexported (golint)
-
-
noms/go/marshal/decode.go
- Line 86: warning: comment on exported function MustUnmarshal should be of the form "MustUnmarshal ..." (golint)
-
-
noms/go/types/bool.go
- Line 19: warning: exported method Bool.Equals should have comment or be unexported (golint)
- Line 23: warning: exported method Bool.Less should have comment or be unexported (golint)
- Line 30: warning: exported method Bool.Hash should have comment or be unexported (golint)
- Line 34: warning: exported method Bool.WalkValues should have comment or be unexported (golint)
- Line 37: warning: exported method Bool.WalkRefs should have comment or be unexported (golint)
- Line 44: warning: exported method Bool.Kind should have comment or be unexported (golint)
-
-
noms/go/spec/absolute_path.go
- Line 105: warning: exported method AbsolutePath.IsEmpty should have comment or be unexported (golint)
-
-
noms/cmd/noms/commit_iterator.go
- Line 14: warning: exported type CommitIterator should have comment or be unexported (golint)
- Line 80: warning: exported type LogNode should have comment or be unexported (golint)
-
-
noms/go/datas/database_server.go
- Line 25: warning: exported type RemoteDatabaseServer should have comment or be unexported (golint)
- Line 36: warning: exported function NewRemoteDatabaseServer should have comment or be unexported (golint)
- Line 51: warning: exported function Router should have comment or be unexported (golint)
- Line 147: warning: comment on exported method RemoteDatabaseServer.Stop should be of the form "Stop ..." (golint)
-
-
noms/go/types/list.go
- Line 56: warning: exported method List.Edit should have comment or be unexported (golint)
- Line 71: warning: exported method List.WalkValues should have comment or be unexported (golint)
- Line 109: warning: exported method List.IterRange should have comment or be unexported (golint)
-
-
noms/go/types/ref_heap.go
- Line 29: warning: exported method RefByHeight.PushBack should have comment or be unexported (golint)
- Line 33: warning: exported method RefByHeight.PopBack should have comment or be unexported (golint)
- Line 59: warning: exported method RefByHeight.Unique should have comment or be unexported (golint)
- Line 89: warning: exported method RefByHeight.Empty should have comment or be unexported (golint)
-
-
noms/go/chunks/remote_requests.go
- Line 13: warning: exported type ReadRequest should have comment or be unexported (golint)
- Line 18: warning: exported function NewGetRequest should have comment or be unexported (golint)
- Line 22: warning: exported type GetRequest should have comment or be unexported (golint)
- Line 27: warning: exported function NewGetManyRequest should have comment or be unexported (golint)
- Line 31: warning: exported type GetManyRequest should have comment or be unexported (golint)
- Line 37: warning: exported function NewAbsentRequest should have comment or be unexported (golint)
- Line 41: warning: exported type AbsentRequest should have comment or be unexported (golint)
- Line 46: warning: exported function NewAbsentManyRequest should have comment or be unexported (golint)
- Line 50: warning: exported type AbsentManyRequest should have comment or be unexported (golint)
- Line 56: warning: exported method GetRequest.Hashes should have comment or be unexported (golint)
- Line 60: warning: exported method GetRequest.Outstanding should have comment or be unexported (golint)
- Line 64: warning: exported method GetManyRequest.Hashes should have comment or be unexported (golint)
- Line 68: warning: exported method GetManyRequest.Outstanding should have comment or be unexported (golint)
- Line 72: warning: exported method AbsentRequest.Hashes should have comment or be unexported (golint)
- Line 76: warning: exported method AbsentRequest.Outstanding should have comment or be unexported (golint)
- Line 80: warning: exported method AbsentManyRequest.Hashes should have comment or be unexported (golint)
- Line 84: warning: exported method AbsentManyRequest.Outstanding should have comment or be unexported (golint)
- Line 88: warning: exported type OutstandingRequest should have comment or be unexported (golint)
- Line 93: warning: exported type OutstandingGet should have comment or be unexported (golint)
- Line 94: warning: exported type OutstandingGetMany should have comment or be unexported (golint)
- Line 98: warning: exported type OutstandingAbsent should have comment or be unexported (golint)
- Line 99: warning: exported type OutstandingAbsentMany should have comment or be unexported (golint)
- Line 104: warning: exported method OutstandingGet.Satisfy should have comment or be unexported (golint)
- Line 108: warning: exported method OutstandingGet.Fail should have comment or be unexported (golint)
- Line 112: warning: exported method OutstandingGetMany.Satisfy should have comment or be unexported (golint)
- Line 117: warning: exported method OutstandingGetMany.Fail should have comment or be unexported (golint)
- Line 121: warning: exported method OutstandingAbsent.Satisfy should have comment or be unexported (golint)
- Line 125: warning: exported method OutstandingAbsent.Fail should have comment or be unexported (golint)
- Line 129: warning: exported method OutstandingAbsentMany.Satisfy should have comment or be unexported (golint)
- Line 134: warning: exported method OutstandingAbsentMany.Fail should have comment or be unexported (golint)
-
-
noms/go/diff/print_diff.go
- Line 18: warning: exported const ADD should have comment (or a comment on this block) or be unexported (golint)
-
-
noms/samples/go/decent/dbg/debug.go
- Line 16: warning: exported var Filepath should have comment or be unexported (golint)
- Line 20: warning: exported function NewLogger should have comment or be unexported (golint)
- Line 27: warning: exported function GetLogger should have comment or be unexported (golint)
- Line 31: warning: exported function SetLogger should have comment or be unexported (golint)
- Line 35: warning: exported function Debug should have comment or be unexported (golint)
- Line 40: warning: exported function BoxF should have comment or be unexported (golint)
-
-
noms/samples/go/csv/csv-import/importer.go
- Line 148: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
-
-
noms/samples/go/csv/csv_reader.go
- Line 35: warning: exported function SkipRecords should have comment or be unexported (golint)
-
-
noms/samples/go/csv/schema.go
- Line 108: warning: exported function GetSchema should have comment or be unexported (golint)
- Line 120: warning: exported function GetFieldNamesFromIndices should have comment or be unexported (golint)
-
-
noms/samples/go/nomdex/nomdex_update.go
- Line 89: warning: exported type StreamingSetEntry should have comment or be unexported (golint)
- Line 94: warning: exported type IndexMap should have comment or be unexported (golint)
- Line 96: warning: exported type Index should have comment or be unexported (golint)
-
-
noms/go/types/encode_human_readable.go
- Line 32: warning: comment on exported type HRSCommenter should be of the form "HRSCommenter ..." (with optional leading article) (golint)
- Line 415: warning: exported function EncodedIndexValue should have comment or be unexported (golint)
-
-
noms/go/util/clienttest/client_test_suite.go
- Line 18: warning: exported const DefaultMemTableSize should have comment or be unexported (golint)
- Line 20: warning: exported type ClientTestSuite should have comment or be unexported (golint)
- Line 30: warning: exported type ExitError should have comment or be unexported (golint)
- Line 38: warning: exported method ClientTestSuite.SetupSuite should have comment or be unexported (golint)
- Line 57: warning: exported method ClientTestSuite.TearDownSuite should have comment or be unexported (golint)
- Line 120: warning: comment on exported function MockExit should be of the form "MockExit ..." (golint)
-
-
noms/go/perf/suite/suite.go
- Line 343: warning: exported method PerfSuite.Suite should have comment or be unexported (golint)
-
-
noms/go/types/set_iterator.go
- Line 110: warning: exported method UnionIterator.Next should have comment or be unexported (golint)
- Line 123: warning: exported method UnionIterator.SkipTo should have comment or be unexported (golint)
- Line 165: warning: exported method IntersectionIterator.Next should have comment or be unexported (golint)
- Line 183: warning: exported method IntersectionIterator.SkipTo should have comment or be unexported (golint)
-
-
noms/go/types/walk.go
- Line 9: warning: exported type SkipValueCallback should have comment or be unexported (golint)
-
-
noms/go/types/map.go
- Line 14: warning: exported type Map should have comment or be unexported (golint)
- Line 28: warning: exported function NewMap should have comment or be unexported (golint)
- Line 122: warning: exported method Map.WalkValues should have comment or be unexported (golint)
- Line 138: warning: exported method Map.First should have comment or be unexported (golint)
- Line 142: warning: exported method Map.Last should have comment or be unexported (golint)
- Line 146: warning: exported method Map.At should have comment or be unexported (golint)
- Line 156: warning: exported method Map.MaybeGet should have comment or be unexported (golint)
- Line 169: warning: exported method Map.Has should have comment or be unexported (golint)
- Line 178: warning: exported method Map.Get should have comment or be unexported (golint)
- Line 185: warning: exported method Map.Iter should have comment or be unexported (golint)
- Line 205: warning: exported method Map.Iterator should have comment or be unexported (golint)
- Line 209: warning: exported method Map.IteratorAt should have comment or be unexported (golint)
- Line 215: warning: exported method Map.IteratorFrom should have comment or be unexported (golint)
- Line 223: warning: exported method Map.IterAll should have comment or be unexported (golint)
- Line 236: warning: exported method Map.IterFrom should have comment or be unexported (golint)
- Line 244: warning: exported method Map.Edit should have comment or be unexported (golint)
-
-
noms/go/types/noms_kind.go
- Line 34: warning: exported var KindToString should have comment or be unexported (golint)
-
-
noms/cmd/noms/noms_commit.go
- Line 39: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
-
-
noms/go/datas/commit.go
- Line 17: warning: exported const ParentsField should have comment (or a comment on this block) or be unexported (golint)
- Line 128: warning: exported function IsCommitType should have comment or be unexported (golint)
- Line 132: warning: exported function IsCommit should have comment or be unexported (golint)
- Line 136: warning: exported function IsRefOfCommitType should have comment or be unexported (golint)
-
-
noms/go/datas/database_common.go
- Line 25: warning: exported var ErrOptimisticLockFailed should have comment or be unexported (golint)
- Line 205: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
noms/go/nbs/table.go
- Line 153: warning: exported function ParseAddr should have comment or be unexported (golint)
- Line 158: warning: exported function ValidateAddr should have comment or be unexported (golint)
-
-
noms/go/types/set_editor.go
- Line 25: warning: exported function NewSetEditor should have comment or be unexported (golint)
- Line 29: warning: exported method SetEditor.Kind should have comment or be unexported (golint)
- Line 33: warning: exported method SetEditor.Value should have comment or be unexported (golint)
- Line 37: warning: exported method SetEditor.Set should have comment or be unexported (golint)
- Line 113: warning: exported method SetEditor.Insert should have comment or be unexported (golint)
- Line 122: warning: exported method SetEditor.Remove should have comment or be unexported (golint)
- Line 131: warning: exported method SetEditor.Has should have comment or be unexported (golint)
-
-
noms/go/types/type.go
- Line 21: warning: exported type Type should have comment or be unexported (golint)
- Line 34: warning: exported method Type.TargetKind should have comment or be unexported (golint)
- Line 43: warning: exported method Type.Equals should have comment or be unexported (golint)
- Line 56: warning: exported method Type.Less should have comment or be unexported (golint)
- Line 60: warning: exported method Type.Hash should have comment or be unexported (golint)
- Line 73: warning: exported method Type.WalkValues should have comment or be unexported (golint)
- Line 77: warning: exported method Type.WalkRefs should have comment or be unexported (golint)
- Line 85: warning: exported method Type.Kind should have comment or be unexported (golint)
-
-
noms/go/sloppy/sloppy.go
- Line 143: warning: exported method Sloppy.Reset should have comment or be unexported (golint)
-
-
noms/go/util/status/status.go
- Line 15: warning: exported const Rate should have comment (or a comment on this block) or be unexported (golint)
- Line 24: warning: exported function Clear should have comment or be unexported (golint)
- Line 29: warning: exported function WillPrint should have comment or be unexported (golint)
- Line 33: warning: exported function Printf should have comment or be unexported (golint)
- Line 43: warning: exported function Done should have comment or be unexported (golint)
-
-
noms/go/types/value.go
- Line 13: warning: exported type ValueCallback should have comment or be unexported (golint)
- Line 14: warning: exported type RefCallback should have comment or be unexported (golint)
- Line 59: warning: exported type ValueSlice should have comment or be unexported (golint)
- Line 64: warning: exported method ValueSlice.Equals should have comment or be unexported (golint)
- Line 78: warning: exported method ValueSlice.Contains should have comment or be unexported (golint)
-
-
noms/go/types/value_stats.go
- Line 16: warning: exported type ValueStats should have comment or be unexported (golint)
- Line 20: warning: exported function WriteValueStats should have comment or be unexported (golint)
-
-
noms/go/config/resolver.go
- Line 18: warning: exported type Resolver should have comment or be unexported (golint)
- Line 23: warning: comment on exported function NewResolver should be of the form "NewResolver ..." (golint)
- Line 49: warning: comment on exported method Resolver.ResolveDbSpec should be of the form "ResolveDbSpec ..." (golint)
- Line 64: warning: comment on exported method Resolver.ResolvePathSpec should be of the form "ResolvePathSpec ..." (golint)
- Line 87: warning: comment on exported method Resolver.GetDatabase should be of the form "GetDatabase ..." (golint)
- Line 98: warning: comment on exported method Resolver.GetChunkStore should be of the form "GetChunkStore ..." (golint)
- Line 107: warning: comment on exported method Resolver.GetDataset should be of the form "GetDataset ..." (golint)
- Line 118: warning: comment on exported method Resolver.GetPath should be of the form "GetPath ..." (golint)
-
-
noms/go/nbs/store.go
- Line 52: warning: exported type NomsBlockStore should have comment or be unexported (golint)
- Line 68: warning: exported function NewAWSStore should have comment or be unexported (golint)
- Line 84: warning: exported function NewLocalStore should have comment or be unexported (golint)
- Line 135: warning: exported method NomsBlockStore.Put should have comment or be unexported (golint)
- Line 159: warning: exported method NomsBlockStore.Get should have comment or be unexported (golint)
- Line 185: warning: exported method NomsBlockStore.GetMany should have comment or be unexported (golint)
- Line 233: warning: exported method NomsBlockStore.CalcReads should have comment or be unexported (golint)
- Line 266: warning: exported method NomsBlockStore.Count should have comment or be unexported (golint)
- Line 278: warning: exported method NomsBlockStore.Has should have comment or be unexported (golint)
- Line 296: warning: exported method NomsBlockStore.HasMany should have comment or be unexported (golint)
- Line 349: warning: exported method NomsBlockStore.Rebase should have comment or be unexported (golint)
- Line 358: warning: exported method NomsBlockStore.Root should have comment or be unexported (golint)
- Line 364: warning: exported method NomsBlockStore.Commit should have comment or be unexported (golint)
- Line 463: warning: exported method NomsBlockStore.Version should have comment or be unexported (golint)
- Line 467: warning: exported method NomsBlockStore.Close should have comment or be unexported (golint)
- Line 471: warning: exported method NomsBlockStore.Stats should have comment or be unexported (golint)
- Line 475: warning: exported method NomsBlockStore.StatsSummary should have comment or be unexported (golint)
-
-
noms/go/datas/dataset.go
- Line 75: warning: comment on exported method Dataset.HasHead should be of the form "HasHead ..." (golint)
- Line 105: warning: exported function IsValidDatasetName should have comment or be unexported (golint)
-
-
noms/go/nbs/stats.go
- Line 13: warning: exported type Stats should have comment or be unexported (golint)
- Line 56: warning: exported function NewStats should have comment or be unexported (golint)
- Line 84: warning: exported method Stats.Add should have comment or be unexported (golint)
- Line 127: warning: exported method Stats.Delta should have comment or be unexported (golint)
-
-
noms/go/types/collection.go
- Line 7: warning: exported type Collection should have comment or be unexported (golint)
-
-
noms/go/chunks/memory_store.go
- Line 98: warning: exported method MemoryStoreView.Get should have comment or be unexported (golint)
- Line 107: warning: exported method MemoryStoreView.GetMany should have comment or be unexported (golint)
- Line 117: warning: exported method MemoryStoreView.Has should have comment or be unexported (golint)
- Line 126: warning: exported method MemoryStoreView.HasMany should have comment or be unexported (golint)
- Line 136: warning: exported method MemoryStoreView.Version should have comment or be unexported (golint)
- Line 140: warning: exported method MemoryStoreView.Put should have comment or be unexported (golint)
- Line 149: warning: exported method MemoryStoreView.Len should have comment or be unexported (golint)
- Line 155: warning: exported method MemoryStoreView.Rebase should have comment or be unexported (golint)
- Line 161: warning: exported method MemoryStoreView.Root should have comment or be unexported (golint)
- Line 167: warning: exported method MemoryStoreView.Commit should have comment or be unexported (golint)
- Line 182: warning: exported method MemoryStoreView.Stats should have comment or be unexported (golint)
- Line 186: warning: exported method MemoryStoreView.StatsSummary should have comment or be unexported (golint)
- Line 190: warning: exported method MemoryStoreView.Close should have comment or be unexported (golint)
- Line 199: warning: exported function NewMemoryStoreFactory should have comment or be unexported (golint)
-
-
noms/go/util/datetime/date_time.go
- Line 78: warning: exported type DateTimeCommenter should have comment or be unexported (golint)
- Line 82: warning: exported method DateTimeCommenter.Comment should have comment or be unexported (golint)
- Line 91: warning: exported function RegisterHRSCommenter should have comment or be unexported (golint)
-
-
noms/go/spec/util.go
- Line 12: warning: exported function CreateDatabaseSpecString should have comment or be unexported (golint)
- Line 16: warning: exported function CreateValueSpecString should have comment or be unexported (golint)
- Line 22: warning: exported function CreateHashSpecString should have comment or be unexported (golint)
-
-
noms/samples/go/csv/kind_slice.go
- Line 18: warning: exported method KindSlice.MarshalJSON should have comment or be unexported (golint)
- Line 26: warning: exported method KindSlice.UnmarshalJSON should have comment or be unexported (golint)
-
-
noms/samples/go/hr/main.go
- Line 49: warning: exported type Person should have comment or be unexported (golint)
-
-
noms/go/datas/pull.go
- Line 18: warning: exported type PullProgress should have comment or be unexported (golint)
-
-
noms/go/nbs/factory.go
- Line 71: warning: exported method AWSStoreFactory.CreateStore should have comment or be unexported (golint)
- Line 76: warning: exported method AWSStoreFactory.CreateStoreFromCache should have comment or be unexported (golint)
- Line 86: warning: exported method AWSStoreFactory.Shutter should have comment or be unexported (golint)
- Line 89: warning: exported type LocalStoreFactory should have comment or be unexported (golint)
- Line 110: warning: exported function NewLocalStoreFactory should have comment or be unexported (golint)
- Line 128: warning: exported method LocalStoreFactory.CreateStore should have comment or be unexported (golint)
- Line 137: warning: exported method LocalStoreFactory.CreateStoreFromCache should have comment or be unexported (golint)
- Line 151: warning: exported method LocalStoreFactory.Shutter should have comment or be unexported (golint)
-
-
noms/go/types/blob.go
- Line 26: warning: exported function NewEmptyBlob should have comment or be unexported (golint)
- Line 30: warning: exported method Blob.Edit should have comment or be unexported (golint)
- Line 81: warning: exported method Blob.Reader should have comment or be unexported (golint)
- Line 85: warning: exported method Blob.Copy should have comment or be unexported (golint)
- Line 155: warning: exported method Blob.WalkValues should have comment or be unexported (golint)
- Line 158: warning: exported type BlobReader should have comment or be unexported (golint)
- Line 169: warning: exported method BlobReader.Seek should have comment or be unexported (golint)
-
-
noms/go/constants/version.go
- Line 8: warning: exported const NomsVersion should have comment or be unexported (golint)
- Line 10: warning: exported var NomsGitSHA should have comment or be unexported (golint)
-
-
noms/go/spec/commit_meta.go
- Line 17: warning: exported const CommitMetaDateFormat should have comment or be unexported (golint)
- Line 37: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 49: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 52: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 76: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 82: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 95: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
-
-
noms/go/types/number.go
- Line 23: warning: exported method Number.Equals should have comment or be unexported (golint)
- Line 27: warning: exported method Number.Less should have comment or be unexported (golint)
- Line 34: warning: exported method Number.Hash should have comment or be unexported (golint)
- Line 38: warning: exported method Number.WalkValues should have comment or be unexported (golint)
- Line 41: warning: exported method Number.WalkRefs should have comment or be unexported (golint)
- Line 48: warning: exported method Number.Kind should have comment or be unexported (golint)
-
-
noms/go/types/subtype.go
- Line 23: warning: comment on exported function IsSubtypeDisallowExtraStructFields should be of the form "IsSubtypeDisallowExtraStructFields ..." (golint)
- Line 169: warning: exported function IsValueSubtypeOf should have comment or be unexported (golint)
-
-
noms/go/types/edit_distance.go
- Line 16: warning: exported const DEFAULT_MAX_SPLICE_MATRIX_SIZE should have comment (or a comment on this block) or be unexported (golint)
- Line 25: warning: comment on exported type Splice should be of the form "Splice ..." (with optional leading article) (golint)
- Line 34: warning: exported type EditDistanceEqualsFn should have comment or be unexported (golint)
-
-
noms/go/types/make_type.go
- Line 13: warning: exported function MakePrimitiveType should have comment or be unexported (golint)
- Line 37: warning: exported function MakeListType should have comment or be unexported (golint)
- Line 41: warning: exported function MakeSetType should have comment or be unexported (golint)
- Line 45: warning: exported function MakeRefType should have comment or be unexported (golint)
- Line 49: warning: exported function MakeMapType should have comment or be unexported (golint)
- Line 53: warning: exported function MakeStructType should have comment or be unexported (golint)
- Line 67: warning: exported function MakeCycleType should have comment or be unexported (golint)
- Line 76: warning: exported var BoolType should have comment or be unexported (golint)
- Line 77: warning: exported var NumberType should have comment or be unexported (golint)
- Line 78: warning: exported var StringType should have comment or be unexported (golint)
- Line 79: warning: exported var BlobType should have comment or be unexported (golint)
- Line 80: warning: exported var TypeType should have comment or be unexported (golint)
- Line 81: warning: exported var ValueType should have comment or be unexported (golint)
- Line 104: warning: exported type FieldMap should have comment or be unexported (golint)
- Line 106: warning: exported function MakeStructTypeFromFields should have comment or be unexported (golint)
-
-
noms/tools/file/file.go
- Line 48: warning: exported var ErrNoCopyDir should have comment or be unexported (golint)
-
-
noms/go/types/graph_builder.go
- Line 49: warning: exported type GraphBuilder should have comment or be unexported (golint)
-
-
noms/go/types/map_iterator.go
- Line 14: warning: exported method MapIterator.Valid should have comment or be unexported (golint)
- Line 18: warning: exported method MapIterator.Entry should have comment or be unexported (golint)
- Line 22: warning: exported method MapIterator.Key should have comment or be unexported (golint)
- Line 29: warning: exported method MapIterator.Value should have comment or be unexported (golint)
- Line 36: warning: exported method MapIterator.Position should have comment or be unexported (golint)
-
-
noms/go/types/ref.go
- Line 13: warning: exported type Ref should have comment or be unexported (golint)
- Line 27: warning: exported function NewRef should have comment or be unexported (golint)
- Line 100: warning: exported method Ref.TargetHash should have comment or be unexported (golint)
- Line 105: warning: exported method Ref.Height should have comment or be unexported (golint)
- Line 110: warning: exported method Ref.TargetValue should have comment or be unexported (golint)
- Line 114: warning: exported method Ref.TargetType should have comment or be unexported (golint)
- Line 124: warning: exported method Ref.WalkValues should have comment or be unexported (golint)
-
-
noms/go/types/string.go
- Line 21: warning: exported method String.Equals should have comment or be unexported (golint)
- Line 25: warning: exported method String.Less should have comment or be unexported (golint)
- Line 32: warning: exported method String.Hash should have comment or be unexported (golint)
- Line 36: warning: exported method String.WalkValues should have comment or be unexported (golint)
- Line 39: warning: exported method String.WalkRefs should have comment or be unexported (golint)
- Line 46: warning: exported method String.Kind should have comment or be unexported (golint)
-
-
noms/go/types/validating_decoder.go
- Line 12: warning: exported type ValidatingDecoder should have comment or be unexported (golint)
- Line 16: warning: exported function NewValidatingDecoder should have comment or be unexported (golint)
-
-
noms/go/d/try.go
- Line 28: warning: comment on exported function Panic should be of the form "Panic ..." (golint)
- Line 40: warning: comment on exported function PanicIfError should be of the form "PanicIfError ..." (golint)
- Line 48: warning: comment on exported function PanicIfTrue should be of the form "PanicIfTrue ..." (golint)
- Line 55: warning: comment on exported function PanicIfFalse should be of the form "PanicIfFalse ..." (golint)
- Line 62: warning: comment on exported function Try should be of the form "Try ..." (golint)
- Line 72: warning: comment on exported function TryCatch should be of the form "TryCatch ..." (golint)
- Line 82: warning: exported type WrappedError should have comment or be unexported (golint)
- Line 87: warning: comment on exported function Wrap should be of the form "Wrap ..." (golint)
- Line 104: warning: comment on exported function Unwrap should be of the form "Unwrap ..." (golint)
- Line 125: warning: comment on exported function PanicIfNotType should be of the form "PanicIfNotType ..." (golint)
-
-
noms/go/hash/hash_slice.go
- Line 7: warning: exported type HashSlice should have comment or be unexported (golint)
- Line 21: warning: exported method HashSlice.Equals should have comment or be unexported (golint)
- Line 33: warning: exported method HashSlice.HashSet should have comment or be unexported (golint)
-
-
noms/cmd/noms/splore/noms_splore.go
- Line 58: warning: exported function Cmd should have comment or be unexported (golint)
-
-
noms/go/nbs/cache.go
- Line 20: warning: exported function NewCache should have comment or be unexported (golint)
-
-
noms/go/types/codec.go
- Line 21: warning: exported function EncodeValue should have comment or be unexported (golint)
- Line 34: warning: exported function DecodeFromBytes should have comment or be unexported (golint)
-
-
noms/cmd/util/kingpin_command.go
- Line 9: warning: exported type KingpinHandler should have comment or be unexported (golint)
- Line 10: warning: exported type KingpinCommand should have comment or be unexported (golint)
-
-
noms/go/util/test/equals_ignore_hashes.go
- Line 26: warning: exported function RemoveHashes should have comment or be unexported (golint)
-
-
noms/go/util/sizecache/size_cache.go
- Line 24: warning: exported type SizeCache should have comment or be unexported (golint)
- Line 33: warning: exported type ExpireCallback should have comment or be unexported (golint)
-
-
noms/go/util/profile/profile.go
- Line 24: warning: exported function RegisterProfileFlags should have comment or be unexported (golint)
-
-
noms/go/types/get_hash.go
- Line 22: warning: exported function EnsureHash should have comment or be unexported (golint)
-
-
noms/go/types/map_editor.go
- Line 25: warning: exported function NewMapEditor should have comment or be unexported (golint)
- Line 29: warning: exported method MapEditor.Kind should have comment or be unexported (golint)
- Line 33: warning: exported method MapEditor.Value should have comment or be unexported (golint)
- Line 37: warning: exported method MapEditor.Map should have comment or be unexported (golint)
- Line 131: warning: exported method MapEditor.Set should have comment or be unexported (golint)
- Line 137: warning: exported method MapEditor.SetM should have comment or be unexported (golint)
- Line 146: warning: exported method MapEditor.Remove should have comment or be unexported (golint)
- Line 151: warning: exported method MapEditor.Get should have comment or be unexported (golint)
- Line 159: warning: exported method MapEditor.Has should have comment or be unexported (golint)
-
-
noms/go/types/type_desc.go
- Line 32: warning: exported method PrimitiveDesc.Kind should have comment or be unexported (golint)
- Line 58: warning: exported method CompoundDesc.Kind should have comment or be unexported (golint)
- Line 101: warning: exported method StructDesc.Kind should have comment or be unexported (golint)
- Line 153: warning: exported method StructDesc.IterFields should have comment or be unexported (golint)
- Line 159: warning: exported method StructDesc.Field should have comment or be unexported (golint)
- Line 180: warning: exported type CycleDesc should have comment or be unexported (golint)
- Line 182: warning: exported method CycleDesc.Kind should have comment or be unexported (golint)
-
-
noms/go/util/exit/exit.go
- Line 17: warning: exported var Exit should have comment or be unexported (golint)
-
-
noms/go/util/json/from_json.go
- Line 84: warning: exported function FromJSON should have comment or be unexported (golint)
-
-
noms/go/util/verbose/verbose.go
- Line 32: warning: exported function SetVerbose should have comment or be unexported (golint)
- Line 41: warning: exported function SetQuiet should have comment or be unexported (golint)
-
-
noms/go/datas/remote_database_handlers.go
- Line 31: warning: exported type URLParams should have comment or be unexported (golint)
- Line 35: warning: exported type Handler should have comment or be unexported (golint)
- Line 66: warning: comment on exported var HandleHasRefs should be of the form "HandleHasRefs ..." (golint)
- Line 79: warning: comment on exported var HandleRootPost should be of the form "HandleRootPost ..." (golint)
- Line 92: warning: exported var HandleGraphQL should have comment or be unexported (golint)
- Line 333: warning: exported function BuildHashesRequestForTest should have comment or be unexported (golint)
-
-
noms/go/types/ordered_sequences_diff.go
- Line 14: warning: exported type DiffChangeType should have comment or be unexported (golint)
- Line 17: warning: exported const DiffChangeAdded should have comment (or a comment on this block) or be unexported (golint)
- Line 22: warning: exported type ValueChanged should have comment or be unexported (golint)
-
-
noms/go/types/struct.go
- Line 17: warning: exported var EmptyStructType should have comment or be unexported (golint)
- Line 18: warning: exported var EmptyStruct should have comment or be unexported (golint)
- Line 20: warning: exported type StructData should have comment or be unexported (golint)
- Line 22: warning: exported type Struct should have comment or be unexported (golint)
- Line 95: warning: exported function NewStruct should have comment or be unexported (golint)
- Line 147: warning: exported method Struct.Empty should have comment or be unexported (golint)
- Line 156: warning: exported method Struct.WalkValues should have comment or be unexported (golint)
- Line 290: warning: exported method Struct.SetName should have comment or be unexported (golint)
- Line 358: warning: exported method Struct.Diff should have comment or be unexported (golint)
- Line 436: warning: exported function CamelCaseFieldName should have comment or be unexported (golint)
-
-
noms/go/chunks/test_utils.go
- Line 24: warning: exported type TestStorage should have comment or be unexported (golint)
- Line 28: warning: exported method TestStorage.NewView should have comment or be unexported (golint)
- Line 32: warning: exported type TestStoreView should have comment or be unexported (golint)
- Line 39: warning: exported method TestStoreView.Get should have comment or be unexported (golint)
- Line 44: warning: exported method TestStoreView.GetMany should have comment or be unexported (golint)
- Line 49: warning: exported method TestStoreView.Has should have comment or be unexported (golint)
- Line 54: warning: exported method TestStoreView.HasMany should have comment or be unexported (golint)
- Line 59: warning: exported method TestStoreView.Put should have comment or be unexported (golint)
- Line 64: warning: exported type TestStoreFactory should have comment or be unexported (golint)
- Line 68: warning: exported function NewTestStoreFactory should have comment or be unexported (golint)
- Line 72: warning: exported method TestStoreFactory.CreateStore should have comment or be unexported (golint)
- Line 83: warning: exported method TestStoreFactory.Shutter should have comment or be unexported (golint)
-
-
noms/go/ngql/query.go
- Line 65: warning: should not use basic type string as key in context.WithValue (golint)
gocyclo93%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
noms/go/util/json/to_json.go
- Line 44: warning: cyclomatic complexity 18 of function toPile() is high (> 15) (gocyclo)
-
-
noms/go/marshal/decode.go
- Line 172: warning: cyclomatic complexity 16 of function typeDecoder() is high (> 15) (gocyclo)
-
-
noms/go/types/struct.go
- Line 358: warning: cyclomatic complexity 17 of function (Struct).Diff() is high (> 15) (gocyclo)
-
-
noms/go/types/walk.go
- Line 22: warning: cyclomatic complexity 16 of function WalkValues() is high (> 15) (gocyclo)
-
-
noms/go/sloppy/sloppy.go
- Line 90: warning: cyclomatic complexity 18 of function (*Sloppy).Update() is high (> 15) (gocyclo)
-
-
noms/go/ngql/types.go
- Line 712: warning: cyclomatic complexity 19 of function getTypeName() is high (> 15) (gocyclo)
- Line 137: warning: cyclomatic complexity 17 of function (*TypeConverter).nomsTypeToGraphQLType() is high (> 15) (gocyclo)
-
-
noms/go/spec/commit_meta.go
- Line 31: warning: cyclomatic complexity 19 of function CreateCommitMetaStruct() is high (> 15) (gocyclo)
-
-
noms/samples/go/csv/csv-import/importer.go
- Line 36: warning: cyclomatic complexity 34 of function main() is high (> 15) (gocyclo)
-
-
noms/go/marshal/encode_type.go
- Line 80: warning: cyclomatic complexity 27 of function encodeType() is high (> 15) (gocyclo)
-
-
noms/go/types/subtype.go
- Line 197: warning: cyclomatic complexity 43 of function isValueSubtypeOfDetails() is high (> 15) (gocyclo)
- Line 43: warning: cyclomatic complexity 31 of function isSubtypeDetails() is high (> 15) (gocyclo)
-
-
noms/go/types/map_editor.go
- Line 37: warning: cyclomatic complexity 19 of function (*MapEditor).Map() is high (> 15) (gocyclo)
-
-
noms/go/types/indexed_sequence_diff.go
- Line 16: warning: cyclomatic complexity 18 of function indexedSequenceDiff() is high (> 15) (gocyclo)
-
-
noms/go/diff/apply_patch.go
- Line 109: warning: cyclomatic complexity 29 of function (*patchStack).updateNode() is high (> 15) (gocyclo)
-
-
noms/go/perf/suite/suite.go
- Line 173: warning: cyclomatic complexity 29 of function Run() is high (> 15) (gocyclo)
-
-
noms/cmd/noms/splore/noms_splore.go
- Line 151: warning: cyclomatic complexity 18 of function getNodeChildren() is high (> 15) (gocyclo)
-
-
noms/go/nbs/aws_table_persister_test.go
- Line 289: warning: cyclomatic complexity 22 of function TestAWSTablePersisterConjoinAll() is high (> 15) (gocyclo)
- Line 18: warning: cyclomatic complexity 19 of function TestAWSTablePersisterPersist() is high (> 15) (gocyclo)
-
-
noms/go/diff/print_diff.go
- Line 29: warning: cyclomatic complexity 17 of function PrintDiff() is high (> 15) (gocyclo)
-
-
noms/go/datas/remote_database_handlers.go
- Line 503: warning: cyclomatic complexity 20 of function mergeDatasetMaps() is high (> 15) (gocyclo)
-
-
noms/go/marshal/encode.go
- Line 292: warning: cyclomatic complexity 16 of function structEncoder() is high (> 15) (gocyclo)
- Line 239: warning: cyclomatic complexity 16 of function typeEncoder() is high (> 15) (gocyclo)
-
-
noms/go/nbs/aws_table_persister.go
- Line 277: warning: cyclomatic complexity 18 of function (awsTablePersister).assembleTable() is high (> 15) (gocyclo)
- Line 142: warning: cyclomatic complexity 16 of function (awsTablePersister).uploadParts() is high (> 15) (gocyclo)
-
-
noms/go/types/path.go
- Line 59: warning: cyclomatic complexity 26 of function constructPath() is high (> 15) (gocyclo)
- Line 385: warning: cyclomatic complexity 16 of function ParsePathIndex() is high (> 15) (gocyclo)
-
-
noms/go/types/edit_distance.go
- Line 76: warning: cyclomatic complexity 18 of function calcSplices() is high (> 15) (gocyclo)
-
-
noms/go/types/encode_human_readable.go
- Line 316: warning: cyclomatic complexity 16 of function (*hrsWriter).writeType() is high (> 15) (gocyclo)
-
-
noms/go/nomdl/parser.go
- Line 312: warning: cyclomatic complexity 17 of function (*Parser).parseValue() is high (> 15) (gocyclo)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!