Preparing report...

Report for github.com/barnybug/cli53

A    Great!    Found 9 issues across 14 files

Tweet

gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo64%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • cli53/bind.go
    • Line 222: warning: cyclomatic complexity 35 of function ConvertRRSetToBind() is high (> 15) (gocyclo)
    • cli53/main.go
    • Line 15: warning: cyclomatic complexity 31 of function Main() is high (> 15) (gocyclo)
    • cli53/commands.go
    • Line 265: warning: cyclomatic complexity 23 of function importBind() is high (> 15) (gocyclo)
    • Line 481: warning: cyclomatic complexity 19 of function (createArgs).validate() is high (> 15) (gocyclo)

golint57%

Golint is a linter for Go source code.

    • cli53/util.go
    • Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 203: warning: exported type KeyValues should have comment or be unexported (golint)
    • Line 205: warning: exported method KeyValues.GetOptString should have comment or be unexported (golint)
    • Line 216: warning: exported method KeyValues.GetString should have comment or be unexported (golint)
    • Line 224: warning: exported method KeyValues.GetInt should have comment or be unexported (golint)
    • Line 253: warning: exported function ParseKeyValues should have comment or be unexported (golint)
    • cli53/awsrr.go
    • Line 10: warning: exported const ClassAWS should have comment or be unexported (golint)
    • Line 11: warning: exported const TypeALIAS should have comment or be unexported (golint)
    • Line 13: warning: exported type ALIASRdata should have comment or be unexported (golint)
    • Line 20: warning: exported method ALIASRdata.Copy should have comment or be unexported (golint)
    • Line 29: warning: exported method ALIASRdata.Len should have comment or be unexported (golint)
    • Line 33: warning: exported method ALIASRdata.Parse should have comment or be unexported (golint)
    • Line 44: warning: exported method ALIASRdata.Pack should have comment or be unexported (golint)
    • Line 48: warning: exported method ALIASRdata.Unpack should have comment or be unexported (golint)
    • Line 52: warning: receiver name rr should be consistent with previous receiver name rd for ALIASRdata (golint)
    • Line 61: warning: exported function NewALIASRdata should have comment or be unexported (golint)
    • Line 69: warning: exported type AWSRoute should have comment or be unexported (golint)
    • Line 74: warning: exported type AWSRR should have comment or be unexported (golint)
    • Line 94: warning: exported type FailoverRoute should have comment or be unexported (golint)
    • Line 102: warning: exported method FailoverRoute.Parse should have comment or be unexported (golint)
    • Line 106: warning: exported type GeoLocationRoute should have comment or be unexported (golint)
    • Line 126: warning: exported method GeoLocationRoute.Parse should have comment or be unexported (golint)
    • Line 132: warning: exported type LatencyRoute should have comment or be unexported (golint)
    • Line 140: warning: exported method LatencyRoute.Parse should have comment or be unexported (golint)
    • Line 144: warning: exported type WeightedRoute should have comment or be unexported (golint)
    • Line 152: warning: exported method WeightedRoute.Parse should have comment or be unexported (golint)
    • Line 156: warning: exported type MultiValueAnswerRoute should have comment or be unexported (golint)
    • Line 163: warning: exported method MultiValueAnswerRoute.Parse should have comment or be unexported (golint)
    • Line 166: warning: exported var RoutingTypes should have comment or be unexported (golint)
    • cli53/commands.go
    • Line 15: warning: exported const ChangeBatchSize should have comment or be unexported (golint)
    • Line 188: warning: exported type Key should have comment or be unexported (golint)
    • Line 387: warning: exported function UnexpandSelfAliases should have comment or be unexported (golint)
    • Line 439: warning: exported function ExportBindToWriter should have comment or be unexported (golint)
    • Line 664: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 678: warning: comment on exported function ListAllRecordSets should be of the form "ListAllRecordSets ..." (golint)
    • cli53/formatters.go
    • Line 14: warning: exported type Formatter should have comment or be unexported (golint)
    • Line 18: warning: exported type TextFormatter should have comment or be unexported (golint)
    • Line 21: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 27: warning: exported type JsonFormatter should have comment or be unexported (golint)
    • Line 30: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 40: warning: exported type JlFormatter should have comment or be unexported (golint)
    • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 51: warning: exported type TableFormatter should have comment or be unexported (golint)
    • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 71: warning: exported type CSVFormatter should have comment or be unexported (golint)
    • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!