gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• seaweedfs/weed/server/filer_server_handlers_read.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/server/master_server_handlers.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/shell/command_ec_balance.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/unmaintained/load_test/load_test_meta_tail/load_test_meta_tail.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/server/master_server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/shell/command_volume_balance.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/wdclient/resource_pool/multi_resource_pool.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/filesys/dirty_pages_temp_file.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/s3api/filer_util_tags.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/s3api/s3api_object_handlers.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/topology/node.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/glog/glog.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/topology/topology_event_handling.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/filer/filer_notify_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/server/filer_server_handlers_tagging.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/filesys/dirty_pages_temp_interval.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/filesys/filehandle.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/storage/volume_info_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/topology/volume_layout_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/server/filer_server.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/unmaintained/s3/presigned_put/presigned_put.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/notification/aws_sqs/aws_sqs_pub.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/topology/topology_ec.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/server/master_grpc_server_volume.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/storage/disk_location_ec.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/command/fuse.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/test/s3/multipart/aws_upload.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/test/s3/basic/basic_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/unmaintained/volume_tailer/volume_tailer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/unmaintained/stress_filer_upload/bench_filer_upload/bench_filer_upload.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/unmaintained/see_log_entry/see_log_entry.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/filer/hbase/hbase_store_kv.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/util/grace/signal_handling.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• seaweedfs/weed/topology/topology.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• seaweedfs/weed/storage/backend/memory_map/os_overloads/file_windows.go
  • Line 26: warning: cyclomatic complexity 20 of function volumeName() is high (> 15) (gocyclo)
  • Line 72: warning: cyclomatic complexity 19 of function fixLongPath() is high (> 15) (gocyclo)

• seaweedfs/weed/images/resizing.go
  • Line 16: warning: cyclomatic complexity 16 of function Resized() is high (> 15) (gocyclo)

• seaweedfs/weed/command/filer_meta_backup.go
  • Line 148: warning: cyclomatic complexity 20 of function (*FilerMetaBackupOptions).streamMetadataBackup() is high (> 15) (gocyclo)

• seaweedfs/weed/util/log_buffer/log_buffer.go
  • Line 179: warning: cyclomatic complexity 16 of function (*LogBuffer).ReadFromBuffer() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/needle/needle.go
  • Line 51: warning: cyclomatic complexity 16 of function CreateNeedleFromRequest() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/auth_signature_v2.go
  • Line 179: warning: cyclomatic complexity 17 of function (*IdentityAccessManagement).doesPresignV2SignatureMatch() is high (> 15) (gocyclo)

• seaweedfs/weed/messaging/broker/broker_grpc_server_subscribe.go
  • Line 18: warning: cyclomatic complexity 19 of function (*MessageBroker).Subscribe() is high (> 15) (gocyclo)

• seaweedfs/weed/filer/meta_aggregator.go
  • Line 49: warning: cyclomatic complexity 18 of function (*MetaAggregator).subscribeToOneFiler() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/auth_signature_v4.go
  • Line 344: warning: cyclomatic complexity 17 of function (*IdentityAccessManagement).doesPresignedSignatureMatch() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/volume_vacuum.go
  • Line 179: warning: cyclomatic complexity 26 of function (*Volume).makeupDiff() is high (> 15) (gocyclo)

• seaweedfs/weed/server/master_grpc_server.go
  • Line 20: warning: cyclomatic complexity 35 of function (*MasterServer).SendHeartbeat() is high (> 15) (gocyclo)

• seaweedfs/weed/server/volume_grpc_client_to_master.go
  • Line 97: warning: cyclomatic complexity 29 of function (*VolumeServer).doHeartbeat() is high (> 15) (gocyclo)

• seaweedfs/weed/server/raft_server.go
  • Line 54: warning: cyclomatic complexity 16 of function NewRaftServer() is high (> 15) (gocyclo)

• seaweedfs/weed/operation/submit.go
  • Line 121: warning: cyclomatic complexity 16 of function (FilePart).Upload() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/volume_loading.go
  • Line 25: warning: cyclomatic complexity 37 of function (*Volume).load() is high (> 15) (gocyclo)

• seaweedfs/weed/glog/glog.go
  • Line 672: warning: cyclomatic complexity 19 of function (*loggingT).output() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/needle_map/compact_map_test.go
  • Line 49: warning: cyclomatic complexity 20 of function TestCompactMap() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/chunked_reader_v4.go
  • Line 231: warning: cyclomatic complexity 18 of function (*s3ChunkedReader).Read() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/store.go
  • Line 213: warning: cyclomatic complexity 23 of function (*Store).CollectHeartbeat() is high (> 15) (gocyclo)

• seaweedfs/weed/shell/command_fs_ls.go
  • Line 36: warning: cyclomatic complexity 19 of function (*commandFsLs).Do() is high (> 15) (gocyclo)

• seaweedfs/weed/server/volume_server_handlers_helper.go
  • Line 31: warning: cyclomatic complexity 16 of function parseRange() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/policy/postpolicyform.go
  • Line 114: warning: cyclomatic complexity 18 of function ParsePostPolicyForm() is high (> 15) (gocyclo)

• seaweedfs/weed/command/backup.go
  • Line 64: warning: cyclomatic complexity 17 of function runBackup() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/s3api_objects_list_handlers.go
  • Line 200: warning: cyclomatic complexity 20 of function (*S3ApiServer).doListFilerEntries() is high (> 15) (gocyclo)

• seaweedfs/weed/server/volume_server_handlers_read.go
  • Line 28: warning: cyclomatic complexity 40 of function (*VolumeServer).GetOrHeadHandler() is high (> 15) (gocyclo)

• seaweedfs/weed/operation/upload_content.go
  • Line 108: warning: cyclomatic complexity 19 of function doUploadData() is high (> 15) (gocyclo)
  • Line 190: warning: cyclomatic complexity 18 of function upload_content() is high (> 15) (gocyclo)

• seaweedfs/weed/shell/command_volume_fsck.go
  • Line 50: warning: cyclomatic complexity 19 of function (*commandVolumeFsck).Do() is high (> 15) (gocyclo)

• seaweedfs/weed/server/volume_grpc_erasure_coding.go
  • Line 159: warning: cyclomatic complexity 18 of function (*VolumeServer).VolumeEcShardsDelete() is high (> 15) (gocyclo)

• seaweedfs/weed/filesys/meta_cache/meta_cache_subscribe.go
  • Line 15: warning: cyclomatic complexity 17 of function SubscribeMetaEvents() is high (> 15) (gocyclo)

• seaweedfs/weed/command/volume.go
  • Line 129: warning: cyclomatic complexity 32 of function (VolumeServerOptions).startVolumeServer() is high (> 15) (gocyclo)

• seaweedfs/test/s3/basic/basic_test.go
  • Line 136: warning: cyclomatic complexity 16 of function TestObjectOp() is high (> 15) (gocyclo)

• seaweedfs/weed/filesys/dirty_pages_temp_interval.go
  • Line 114: warning: cyclomatic complexity 19 of function (*WrittenContinuousIntervals).AddInterval() is high (> 15) (gocyclo)

• seaweedfs/weed/command/filer_replication.go
  • Line 37: warning: cyclomatic complexity 23 of function runFilerReplicate() is high (> 15) (gocyclo)

• seaweedfs/weed/server/filer_server_handlers_write_upload.go
  • Line 22: warning: cyclomatic complexity 16 of function (*FilerServer).uploadReaderToChunks() is high (> 15) (gocyclo)

• seaweedfs/weed/query/json/query_json.go
  • Line 29: warning: cyclomatic complexity 29 of function filterJson() is high (> 15) (gocyclo)

• seaweedfs/weed/filesys/dirty_page_interval.go
  • Line 90: warning: cyclomatic complexity 19 of function (*ContinuousIntervals).AddInterval() is high (> 15) (gocyclo)

• seaweedfs/weed/command/mount_std.go
  • Line 70: warning: cyclomatic complexity 24 of function RunMount() is high (> 15) (gocyclo)

• seaweedfs/weed/command/export.go
  • Line 109: warning: cyclomatic complexity 16 of function (*VolumeFileScanner4Export).VisitNeedle() is high (> 15) (gocyclo)

• seaweedfs/weed/shell/command_s3_configure.go
  • Line 35: warning: cyclomatic complexity 40 of function (*commandS3Configure).Do() is high (> 15) (gocyclo)

• seaweedfs/weed/server/filer_server_handlers_read.go
  • Line 24: warning: cyclomatic complexity 33 of function (*FilerServer).GetOrHeadHandler() is high (> 15) (gocyclo)

• seaweedfs/unmaintained/diff_volume_servers/diff_volume_servers.go
  • Line 41: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• seaweedfs/weed/query/sqltypes/value.go
  • Line 121: warning: cyclomatic complexity 20 of function BuildValue() is high (> 15) (gocyclo)

• seaweedfs/weed/command/fuse.go
  • Line 20: warning: cyclomatic complexity 55 of function runFuse() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/needle/volume_ttl.go
  • Line 144: warning: cyclomatic complexity 18 of function SecondsToTTL() is high (> 15) (gocyclo)

• seaweedfs/weed/shell/command_volume_tier_move.go
  • Line 93: warning: cyclomatic complexity 16 of function doVolumeTierMove() is high (> 15) (gocyclo)

• seaweedfs/weed/shell/command_ec_balance.go
  • Line 381: warning: cyclomatic complexity 16 of function doBalanceEcRack() is high (> 15) (gocyclo)

• seaweedfs/weed/server/volume_grpc_copy.go
  • Line 221: warning: cyclomatic complexity 18 of function (*VolumeServer).CopyFile() is high (> 15) (gocyclo)

• seaweedfs/weed/util/fla9/fla9.go
  • Line 805: warning: cyclomatic complexity 25 of function (*FlagSet).parseOne() is high (> 15) (gocyclo)
  • Line 1087: warning: cyclomatic complexity 21 of function (*FlagSet).ParseFile() is high (> 15) (gocyclo)
  • Line 887: warning: cyclomatic complexity 20 of function (*FlagSet).Parse() is high (> 15) (gocyclo)

• seaweedfs/weed/filer/elastic/v7/elastic_store.go
  • Line 204: warning: cyclomatic complexity 17 of function (*ElasticStore).listDirectoryEntries() is high (> 15) (gocyclo)

• seaweedfs/weed/iamapi/iamapi_management_handlers.go
  • Line 363: warning: cyclomatic complexity 23 of function (*IamApiServer).DoActions() is high (> 15) (gocyclo)

• seaweedfs/weed/command/filer_sync.go
  • Line 272: warning: cyclomatic complexity 20 of function genProcessFunction() is high (> 15) (gocyclo)

• seaweedfs/weed/util/httpdown/http_down.go
  • Line 181: warning: cyclomatic complexity 21 of function (*server).manage() is high (> 15) (gocyclo)

• seaweedfs/weed/s3api/s3api_object_handlers_postpolicy.go
  • Line 20: warning: cyclomatic complexity 22 of function (*S3ApiServer).PostPolicyBucketHandler() is high (> 15) (gocyclo)

• seaweedfs/weed/command/benchmark.go
  • Line 460: warning: cyclomatic complexity 24 of function (*stats).printStats() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/needle/needle_parse_upload.go
  • Line 114: warning: cyclomatic complexity 18 of function parseMultipart() is high (> 15) (gocyclo)
  • Line 35: warning: cyclomatic complexity 18 of function ParseUpload() is high (> 15) (gocyclo)

• seaweedfs/weed/topology/volume_growth.go
  • Line 123: warning: cyclomatic complexity 31 of function (*VolumeGrowth).findEmptySlotsForOneVolume() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/volume_write.go
  • Line 228: warning: cyclomatic complexity 19 of function (*Volume).startWorker() is high (> 15) (gocyclo)

• seaweedfs/weed/command/filer_meta_tail.go
  • Line 46: warning: cyclomatic complexity 21 of function runFilerMetaTail() is high (> 15) (gocyclo)

• seaweedfs/weed/command/filer_copy.go
  • Line 85: warning: cyclomatic complexity 20 of function runCopy() is high (> 15) (gocyclo)

• seaweedfs/weed/storage/needle/needle_read_write.go
  • Line 255: warning: cyclomatic complexity 19 of function (*Needle).readNeedleDataVersion2() is high (> 15) (gocyclo)
  • Line 32: warning: cyclomatic complexity 18 of function (*Needle).prepareWriteBuffer() is high (> 15) (gocyclo)

• seaweedfs/weed/server/filer_server_handlers_write_autochunk.go
  • Line 126: warning: cyclomatic complexity 22 of function (*FilerServer).saveMetaData() is high (> 15) (gocyclo)

golint27%

Golint is a linter for Go source code.

• seaweedfs/weed/wdclient/resource_pool/doc.go
  • Line 1: warning: package comment should be of the form "Package resource_pool ..." (golint)
  • Line 2: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filer/redis/universal_redis_store_kv.go
  • Line 11: warning: exported method UniversalRedisStore.KvPut should have comment or be unexported (golint)
  • Line 22: warning: exported method UniversalRedisStore.KvGet should have comment or be unexported (golint)
  • Line 33: warning: exported method UniversalRedisStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/filer/elastic/v7/elastic_store.go
  • Line 33: warning: exported type ESEntry should have comment or be unexported (golint)
  • Line 38: warning: exported type ESKVEntry should have comment or be unexported (golint)
  • Line 46: warning: exported type ElasticStore should have comment or be unexported (golint)
  • Line 51: warning: exported method ElasticStore.GetName should have comment or be unexported (golint)
  • Line 55: warning: exported method ElasticStore.Initialize should have comment or be unexported (golint)
  • Line 89: warning: exported method ElasticStore.BeginTransaction should have comment or be unexported (golint)
  • Line 92: warning: exported method ElasticStore.CommitTransaction should have comment or be unexported (golint)
  • Line 95: warning: exported method ElasticStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 99: warning: exported method ElasticStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 103: warning: exported method ElasticStore.InsertEntry should have comment or be unexported (golint)
  • Line 129: warning: exported method ElasticStore.UpdateEntry should have comment or be unexported (golint)
  • Line 133: warning: exported method ElasticStore.FindEntry should have comment or be unexported (golint)
  • Line 156: warning: exported method ElasticStore.DeleteEntry should have comment or be unexported (golint)
  • Line 189: warning: exported method ElasticStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 200: warning: exported method ElasticStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 291: warning: exported method ElasticStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/filer/mongodb/mongodb_store.go
  • Line 21: warning: exported type MongodbStore should have comment or be unexported (golint)
  • Line 27: warning: exported type Model should have comment or be unexported (golint)
  • Line 33: warning: exported method MongodbStore.GetName should have comment or be unexported (golint)
  • Line 37: warning: exported method MongodbStore.Initialize should have comment or be unexported (golint)
  • Line 84: warning: exported method MongodbStore.BeginTransaction should have comment or be unexported (golint)
  • Line 88: warning: exported method MongodbStore.CommitTransaction should have comment or be unexported (golint)
  • Line 92: warning: exported method MongodbStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 96: warning: exported method MongodbStore.InsertEntry should have comment or be unexported (golint)
  • Line 102: warning: exported method MongodbStore.UpdateEntry should have comment or be unexported (golint)
  • Line 129: warning: exported method MongodbStore.FindEntry should have comment or be unexported (golint)
  • Line 157: warning: exported method MongodbStore.DeleteEntry should have comment or be unexported (golint)
  • Line 170: warning: exported method MongodbStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 181: warning: exported method MongodbStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 185: warning: exported method MongodbStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 226: warning: exported method MongodbStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/iamapi/iamapi_response.go
  • Line 11: warning: exported type CommonResponse should have comment or be unexported (golint)
  • Line 17: warning: exported type ListUsersResponse should have comment or be unexported (golint)
  • Line 26: warning: exported type ListAccessKeysResponse should have comment or be unexported (golint)
  • Line 35: warning: exported type DeleteAccessKeyResponse should have comment or be unexported (golint)
  • Line 40: warning: exported type CreatePolicyResponse should have comment or be unexported (golint)
  • Line 48: warning: exported type CreateUserResponse should have comment or be unexported (golint)
  • Line 56: warning: exported type DeleteUserResponse should have comment or be unexported (golint)
  • Line 61: warning: exported type GetUserResponse should have comment or be unexported (golint)
  • Line 69: warning: exported type CreateAccessKeyResponse should have comment or be unexported (golint)
  • Line 77: warning: exported type PutUserPolicyResponse should have comment or be unexported (golint)
  • Line 82: warning: exported type GetUserPolicyResponse should have comment or be unexported (golint)
  • Line 92: warning: exported type ErrorResponse should have comment or be unexported (golint)
  • Line 101: warning: exported method CommonResponse.SetRequestId should have comment or be unexported (golint)

• seaweedfs/weed/util/log_buffer/sealed_buffer.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: exported type MemBuffer should have comment or be unexported (golint)
  • Line 15: warning: exported type SealedBuffers should have comment or be unexported (golint)
  • Line 32: warning: exported method SealedBuffers.SealBuffer should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_query.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported method VolumeServer.Query should have comment or be unexported (golint)
  • Line 16: warning: don't use underscores in Go names; var id_cookie should be idCookie (golint)

• seaweedfs/weed/server/webdav_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 29: warning: exported type WebDavOption should have comment or be unexported (golint)
  • Line 45: warning: exported type WebDavServer should have comment or be unexported (golint)
  • Line 53: warning: exported function NewWebDavServer should have comment or be unexported (golint)
  • Line 71: warning: exported type WebDavFileSystem should have comment or be unexported (golint)
  • Line 80: warning: exported type FileInfo should have comment or be unexported (golint)
  • Line 88: warning: exported method FileInfo.Name should have comment or be unexported (golint)
  • Line 89: warning: exported method FileInfo.Size should have comment or be unexported (golint)
  • Line 90: warning: exported method FileInfo.Mode should have comment or be unexported (golint)
  • Line 91: warning: exported method FileInfo.ModTime should have comment or be unexported (golint)
  • Line 92: warning: exported method FileInfo.IsDir should have comment or be unexported (golint)
  • Line 93: warning: exported method FileInfo.Sys should have comment or be unexported (golint)
  • Line 95: warning: exported type WebDavFile should have comment or be unexported (golint)
  • Line 108: warning: exported function NewWebDavFileSystem should have comment or be unexported (golint)
  • Line 124: warning: exported method WebDavFileSystem.WithFilerClient should have comment or be unexported (golint)
  • Line 132: warning: exported method WebDavFileSystem.AdjustedUrl should have comment or be unexported (golint)
  • Line 148: warning: exported method WebDavFileSystem.Mkdir should have comment or be unexported (golint)
  • Line 193: warning: exported method WebDavFileSystem.OpenFile should have comment or be unexported (golint)
  • Line 279: warning: exported method WebDavFileSystem.RemoveAll should have comment or be unexported (golint)
  • Line 286: warning: exported method WebDavFileSystem.Rename should have comment or be unexported (golint)
  • Line 367: warning: exported method WebDavFileSystem.Stat should have comment or be unexported (golint)
  • Line 503: warning: exported method WebDavFile.Close should have comment or be unexported (golint)
  • Line 556: warning: exported method WebDavFile.Readdir should have comment or be unexported (golint)
  • Line 599: warning: exported method WebDavFile.Seek should have comment or be unexported (golint)
  • Line 612: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 620: warning: exported method WebDavFile.Stat should have comment or be unexported (golint)

• seaweedfs/weed/filer/leveldb2/leveldb2_store_kv.go
  • Line 11: warning: exported method LevelDB2Store.KvPut should have comment or be unexported (golint)
  • Line 24: warning: exported method LevelDB2Store.KvGet should have comment or be unexported (golint)
  • Line 41: warning: exported method LevelDB2Store.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/replication/sub/notification_kafka.go
  • Line 21: warning: exported type KafkaInput should have comment or be unexported (golint)
  • Line 27: warning: exported method KafkaInput.GetName should have comment or be unexported (golint)
  • Line 31: warning: exported method KafkaInput.Initialize should have comment or be unexported (golint)
  • Line 100: warning: exported method KafkaInput.ReceiveMessage should have comment or be unexported (golint)
  • Line 111: warning: exported type KafkaProgress should have comment or be unexported (golint)

• seaweedfs/weed/operation/grpc_client.go
  • Line 17: warning: exported function WithVolumeServerClient should have comment or be unexported (golint)
  • Line 41: warning: exported function WithMasterServerClient should have comment or be unexported (golint)
  • Line 55: warning: exported function WithFilerServerClient should have comment or be unexported (golint)

• seaweedfs/weed/topology/data_center.go
  • Line 7: warning: exported type DataCenter should have comment or be unexported (golint)
  • Line 11: warning: exported function NewDataCenter should have comment or be unexported (golint)
  • Line 21: warning: exported method DataCenter.GetOrCreateRack should have comment or be unexported (golint)
  • Line 33: warning: exported method DataCenter.ToMap should have comment or be unexported (golint)
  • Line 45: warning: exported method DataCenter.ToDataCenterInfo should have comment or be unexported (golint)

• seaweedfs/weed/shell/command_volume_fix_replication.go
  • Line 273: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 301: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 318: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 347: warning: exported type VolumeReplica should have comment or be unexported (golint)

• seaweedfs/weed/command/webdav.go
  • Line 24: warning: exported type WebDavOption should have comment or be unexported (golint)
  • Line 109: warning: don't use underscores in Go names; var webdavServer_err should be webdavServerErr (golint)

• seaweedfs/weed/shell/command_volume_fsck.go
  • Line 265: warning: exported type VInfo should have comment or be unexported (golint)

• seaweedfs/weed/util/constants.go
  • Line 8: warning: exported var VERSION should have comment or be unexported (golint)
  • Line 12: warning: exported function Version should have comment or be unexported (golint)

• seaweedfs/weed/filer/abstract_sql/abstract_sql_store_kv.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported method AbstractSqlStore.KvPut should have comment or be unexported (golint)
  • Line 49: warning: exported method AbstractSqlStore.KvGet should have comment or be unexported (golint)
  • Line 72: warning: exported method AbstractSqlStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/broker_append.go
  • Line 101: warning: exported method MessageBroker.WithFilerClient should have comment or be unexported (golint)
  • Line 118: warning: exported method MessageBroker.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/images/orientation_test.go
  • Line 14: warning: don't use underscores in Go names; var fixed_data should be fixedData (golint)

• seaweedfs/weed/storage/backend/disk_file.go
  • Line 5: warning: should not use dot imports (golint)
  • Line 14: warning: exported type DiskFile should have comment or be unexported (golint)
  • Line 21: warning: exported function NewDiskFile should have comment or be unexported (golint)
  • Line 39: warning: exported method DiskFile.ReadAt should have comment or be unexported (golint)
  • Line 43: warning: exported method DiskFile.WriteAt should have comment or be unexported (golint)
  • Line 59: warning: exported method DiskFile.Truncate should have comment or be unexported (golint)
  • Line 68: warning: exported method DiskFile.Close should have comment or be unexported (golint)
  • Line 72: warning: exported method DiskFile.GetStat should have comment or be unexported (golint)
  • Line 76: warning: exported method DiskFile.Name should have comment or be unexported (golint)
  • Line 80: warning: exported method DiskFile.Sync should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map/compact_map_perf_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/util/log_buffer/log_buffer.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported const BufferSize should have comment or be unexported (golint)
  • Line 16: warning: exported const PreviousBufferCount should have comment or be unexported (golint)
  • Line 24: warning: exported type LogBuffer should have comment or be unexported (golint)
  • Line 42: warning: exported function NewLogBuffer should have comment or be unexported (golint)
  • Line 57: warning: exported method LogBuffer.AddToBuffer should have comment or be unexported (golint)
  • Line 114: warning: exported method LogBuffer.Shutdown should have comment or be unexported (golint)
  • Line 179: warning: exported method LogBuffer.ReadFromBuffer should have comment or be unexported (golint)
  • Line 263: warning: exported method LogBuffer.ReleaseMemory should have comment or be unexported (golint)

• seaweedfs/weed/command/benchmark.go
  • Line 26: warning: exported type BenchmarkOptions should have comment or be unexported (golint)
  • Line 548: warning: comment on exported type FakeReader should be of the form "FakeReader ..." (with optional leading article) (golint)
  • Line 574: warning: exported method FakeReader.WriteTo should have comment or be unexported (golint)
  • Line 591: warning: exported function Readln should have comment or be unexported (golint)

• seaweedfs/weed/server/gateway_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 26: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 34: warning: exported type GatewayOption should have comment or be unexported (golint)
  • Line 41: warning: exported type GatewayServer should have comment or be unexported (golint)
  • Line 47: warning: exported function NewGatewayServer should have comment or be unexported (golint)

• seaweedfs/unmaintained/remove_duplicate_fids/remove_duplicate_fids.go
  • Line 22: warning: exported function Checksum should have comment or be unexported (golint)
  • Line 26: warning: exported type VolumeFileScanner4SeeDat should have comment or be unexported (golint)
  • Line 36: warning: exported method VolumeFileScanner4SeeDat.VisitSuperBlock should have comment or be unexported (golint)
  • Line 42: warning: exported method VolumeFileScanner4SeeDat.ReadNeedleBody should have comment or be unexported (golint)
  • Line 46: warning: exported method VolumeFileScanner4SeeDat.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/replication/sub/notification_aws_sqs.go
  • Line 21: warning: exported type AwsSqsInput should have comment or be unexported (golint)
  • Line 26: warning: exported method AwsSqsInput.GetName should have comment or be unexported (golint)
  • Line 30: warning: exported method AwsSqsInput.Initialize should have comment or be unexported (golint)
  • Line 71: warning: exported method AwsSqsInput.ReceiveMessage should have comment or be unexported (golint)

• seaweedfs/weed/operation/submit.go
  • Line 18: warning: exported type FilePart should have comment or be unexported (golint)
  • Line 34: warning: exported type SubmitResult should have comment or be unexported (golint)
  • Line 42: warning: exported type GetMasterFn should have comment or be unexported (golint)
  • Line 44: warning: exported function SubmitFiles should have comment or be unexported (golint)
  • Line 88: warning: exported function NewFileParts should have comment or be unexported (golint)
  • Line 121: warning: exported method FilePart.Upload should have comment or be unexported (golint)
  • Line 218: warning: don't use underscores in Go names; func upload_one_chunk should be uploadOneChunk (golint)
  • Line 229: warning: don't use underscores in Go names; func upload_chunked_file_manifest should be uploadChunkedFileManifest (golint)

• seaweedfs/weed/operation/upload_content.go
  • Line 23: warning: exported type UploadResult should have comment or be unexported (golint)
  • Line 35: warning: exported method UploadResult.ToPbFileChunk should have comment or be unexported (golint)
  • Line 55: warning: exported var HttpClient should have comment or be unexported (golint)
  • Line 67: warning: comment on exported function UploadData should be of the form "UploadData ..." (golint)
  • Line 74: warning: error should be the last type when returning multiple items (golint)
  • Line 79: warning: error should be the last type when returning multiple items (golint)
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 190: warning: don't use underscores in Go names; func upload_content should be uploadContent (golint)
  • Line 193: warning: don't use underscores in Go names; var body_writer should be bodyWriter (golint)
  • Line 207: warning: don't use underscores in Go names; var file_writer should be fileWriter (golint)
  • Line 207: warning: don't use underscores in Go names; var cp_err should be cpErr (golint)
  • Line 216: warning: don't use underscores in Go names; var content_type should be contentType (golint)
  • Line 235: warning: don't use underscores in Go names; var post_err should be postErr (golint)
  • Line 255: warning: don't use underscores in Go names; var resp_body should be respBody (golint)
  • Line 255: warning: don't use underscores in Go names; var ra_err should be raErr (golint)
  • Line 260: warning: don't use underscores in Go names; var unmarshal_err should be unmarshalErr (golint)

• seaweedfs/weed/storage/types/offset_4bytes.go
  • Line 9: warning: exported type OffsetHigher should have comment or be unexported (golint)
  • Line 14: warning: exported const OffsetSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported function OffsetToBytes should have comment or be unexported (golint)
  • Line 25: warning: comment on exported function Uint32ToOffset should be of the form "Uint32ToOffset ..." (golint)
  • Line 37: warning: exported function BytesToOffset should have comment or be unexported (golint)
  • Line 48: warning: exported method Offset.IsZero should have comment or be unexported (golint)
  • Line 52: warning: exported function ToOffset should have comment or be unexported (golint)
  • Line 57: warning: exported method Offset.ToActualOffset should have comment or be unexported (golint)

• seaweedfs/weed/shell/command_volume_balance.go
  • Line 179: warning: should omit 2nd value from range; this loop is equivalent to `for diskType := range ...` (golint)
  • Line 187: warning: should omit 2nd value from range; this loop is equivalent to `for diskType := range ...` (golint)
  • Line 193: warning: exported type Node should have comment or be unexported (golint)
  • Line 200: warning: exported type CapacityFunc should have comment or be unexported (golint)
  • Line 329: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/s3api/s3api_object_handlers.go
  • Line 39: warning: exported method S3ApiServer.PutObjectHandler should have comment or be unexported (golint)
  • Line 118: warning: exported method S3ApiServer.GetObjectHandler should have comment or be unexported (golint)
  • Line 134: warning: exported method S3ApiServer.HeadObjectHandler should have comment or be unexported (golint)
  • Line 145: warning: exported method S3ApiServer.DeleteObjectHandler should have comment or be unexported (golint)
  • Line 160: warning: comment on exported type ObjectIdentifier should be of the form "ObjectIdentifier ..." (with optional leading article) (golint)
  • Line 262: warning: should omit 2nd value from range; this loop is equivalent to `for dir := range ...` (golint)
  • Line 394: warning: don't use underscores in Go names; var resp_body should be respBody (golint)
  • Line 394: warning: don't use underscores in Go names; var ra_err should be raErr (golint)
  • Line 400: warning: don't use underscores in Go names; var unmarshal_err should be unmarshalErr (golint)

• seaweedfs/weed/util/parse.go
  • Line 10: warning: exported function ParseInt should have comment or be unexported (golint)
  • Line 20: warning: exported function ParseUint64 should have comment or be unexported (golint)
  • Line 31: warning: exported function ParseFilerUrl should have comment or be unexported (golint)
  • Line 50: warning: exported function ParseHostPort should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis/universal_redis_store.go
  • Line 19: warning: exported const DIR_LIST_MARKER should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported type UniversalRedisStore should have comment or be unexported (golint)
  • Line 26: warning: exported method UniversalRedisStore.BeginTransaction should have comment or be unexported (golint)
  • Line 29: warning: exported method UniversalRedisStore.CommitTransaction should have comment or be unexported (golint)
  • Line 32: warning: exported method UniversalRedisStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 36: warning: exported method UniversalRedisStore.InsertEntry should have comment or be unexported (golint)
  • Line 64: warning: exported method UniversalRedisStore.UpdateEntry should have comment or be unexported (golint)
  • Line 69: warning: exported method UniversalRedisStore.FindEntry should have comment or be unexported (golint)
  • Line 91: warning: exported method UniversalRedisStore.DeleteEntry should have comment or be unexported (golint)
  • Line 110: warning: exported method UniversalRedisStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 128: warning: exported method UniversalRedisStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 132: warning: exported method UniversalRedisStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 198: warning: exported method UniversalRedisStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/notification/configuration.go
  • Line 9: warning: exported type MessageQueue should have comment or be unexported (golint)
  • Line 18: warning: exported var MessageQueues should have comment or be unexported (golint)
  • Line 23: warning: exported function LoadConfiguration should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_volume_info.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: comment on exported type EcVolumeInfo should be of the form "EcVolumeInfo ..." (with optional leading article) (golint)
  • Line 16: warning: exported function NewEcVolumeInfo should have comment or be unexported (golint)
  • Line 25: warning: exported method EcVolumeInfo.AddShardId should have comment or be unexported (golint)
  • Line 29: warning: exported method EcVolumeInfo.RemoveShardId should have comment or be unexported (golint)
  • Line 33: warning: exported method EcVolumeInfo.HasShardId should have comment or be unexported (golint)
  • Line 37: warning: exported method EcVolumeInfo.ShardIds should have comment or be unexported (golint)
  • Line 41: warning: exported method EcVolumeInfo.ShardIdCount should have comment or be unexported (golint)
  • Line 45: warning: exported method EcVolumeInfo.Minus should have comment or be unexported (golint)
  • Line 56: warning: exported method EcVolumeInfo.ToVolumeEcShardInformationMessage should have comment or be unexported (golint)
  • Line 65: warning: exported type ShardBits should have comment or be unexported (golint)
  • Line 67: warning: exported method ShardBits.AddShardId should have comment or be unexported (golint)
  • Line 71: warning: exported method ShardBits.RemoveShardId should have comment or be unexported (golint)
  • Line 75: warning: exported method ShardBits.HasShardId should have comment or be unexported (golint)
  • Line 79: warning: exported method ShardBits.ShardIds should have comment or be unexported (golint)
  • Line 88: warning: exported method ShardBits.ToUint32Slice should have comment or be unexported (golint)
  • Line 97: warning: exported method ShardBits.ShardIdCount should have comment or be unexported (golint)
  • Line 104: warning: exported method ShardBits.Minus should have comment or be unexported (golint)
  • Line 108: warning: exported method ShardBits.Plus should have comment or be unexported (golint)
  • Line 112: warning: exported method ShardBits.MinusParityShards should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/exclusive_locks/exclusive_locker.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported const RenewInteval should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type ExclusiveLocker should have comment or be unexported (golint)
  • Line 27: warning: exported function NewExclusiveLocker should have comment or be unexported (golint)
  • Line 32: warning: exported method ExclusiveLocker.IsLocking should have comment or be unexported (golint)
  • Line 36: warning: exported method ExclusiveLocker.GetToken should have comment or be unexported (golint)
  • Line 44: warning: exported method ExclusiveLocker.RequestLock should have comment or be unexported (golint)
  • Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 107: warning: exported method ExclusiveLocker.ReleaseLock should have comment or be unexported (golint)

• seaweedfs/weed/command/export.go
  • Line 34: warning: exported type ExportOptions should have comment or be unexported (golint)
  • Line 93: warning: exported type VolumeFileScanner4Export should have comment or be unexported (golint)
  • Line 100: warning: exported method VolumeFileScanner4Export.VisitSuperBlock should have comment or be unexported (golint)
  • Line 105: warning: exported method VolumeFileScanner4Export.ReadNeedleBody should have comment or be unexported (golint)
  • Line 109: warning: exported method VolumeFileScanner4Export.VisitNeedle should have comment or be unexported (golint)
  • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/security/tls.go
  • Line 21: warning: exported type Authenticator should have comment or be unexported (golint)
  • Line 26: warning: exported function LoadServerTLS should have comment or be unexported (golint)
  • Line 69: warning: exported function LoadClientTLS should have comment or be unexported (golint)
  • Line 101: warning: exported method Authenticator.Authenticate should have comment or be unexported (golint)

• seaweedfs/weed/util/grace/pprof.go
  • Line 11: warning: exported function SetupProfiling should have comment or be unexported (golint)

• seaweedfs/weed/command/fix.go
  • Line 35: warning: exported type VolumeFileScanner4Fix should have comment or be unexported (golint)
  • Line 40: warning: exported method VolumeFileScanner4Fix.VisitSuperBlock should have comment or be unexported (golint)
  • Line 45: warning: exported method VolumeFileScanner4Fix.ReadNeedleBody should have comment or be unexported (golint)
  • Line 49: warning: exported method VolumeFileScanner4Fix.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/ftpd/ftp_server.go
  • Line 13: warning: exported type FtpServerOption should have comment or be unexported (golint)
  • Line 25: warning: exported type SftpServer should have comment or be unexported (golint)
  • Line 32: warning: comment on exported function NewFtpServer should be of the form "NewFtpServer ..." (golint)

• seaweedfs/weed/filer/filer.go
  • Line 20: warning: exported const LogFlushInterval should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported var OS_UID should have comment or be unexported (golint)
  • Line 30: warning: exported type Filer should have comment or be unexported (golint)
  • Line 47: warning: exported function NewFiler should have comment or be unexported (golint)
  • Line 64: warning: exported method Filer.AggregateFromPeers should have comment or be unexported (golint)
  • Line 82: warning: exported method Filer.SetStore should have comment or be unexported (golint)
  • Line 107: warning: exported method Filer.GetStore should have comment or be unexported (golint)
  • Line 111: warning: exported method Filer.GetMaster should have comment or be unexported (golint)
  • Line 111: warning: receiver name fs should be consistent with previous receiver name f for Filer (golint)
  • Line 115: warning: exported method Filer.KeepConnectedToMaster should have comment or be unexported (golint)
  • Line 115: warning: receiver name fs should be consistent with previous receiver name f for Filer (golint)
  • Line 119: warning: exported method Filer.BeginTransaction should have comment or be unexported (golint)
  • Line 123: warning: exported method Filer.CommitTransaction should have comment or be unexported (golint)
  • Line 127: warning: exported method Filer.RollbackTransaction should have comment or be unexported (golint)
  • Line 131: warning: exported method Filer.CreateEntry should have comment or be unexported (golint)
  • Line 131: warning: don't use underscores in Go names; method parameter o_excl should be oExcl (golint)
  • Line 240: warning: exported method Filer.UpdateEntry should have comment or be unexported (golint)
  • Line 256: warning: exported var Root should have comment or be unexported (golint)
  • Line 268: warning: exported method Filer.FindEntry should have comment or be unexported (golint)
  • Line 301: warning: exported method Filer.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/filer/meta_replay.go
  • Line 11: warning: exported function Replay should have comment or be unexported (golint)

• seaweedfs/weed/filesys/wfs.go
  • Line 32: warning: exported type Option should have comment or be unexported (golint)
  • Line 68: warning: exported type WFS should have comment or be unexported (golint)
  • Line 95: warning: exported function NewSeaweedFileSystem should have comment or be unexported (golint)
  • Line 144: warning: exported method WFS.Root should have comment or be unexported (golint)
  • Line 148: warning: exported method WFS.AcquireHandle should have comment or be unexported (golint)
  • Line 179: warning: exported method WFS.ReleaseHandle should have comment or be unexported (golint)
  • Line 266: warning: exported method WFS.LookupFn should have comment or be unexported (golint)
  • Line 292: warning: exported type NodeWithId should have comment or be unexported (golint)
  • Line 294: warning: exported method NodeWithId.Id should have comment or be unexported (golint)
  • Line 297: warning: exported method NodeWithId.Attr should have comment or be unexported (golint)

• seaweedfs/weed/storage/types/needle_id_type.go
  • Line 9: warning: exported type NeedleId should have comment or be unexported (golint)
  • Line 12: warning: exported const NeedleIdSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported function NeedleIdToBytes should have comment or be unexported (golint)
  • Line 25: warning: exported function Uint64ToNeedleId should have comment or be unexported (golint)
  • Line 29: warning: exported function BytesToNeedleId should have comment or be unexported (golint)
  • Line 37: warning: exported function ParseNeedleId should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3api_object_copy_handlers.go
  • Line 17: warning: exported method S3ApiServer.CopyObjectHandler should have comment or be unexported (golint)
  • Line 100: warning: exported type CopyPartResult should have comment or be unexported (golint)
  • Line 105: warning: exported method S3ApiServer.CopyObjectPartHandler should have comment or be unexported (golint)

• seaweedfs/weed/server/common.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 211: warning: exported var StaticFS should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_read.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 24: warning: exported method FilerServer.GetOrHeadHandler should have comment or be unexported (golint)
  • Line 104: warning: should omit 2nd value from range; this loop is equivalent to `for header := range ...` (golint)

• seaweedfs/weed/weed.go
  • Line 23: warning: exported var IsDebug should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server_ui/templates.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: don't use underscores in Go names; func parameter part_of should be partOf (golint)
  • Line 29: warning: exported var StatusTpl should have comment or be unexported (golint)

• seaweedfs/weed/util/bounded_tree/bounded_tree.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type Node should have comment or be unexported (golint)
  • Line 16: warning: exported type BoundedTree should have comment or be unexported (golint)
  • Line 22: warning: exported function NewBoundedTree should have comment or be unexported (golint)
  • Line 31: warning: exported type VisitNodeFunc should have comment or be unexported (golint)
  • Line 33: warning: comment on exported method BoundedTree.EnsureVisited should be of the form "EnsureVisited ..." (golint)
  • Line 142: warning: exported method BoundedTree.HasVisited should have comment or be unexported (golint)

• seaweedfs/weed/command/filer_backup.go
  • Line 17: warning: exported type FilerBackupOptions should have comment or be unexported (golint)
  • Line 72: warning: exported const BackupKeyPrefix should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/replication/sink/filersink/fetch_write.go
  • Line 125: warning: exported method FilerSink.WithFilerClient should have comment or be unexported (golint)
  • Line 133: warning: exported method FilerSink.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/storage/types/volume_disk_type.go
  • Line 7: warning: exported type DiskType should have comment or be unexported (golint)
  • Line 10: warning: exported const HardDriveType should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported function ToDiskType should have comment or be unexported (golint)
  • Line 35: warning: exported method DiskType.ReadableString should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_test.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 202: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• seaweedfs/weed/storage/needle/needle_read_write.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 15: warning: exported const FlagIsCompressed should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported var ErrorSizeMismatch should have comment or be unexported (golint)
  • Line 28: warning: exported method Needle.DiskSize should have comment or be unexported (golint)
  • Line 129: warning: exported method Needle.Append should have comment or be unexported (golint)
  • Line 158: warning: exported function WriteNeedleBlob should have comment or be unexported (golint)
  • Line 187: warning: exported function ReadNeedleBlob should have comment or be unexported (golint)
  • Line 249: warning: exported method Needle.ParseNeedleHeader should have comment or be unexported (golint)
  • Line 316: warning: exported function ReadNeedleHeader should have comment or be unexported (golint)
  • Line 334: warning: exported function PaddingLength should have comment or be unexported (golint)
  • Line 342: warning: exported function NeedleBodyLength should have comment or be unexported (golint)
  • Line 349: warning: comment on exported method Needle.ReadNeedleBody should be of the form "ReadNeedleBody ..." (golint)
  • Line 366: warning: exported method Needle.ReadNeedleBodyBytes should have comment or be unexported (golint)
  • Line 389: warning: exported method Needle.IsCompressed should have comment or be unexported (golint)
  • Line 392: warning: exported method Needle.SetIsCompressed should have comment or be unexported (golint)
  • Line 395: warning: exported method Needle.HasName should have comment or be unexported (golint)
  • Line 398: warning: exported method Needle.SetHasName should have comment or be unexported (golint)
  • Line 401: warning: exported method Needle.HasMime should have comment or be unexported (golint)
  • Line 404: warning: exported method Needle.SetHasMime should have comment or be unexported (golint)
  • Line 407: warning: exported method Needle.HasLastModifiedDate should have comment or be unexported (golint)
  • Line 410: warning: exported method Needle.SetHasLastModifiedDate should have comment or be unexported (golint)
  • Line 413: warning: exported method Needle.HasTtl should have comment or be unexported (golint)
  • Line 416: warning: exported method Needle.SetHasTtl should have comment or be unexported (golint)
  • Line 420: warning: exported method Needle.IsChunkedManifest should have comment or be unexported (golint)
  • Line 424: warning: exported method Needle.SetIsChunkManifest should have comment or be unexported (golint)
  • Line 428: warning: exported method Needle.HasPairs should have comment or be unexported (golint)
  • Line 432: warning: exported method Needle.SetHasPairs should have comment or be unexported (golint)
  • Line 436: warning: exported function GetActualSize should have comment or be unexported (golint)

• seaweedfs/weed/util/net_timeout.go
  • Line 18: warning: exported method Listener.Accept should have comment or be unexported (golint)
  • Line 70: warning: exported method Conn.Close should have comment or be unexported (golint)
  • Line 81: warning: exported function NewListener should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_grpc_server_kv.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: exported method FilerServer.KvGet should have comment or be unexported (golint)

• seaweedfs/weed/notification/gocdk_pub_sub/gocdk_pub_sub.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 48: warning: exported type GoCDKPubSub should have comment or be unexported (golint)
  • Line 53: warning: exported method GoCDKPubSub.GetName should have comment or be unexported (golint)
  • Line 79: warning: exported method GoCDKPubSub.Initialize should have comment or be unexported (golint)
  • Line 91: warning: exported method GoCDKPubSub.SendMessage should have comment or be unexported (golint)

• seaweedfs/weed/filer/reader_at.go
  • Line 18: warning: exported type ChunkReadAt should have comment or be unexported (golint)
  • Line 34: warning: exported function LookupFn should have comment or be unexported (golint)
  • Line 88: warning: exported function NewChunkReaderAtFromClient should have comment or be unexported (golint)
  • Line 98: warning: exported method ChunkReadAt.Close should have comment or be unexported (golint)
  • Line 104: warning: exported method ChunkReadAt.ReadAt should have comment or be unexported (golint)

• seaweedfs/weed/operation/chunked_file.go
  • Line 20: warning: comment on exported var ErrRangeRequestsNotSupported should be of the form "ErrRangeRequestsNotSupported ..." (golint)
  • Line 26: warning: exported type ChunkInfo should have comment or be unexported (golint)
  • Line 32: warning: exported type ChunkList should have comment or be unexported (golint)
  • Line 34: warning: exported type ChunkManifest should have comment or be unexported (golint)
  • Line 41: warning: comment on exported type ChunkedFileReader should be of the form "ChunkedFileReader ..." (with optional leading article) (golint)
  • Line 56: warning: exported function LoadChunkManifest should have comment or be unexported (golint)
  • Line 71: warning: exported method ChunkManifest.Marshal should have comment or be unexported (golint)
  • Line 75: warning: exported method ChunkManifest.DeleteChunks should have comment or be unexported (golint)
  • Line 129: warning: exported function NewChunkedFileReader should have comment or be unexported (golint)
  • Line 142: warning: exported method ChunkedFileReader.Seek should have comment or be unexported (golint)
  • Line 161: warning: exported method ChunkedFileReader.WriteTo should have comment or be unexported (golint)
  • Line 185: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 195: warning: exported method ChunkedFileReader.ReadAt should have comment or be unexported (golint)
  • Line 204: warning: exported method ChunkedFileReader.Close should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle/crc.go
  • Line 14: warning: exported type CRC should have comment or be unexported (golint)
  • Line 16: warning: exported function NewCRC should have comment or be unexported (golint)
  • Line 20: warning: exported method CRC.Update should have comment or be unexported (golint)
  • Line 24: warning: exported method CRC.Value should have comment or be unexported (golint)
  • Line 28: warning: exported method Needle.Etag should have comment or be unexported (golint)
  • Line 34: warning: exported function NewCRCwriter should have comment or be unexported (golint)
  • Line 43: warning: exported type CRCwriter should have comment or be unexported (golint)
  • Line 54: warning: exported method CRCwriter.Sum should have comment or be unexported (golint)

• seaweedfs/weed/topology/rack.go
  • Line 10: warning: exported type Rack should have comment or be unexported (golint)
  • Line 14: warning: exported function NewRack should have comment or be unexported (golint)
  • Line 24: warning: exported method Rack.FindDataNode should have comment or be unexported (golint)
  • Line 33: warning: exported method Rack.GetOrCreateDataNode should have comment or be unexported (golint)
  • Line 55: warning: exported method Rack.ToMap should have comment or be unexported (golint)
  • Line 67: warning: exported method Rack.ToRackInfo should have comment or be unexported (golint)

• seaweedfs/weed/topology/topology_event_handling.go
  • Line 13: warning: exported method Topology.StartRefreshWritableVolumes should have comment or be unexported (golint)
  • Line 25: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
  • Line 42: warning: exported method Topology.SetVolumeCapacityFull should have comment or be unexported (golint)
  • Line 71: warning: exported method Topology.SetVolumeCrowded should have comment or be unexported (golint)
  • Line 77: warning: exported method Topology.UnRegisterDataNode should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_batch_delete.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported method VolumeServer.BatchDelete should have comment or be unexported (golint)
  • Line 21: warning: don't use underscores in Go names; var id_cookie should be idCookie (golint)

• seaweedfs/weed/messaging/msgclient/chan_sub.go
  • Line 15: warning: exported type SubChannel should have comment or be unexported (golint)
  • Line 22: warning: exported method MessagingClient.NewSubChannel should have comment or be unexported (golint)
  • Line 75: warning: exported method SubChannel.Channel should have comment or be unexported (golint)
  • Line 79: warning: exported method SubChannel.Md5 should have comment or be unexported (golint)
  • Line 83: warning: exported method SubChannel.Cancel should have comment or be unexported (golint)

• seaweedfs/weed/pb/volume_info.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 63: warning: exported function SaveVolumeInfo should have comment or be unexported (golint)

• seaweedfs/weed/iamapi/iamapi_server.go
  • Line 14: warning: should not use dot imports (golint)
  • Line 22: warning: exported type IamS3ApiConfig should have comment or be unexported (golint)
  • Line 29: warning: exported type IamS3ApiConfigure should have comment or be unexported (golint)
  • Line 34: warning: exported type IamServerOption should have comment or be unexported (golint)
  • Line 42: warning: exported type IamApiServer should have comment or be unexported (golint)
  • Line 49: warning: exported function NewIamApiServer should have comment or be unexported (golint)
  • Line 77: warning: exported method IamS3ApiConfigure.GetS3ApiConfiguration should have comment or be unexported (golint)
  • Line 96: warning: exported method IamS3ApiConfigure.PutS3ApiConfiguration should have comment or be unexported (golint)
  • Line 113: warning: exported method IamS3ApiConfigure.GetPolicies should have comment or be unexported (golint)
  • Line 134: warning: exported method IamS3ApiConfigure.PutPolicies should have comment or be unexported (golint)

• seaweedfs/weed/replication/sub/notification_google_pub_sub.go
  • Line 20: warning: exported type GooglePubSubInput should have comment or be unexported (golint)
  • Line 26: warning: exported method GooglePubSubInput.GetName should have comment or be unexported (golint)
  • Line 30: warning: exported method GooglePubSubInput.Initialize should have comment or be unexported (golint)
  • Line 40: warning: don't use underscores in Go names; method parameter google_application_credentials should be googleApplicationCredentials (golint)
  • Line 93: warning: exported method GooglePubSubInput.ReceiveMessage should have comment or be unexported (golint)

• seaweedfs/weed/storage/disk_location.go
  • Line 20: warning: exported type DiskLocation should have comment or be unexported (golint)
  • Line 37: warning: exported function NewDiskLocation should have comment or be unexported (golint)
  • Line 141: warning: don't use underscores in Go names; var task_queue should be taskQueue (golint)
  • Line 183: warning: exported method DiskLocation.DeleteCollectionFromDiskLocation should have comment or be unexported (golint)
  • Line 243: warning: exported method DiskLocation.LoadVolume should have comment or be unexported (golint)
  • Line 250: warning: exported method DiskLocation.DeleteVolume should have comment or be unexported (golint)
  • Line 262: warning: exported method DiskLocation.UnloadVolume should have comment or be unexported (golint)
  • Line 289: warning: exported method DiskLocation.SetVolume should have comment or be unexported (golint)
  • Line 297: warning: exported method DiskLocation.FindVolume should have comment or be unexported (golint)
  • Line 305: warning: exported method DiskLocation.VolumesLen should have comment or be unexported (golint)
  • Line 312: warning: exported method DiskLocation.Close should have comment or be unexported (golint)
  • Line 328: warning: exported method DiskLocation.LocateVolume should have comment or be unexported (golint)
  • Line 341: warning: exported method DiskLocation.UnUsedSpace should have comment or be unexported (golint)
  • Line 357: warning: exported method DiskLocation.CheckDiskSpace should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/broker_grpc_server_subscribe.go
  • Line 18: warning: exported method MessageBroker.Subscribe should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/resource_pool/semaphore.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type Semaphore should have comment or be unexported (golint)
  • Line 27: warning: comment on exported function NewBoundedSemaphore should be of the form "NewBoundedSemaphore ..." (golint)
  • Line 84: warning: comment on exported function NewUnboundedSemaphore should be of the form "NewUnboundedSemaphore ..." (golint)

• seaweedfs/weed/shell/command_fs_tree.go
  • Line 78: warning: exported type Prefix should have comment or be unexported (golint)

• seaweedfs/weed/util/buffered_writer/buffered_writer.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type BufferedWriteCloser should have comment or be unexported (golint)
  • Line 19: warning: exported function NewBufferedWriteCloser should have comment or be unexported (golint)
  • Line 39: warning: exported method BufferedWriteCloser.Close should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/resource_pool/multi_resource_pool.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 26: warning: comment on exported function NewMultiResourcePool should be of the form "NewMultiResourcePool ..." (golint)
  • Line 136: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

• seaweedfs/weed/command/mount.go
  • Line 8: warning: exported type MountOptions should have comment or be unexported (golint)

• seaweedfs/weed/filer/hbase/hbase_store_kv.go
  • Line 11: warning: exported const COLUMN_NAME should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported method HbaseStore.KvPut should have comment or be unexported (golint)
  • Line 18: warning: exported method HbaseStore.KvGet should have comment or be unexported (golint)
  • Line 22: warning: exported method HbaseStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/glog/glog.go
  • Line 883: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

• seaweedfs/weed/replication/sub/notifications.go
  • Line 8: warning: exported type NotificationInput should have comment or be unexported (golint)
  • Line 17: warning: exported var NotificationInputs should have comment or be unexported (golint)

• seaweedfs/weed/operation/lookup.go
  • Line 18: warning: exported type Location should have comment or be unexported (golint)
  • Line 22: warning: exported type LookupResult should have comment or be unexported (golint)
  • Line 36: warning: exported function Lookup should have comment or be unexported (golint)
  • Line 37: warning: don't use underscores in Go names; var cache_err should be cacheErr (golint)
  • Line 48: warning: don't use underscores in Go names; func do_lookup should be doLookup (golint)
  • Line 67: warning: exported function LookupFileId should have comment or be unexported (golint)
  • Line 85: warning: don't use underscores in Go names; var unknown_vids should be unknownVids (golint)
  • Line 89: warning: don't use underscores in Go names; var cache_err should be cacheErr (golint)

• seaweedfs/weed/filesys/file.go
  • Line 31: warning: exported type File should have comment or be unexported (golint)
  • Line 45: warning: exported method File.Id should have comment or be unexported (golint)
  • Line 49: warning: exported method File.Attr should have comment or be unexported (golint)
  • Line 84: warning: exported method File.Getxattr should have comment or be unexported (golint)
  • Line 96: warning: exported method File.Open should have comment or be unexported (golint)
  • Line 110: warning: exported method File.Setattr should have comment or be unexported (golint)
  • Line 188: warning: exported method File.Setxattr should have comment or be unexported (golint)
  • Line 210: warning: exported method File.Removexattr should have comment or be unexported (golint)
  • Line 232: warning: exported method File.Listxattr should have comment or be unexported (golint)
  • Line 249: warning: exported method File.Fsync should have comment or be unexported (golint)
  • Line 257: warning: exported method File.Forget should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_info.go
  • Line 12: warning: exported type VolumeInfo should have comment or be unexported (golint)
  • Line 30: warning: exported function NewVolumeInfo should have comment or be unexported (golint)
  • Line 55: warning: exported function NewVolumeInfoFromShort should have comment or be unexported (golint)
  • Line 71: warning: exported method VolumeInfo.IsRemote should have comment or be unexported (golint)
  • Line 80: warning: exported method VolumeInfo.ToVolumeInformationMessage should have comment or be unexported (golint)

• seaweedfs/weed/topology/topology_map.go
  • Line 5: warning: exported method Topology.ToMap should have comment or be unexported (golint)
  • Line 30: warning: exported method Topology.ToVolumeMap should have comment or be unexported (golint)
  • Line 57: warning: exported method Topology.ToVolumeLocations should have comment or be unexported (golint)
  • Line 81: warning: exported method Topology.ToTopologyInfo should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_write_cipher.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/topology/volume_layout.go
  • Line 35: warning: exported function ExistCopies should have comment or be unexported (golint)
  • Line 39: warning: exported function NoCopies should have comment or be unexported (golint)
  • Line 50: warning: exported function NewVolumesBinaryState should have comment or be unexported (golint)
  • Line 104: warning: comment on exported type VolumeLayout should be of the form "VolumeLayout ..." (with optional leading article) (golint)
  • Line 119: warning: exported type VolumeLayoutStats should have comment or be unexported (golint)
  • Line 125: warning: exported function NewVolumeLayout should have comment or be unexported (golint)
  • Line 146: warning: exported method VolumeLayout.RegisterVolume should have comment or be unexported (golint)
  • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 185: warning: exported method VolumeLayout.UnRegisterVolume should have comment or be unexported (golint)
  • Line 208: warning: exported method VolumeLayout.EnsureCorrectWritables should have comment or be unexported (golint)
  • Line 253: warning: exported method VolumeLayout.Lookup should have comment or be unexported (golint)
  • Line 263: warning: exported method VolumeLayout.ListVolumeServers should have comment or be unexported (golint)
  • Line 273: warning: exported method VolumeLayout.PickForWrite should have comment or be unexported (golint)
  • Line 313: warning: exported method VolumeLayout.GetActiveVolumeCount should have comment or be unexported (golint)
  • Line 367: warning: exported method VolumeLayout.SetVolumeUnavailable should have comment or be unexported (golint)
  • Line 383: warning: exported method VolumeLayout.SetVolumeAvailable should have comment or be unexported (golint)
  • Line 410: warning: exported method VolumeLayout.SetVolumeCapacityFull should have comment or be unexported (golint)
  • Line 429: warning: exported method VolumeLayout.SetVolumeCrowded should have comment or be unexported (golint)
  • Line 444: warning: exported method VolumeLayout.ToMap should have comment or be unexported (golint)
  • Line 453: warning: exported method VolumeLayout.Stats should have comment or be unexported (golint)

• seaweedfs/weed/query/sqltypes/value.go
  • Line 17: warning: exported type Value should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_on_meta_event.go
  • Line 72: warning: exported method Filer.LoadFilerConf should have comment or be unexported (golint)

• seaweedfs/weed/stats/stats.go
  • Line 7: warning: exported type ServerStats should have comment or be unexported (golint)
  • Line 18: warning: exported type Channels should have comment or be unexported (golint)
  • Line 30: warning: exported var Chan should have comment or be unexported (golint)
  • Line 46: warning: exported function NewServerStats should have comment or be unexported (golint)
  • Line 59: warning: exported function ConnectionOpen should have comment or be unexported (golint)
  • Line 62: warning: exported function ConnectionClose should have comment or be unexported (golint)
  • Line 65: warning: exported function RequestOpen should have comment or be unexported (golint)
  • Line 68: warning: exported function RequestClose should have comment or be unexported (golint)
  • Line 71: warning: exported function AssignRequest should have comment or be unexported (golint)
  • Line 74: warning: exported function ReadRequest should have comment or be unexported (golint)
  • Line 77: warning: exported function WriteRequest should have comment or be unexported (golint)
  • Line 80: warning: exported function DeleteRequest should have comment or be unexported (golint)
  • Line 83: warning: exported function BytesIn should have comment or be unexported (golint)
  • Line 86: warning: exported function BytesOut should have comment or be unexported (golint)
  • Line 90: warning: exported method ServerStats.Start should have comment or be unexported (golint)

• seaweedfs/weed/util/grace/signal_handling.go
  • Line 29: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
  • Line 38: warning: exported function OnInterrupt should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/resource_pool/managed_handle.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: comment on exported type ManagedHandle should be of the form "ManagedHandle ..." (with optional leading article) (golint)
  • Line 45: warning: comment on exported function NewManagedHandle should be of the form "NewManagedHandle ..." (golint)

• seaweedfs/weed/topology/volume_growth.go
  • Line 27: warning: exported type VolumeGrowRequest should have comment or be unexported (golint)
  • Line 33: warning: exported type VolumeGrowOption should have comment or be unexported (golint)
  • Line 45: warning: exported type VolumeGrowth should have comment or be unexported (golint)
  • Line 54: warning: exported method VolumeGrowOption.Threshold should have comment or be unexported (golint)
  • Line 59: warning: exported function NewDefaultVolumeGrowth should have comment or be unexported (golint)
  • Line 80: warning: exported method VolumeGrowth.AutomaticGrowByType should have comment or be unexported (golint)
  • Line 90: warning: exported method VolumeGrowth.GrowByCountAndType should have comment or be unexported (golint)
  • Line 126: warning: don't use underscores in Go names; var dc_err should be dcErr (golint)

• seaweedfs/weed/util/limiter.go
  • Line 18: warning: exported function NewLimitedConcurrentExecutor should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type OperationRequest should be of the form "OperationRequest ..." (with optional leading article) (golint)
  • Line 52: warning: exported type LimitedOutOfOrderProcessor should have comment or be unexported (golint)
  • Line 60: warning: exported function NewLimitedOutOfOrderProcessor should have comment or be unexported (golint)
  • Line 111: warning: exported method LimitedOutOfOrderProcessor.Execute should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/localsink/local_incremental_sink.go
  • Line 7: warning: exported type LocalIncSink should have comment or be unexported (golint)
  • Line 11: warning: exported method LocalIncSink.GetName should have comment or be unexported (golint)

• seaweedfs/weed/filer/s3iam_conf.go
  • Line 10: warning: exported function ParseS3ConfigurationFromBytes should have comment or be unexported (golint)
  • Line 17: warning: exported function S3ConfigurationToText should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dir_link.go
  • Line 22: warning: exported const HARD_LINK_MARKER should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported method Dir.Link should have comment or be unexported (golint)
  • Line 103: warning: exported method Dir.Symlink should have comment or be unexported (golint)
  • Line 145: warning: exported method File.Readlink should have comment or be unexported (golint)

• seaweedfs/weed/command/filer_replication.go
  • Line 10: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• seaweedfs/weed/storage/volume.go
  • Line 21: warning: exported type Volume should have comment or be unexported (golint)
  • Line 53: warning: exported function NewVolume should have comment or be unexported (golint)
  • Line 70: warning: exported function VolumeFileName should have comment or be unexported (golint)
  • Line 80: warning: exported method Volume.DataFileName should have comment or be unexported (golint)
  • Line 84: warning: exported method Volume.IndexFileName should have comment or be unexported (golint)
  • Line 88: warning: exported method Volume.FileName should have comment or be unexported (golint)
  • Line 97: warning: exported method Volume.Version should have comment or be unexported (golint)
  • Line 104: warning: exported method Volume.FileStat should have comment or be unexported (golint)
  • Line 120: warning: exported method Volume.ContentSize should have comment or be unexported (golint)
  • Line 129: warning: exported method Volume.DeletedSize should have comment or be unexported (golint)
  • Line 138: warning: exported method Volume.FileCount should have comment or be unexported (golint)
  • Line 147: warning: exported method Volume.DeletedCount should have comment or be unexported (golint)
  • Line 156: warning: exported method Volume.MaxFileKey should have comment or be unexported (golint)
  • Line 165: warning: exported method Volume.IndexFileSize should have comment or be unexported (golint)
  • Line 174: warning: exported method Volume.DiskType should have comment or be unexported (golint)
  • Line 199: warning: exported method Volume.NeedToReplicate should have comment or be unexported (golint)
  • Line 264: warning: exported method Volume.ToVolumeInformationMessage should have comment or be unexported (golint)
  • Line 293: warning: exported method Volume.RemoteStorageNameKey should have comment or be unexported (golint)
  • Line 303: warning: exported method Volume.IsReadOnly should have comment or be unexported (golint)

• seaweedfs/weed/topology/disk.go
  • Line 16: warning: exported type Disk should have comment or be unexported (golint)
  • Line 23: warning: exported function NewDisk should have comment or be unexported (golint)
  • Line 34: warning: exported type DiskUsages should have comment or be unexported (golint)
  • Line 61: warning: exported method DiskUsages.ToDiskInfo should have comment or be unexported (golint)
  • Line 76: warning: exported method DiskUsages.FreeSpace should have comment or be unexported (golint)
  • Line 85: warning: exported method DiskUsages.GetMaxVolumeCount should have comment or be unexported (golint)
  • Line 94: warning: exported type DiskUsageCounts should have comment or be unexported (golint)
  • Line 110: warning: exported method DiskUsageCounts.FreeSpace should have comment or be unexported (golint)
  • Line 128: warning: receiver name du should be consistent with previous receiver name d for DiskUsages (golint)
  • Line 146: warning: exported method Disk.AddOrUpdateVolume should have comment or be unexported (golint)
  • Line 183: warning: exported method Disk.GetVolumes should have comment or be unexported (golint)
  • Line 192: warning: exported method Disk.GetVolumesById should have comment or be unexported (golint)
  • Line 198: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 203: warning: exported method Disk.GetDataCenter should have comment or be unexported (golint)
  • Line 211: warning: exported method Disk.GetRack should have comment or be unexported (golint)
  • Line 215: warning: exported method Disk.GetTopology should have comment or be unexported (golint)
  • Line 224: warning: exported method Disk.ToMap should have comment or be unexported (golint)
  • Line 235: warning: exported method Disk.FreeSpace should have comment or be unexported (golint)
  • Line 240: warning: exported method Disk.ToDiskInfo should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3api_xsd_generated.go
  • Line 10: warning: exported type AccessControlList should have comment or be unexported (golint)
  • Line 14: warning: exported type AccessControlPolicy should have comment or be unexported (golint)
  • Line 19: warning: exported type AmazonCustomerByEmail should have comment or be unexported (golint)
  • Line 23: warning: exported type BucketLoggingStatus should have comment or be unexported (golint)
  • Line 27: warning: exported type CanonicalUser should have comment or be unexported (golint)
  • Line 32: warning: exported type CopyObject should have comment or be unexported (golint)
  • Line 51: warning: exported method CopyObject.MarshalXML should have comment or be unexported (golint)
  • Line 65: warning: exported method CopyObject.UnmarshalXML should have comment or be unexported (golint)
  • Line 80: warning: exported type CopyObjectResponse should have comment or be unexported (golint)
  • Line 84: warning: exported type CopyObjectResult should have comment or be unexported (golint)
  • Line 89: warning: exported method CopyObjectResult.MarshalXML should have comment or be unexported (golint)
  • Line 99: warning: exported method CopyObjectResult.UnmarshalXML should have comment or be unexported (golint)
  • Line 110: warning: exported type CreateBucket should have comment or be unexported (golint)
  • Line 118: warning: exported method CreateBucket.MarshalXML should have comment or be unexported (golint)
  • Line 128: warning: exported method CreateBucket.UnmarshalXML should have comment or be unexported (golint)
  • Line 139: warning: exported type CreateBucketConfiguration should have comment or be unexported (golint)
  • Line 143: warning: exported type CreateBucketResponse should have comment or be unexported (golint)
  • Line 147: warning: exported type CreateBucketResult should have comment or be unexported (golint)
  • Line 151: warning: exported type DeleteBucket should have comment or be unexported (golint)
  • Line 159: warning: exported method DeleteBucket.MarshalXML should have comment or be unexported (golint)
  • Line 169: warning: exported method DeleteBucket.UnmarshalXML should have comment or be unexported (golint)
  • Line 180: warning: exported type DeleteBucketResponse should have comment or be unexported (golint)
  • Line 184: warning: exported type DeleteMarkerEntry should have comment or be unexported (golint)
  • Line 192: warning: exported method DeleteMarkerEntry.MarshalXML should have comment or be unexported (golint)
  • Line 202: warning: exported method DeleteMarkerEntry.UnmarshalXML should have comment or be unexported (golint)
  • Line 213: warning: exported type DeleteObject should have comment or be unexported (golint)
  • Line 222: warning: exported method DeleteObject.MarshalXML should have comment or be unexported (golint)
  • Line 232: warning: exported method DeleteObject.UnmarshalXML should have comment or be unexported (golint)
  • Line 243: warning: exported type DeleteObjectResponse should have comment or be unexported (golint)
  • Line 247: warning: exported type GetBucketAccessControlPolicy should have comment or be unexported (golint)
  • Line 255: warning: exported method GetBucketAccessControlPolicy.MarshalXML should have comment or be unexported (golint)
  • Line 265: warning: exported method GetBucketAccessControlPolicy.UnmarshalXML should have comment or be unexported (golint)
  • Line 276: warning: exported type GetBucketAccessControlPolicyResponse should have comment or be unexported (golint)
  • Line 280: warning: exported type GetBucketLoggingStatus should have comment or be unexported (golint)
  • Line 288: warning: exported method GetBucketLoggingStatus.MarshalXML should have comment or be unexported (golint)
  • Line 298: warning: exported method GetBucketLoggingStatus.UnmarshalXML should have comment or be unexported (golint)
  • Line 309: warning: exported type GetBucketLoggingStatusResponse should have comment or be unexported (golint)
  • Line 313: warning: exported type GetObject should have comment or be unexported (golint)
  • Line 325: warning: exported method GetObject.MarshalXML should have comment or be unexported (golint)
  • Line 335: warning: exported method GetObject.UnmarshalXML should have comment or be unexported (golint)
  • Line 346: warning: exported type GetObjectAccessControlPolicy should have comment or be unexported (golint)
  • Line 355: warning: exported method GetObjectAccessControlPolicy.MarshalXML should have comment or be unexported (golint)
  • Line 365: warning: exported method GetObjectAccessControlPolicy.UnmarshalXML should have comment or be unexported (golint)
  • Line 376: warning: exported type GetObjectAccessControlPolicyResponse should have comment or be unexported (golint)
  • Line 380: warning: exported type GetObjectExtended should have comment or be unexported (golint)
  • Line 399: warning: exported method GetObjectExtended.MarshalXML should have comment or be unexported (golint)
  • Line 413: warning: exported method GetObjectExtended.UnmarshalXML should have comment or be unexported (golint)
  • Line 428: warning: exported type GetObjectExtendedResponse should have comment or be unexported (golint)
  • Line 432: warning: exported type GetObjectResponse should have comment or be unexported (golint)
  • Line 436: warning: exported type GetObjectResult should have comment or be unexported (golint)
  • Line 444: warning: exported method GetObjectResult.MarshalXML should have comment or be unexported (golint)
  • Line 456: warning: exported method GetObjectResult.UnmarshalXML should have comment or be unexported (golint)
  • Line 469: warning: exported type Grant should have comment or be unexported (golint)
  • Line 474: warning: exported type Grantee should have comment or be unexported (golint)
  • Line 477: warning: exported type Group should have comment or be unexported (golint)
  • Line 481: warning: exported type ListAllMyBuckets should have comment or be unexported (golint)
  • Line 487: warning: exported method ListAllMyBuckets.MarshalXML should have comment or be unexported (golint)
  • Line 497: warning: exported method ListAllMyBuckets.UnmarshalXML should have comment or be unexported (golint)
  • Line 508: warning: exported type ListAllMyBucketsEntry should have comment or be unexported (golint)
  • Line 513: warning: exported method ListAllMyBucketsEntry.MarshalXML should have comment or be unexported (golint)
  • Line 523: warning: exported method ListAllMyBucketsEntry.UnmarshalXML should have comment or be unexported (golint)
  • Line 534: warning: exported type ListAllMyBucketsList should have comment or be unexported (golint)
  • Line 538: warning: exported type ListAllMyBucketsResponse should have comment or be unexported (golint)
  • Line 542: warning: exported type ListBucket should have comment or be unexported (golint)
  • Line 554: warning: exported method ListBucket.MarshalXML should have comment or be unexported (golint)
  • Line 564: warning: exported method ListBucket.UnmarshalXML should have comment or be unexported (golint)
  • Line 575: warning: exported type ListBucketResponse should have comment or be unexported (golint)
  • Line 579: warning: exported type ListBucketResult should have comment or be unexported (golint)
  • Line 593: warning: exported type ListEntry should have comment or be unexported (golint)
  • Line 602: warning: exported method ListEntry.MarshalXML should have comment or be unexported (golint)
  • Line 612: warning: exported method ListEntry.UnmarshalXML should have comment or be unexported (golint)
  • Line 623: warning: exported type ListVersionsResponse should have comment or be unexported (golint)
  • Line 627: warning: exported type ListVersionsResult should have comment or be unexported (golint)
  • Line 643: warning: exported type LoggingSettings should have comment or be unexported (golint)
  • Line 649: warning: comment on exported type MetadataDirective should be of the form "MetadataDirective ..." (with optional leading article) (golint)
  • Line 652: warning: exported type MetadataEntry should have comment or be unexported (golint)
  • Line 657: warning: comment on exported type MfaDeleteStatus should be of the form "MfaDeleteStatus ..." (with optional leading article) (golint)
  • Line 660: warning: exported type NotificationConfiguration should have comment or be unexported (golint)
  • Line 664: warning: comment on exported type Payer should be of the form "Payer ..." (with optional leading article) (golint)
  • Line 667: warning: comment on exported type Permission should be of the form "Permission ..." (with optional leading article) (golint)
  • Line 670: warning: exported type PostResponse should have comment or be unexported (golint)
  • Line 677: warning: exported type PrefixEntry should have comment or be unexported (golint)
  • Line 681: warning: exported type PutObject should have comment or be unexported (golint)
  • Line 694: warning: exported method PutObject.MarshalXML should have comment or be unexported (golint)
  • Line 704: warning: exported method PutObject.UnmarshalXML should have comment or be unexported (golint)
  • Line 715: warning: exported type PutObjectInline should have comment or be unexported (golint)
  • Line 729: warning: exported method PutObjectInline.MarshalXML should have comment or be unexported (golint)
  • Line 741: warning: exported method PutObjectInline.UnmarshalXML should have comment or be unexported (golint)
  • Line 754: warning: exported type PutObjectInlineResponse should have comment or be unexported (golint)
  • Line 758: warning: exported type PutObjectResponse should have comment or be unexported (golint)
  • Line 762: warning: exported type PutObjectResult should have comment or be unexported (golint)
  • Line 767: warning: exported method PutObjectResult.MarshalXML should have comment or be unexported (golint)
  • Line 777: warning: exported method PutObjectResult.UnmarshalXML should have comment or be unexported (golint)
  • Line 788: warning: exported type RequestPaymentConfiguration should have comment or be unexported (golint)
  • Line 792: warning: exported type Result should have comment or be unexported (golint)
  • Line 796: warning: exported type SetBucketAccessControlPolicy should have comment or be unexported (golint)
  • Line 805: warning: exported method SetBucketAccessControlPolicy.MarshalXML should have comment or be unexported (golint)
  • Line 815: warning: exported method SetBucketAccessControlPolicy.UnmarshalXML should have comment or be unexported (golint)
  • Line 826: warning: exported type SetBucketAccessControlPolicyResponse should have comment or be unexported (golint)
  • Line 829: warning: exported type SetBucketLoggingStatus should have comment or be unexported (golint)
  • Line 838: warning: exported method SetBucketLoggingStatus.MarshalXML should have comment or be unexported (golint)
  • Line 848: warning: exported method SetBucketLoggingStatus.UnmarshalXML should have comment or be unexported (golint)
  • Line 859: warning: exported type SetBucketLoggingStatusResponse should have comment or be unexported (golint)
  • Line 862: warning: exported type SetObjectAccessControlPolicy should have comment or be unexported (golint)
  • Line 872: warning: exported method SetObjectAccessControlPolicy.MarshalXML should have comment or be unexported (golint)
  • Line 882: warning: exported method SetObjectAccessControlPolicy.UnmarshalXML should have comment or be unexported (golint)
  • Line 893: warning: exported type SetObjectAccessControlPolicyResponse should have comment or be unexported (golint)
  • Line 896: warning: exported type Status should have comment or be unexported (golint)
  • Line 901: warning: comment on exported type StorageClass should be of the form "StorageClass ..." (with optional leading article) (golint)
  • Line 904: warning: exported type TopicConfiguration should have comment or be unexported (golint)
  • Line 909: warning: exported type User should have comment or be unexported (golint)
  • Line 912: warning: exported type VersionEntry should have comment or be unexported (golint)
  • Line 923: warning: exported method VersionEntry.MarshalXML should have comment or be unexported (golint)
  • Line 933: warning: exported method VersionEntry.UnmarshalXML should have comment or be unexported (golint)
  • Line 944: warning: exported type VersioningConfiguration should have comment or be unexported (golint)
  • Line 949: warning: comment on exported type VersioningStatus should be of the form "VersioningStatus ..." (with optional leading article) (golint)

• seaweedfs/weed/filer/etcd/etcd_store_kv.go
  • Line 9: warning: exported method EtcdStore.KvPut should have comment or be unexported (golint)
  • Line 20: warning: exported method EtcdStore.KvGet should have comment or be unexported (golint)
  • Line 35: warning: exported method EtcdStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/unmaintained/stress_filer_upload/stress_filer_upload_actual/stress_filer_upload.go
  • Line 139: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/storage/erasure_coding/ec_shard.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type ShardId should have comment or be unexported (golint)
  • Line 17: warning: exported type EcVolumeShard should have comment or be unexported (golint)
  • Line 27: warning: exported function NewEcVolumeShard should have comment or be unexported (golint)
  • Line 51: warning: exported method EcVolumeShard.Size should have comment or be unexported (golint)
  • Line 59: warning: exported method EcVolumeShard.FileName should have comment or be unexported (golint)
  • Line 63: warning: exported function EcShardFileName should have comment or be unexported (golint)
  • Line 73: warning: exported function EcShardBaseFileName should have comment or be unexported (golint)
  • Line 81: warning: exported method EcVolumeShard.Close should have comment or be unexported (golint)
  • Line 88: warning: exported method EcVolumeShard.Destroy should have comment or be unexported (golint)
  • Line 93: warning: exported method EcVolumeShard.ReadAt should have comment or be unexported (golint)

• seaweedfs/weed/command/filer_meta_tail.go
  • Line 144: warning: exported type EsDocument should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_loading.go
  • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/util/bytes.go
  • Line 34: warning: exported function BytesToUint64 should have comment or be unexported (golint)
  • Line 43: warning: exported function BytesToUint32 should have comment or be unexported (golint)
  • Line 52: warning: exported function BytesToUint16 should have comment or be unexported (golint)
  • Line 58: warning: exported function Uint64toBytes should have comment or be unexported (golint)
  • Line 63: warning: exported function Uint32toBytes should have comment or be unexported (golint)
  • Line 68: warning: exported function Uint16toBytes should have comment or be unexported (golint)
  • Line 72: warning: exported function Uint8toBytes should have comment or be unexported (golint)
  • Line 76: warning: comment on exported function HashStringToLong should be of the form "HashStringToLong ..." (golint)
  • Line 102: warning: exported function HashToInt32 should have comment or be unexported (golint)
  • Line 119: warning: exported function Base64Encode should have comment or be unexported (golint)
  • Line 123: warning: exported function Base64Md5 should have comment or be unexported (golint)
  • Line 127: warning: exported function Md5 should have comment or be unexported (golint)
  • Line 133: warning: exported function Md5String should have comment or be unexported (golint)
  • Line 137: warning: exported function Base64Md5ToBytes should have comment or be unexported (golint)
  • Line 145: warning: exported function RandomInt32 should have comment or be unexported (golint)
  • Line 151: warning: exported function RandomBytes should have comment or be unexported (golint)
  • Line 157: warning: exported type BytesReader should have comment or be unexported (golint)
  • Line 162: warning: exported function NewBytesReader should have comment or be unexported (golint)

• seaweedfs/weed/util/http_util.go
  • Line 19: warning: exported var Transport should have comment or be unexported (golint)
  • Line 32: warning: exported function Post should have comment or be unexported (golint)
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 52: warning: comment on exported function Get should be of the form "Get ..." (golint)
  • Line 85: warning: exported function Head should have comment or be unexported (golint)
  • Line 97: warning: exported function Delete should have comment or be unexported (golint)
  • Line 127: warning: exported function DeleteProxied should have comment or be unexported (golint)
  • Line 148: warning: exported function GetBufferStream should have comment or be unexported (golint)
  • Line 171: warning: exported function GetUrlStream should have comment or be unexported (golint)
  • Line 183: warning: exported function DownloadFile should have comment or be unexported (golint)
  • Line 201: warning: exported function Do should have comment or be unexported (golint)
  • Line 205: warning: exported function NormalizeUrl should have comment or be unexported (golint)
  • Line 212: warning: exported function ReadUrl should have comment or be unexported (golint)
  • Line 281: warning: exported function ReadUrlAsStream should have comment or be unexported (golint)
  • Line 362: warning: exported function ReadUrlAsReaderCloser should have comment or be unexported (golint)
  • Line 395: warning: exported function CloseResponse should have comment or be unexported (golint)
  • Line 400: warning: exported function CloseRequest should have comment or be unexported (golint)

• seaweedfs/weed/filer/cassandra/cassandra_store.go
  • Line 18: warning: exported type CassandraStore should have comment or be unexported (golint)
  • Line 24: warning: exported method CassandraStore.GetName should have comment or be unexported (golint)
  • Line 28: warning: exported method CassandraStore.Initialize should have comment or be unexported (golint)
  • Line 70: warning: exported method CassandraStore.BeginTransaction should have comment or be unexported (golint)
  • Line 73: warning: exported method CassandraStore.CommitTransaction should have comment or be unexported (golint)
  • Line 76: warning: exported method CassandraStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 80: warning: exported method CassandraStore.InsertEntry should have comment or be unexported (golint)
  • Line 105: warning: exported method CassandraStore.UpdateEntry should have comment or be unexported (golint)
  • Line 110: warning: exported method CassandraStore.FindEntry should have comment or be unexported (golint)
  • Line 141: warning: exported method CassandraStore.DeleteEntry should have comment or be unexported (golint)
  • Line 157: warning: exported method CassandraStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 171: warning: exported method CassandraStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 175: warning: exported method CassandraStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 210: warning: exported method CassandraStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/filer/etcd/etcd_store.go
  • Line 19: warning: exported const DIR_FILE_SEPARATOR should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type EtcdStore should have comment or be unexported (golint)
  • Line 30: warning: exported method EtcdStore.GetName should have comment or be unexported (golint)
  • Line 34: warning: exported method EtcdStore.Initialize should have comment or be unexported (golint)
  • Line 67: warning: exported method EtcdStore.BeginTransaction should have comment or be unexported (golint)
  • Line 70: warning: exported method EtcdStore.CommitTransaction should have comment or be unexported (golint)
  • Line 73: warning: exported method EtcdStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 77: warning: exported method EtcdStore.InsertEntry should have comment or be unexported (golint)
  • Line 96: warning: exported method EtcdStore.UpdateEntry should have comment or be unexported (golint)
  • Line 100: warning: exported method EtcdStore.FindEntry should have comment or be unexported (golint)
  • Line 123: warning: exported method EtcdStore.DeleteEntry should have comment or be unexported (golint)
  • Line 133: warning: exported method EtcdStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 143: warning: exported method EtcdStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 147: warning: exported method EtcdStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 217: warning: exported method EtcdStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/filesys/meta_cache/meta_cache.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported type MetaCache should have comment or be unexported (golint)
  • Line 27: warning: exported function NewMetaCache should have comment or be unexported (golint)
  • Line 56: warning: exported method MetaCache.InsertEntry should have comment or be unexported (golint)
  • Line 66: warning: exported method MetaCache.AtomicUpdateEntryFromFiler should have comment or be unexported (golint)
  • Line 99: warning: exported method MetaCache.UpdateEntry should have comment or be unexported (golint)
  • Line 105: warning: exported method MetaCache.FindEntry should have comment or be unexported (golint)
  • Line 116: warning: exported method MetaCache.DeleteEntry should have comment or be unexported (golint)
  • Line 122: warning: exported method MetaCache.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 140: warning: exported method MetaCache.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/operation/tail_volume.go
  • Line 14: warning: exported function TailVolume should have comment or be unexported (golint)
  • Line 29: warning: exported function TailVolumeFromSource should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_volume_delete.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported var MarkNeedleDeleted should have comment or be unexported (golint)
  • Line 27: warning: exported method EcVolume.DeleteNeedleFromEcx should have comment or be unexported (golint)
  • Line 51: warning: exported function RebuildEcxFile should have comment or be unexported (golint)

• seaweedfs/weed/replication/repl_util/replication_util.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported function CopyFromChunkViews should have comment or be unexported (golint)

• seaweedfs/weed/filer/filerstore.go
  • Line 10: warning: exported var ErrUnsupportedListDirectoryPrefixed should have comment or be unexported (golint)
  • Line 16: warning: exported type ListEachEntryFunc should have comment or be unexported (golint)
  • Line 18: warning: exported type FilerStore should have comment or be unexported (golint)
  • Line 43: warning: exported type BucketAware should have comment or be unexported (golint)

• seaweedfs/weed/storage/super_block/super_block.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported const SuperBlockSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: comment on exported type SuperBlock should be of the form "SuperBlock ..." (with optional leading article) (golint)
  • Line 33: warning: exported method SuperBlock.BlockSize should have comment or be unexported (golint)
  • Line 41: warning: exported method SuperBlock.Bytes should have comment or be unexported (golint)
  • Line 67: warning: exported method SuperBlock.Initialized should have comment or be unexported (golint)

• seaweedfs/weed/topology/allocate_volume.go
  • Line 12: warning: exported type AllocateVolumeResult should have comment or be unexported (golint)
  • Line 16: warning: exported function AllocateVolume should have comment or be unexported (golint)

• seaweedfs/weed/topology/node.go
  • Line 14: warning: exported type NodeId should have comment or be unexported (golint)
  • Line 15: warning: exported type Node should have comment or be unexported (golint)
  • Line 38: warning: exported type NodeImpl should have comment or be unexported (golint)
  • Line 51: warning: exported method NodeImpl.GetDiskUsages should have comment or be unexported (golint)
  • Line 55: warning: comment on exported method NodeImpl.PickNodesByWeight should be of the form "PickNodesByWeight ..." (golint)
  • Line 118: warning: exported method NodeImpl.IsDataNode should have comment or be unexported (golint)
  • Line 121: warning: exported method NodeImpl.IsRack should have comment or be unexported (golint)
  • Line 124: warning: exported method NodeImpl.IsDataCenter should have comment or be unexported (golint)
  • Line 133: warning: exported method NodeImpl.Id should have comment or be unexported (golint)
  • Line 139: warning: exported method NodeImpl.AvailableSpaceFor should have comment or be unexported (golint)
  • Line 147: warning: exported method NodeImpl.SetParent should have comment or be unexported (golint)
  • Line 150: warning: exported method NodeImpl.Children should have comment or be unexported (golint)
  • Line 158: warning: exported method NodeImpl.Parent should have comment or be unexported (golint)
  • Line 161: warning: exported method NodeImpl.GetValue should have comment or be unexported (golint)
  • Line 164: warning: exported method NodeImpl.ReserveOneVolume should have comment or be unexported (golint)
  • Line 189: warning: exported method NodeImpl.UpAdjustDiskUsageDelta should have comment or be unexported (golint)
  • Line 198: warning: exported method NodeImpl.UpAdjustMaxVolumeId should have comment or be unexported (golint)
  • Line 206: warning: exported method NodeImpl.GetMaxVolumeId should have comment or be unexported (golint)
  • Line 210: warning: exported method NodeImpl.LinkChildNode should have comment or be unexported (golint)
  • Line 226: warning: exported method NodeImpl.UnlinkChildNode should have comment or be unexported (golint)
  • Line 238: warning: exported method NodeImpl.CollectDeadNodeAndFullVolumes should have comment or be unexported (golint)
  • Line 258: warning: exported method NodeImpl.GetTopology should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/topic_manager.go
  • Line 14: warning: exported type TopicPartition should have comment or be unexported (golint)
  • Line 21: warning: exported const TopicPartitionFmt should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type TopicControl should have comment or be unexported (golint)
  • Line 36: warning: exported type TopicManager should have comment or be unexported (golint)
  • Line 42: warning: exported function NewTopicManager should have comment or be unexported (golint)
  • Line 78: warning: exported method TopicManager.RequestLock should have comment or be unexported (golint)
  • Line 97: warning: exported method TopicManager.ReleaseLock should have comment or be unexported (golint)
  • Line 116: warning: exported method TopicManager.ListTopicPartitions should have comment or be unexported (golint)

• seaweedfs/weed/server/master_ui/templates.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 7: warning: exported var StatusTpl should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/net2/doc.go
  • Line 1: warning: package comment should be of the form "Package net2 ..." (golint)

• seaweedfs/weed/s3api/s3api_bucket_handlers.go
  • Line 22: warning: exported type ListAllMyBucketsResult should have comment or be unexported (golint)
  • Line 28: warning: exported method S3ApiServer.ListBucketsHandler should have comment or be unexported (golint)
  • Line 75: warning: exported method S3ApiServer.PutBucketHandler should have comment or be unexported (golint)
  • Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 128: warning: exported method S3ApiServer.DeleteBucketHandler should have comment or be unexported (golint)
  • Line 162: warning: exported method S3ApiServer.HeadBucketHandler should have comment or be unexported (golint)

• seaweedfs/weed/notification/kafka/kafka_queue.go
  • Line 15: warning: exported type KafkaQueue should have comment or be unexported (golint)
  • Line 20: warning: exported method KafkaQueue.GetName should have comment or be unexported (golint)
  • Line 24: warning: exported method KafkaQueue.Initialize should have comment or be unexported (golint)
  • Line 49: warning: exported method KafkaQueue.SendMessage should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3api_handlers.go
  • Line 45: warning: exported method S3ApiServer.WithFilerClient should have comment or be unexported (golint)
  • Line 53: warning: exported method S3ApiServer.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/util/file_util_non_posix.go
  • Line 10: warning: exported function GetFileUidGid should have comment or be unexported (golint)

• seaweedfs/weed/shell/command_ec_balance.go
  • Line 325: warning: should omit 2nd value from range; this loop is equivalent to `for rackId := range ...` (golint)

• seaweedfs/weed/util/fullpath.go
  • Line 8: warning: exported type FullPath should have comment or be unexported (golint)
  • Line 10: warning: exported function NewFullPath should have comment or be unexported (golint)
  • Line 14: warning: exported method FullPath.DirAndName should have comment or be unexported (golint)
  • Line 26: warning: exported method FullPath.Name should have comment or be unexported (golint)
  • Line 32: warning: exported method FullPath.Child should have comment or be unexported (golint)
  • Line 40: warning: exported method FullPath.AsInode should have comment or be unexported (golint)
  • Line 44: warning: comment on exported method FullPath.Split should be of the form "Split ..." (golint)
  • Line 52: warning: exported function Join should have comment or be unexported (golint)
  • Line 56: warning: exported function JoinPath should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_proxy.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filer/leveldb2/leveldb2_store.go
  • Line 25: warning: exported type LevelDB2Store should have comment or be unexported (golint)
  • Line 30: warning: exported method LevelDB2Store.GetName should have comment or be unexported (golint)
  • Line 34: warning: exported method LevelDB2Store.Initialize should have comment or be unexported (golint)
  • Line 70: warning: exported method LevelDB2Store.BeginTransaction should have comment or be unexported (golint)
  • Line 73: warning: exported method LevelDB2Store.CommitTransaction should have comment or be unexported (golint)
  • Line 76: warning: exported method LevelDB2Store.RollbackTransaction should have comment or be unexported (golint)
  • Line 80: warning: exported method LevelDB2Store.InsertEntry should have comment or be unexported (golint)
  • Line 104: warning: exported method LevelDB2Store.UpdateEntry should have comment or be unexported (golint)
  • Line 109: warning: exported method LevelDB2Store.FindEntry should have comment or be unexported (golint)
  • Line 135: warning: exported method LevelDB2Store.DeleteEntry should have comment or be unexported (golint)
  • Line 147: warning: exported method LevelDB2Store.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 175: warning: exported method LevelDB2Store.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 179: warning: exported method LevelDB2Store.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 256: warning: exported method LevelDB2Store.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/s3_backend/s3_backend.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported type S3BackendFactory should have comment or be unexported (golint)
  • Line 26: warning: exported method S3BackendFactory.StorageType should have comment or be unexported (golint)
  • Line 29: warning: exported method S3BackendFactory.BuildStorage should have comment or be unexported (golint)
  • Line 33: warning: exported type S3BackendStorage should have comment or be unexported (golint)
  • Line 35: warning: don't use underscores in Go names; struct field aws_access_key_id should be awsAccessKeyID (golint)
  • Line 36: warning: don't use underscores in Go names; struct field aws_secret_access_key should be awsSecretAccessKey (golint)
  • Line 58: warning: exported method S3BackendStorage.ToProperties should have comment or be unexported (golint)
  • Line 68: warning: exported method S3BackendStorage.NewStorageFile should have comment or be unexported (golint)
  • Line 82: warning: exported method S3BackendStorage.CopyFile should have comment or be unexported (golint)
  • Line 93: warning: exported method S3BackendStorage.DownloadFile should have comment or be unexported (golint)
  • Line 102: warning: exported method S3BackendStorage.DeleteFile should have comment or be unexported (golint)
  • Line 111: warning: exported type S3BackendStorageFile should have comment or be unexported (golint)
  • Line 117: warning: exported method S3BackendStorageFile.ReadAt should have comment or be unexported (golint)
  • Line 152: warning: exported method S3BackendStorageFile.WriteAt should have comment or be unexported (golint)
  • Line 156: warning: exported method S3BackendStorageFile.Truncate should have comment or be unexported (golint)
  • Line 160: warning: exported method S3BackendStorageFile.Close should have comment or be unexported (golint)
  • Line 164: warning: exported method S3BackendStorageFile.GetStat should have comment or be unexported (golint)
  • Line 179: warning: exported method S3BackendStorageFile.Name should have comment or be unexported (golint)
  • Line 183: warning: exported method S3BackendStorageFile.Sync should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dirty_pages_temp_file.go
  • Line 13: warning: exported type TempFileDirtyPages should have comment or be unexported (golint)
  • Line 37: warning: exported method TempFileDirtyPages.AddPage should have comment or be unexported (golint)
  • Line 71: warning: exported method TempFileDirtyPages.FlushData should have comment or be unexported (golint)
  • Line 141: warning: exported method TempFileDirtyPages.ReadDirtyDataAt should have comment or be unexported (golint)
  • Line 145: warning: exported method TempFileDirtyPages.GetStorageOptions should have comment or be unexported (golint)
  • Line 149: warning: exported method TempFileDirtyPages.SetWriteOnly should have comment or be unexported (golint)
  • Line 155: warning: exported method TempFileDirtyPages.GetWriteOnly should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dirty_pages_temp_interval.go
  • Line 9: warning: exported type WrittenIntervalNode should have comment or be unexported (golint)
  • Line 16: warning: exported type WrittenIntervalLinkedList should have comment or be unexported (golint)
  • Line 22: warning: exported type WrittenContinuousIntervals should have comment or be unexported (golint)
  • Line 28: warning: exported method WrittenIntervalLinkedList.Offset should have comment or be unexported (golint)
  • Line 31: warning: exported method WrittenIntervalLinkedList.Size should have comment or be unexported (golint)
  • Line 50: warning: exported method WrittenIntervalLinkedList.ReadData should have comment or be unexported (golint)
  • Line 67: warning: exported method WrittenContinuousIntervals.TotalSize should have comment or be unexported (golint)
  • Line 114: warning: exported method WrittenContinuousIntervals.AddInterval should have comment or be unexported (golint)
  • Line 189: warning: exported method WrittenContinuousIntervals.RemoveLargestIntervalLinkedList should have comment or be unexported (golint)
  • Line 224: warning: exported method WrittenContinuousIntervals.ReadDataAt should have comment or be unexported (golint)
  • Line 236: warning: exported method WrittenIntervalLinkedList.ToReader should have comment or be unexported (golint)
  • Line 236: warning: receiver name l should be consistent with previous receiver name list for WrittenIntervalLinkedList (golint)
  • Line 255: warning: exported type FileSectionReader should have comment or be unexported (golint)

• seaweedfs/weed/util/chunk_cache/chunk_cache.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported var ErrorOutOfBounds should have comment or be unexported (golint)
  • Line 13: warning: exported type ChunkCache should have comment or be unexported (golint)
  • Line 19: warning: comment on exported type TieredChunkCache should be of the form "TieredChunkCache ..." (with optional leading article) (golint)
  • Line 31: warning: exported function NewTieredChunkCache should have comment or be unexported (golint)
  • Line 47: warning: exported method TieredChunkCache.GetChunk should have comment or be unexported (golint)
  • Line 96: warning: exported method TieredChunkCache.GetChunkSlice should have comment or be unexported (golint)
  • Line 148: warning: exported method TieredChunkCache.SetChunk should have comment or be unexported (golint)
  • Line 182: warning: exported method TieredChunkCache.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/util/network.go
  • Line 9: warning: exported function DetectedHostAddress should have comment or be unexported (golint)

• seaweedfs/weed/filer/meta_aggregator.go
  • Line 20: warning: exported type MetaAggregator should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function NewMetaAggregator should be of the form "NewMetaAggregator ..." (golint)
  • Line 43: warning: exported method MetaAggregator.StartLoopSubscribe should have comment or be unexported (golint)
  • Line 171: warning: exported const MetaOffsetPrefix should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/sequence/memory_sequencer.go
  • Line 7: warning: comment on exported type MemorySequencer should be of the form "MemorySequencer ..." (with optional leading article) (golint)
  • Line 13: warning: exported function NewMemorySequencer should have comment or be unexported (golint)
  • Line 18: warning: exported method MemorySequencer.NextFileId should have comment or be unexported (golint)
  • Line 26: warning: exported method MemorySequencer.SetMax should have comment or be unexported (golint)
  • Line 34: warning: exported method MemorySequencer.Peek should have comment or be unexported (golint)

• seaweedfs/weed/stats/metrics.go
  • Line 19: warning: exported var Gather should have comment or be unexported (golint)
  • Line 149: warning: exported function LoopPushingMetric should have comment or be unexported (golint)
  • Line 172: warning: exported function StartMetricsServer should have comment or be unexported (golint)
  • Line 180: warning: exported function SourceName should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/net2/connection_pool.go
  • Line 8: warning: exported type ConnectionOptions should have comment or be unexported (golint)
  • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 53: warning: comment on exported type ConnectionPool should be of the form "ConnectionPool ..." (with optional leading article) (golint)

• seaweedfs/weed/storage/volume_tier.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 12: warning: exported method Volume.GetVolumeInfo should have comment or be unexported (golint)
  • Line 39: warning: exported method Volume.HasRemoteFile should have comment or be unexported (golint)
  • Line 43: warning: exported method Volume.LoadRemoteFile should have comment or be unexported (golint)
  • Line 55: warning: exported method Volume.SaveVolumeInfo should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_read_write.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported method VolumeServer.ReadNeedleBlob should have comment or be unexported (golint)
  • Line 26: warning: exported method VolumeServer.WriteNeedleBlob should have comment or be unexported (golint)

• seaweedfs/weed/filesys/meta_cache/meta_cache_init.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported function EnsureVisited should have comment or be unexported (golint)
  • Line 45: warning: exported function IsHiddenSystemEntry should have comment or be unexported (golint)

• seaweedfs/weed/pb/filer_pb/filer_client_bfs.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported function TraverseBfs should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_buckets.go
  • Line 12: warning: exported type BucketName should have comment or be unexported (golint)
  • Line 13: warning: exported type BucketOption should have comment or be unexported (golint)
  • Line 18: warning: exported type FilerBuckets should have comment or be unexported (golint)
  • Line 24: warning: exported method Filer.LoadBuckets should have comment or be unexported (golint)
  • Line 59: warning: exported method Filer.ReadBucketOption should have comment or be unexported (golint)

• seaweedfs/weed/operation/data_struts.go
  • Line 3: warning: exported type JoinResult should have comment or be unexported (golint)

• seaweedfs/weed/server/raft_server_handlers.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: exported type ClusterStatusResult should have comment or be unexported (golint)
  • Line 15: warning: exported method RaftServer.StatusHandler should have comment or be unexported (golint)

• seaweedfs/weed/pb/filer_pb/signature.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: exported method CreateEntryRequest.AddSignature should have comment or be unexported (golint)
  • Line 6: warning: exported method CreateEntryRequest.HasSigned should have comment or be unexported (golint)

• seaweedfs/weed/filer/configuration.go
  • Line 12: warning: exported var Stores should have comment or be unexported (golint)
  • Line 15: warning: exported method Filer.LoadConfiguration should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map/compact_map_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filer/sqlite/sqlite_store.go
  • Line 16: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 23: warning: exported type SqliteStore should have comment or be unexported (golint)
  • Line 27: warning: exported method SqliteStore.GetName should have comment or be unexported (golint)
  • Line 31: warning: exported method SqliteStore.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/notification/google_pub_sub/google_pub_sub.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported type GooglePubSub should have comment or be unexported (golint)
  • Line 24: warning: exported method GooglePubSub.GetName should have comment or be unexported (golint)
  • Line 28: warning: exported method GooglePubSub.Initialize should have comment or be unexported (golint)
  • Line 38: warning: don't use underscores in Go names; method parameter google_application_credentials should be googleApplicationCredentials (golint)
  • Line 70: warning: exported method GooglePubSub.SendMessage should have comment or be unexported (golint)

• seaweedfs/weed/messaging/msgclient/subscriber.go
  • Line 14: warning: exported type Subscriber should have comment or be unexported (golint)
  • Line 20: warning: exported method MessagingClient.NewSubscriber should have comment or be unexported (golint)
  • Line 114: warning: exported method Subscriber.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/replication_sink.go
  • Line 9: warning: exported type ReplicationSink should have comment or be unexported (golint)
  • Line 21: warning: exported var Sinks should have comment or be unexported (golint)

• seaweedfs/weed/replication/replicator.go
  • Line 18: warning: exported type Replicator should have comment or be unexported (golint)
  • Line 23: warning: exported function NewReplicator should have comment or be unexported (golint)
  • Line 36: warning: exported method Replicator.Replicate should have comment or be unexported (golint)
  • Line 85: warning: exported function ReadFilerSignature should have comment or be unexported (golint)
  • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• seaweedfs/weed/storage/needle_map_memory.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 12: warning: exported type NeedleMap should have comment or be unexported (golint)
  • Line 17: warning: exported function NewCompactNeedleMap should have comment or be unexported (golint)
  • Line 30: warning: exported function LoadCompactNeedleMap should have comment or be unexported (golint)
  • Line 57: warning: exported method NeedleMap.Put should have comment or be unexported (golint)
  • Line 62: warning: exported method NeedleMap.Get should have comment or be unexported (golint)
  • Line 66: warning: exported method NeedleMap.Delete should have comment or be unexported (golint)
  • Line 71: warning: exported method NeedleMap.Close should have comment or be unexported (golint)
  • Line 78: warning: exported method NeedleMap.Destroy should have comment or be unexported (golint)

• seaweedfs/weed/topology/data_node_ec.go
  • Line 9: warning: exported method DataNode.GetEcShards should have comment or be unexported (golint)
  • Line 19: warning: exported method DataNode.UpdateEcShards should have comment or be unexported (golint)
  • Line 108: warning: exported method DataNode.DeltaUpdateEcShards should have comment or be unexported (golint)
  • Line 120: warning: exported method DataNode.AddOrUpdateEcShard should have comment or be unexported (golint)
  • Line 125: warning: exported method DataNode.DeleteEcShard should have comment or be unexported (golint)
  • Line 130: warning: exported method DataNode.HasVolumesById should have comment or be unexported (golint)

• seaweedfs/weed/topology/disk_ec.go
  • Line 9: warning: exported method Disk.GetEcShards should have comment or be unexported (golint)
  • Line 18: warning: exported method Disk.AddOrUpdateEcShard should have comment or be unexported (golint)
  • Line 39: warning: exported method Disk.DeleteEcShard should have comment or be unexported (golint)
  • Line 60: warning: exported method Disk.HasVolumesById should have comment or be unexported (golint)

• seaweedfs/weed/storage/super_block/super_block_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/storage/needle/volume_id.go
  • Line 7: warning: exported type VolumeId should have comment or be unexported (golint)
  • Line 9: warning: exported function NewVolumeId should have comment or be unexported (golint)
  • Line 16: warning: exported method VolumeId.Next should have comment or be unexported (golint)

• seaweedfs/weed/storage/store_ec.go
  • Line 24: warning: exported method Store.CollectErasureCodingHeartbeat should have comment or be unexported (golint)
  • Line 50: warning: exported method Store.MountEcShards should have comment or be unexported (golint)
  • Line 74: warning: exported method Store.UnmountEcShards should have comment or be unexported (golint)
  • Line 109: warning: exported method Store.FindEcVolume should have comment or be unexported (golint)
  • Line 118: warning: exported method Store.DestroyEcVolume should have comment or be unexported (golint)
  • Line 124: warning: exported method Store.ReadEcShardNeedle should have comment or be unexported (golint)
  • Line 160: warning: don't use underscores in Go names; method result is_deleted should be isDeleted (golint)
  • Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 183: warning: don't use underscores in Go names; method result is_deleted should be isDeleted (golint)
  • Line 265: warning: don't use underscores in Go names; method result is_deleted should be isDeleted (golint)
  • Line 283: warning: don't use underscores in Go names; method result is_deleted should be isDeleted (golint)
  • Line 323: warning: don't use underscores in Go names; method result is_deleted should be isDeleted (golint)
  • Line 379: warning: exported method Store.EcVolumes should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_read.go
  • Line 12: warning: should not use dot imports (golint)
  • Line 61: warning: comment on exported method Volume.ReadNeedleBlob should be of the form "ReadNeedleBlob ..." (golint)
  • Line 69: warning: exported type VolumeFileScanner should have comment or be unexported (golint)
  • Line 75: warning: exported function ScanVolumeFile should have comment or be unexported (golint)
  • Line 94: warning: exported function ScanVolumeFileFrom should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_vacuum.go
  • Line 16: warning: should not use dot imports (golint)
  • Line 36: warning: comment on exported method Volume.Compact should be of the form "Compact ..." (golint)
  • Line 64: warning: comment on exported method Volume.Compact2 should be of the form "Compact2 ..." (golint)
  • Line 89: warning: exported method Volume.CommitCompact should have comment or be unexported (golint)
  • Line 314: warning: exported type VolumeFileScanner4Vacuum should have comment or be unexported (golint)
  • Line 324: warning: exported method VolumeFileScanner4Vacuum.VisitSuperBlock should have comment or be unexported (golint)
  • Line 332: warning: exported method VolumeFileScanner4Vacuum.ReadNeedleBody should have comment or be unexported (golint)
  • Line 336: warning: exported method VolumeFileScanner4Vacuum.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/operation/buffer_pool.go
  • Line 10: warning: exported function GetBuffer should have comment or be unexported (golint)
  • Line 18: warning: exported function PutBuffer should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_encoder.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 18: warning: exported const DataShardsCount should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported function RebuildEcFiles should have comment or be unexported (golint)
  • Line 65: warning: exported function ToExt should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/net2/port.go
  • Line 8: warning: comment on exported function GetPort should be of the form "GetPort ..." (golint)

• seaweedfs/weed/query/json/query_json.go
  • Line 11: warning: exported type Query should have comment or be unexported (golint)
  • Line 17: warning: exported function QueryJson should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/broker_grpc_server.go
  • Line 12: warning: exported method MessageBroker.ConfigureTopic should have comment or be unexported (golint)
  • Line 16: warning: exported method MessageBroker.DeleteTopic should have comment or be unexported (golint)
  • Line 27: warning: exported method MessageBroker.GetTopicConfiguration should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/broker_grpc_server_publish.go
  • Line 16: warning: exported method MessageBroker.Publish should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/memory_map/memory_map_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/pb/filer_pb/filer_pb_helper_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/master_grpc_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported method MasterServer.SendHeartbeat should have comment or be unexported (golint)
  • Line 293: warning: exported method MasterServer.ListMasterClients should have comment or be unexported (golint)
  • Line 306: warning: exported method MasterServer.GetMasterConfiguration should have comment or be unexported (golint)

• seaweedfs/weed/filer/topics.go
  • Line 4: warning: exported const TopicsDir should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/util/fla9/fla9.go
  • Line 5: warning: package comment should be of the form "Package fla9 ..." (golint)
  • Line 5: warning: package comment should not have leading space (golint)

• seaweedfs/weed/command/msg_broker.go
  • Line 26: warning: exported type MessageBrokerOptions should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map/needle_value.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 4: warning: should not use dot imports (golint)
  • Line 9: warning: exported type NeedleValue should have comment or be unexported (golint)
  • Line 15: warning: exported method NeedleValue.Less should have comment or be unexported (golint)
  • Line 15: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 20: warning: exported method NeedleValue.ToBytes should have comment or be unexported (golint)
  • Line 24: warning: exported function ToBytes should have comment or be unexported (golint)

• seaweedfs/weed/util/config.go
  • Line 12: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 20: warning: exported function LoadConfiguration should have comment or be unexported (golint)
  • Line 49: warning: exported type ViperProxy should have comment or be unexported (golint)
  • Line 58: warning: exported method ViperProxy.SetDefault should have comment or be unexported (golint)
  • Line 64: warning: exported method ViperProxy.GetString should have comment or be unexported (golint)
  • Line 70: warning: exported method ViperProxy.GetBool should have comment or be unexported (golint)
  • Line 76: warning: exported method ViperProxy.GetInt should have comment or be unexported (golint)
  • Line 82: warning: exported method ViperProxy.GetStringSlice should have comment or be unexported (golint)
  • Line 88: warning: exported function GetViper should have comment or be unexported (golint)

• seaweedfs/weed/server/master_server_handlers.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filer/hbase/hbase_store.go
  • Line 20: warning: exported type HbaseStore should have comment or be unexported (golint)
  • Line 28: warning: exported method HbaseStore.GetName should have comment or be unexported (golint)
  • Line 32: warning: exported method HbaseStore.Initialize should have comment or be unexported (golint)
  • Line 73: warning: exported method HbaseStore.InsertEntry should have comment or be unexported (golint)
  • Line 85: warning: exported method HbaseStore.UpdateEntry should have comment or be unexported (golint)
  • Line 89: warning: exported method HbaseStore.FindEntry should have comment or be unexported (golint)
  • Line 108: warning: exported method HbaseStore.DeleteEntry should have comment or be unexported (golint)
  • Line 112: warning: exported method HbaseStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 151: warning: exported method HbaseStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 155: warning: exported method HbaseStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 217: warning: exported method HbaseStore.BeginTransaction should have comment or be unexported (golint)
  • Line 221: warning: exported method HbaseStore.CommitTransaction should have comment or be unexported (golint)
  • Line 225: warning: exported method HbaseStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 229: warning: exported method HbaseStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/memory_map/memory_map_other.go
  • Line 3: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported method MemoryMap.CreateMemoryMap should have comment or be unexported (golint)
  • Line 13: warning: exported method MemoryMap.WriteMemory should have comment or be unexported (golint)
  • Line 17: warning: exported method MemoryMap.ReadMemory should have comment or be unexported (golint)
  • Line 22: warning: exported method MemoryMap.DeleteFileAndMemoryMap should have comment or be unexported (golint)
  • Line 22: warning: receiver name mBuffer should be consistent with previous receiver name mMap for MemoryMap (golint)

• seaweedfs/weed/filer/entry.go
  • Line 11: warning: exported type Attr should have comment or be unexported (golint)
  • Line 29: warning: exported method Attr.IsDirectory should have comment or be unexported (golint)
  • Line 33: warning: exported type Entry should have comment or be unexported (golint)
  • Line 47: warning: exported method Entry.Size should have comment or be unexported (golint)
  • Line 51: warning: exported method Entry.Timestamp should have comment or be unexported (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 59: warning: exported method Entry.ToProtoEntry should have comment or be unexported (golint)
  • Line 75: warning: exported method Entry.ToProtoFullEntry should have comment or be unexported (golint)
  • Line 86: warning: exported method Entry.Clone should have comment or be unexported (golint)
  • Line 97: warning: exported function FromPbEntry should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_rename.go
  • Line 9: warning: exported method Filer.CanRename should have comment or be unexported (golint)
  • Line 18: warning: exported method Filer.DetectBucket should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/volume_create_linux.go
  • Line 12: warning: exported function CreateVolumeFile should have comment or be unexported (golint)

• seaweedfs/weed/s3api/filer_util.go
  • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• seaweedfs/weed/server/common_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filer/filer_deletion.go
  • Line 13: warning: exported function LookupByMasterClientFn should have comment or be unexported (golint)
  • Line 95: warning: exported method Filer.DirectDeleteChunks should have comment or be unexported (golint)
  • Line 115: warning: exported method Filer.DeleteChunks should have comment or be unexported (golint)

• seaweedfs/weed/sequence/etcd_sequencer.go
  • Line 26: warning: comment on exported const EtcdKeySequence should be of the form "EtcdKeySequence ..." (golint)
  • Line 28: warning: exported const EtcdContextTimeoutSecond should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported type EtcdSequencer should have comment or be unexported (golint)
  • Line 45: warning: exported function NewEtcdSequencer should have comment or be unexported (golint)
  • Line 81: warning: exported method EtcdSequencer.NextFileId should have comment or be unexported (golint)
  • Line 109: warning: comment on exported method EtcdSequencer.SetMax should be of the form "SetMax ..." (golint)
  • Line 130: warning: exported method EtcdSequencer.GetMax should have comment or be unexported (golint)
  • Line 134: warning: exported method EtcdSequencer.Peek should have comment or be unexported (golint)
  • Line 197: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 232: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/sequence/sequence.go
  • Line 3: warning: exported type Sequencer should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dirty_page_interval.go
  • Line 9: warning: exported type IntervalNode should have comment or be unexported (golint)
  • Line 16: warning: exported type IntervalLinkedList should have comment or be unexported (golint)
  • Line 21: warning: exported type ContinuousIntervals should have comment or be unexported (golint)
  • Line 25: warning: exported method IntervalLinkedList.Offset should have comment or be unexported (golint)
  • Line 28: warning: exported method IntervalLinkedList.Size should have comment or be unexported (golint)
  • Line 42: warning: exported method IntervalLinkedList.ReadData should have comment or be unexported (golint)
  • Line 59: warning: exported method ContinuousIntervals.TotalSize should have comment or be unexported (golint)
  • Line 90: warning: exported method ContinuousIntervals.AddInterval should have comment or be unexported (golint)
  • Line 164: warning: exported method ContinuousIntervals.RemoveLargestIntervalLinkedList should have comment or be unexported (golint)
  • Line 198: warning: exported method ContinuousIntervals.ReadDataAt should have comment or be unexported (golint)
  • Line 210: warning: exported method IntervalLinkedList.ToReader should have comment or be unexported (golint)
  • Line 210: warning: receiver name l should be consistent with previous receiver name list for IntervalLinkedList (golint)

• seaweedfs/weed/topology/topology.go
  • Line 22: warning: exported type Topology should have comment or be unexported (golint)
  • Line 45: warning: exported function NewTopology should have comment or be unexported (golint)
  • Line 68: warning: exported method Topology.IsLeader should have comment or be unexported (golint)
  • Line 77: warning: exported method Topology.Leader should have comment or be unexported (golint)
  • Line 94: warning: exported method Topology.Lookup should have comment or be unexported (golint)
  • Line 118: warning: exported method Topology.NextVolumeId should have comment or be unexported (golint)
  • Line 127: warning: comment on exported method Topology.HasWritableVolume should be of the form "HasWritableVolume ..." (golint)
  • Line 134: warning: exported method Topology.PickForWrite should have comment or be unexported (golint)
  • Line 146: warning: exported method Topology.GetVolumeLayout should have comment or be unexported (golint)
  • Line 152: warning: exported method Topology.ListCollections should have comment or be unexported (golint)
  • Line 173: warning: exported method Topology.FindCollection should have comment or be unexported (golint)
  • Line 181: warning: exported method Topology.DeleteCollection should have comment or be unexported (golint)
  • Line 185: warning: exported method Topology.DeleteLayout should have comment or be unexported (golint)
  • Line 196: warning: exported method Topology.RegisterVolumeLayout should have comment or be unexported (golint)
  • Line 202: warning: exported method Topology.UnRegisterVolumeLayout should have comment or be unexported (golint)
  • Line 212: warning: exported method Topology.GetOrCreateDataCenter should have comment or be unexported (golint)
  • Line 224: warning: exported method Topology.SyncDataNodeRegistration should have comment or be unexported (golint)
  • Line 251: warning: exported method Topology.IncrementalSyncDataNodeRegistration should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_tagging.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: comment on exported method FilerServer.PutTaggingHandler should be of the form "PutTaggingHandler ..." (golint)
  • Line 56: warning: comment on exported method FilerServer.DeleteTaggingHandler should be of the form "DeleteTaggingHandler ..." (golint)
  • Line 90: warning: should omit 2nd value from range; this loop is equivalent to `for header := range ...` (golint)

• seaweedfs/weed/messaging/msgclient/chan_config.go
  • Line 3: warning: exported method MessagingClient.DeleteChannel should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/consistent_distribution.go
  • Line 8: warning: exported type Member should have comment or be unexported (golint)
  • Line 20: warning: exported function PickMember should have comment or be unexported (golint)

• seaweedfs/weed/replication/sub/notification_gocdk_pub_sub.go
  • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 34: warning: exported function QueueDeclareAndBind should have comment or be unexported (golint)
  • Line 78: warning: exported type GoCDKPubSubInput should have comment or be unexported (golint)
  • Line 83: warning: exported method GoCDKPubSubInput.GetName should have comment or be unexported (golint)
  • Line 87: warning: exported method GoCDKPubSubInput.Initialize should have comment or be unexported (golint)
  • Line 117: warning: exported method GoCDKPubSubInput.ReceiveMessage should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_locate.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 7: warning: exported type Interval should have comment or be unexported (golint)
  • Line 15: warning: exported function LocateData should have comment or be unexported (golint)
  • Line 77: warning: exported method Interval.ToShardIdAndOffset should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map_sorted_file.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 12: warning: exported type SortedFileNeedleMap should have comment or be unexported (golint)
  • Line 19: warning: exported function NewSortedFileNeedleMap should have comment or be unexported (golint)
  • Line 61: warning: exported method SortedFileNeedleMap.Get should have comment or be unexported (golint)
  • Line 68: warning: exported method SortedFileNeedleMap.Put should have comment or be unexported (golint)
  • Line 72: warning: exported method SortedFileNeedleMap.Delete should have comment or be unexported (golint)
  • Line 96: warning: exported method SortedFileNeedleMap.Close should have comment or be unexported (golint)
  • Line 105: warning: exported method SortedFileNeedleMap.Destroy should have comment or be unexported (golint)

• seaweedfs/weed/images/orientation.go
  • Line 13: warning: comment on exported function FixJpgOrientation should be of the form "FixJpgOrientation ..." (golint)
  • Line 86: warning: exported type DecodeOpts should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_search.go
  • Line 22: warning: comment on exported method Filer.ListDirectoryEntries should be of the form "ListDirectoryEntries ..." (golint)
  • Line 38: warning: comment on exported method Filer.StreamListDirectoryEntries should be of the form "StreamListDirectoryEntries ..." (golint)

• seaweedfs/weed/storage/needle/needle.go
  • Line 12: warning: should not use dot imports (golint)
  • Line 16: warning: exported const NeedleChecksumSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: comment on exported type Needle should be of the form "Needle ..." (with optional leading article) (golint)
  • Line 51: warning: exported function CreateNeedleFromRequest should have comment or be unexported (golint)
  • Line 120: warning: exported method Needle.ParsePath should have comment or be unexported (golint)
  • Line 144: warning: exported function ParseNeedleIdCookie should have comment or be unexported (golint)
  • Line 144: warning: don't use underscores in Go names; func parameter key_hash_string should be keyHashString (golint)
  • Line 163: warning: exported method Needle.LastModifiedString should have comment or be unexported (golint)

• seaweedfs/unmaintained/see_dat/see_dat.go
  • Line 20: warning: exported type VolumeFileScanner4SeeDat should have comment or be unexported (golint)
  • Line 24: warning: exported method VolumeFileScanner4SeeDat.VisitSuperBlock should have comment or be unexported (golint)
  • Line 29: warning: exported method VolumeFileScanner4SeeDat.ReadNeedleBody should have comment or be unexported (golint)
  • Line 33: warning: exported method VolumeFileScanner4SeeDat.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/filer/leveldb3/leveldb3_store_kv.go
  • Line 11: warning: exported method LevelDB3Store.KvPut should have comment or be unexported (golint)
  • Line 22: warning: exported method LevelDB3Store.KvGet should have comment or be unexported (golint)
  • Line 37: warning: exported method LevelDB3Store.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/filesys/meta_cache/meta_cache_subscribe.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported function SubscribeMetaEvents should have comment or be unexported (golint)

• seaweedfs/weed/query/sqltypes/const.go
  • Line 9: warning: don't use underscores in Go names; const Flag_NONE should be FlagNONE (golint)
  • Line 9: warning: exported const Flag_NONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 10: warning: don't use underscores in Go names; const Flag_ISINTEGRAL should be FlagISINTEGRAL (golint)
  • Line 11: warning: don't use underscores in Go names; const Flag_ISUNSIGNED should be FlagISUNSIGNED (golint)
  • Line 12: warning: don't use underscores in Go names; const Flag_ISFLOAT should be FlagISFLOAT (golint)
  • Line 13: warning: don't use underscores in Go names; const Flag_ISQUOTED should be FlagISQUOTED (golint)
  • Line 14: warning: don't use underscores in Go names; const Flag_ISTEXT should be FlagISTEXT (golint)
  • Line 15: warning: don't use underscores in Go names; const Flag_ISBINARY should be FlagISBINARY (golint)
  • Line 18: warning: don't use underscores in Go names; var Flag_name should be FlagName (golint)
  • Line 18: warning: exported var Flag_name should have comment or be unexported (golint)
  • Line 27: warning: don't use underscores in Go names; var Flag_value should be FlagValue (golint)
  • Line 27: warning: exported var Flag_value should have comment or be unexported (golint)
  • Line 42: warning: comment on exported const Type_NULL_TYPE should be of the form "Type_NULL_TYPE ..." (golint)
  • Line 43: warning: don't use underscores in Go names; const Type_NULL_TYPE should be TypeNULLTYPE (golint)
  • Line 44: warning: comment on exported const Type_INT8 should be of the form "Type_INT8 ..." (golint)
  • Line 46: warning: don't use underscores in Go names; const Type_INT8 should be TypeINT8 (golint)
  • Line 47: warning: comment on exported const Type_UINT8 should be of the form "Type_UINT8 ..." (golint)
  • Line 49: warning: don't use underscores in Go names; const Type_UINT8 should be TypeUINT8 (golint)
  • Line 50: warning: comment on exported const Type_INT16 should be of the form "Type_INT16 ..." (golint)
  • Line 52: warning: don't use underscores in Go names; const Type_INT16 should be TypeINT16 (golint)
  • Line 53: warning: comment on exported const Type_UINT16 should be of the form "Type_UINT16 ..." (golint)
  • Line 55: warning: don't use underscores in Go names; const Type_UINT16 should be TypeUINT16 (golint)
  • Line 56: warning: comment on exported const Type_INT32 should be of the form "Type_INT32 ..." (golint)
  • Line 58: warning: don't use underscores in Go names; const Type_INT32 should be TypeINT32 (golint)
  • Line 59: warning: comment on exported const Type_UINT32 should be of the form "Type_UINT32 ..." (golint)
  • Line 61: warning: don't use underscores in Go names; const Type_UINT32 should be TypeUINT32 (golint)
  • Line 62: warning: comment on exported const Type_INT64 should be of the form "Type_INT64 ..." (golint)
  • Line 64: warning: don't use underscores in Go names; const Type_INT64 should be TypeINT64 (golint)
  • Line 65: warning: comment on exported const Type_UINT64 should be of the form "Type_UINT64 ..." (golint)
  • Line 67: warning: don't use underscores in Go names; const Type_UINT64 should be TypeUINT64 (golint)
  • Line 68: warning: comment on exported const Type_FLOAT32 should be of the form "Type_FLOAT32 ..." (golint)
  • Line 70: warning: don't use underscores in Go names; const Type_FLOAT32 should be TypeFLOAT32 (golint)
  • Line 71: warning: comment on exported const Type_FLOAT64 should be of the form "Type_FLOAT64 ..." (golint)
  • Line 73: warning: don't use underscores in Go names; const Type_FLOAT64 should be TypeFLOAT64 (golint)
  • Line 74: warning: comment on exported const Type_TIMESTAMP should be of the form "Type_TIMESTAMP ..." (golint)
  • Line 76: warning: don't use underscores in Go names; const Type_TIMESTAMP should be TypeTIMESTAMP (golint)
  • Line 77: warning: comment on exported const Type_DATE should be of the form "Type_DATE ..." (golint)
  • Line 79: warning: don't use underscores in Go names; const Type_DATE should be TypeDATE (golint)
  • Line 80: warning: comment on exported const Type_TIME should be of the form "Type_TIME ..." (golint)
  • Line 82: warning: don't use underscores in Go names; const Type_TIME should be TypeTIME (golint)
  • Line 83: warning: comment on exported const Type_DATETIME should be of the form "Type_DATETIME ..." (golint)
  • Line 85: warning: don't use underscores in Go names; const Type_DATETIME should be TypeDATETIME (golint)
  • Line 86: warning: comment on exported const Type_YEAR should be of the form "Type_YEAR ..." (golint)
  • Line 88: warning: don't use underscores in Go names; const Type_YEAR should be TypeYEAR (golint)
  • Line 89: warning: comment on exported const Type_DECIMAL should be of the form "Type_DECIMAL ..." (golint)
  • Line 91: warning: don't use underscores in Go names; const Type_DECIMAL should be TypeDECIMAL (golint)
  • Line 92: warning: comment on exported const Type_TEXT should be of the form "Type_TEXT ..." (golint)
  • Line 94: warning: don't use underscores in Go names; const Type_TEXT should be TypeTEXT (golint)
  • Line 95: warning: comment on exported const Type_BLOB should be of the form "Type_BLOB ..." (golint)
  • Line 97: warning: don't use underscores in Go names; const Type_BLOB should be TypeBLOB (golint)
  • Line 98: warning: comment on exported const Type_VARCHAR should be of the form "Type_VARCHAR ..." (golint)
  • Line 100: warning: don't use underscores in Go names; const Type_VARCHAR should be TypeVARCHAR (golint)
  • Line 101: warning: comment on exported const Type_VARBINARY should be of the form "Type_VARBINARY ..." (golint)
  • Line 103: warning: don't use underscores in Go names; const Type_VARBINARY should be TypeVARBINARY (golint)
  • Line 104: warning: comment on exported const Type_CHAR should be of the form "Type_CHAR ..." (golint)
  • Line 106: warning: don't use underscores in Go names; const Type_CHAR should be TypeCHAR (golint)
  • Line 107: warning: comment on exported const Type_BINARY should be of the form "Type_BINARY ..." (golint)
  • Line 109: warning: don't use underscores in Go names; const Type_BINARY should be TypeBINARY (golint)
  • Line 110: warning: comment on exported const Type_BIT should be of the form "Type_BIT ..." (golint)
  • Line 112: warning: don't use underscores in Go names; const Type_BIT should be TypeBIT (golint)
  • Line 113: warning: comment on exported const Type_JSON should be of the form "Type_JSON ..." (golint)
  • Line 115: warning: don't use underscores in Go names; const Type_JSON should be TypeJSON (golint)

• seaweedfs/weed/messaging/msgclient/publisher.go
  • Line 13: warning: exported type Publisher should have comment or be unexported (golint)
  • Line 20: warning: exported method MessagingClient.NewPublisher should have comment or be unexported (golint)
  • Line 98: warning: exported method Publisher.Publish should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server_handlers_admin.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/volume_server_handlers_read.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 28: warning: exported method VolumeServer.GetOrHeadHandler should have comment or be unexported (golint)

• seaweedfs/weed/storage/store_vacuum.go
  • Line 11: warning: exported method Store.CheckCompactVolume should have comment or be unexported (golint)
  • Line 18: warning: exported method Store.CompactVolume should have comment or be unexported (golint)
  • Line 28: warning: exported method Store.CommitCompactVolume should have comment or be unexported (golint)
  • Line 34: warning: exported method Store.CommitCleanupVolume should have comment or be unexported (golint)

• seaweedfs/weed/s3api/filer_multipart.go
  • Line 21: warning: exported type InitiateMultipartUploadResult should have comment or be unexported (golint)
  • Line 54: warning: exported type CompleteMultipartUploadResult should have comment or be unexported (golint)
  • Line 149: warning: exported type ListMultipartUploadsResult should have comment or be unexported (golint)
  • Line 209: warning: exported type ListPartsResult should have comment or be unexported (golint)

• seaweedfs/weed/util/concurrent_read_map.go
  • Line 7: warning: comment on exported type ConcurrentReadMap should be of the form "ConcurrentReadMap ..." (with optional leading article) (golint)
  • Line 15: warning: exported function NewConcurrentReadMap should have comment or be unexported (golint)
  • Line 30: warning: exported method ConcurrentReadMap.Get should have comment or be unexported (golint)
  • Line 40: warning: exported method ConcurrentReadMap.Find should have comment or be unexported (golint)
  • Line 47: warning: exported method ConcurrentReadMap.Items should have comment or be unexported (golint)
  • Line 56: warning: exported method ConcurrentReadMap.Delete should have comment or be unexported (golint)

• seaweedfs/weed/server/master_grpc_server_admin.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 58: warning: exported const LockDuration should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported type AdminLock should have comment or be unexported (golint)
  • Line 67: warning: exported type AdminLocks should have comment or be unexported (golint)
  • Line 72: warning: exported function NewAdminLocks should have comment or be unexported (golint)
  • Line 117: warning: exported method MasterServer.LeaseAdminToken should have comment or be unexported (golint)
  • Line 137: warning: exported method MasterServer.ReleaseAdminToken should have comment or be unexported (golint)

• seaweedfs/weed/server/master_grpc_server_collection.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported method MasterServer.CollectionList should have comment or be unexported (golint)
  • Line 30: warning: exported method MasterServer.CollectionDelete should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map_metric.go
  • Line 9: warning: should not use dot imports (golint)

• seaweedfs/weed/server/master_grpc_server_volume.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported method MasterServer.ProcessGrowRequest should have comment or be unexported (golint)
  • Line 69: warning: exported method MasterServer.LookupVolume should have comment or be unexported (golint)
  • Line 96: warning: exported method MasterServer.Assign should have comment or be unexported (golint)
  • Line 165: warning: exported method MasterServer.Statistics should have comment or be unexported (golint)
  • Line 194: warning: exported method MasterServer.VolumeList should have comment or be unexported (golint)
  • Line 208: warning: exported method MasterServer.LookupEcVolume should have comment or be unexported (golint)
  • Line 241: warning: exported method MasterServer.VacuumVolume should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server_handlers.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 109: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/filer/elastic/v7/elastic_store_kv.go
  • Line 14: warning: exported method ElasticStore.KvDelete should have comment or be unexported (golint)
  • Line 29: warning: exported method ElasticStore.KvGet should have comment or be unexported (golint)
  • Line 48: warning: exported method ElasticStore.KvPut should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/s3sink/s3_write.go
  • Line 1: warning: don't use MixedCaps in package name; S3Sink should be s3sink (golint)

• seaweedfs/weed/filer/filerstore_translate_path.go
  • Line 13: warning: exported type FilerStorePathTranlator should have comment or be unexported (golint)
  • Line 18: warning: exported function NewFilerStorePathTranlator should have comment or be unexported (golint)
  • Line 56: warning: exported method FilerStorePathTranlator.GetName should have comment or be unexported (golint)
  • Line 60: warning: exported method FilerStorePathTranlator.Initialize should have comment or be unexported (golint)
  • Line 64: warning: exported method FilerStorePathTranlator.InsertEntry should have comment or be unexported (golint)
  • Line 71: warning: exported method FilerStorePathTranlator.UpdateEntry should have comment or be unexported (golint)
  • Line 78: warning: exported method FilerStorePathTranlator.FindEntry should have comment or be unexported (golint)
  • Line 90: warning: exported method FilerStorePathTranlator.DeleteEntry should have comment or be unexported (golint)
  • Line 95: warning: exported method FilerStorePathTranlator.DeleteOneEntry should have comment or be unexported (golint)
  • Line 103: warning: exported method FilerStorePathTranlator.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 109: warning: exported method FilerStorePathTranlator.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 119: warning: exported method FilerStorePathTranlator.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 129: warning: exported method FilerStorePathTranlator.BeginTransaction should have comment or be unexported (golint)
  • Line 133: warning: exported method FilerStorePathTranlator.CommitTransaction should have comment or be unexported (golint)
  • Line 137: warning: exported method FilerStorePathTranlator.RollbackTransaction should have comment or be unexported (golint)
  • Line 141: warning: exported method FilerStorePathTranlator.Shutdown should have comment or be unexported (golint)
  • Line 145: warning: exported method FilerStorePathTranlator.KvPut should have comment or be unexported (golint)
  • Line 148: warning: exported method FilerStorePathTranlator.KvGet should have comment or be unexported (golint)
  • Line 151: warning: exported method FilerStorePathTranlator.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/sequence/snowflake_sequencer.go
  • Line 11: warning: comment on exported type SnowflakeSequencer should be of the form "SnowflakeSequencer ..." (with optional leading article) (golint)
  • Line 16: warning: exported function NewSnowflakeSequencer should have comment or be unexported (golint)
  • Line 17: warning: don't use underscores in Go names; var nodeid_hash should be nodeidHash (golint)
  • Line 35: warning: exported method SnowflakeSequencer.NextFileId should have comment or be unexported (golint)
  • Line 39: warning: comment on exported method SnowflakeSequencer.SetMax should be of the form "SetMax ..." (golint)
  • Line 43: warning: comment on exported method SnowflakeSequencer.Peek should be of the form "Peek ..." (golint)

• seaweedfs/weed/wdclient/masterclient.go
  • Line 16: warning: exported type MasterClient should have comment or be unexported (golint)
  • Line 27: warning: exported function NewMasterClient should have comment or be unexported (golint)
  • Line 38: warning: exported method MasterClient.GetMaster should have comment or be unexported (golint)
  • Line 43: warning: exported method MasterClient.WaitUntilConnected should have comment or be unexported (golint)
  • Line 49: warning: exported method MasterClient.KeepConnectedToMaster should have comment or be unexported (golint)
  • Line 57: warning: exported method MasterClient.FindLeaderFromOtherPeers should have comment or be unexported (golint)
  • Line 155: warning: exported method MasterClient.WithClient should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_delete_entry.go
  • Line 12: warning: exported type HardLinkId should have comment or be unexported (golint)
  • Line 15: warning: exported const MsgFailDelNonEmptyFolder should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported method Filer.DeleteEntryMetaAndData should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3api_server.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 15: warning: exported type S3ApiServerOption should have comment or be unexported (golint)
  • Line 26: warning: exported type S3ApiServer should have comment or be unexported (golint)
  • Line 31: warning: exported function NewS3ApiServer should have comment or be unexported (golint)

• seaweedfs/weed/filer/postgres/postgres_sql_gen.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 10: warning: exported type SqlGenPostgres should have comment or be unexported (golint)
  • Line 20: warning: exported method SqlGenPostgres.GetSqlInsert should have comment or be unexported (golint)
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 28: warning: exported method SqlGenPostgres.GetSqlUpdate should have comment or be unexported (golint)
  • Line 32: warning: exported method SqlGenPostgres.GetSqlFind should have comment or be unexported (golint)
  • Line 36: warning: exported method SqlGenPostgres.GetSqlDelete should have comment or be unexported (golint)
  • Line 40: warning: exported method SqlGenPostgres.GetSqlDeleteFolderChildren should have comment or be unexported (golint)
  • Line 44: warning: exported method SqlGenPostgres.GetSqlListExclusive should have comment or be unexported (golint)
  • Line 48: warning: exported method SqlGenPostgres.GetSqlListInclusive should have comment or be unexported (golint)
  • Line 52: warning: exported method SqlGenPostgres.GetSqlCreateTable should have comment or be unexported (golint)
  • Line 56: warning: exported method SqlGenPostgres.GetSqlDropTable should have comment or be unexported (golint)

• seaweedfs/weed/pb/filer_pb/filer_client.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 18: warning: exported var OS_UID should have comment or be unexported (golint)
  • Line 22: warning: exported type FilerClient should have comment or be unexported (golint)
  • Line 27: warning: exported function GetEntry should have comment or be unexported (golint)
  • Line 60: warning: exported type EachEntryFunciton should have comment or be unexported (golint)
  • Line 62: warning: exported function ReadDirAllEntries should have comment or be unexported (golint)
  • Line 88: warning: exported function List should have comment or be unexported (golint)
  • Line 100: warning: exported function SeaweedList should have comment or be unexported (golint)
  • Line 157: warning: exported function Exists should have comment or be unexported (golint)
  • Line 185: warning: exported function Touch should have comment or be unexported (golint)
  • Line 205: warning: exported function Mkdir should have comment or be unexported (golint)
  • Line 239: warning: exported function MkFile should have comment or be unexported (golint)
  • Line 270: warning: exported function Remove should have comment or be unexported (golint)
  • Line 287: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• seaweedfs/weed/wdclient/net2/base_connection_pool.go
  • Line 72: warning: comment on exported function NewSimpleConnectionPool should be of the form "NewSimpleConnectionPool ..." (golint)
  • Line 78: warning: comment on exported function NewMultiConnectionPool should be of the form "NewMultiConnectionPool ..." (golint)

• seaweedfs/weed/command/filer.go
  • Line 32: warning: exported type FilerOptions should have comment or be unexported (golint)
  • Line 180: warning: don't use underscores in Go names; var nfs_err should be nfsErr (golint)

• seaweedfs/weed/shell/command_volume_server_evacuate.go
  • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/messaging/broker/broker_grpc_server_discovery.go
  • Line 27: warning: exported method MessageBroker.FindBroker should have comment or be unexported (golint)

• seaweedfs/weed/stats/duration_counter.go
  • Line 7: warning: exported type TimedValue should have comment or be unexported (golint)
  • Line 12: warning: exported function NewTimedValue should have comment or be unexported (golint)
  • Line 16: warning: exported type RoundRobinCounter should have comment or be unexported (golint)
  • Line 22: warning: exported function NewRoundRobinCounter should have comment or be unexported (golint)
  • Line 25: warning: exported method RoundRobinCounter.Add should have comment or be unexported (golint)
  • Line 37: warning: exported method RoundRobinCounter.Max should have comment or be unexported (golint)
  • Line 45: warning: exported method RoundRobinCounter.Count should have comment or be unexported (golint)
  • Line 51: warning: exported method RoundRobinCounter.Sum should have comment or be unexported (golint)
  • Line 58: warning: exported method RoundRobinCounter.ToList should have comment or be unexported (golint)
  • Line 72: warning: exported type DurationCounter should have comment or be unexported (golint)
  • Line 79: warning: exported function NewDurationCounter should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_backup.go
  • Line 16: warning: should not use dot imports (golint)
  • Line 19: warning: exported method Volume.GetVolumeSyncStatus should have comment or be unexported (golint)
  • Line 65: warning: exported method Volume.IncrementalBackup should have comment or be unexported (golint)
  • Line 169: warning: comment on exported method Volume.BinarySearchByAppendAtNs should be of the form "BinarySearchByAppendAtNs ..." (golint)
  • Line 232: warning: comment on exported type VolumeFileScanner4GenIdx should be of the form "VolumeFileScanner4GenIdx ..." (with optional leading article) (golint)
  • Line 237: warning: exported method VolumeFileScanner4GenIdx.VisitSuperBlock should have comment or be unexported (golint)
  • Line 241: warning: exported method VolumeFileScanner4GenIdx.ReadNeedleBody should have comment or be unexported (golint)
  • Line 245: warning: exported method VolumeFileScanner4GenIdx.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_vacuum.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported method VolumeServer.VacuumVolumeCheck should have comment or be unexported (golint)
  • Line 27: warning: exported method VolumeServer.VacuumVolumeCompact should have comment or be unexported (golint)
  • Line 43: warning: exported method VolumeServer.VacuumVolumeCommit should have comment or be unexported (golint)
  • Line 59: warning: exported method VolumeServer.VacuumVolumeCleanup should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis2/redis_store.go
  • Line 13: warning: exported type Redis2Store should have comment or be unexported (golint)
  • Line 17: warning: exported method Redis2Store.GetName should have comment or be unexported (golint)
  • Line 21: warning: exported method Redis2Store.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/topology/topology_vacuum.go
  • Line 147: warning: exported method Topology.Vacuum should have comment or be unexported (golint)

• seaweedfs/weed/topology/volume_location_list.go
  • Line 9: warning: exported type VolumeLocationList should have comment or be unexported (golint)
  • Line 13: warning: exported function NewVolumeLocationList should have comment or be unexported (golint)
  • Line 21: warning: exported method VolumeLocationList.Copy should have comment or be unexported (golint)
  • Line 29: warning: exported method VolumeLocationList.Head should have comment or be unexported (golint)
  • Line 34: warning: exported method VolumeLocationList.Length should have comment or be unexported (golint)
  • Line 41: warning: exported method VolumeLocationList.Set should have comment or be unexported (golint)
  • Line 51: warning: exported method VolumeLocationList.Remove should have comment or be unexported (golint)
  • Line 61: warning: exported method VolumeLocationList.Refresh should have comment or be unexported (golint)
  • Line 80: warning: exported method VolumeLocationList.Stats should have comment or be unexported (golint)

• seaweedfs/weed/shell/command_ec_common.go
  • Line 126: warning: exported type CandidateEcNode should have comment or be unexported (golint)
  • Line 174: warning: exported type RackId should have comment or be unexported (golint)
  • Line 175: warning: exported type EcNodeId should have comment or be unexported (golint)
  • Line 177: warning: exported type EcNode should have comment or be unexported (golint)
  • Line 196: warning: exported type EcRack should have comment or be unexported (golint)

• seaweedfs/weed/util/constants_4bytes.go
  • Line 7: warning: exported const VolumeSizeLimitGB should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/filer/filer_conf.go
  • Line 16: warning: exported const DirectoryEtcRoot should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type FilerConf should have comment or be unexported (golint)
  • Line 28: warning: exported function NewFilerConf should have comment or be unexported (golint)
  • Line 65: warning: exported method FilerConf.LoadFromBytes should have comment or be unexported (golint)
  • Line 86: warning: exported method FilerConf.AddLocationConf should have comment or be unexported (golint)
  • Line 94: warning: exported method FilerConf.DeleteLocationConf should have comment or be unexported (golint)
  • Line 107: warning: exported method FilerConf.MatchStorageRule should have comment or be unexported (golint)
  • Line 134: warning: exported method FilerConf.ToProto should have comment or be unexported (golint)
  • Line 144: warning: exported method FilerConf.ToText should have comment or be unexported (golint)

• seaweedfs/weed/operation/assign_file_id.go
  • Line 16: warning: exported type VolumeAssignRequest should have comment or be unexported (golint)
  • Line 28: warning: exported type AssignResult should have comment or be unexported (golint)
  • Line 37: warning: exported function Assign should have comment or be unexported (golint)
  • Line 95: warning: exported function LookupJwt should have comment or be unexported (golint)
  • Line 109: warning: exported type StorageOption should have comment or be unexported (golint)
  • Line 120: warning: exported method StorageOption.TtlString should have comment or be unexported (golint)
  • Line 124: warning: exported method StorageOption.ToAssignRequests should have comment or be unexported (golint)

• seaweedfs/weed/command/command.go
  • Line 10: warning: exported var Commands should have comment or be unexported (golint)
  • Line 41: warning: exported type Command should have comment or be unexported (golint)
  • Line 72: warning: exported method Command.Usage should have comment or be unexported (golint)

• seaweedfs/weed/topology/configuration.go
  • Line 22: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 35: warning: exported method Configuration.Locate should have comment or be unexported (golint)

• seaweedfs/weed/shell/commands.go
  • Line 19: warning: exported type ShellOptions should have comment or be unexported (golint)
  • Line 28: warning: exported type CommandEnv should have comment or be unexported (golint)
  • Line 42: warning: exported var Commands should have comment or be unexported (golint)
  • Line 45: warning: exported function NewCommandEnv should have comment or be unexported (golint)
  • Line 98: warning: exported method CommandEnv.WithFilerClient should have comment or be unexported (golint)
  • Line 105: warning: exported method CommandEnv.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/util/queue_unbounded.go
  • Line 5: warning: exported type UnboundedQueue should have comment or be unexported (golint)
  • Line 12: warning: exported function NewUnboundedQueue should have comment or be unexported (golint)
  • Line 17: warning: exported method UnboundedQueue.EnQueue should have comment or be unexported (golint)
  • Line 25: warning: exported method UnboundedQueue.Consume should have comment or be unexported (golint)

• seaweedfs/weed/filer/mongodb/mongodb_store_kv.go
  • Line 12: warning: exported method MongodbStore.KvPut should have comment or be unexported (golint)
  • Line 31: warning: exported method MongodbStore.KvGet should have comment or be unexported (golint)
  • Line 50: warning: exported method MongodbStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/filer/postgres/postgres_store.go
  • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 15: warning: exported const CONNECTION_URL_PATTERN should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported type PostgresStore should have comment or be unexported (golint)
  • Line 26: warning: exported method PostgresStore.GetName should have comment or be unexported (golint)
  • Line 30: warning: exported method PostgresStore.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/azuresink/azure_sink.go
  • Line 20: warning: exported type AzureSink should have comment or be unexported (golint)
  • Line 32: warning: exported method AzureSink.GetName should have comment or be unexported (golint)
  • Line 36: warning: exported method AzureSink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 40: warning: exported method AzureSink.IsIncremental should have comment or be unexported (golint)
  • Line 44: warning: exported method AzureSink.Initialize should have comment or be unexported (golint)
  • Line 54: warning: exported method AzureSink.SetSourceFiler should have comment or be unexported (golint)
  • Line 80: warning: exported method AzureSink.DeleteEntry should have comment or be unexported (golint)
  • Line 97: warning: exported method AzureSink.CreateEntry should have comment or be unexported (golint)
  • Line 130: warning: exported method AzureSink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/util/chunk_cache/on_disk_cache_layer.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported type OnDiskCacheLayer should have comment or be unexported (golint)
  • Line 17: warning: exported function NewOnDiskCacheLayer should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/net2/ip.go
  • Line 15: warning: comment on exported function MyHostname should be of the form "MyHostname ..." (golint)
  • Line 32: warning: comment on exported function MyIp4 should be of the form "MyIp4 ..." (golint)
  • Line 49: warning: comment on exported function MyIp6 should be of the form "MyIp6 ..." (golint)
  • Line 63: warning: comment on exported function GetLocalIPs should be of the form "GetLocalIPs ..." (golint)
  • Line 112: warning: exported function IsLocalhostIp should have comment or be unexported (golint)
  • Line 125: warning: comment on exported function IsLocalhost should be of the form "IsLocalhost ..." (golint)
  • Line 133: warning: comment on exported function ResolveIP4s should be of the form "ResolveIP4s ..." (golint)
  • Line 158: warning: exported function LookupValidAddrs should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_grpc_server_rename.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported method FilerServer.AtomicRenameEntry should have comment or be unexported (golint)
  • Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/filer/cassandra/cassandra_store_kv.go
  • Line 11: warning: exported method CassandraStore.KvPut should have comment or be unexported (golint)
  • Line 23: warning: exported method CassandraStore.KvGet should have comment or be unexported (golint)
  • Line 41: warning: exported method CassandraStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/notification/log/log_queue.go
  • Line 14: warning: exported type LogQueue should have comment or be unexported (golint)
  • Line 17: warning: exported method LogQueue.GetName should have comment or be unexported (golint)
  • Line 21: warning: exported method LogQueue.Initialize should have comment or be unexported (golint)
  • Line 25: warning: exported method LogQueue.SendMessage should have comment or be unexported (golint)

• seaweedfs/weed/filesys/fscache.go
  • Line 11: warning: exported type FsCache should have comment or be unexported (golint)
  • Line 15: warning: exported type FsNode should have comment or be unexported (golint)
  • Line 31: warning: exported method FsCache.GetFsNode should have comment or be unexported (golint)
  • Line 50: warning: exported method FsCache.SetFsNode should have comment or be unexported (golint)
  • Line 66: warning: exported method FsCache.EnsureFsNode should have comment or be unexported (golint)
  • Line 80: warning: exported method FsCache.DeleteFsNode should have comment or be unexported (golint)
  • Line 98: warning: comment on exported method FsCache.Move should be of the form "Move ..." (golint)

• seaweedfs/weed/util/retry.go
  • Line 10: warning: exported var RetryWaitTime should have comment or be unexported (golint)
  • Line 12: warning: exported function Retry should have comment or be unexported (golint)
  • Line 35: warning: comment on exported function Nvl should be of the form "Nvl ..." (golint)

• seaweedfs/weed/server/filer_grpc_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported method FilerServer.LookupDirectoryEntry should have comment or be unexported (golint)
  • Line 47: warning: exported method FilerServer.ListEntries should have comment or be unexported (golint)
  • Line 107: warning: exported method FilerServer.LookupVolume should have comment or be unexported (golint)
  • Line 153: warning: exported method FilerServer.CreateEntry should have comment or be unexported (golint)
  • Line 184: warning: exported method FilerServer.UpdateEntry should have comment or be unexported (golint)
  • Line 282: warning: exported method FilerServer.AppendToEntry should have comment or be unexported (golint)
  • Line 326: warning: exported method FilerServer.DeleteEntry should have comment or be unexported (golint)
  • Line 338: warning: exported method FilerServer.AssignVolume should have comment or be unexported (golint)
  • Line 369: warning: exported method FilerServer.CollectionList should have comment or be unexported (golint)
  • Line 391: warning: exported method FilerServer.DeleteCollection should have comment or be unexported (golint)
  • Line 405: warning: exported method FilerServer.Statistics should have comment or be unexported (golint)
  • Line 435: warning: exported method FilerServer.GetFilerConfiguration should have comment or be unexported (golint)
  • Line 454: warning: exported method FilerServer.KeepConnected should have comment or be unexported (golint)
  • Line 494: warning: exported method FilerServer.LocateBroker should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_grpc_server_sub_meta.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported method FilerServer.SubscribeMetadata should have comment or be unexported (golint)
  • Line 68: warning: exported method FilerServer.SubscribeLocalMetadata should have comment or be unexported (golint)

• seaweedfs/weed/filer/abstract_sql/abstract_sql_store.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported type SqlGenerator should have comment or be unexported (golint)
  • Line 27: warning: exported type AbstractSqlStore should have comment or be unexported (golint)
  • Line 35: warning: exported method AbstractSqlStore.OnBucketCreation should have comment or be unexported (golint)
  • Line 46: warning: exported method AbstractSqlStore.OnBucketDeletion should have comment or be unexported (golint)
  • Line 59: warning: exported const DEFAULT_TABLE should have comment (or a comment on this block) or be unexported (golint)
  • Line 62: warning: exported type TxOrDB should have comment or be unexported (golint)
  • Line 68: warning: exported method AbstractSqlStore.BeginTransaction should have comment or be unexported (golint)
  • Line 77: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 79: warning: exported method AbstractSqlStore.CommitTransaction should have comment or be unexported (golint)
  • Line 85: warning: exported method AbstractSqlStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 143: warning: exported method AbstractSqlStore.InsertEntry should have comment or be unexported (golint)
  • Line 186: warning: exported method AbstractSqlStore.UpdateEntry should have comment or be unexported (golint)
  • Line 211: warning: exported method AbstractSqlStore.FindEntry should have comment or be unexported (golint)
  • Line 239: warning: exported method AbstractSqlStore.DeleteEntry should have comment or be unexported (golint)
  • Line 261: warning: exported method AbstractSqlStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 274: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 294: warning: exported method AbstractSqlStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 338: warning: exported method AbstractSqlStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 342: warning: exported method AbstractSqlStore.Shutdown should have comment or be unexported (golint)
  • Line 350: warning: exported method AbstractSqlStore.CreateTable should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dirty_pages_continuous.go
  • Line 14: warning: exported type ContinuousDirtyPages should have comment or be unexported (golint)
  • Line 34: warning: exported method ContinuousDirtyPages.AddPage should have comment or be unexported (golint)
  • Line 63: warning: exported method ContinuousDirtyPages.FlushData should have comment or be unexported (golint)
  • Line 144: warning: exported method ContinuousDirtyPages.ReadDirtyDataAt should have comment or be unexported (golint)
  • Line 148: warning: exported method ContinuousDirtyPages.GetStorageOptions should have comment or be unexported (golint)
  • Line 152: warning: exported method ContinuousDirtyPages.SetWriteOnly should have comment or be unexported (golint)
  • Line 158: warning: exported method ContinuousDirtyPages.GetWriteOnly should have comment or be unexported (golint)

• seaweedfs/weed/security/jwt.go
  • Line 13: warning: exported type EncodedJwt should have comment or be unexported (golint)
  • Line 14: warning: exported type SigningKey should have comment or be unexported (golint)
  • Line 16: warning: exported type SeaweedFileIdClaims should have comment or be unexported (golint)
  • Line 21: warning: exported function GenJwt should have comment or be unexported (golint)
  • Line 42: warning: exported function GetJwt should have comment or be unexported (golint)
  • Line 58: warning: exported function DecodeJwt should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/resource_pool/simple_resource_pool.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 16: warning: exported type TooManyHandles should have comment or be unexported (golint)
  • Line 24: warning: exported type OpenHandleError should have comment or be unexported (golint)
  • Line 50: warning: comment on exported function NewSimpleResourcePool should be of the form "NewSimpleResourcePool ..." (golint)

• seaweedfs/weed/shell/command_collection_list.go
  • Line 42: warning: exported function ListCollectionNames should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_decoder.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: comment on exported function WriteIdxFileFromEcIndex should be of the form "WriteIdxFileFromEcIndex ..." (golint)

• seaweedfs/weed/storage/needle_map/memdb_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/storage/disk_location_ec.go
  • Line 20: warning: exported method DiskLocation.FindEcVolume should have comment or be unexported (golint)
  • Line 31: warning: exported method DiskLocation.DestroyEcVolume should have comment or be unexported (golint)
  • Line 42: warning: exported method DiskLocation.FindEcShard should have comment or be unexported (golint)
  • Line 58: warning: exported method DiskLocation.LoadEcShard should have comment or be unexported (golint)
  • Line 82: warning: exported method DiskLocation.UnloadEcShard should have comment or be unexported (golint)
  • Line 192: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 198: warning: exported method DiskLocation.EcVolumesLen should have comment or be unexported (golint)

• seaweedfs/weed/filer/mysql/mysql_store.go
  • Line 12: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 16: warning: exported const CONNECTION_URL_PATTERN should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type MysqlStore should have comment or be unexported (golint)
  • Line 27: warning: exported method MysqlStore.GetName should have comment or be unexported (golint)
  • Line 31: warning: exported method MysqlStore.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/pb/volume_server_pb/volume_server_helper.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: exported method RemoteFile.BackendName should have comment or be unexported (golint)

• seaweedfs/weed/filer/filechunks.go
  • Line 15: warning: exported function TotalSize should have comment or be unexported (golint)
  • Line 25: warning: exported function FileSize should have comment or be unexported (golint)
  • Line 29: warning: exported function ETag should have comment or be unexported (golint)
  • Line 36: warning: exported function ETagEntry should have comment or be unexported (golint)
  • Line 43: warning: exported function ETagChunks should have comment or be unexported (golint)
  • Line 47: warning: don't use underscores in Go names; var md5_digests should be md5Digests (golint)
  • Line 54: warning: exported function CompactFileChunks should have comment or be unexported (golint)
  • Line 73: warning: exported function MinusChunks should have comment or be unexported (golint)
  • Line 89: warning: exported function DoMinusChunks should have comment or be unexported (golint)
  • Line 104: warning: exported type ChunkView should have comment or be unexported (golint)
  • Line 114: warning: exported method ChunkView.IsFullChunk should have comment or be unexported (golint)
  • Line 118: warning: exported function ViewFromChunks should have comment or be unexported (golint)
  • Line 126: warning: exported function ViewFromVisibleIntervals should have comment or be unexported (golint)
  • Line 173: warning: exported function MergeIntoVisibles should have comment or be unexported (golint)
  • Line 255: warning: exported type VisibleInterval should have comment or be unexported (golint)

• seaweedfs/weed/filer/filer_notify.go
  • Line 18: warning: exported method Filer.NotifyUpdateEvent should have comment or be unexported (golint)
  • Line 110: warning: exported method Filer.ReadPersistedLogBuffer should have comment or be unexported (golint)
  • Line 152: warning: exported function ReadEachLogEntry should have comment or be unexported (golint)
  • Line 181: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• seaweedfs/weed/filesys/dir.go
  • Line 22: warning: exported type Dir should have comment or be unexported (golint)
  • Line 48: warning: exported method Dir.Id should have comment or be unexported (golint)
  • Line 55: warning: exported method Dir.Attr should have comment or be unexported (golint)
  • Line 83: warning: exported method Dir.Getxattr should have comment or be unexported (golint)
  • Line 95: warning: exported method Dir.Fsync should have comment or be unexported (golint)
  • Line 129: warning: exported method Dir.Create should have comment or be unexported (golint)
  • Line 169: warning: exported method Dir.Mknod should have comment or be unexported (golint)
  • Line 227: warning: exported method Dir.Mkdir should have comment or be unexported (golint)
  • Line 281: warning: exported method Dir.Lookup should have comment or be unexported (golint)
  • Line 336: warning: exported method Dir.ReadDirAll should have comment or be unexported (golint)
  • Line 408: warning: exported method Dir.Remove should have comment or be unexported (golint)
  • Line 473: warning: exported method Dir.Setattr should have comment or be unexported (golint)
  • Line 502: warning: exported method Dir.Setxattr should have comment or be unexported (golint)
  • Line 519: warning: exported method Dir.Removexattr should have comment or be unexported (golint)
  • Line 536: warning: exported method Dir.Listxattr should have comment or be unexported (golint)
  • Line 553: warning: exported method Dir.Forget should have comment or be unexported (golint)
  • Line 593: warning: exported method Dir.FullPath should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_tier_upload.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/storage/store_ec_delete.go
  • Line 15: warning: exported method Store.DeleteEcShardNeedle should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_stream_write.go
  • Line 13: warning: should not use dot imports (golint)
  • Line 16: warning: exported method Volume.StreamWrite should have comment or be unexported (golint)
  • Line 64: warning: exported method Volume.StreamRead should have comment or be unexported (golint)
  • Line 92: warning: exported type StreamReader should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server_tcp_handlers_write.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported method VolumeServer.HandleTcpConnection should have comment or be unexported (golint)

• seaweedfs/weed/filer/leveldb3/leveldb3_store.go
  • Line 24: warning: exported const DEFAULT should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type LevelDB3Store should have comment or be unexported (golint)
  • Line 37: warning: exported method LevelDB3Store.GetName should have comment or be unexported (golint)
  • Line 41: warning: exported method LevelDB3Store.Initialize should have comment or be unexported (golint)
  • Line 153: warning: exported method LevelDB3Store.BeginTransaction should have comment or be unexported (golint)
  • Line 156: warning: exported method LevelDB3Store.CommitTransaction should have comment or be unexported (golint)
  • Line 159: warning: exported method LevelDB3Store.RollbackTransaction should have comment or be unexported (golint)
  • Line 163: warning: exported method LevelDB3Store.InsertEntry should have comment or be unexported (golint)
  • Line 193: warning: exported method LevelDB3Store.UpdateEntry should have comment or be unexported (golint)
  • Line 198: warning: exported method LevelDB3Store.FindEntry should have comment or be unexported (golint)
  • Line 230: warning: exported method LevelDB3Store.DeleteEntry should have comment or be unexported (golint)
  • Line 248: warning: exported method LevelDB3Store.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 290: warning: exported method LevelDB3Store.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 294: warning: exported method LevelDB3Store.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 372: warning: exported method LevelDB3Store.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/localsink/local_sink.go
  • Line 16: warning: exported type LocalSink should have comment or be unexported (golint)
  • Line 26: warning: exported method LocalSink.SetSourceFiler should have comment or be unexported (golint)
  • Line 30: warning: exported method LocalSink.GetName should have comment or be unexported (golint)
  • Line 44: warning: exported method LocalSink.Initialize should have comment or be unexported (golint)
  • Line 51: warning: exported method LocalSink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 55: warning: exported method LocalSink.IsIncremental should have comment or be unexported (golint)
  • Line 59: warning: exported method LocalSink.DeleteEntry should have comment or be unexported (golint)
  • Line 70: warning: exported method LocalSink.CreateEntry should have comment or be unexported (golint)
  • Line 110: warning: exported method LocalSink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/storage/super_block/replica_placement.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: exported type ReplicaPlacement should have comment or be unexported (golint)
  • Line 14: warning: exported function NewReplicaPlacementFromString should have comment or be unexported (golint)
  • Line 34: warning: exported function NewReplicaPlacementFromByte should have comment or be unexported (golint)
  • Line 38: warning: exported method ReplicaPlacement.Byte should have comment or be unexported (golint)
  • Line 54: warning: exported method ReplicaPlacement.GetCopyCount should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle/needle_parse_upload.go
  • Line 20: warning: exported type ParsedUpload should have comment or be unexported (golint)
  • Line 35: warning: exported function ParseUpload should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/net2/managed_connection.go
  • Line 12: warning: comment on exported type NetworkAddress should be of the form "NetworkAddress ..." (with optional leading article) (golint)
  • Line 18: warning: comment on exported type ManagedConn should be of the form "ManagedConn ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported function NewManagedConn should be of the form "NewManagedConn ..." (golint)

• seaweedfs/weed/command/filer_copy.go
  • Line 36: warning: exported type CopyOptions should have comment or be unexported (golint)
  • Line 239: warning: exported type FileCopyWorker should have comment or be unexported (golint)
  • Line 254: warning: exported type FileCopyTask should have comment or be unexported (golint)

• seaweedfs/weed/command/filer_sync.go
  • Line 23: warning: exported type SyncOptions should have comment or be unexported (golint)
  • Line 215: warning: exported const SyncKeyPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 338: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 351: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/server/volume_grpc_copy_incremental.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: exported method VolumeServer.VolumeIncrementalCopy should have comment or be unexported (golint)
  • Line 37: warning: exported method VolumeServer.VolumeSyncStatus should have comment or be unexported (golint)

• seaweedfs/weed/messaging/msgclient/config.go
  • Line 32: warning: exported method MessagingClient.DeleteTopic should have comment or be unexported (golint)

• seaweedfs/weed/operation/sync_volume.go
  • Line 9: warning: exported function GetVolumeSyncStatus should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/s3_backend/s3_download.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filesys/filehandle.go
  • Line 21: warning: exported type FileHandle should have comment or be unexported (golint)
  • Line 195: warning: exported method FileHandle.Release should have comment or be unexported (golint)
  • Line 221: warning: exported method FileHandle.Flush should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/resource_pool/resource_pool.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 7: warning: exported type Options should have comment or be unexported (golint)
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 49: warning: comment on exported type ResourcePool should be of the form "ResourcePool ..." (with optional leading article) (golint)

• seaweedfs/weed/server/volume_server_handlers_ui.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/storage/backend/memory_map/memory_map.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 8: warning: exported type MemoryBuffer should have comment or be unexported (golint)
  • Line 9: warning: don't use underscores in Go names; struct field aligned_length should be alignedLength (golint)
  • Line 11: warning: don't use underscores in Go names; struct field aligned_ptr should be alignedPtr (golint)
  • Line 16: warning: exported type MemoryMap should have comment or be unexported (golint)
  • Line 18: warning: don't use underscores in Go names; struct field file_memory_map_handle should be fileMemoryMapHandle (golint)
  • Line 19: warning: don't use underscores in Go names; struct field write_map_views should be writeMapViews (golint)
  • Line 20: warning: don't use underscores in Go names; struct field max_length should be maxLength (golint)
  • Line 21: warning: don't use underscores in Go names; struct field End_of_file should be EndOfFile (golint)
  • Line 24: warning: exported function ReadMemoryMapMaxSizeMb should have comment or be unexported (golint)

• seaweedfs/weed/topology/store_replicate.go
  • Line 21: warning: exported function ReplicatedWrite should have comment or be unexported (golint)
  • Line 95: warning: exported function ReplicatedDelete should have comment or be unexported (golint)
  • Line 127: warning: exported type DistributedOperationResult should have comment or be unexported (golint)
  • Line 142: warning: exported type RemoteResult should have comment or be unexported (golint)

• seaweedfs/weed/topology/topology_ec.go
  • Line 10: warning: exported type EcShardLocations should have comment or be unexported (golint)
  • Line 15: warning: exported method Topology.SyncDataNodeEcShards should have comment or be unexported (golint)
  • Line 37: warning: exported method Topology.IncrementalSyncDataNodeEcShards should have comment or be unexported (golint)
  • Line 68: warning: exported function NewEcShardLocations should have comment or be unexported (golint)
  • Line 74: warning: exported method EcShardLocations.AddShard should have comment or be unexported (golint)
  • Line 85: warning: exported method EcShardLocations.DeleteShard should have comment or be unexported (golint)
  • Line 100: warning: exported method Topology.RegisterEcShards should have comment or be unexported (golint)
  • Line 115: warning: exported method Topology.UnRegisterEcShards should have comment or be unexported (golint)
  • Line 129: warning: exported method Topology.LookupEcShards should have comment or be unexported (golint)
  • Line 138: warning: exported method Topology.ListEcServersByCollection should have comment or be unexported (golint)
  • Line 153: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 160: warning: exported method Topology.DeleteEcCollection should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/gcssink/gcs_sink.go
  • Line 20: warning: exported type GcsSink should have comment or be unexported (golint)
  • Line 32: warning: exported method GcsSink.GetName should have comment or be unexported (golint)
  • Line 36: warning: exported method GcsSink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 40: warning: exported method GcsSink.IsIncremental should have comment or be unexported (golint)
  • Line 44: warning: exported method GcsSink.Initialize should have comment or be unexported (golint)
  • Line 53: warning: exported method GcsSink.SetSourceFiler should have comment or be unexported (golint)
  • Line 57: warning: don't use underscores in Go names; method parameter google_application_credentials should be googleApplicationCredentials (golint)
  • Line 79: warning: exported method GcsSink.DeleteEntry should have comment or be unexported (golint)
  • Line 93: warning: exported method GcsSink.CreateEntry should have comment or be unexported (golint)
  • Line 118: warning: exported method GcsSink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle/volume_version.go
  • Line 3: warning: exported type Version should have comment or be unexported (golint)
  • Line 6: warning: exported const Version1 should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/s3api/s3api_objects_list_handlers.go
  • Line 22: warning: exported type ListBucketResultV2 should have comment or be unexported (golint)
  • Line 37: warning: exported method S3ApiServer.ListObjectsV2Handler should have comment or be unexported (golint)
  • Line 92: warning: exported method S3ApiServer.ListObjectsV1Handler should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_erasure_coding.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 85: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 229: warning: exported method VolumeServer.VolumeEcShardsMount should have comment or be unexported (golint)
  • Line 250: warning: exported method VolumeServer.VolumeEcShardsUnmount should have comment or be unexported (golint)
  • Line 271: warning: exported method VolumeServer.VolumeEcShardRead should have comment or be unexported (golint)
  • Line 339: warning: exported method VolumeServer.VolumeEcBlobDelete should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_volume.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: error var NotFoundError should have name of the form ErrFoo (golint)
  • Line 21: warning: exported var NotFoundError should have comment or be unexported (golint)
  • Line 24: warning: exported type EcVolume should have comment or be unexported (golint)
  • Line 42: warning: exported function NewEcVolume should have comment or be unexported (golint)
  • Line 77: warning: exported method EcVolume.AddEcVolumeShard should have comment or be unexported (golint)
  • Line 91: warning: exported method EcVolume.DeleteEcVolumeShard should have comment or be unexported (golint)
  • Line 108: warning: exported method EcVolume.FindEcVolumeShard should have comment or be unexported (golint)
  • Line 117: warning: exported method EcVolume.Close should have comment or be unexported (golint)
  • Line 133: warning: exported method EcVolume.Destroy should have comment or be unexported (golint)
  • Line 145: warning: exported method EcVolume.FileName should have comment or be unexported (golint)
  • Line 154: warning: exported method EcVolume.DataBaseFileName should have comment or be unexported (golint)
  • Line 158: warning: exported method EcVolume.IndexBaseFileName should have comment or be unexported (golint)
  • Line 162: warning: exported method EcVolume.ShardSize should have comment or be unexported (golint)
  • Line 169: warning: exported method EcVolume.Size should have comment or be unexported (golint)
  • Line 176: warning: exported method EcVolume.CreatedAt should have comment or be unexported (golint)
  • Line 180: warning: exported method EcVolume.ShardIdList should have comment or be unexported (golint)
  • Line 187: warning: exported method EcVolume.ToVolumeEcShardInformationMessage should have comment or be unexported (golint)
  • Line 205: warning: exported method EcVolume.LocateEcShardNeedle should have comment or be unexported (golint)
  • Line 221: warning: exported method EcVolume.FindNeedleFromEcx should have comment or be unexported (golint)
  • Line 225: warning: exported function SearchNeedleFromSortedIndex should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle/file_id.go
  • Line 8: warning: should not use dot imports (golint)
  • Line 11: warning: exported type FileId should have comment or be unexported (golint)
  • Line 17: warning: exported function NewFileIdFromNeedle should have comment or be unexported (golint)
  • Line 21: warning: exported function NewFileId should have comment or be unexported (golint)
  • Line 25: warning: comment on exported function ParseFileIdFromString should be of the form "ParseFileIdFromString ..." (golint)
  • Line 44: warning: exported method FileId.GetVolumeId should have comment or be unexported (golint)
  • Line 48: warning: exported method FileId.GetNeedleId should have comment or be unexported (golint)
  • Line 52: warning: exported method FileId.GetCookie should have comment or be unexported (golint)
  • Line 56: warning: exported method FileId.GetNeedleIdCookie should have comment or be unexported (golint)
  • Line 68: warning: don't use underscores in Go names; var nonzero_index should be nonzeroIndex (golint)
  • Line 75: warning: don't use underscores in Go names; func result key_cookie should be keyCookie (golint)

• seaweedfs/weed/topology/data_node.go
  • Line 15: warning: exported type DataNode should have comment or be unexported (golint)
  • Line 23: warning: exported function NewDataNode should have comment or be unexported (golint)
  • Line 39: warning: exported method DataNode.AddOrUpdateVolume should have comment or be unexported (golint)
  • Line 106: warning: exported method DataNode.DeltaUpdateVolumes should have comment or be unexported (golint)
  • Line 131: warning: exported method DataNode.AdjustMaxVolumeCounts should have comment or be unexported (golint)
  • Line 150: warning: exported method DataNode.GetVolumes should have comment or be unexported (golint)
  • Line 160: warning: exported method DataNode.GetVolumesById should have comment or be unexported (golint)
  • Line 173: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 178: warning: exported method DataNode.GetDataCenter should have comment or be unexported (golint)
  • Line 191: warning: exported method DataNode.GetRack should have comment or be unexported (golint)
  • Line 195: warning: exported method DataNode.GetTopology should have comment or be unexported (golint)
  • Line 204: warning: exported method DataNode.MatchLocation should have comment or be unexported (golint)
  • Line 208: warning: exported method DataNode.Url should have comment or be unexported (golint)
  • Line 212: warning: exported method DataNode.ToMap should have comment or be unexported (golint)
  • Line 239: warning: exported method DataNode.ToDataNodeInfo should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis/redis_cluster_store.go
  • Line 13: warning: exported type RedisClusterStore should have comment or be unexported (golint)
  • Line 17: warning: exported method RedisClusterStore.GetName should have comment or be unexported (golint)
  • Line 21: warning: exported method RedisClusterStore.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis2/redis_cluster_store.go
  • Line 13: warning: exported type RedisCluster2Store should have comment or be unexported (golint)
  • Line 17: warning: exported method RedisCluster2Store.GetName should have comment or be unexported (golint)
  • Line 21: warning: exported method RedisCluster2Store.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis2/universal_redis_store_kv.go
  • Line 11: warning: exported method UniversalRedis2Store.KvPut should have comment or be unexported (golint)
  • Line 22: warning: exported method UniversalRedis2Store.KvGet should have comment or be unexported (golint)
  • Line 33: warning: exported method UniversalRedis2Store.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/filer/entry_codec.go
  • Line 14: warning: exported method Entry.EncodeAttributesAndChunks should have comment or be unexported (golint)
  • Line 26: warning: exported method Entry.DecodeAttributesAndChunks should have comment or be unexported (golint)
  • Line 47: warning: exported function EntryAttributeToPb should have comment or be unexported (golint)
  • Line 68: warning: exported function PbToEntryAttribute should have comment or be unexported (golint)
  • Line 95: warning: exported function EqualEntry should have comment or be unexported (golint)

• seaweedfs/weed/storage/super_block/super_block_read.go.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/volume_server_handlers_write.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 18: warning: exported method VolumeServer.PostHandler should have comment or be unexported (golint)
  • Line 77: warning: exported method VolumeServer.DeleteHandler should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_checking.go
  • Line 13: warning: should not use dot imports (golint)
  • Line 17: warning: exported function CheckAndFixVolumeDataIntegrity should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_write_autochunk.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 306: warning: exported function SaveAmzMetaData should have comment or be unexported (golint)

• seaweedfs/weed/util/chunk_cache/chunk_cache_on_disk.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported type ChunkCacheVolume should have comment or be unexported (golint)
  • Line 30: warning: exported function LoadOrCreateChunkCacheVolume should have comment or be unexported (golint)
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 80: warning: exported method ChunkCacheVolume.Shutdown should have comment or be unexported (golint)
  • Line 100: warning: exported method ChunkCacheVolume.Reset should have comment or be unexported (golint)
  • Line 105: warning: exported method ChunkCacheVolume.GetNeedle should have comment or be unexported (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 138: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 147: warning: exported method ChunkCacheVolume.WriteNeedle should have comment or be unexported (golint)

• seaweedfs/weed/command/filer_cat.go
  • Line 24: warning: exported type FilerCatOptions should have comment or be unexported (golint)
  • Line 31: warning: exported method FilerCatOptions.GetLookupFileIdFunction should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/memory_map/memory_map_backend.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 12: warning: exported type MemoryMappedFile should have comment or be unexported (golint)
  • Line 16: warning: exported function NewMemoryMappedFile should have comment or be unexported (golint)
  • Line 24: warning: exported method MemoryMappedFile.ReadAt should have comment or be unexported (golint)
  • Line 34: warning: exported method MemoryMappedFile.WriteAt should have comment or be unexported (golint)
  • Line 39: warning: exported method MemoryMappedFile.Truncate should have comment or be unexported (golint)
  • Line 43: warning: exported method MemoryMappedFile.Close should have comment or be unexported (golint)
  • Line 48: warning: exported method MemoryMappedFile.GetStat should have comment or be unexported (golint)
  • Line 56: warning: exported method MemoryMappedFile.Name should have comment or be unexported (golint)
  • Line 60: warning: exported method MemoryMappedFile.Sync should have comment or be unexported (golint)
  • Line 60: warning: receiver name mm should be consistent with previous receiver name mmf for MemoryMappedFile (golint)

• seaweedfs/weed/iamapi/iamapi_management_handlers.go
  • Line 26: warning: exported const StatementActionAdmin should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported function MapToStatementAction should have comment or be unexported (golint)
  • Line 57: warning: exported function MapToIdentitiesAction should have comment or be unexported (golint)
  • Line 74: warning: exported type Statement should have comment or be unexported (golint)
  • Line 80: warning: exported type Policies should have comment or be unexported (golint)
  • Line 84: warning: exported type PolicyDocument should have comment or be unexported (golint)
  • Line 94: warning: exported function Hash should have comment or be unexported (golint)
  • Line 100: warning: exported function StringWithCharset should have comment or be unexported (golint)
  • Line 108: warning: exported method IamApiServer.ListUsers should have comment or be unexported (golint)
  • Line 115: warning: exported method IamApiServer.ListAccessKeys should have comment or be unexported (golint)
  • Line 131: warning: exported method IamApiServer.CreateUser should have comment or be unexported (golint)
  • Line 138: warning: exported method IamApiServer.DeleteUser should have comment or be unexported (golint)
  • Line 148: warning: exported method IamApiServer.GetUser should have comment or be unexported (golint)
  • Line 158: warning: exported function GetPolicyDocument should have comment or be unexported (golint)
  • Line 165: warning: exported method IamApiServer.CreatePolicy should have comment or be unexported (golint)
  • Line 190: warning: exported method IamApiServer.PutUserPolicy should have comment or be unexported (golint)
  • Line 211: warning: exported method IamApiServer.GetUserPolicy should have comment or be unexported (golint)
  • Line 265: warning: exported method IamApiServer.DeleteUserPolicy should have comment or be unexported (golint)
  • Line 276: warning: exported function GetActions should have comment or be unexported (golint)
  • Line 313: warning: exported method IamApiServer.CreateAccessKey should have comment or be unexported (golint)
  • Line 346: warning: exported method IamApiServer.DeleteAccessKey should have comment or be unexported (golint)
  • Line 363: warning: exported method IamApiServer.DoActions should have comment or be unexported (golint)

• seaweedfs/weed/storage/idx/walk.go
  • Line 10: warning: comment on exported function WalkIndexFile should be of the form "WalkIndexFile ..." (golint)
  • Line 45: warning: exported function IdxFileEntry should have comment or be unexported (golint)
  • Line 53: warning: exported const RowsToRead should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/operation/lookup_vid_cache.go
  • Line 12: warning: exported var ErrorNotFound should have comment or be unexported (golint)
  • Line 14: warning: exported type VidInfo should have comment or be unexported (golint)
  • Line 18: warning: exported type VidCache should have comment or be unexported (golint)
  • Line 23: warning: exported method VidCache.Get should have comment or be unexported (golint)
  • Line 42: warning: exported method VidCache.Set should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/s3_backend/s3_upload.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/command/filer_meta_backup.go
  • Line 24: warning: exported type FilerMetaBackupOptions should have comment or be unexported (golint)
  • Line 145: warning: exported var MetaBackupKey should have comment or be unexported (golint)
  • Line 258: warning: exported method FilerMetaBackupOptions.WithFilerClient should have comment or be unexported (golint)
  • Line 266: warning: exported method FilerMetaBackupOptions.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/topology/cluster_commands.go
  • Line 9: warning: exported type MaxVolumeIdCommand should have comment or be unexported (golint)
  • Line 13: warning: exported function NewMaxVolumeIdCommand should have comment or be unexported (golint)
  • Line 19: warning: exported method MaxVolumeIdCommand.CommandName should have comment or be unexported (golint)
  • Line 23: warning: exported method MaxVolumeIdCommand.Apply should have comment or be unexported (golint)

• seaweedfs/weed/shell/command_ec_rebuild.go
  • Line 248: warning: exported type EcShardMap should have comment or be unexported (golint)
  • Line 249: warning: exported type EcShardLocations should have comment or be unexported (golint)

• seaweedfs/weed/images/resizing.go
  • Line 16: warning: exported function Resized should have comment or be unexported (golint)
  • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/pb/filer_pb/filer_pb_helper.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported function ToFileIdObject should have comment or be unexported (golint)
  • Line 32: warning: exported method FileChunk.GetFileIdString should have comment or be unexported (golint)
  • Line 43: warning: exported function BeforeEntrySerialization should have comment or be unexported (golint)
  • Line 64: warning: exported function EnsureFid should have comment or be unexported (golint)
  • Line 73: warning: exported function AfterEntryDeserialization should have comment or be unexported (golint)
  • Line 88: warning: exported function CreateEntry should have comment or be unexported (golint)
  • Line 101: warning: exported function UpdateEntry should have comment or be unexported (golint)
  • Line 110: warning: exported function LookupEntry should have comment or be unexported (golint)
  • Line 125: warning: exported var ErrNotFound should have comment or be unexported (golint)
  • Line 127: warning: exported function IsCreate should have comment or be unexported (golint)
  • Line 130: warning: exported function IsUpdate should have comment or be unexported (golint)
  • Line 135: warning: exported function IsDelete should have comment or be unexported (golint)
  • Line 138: warning: exported function IsRename should have comment or be unexported (golint)
  • Line 146: warning: exported method FilerConf_PathConf.Key should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_ui/breadcrumb.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: exported type Breadcrumb should have comment or be unexported (golint)
  • Line 14: warning: exported function ToBreadcrumb should have comment or be unexported (golint)

• seaweedfs/weed/storage/super_block/replica_placement_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filesys/wfs_filer_client.go
  • Line 14: warning: exported method WFS.WithFilerClient should have comment or be unexported (golint)
  • Line 46: warning: exported method WFS.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3api_object_handlers_postpolicy.go
  • Line 20: warning: exported method S3ApiServer.PostPolicyBucketHandler should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 40: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 48: warning: exported type FilerOption should have comment or be unexported (golint)
  • Line 68: warning: exported type FilerServer should have comment or be unexported (golint)
  • Line 89: warning: exported function NewFilerServer should have comment or be unexported (golint)

• seaweedfs/weed/server/raft_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type RaftServer should have comment or be unexported (golint)
  • Line 30: warning: exported type StateMachine should have comment or be unexported (golint)
  • Line 35: warning: exported method StateMachine.Save should have comment or be unexported (golint)
  • Line 43: warning: exported method StateMachine.Recovery should have comment or be unexported (golint)
  • Line 54: warning: exported function NewRaftServer should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 134: warning: exported method RaftServer.Peers should have comment or be unexported (golint)
  • Line 152: warning: exported method RaftServer.DoJoinCommand should have comment or be unexported (golint)

• seaweedfs/weed/command/volume.go
  • Line 37: warning: exported type VolumeServerOptions should have comment or be unexported (golint)

• seaweedfs/weed/topology/collection.go
  • Line 12: warning: exported type Collection should have comment or be unexported (golint)
  • Line 19: warning: exported function NewCollection should have comment or be unexported (golint)
  • Line 33: warning: exported method Collection.GetOrCreateVolumeLayout should have comment or be unexported (golint)
  • Line 47: warning: exported method Collection.DeleteVolumeLayout should have comment or be unexported (golint)
  • Line 58: warning: exported method Collection.Lookup should have comment or be unexported (golint)
  • Line 69: warning: exported method Collection.ListVolumeServers should have comment or be unexported (golint)

• seaweedfs/weed/util/file_util.go
  • Line 14: warning: exported function TestFolderWritable should have comment or be unexported (golint)
  • Line 30: warning: exported function GetFileSize should have comment or be unexported (golint)
  • Line 38: warning: exported function FileExists should have comment or be unexported (golint)
  • Line 48: warning: exported function CheckFile should have comment or be unexported (golint)
  • Line 70: warning: exported function ResolvePath should have comment or be unexported (golint)

• seaweedfs/weed/filer/mysql2/mysql2_store.go
  • Line 13: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 17: warning: exported const CONNECTION_URL_PATTERN should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type MysqlStore2 should have comment or be unexported (golint)
  • Line 28: warning: exported method MysqlStore2.GetName should have comment or be unexported (golint)
  • Line 32: warning: exported method MysqlStore2.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/filer/postgres2/postgres2_store.go
  • Line 13: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 17: warning: exported const CONNECTION_URL_PATTERN should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type PostgresStore2 should have comment or be unexported (golint)
  • Line 28: warning: exported method PostgresStore2.GetName should have comment or be unexported (golint)
  • Line 32: warning: exported method PostgresStore2.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis2/universal_redis_store.go
  • Line 17: warning: exported const DIR_LIST_MARKER should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type UniversalRedis2Store should have comment or be unexported (golint)
  • Line 38: warning: exported method UniversalRedis2Store.BeginTransaction should have comment or be unexported (golint)
  • Line 41: warning: exported method UniversalRedis2Store.CommitTransaction should have comment or be unexported (golint)
  • Line 44: warning: exported method UniversalRedis2Store.RollbackTransaction should have comment or be unexported (golint)
  • Line 48: warning: exported method UniversalRedis2Store.InsertEntry should have comment or be unexported (golint)
  • Line 77: warning: exported method UniversalRedis2Store.UpdateEntry should have comment or be unexported (golint)
  • Line 82: warning: exported method UniversalRedis2Store.FindEntry should have comment or be unexported (golint)
  • Line 104: warning: exported method UniversalRedis2Store.DeleteEntry should have comment or be unexported (golint)
  • Line 130: warning: exported method UniversalRedis2Store.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 152: warning: exported method UniversalRedis2Store.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 156: warning: exported method UniversalRedis2Store.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 202: warning: exported method UniversalRedis2Store.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/messaging/msgclient/chan_pub.go
  • Line 15: warning: exported type PubChannel should have comment or be unexported (golint)
  • Line 21: warning: exported method MessagingClient.NewPubChannel should have comment or be unexported (golint)
  • Line 42: warning: exported method PubChannel.Publish should have comment or be unexported (golint)
  • Line 53: warning: exported method PubChannel.Close should have comment or be unexported (golint)
  • Line 74: warning: exported method PubChannel.Md5 should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map.go
  • Line 10: warning: should not use dot imports (golint)
  • Line 13: warning: exported type NeedleMapKind should have comment or be unexported (golint)
  • Line 16: warning: exported const NeedleMapInMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported type NeedleMapper should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_write.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported var OS_UID should have comment or be unexported (golint)
  • Line 27: warning: exported type FilerPostResult should have comment or be unexported (golint)
  • Line 58: warning: exported method FilerServer.PostHandler should have comment or be unexported (golint)
  • Line 86: warning: comment on exported method FilerServer.DeleteHandler should be of the form "DeleteHandler ..." (golint)

• seaweedfs/weed/storage/needle_map/compact_map.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 7: warning: should not use dot imports (golint)
  • Line 14: warning: exported type SectionalNeedleId should have comment or be unexported (golint)
  • Line 16: warning: exported const SectionalNeedleIdLimit should have comment or be unexported (golint)
  • Line 18: warning: exported type SectionalNeedleValue should have comment or be unexported (golint)
  • Line 24: warning: exported type SectionalNeedleValueExtra should have comment or be unexported (golint)
  • Line 28: warning: exported type CompactSection should have comment or be unexported (golint)
  • Line 39: warning: exported type Overflow should have comment or be unexported (golint)
  • Line 40: warning: exported type OverflowExtra should have comment or be unexported (golint)
  • Line 42: warning: exported function NewCompactSection should have comment or be unexported (golint)
  • Line 52: warning: comment on exported method CompactSection.Set should be of the form "Set ..." (golint)
  • Line 124: warning: comment on exported method CompactSection.Delete should be of the form "Delete ..." (golint)
  • Line 142: warning: exported method CompactSection.Get should have comment or be unexported (golint)
  • Line 171: warning: comment on exported type CompactMap should be of the form "CompactMap ..." (with optional leading article) (golint)
  • Line 177: warning: exported function NewCompactMap should have comment or be unexported (golint)
  • Line 181: warning: exported method CompactMap.Set should have comment or be unexported (golint)
  • Line 204: warning: exported method CompactMap.Delete should have comment or be unexported (golint)
  • Line 211: warning: exported method CompactMap.Get should have comment or be unexported (golint)
  • Line 244: warning: comment on exported method CompactMap.AscendingVisit should be of the form "AscendingVisit ..." (golint)

• seaweedfs/weed/storage/needle/async_request.go
  • Line 3: warning: exported type AsyncRequest should have comment or be unexported (golint)
  • Line 14: warning: exported function NewAsyncRequest should have comment or be unexported (golint)
  • Line 27: warning: exported method AsyncRequest.WaitComplete should have comment or be unexported (golint)
  • Line 32: warning: exported method AsyncRequest.Complete should have comment or be unexported (golint)
  • Line 40: warning: exported method AsyncRequest.UpdateResult should have comment or be unexported (golint)
  • Line 47: warning: exported method AsyncRequest.Submit should have comment or be unexported (golint)
  • Line 51: warning: exported method AsyncRequest.IsSucceed should have comment or be unexported (golint)

• seaweedfs/weed/util/throttler.go
  • Line 5: warning: exported type WriteThrottler should have comment or be unexported (golint)
  • Line 11: warning: exported function NewWriteThrottler should have comment or be unexported (golint)
  • Line 18: warning: exported method WriteThrottler.MaybeSlowdown should have comment or be unexported (golint)

• seaweedfs/weed/command/scaffold.go
  • Line 64: warning: exported const FILER_TOML_EXAMPLE should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/s3api/tags.go
  • Line 7: warning: exported type Tag should have comment or be unexported (golint)
  • Line 12: warning: exported type TagSet should have comment or be unexported (golint)
  • Line 16: warning: exported type Tagging should have comment or be unexported (golint)
  • Line 21: warning: exported method Tagging.ToTags should have comment or be unexported (golint)
  • Line 29: warning: exported function FromTags should have comment or be unexported (golint)

• seaweedfs/weed/filer/mysql/mysql_sql_gen.go
  • Line 7: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 10: warning: exported type SqlGenMysql should have comment or be unexported (golint)
  • Line 20: warning: exported method SqlGenMysql.GetSqlInsert should have comment or be unexported (golint)
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 28: warning: exported method SqlGenMysql.GetSqlUpdate should have comment or be unexported (golint)
  • Line 32: warning: exported method SqlGenMysql.GetSqlFind should have comment or be unexported (golint)
  • Line 36: warning: exported method SqlGenMysql.GetSqlDelete should have comment or be unexported (golint)
  • Line 40: warning: exported method SqlGenMysql.GetSqlDeleteFolderChildren should have comment or be unexported (golint)
  • Line 44: warning: exported method SqlGenMysql.GetSqlListExclusive should have comment or be unexported (golint)
  • Line 48: warning: exported method SqlGenMysql.GetSqlListInclusive should have comment or be unexported (golint)
  • Line 52: warning: exported method SqlGenMysql.GetSqlCreateTable should have comment or be unexported (golint)
  • Line 56: warning: exported method SqlGenMysql.GetSqlDropTable should have comment or be unexported (golint)

• seaweedfs/weed/pb/grpc_client_server.go
  • Line 23: warning: don't use underscores in Go names; const Max_Message_Size should be MaxMessageSize (golint)
  • Line 23: warning: exported const Max_Message_Size should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported function NewGrpcServer should have comment or be unexported (golint)
  • Line 66: warning: exported function GrpcDial should have comment or be unexported (golint)
  • Line 114: warning: exported function WithCachedGrpcClient should have comment or be unexported (golint)
  • Line 140: warning: exported function ParseServerToGrpcAddress should have comment or be unexported (golint)
  • Line 143: warning: exported function ParseServersToGrpcAddresses should have comment or be unexported (golint)
  • Line 154: warning: exported function ParseServerAddress should have comment or be unexported (golint)
  • Line 179: warning: exported function ServerToGrpcAddress should have comment or be unexported (golint)
  • Line 191: warning: exported function GrpcAddressToServerAddress should have comment or be unexported (golint)
  • Line 202: warning: exported function WithMasterClient should have comment or be unexported (golint)
  • Line 216: warning: exported function WithBrokerGrpcClient should have comment or be unexported (golint)
  • Line 225: warning: exported function WithFilerClient should have comment or be unexported (golint)
  • Line 236: warning: exported function WithGrpcFilerClient should have comment or be unexported (golint)
  • Line 245: warning: exported function WithOneOfGrpcFilerClients should have comment or be unexported (golint)

• seaweedfs/weed/pb/shared_values.go
  • Line 4: warning: exported const AdminShellClient should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/storage/needle_map/memdb.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: should not use dot imports (golint)
  • Line 17: warning: comment on exported type MemDb should be of the form "MemDb ..." (with optional leading article) (golint)
  • Line 22: warning: exported function NewMemDb should have comment or be unexported (golint)
  • Line 35: warning: exported method MemDb.Set should have comment or be unexported (golint)
  • Line 45: warning: exported method MemDb.Delete should have comment or be unexported (golint)
  • Line 51: warning: exported method MemDb.Get should have comment or be unexported (golint)
  • Line 63: warning: comment on exported method MemDb.AscendingVisit should be of the form "AscendingVisit ..." (golint)
  • Line 84: warning: exported method MemDb.SaveToIdx should have comment or be unexported (golint)
  • Line 101: warning: exported method MemDb.LoadFromIdx should have comment or be unexported (golint)
  • Line 112: warning: exported method MemDb.LoadFromReaderAt should have comment or be unexported (golint)
  • Line 123: warning: exported method MemDb.Close should have comment or be unexported (golint)

• seaweedfs/weed/command/mount_std.go
  • Line 70: warning: exported function RunMount should have comment or be unexported (golint)

• seaweedfs/weed/notification/aws_sqs/aws_sqs_pub.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type AwsSqsPub should have comment or be unexported (golint)
  • Line 26: warning: exported method AwsSqsPub.GetName should have comment or be unexported (golint)
  • Line 30: warning: exported method AwsSqsPub.Initialize should have comment or be unexported (golint)
  • Line 71: warning: exported method AwsSqsPub.SendMessage should have comment or be unexported (golint)

• seaweedfs/weed/s3api/filer_util_tags.go
  • Line 11: warning: exported const S3TAG_PREFIX should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 85: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• seaweedfs/weed/util/minfreespace.go
  • Line 71: warning: exported var ErrMinFreeSpaceBadValue should have comment or be unexported (golint)

• seaweedfs/weed/server/master_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 29: warning: exported const SequencerType should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: exported type MasterOption should have comment or be unexported (golint)
  • Line 48: warning: exported type MasterServer should have comment or be unexported (golint)
  • Line 71: warning: exported function NewMasterServer should have comment or be unexported (golint)
  • Line 152: warning: exported method MasterServer.SetRaftServer should have comment or be unexported (golint)

• seaweedfs/weed/command/upload.go
  • Line 22: warning: exported type UploadOptions should have comment or be unexported (golint)

• seaweedfs/weed/util/cipher.go
  • Line 13: warning: exported type CipherKey should have comment or be unexported (golint)
  • Line 15: warning: exported function GenCipherKey should have comment or be unexported (golint)
  • Line 23: warning: exported function Encrypt should have comment or be unexported (golint)
  • Line 42: warning: exported function Decrypt should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_tail.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 16: warning: exported method VolumeServer.VolumeTailSender should have comment or be unexported (golint)
  • Line 81: warning: exported method VolumeServer.VolumeTailReceiver should have comment or be unexported (golint)
  • Line 99: warning: comment on exported type VolumeFileScanner4Tailing should be of the form "VolumeFileScanner4Tailing ..." (with optional leading article) (golint)
  • Line 105: warning: exported method VolumeFileScanner4Tailing.VisitSuperBlock should have comment or be unexported (golint)
  • Line 109: warning: exported method VolumeFileScanner4Tailing.ReadNeedleBody should have comment or be unexported (golint)
  • Line 113: warning: exported method VolumeFileScanner4Tailing.VisitNeedle should have comment or be unexported (golint)

• seaweedfs/weed/messaging/broker/broker_server.go
  • Line 15: warning: exported type MessageBrokerOption should have comment or be unexported (golint)
  • Line 24: warning: exported type MessageBroker should have comment or be unexported (golint)
  • Line 30: warning: exported function NewMessageBroker should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/s3sink/s3_sink.go
  • Line 1: warning: don't use MixedCaps in package name; S3Sink should be s3sink (golint)
  • Line 23: warning: exported type S3Sink should have comment or be unexported (golint)
  • Line 37: warning: exported method S3Sink.GetName should have comment or be unexported (golint)
  • Line 41: warning: exported method S3Sink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 45: warning: exported method S3Sink.IsIncremental should have comment or be unexported (golint)
  • Line 49: warning: exported method S3Sink.Initialize should have comment or be unexported (golint)
  • Line 66: warning: exported method S3Sink.SetSourceFiler should have comment or be unexported (golint)
  • Line 94: warning: exported method S3Sink.DeleteEntry should have comment or be unexported (golint)
  • Line 106: warning: exported method S3Sink.CreateEntry should have comment or be unexported (golint)
  • Line 148: warning: exported method S3Sink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/s3api/s3_constants/s3_actions.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 4: warning: exported const ACTION_READ should have comment (or a comment on this block) or be unexported (golint)

• seaweedfs/weed/replication/source/filer_source.go
  • Line 20: warning: exported type ReplicationSource should have comment or be unexported (golint)
  • Line 24: warning: exported type FilerSource should have comment or be unexported (golint)
  • Line 32: warning: exported method FilerSource.Initialize should have comment or be unexported (golint)
  • Line 41: warning: exported method FilerSource.DoInitialize should have comment or be unexported (golint)
  • Line 53: warning: exported method FilerSource.LookupFileId should have comment or be unexported (golint)
  • Line 96: warning: exported method FilerSource.ReadPart should have comment or be unexported (golint)
  • Line 121: warning: exported method FilerSource.WithFilerClient should have comment or be unexported (golint)
  • Line 130: warning: exported method FilerSource.AdjustedUrl should have comment or be unexported (golint)

• seaweedfs/weed/filer/filechunk_manifest.go
  • Line 19: warning: exported const ManifestBatch should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported function HasChunkManifest should have comment or be unexported (golint)
  • Line 31: warning: exported function SeparateManifestChunks should have comment or be unexported (golint)
  • Line 42: warning: exported function ResolveChunkManifest should have comment or be unexported (golint)
  • Line 67: warning: exported function ResolveOneChunkManifest should have comment or be unexported (golint)
  • Line 130: warning: exported function MaybeManifestize should have comment or be unexported (golint)
  • Line 194: warning: exported type SaveDataAsChunkFunctionType should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server_handlers_helper.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/filesys/meta_cache/cache_config.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/util/log_buffer/log_buffer_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/wdclient/vid_map.go
  • Line 18: warning: exported type HasLookupFileIdFunction should have comment or be unexported (golint)
  • Line 22: warning: exported type LookupFileIdFunctionType should have comment or be unexported (golint)
  • Line 24: warning: exported type Location should have comment or be unexported (golint)

• seaweedfs/weed/storage/store.go
  • Line 19: warning: should not use dot imports (golint)
  • Line 23: warning: exported const MAX_TTL_VOLUME_REMOVAL_DELAY should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type ReadOption should have comment or be unexported (golint)
  • Line 30: warning: comment on exported type Store should be of the form "Store ..." (with optional leading article) (golint)
  • Line 56: warning: exported function NewStore should have comment or be unexported (golint)
  • Line 74: warning: exported method Store.AddVolume should have comment or be unexported (golint)
  • Line 86: warning: exported method Store.DeleteCollection should have comment or be unexported (golint)
  • Line 105: warning: exported method Store.FindFreeLocation should have comment or be unexported (golint)
  • Line 144: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 151: warning: exported method Store.VolumeInfos should have comment or be unexported (golint)
  • Line 200: warning: exported method Store.SetDataCenter should have comment or be unexported (golint)
  • Line 203: warning: exported method Store.SetRack should have comment or be unexported (golint)
  • Line 206: warning: exported method Store.GetDataCenter should have comment or be unexported (golint)
  • Line 209: warning: exported method Store.GetRack should have comment or be unexported (golint)
  • Line 213: warning: exported method Store.CollectHeartbeat should have comment or be unexported (golint)
  • Line 319: warning: exported method Store.Close should have comment or be unexported (golint)
  • Line 325: warning: exported method Store.WriteVolumeNeedle should have comment or be unexported (golint)
  • Line 339: warning: exported method Store.DeleteVolumeNeedle should have comment or be unexported (golint)
  • Line 349: warning: exported method Store.ReadVolumeNeedle should have comment or be unexported (golint)
  • Line 355: warning: exported method Store.GetVolume should have comment or be unexported (golint)
  • Line 359: warning: exported method Store.HasVolume should have comment or be unexported (golint)
  • Line 364: warning: exported method Store.MarkVolumeReadonly should have comment or be unexported (golint)
  • Line 375: warning: exported method Store.MarkVolumeWritable should have comment or be unexported (golint)
  • Line 386: warning: exported method Store.MountVolume should have comment or be unexported (golint)
  • Line 406: warning: exported method Store.UnmountVolume should have comment or be unexported (golint)
  • Line 431: warning: exported method Store.DeleteVolume should have comment or be unexported (golint)
  • Line 449: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 457: warning: exported method Store.ConfigureVolume should have comment or be unexported (golint)
  • Line 482: warning: exported method Store.SetVolumeSizeLimit should have comment or be unexported (golint)
  • Line 486: warning: exported method Store.GetVolumeSizeLimit should have comment or be unexported (golint)
  • Line 490: warning: exported method Store.MaybeAdjustVolumeMax should have comment or be unexported (golint)

• seaweedfs/weed/util/log_buffer/log_read.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 16: warning: error var ResumeError should have name of the form ErrFoo (golint)
  • Line 16: warning: exported var ResumeError should have comment or be unexported (golint)
  • Line 17: warning: error var ResumeFromDiskError should have name of the form ErrFoo (golint)
  • Line 20: warning: exported method LogBuffer.LoopProcessLogData should have comment or be unexported (golint)

• seaweedfs/weed/wdclient/volume_tcp_client.go
  • Line 21: warning: exported type VolumeTcpConn should have comment or be unexported (golint)
  • Line 27: warning: exported function NewVolumeTcpClient should have comment or be unexported (golint)
  • Line 49: warning: exported method VolumeTcpClient.PutFileChunk should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_read_dir.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 31: warning: don't use underscores in Go names; var limit_err should be limitErr (golint)

• seaweedfs/weed/images/preprocess.go
  • Line 10: warning: comment on exported function MaybePreprocessImage should be of the form "MaybePreprocessImage ..." (golint)

• seaweedfs/weed/operation/delete_content.go
  • Line 15: warning: exported type DeleteResult should have comment or be unexported (golint)
  • Line 22: warning: exported function ParseFileId should have comment or be unexported (golint)
  • Line 22: warning: don't use underscores in Go names; func result key_cookie should be keyCookie (golint)
  • Line 49: warning: exported function DeleteFilesWithLookupVolumeId should have comment or be unexported (golint)
  • Line 53: warning: don't use underscores in Go names; var vid_to_fileIds should be vidToFileIds (golint)
  • Line 77: warning: don't use underscores in Go names; var server_to_fileIds should be serverToFileIds (golint)

• seaweedfs/weed/storage/types/needle_types.go
  • Line 10: warning: exported type Offset should have comment or be unexported (golint)
  • Line 15: warning: exported type Size should have comment or be unexported (golint)
  • Line 17: warning: exported method Size.IsDeleted should have comment or be unexported (golint)
  • Line 20: warning: exported method Size.IsValid should have comment or be unexported (golint)
  • Line 24: warning: exported type OffsetLower should have comment or be unexported (golint)
  • Line 31: warning: exported type Cookie should have comment or be unexported (golint)
  • Line 34: warning: exported const SizeSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported function CookieToBytes should have comment or be unexported (golint)
  • Line 46: warning: exported function Uint32ToCookie should have comment or be unexported (golint)
  • Line 50: warning: exported function BytesToCookie should have comment or be unexported (golint)
  • Line 54: warning: exported function ParseCookie should have comment or be unexported (golint)
  • Line 62: warning: exported function BytesToSize should have comment or be unexported (golint)
  • Line 66: warning: exported function SizeToBytes should have comment or be unexported (golint)

• seaweedfs/weed/security/guard.go
  • Line 14: warning: exported var ErrUnauthorized should have comment or be unexported (golint)
  • Line 53: warning: exported function NewGuard should have comment or be unexported (golint)
  • Line 65: warning: exported method Guard.WhiteList should have comment or be unexported (golint)
  • Line 79: warning: exported function GetActualRemoteHost should have comment or be unexported (golint)

• seaweedfs/weed/stats/disk.go
  • Line 8: warning: exported function NewDiskStatus should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_server_handlers_write_upload.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: error should be the last type when returning multiple items (golint)
  • Line 100: warning: error should be the last type when returning multiple items (golint)

• seaweedfs/weed/server/master_server_handlers_admin.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/volume_grpc_copy.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported const BufferSizeLimit should have comment or be unexported (golint)
  • Line 198: warning: exported method VolumeServer.ReadVolumeFileStatus should have comment or be unexported (golint)

• seaweedfs/unmaintained/volume_tailer/volume_tailer.go
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/command/download.go
  • Line 20: warning: exported type DownloadOptions should have comment or be unexported (golint)
  • Line 120: warning: exported function WriteFile should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_super_block.go
  • Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• seaweedfs/weed/replication/sink/filersink/filer_sink.go
  • Line 21: warning: exported type FilerSink should have comment or be unexported (golint)
  • Line 40: warning: exported method FilerSink.GetName should have comment or be unexported (golint)
  • Line 44: warning: exported method FilerSink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 48: warning: exported method FilerSink.IsIncremental should have comment or be unexported (golint)
  • Line 52: warning: exported method FilerSink.Initialize should have comment or be unexported (golint)
  • Line 66: warning: exported method FilerSink.SetSourceFiler should have comment or be unexported (golint)
  • Line 70: warning: exported method FilerSink.DoInitialize should have comment or be unexported (golint)
  • Line 87: warning: exported method FilerSink.DeleteEntry should have comment or be unexported (golint)
  • Line 100: warning: exported method FilerSink.CreateEntry should have comment or be unexported (golint)
  • Line 151: warning: exported method FilerSink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/backend.go
  • Line 15: warning: exported type BackendStorageFile should have comment or be unexported (golint)
  • Line 25: warning: exported type BackendStorage should have comment or be unexported (golint)
  • Line 33: warning: exported type StringProperties should have comment or be unexported (golint)
  • Line 36: warning: exported type StorageType should have comment or be unexported (golint)
  • Line 37: warning: exported type BackendStorageFactory should have comment or be unexported (golint)
  • Line 43: warning: exported var BackendStorageFactories should have comment or be unexported (golint)
  • Line 47: warning: comment on exported function LoadConfiguration should be of the form "LoadConfiguration ..." (golint)
  • Line 78: warning: comment on exported function LoadFromPbStorageBackends should be of the form "LoadFromPbStorageBackends ..." (golint)
  • Line 101: warning: exported type Properties should have comment or be unexported (golint)
  • Line 109: warning: exported method Properties.GetString should have comment or be unexported (golint)
  • Line 116: warning: exported function ToPbStorageBackends should have comment or be unexported (golint)
  • Line 131: warning: exported function BackendNameToTypeId should have comment or be unexported (golint)

• seaweedfs/weed/util/chunk_cache/chunk_cache_in_memory.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: comment on exported type ChunkCacheInMemory should be of the form "ChunkCacheInMemory ..." (with optional leading article) (golint)
  • Line 14: warning: exported function NewChunkCacheInMemory should have comment or be unexported (golint)
  • Line 24: warning: exported method ChunkCacheInMemory.GetChunk should have comment or be unexported (golint)
  • Line 48: warning: exported method ChunkCacheInMemory.SetChunk should have comment or be unexported (golint)

• seaweedfs/weed/command/iam.go
  • Line 22: warning: exported type IamOptions should have comment or be unexported (golint)
  • Line 72: warning: don't use underscores in Go names; var iamApiServer_err should be iamAPIServerErr (golint)

• seaweedfs/weed/command/server.go
  • Line 16: warning: exported type ServerOptions should have comment or be unexported (golint)
  • Line 75: warning: exported var False should have comment or be unexported (golint)

• seaweedfs/weed/filer/leveldb/leveldb_store_kv.go
  • Line 10: warning: exported method LevelDBStore.KvPut should have comment or be unexported (golint)
  • Line 21: warning: exported method LevelDBStore.KvGet should have comment or be unexported (golint)
  • Line 36: warning: exported method LevelDBStore.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dir_rename.go
  • Line 14: warning: exported method Dir.Rename should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle_map/needle_value_map.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 4: warning: should not use dot imports (golint)
  • Line 7: warning: exported type NeedleValueMap should have comment or be unexported (golint)

• seaweedfs/weed/storage/needle/volume_ttl.go
  • Line 9: warning: comment on exported const Empty should be of the form "Empty ..." (golint)
  • Line 11: warning: exported const Minute should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported type TTL should have comment or be unexported (golint)
  • Line 24: warning: exported var EMPTY_TTL should have comment or be unexported (golint)
  • Line 26: warning: comment on exported function ReadTTL should be of the form "ReadTTL ..." (golint)
  • Line 50: warning: comment on exported function LoadTTLFromBytes should be of the form "LoadTTLFromBytes ..." (golint)
  • Line 58: warning: comment on exported function LoadTTLFromUint32 should be of the form "LoadTTLFromUint32 ..." (golint)
  • Line 66: warning: comment on exported method TTL.ToBytes should be of the form "ToBytes ..." (golint)
  • Line 72: warning: exported method TTL.ToUint32 should have comment or be unexported (golint)
  • Line 124: warning: exported method TTL.Minutes should have comment or be unexported (golint)
  • Line 144: warning: exported function SecondsToTTL should have comment or be unexported (golint)

• seaweedfs/weed/command/gateway.go
  • Line 18: warning: exported type GatewayOptions should have comment or be unexported (golint)
  • Line 70: warning: don't use underscores in Go names; var gws_err should be gwsErr (golint)

• seaweedfs/weed/server/volume_grpc_client_to_master.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported method VolumeServer.GetMaster should have comment or be unexported (golint)
  • Line 41: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 88: warning: exported method VolumeServer.StopHeartbeat should have comment or be unexported (golint)

• seaweedfs/weed/filer/filerstore_hardlink.go
  • Line 73: warning: exported method FilerStoreWrapper.DeleteHardLink should have comment or be unexported (golint)

• seaweedfs/weed/stats/memory.go
  • Line 9: warning: exported function MemStat should have comment or be unexported (golint)

• seaweedfs/weed/shell/shell_liner.go
  • Line 21: warning: exported function RunShell should have comment or be unexported (golint)
  • Line 69: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/server/filer_server_handlers.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 109: warning: exported function OptionsHandler should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_grpc_admin.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 16: warning: exported method VolumeServer.DeleteCollection should have comment or be unexported (golint)
  • Line 32: warning: exported method VolumeServer.AllocateVolume should have comment or be unexported (golint)
  • Line 57: warning: exported method VolumeServer.VolumeMount should have comment or be unexported (golint)
  • Line 73: warning: exported method VolumeServer.VolumeUnmount should have comment or be unexported (golint)
  • Line 89: warning: exported method VolumeServer.VolumeDelete should have comment or be unexported (golint)
  • Line 105: warning: exported method VolumeServer.VolumeConfigure should have comment or be unexported (golint)
  • Line 140: warning: exported method VolumeServer.VolumeMarkReadonly should have comment or be unexported (golint)
  • Line 155: warning: exported method VolumeServer.VolumeMarkWritable should have comment or be unexported (golint)
  • Line 170: warning: exported method VolumeServer.VolumeStatus should have comment or be unexported (golint)
  • Line 184: warning: exported method VolumeServer.VolumeServerStatus should have comment or be unexported (golint)
  • Line 200: warning: exported method VolumeServer.VolumeServerLeave should have comment or be unexported (golint)
  • Line 210: warning: exported method VolumeServer.VolumeNeedleStatus should have comment or be unexported (golint)

• seaweedfs/weed/filesys/dirty_pages.go
  • Line 3: warning: exported type DirtyPages should have comment or be unexported (golint)

• seaweedfs/weed/util/chunk_cache/chunk_cache_on_disk_test.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: don't use underscores in Go names; type test_data should be testData (golint)

• seaweedfs/weed/command/backup.go
  • Line 19: warning: exported type BackupOptions should have comment or be unexported (golint)

• seaweedfs/weed/replication/sink/b2sink/b2_sink.go
  • Line 1: warning: don't use MixedCaps in package name; B2Sink should be b2sink (golint)
  • Line 16: warning: exported type B2Sink should have comment or be unexported (golint)
  • Line 28: warning: exported method B2Sink.GetName should have comment or be unexported (golint)
  • Line 32: warning: exported method B2Sink.GetSinkToDirectory should have comment or be unexported (golint)
  • Line 36: warning: exported method B2Sink.IsIncremental should have comment or be unexported (golint)
  • Line 40: warning: exported method B2Sink.Initialize should have comment or be unexported (golint)
  • Line 50: warning: exported method B2Sink.SetSourceFiler should have comment or be unexported (golint)
  • Line 67: warning: exported method B2Sink.DeleteEntry should have comment or be unexported (golint)
  • Line 86: warning: exported method B2Sink.CreateEntry should have comment or be unexported (golint)
  • Line 120: warning: exported method B2Sink.UpdateEntry should have comment or be unexported (golint)

• seaweedfs/weed/filer/redis/redis_store.go
  • Line 13: warning: exported type RedisStore should have comment or be unexported (golint)
  • Line 17: warning: exported method RedisStore.GetName should have comment or be unexported (golint)
  • Line 21: warning: exported method RedisStore.Initialize should have comment or be unexported (golint)

• seaweedfs/weed/filesys/meta_cache/id_mapper.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 9: warning: exported type UidGidMapper should have comment or be unexported (golint)
  • Line 14: warning: exported type IdMapper should have comment or be unexported (golint)
  • Line 19: warning: comment on exported function NewUidGidMapper should be of the form "NewUidGidMapper ..." (golint)
  • Line 39: warning: exported method UidGidMapper.LocalToFiler should have comment or be unexported (golint)
  • Line 42: warning: exported method UidGidMapper.FilerToLocal should have comment or be unexported (golint)
  • Line 46: warning: exported method IdMapper.LocalToFiler should have comment or be unexported (golint)
  • Line 53: warning: exported method IdMapper.FilerToLocal should have comment or be unexported (golint)

• seaweedfs/weed/filer/filerstore_wrapper.go
  • Line 19: warning: exported type VirtualFilerStore should have comment or be unexported (golint)
  • Line 28: warning: exported type FilerStoreWrapper should have comment or be unexported (golint)
  • Line 34: warning: exported function NewFilerStoreWrapper should have comment or be unexported (golint)
  • Line 45: warning: exported method FilerStoreWrapper.OnBucketCreation should have comment or be unexported (golint)
  • Line 55: warning: exported method FilerStoreWrapper.OnBucketDeletion should have comment or be unexported (golint)
  • Line 66: warning: exported method FilerStoreWrapper.AddPathSpecificStore should have comment or be unexported (golint)
  • Line 94: warning: exported method FilerStoreWrapper.GetName should have comment or be unexported (golint)
  • Line 98: warning: exported method FilerStoreWrapper.Initialize should have comment or be unexported (golint)
  • Line 102: warning: exported method FilerStoreWrapper.InsertEntry should have comment or be unexported (golint)
  • Line 123: warning: exported method FilerStoreWrapper.UpdateEntry should have comment or be unexported (golint)
  • Line 144: warning: exported method FilerStoreWrapper.FindEntry should have comment or be unexported (golint)
  • Line 164: warning: exported method FilerStoreWrapper.DeleteEntry should have comment or be unexported (golint)
  • Line 188: warning: exported method FilerStoreWrapper.DeleteOneEntry should have comment or be unexported (golint)
  • Line 208: warning: exported method FilerStoreWrapper.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 220: warning: exported method FilerStoreWrapper.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 236: warning: exported method FilerStoreWrapper.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 298: warning: exported method FilerStoreWrapper.BeginTransaction should have comment or be unexported (golint)
  • Line 302: warning: exported method FilerStoreWrapper.CommitTransaction should have comment or be unexported (golint)
  • Line 306: warning: exported method FilerStoreWrapper.RollbackTransaction should have comment or be unexported (golint)
  • Line 310: warning: exported method FilerStoreWrapper.Shutdown should have comment or be unexported (golint)
  • Line 314: warning: exported method FilerStoreWrapper.KvPut should have comment or be unexported (golint)
  • Line 317: warning: exported method FilerStoreWrapper.KvGet should have comment or be unexported (golint)
  • Line 320: warning: exported method FilerStoreWrapper.KvDelete should have comment or be unexported (golint)

• seaweedfs/weed/storage/backend/s3_backend/s3_sessions.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/command/s3.go
  • Line 25: warning: exported type S3Options should have comment or be unexported (golint)
  • Line 178: warning: don't use underscores in Go names; var s3ApiServer_err should be s3ApiServerErr (golint)

• seaweedfs/weed/s3api/stats.go
  • Line 11: warning: exported type StatusRecorder should have comment or be unexported (golint)
  • Line 16: warning: exported function NewStatusResponseWriter should have comment or be unexported (golint)
  • Line 20: warning: exported method StatusRecorder.WriteHeader should have comment or be unexported (golint)
  • Line 25: warning: exported method StatusRecorder.Flush should have comment or be unexported (golint)

• seaweedfs/weed/util/queue.go
  • Line 10: warning: exported type Queue should have comment or be unexported (golint)
  • Line 17: warning: exported function NewQueue should have comment or be unexported (golint)
  • Line 22: warning: exported method Queue.Len should have comment or be unexported (golint)
  • Line 28: warning: exported method Queue.Enqueue should have comment or be unexported (golint)
  • Line 44: warning: exported method Queue.Dequeue should have comment or be unexported (golint)

• seaweedfs/weed/filer/read_write.go
  • Line 15: warning: exported function ReadEntry should have comment or be unexported (golint)
  • Line 34: warning: exported function ReadContent should have comment or be unexported (golint)
  • Line 43: warning: exported function SaveAs should have comment or be unexported (golint)
  • Line 80: warning: exported function SaveInsideFiler should have comment or be unexported (golint)

• seaweedfs/weed/storage/erasure_coding/ec_volume_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/master_server_handlers_ui.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/server/volume_grpc_tier_download.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/util/compression.go
  • Line 16: warning: error var UnsupportedCompression should have name of the form ErrFoo (golint)
  • Line 16: warning: exported var UnsupportedCompression should have comment or be unexported (golint)
  • Line 19: warning: exported function MaybeGzipData should have comment or be unexported (golint)
  • Line 33: warning: exported function MaybeDecompressData should have comment or be unexported (golint)
  • Line 44: warning: exported function GzipData should have comment or be unexported (golint)
  • Line 58: warning: exported function DecompressData should have comment or be unexported (golint)
  • Line 81: warning: exported function IsGzippedContent should have comment or be unexported (golint)
  • Line 111: warning: exported function IsCompressableFileType should have comment or be unexported (golint)

• seaweedfs/weed/server/filer_ui/templates.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported var StatusTpl should have comment or be unexported (golint)

• seaweedfs/weed/filer/stream.go
  • Line 18: warning: exported function StreamContent should have comment or be unexported (golint)
  • Line 63: warning: exported function ReadAll should have comment or be unexported (golint)
  • Line 89: warning: comment on exported type ChunkStreamReader should be of the form "ChunkStreamReader ..." (with optional leading article) (golint)
  • Line 102: warning: exported function NewChunkStreamReaderFromFiler should have comment or be unexported (golint)
  • Line 116: warning: exported function NewChunkStreamReader should have comment or be unexported (golint)
  • Line 149: warning: exported method ChunkStreamReader.Seek should have comment or be unexported (golint)
  • Line 217: warning: exported method ChunkStreamReader.Close should have comment or be unexported (golint)
  • Line 221: warning: exported function VolumeId should have comment or be unexported (golint)

• seaweedfs/weed/filesys/unimplemented.go
  • Line 14: warning: exported method Dir.Access should have comment or be unexported (golint)
  • Line 20: warning: exported method File.Access should have comment or be unexported (golint)

• seaweedfs/weed/command/master.go
  • Line 29: warning: exported type MasterOptions should have comment or be unexported (golint)

• seaweedfs/weed/storage/volume_write.go
  • Line 13: warning: should not use dot imports (golint)
  • Line 16: warning: exported var ErrorNotFound should have comment or be unexported (golint)
  • Line 17: warning: exported var ErrorDeleted should have comment or be unexported (golint)
  • Line 18: warning: exported var ErrorSizeMismatch should have comment or be unexported (golint)
  • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 195: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 303: warning: exported method Volume.WriteNeedleBlob should have comment or be unexported (golint)

• seaweedfs/unmaintained/stress_filer_upload/bench_filer_upload/bench_filer_upload.go
  • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• seaweedfs/weed/messaging/msgclient/client.go
  • Line 17: warning: exported type MessagingClient should have comment or be unexported (golint)
  • Line 23: warning: exported function NewMessagingClient should have comment or be unexported (golint)

• seaweedfs/weed/query/json/seralize.go
  • Line 5: warning: exported function ToJson should have comment or be unexported (golint)

• seaweedfs/weed/server/volume_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported type VolumeServer should have comment or be unexported (golint)
  • Line 44: warning: exported function NewVolumeServer should have comment or be unexported (golint)
  • Line 115: warning: exported method VolumeServer.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/filer/leveldb/leveldb_store.go
  • Line 20: warning: exported const DIR_FILE_SEPARATOR should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type LevelDBStore should have comment or be unexported (golint)
  • Line 31: warning: exported method LevelDBStore.GetName should have comment or be unexported (golint)
  • Line 35: warning: exported method LevelDBStore.Initialize should have comment or be unexported (golint)
  • Line 65: warning: exported method LevelDBStore.BeginTransaction should have comment or be unexported (golint)
  • Line 68: warning: exported method LevelDBStore.CommitTransaction should have comment or be unexported (golint)
  • Line 71: warning: exported method LevelDBStore.RollbackTransaction should have comment or be unexported (golint)
  • Line 75: warning: exported method LevelDBStore.InsertEntry should have comment or be unexported (golint)
  • Line 98: warning: exported method LevelDBStore.UpdateEntry should have comment or be unexported (golint)
  • Line 103: warning: exported method LevelDBStore.FindEntry should have comment or be unexported (golint)
  • Line 128: warning: exported method LevelDBStore.DeleteEntry should have comment or be unexported (golint)
  • Line 139: warning: exported method LevelDBStore.DeleteFolderChildren should have comment or be unexported (golint)
  • Line 167: warning: exported method LevelDBStore.ListDirectoryEntries should have comment or be unexported (golint)
  • Line 171: warning: exported method LevelDBStore.ListDirectoryPrefixedEntries should have comment or be unexported (golint)
  • Line 241: warning: exported method LevelDBStore.Shutdown should have comment or be unexported (golint)

• seaweedfs/weed/util/bounded_tree/bounded_tree_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• seaweedfs/weed/storage/needle_map_leveldb.go
  • Line 17: warning: should not use dot imports (golint)
  • Line 20: warning: exported type LevelDbNeedleMap should have comment or be unexported (golint)
  • Line 26: warning: exported function NewLevelDbNeedleMap should have comment or be unexported (golint)
  • Line 91: warning: exported method LevelDbNeedleMap.Get should have comment or be unexported (golint)
  • Line 103: warning: exported method LevelDbNeedleMap.Put should have comment or be unexported (golint)
  • Line 131: warning: exported method LevelDbNeedleMap.Delete should have comment or be unexported (golint)
  • Line 146: warning: exported method LevelDbNeedleMap.Close should have comment or be unexported (golint)
  • Line 162: warning: exported method LevelDbNeedleMap.Destroy should have comment or be unexported (golint)

• seaweedfs/weed/topology/volume_layout_test.go
  • Line 36: warning: don't use underscores in Go names; var state_exist should be stateExist (golint)
  • Line 44: warning: don't use underscores in Go names; var state_no should be stateNo (golint)
  • Line 86: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)
  • Line 101: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)

• seaweedfs/weed/s3api/auth_credentials.go
  • Line 16: warning: exported type Action should have comment or be unexported (golint)
  • Line 18: warning: exported type Iam should have comment or be unexported (golint)
  • Line 22: warning: exported type IdentityAccessManagement should have comment or be unexported (golint)
  • Line 27: warning: exported type Identity should have comment or be unexported (golint)
  • Line 33: warning: exported type Credential should have comment or be unexported (golint)
  • Line 38: warning: exported function NewIdentityAccessManagement should have comment or be unexported (golint)
  • Line 135: warning: exported method IdentityAccessManagement.Auth should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (exit status 3)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!