gofmt88%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• rexray/libstorage/api/utils/config/config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/server/router/volume/volume_routes.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/utils_logging.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/types/types_model_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/s3fs/storage/s3fs_storage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/s3fs/executor/s3fs_executor.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/util/util_tls.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/server/services/services_task.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/utils_auth.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/rbd/storage/rbd_storage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/vfs/executor/vfs_executor.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/vbox/storage/vbox_storage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/dobs/storage/dobs_client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/utils_paths_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/mock/mock_driver.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/cli/cli_formatter.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/client/client_logging.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/cli/cmds_10_volume.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/context/context.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/server/handlers/handlers_errors.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/server/server_http.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/agent/csi/mod_csi_docker_legacy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/ebs/ebs_config_compat.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/cli/cmds_02_device.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/scaleio/storage/scaleio_storage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/registry/registry_integration.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/schema/schema_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/server/server_names.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/rbd/utils/utils.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/mock/tests/mock_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/imports/config/imports_config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/agent/csi/libstorage/csi_service_libstorage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/schema/schema.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/agent/csi/mod_csi_docker_bridge.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/types/types_config_compat.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/api/utils/utils_tls.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/efs/storage/efs_storage.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/cli/cli_formatter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• rexray/libstorage/drivers/storage/libstorage/libstorage_driver.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• rexray/libstorage/drivers/storage/gcepd/storage/gce_storage.go
  • Line 356: warning: cyclomatic complexity 17 of function (*driver).VolumeCreate() is high (> 15) (gocyclo)
  • Line 75: warning: cyclomatic complexity 16 of function (*driver).Init() is high (> 15) (gocyclo)

• rexray/cli/template/template_utils.go
  • Line 353: warning: cyclomatic complexity 74 of function checkCondition() is high (> 15) (gocyclo)
  • Line 82: warning: cyclomatic complexity 22 of function evaluateSubElem() is high (> 15) (gocyclo)
  • Line 601: warning: cyclomatic complexity 21 of function intersect() is high (> 15) (gocyclo)
  • Line 170: warning: cyclomatic complexity 20 of function compareGetFloat() is high (> 15) (gocyclo)
  • Line 555: warning: cyclomatic complexity 16 of function in() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/storage/fittedcloud/storage/fittedcloud_storage.go
  • Line 439: warning: cyclomatic complexity 18 of function (*driver).VolumeAttach() is high (> 15) (gocyclo)

• rexray/cli/cmds_10_volume.go
  • Line 27: warning: cyclomatic complexity 83 of function (*CLI).initVolumeCmds() is high (> 15) (gocyclo)

• rexray/agent/csi/libstorage/csi_service_libstorage.go
  • Line 539: warning: cyclomatic complexity 17 of function (*driver).NodeUnpublishVolume() is high (> 15) (gocyclo)

• rexray/cli/template/template_funcs.go
  • Line 13: warning: cyclomatic complexity 26 of function sortSeq() is high (> 15) (gocyclo)

• rexray/cli/cli_formatter.go
  • Line 26: warning: cyclomatic complexity 57 of function (*CLI).fmtOutput() is high (> 15) (gocyclo)

• rexray/libstorage/api/utils/utils_tls.go
  • Line 54: warning: cyclomatic complexity 37 of function ParseTLSConfig() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/storage/efs/storage/efs_storage.go
  • Line 511: warning: cyclomatic complexity 16 of function (*driver).VolumeRemove() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/storage/isilon/storage/isilon_storage.go
  • Line 334: warning: cyclomatic complexity 16 of function (*driver).VolumeAttach() is high (> 15) (gocyclo)
  • Line 528: warning: cyclomatic complexity 16 of function (*driver).getVolume() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/storage/s3fs/storage/s3fs_storage.go
  • Line 302: warning: cyclomatic complexity 26 of function (*driver).VolumeRemove() is high (> 15) (gocyclo)

• rexray/core/semver/semver.go
  • Line 21: warning: cyclomatic complexity 29 of function main() is high (> 15) (gocyclo)

• rexray/libstorage/client/client.go
  • Line 35: warning: cyclomatic complexity 20 of function New() is high (> 15) (gocyclo)

• rexray/libstorage/api/server/server.go
  • Line 65: warning: cyclomatic complexity 22 of function newServer() is high (> 15) (gocyclo)

• rexray/libstorage/api/client/client_http.go
  • Line 46: warning: cyclomatic complexity 33 of function (*client).httpDo() is high (> 15) (gocyclo)

• rexray/cli/cmds_60_token.go
  • Line 45: warning: cyclomatic complexity 17 of function (*CLI).initTokenCmds() is high (> 15) (gocyclo)

• rexray/libstorage/api/types/types_drivers_storage.go
  • Line 129: warning: cyclomatic complexity 17 of function ParseVolumeAttachmentTypes() is high (> 15) (gocyclo)

• rexray/util/util_tls.go
  • Line 29: warning: cyclomatic complexity 16 of function CreateSelfCert() is high (> 15) (gocyclo)

• rexray/agent/csi/libstorage/csi_service_libstorage_idemp.go
  • Line 156: warning: cyclomatic complexity 19 of function (*driver).IsNodePublished() is high (> 15) (gocyclo)

• rexray/libstorage/api/server/router/volume/volume_routes.go
  • Line 131: warning: cyclomatic complexity 21 of function handleVolAttachments() is high (> 15) (gocyclo)
  • Line 281: warning: cyclomatic complexity 19 of function (*router).volumeInspect() is high (> 15) (gocyclo)
  • Line 669: warning: cyclomatic complexity 16 of function (*router).volumeDetachAll() is high (> 15) (gocyclo)

• rexray/libstorage/cli/lss/lss.go
  • Line 57: warning: cyclomatic complexity 29 of function Run() is high (> 15) (gocyclo)

• rexray/libstorage/api/utils/filters/filters.go
  • Line 98: warning: cyclomatic complexity 34 of function compileFilter() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/integration/linux/linux.go
  • Line 175: warning: cyclomatic complexity 31 of function (*driver).Mount() is high (> 15) (gocyclo)
  • Line 340: warning: cyclomatic complexity 16 of function (*driver).Unmount() is high (> 15) (gocyclo)

• rexray/libstorage/drivers/storage/libstorage/libstorage_driver.go
  • Line 41: warning: cyclomatic complexity 18 of function (*driver).Init() is high (> 15) (gocyclo)

• rexray/agent/csi/mod_csi.go
  • Line 171: warning: cyclomatic complexity 35 of function (*mod).Start() is high (> 15) (gocyclo)

• rexray/libstorage/api/context/context_logger.go
  • Line 34: warning: cyclomatic complexity 16 of function ctxFieldsProcessValue() is high (> 15) (gocyclo)

• rexray/util/util_test.go
  • Line 134: warning: cyclomatic complexity 25 of function TestFindFlagArgs() is high (> 15) (gocyclo)

• rexray/rexray.go
  • Line 39: warning: cyclomatic complexity 27 of function main() is high (> 15) (gocyclo)
  • Line 224: warning: cyclomatic complexity 17 of function updateLogLevel() is high (> 15) (gocyclo)

golint99%

Golint is a linter for Go source code.

• rexray/libstorage/api/context/context.go
  • Line 27: warning: context.Context should be the first parameter of a function (golint)
  • Line 271: warning: context.Context should be the first parameter of a function (golint)

• rexray/libstorage/c/libstor-c/libstor-c_exported.go
  • Line 26: warning: don't use underscores in Go names; var client_id should be clientID (golint)
  • Line 67: warning: don't use underscores in Go names; var service_names should be serviceNames (golint)
  • Line 68: warning: don't use underscores in Go names; var volume_maps should be volumeMaps (golint)
  • Line 75: warning: don't use underscores in Go names; var volume_ids should be volumeIds (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• rexray/libstorage/drivers/storage/isilon/storage/isilon_storage.go
  • Line 277: warning: ineffectual assignment to err (ineffassign)
  • Line 348: warning: ineffectual assignment to vol (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words

• rexray/libstorage/api/types/types_context.go
  • Line 37: warning: "levle" is a misspelling of "level" (misspell)

• rexray/libstorage/drivers/storage/rbd/storage/rbd_storage.go
  • Line 141: warning: "detaild" is a misspelling of "detailed" (misspell)

• rexray/cli/cmds_10_volume.go
  • Line 292: warning: "avaialble" is a misspelling of "available" (misspell)
  • Line 366: warning: "avaialble" is a misspelling of "available" (misspell)
  • Line 504: warning: "avaialble" is a misspelling of "available" (misspell)

• rexray/libstorage/api/context/context_test.go
  • Line 28: warning: "unkown" is a misspelling of "unknown" (misspell)

• rexray/libstorage/api/types/types_errors.go
  • Line 30: warning: "avaialble" is a misspelling of "available" (misspell)

• rexray/libstorage/drivers/storage/efs/storage/efs_storage.go
  • Line 475: warning: "retreive" is a misspelling of "retrieve" (misspell)
  • Line 499: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 571: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 618: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/gcepd/storage/gce_storage.go
  • Line 981: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/isilon/executor/isilon_executor.go
  • Line 62: warning: "addressess" is a misspelling of "addresses" (misspell)

• rexray/libstorage/api/tests/tests_suite.go
  • Line 306: warning: "nto" is a misspelling of "not" (misspell)

• rexray/libstorage/api/utils/utils_paths_test.go
  • Line 421: warning: "nto" is a misspelling of "not" (misspell)

• rexray/cli/cli.go
  • Line 390: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 407: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/fittedcloud/storage/fittedcloud_storage.go
  • Line 975: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/ebs/storage/ebs_storage.go
  • Line 1279: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/cinder/storage/cinder_storage.go
  • Line 735: warning: "occured" is a misspelling of "occurred" (misspell)

• rexray/libstorage/drivers/storage/dobs/storage/dobs_storage.go
  • Line 537: warning: "occured" is a misspelling of "occurred" (misspell)