Report for github.com/dominikh/go-tools
A+ Excellent! Found 97 issues across 167 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo71%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-tools/quickfix/lint.go
- Line 304: warning: cyclomatic complexity 26 of function CheckIfElseToSwitch() is high (> 15) (gocyclo)
- Line 620: warning: cyclomatic complexity 21 of function CheckExplicitEmbeddedSelector() is high (> 15) (gocyclo)
- Line 466: warning: cyclomatic complexity 16 of function CheckMathPow() is high (> 15) (gocyclo)
- Line 238: warning: cyclomatic complexity 16 of function CheckTaglessSwitch() is high (> 15) (gocyclo)
-
-
go-tools/internal/gosmith/expr.go
- Line 322: warning: cyclomatic complexity 32 of function (*Smith).exprCallBuiltin() is high (> 15) (gocyclo)
- Line 53: warning: cyclomatic complexity 17 of function (*Smith).nonconstRvalue() is high (> 15) (gocyclo)
-
-
go-tools/unused/typemap/identical.go
- Line 10: warning: cyclomatic complexity 46 of function identical0() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/sanity.go
- Line 90: warning: cyclomatic complexity 67 of function (*sanity).checkInstr() is high (> 15) (gocyclo)
- Line 275: warning: cyclomatic complexity 37 of function (*sanity).checkBlock() is high (> 15) (gocyclo)
- Line 429: warning: cyclomatic complexity 25 of function (*sanity).checkFunction() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/dom.go
- Line 175: warning: cyclomatic complexity 22 of function buildPostDomTree() is high (> 15) (gocyclo)
- Line 72: warning: cyclomatic complexity 22 of function buildDomTree() is high (> 15) (gocyclo)
- Line 314: warning: cyclomatic complexity 17 of function sanityCheckDomTree() is high (> 15) (gocyclo)
-
-
go-tools/go/callgraph/rta/rta.go
- Line 345: warning: cyclomatic complexity 30 of function (*rta).addRuntimeType() is high (> 15) (gocyclo)
-
-
go-tools/internal/cmd/ast-to-pattern/parse.go
- Line 65: warning: cyclomatic complexity 17 of function parseDetectingNode() is high (> 15) (gocyclo)
-
-
go-tools/analysis/facts/typedness/typedness.go
- Line 69: warning: cyclomatic complexity 46 of function impl() is high (> 15) (gocyclo)
-
-
go-tools/stylecheck/names.go
- Line 28: warning: cyclomatic complexity 57 of function CheckNames() is high (> 15) (gocyclo)
- Line 199: warning: cyclomatic complexity 20 of function lintName() is high (> 15) (gocyclo)
-
-
go-tools/stylecheck/lint.go
- Line 360: warning: cyclomatic complexity 19 of function CheckErrorStrings() is high (> 15) (gocyclo)
- Line 679: warning: cyclomatic complexity 18 of function CheckInvisibleCharacters() is high (> 15) (gocyclo)
- Line 129: warning: cyclomatic complexity 17 of function CheckBlankImports() is high (> 15) (gocyclo)
- Line 820: warning: cyclomatic complexity 16 of function CheckExportedTypeDocs() is high (> 15) (gocyclo)
-
-
go-tools/unused/unused_test.go
- Line 29: warning: cyclomatic complexity 26 of function check() is high (> 15) (gocyclo)
-
-
go-tools/analysis/facts/nilness/nilness.go
- Line 97: warning: cyclomatic complexity 48 of function impl() is high (> 15) (gocyclo)
-
-
go-tools/go/buildid/buildid.go
- Line 28: warning: cyclomatic complexity 18 of function ReadFile() is high (> 15) (gocyclo)
-
-
go-tools/cmd/keyify/keyify.go
- Line 286: warning: cyclomatic complexity 26 of function copyExpr() is high (> 15) (gocyclo)
- Line 51: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)
-
-
go-tools/internal/cache/cache.go
- Line 161: warning: cyclomatic complexity 24 of function (*Cache).get() is high (> 15) (gocyclo)
-
-
go-tools/analysis/facts/deprecated.go
- Line 31: warning: cyclomatic complexity 28 of function deprecated() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/builder.go
- Line 508: warning: cyclomatic complexity 49 of function (*builder).expr0() is high (> 15) (gocyclo)
- Line 2049: warning: cyclomatic complexity 47 of function (*builder).stmt() is high (> 15) (gocyclo)
- Line 1547: warning: cyclomatic complexity 26 of function (*builder).selectStmt() is high (> 15) (gocyclo)
- Line 1054: warning: cyclomatic complexity 23 of function (*builder).compLit() is high (> 15) (gocyclo)
- Line 1392: warning: cyclomatic complexity 21 of function (*builder).typeSwitchStmt() is high (> 15) (gocyclo)
- Line 1975: warning: cyclomatic complexity 17 of function (*builder).rangeStmt() is high (> 15) (gocyclo)
- Line 2361: warning: cyclomatic complexity 17 of function (*Package).build() is high (> 15) (gocyclo)
- Line 310: warning: cyclomatic complexity 17 of function (*builder).addr() is high (> 15) (gocyclo)
- Line 2235: warning: cyclomatic complexity 16 of function (*builder).buildFunction() is high (> 15) (gocyclo)
- Line 1180: warning: cyclomatic complexity 16 of function (*builder).switchStmt() is high (> 15) (gocyclo)
-
-
go-tools/lintcmd/runner/runner.go
- Line 952: warning: cyclomatic complexity 21 of function (*subrunner).runAnalyzers() is high (> 15) (gocyclo)
- Line 1105: warning: cyclomatic complexity 19 of function (*Runner).Run() is high (> 15) (gocyclo)
- Line 791: warning: cyclomatic complexity 19 of function (*analyzerRunner).do() is high (> 15) (gocyclo)
- Line 472: warning: cyclomatic complexity 16 of function (*subrunner).do() is high (> 15) (gocyclo)
-
-
go-tools/internal/gosmith/context.go
- Line 388: warning: cyclomatic complexity 20 of function (*Smith).materializeVar() is high (> 15) (gocyclo)
-
-
go-tools/unused/typemap/map_test.go
- Line 42: warning: cyclomatic complexity 32 of function TestMap() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/lift.go
- Line 168: warning: cyclomatic complexity 40 of function lift() is high (> 15) (gocyclo)
- Line 923: warning: cyclomatic complexity 37 of function rename() is high (> 15) (gocyclo)
- Line 733: warning: cyclomatic complexity 30 of function liftAlloc() is high (> 15) (gocyclo)
-
-
go-tools/go/callgraph/cha/cha.go
- Line 38: warning: cyclomatic complexity 16 of function CallGraph() is high (> 15) (gocyclo)
-
-
go-tools/internal/renameio/renameio_test.go
- Line 26: warning: cyclomatic complexity 22 of function TestConcurrentReadsAndWrites() is high (> 15) (gocyclo)
-
-
go-tools/internal/cache/cache_test.go
- Line 22: warning: cyclomatic complexity 18 of function TestBasic() is high (> 15) (gocyclo)
-
-
go-tools/lintcmd/lint.go
- Line 81: warning: cyclomatic complexity 28 of function (*linter).Lint() is high (> 15) (gocyclo)
-
-
go-tools/staticcheck/lint.go
- Line 459: warning: cyclomatic complexity 97 of function checkPrintfCallImpl() is high (> 15) (gocyclo)
- Line 2379: warning: cyclomatic complexity 49 of function CheckIneffectiveAppend() is high (> 15) (gocyclo)
- Line 1940: warning: cyclomatic complexity 42 of function CheckExtremeComparison() is high (> 15) (gocyclo)
- Line 1751: warning: cyclomatic complexity 37 of function CheckUnreadVariableValues() is high (> 15) (gocyclo)
- Line 2208: warning: cyclomatic complexity 29 of function CheckIneffectiveLoop() is high (> 15) (gocyclo)
- Line 4607: warning: cyclomatic complexity 29 of function CheckIneffectiveFieldAssignments() is high (> 15) (gocyclo)
- Line 4444: warning: cyclomatic complexity 28 of function CheckTypedNilInterface() is high (> 15) (gocyclo)
- Line 3090: warning: cyclomatic complexity 27 of function CheckDeprecated() is high (> 15) (gocyclo)
- Line 4195: warning: cyclomatic complexity 24 of function findSliceLenChecks() is high (> 15) (gocyclo)
- Line 2064: warning: cyclomatic complexity 23 of function CheckLoopCondition() is high (> 15) (gocyclo)
- Line 3559: warning: cyclomatic complexity 22 of function CheckMissingEnumTypesInDeclaration() is high (> 15) (gocyclo)
- Line 2919: warning: cyclomatic complexity 22 of function CheckSillyBitwiseOps() is high (> 15) (gocyclo)
- Line 1338: warning: cyclomatic complexity 21 of function CheckLhsRhsIdentical() is high (> 15) (gocyclo)
- Line 3309: warning: cyclomatic complexity 21 of function CheckWriterBufferModified() is high (> 15) (gocyclo)
- Line 1408: warning: cyclomatic complexity 20 of function CheckScopedBreak() is high (> 15) (gocyclo)
- Line 2132: warning: cyclomatic complexity 20 of function CheckArgOverwritten() is high (> 15) (gocyclo)
- Line 4010: warning: cyclomatic complexity 19 of function CheckMaybeNil() is high (> 15) (gocyclo)
- Line 2569: warning: cyclomatic complexity 19 of function CheckConcurrentTesting() is high (> 15) (gocyclo)
- Line 934: warning: cyclomatic complexity 19 of function CheckUntrappableSignal() is high (> 15) (gocyclo)
- Line 3862: warning: cyclomatic complexity 19 of function checkJSONTag() is high (> 15) (gocyclo)
- Line 1506: warning: cyclomatic complexity 19 of function CheckEarlyDefer() is high (> 15) (gocyclo)
- Line 1874: warning: cyclomatic complexity 18 of function CheckPredeterminedBooleanExprs() is high (> 15) (gocyclo)
- Line 3218: warning: cyclomatic complexity 17 of function checkCalls() is high (> 15) (gocyclo)
- Line 1584: warning: cyclomatic complexity 17 of function CheckEmptyCriticalSection() is high (> 15) (gocyclo)
- Line 1210: warning: cyclomatic complexity 17 of function CheckTestMainExit() is high (> 15) (gocyclo)
- Line 3635: warning: cyclomatic complexity 16 of function CheckTimerResetReturnValue() is high (> 15) (gocyclo)
- Line 3405: warning: cyclomatic complexity 16 of function CheckMapBytesKey() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/func.go
- Line 825: warning: cyclomatic complexity 27 of function WriteFunction() is high (> 15) (gocyclo)
-
-
go-tools/analysis/facts/purity.go
- Line 58: warning: cyclomatic complexity 35 of function purity() is high (> 15) (gocyclo)
-
-
go-tools/lintcmd/cmd.go
- Line 196: warning: cyclomatic complexity 41 of function (*Command).Run() is high (> 15) (gocyclo)
-
-
go-tools/unused/unused.go
- Line 834: warning: cyclomatic complexity 100 of function (*graph).entry() is high (> 15) (gocyclo)
- Line 1459: warning: cyclomatic complexity 73 of function (*graph).instructions() is high (> 15) (gocyclo)
- Line 1276: warning: cyclomatic complexity 41 of function (*graph).typ() is high (> 15) (gocyclo)
- Line 731: warning: cyclomatic complexity 28 of function isIrrelevant() is high (> 15) (gocyclo)
- Line 561: warning: cyclomatic complexity 19 of function results() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/source_test.go
- Line 32: warning: cyclomatic complexity 22 of function TestObjValueLookup() is high (> 15) (gocyclo)
- Line 232: warning: cyclomatic complexity 21 of function testValueForExpr() is high (> 15) (gocyclo)
-
-
go-tools/simple/lint.go
- Line 930: warning: cyclomatic complexity 67 of function CheckTrim() is high (> 15) (gocyclo)
- Line 506: warning: cyclomatic complexity 39 of function CheckRedundantNilCheckWithLen() is high (> 15) (gocyclo)
- Line 811: warning: cyclomatic complexity 28 of function CheckSimplerStructConversion() is high (> 15) (gocyclo)
- Line 1248: warning: cyclomatic complexity 23 of function CheckDeclareAssign() is high (> 15) (gocyclo)
- Line 196: warning: cyclomatic complexity 16 of function CheckStringsContains() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/methods.go
- Line 154: warning: cyclomatic complexity 25 of function (*Program).needMethods() is high (> 15) (gocyclo)
-
-
go-tools/analysis/code/code.go
- Line 205: warning: cyclomatic complexity 39 of function MayHaveSideEffects() is high (> 15) (gocyclo)
-
-
go-tools/internal/cmd/irdump/main.go
- Line 54: warning: cyclomatic complexity 16 of function doMain() is high (> 15) (gocyclo)
-
-
go-tools/internal/go/gcimporter/gcimporter.go
- Line 91: warning: cyclomatic complexity 18 of function Import() is high (> 15) (gocyclo)
-
-
go-tools/internal/go/gcimporter/gcimporter_test.go
- Line 192: warning: cyclomatic complexity 18 of function TestVersionHandling() is high (> 15) (gocyclo)
-
-
go-tools/internal/gosmith/type.go
- Line 231: warning: cyclomatic complexity 40 of function (*Smith).satisfiesTrait() is high (> 15) (gocyclo)
- Line 136: warning: cyclomatic complexity 18 of function (*Smith).typeLit() is high (> 15) (gocyclo)
-
-
go-tools/unused/typemap/map.go
- Line 248: warning: cyclomatic complexity 16 of function (Hasher).hashFor() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/html.go
- Line 819: warning: cyclomatic complexity 24 of function valueLongHTML() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/exits.go
- Line 7: warning: cyclomatic complexity 48 of function (*builder).buildExits() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/builder_test.go
- Line 31: warning: cyclomatic complexity 29 of function TestBuildPackage() is high (> 15) (gocyclo)
-
-
go-tools/analysis/report/report.go
- Line 78: warning: cyclomatic complexity 22 of function shortRange() is high (> 15) (gocyclo)
-
-
go-tools/go/buildid/note.go
- Line 78: warning: cyclomatic complexity 21 of function readELF() is high (> 15) (gocyclo)
-
-
go-tools/go/ir/irutil/terminates.go
- Line 12: warning: cyclomatic complexity 17 of function Terminates() is high (> 15) (gocyclo)
-
-
go-tools/internal/sharedcheck/lint.go
- Line 94: warning: cyclomatic complexity 28 of function RedundantTypeInDeclarationChecker() is high (> 15) (gocyclo)
-
-
go-tools/internal/gosmith/stmt.go
- Line 79: warning: cyclomatic complexity 30 of function (*Smith).stmtFor() is high (> 15) (gocyclo)
-
-
go-tools/staticcheck/structtag.go
- Line 8: warning: cyclomatic complexity 19 of function parseStructTag() is high (> 15) (gocyclo)
golint55%
Golint is a linter for Go source code.
-
-
go-tools/internal/gosmith/context.go
- Line 21: warning: exported type Smith should have comment or be unexported (golint)
- Line 55: warning: exported const NPackages should have comment (or a comment on this block) or be unexported (golint)
- Line 71: warning: exported type Package should have comment or be unexported (golint)
- Line 83: warning: exported type Block should have comment or be unexported (golint)
- Line 98: warning: exported type Func should have comment or be unexported (golint)
- Line 104: warning: exported type Var should have comment or be unexported (golint)
- Line 111: warning: exported type Const should have comment or be unexported (golint)
- Line 167: warning: exported function F should have comment or be unexported (golint)
-
-
go-tools/go/ir/html.go
- Line 143: warning: exported type HTMLWriter should have comment or be unexported (golint)
- Line 149: warning: exported function NewHTMLWriter should have comment or be unexported (golint)
- Line 746: warning: exported method HTMLWriter.Close should have comment or be unexported (golint)
- Line 787: warning: exported method HTMLWriter.Printf should have comment or be unexported (golint)
- Line 793: warning: exported method HTMLWriter.WriteString should have comment or be unexported (golint)
-
-
go-tools/analysis/code/visit.go
- Line 15: warning: exported function Preorder should have comment or be unexported (golint)
- Line 19: warning: exported function PreorderStack should have comment or be unexported (golint)
- Line 28: warning: exported function Match should have comment or be unexported (golint)
- Line 37: warning: exported function MatchAndEdit should have comment or be unexported (golint)
-
-
go-tools/knowledge/deprecated.go
- Line 4: warning: exported const DeprecatedNeverUse should have comment (or a comment on this block) or be unexported (golint)
- Line 8: warning: exported type Deprecation should have comment or be unexported (golint)
- Line 16: warning: exported var StdlibDeprecations should have comment or be unexported (golint)
-
-
go-tools/quickfix/doc.go
- Line 5: warning: exported var Docs should have comment or be unexported (golint)
-
-
go-tools/pattern/lexer.go
- Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-tools/stylecheck/doc.go
- Line 5: warning: exported var Docs should have comment or be unexported (golint)
-
-
go-tools/go/ir/const.go
- Line 77: warning: exported method Const.RelString should have comment or be unexported (golint)
-
-
go-tools/staticcheck/lint.go
- Line 934: warning: exported function CheckUntrappableSignal should have comment or be unexported (golint)
- Line 1004: warning: exported function CheckTemplate should have comment or be unexported (golint)
- Line 1052: warning: exported function CheckTimeSleepConstant should have comment or be unexported (golint)
- Line 1089: warning: exported function CheckWaitgroupAdd should have comment or be unexported (golint)
- Line 1100: warning: exported function CheckInfiniteEmptyLoop should have comment or be unexported (golint)
- Line 1144: warning: exported function CheckDeferInInfiniteLoop should have comment or be unexported (golint)
- Line 1186: warning: exported function CheckDubiousDeferInChannelRangeLoop should have comment or be unexported (golint)
- Line 1210: warning: exported function CheckTestMainExit should have comment or be unexported (golint)
- Line 1292: warning: exported function CheckExec should have comment or be unexported (golint)
- Line 1312: warning: exported function CheckLoopEmptyDefault should have comment or be unexported (golint)
- Line 1338: warning: exported function CheckLhsRhsIdentical should have comment or be unexported (golint)
- Line 1408: warning: exported function CheckScopedBreak should have comment or be unexported (golint)
- Line 1467: warning: exported function CheckUnsafePrintf should have comment or be unexported (golint)
- Line 1506: warning: exported function CheckEarlyDefer should have comment or be unexported (golint)
- Line 1584: warning: exported function CheckEmptyCriticalSection should have comment or be unexported (golint)
- Line 1657: warning: exported function CheckIneffectiveCopy should have comment or be unexported (golint)
- Line 1671: warning: exported function CheckCanonicalHeaderKey should have comment or be unexported (golint)
- Line 1729: warning: exported function CheckBenchmarkN should have comment or be unexported (golint)
- Line 1751: warning: exported function CheckUnreadVariableValues should have comment or be unexported (golint)
- Line 1874: warning: exported function CheckPredeterminedBooleanExprs should have comment or be unexported (golint)
- Line 1918: warning: exported function CheckNilMaps should have comment or be unexported (golint)
- Line 1940: warning: exported function CheckExtremeComparison should have comment or be unexported (golint)
- Line 2064: warning: exported function CheckLoopCondition should have comment or be unexported (golint)
- Line 2132: warning: exported function CheckArgOverwritten should have comment or be unexported (golint)
- Line 2208: warning: exported function CheckIneffectiveLoop should have comment or be unexported (golint)
- Line 2325: warning: exported function CheckNilContext should have comment or be unexported (golint)
- Line 2368: warning: exported function CheckSeeker should have comment or be unexported (golint)
- Line 2379: warning: exported function CheckIneffectiveAppend should have comment or be unexported (golint)
- Line 2569: warning: exported function CheckConcurrentTesting should have comment or be unexported (golint)
- Line 2644: warning: exported function CheckCyclicFinalizer should have comment or be unexported (golint)
- Line 2709: warning: exported function CheckDeferLock should have comment or be unexported (golint)
- Line 2749: warning: exported function CheckNaNComparison should have comment or be unexported (golint)
- Line 2773: warning: exported function CheckInfiniteRecursion should have comment or be unexported (golint)
- Line 2834: warning: exported function CheckLeakyTimeTick should have comment or be unexported (golint)
- Line 2857: warning: exported function CheckDoubleNegation should have comment or be unexported (golint)
- Line 2869: warning: exported function CheckRepeatedIfElse should have comment or be unexported (golint)
- Line 2919: warning: exported function CheckSillyBitwiseOps should have comment or be unexported (golint)
- Line 3005: warning: exported function CheckNonOctalFileMode should have comment or be unexported (golint)
- Line 3036: warning: exported function CheckPureFunctions should have comment or be unexported (golint)
- Line 3090: warning: exported function CheckDeprecated should have comment or be unexported (golint)
- Line 3309: warning: exported function CheckWriterBufferModified should have comment or be unexported (golint)
- Line 3372: warning: exported function CheckEmptyBranch should have comment or be unexported (golint)
- Line 3405: warning: exported function CheckMapBytesKey should have comment or be unexported (golint)
- Line 3457: warning: exported function CheckRangeStringRunes should have comment or be unexported (golint)
- Line 3461: warning: exported function CheckSelfAssignment should have comment or be unexported (golint)
- Line 3507: warning: exported function CheckDuplicateBuildConstraints should have comment or be unexported (golint)
- Line 3527: warning: exported function CheckSillyRegexp should have comment or be unexported (golint)
- Line 3559: warning: exported function CheckMissingEnumTypesInDeclaration should have comment or be unexported (golint)
- Line 3635: warning: exported function CheckTimerResetReturnValue should have comment or be unexported (golint)
- Line 3707: warning: exported function CheckToLowerToUpperComparison should have comment or be unexported (golint)
- Line 3728: warning: exported function CheckUnreachableTypeCases should have comment or be unexported (golint)
- Line 3802: warning: exported function CheckSingleArgAppend should have comment or be unexported (golint)
- Line 3814: warning: exported function CheckStructTags should have comment or be unexported (golint)
- Line 3941: warning: exported function CheckImpossibleTypeAssertion should have comment or be unexported (golint)
- Line 4010: warning: exported function CheckMaybeNil should have comment or be unexported (golint)
- Line 4129: warning: exported function CheckAddressIsNil should have comment or be unexported (golint)
- Line 4149: warning: exported function CheckStaticBitShift should have comment or be unexported (golint)
- Line 4436: warning: exported function CheckEvenSliceLength should have comment or be unexported (golint)
- Line 4444: warning: exported function CheckTypedNilInterface should have comment or be unexported (golint)
- Line 4560: warning: exported function CheckBuiltinZeroComparison should have comment or be unexported (golint)
- Line 4577: warning: exported function CheckIntegerDivisionEqualsZero should have comment or be unexported (golint)
- Line 4607: warning: exported function CheckIneffectiveFieldAssignments should have comment or be unexported (golint)
- Line 4729: warning: exported function CheckNegativeZeroFloat should have comment or be unexported (golint)
- Line 4763: warning: exported function CheckIneffectiveURLQueryModification should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/typedness/typedness.go
- Line 27: warning: exported type Result should have comment or be unexported (golint)
- Line 31: warning: exported var Analysis should have comment or be unexported (golint)
- Line 146: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go-tools/analysis/facts/deprecated.go
- Line 13: warning: exported type IsDeprecated should have comment or be unexported (golint)
- Line 15: warning: exported method IsDeprecated.AFact should have comment or be unexported (golint)
- Line 18: warning: exported type DeprecatedResult should have comment or be unexported (golint)
- Line 23: warning: exported var Deprecated should have comment or be unexported (golint)
-
-
go-tools/internal/cache/cache.go
- Line 76: warning: exported method Cache.SetSalt should have comment or be unexported (golint)
- Line 154: warning: exported type Entry should have comment or be unexported (golint)
-
-
go-tools/pattern/parser.go
- Line 10: warning: exported type Pattern should have comment or be unexported (golint)
- Line 17: warning: exported function MustParse should have comment or be unexported (golint)
- Line 151: warning: exported type Parser should have comment or be unexported (golint)
- Line 161: warning: exported method Parser.Parse should have comment or be unexported (golint)
-
-
go-tools/lintcmd/lint.go
- Line 45: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go-tools/go/ir/ssa.go
- Line 21: warning: exported type ID should have comment or be unexported (golint)
- Line 282: warning: exported type Synthetic should have comment or be unexported (golint)
- Line 285: warning: exported const SyntheticLoadedFromExportData should have comment (or a comment on this block) or be unexported (golint)
- Line 368: warning: exported type NoReturn should have comment or be unexported (golint)
- Line 371: warning: exported const Returns should have comment (or a comment on this block) or be unexported (golint)
- Line 1196: warning: exported type ConstantSwitch should have comment or be unexported (golint)
- Line 1204: warning: exported type TypeSwitch should have comment or be unexported (golint)
- Line 1582: warning: exported method Call.Common should have comment or be unexported (golint)
- Line 1583: warning: exported method Defer.Common should have comment or be unexported (golint)
- Line 1584: warning: exported method Go.Common should have comment or be unexported (golint)
- Line 1586: warning: exported method Call.Value should have comment or be unexported (golint)
- Line 1587: warning: exported method Defer.Value should have comment or be unexported (golint)
- Line 1588: warning: exported method Go.Value should have comment or be unexported (golint)
- Line 1590: warning: exported method Builtin.Type should have comment or be unexported (golint)
- Line 1591: warning: exported method Builtin.Name should have comment or be unexported (golint)
- Line 1592: warning: exported method Builtin.Referrers should have comment or be unexported (golint)
- Line 1593: warning: exported method Builtin.Pos should have comment or be unexported (golint)
- Line 1594: warning: exported method Builtin.Object should have comment or be unexported (golint)
- Line 1595: warning: exported method Builtin.Parent should have comment or be unexported (golint)
- Line 1597: warning: exported method FreeVar.Type should have comment or be unexported (golint)
- Line 1598: warning: exported method FreeVar.Name should have comment or be unexported (golint)
- Line 1599: warning: exported method FreeVar.Referrers should have comment or be unexported (golint)
- Line 1600: warning: exported method FreeVar.Parent should have comment or be unexported (golint)
- Line 1602: warning: exported method Global.Type should have comment or be unexported (golint)
- Line 1603: warning: exported method Global.Name should have comment or be unexported (golint)
- Line 1604: warning: exported method Global.Parent should have comment or be unexported (golint)
- Line 1605: warning: exported method Global.Referrers should have comment or be unexported (golint)
- Line 1606: warning: exported method Global.Token should have comment or be unexported (golint)
- Line 1607: warning: exported method Global.Object should have comment or be unexported (golint)
- Line 1609: warning: exported method Global.Package should have comment or be unexported (golint)
- Line 1610: warning: exported method Global.RelString should have comment or be unexported (golint)
- Line 1612: warning: exported method Function.Name should have comment or be unexported (golint)
- Line 1612: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1613: warning: exported method Function.Type should have comment or be unexported (golint)
- Line 1613: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1614: warning: exported method Function.Token should have comment or be unexported (golint)
- Line 1614: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1615: warning: exported method Function.Object should have comment or be unexported (golint)
- Line 1615: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1616: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1617: warning: exported method Function.Package should have comment or be unexported (golint)
- Line 1617: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1618: warning: exported method Function.Parent should have comment or be unexported (golint)
- Line 1618: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1619: warning: exported method Function.Referrers should have comment or be unexported (golint)
- Line 1619: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1626: warning: exported method Parameter.Object should have comment or be unexported (golint)
- Line 1628: warning: exported method Alloc.Type should have comment or be unexported (golint)
- Line 1629: warning: exported method Alloc.Referrers should have comment or be unexported (golint)
- Line 1641: warning: exported method Type.Name should have comment or be unexported (golint)
- Line 1642: warning: exported method Type.Pos should have comment or be unexported (golint)
- Line 1643: warning: exported method Type.Type should have comment or be unexported (golint)
- Line 1644: warning: exported method Type.Token should have comment or be unexported (golint)
- Line 1645: warning: exported method Type.Object should have comment or be unexported (golint)
- Line 1647: warning: exported method Type.Package should have comment or be unexported (golint)
- Line 1648: warning: exported method Type.RelString should have comment or be unexported (golint)
- Line 1650: warning: exported method NamedConst.Name should have comment or be unexported (golint)
- Line 1651: warning: exported method NamedConst.Pos should have comment or be unexported (golint)
- Line 1653: warning: exported method NamedConst.Type should have comment or be unexported (golint)
- Line 1654: warning: exported method NamedConst.Token should have comment or be unexported (golint)
- Line 1655: warning: exported method NamedConst.Object should have comment or be unexported (golint)
- Line 1656: warning: exported method NamedConst.Package should have comment or be unexported (golint)
- Line 1657: warning: exported method NamedConst.RelString should have comment or be unexported (golint)
- Line 1691: warning: exported method DebugRef.Pos should have comment or be unexported (golint)
- Line 1695: warning: exported method Alloc.Operands should have comment or be unexported (golint)
- Line 1699: warning: exported method BinOp.Operands should have comment or be unexported (golint)
- Line 1703: warning: exported method CallCommon.Operands should have comment or be unexported (golint)
- Line 1711: warning: exported method Go.Operands should have comment or be unexported (golint)
- Line 1715: warning: exported method Call.Operands should have comment or be unexported (golint)
- Line 1719: warning: exported method Defer.Operands should have comment or be unexported (golint)
- Line 1723: warning: exported method ChangeInterface.Operands should have comment or be unexported (golint)
- Line 1727: warning: exported method ChangeType.Operands should have comment or be unexported (golint)
- Line 1731: warning: exported method Convert.Operands should have comment or be unexported (golint)
- Line 1735: warning: exported method DebugRef.Operands should have comment or be unexported (golint)
- Line 1739: warning: exported method Extract.Operands should have comment or be unexported (golint)
- Line 1743: warning: exported method Field.Operands should have comment or be unexported (golint)
- Line 1747: warning: exported method FieldAddr.Operands should have comment or be unexported (golint)
- Line 1751: warning: exported method If.Operands should have comment or be unexported (golint)
- Line 1755: warning: exported method ConstantSwitch.Operands should have comment or be unexported (golint)
- Line 1763: warning: exported method TypeSwitch.Operands should have comment or be unexported (golint)
- Line 1768: warning: exported method Index.Operands should have comment or be unexported (golint)
- Line 1772: warning: exported method IndexAddr.Operands should have comment or be unexported (golint)
- Line 1776: warning: exported method Jump.Operands should have comment or be unexported (golint)
- Line 1780: warning: exported method Unreachable.Operands should have comment or be unexported (golint)
- Line 1784: warning: exported method MapLookup.Operands should have comment or be unexported (golint)
- Line 1788: warning: exported method StringLookup.Operands should have comment or be unexported (golint)
- Line 1792: warning: exported method MakeChan.Operands should have comment or be unexported (golint)
- Line 1796: warning: exported method MakeClosure.Operands should have comment or be unexported (golint)
- Line 1804: warning: exported method MakeInterface.Operands should have comment or be unexported (golint)
- Line 1808: warning: exported method MakeMap.Operands should have comment or be unexported (golint)
- Line 1812: warning: exported method MakeSlice.Operands should have comment or be unexported (golint)
- Line 1816: warning: exported method MapUpdate.Operands should have comment or be unexported (golint)
- Line 1820: warning: exported method Next.Operands should have comment or be unexported (golint)
- Line 1824: warning: exported method Panic.Operands should have comment or be unexported (golint)
- Line 1828: warning: exported method Sigma.Operands should have comment or be unexported (golint)
- Line 1832: warning: exported method Phi.Operands should have comment or be unexported (golint)
- Line 1839: warning: exported method Range.Operands should have comment or be unexported (golint)
- Line 1843: warning: exported method Return.Operands should have comment or be unexported (golint)
- Line 1850: warning: exported method RunDefers.Operands should have comment or be unexported (golint)
- Line 1854: warning: exported method Select.Operands should have comment or be unexported (golint)
- Line 1861: warning: exported method Send.Operands should have comment or be unexported (golint)
- Line 1865: warning: exported method Recv.Operands should have comment or be unexported (golint)
- Line 1869: warning: exported method Slice.Operands should have comment or be unexported (golint)
- Line 1873: warning: exported method Store.Operands should have comment or be unexported (golint)
- Line 1877: warning: exported method BlankStore.Operands should have comment or be unexported (golint)
- Line 1881: warning: exported method TypeAssert.Operands should have comment or be unexported (golint)
- Line 1885: warning: exported method UnOp.Operands should have comment or be unexported (golint)
- Line 1889: warning: exported method Load.Operands should have comment or be unexported (golint)
- Line 1893: warning: comment on exported method Builtin.Operands should be of the form "Operands ..." (golint)
- Line 1895: warning: exported method FreeVar.Operands should have comment or be unexported (golint)
- Line 1896: warning: exported method Const.Operands should have comment or be unexported (golint)
- Line 1897: warning: exported method Function.Operands should have comment or be unexported (golint)
- Line 1897: warning: receiver name v should be consistent with previous receiver name fn for Function (golint)
- Line 1898: warning: exported method Global.Operands should have comment or be unexported (golint)
- Line 1899: warning: exported method Parameter.Operands should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/directives.go
- Line 14: warning: exported var Directives should have comment or be unexported (golint)
-
-
go-tools/go/types/typeutil/upstream.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 11: warning: exported type MethodSetCache should have comment or be unexported (golint)
- Line 12: warning: exported type Map should have comment or be unexported (golint)
- Line 13: warning: exported type Hasher should have comment or be unexported (golint)
- Line 15: warning: exported function Callee should have comment or be unexported (golint)
- Line 19: warning: exported function IntuitiveMethodSet should have comment or be unexported (golint)
- Line 23: warning: exported function MakeHasher should have comment or be unexported (golint)
-
-
go-tools/internal/go/gcimporter/exportdata.go
- Line 98: warning: exported function GetExportData should have comment or be unexported (golint)
- Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-tools/pattern/convert.go
- Line 56: warning: exported function ASTToNode should have comment or be unexported (golint)
- Line 134: warning: exported function NodeToAST should have comment or be unexported (golint)
-
-
go-tools/go/ir/lift.go
- Line 493: warning: exported type BlockSet should have comment or be unexported (golint)
- Line 499: warning: exported function NewBlockSet should have comment or be unexported (golint)
- Line 503: warning: exported method BlockSet.Set should have comment or be unexported (golint)
- Line 513: warning: exported method BlockSet.Num should have comment or be unexported (golint)
- Line 517: warning: exported method BlockSet.Has should have comment or be unexported (golint)
- Line 524: warning: comment on exported method BlockSet.Add should be of the form "Add ..." (golint)
- Line 536: warning: exported method BlockSet.Clear should have comment or be unexported (golint)
- Line 543: warning: comment on exported method BlockSet.Take should be of the form "Take ..." (golint)
-
-
go-tools/simple/lint.go
- Line 42: warning: exported function CheckSingleCaseSelect should have comment or be unexported (golint)
- Line 78: warning: exported function CheckLoopCopy should have comment or be unexported (golint)
- Line 108: warning: exported function CheckIfBoolCmp should have comment or be unexported (golint)
- Line 160: warning: exported function CheckBytesBufferConversions should have comment or be unexported (golint)
- Line 196: warning: exported function CheckStringsContains should have comment or be unexported (golint)
- Line 287: warning: exported function CheckBytesCompare should have comment or be unexported (golint)
- Line 319: warning: exported function CheckForTrue should have comment or be unexported (golint)
- Line 336: warning: exported function CheckRegexpRaw should have comment or be unexported (golint)
- Line 394: warning: exported function CheckIfReturn should have comment or be unexported (golint)
- Line 627: warning: exported function CheckSlicing should have comment or be unexported (golint)
- Line 666: warning: exported function CheckLoopAppend should have comment or be unexported (golint)
- Line 713: warning: exported function CheckTimeSince should have comment or be unexported (golint)
- Line 730: warning: exported function CheckTimeUntil should have comment or be unexported (golint)
- Line 763: warning: exported function CheckUnnecessaryBlank should have comment or be unexported (golint)
- Line 811: warning: exported function CheckSimplerStructConversion should have comment or be unexported (golint)
- Line 930: warning: exported function CheckTrim should have comment or be unexported (golint)
- Line 1138: warning: exported function CheckLoopSlide should have comment or be unexported (golint)
- Line 1168: warning: exported function CheckMakeLenCap should have comment or be unexported (golint)
- Line 1218: warning: exported function CheckAssertNotNil should have comment or be unexported (golint)
- Line 1248: warning: exported function CheckDeclareAssign should have comment or be unexported (golint)
- Line 1332: warning: exported function CheckRedundantBreak should have comment or be unexported (golint)
- Line 1427: warning: exported function CheckRedundantSprintf should have comment or be unexported (golint)
- Line 1498: warning: exported function CheckErrorsNewSprintf should have comment or be unexported (golint)
- Line 1511: warning: exported function CheckRangeStringRunes should have comment or be unexported (golint)
- Line 1522: warning: exported function CheckNilCheckAroundRange should have comment or be unexported (golint)
- Line 1561: warning: exported function CheckSortHelpers should have comment or be unexported (golint)
- Line 1642: warning: exported function CheckGuardedDelete should have comment or be unexported (golint)
- Line 1665: warning: exported function CheckSimplifyTypeSwitch should have comment or be unexported (golint)
- Line 1743: warning: exported function CheckRedundantCanonicalHeaderKey should have comment or be unexported (golint)
- Line 1784: warning: exported function CheckUnnecessaryGuard should have comment or be unexported (golint)
- Line 1804: warning: exported function CheckElaborateSleep should have comment or be unexported (golint)
- Line 1840: warning: exported function CheckPrintSprintf should have comment or be unexported (golint)
- Line 1879: warning: exported function CheckSprintLiteral should have comment or be unexported (golint)
- Line 1905: warning: exported function CheckSameTypeTypeAssertion should have comment or be unexported (golint)
-
-
go-tools/go/callgraph/callgraph.go
- Line 103: warning: exported method Edge.Description should have comment or be unexported (golint)
- Line 116: warning: exported method Edge.Pos should have comment or be unexported (golint)
-
-
go-tools/go/gcsizes/sizes.go
- Line 14: warning: exported type Sizes should have comment or be unexported (golint)
- Line 32: warning: exported method Sizes.Alignof should have comment or be unexported (golint)
- Line 60: warning: exported method Sizes.Offsetsof should have comment or be unexported (golint)
- Line 88: warning: exported method Sizes.Sizeof should have comment or be unexported (golint)
-
-
go-tools/lintcmd/version/version.go
- Line 10: warning: exported const Version should have comment or be unexported (golint)
- Line 11: warning: exported const MachineVersion should have comment or be unexported (golint)
- Line 15: warning: don't use underscores in Go names; func result human_ should be human (golint)
- Line 15: warning: don't use underscores in Go names; func result machine_ should be machine (golint)
- Line 26: warning: exported function Print should have comment or be unexported (golint)
- Line 38: warning: exported function Verbose should have comment or be unexported (golint)
-
-
go-tools/stylecheck/analysis.go
- Line 14: warning: exported var Analyzers should have comment or be unexported (golint)
-
-
go-tools/simple/analysis.go
- Line 11: warning: exported var Analyzers should have comment or be unexported (golint)
-
-
go-tools/go/ast/astutil/util.go
- Line 11: warning: exported function IsIdent should have comment or be unexported (golint)
- Line 16: warning: comment on exported function IsBlank should be of the form "IsBlank ..." (golint)
- Line 23: warning: exported function IsIntLiteral should have comment or be unexported (golint)
- Line 28: warning: comment on exported function IsZero should be of the form "IsZero ..." (golint)
- Line 33: warning: exported function Preamble should have comment or be unexported (golint)
- Line 48: warning: exported function GroupSpecs should have comment or be unexported (golint)
- Line 80: warning: exported function CopyExpr should have comment or be unexported (golint)
- Line 182: warning: exported function Equal should have comment or be unexported (golint)
-
-
go-tools/internal/passes/buildir/buildir.go
- Line 29: warning: exported var Analyzer should have comment or be unexported (golint)
-
-
go-tools/lint/testutil/util.go
- Line 11: warning: exported type Test should have comment or be unexported (golint)
- Line 16: warning: exported function Run should have comment or be unexported (golint)
-
-
go-tools/internal/gosmith/type.go
- Line 9: warning: exported type TypeClass should have comment or be unexported (golint)
- Line 12: warning: exported const ClassBoolean should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported type Type should have comment or be unexported (golint)
- Line 170: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 221: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-tools/staticcheck/doc.go
- Line 5: warning: exported var Docs should have comment or be unexported (golint)
-
-
go-tools/go/ast/astutil/upstream.go
- Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 11: warning: exported type Cursor should have comment or be unexported (golint)
- Line 12: warning: exported type ApplyFunc should have comment or be unexported (golint)
- Line 14: warning: exported function Apply should have comment or be unexported (golint)
- Line 18: warning: exported function PathEnclosingInterval should have comment or be unexported (golint)
-
-
go-tools/internal/cmd/ast-to-pattern/parse.go
- Line 107: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go-tools/go/ir/builder.go
- Line 1429: warning: don't use underscores in Go names; var default_ should be default (golint)
-
-
go-tools/staticcheck/analysis.go
- Line 23: warning: exported var Analyzers should have comment or be unexported (golint)
-
-
go-tools/debug/debug.go
- Line 10: warning: exported type Positioner should have comment or be unexported (golint)
- Line 14: warning: exported function PrintPosition should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/generated.go
- Line 14: warning: exported type Generator should have comment or be unexported (golint)
- Line 81: warning: exported var Generated should have comment or be unexported (golint)
-
-
go-tools/pattern/pattern.go
- Line 66: warning: exported type Function should have comment or be unexported (golint)
- Line 70: warning: exported type Token should have comment or be unexported (golint)
- Line 72: warning: exported type Nil should have comment or be unexported (golint)
- Line 75: warning: exported type Ellipsis should have comment or be unexported (golint)
- Line 79: warning: exported type IncDecStmt should have comment or be unexported (golint)
- Line 84: warning: exported type BranchStmt should have comment or be unexported (golint)
- Line 89: warning: exported type InterfaceType should have comment or be unexported (golint)
- Line 93: warning: exported type TypeSpec should have comment or be unexported (golint)
- Line 98: warning: exported type TypeAssertExpr should have comment or be unexported (golint)
- Line 103: warning: exported type TypeSwitchStmt should have comment or be unexported (golint)
- Line 109: warning: exported type SwitchStmt should have comment or be unexported (golint)
- Line 115: warning: exported type EmptyStmt should have comment or be unexported (golint)
- Line 118: warning: exported type CompositeLit should have comment or be unexported (golint)
- Line 123: warning: exported type CommClause should have comment or be unexported (golint)
- Line 128: warning: exported type CaseClause should have comment or be unexported (golint)
- Line 133: warning: exported type CallExpr should have comment or be unexported (golint)
- Line 141: warning: exported type ChanType should have comment or be unexported (golint)
- Line 146: warning: exported type FuncDecl should have comment or be unexported (golint)
- Line 153: warning: exported type FuncLit should have comment or be unexported (golint)
- Line 158: warning: exported type FuncType should have comment or be unexported (golint)
- Line 163: warning: exported type KeyValueExpr should have comment or be unexported (golint)
- Line 168: warning: exported type StructType should have comment or be unexported (golint)
- Line 172: warning: exported type SelectorExpr should have comment or be unexported (golint)
- Line 177: warning: exported type Field should have comment or be unexported (golint)
- Line 183: warning: exported type GoStmt should have comment or be unexported (golint)
- Line 187: warning: exported type IfStmt should have comment or be unexported (golint)
- Line 194: warning: exported type ImportSpec should have comment or be unexported (golint)
- Line 199: warning: exported type SelectStmt should have comment or be unexported (golint)
- Line 203: warning: exported type ArrayType should have comment or be unexported (golint)
- Line 208: warning: exported type DeferStmt should have comment or be unexported (golint)
- Line 212: warning: exported type MapType should have comment or be unexported (golint)
- Line 217: warning: exported type ReturnStmt should have comment or be unexported (golint)
- Line 221: warning: exported type SliceExpr should have comment or be unexported (golint)
- Line 228: warning: exported type StarExpr should have comment or be unexported (golint)
- Line 232: warning: exported type UnaryExpr should have comment or be unexported (golint)
- Line 237: warning: exported type SendStmt should have comment or be unexported (golint)
- Line 242: warning: exported type Binding should have comment or be unexported (golint)
- Line 247: warning: exported type RangeStmt should have comment or be unexported (golint)
- Line 255: warning: exported type AssignStmt should have comment or be unexported (golint)
- Line 261: warning: exported type IndexExpr should have comment or be unexported (golint)
- Line 266: warning: exported type Node should have comment or be unexported (golint)
- Line 271: warning: exported type Ident should have comment or be unexported (golint)
- Line 275: warning: exported type Object should have comment or be unexported (golint)
- Line 279: warning: exported type Builtin should have comment or be unexported (golint)
- Line 283: warning: exported type String should have comment or be unexported (golint)
- Line 285: warning: exported type Any should have comment or be unexported (golint)
- Line 287: warning: exported type ValueSpec should have comment or be unexported (golint)
- Line 293: warning: exported type List should have comment or be unexported (golint)
- Line 298: warning: exported type GenDecl should have comment or be unexported (golint)
- Line 303: warning: exported type BasicLit should have comment or be unexported (golint)
- Line 308: warning: exported type BinaryExpr should have comment or be unexported (golint)
- Line 314: warning: exported type ForStmt should have comment or be unexported (golint)
- Line 321: warning: exported type Or should have comment or be unexported (golint)
- Line 325: warning: exported type Not should have comment or be unexported (golint)
-
-
go-tools/lintcmd/runner/stats.go
- Line 13: warning: exported const StateInitializing should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported type Stats should have comment or be unexported (golint)
- Line 32: warning: exported method Stats.State should have comment or be unexported (golint)
- Line 34: warning: exported method Stats.InitialPackages should have comment or be unexported (golint)
- Line 36: warning: exported method Stats.TotalPackages should have comment or be unexported (golint)
- Line 40: warning: exported method Stats.ProcessedPackages should have comment or be unexported (golint)
- Line 41: warning: exported method Stats.ProcessedInitialPackages should have comment or be unexported (golint)
-
-
go-tools/go/ir/irutil/load.go
- Line 20: warning: exported type Options should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/nilness/nilness.go
- Line 28: warning: exported type Result should have comment or be unexported (golint)
- Line 32: warning: exported var Analysis should have comment or be unexported (golint)
- Line 154: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 171: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
go-tools/stylecheck/names.go
- Line 28: warning: exported function CheckNames should have comment or be unexported (golint)
-
-
go-tools/analysis/report/report.go
- Line 19: warning: exported type Options should have comment or be unexported (golint)
- Line 26: warning: exported type Option should have comment or be unexported (golint)
- Line 28: warning: exported function ShortRange should have comment or be unexported (golint)
- Line 34: warning: exported function FilterGenerated should have comment or be unexported (golint)
- Line 40: warning: exported function Fixes should have comment or be unexported (golint)
- Line 46: warning: exported function Related should have comment or be unexported (golint)
- Line 61: warning: exported type Positioner should have comment or be unexported (golint)
- Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 133: warning: exported function HasRange should have comment or be unexported (golint)
- Line 167: warning: exported function Report should have comment or be unexported (golint)
- Line 195: warning: exported function Render should have comment or be unexported (golint)
- Line 203: warning: exported function RenderArgs should have comment or be unexported (golint)
- Line 211: warning: exported function DisplayPosition should have comment or be unexported (golint)
- Line 229: warning: exported function Ordinal should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/token.go
- Line 11: warning: exported var TokenFile should have comment or be unexported (golint)
-
-
go-tools/go/types/typeutil/util.go
- Line 17: warning: exported function FuncName should have comment or be unexported (golint)
- Line 75: warning: exported function IsObject should have comment or be unexported (golint)
- Line 83: warning: comment on exported function IsType should be of the form "IsType ..." (golint)
- Line 86: warning: exported function IsPointerLike should have comment or be unexported (golint)
- Line 96: warning: exported type Field should have comment or be unexported (golint)
-
-
go-tools/printf/printf.go
- Line 36: warning: exported type Verb should have comment or be unexported (golint)
-
-
go-tools/staticcheck/rules.go
- Line 25: warning: exported const MsgInvalidHostPort should have comment (or a comment on this block) or be unexported (golint)
- Line 30: warning: exported type Call should have comment or be unexported (golint)
- Line 40: warning: exported method Call.Invalid should have comment or be unexported (golint)
- Line 44: warning: exported type Argument should have comment or be unexported (golint)
- Line 49: warning: exported type Value should have comment or be unexported (golint)
- Line 53: warning: exported method Argument.Invalid should have comment or be unexported (golint)
- Line 57: warning: exported type CallCheck should have comment or be unexported (golint)
- Line 79: warning: exported function ValidateRegexp should have comment or be unexported (golint)
- Line 89: warning: exported function ValidateTimeLayout should have comment or be unexported (golint)
- Line 102: warning: exported function ValidateURL should have comment or be unexported (golint)
- Line 113: warning: exported function InvalidUTF8 should have comment or be unexported (golint)
- Line 123: warning: exported function UnbufferedChannel should have comment or be unexported (golint)
- Line 143: warning: exported function Pointer should have comment or be unexported (golint)
- Line 151: warning: exported function ConvertedFromInt should have comment or be unexported (golint)
- Line 196: warning: exported function CanBinaryMarshal should have comment or be unexported (golint)
- Line 212: warning: exported function RepeatZeroTimes should have comment or be unexported (golint)
- Line 255: warning: exported function ValidHostPort should have comment or be unexported (golint)
- Line 276: warning: exported function UniqueStringCutset should have comment or be unexported (golint)
-
-
go-tools/go/ir/print.go
- Line 426: warning: exported method Package.WriteTo should have comment or be unexported (golint)
-
-
go-tools/sarif/sarif.go
- Line 3: warning: exported const Version should have comment or be unexported (golint)
- Line 4: warning: exported const Schema should have comment or be unexported (golint)
- Line 6: warning: exported type Log should have comment or be unexported (golint)
- Line 12: warning: exported type Run should have comment or be unexported (golint)
- Line 19: warning: exported type Artifact should have comment or be unexported (golint)
- Line 28: warning: exported const AnalysisTarget should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported type Hash should have comment or be unexported (golint)
- Line 41: warning: exported type Tool should have comment or be unexported (golint)
- Line 45: warning: exported type Invocation should have comment or be unexported (golint)
- Line 52: warning: exported type ToolComponent should have comment or be unexported (golint)
- Line 60: warning: exported type ReportingDescriptor should have comment or be unexported (golint)
- Line 68: warning: exported type ReportingConfiguration should have comment or be unexported (golint)
- Line 74: warning: exported type Result should have comment or be unexported (golint)
- Line 86: warning: exported type Suppression should have comment or be unexported (golint)
- Line 91: warning: exported type Fix should have comment or be unexported (golint)
- Line 96: warning: exported type ArtifactChange should have comment or be unexported (golint)
- Line 101: warning: exported type Replacement should have comment or be unexported (golint)
- Line 106: warning: exported type ArtifactContent should have comment or be unexported (golint)
- Line 110: warning: exported type Message should have comment or be unexported (golint)
- Line 115: warning: exported type Location should have comment or be unexported (golint)
- Line 121: warning: exported type PhysicalLocation should have comment or be unexported (golint)
- Line 126: warning: exported type ArtifactLocation should have comment or be unexported (golint)
- Line 131: warning: exported type Region should have comment or be unexported (golint)
-
-
go-tools/internal/sharedcheck/lint.go
- Line 22: warning: exported function CheckRangeStringRunes should have comment or be unexported (golint)
-
-
go-tools/internal/gosmith/expr.go
- Line 250: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 404: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-tools/unused/unused.go
- Line 25: warning: exported var Debug should have comment or be unexported (golint)
- Line 407: warning: comment on exported type Result should be of the form "Result ..." (with optional leading article) (golint)
- Line 413: warning: exported type SerializedResult should have comment or be unexported (golint)
- Line 418: warning: exported var Analyzer should have comment or be unexported (golint)
- Line 431: warning: exported type SerializedObject should have comment or be unexported (golint)
- Line 457: warning: exported function Serialize should have comment or be unexported (golint)
-
-
go-tools/simple/doc.go
- Line 5: warning: exported var Docs should have comment or be unexported (golint)
-
-
go-tools/go/callgraph/rta/rta.go
- Line 5: warning: package comment should be of the form "Package rta ..." (golint)
-
-
go-tools/analysis/code/code.go
- Line 20: warning: exported type Positioner should have comment or be unexported (golint)
- Line 24: warning: exported function IsOfType should have comment or be unexported (golint)
- Line 28: warning: exported function IsInTest should have comment or be unexported (golint)
- Line 62: warning: exported function SelectorName should have comment or be unexported (golint)
- Line 79: warning: exported function IsNil should have comment or be unexported (golint)
- Line 83: warning: exported function BoolConst should have comment or be unexported (golint)
- Line 88: warning: exported function IsBoolConst should have comment or be unexported (golint)
- Line 112: warning: exported function ExprToInt should have comment or be unexported (golint)
- Line 123: warning: exported function ExprToString should have comment or be unexported (golint)
- Line 134: warning: exported function CallName should have comment or be unexported (golint)
- Line 157: warning: exported function IsCallTo should have comment or be unexported (golint)
- Line 165: warning: exported function IsCallToAny should have comment or be unexported (golint)
- Line 179: warning: exported function File should have comment or be unexported (golint)
- Line 287: warning: exported function IsGoVersion should have comment or be unexported (golint)
-
-
go-tools/go/ir/irutil/util.go
- Line 11: warning: exported function Reachable should have comment or be unexported (golint)
- Line 30: warning: exported function Walk should have comment or be unexported (golint)
- Line 47: warning: exported function Vararg should have comment or be unexported (golint)
- Line 76: warning: exported function CallName should have comment or be unexported (golint)
- Line 93: warning: exported function IsCallTo should have comment or be unexported (golint)
- Line 95: warning: exported function IsCallToAny should have comment or be unexported (golint)
- Line 105: warning: exported function FilterDebug should have comment or be unexported (golint)
- Line 115: warning: exported function IsExample should have comment or be unexported (golint)
-
-
go-tools/go/ir/func.go
- Line 99: warning: exported method BasicBlock.Phis should have comment or be unexported (golint)
- Line 627: warning: exported method Function.RemoveNilBlocks should have comment or be unexported (golint)
- Line 817: warning: exported method Function.WriteTo should have comment or be unexported (golint)
-
-
go-tools/go/ir/write.go
- Line 3: warning: exported function NewJump should have comment or be unexported (golint)
-
-
go-tools/analysis/edit/edit.go
- Line 13: warning: exported type Ranger should have comment or be unexported (golint)
- Line 18: warning: exported type Range should have comment or be unexported (golint)
- Line 20: warning: exported method Range.Pos should have comment or be unexported (golint)
- Line 21: warning: exported method Range.End should have comment or be unexported (golint)
- Line 23: warning: exported function ReplaceWithString should have comment or be unexported (golint)
- Line 31: warning: exported function ReplaceWithNode should have comment or be unexported (golint)
- Line 43: warning: exported function ReplaceWithPattern should have comment or be unexported (golint)
- Line 54: warning: exported function Delete should have comment or be unexported (golint)
- Line 62: warning: exported function Fix should have comment or be unexported (golint)
- Line 69: warning: exported function Selector should have comment or be unexported (golint)
-
-
go-tools/analysis/facts/purity.go
- Line 14: warning: exported type IsPure should have comment or be unexported (golint)
- Line 16: warning: exported method IsPure.AFact should have comment or be unexported (golint)
- Line 19: warning: exported type PurityResult should have comment or be unexported (golint)
- Line 21: warning: exported var Purity should have comment or be unexported (golint)
-
-
go-tools/knowledge/arg.go
- Line 58: warning: exported function Arg should have comment or be unexported (golint)
-
-
go-tools/go/ir/irutil/loops.go
- Line 5: warning: exported type Loop should have comment or be unexported (golint)
- Line 7: warning: exported function FindLoops should have comment or be unexported (golint)
-
-
go-tools/stylecheck/lint.go
- Line 41: warning: exported function CheckPackageComment should have comment or be unexported (golint)
- Line 79: warning: exported function CheckDotImports should have comment or be unexported (golint)
- Line 99: warning: exported function CheckDuplicatedImports should have comment or be unexported (golint)
- Line 129: warning: exported function CheckBlankImports should have comment or be unexported (golint)
- Line 188: warning: exported function CheckIncDec should have comment or be unexported (golint)
- Line 219: warning: exported function CheckErrorReturn should have comment or be unexported (golint)
- Line 269: warning: exported function CheckReceiverNames should have comment or be unexported (golint)
- Line 293: warning: exported function CheckReceiverNamesIdentical should have comment or be unexported (golint)
- Line 334: warning: exported function CheckContextFirstArg should have comment or be unexported (golint)
- Line 360: warning: exported function CheckErrorStrings should have comment or be unexported (golint)
- Line 447: warning: exported function CheckTimeNames should have comment or be unexported (golint)
- Line 499: warning: exported function CheckErrorVarNames should have comment or be unexported (golint)
- Line 599: warning: exported function CheckHTTPStatusCodes should have comment or be unexported (golint)
- Line 647: warning: exported function CheckDefaultCaseOrder should have comment or be unexported (golint)
- Line 667: warning: exported function CheckYodaConditions should have comment or be unexported (golint)
- Line 679: warning: exported function CheckInvisibleCharacters should have comment or be unexported (golint)
- Line 780: warning: exported function CheckExportedFunctionDocs should have comment or be unexported (golint)
- Line 820: warning: exported function CheckExportedTypeDocs should have comment or be unexported (golint)
- Line 886: warning: exported function CheckExportedVarDocs should have comment or be unexported (golint)
-
-
go-tools/go/loader/loader.go
- Line 21: warning: exported const MaxFileSize should have comment or be unexported (golint)
- Line 25: warning: exported type PackageSpec should have comment or be unexported (golint)
- Line 49: warning: exported type Package should have comment or be unexported (golint)
- Line 142: warning: exported type Stats should have comment or be unexported (golint)
-
-
go-tools/structlayout/layout.go
- Line 5: warning: exported type Field should have comment or be unexported (golint)
-
-
go-tools/go/ir/mode.go
- Line 24: warning: exported const PrintPackages should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported const BuilderModeDoc should have comment or be unexported (golint)
-
-
go-tools/config/config.go
- Line 59: warning: exported var Analyzer should have comment or be unexported (golint)
- Line 78: warning: exported function For should have comment or be unexported (golint)
- Line 118: warning: exported method Config.Merge should have comment or be unexported (golint)
- Line 134: warning: exported type Config should have comment or be unexported (golint)
- Line 148: warning: receiver name c should be consistent with previous receiver name cfg for Config (golint)
- Line 159: warning: exported var DefaultConfig should have comment or be unexported (golint)
- Line 174: warning: exported const ConfigName should have comment or be unexported (golint)
- Line 232: warning: exported function Load should have comment or be unexported (golint)
-
-
go-tools/go/buildid/note.go
- Line 28: warning: exported function ReadELFNote should have comment or be unexported (golint)
-
-
go-tools/lintcmd/runner/runner.go
- Line 144: warning: exported type Diagnostic should have comment or be unexported (golint)
- Line 161: warning: exported type SuggestedFix should have comment or be unexported (golint)
- Line 166: warning: exported type TextEdit should have comment or be unexported (golint)
- Line 188: warning: exported type SerializedDirective should have comment or be unexported (golint)
- Line 206: warning: exported type ResultData should have comment or be unexported (golint)
- Line 212: warning: exported method Result.Load should have comment or be unexported (golint)
-
-
go-tools/go/ir/emit.go
- Line 156: warning: don't use underscores in Go names; func parameter ut_src should be utSrc (golint)
- Line 156: warning: don't use underscores in Go names; func parameter ut_dst should be utDst (golint)
- Line 182: warning: don't use underscores in Go names; var t_src should be tSrc (golint)
- Line 189: warning: don't use underscores in Go names; var ut_dst should be utDst (golint)
- Line 190: warning: don't use underscores in Go names; var ut_src should be utSrc (golint)
-
-
go-tools/analysis/lint/lint.go
- Line 16: warning: exported type Analyzer should have comment or be unexported (golint)
- Line 33: warning: exported function InitializeAnalyzers should have comment or be unexported (golint)
- Line 47: warning: exported type Severity should have comment or be unexported (golint)
- Line 50: warning: exported const SeverityNone should have comment (or a comment on this block) or be unexported (golint)
- Line 58: warning: exported type Documentation should have comment or be unexported (golint)
- Line 67: warning: exported function Markdownify should have comment or be unexported (golint)
- Line 119: warning: exported type VersionFlag should have comment or be unexported (golint)
- Line 125: warning: exported method VersionFlag.Set should have comment or be unexported (golint)
- Line 143: warning: exported method VersionFlag.Get should have comment or be unexported (golint)
- Line 153: warning: comment on exported type Directive should be of the form "Directive ..." (with optional leading article) (golint)
- Line 172: warning: exported function ParseDirectives should have comment or be unexported (golint)
-
-
go-tools/internal/sync/sync.go
- Line 3: warning: exported type Semaphore should have comment or be unexported (golint)
- Line 7: warning: exported function NewSemaphore should have comment or be unexported (golint)
- Line 13: warning: exported method Semaphore.Acquire should have comment or be unexported (golint)
- Line 17: warning: exported method Semaphore.AcquireMaybe should have comment or be unexported (golint)
- Line 26: warning: exported method Semaphore.Release should have comment or be unexported (golint)
- Line 30: warning: exported method Semaphore.Len should have comment or be unexported (golint)
- Line 34: warning: exported method Semaphore.Cap should have comment or be unexported (golint)
-
-
go-tools/quickfix/analysis.go
- Line 12: warning: exported var Analyzers should have comment or be unexported (golint)
-
-
go-tools/quickfix/lint.go
- Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 132: warning: exported function CheckDeMorgan should have comment or be unexported (golint)
- Line 238: warning: exported function CheckTaglessSwitch should have comment or be unexported (golint)
- Line 304: warning: exported function CheckIfElseToSwitch should have comment or be unexported (golint)
- Line 425: warning: exported function CheckStringsReplaceAll should have comment or be unexported (golint)
- Line 466: warning: exported function CheckMathPow should have comment or be unexported (golint)
- Line 541: warning: exported function CheckForLoopIfBreak should have comment or be unexported (golint)
- Line 567: warning: exported function CheckConditionalAssignment should have comment or be unexported (golint)
- Line 620: warning: exported function CheckExplicitEmbeddedSelector should have comment or be unexported (golint)
- Line 747: warning: exported function CheckTimeEquality should have comment or be unexported (golint)
- Line 793: warning: exported function CheckByteSlicePrinting should have comment or be unexported (golint)
-
-
go-tools/pattern/match.go
- Line 88: warning: exported type State should have comment or be unexported (golint)
- Line 90: warning: exported type Matcher should have comment or be unexported (golint)
- Line 110: warning: exported method Matcher.Match should have comment or be unexported (golint)
- Line 116: warning: exported function Match should have comment or be unexported (golint)
- Line 377: warning: exported method Binding.Match should have comment or be unexported (golint)
- Line 399: warning: exported method Any.Match should have comment or be unexported (golint)
- Line 403: warning: exported method List.Match should have comment or be unexported (golint)
- Line 422: warning: exported method String.Match should have comment or be unexported (golint)
- Line 436: warning: exported method Token.Match should have comment or be unexported (golint)
- Line 444: warning: exported method Nil.Match should have comment or be unexported (golint)
- Line 448: warning: exported method Builtin.Match should have comment or be unexported (golint)
- Line 461: warning: exported method Object.Match should have comment or be unexported (golint)
- Line 473: warning: exported method Function.Match should have comment or be unexported (golint)
- Line 509: warning: exported method Or.Match should have comment or be unexported (golint)
- Line 520: warning: exported method Not.Match should have comment or be unexported (golint)
ineffassign99%
IneffAssign detects ineffectual assignments in Go code.
-
-
go-tools/go/ir/lift.go
- Line 217: warning: ineffectual assignment to index (ineffassign)