Preparing report...

Report for github.com/emc-advanced-dev/unik

B    Not bad!    Found 319 issues across 361 files

Tweet

gofmt70%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint17%

Golint is a linter for Go source code.

    • unik/pkg/providers/common/qemu.go
    • Line 17: warning: exported function ConvertRawImage should have comment or be unexported (golint)
    • Line 87: warning: exported function ConvertRawToNewVmdk should have comment or be unexported (golint)
    • Line 111: warning: exported function GetVirtualImageSize should have comment or be unexported (golint)
    • unik/pkg/providers/vsphere/vsphereclient/client.go
    • Line 19: warning: exported type VsphereClient should have comment or be unexported (golint)
    • Line 25: warning: exported function NewVsphereClient should have comment or be unexported (golint)
    • Line 59: warning: exported method VsphereClient.GetVmByUuid should have comment or be unexported (golint)
    • Line 85: warning: exported method VsphereClient.GetVm should have comment or be unexported (golint)
    • Line 111: warning: exported method VsphereClient.GetVmIp should have comment or be unexported (golint)
    • Line 119: warning: exported method VsphereClient.CreateVm should have comment or be unexported (golint)
    • Line 144: warning: exported method VsphereClient.DestroyVm should have comment or be unexported (golint)
    • Line 160: warning: exported method VsphereClient.Mkdir should have comment or be unexported (golint)
    • Line 177: warning: exported method VsphereClient.Rmdir should have comment or be unexported (golint)
    • Line 194: warning: exported method VsphereClient.ImportVmdk should have comment or be unexported (golint)
    • Line 216: warning: exported method VsphereClient.UploadFile should have comment or be unexported (golint)
    • Line 235: warning: exported method VsphereClient.DownloadFile should have comment or be unexported (golint)
    • Line 254: warning: exported method VsphereClient.CopyVmdk should have comment or be unexported (golint)
    • Line 276: warning: exported method VsphereClient.CopyFile should have comment or be unexported (golint)
    • Line 310: warning: exported method VsphereClient.Ls should have comment or be unexported (golint)
    • Line 335: warning: exported method VsphereClient.PowerOnVm should have comment or be unexported (golint)
    • Line 352: warning: exported method VsphereClient.PowerOffVm should have comment or be unexported (golint)
    • Line 369: warning: exported method VsphereClient.AttachDisk should have comment or be unexported (golint)
    • Line 392: warning: exported method VsphereClient.DetachDisk should have comment or be unexported (golint)
    • unik/pkg/compilers/osv/osv_vmware.go
    • Line 7: warning: exported const OSV_VMWARE_MEMORY should have comment or be unexported (golint)
    • Line 9: warning: exported type VmwareImageFinisher should have comment or be unexported (golint)
    • Line 13: warning: exported method VmwareImageFinisher.FinishImage should have comment or be unexported (golint)
    • unik/pkg/providers/qemu/qemu_provider.go
    • Line 14: warning: exported type QemuProvider should have comment or be unexported (golint)
    • Line 19: warning: exported function QemuStateFile should have comment or be unexported (golint)
    • Line 35: warning: exported function NewQemuProvider should have comment or be unexported (golint)
    • Line 57: warning: exported method QemuProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/providers/vsphere/stage.go
    • Line 15: warning: exported method VsphereProvider.Stage should have comment or be unexported (golint)
    • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/containers/compilers/rump/go/stub/gomaincaller.go
    • Line 18: warning: don't use underscores in Go names; func parameter kludge_dns_addrs_len should be kludgeDNSAddrsLen (golint)
    • Line 18: warning: don't use underscores in Go names; func parameter kludge_dns_addrs should be kludgeDNSAddrs (golint)
    • Line 36: warning: exported const BROADCAST_LISTENING_PORT should have comment or be unexported (golint)
    • unik/pkg/providers/xen/xen_provider.go
    • Line 12: warning: exported type XenProvider should have comment or be unexported (golint)
    • Line 17: warning: exported function XenStateFile should have comment or be unexported (golint)
    • Line 33: warning: exported function NewXenProvider should have comment or be unexported (golint)
    • Line 56: warning: exported method XenProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/os/shell.go
    • Line 14: warning: exported function RunLogCommand should have comment or be unexported (golint)
    • Line 25: warning: exported function GetDirSize should have comment or be unexported (golint)
    • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 64: warning: exported function CopyDir should have comment or be unexported (golint)
    • Line 175: warning: comment on exported function DirSize should be of the form "DirSize ..." (golint)
    • unik/pkg/compilers/interface.go
    • Line 9: warning: exported type Compiler should have comment or be unexported (golint)
    • Line 18: warning: exported type CompilerUsage should have comment or be unexported (golint)
    • Line 31: warning: exported method CompilerUsage.ToString should have comment or be unexported (golint)
    • unik/pkg/compilers/includeos/includeos_virtualbox.go
    • Line 16: warning: exported type IncludeosVirtualboxCompiler should have comment or be unexported (golint)
    • Line 18: warning: exported method IncludeosVirtualboxCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 58: warning: exported method IncludeosVirtualboxCompiler.Usage should have comment or be unexported (golint)
    • Line 58: warning: receiver name r should be consistent with previous receiver name i for IncludeosVirtualboxCompiler (golint)
    • unik/pkg/providers/common/hub_client.go
    • Line 21: warning: don't use underscores in Go names; const unik_hub_region should be unikHubRegion (golint)
    • Line 22: warning: don't use underscores in Go names; const unik_hub_bucket should be unikHubBucket (golint)
    • Line 23: warning: don't use underscores in Go names; const unik_image_info should be unikImageInfo (golint)
    • Line 26: warning: exported function PullImage should have comment or be unexported (golint)
    • Line 65: warning: exported function PushImage should have comment or be unexported (golint)
    • Line 89: warning: exported function RemoteDeleteImage should have comment or be unexported (golint)
    • unik/pkg/providers/openstack/openstack_provider.go
    • Line 12: warning: exported type OpenstackProvider should have comment or be unexported (golint)
    • Line 17: warning: exported function OpenstackStateFile should have comment or be unexported (golint)
    • Line 21: warning: exported function NewOpenstackProvider should have comment or be unexported (golint)
    • Line 31: warning: exported method OpenstackProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/providers/aws/aws_provider.go
    • Line 16: warning: exported function AwsStateFile should have comment or be unexported (golint)
    • Line 20: warning: exported type AwsProvider should have comment or be unexported (golint)
    • Line 25: warning: exported function NewAwsProvier should have comment or be unexported (golint)
    • Line 33: warning: exported method AwsProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/providers/ukvm/ukvm_provider.go
    • Line 11: warning: exported type UkvmProvider should have comment or be unexported (golint)
    • Line 16: warning: exported function UkvmStateFile should have comment or be unexported (golint)
    • Line 32: warning: exported function NewUkvmProvider should have comment or be unexported (golint)
    • Line 46: warning: exported method UkvmProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/compilers/osv/osv_qemu.go
    • Line 7: warning: exported const OSV_QEMU_DEFAULT_MEMORY should have comment or be unexported (golint)
    • Line 9: warning: exported type QemuImageFinisher should have comment or be unexported (golint)
    • Line 13: warning: exported method QemuImageFinisher.FinishImage should have comment or be unexported (golint)
    • Line 27: warning: exported method QemuImageFinisher.UseEc2 should have comment or be unexported (golint)
    • unik/pkg/providers/photon/stage.go
    • Line 47: warning: exported method PhotonProvider.Stage should have comment or be unexported (golint)
    • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/cmd/root.go
    • Line 22: warning: exported var RootCmd should have comment or be unexported (golint)
    • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/util/log_formatter.go
    • Line 38: warning: exported type RedactedTextFormatter should have comment or be unexported (golint)
    • Line 66: warning: exported method RedactedTextFormatter.Format should have comment or be unexported (golint)
    • Line 207: warning: exported function Redact should have comment or be unexported (golint)
    • unik/pkg/providers/qemu/stage.go
    • Line 15: warning: exported method QemuProvider.Stage should have comment or be unexported (golint)
    • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/compilers/rump/rump-go.go
    • Line 21: warning: exported type RumpGoCompiler should have comment or be unexported (golint)
    • Line 26: warning: exported method RumpGoCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 60: warning: exported method RumpGoCompiler.Usage should have comment or be unexported (golint)
    • unik/pkg/providers/firecracker/provider.go
    • Line 14: warning: exported type FirecrackerProvider should have comment or be unexported (golint)
    • Line 22: warning: exported function FirecrackerStateFile should have comment or be unexported (golint)
    • Line 38: warning: exported function NewProvider should have comment or be unexported (golint)
    • Line 53: warning: exported method FirecrackerProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/compilers/rump/rump-scripting.go
    • Line 22: warning: exported const BootstrapTypeEC2 should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: comment on exported type RumpScriptCompiler should be of the form "RumpScriptCompiler ..." (with optional leading article) (golint)
    • Line 42: warning: exported method RumpScriptCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 82: warning: exported method RumpScriptCompiler.Usage should have comment or be unexported (golint)
    • Line 86: warning: exported function NewRumpPythonCompiler should have comment or be unexported (golint)
    • Line 101: warning: exported function NewRumpJavaCompiler should have comment or be unexported (golint)
    • unik/pkg/util/log.go
    • Line 14: warning: exported type AddTraceHook should have comment or be unexported (golint)
    • Line 18: warning: exported method AddTraceHook.Levels should have comment or be unexported (golint)
    • Line 22: warning: exported method AddTraceHook.Fire should have comment or be unexported (golint)
    • Line 72: warning: exported function LogCommand should have comment or be unexported (golint)
    • Line 100: warning: exported type TeeHook should have comment or be unexported (golint)
    • Line 104: warning: exported method TeeHook.Levels should have comment or be unexported (golint)
    • Line 108: warning: exported method TeeHook.Fire should have comment or be unexported (golint)
    • unik/pkg/os/device.go
    • Line 13: warning: exported type DiskSize should have comment or be unexported (golint)
    • Line 18: warning: exported type Bytes should have comment or be unexported (golint)
    • Line 20: warning: exported method Bytes.ToPartedFormat should have comment or be unexported (golint)
    • Line 24: warning: exported method Bytes.ToBytes should have comment or be unexported (golint)
    • Line 33: warning: exported type MegaBytes should have comment or be unexported (golint)
    • Line 35: warning: exported method MegaBytes.ToPartedFormat should have comment or be unexported (golint)
    • Line 39: warning: exported method MegaBytes.ToBytes should have comment or be unexported (golint)
    • Line 43: warning: exported type GigaBytes should have comment or be unexported (golint)
    • Line 45: warning: exported method GigaBytes.ToPartedFormat should have comment or be unexported (golint)
    • Line 49: warning: exported method GigaBytes.ToBytes should have comment or be unexported (golint)
    • Line 53: warning: exported type Sectors should have comment or be unexported (golint)
    • Line 55: warning: exported const SectorSize should have comment or be unexported (golint)
    • Line 57: warning: exported method Sectors.ToPartedFormat should have comment or be unexported (golint)
    • Line 61: warning: exported method Sectors.ToBytes should have comment or be unexported (golint)
    • Line 65: warning: exported function ToSectors should have comment or be unexported (golint)
    • Line 73: warning: exported type BlockDevice should have comment or be unexported (golint)
    • Line 75: warning: exported method BlockDevice.Name should have comment or be unexported (golint)
    • Line 79: warning: exported type Partitioner should have comment or be unexported (golint)
    • Line 84: warning: exported type Resource should have comment or be unexported (golint)
    • Line 89: warning: exported type Part should have comment or be unexported (golint)
    • Line 98: warning: exported function IsExists should have comment or be unexported (golint)
    • unik/pkg/os/volumes.go
    • Line 14: warning: exported type RawVolume should have comment or be unexported (golint)
    • Line 19: warning: exported const GrubTemplate should have comment or be unexported (golint)
    • Line 29: warning: exported const DeviceMapFile should have comment or be unexported (golint)
    • Line 32: warning: exported const ProgramName should have comment or be unexported (golint)
    • Line 52: warning: exported function CreateBootImageWithSize should have comment or be unexported (golint)
    • Line 65: warning: exported function CreateBootImageOnFile should have comment or be unexported (golint)
    • Line 153: warning: exported function PrepareGrub should have comment or be unexported (golint)
    • Line 184: warning: exported function CreateBootImageOnFilePvGrub should have comment or be unexported (golint)
    • Line 213: warning: exported function PreparePVGrub should have comment or be unexported (golint)
    • Line 313: warning: exported function CreateSingleVolume should have comment or be unexported (golint)
    • Line 343: warning: exported function CopyToImgFile should have comment or be unexported (golint)
    • Line 364: warning: exported function CreateVolumes should have comment or be unexported (golint)
    • unik/pkg/compilers/osv/osv_virtualbox.go
    • Line 7: warning: exported const OSV_VIRTUALBOX_MEMORY should have comment or be unexported (golint)
    • Line 9: warning: exported type VirtualboxImageFinisher should have comment or be unexported (golint)
    • Line 11: warning: exported method VirtualboxImageFinisher.FinishImage should have comment or be unexported (golint)
    • Line 27: warning: exported method VirtualboxImageFinisher.UseEc2 should have comment or be unexported (golint)
    • unik/pkg/compilers/rump/rump-c.go
    • Line 15: warning: comment on exported type RumpCCompiler should be of the form "RumpCCompiler ..." (with optional leading article) (golint)
    • Line 24: warning: exported method RumpCCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 48: warning: exported method RumpCCompiler.Usage should have comment or be unexported (golint)
    • Line 52: warning: exported function NewRumpCCompiler should have comment or be unexported (golint)
    • unik/pkg/providers/vsphere/vsphere_provider.go
    • Line 18: warning: exported function VsphereStateFile should have comment or be unexported (golint)
    • Line 22: warning: exported var VsphereImagesDirectory should have comment or be unexported (golint)
    • Line 23: warning: exported var VsphereVolumesDirectory should have comment or be unexported (golint)
    • Line 25: warning: exported const VsphereUnikInstanceListener should have comment or be unexported (golint)
    • Line 28: warning: exported type VsphereProvider should have comment or be unexported (golint)
    • Line 35: warning: exported function NewVsphereProvier should have comment or be unexported (golint)
    • Line 82: warning: exported method VsphereProvider.WithState should have comment or be unexported (golint)
    • unik/test/helpers/test_helpers.go
    • Line 20: warning: exported type TempUnikHome should have comment or be unexported (golint)
    • Line 24: warning: exported method TempUnikHome.SetupUnik should have comment or be unexported (golint)
    • Line 40: warning: exported method TempUnikHome.TearDownUnik should have comment or be unexported (golint)
    • Line 52: warning: exported function NewAwsConfig should have comment or be unexported (golint)
    • Line 68: warning: exported function NewVirtualboxConfig should have comment or be unexported (golint)
    • Line 85: warning: exported function NewVsphereConfig should have comment or be unexported (golint)
    • Line 122: warning: exported function NewQemuConfig should have comment or be unexported (golint)
    • Line 130: warning: exported function NewXenConfig should have comment or be unexported (golint)
    • Line 142: warning: exported function NewTestConfig should have comment or be unexported (golint)
    • Line 190: warning: exported function MakeContainers should have comment or be unexported (golint)
    • Line 196: warning: exported function RemoveContainers should have comment or be unexported (golint)
    • Line 202: warning: exported function TarExampleApp should have comment or be unexported (golint)
    • Line 221: warning: exported function TarTestApp should have comment or be unexported (golint)
    • Line 239: warning: exported function TarTestVolume should have comment or be unexported (golint)
    • Line 257: warning: exported function BuildExampleImage should have comment or be unexported (golint)
    • Line 268: warning: exported function BuildTestImage should have comment or be unexported (golint)
    • Line 279: warning: exported function RunExampleInstance should have comment or be unexported (golint)
    • Line 286: warning: exported function CreateExampleVolume should have comment or be unexported (golint)
    • Line 290: warning: exported function CreateTestDataVolume should have comment or be unexported (golint)
    • Line 299: warning: exported function GetProjectRoot should have comment or be unexported (golint)
    • Line 312: warning: exported function WaitForIp should have comment or be unexported (golint)
    • unik/pkg/util/data_image.go
    • Line 17: warning: exported function BuildRawDataImageWithType should have comment or be unexported (golint)
    • Line 74: warning: exported function BuildRawDataImage should have comment or be unexported (golint)
    • Line 77: warning: exported function BuildEmptyDataVolumeWithType should have comment or be unexported (golint)
    • Line 120: warning: exported function BuildEmptyDataVolume should have comment or be unexported (golint)
    • unik/pkg/os/archive.go
    • Line 13: warning: exported function ExtractTar should have comment or be unexported (golint)
    • Line 60: warning: comment on exported function Compress should be of the form "Compress ..." (golint)
    • unik/pkg/providers/interface.go
    • Line 8: warning: exported type Provider should have comment or be unexported (golint)
    • Line 36: warning: exported type ProviderConfig should have comment or be unexported (golint)
    • Line 40: warning: exported type Providers should have comment or be unexported (golint)
    • Line 42: warning: exported method Providers.Keys should have comment or be unexported (golint)
    • Line 50: warning: exported method Providers.ProviderForImage should have comment or be unexported (golint)
    • Line 60: warning: exported method Providers.ProviderForInstance should have comment or be unexported (golint)
    • Line 70: warning: exported method Providers.ProviderForVolume should have comment or be unexported (golint)
    • unik/pkg/compilers/names.go
    • Line 11: warning: exported const Rump should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type CompilerType should have comment or be unexported (golint)
    • Line 16: warning: exported method CompilerType.Base should have comment or be unexported (golint)
    • Line 19: warning: exported method CompilerType.Language should have comment or be unexported (golint)
    • Line 22: warning: exported method CompilerType.Provider should have comment or be unexported (golint)
    • Line 30: warning: comment on exported var RUMP_C_XEN should be of the form "RUMP_C_XEN ..." (golint)
    • Line 32: warning: exported var RUMP_C_AWS should have comment or be unexported (golint)
    • Line 162: warning: exported function ValidateCompiler should have comment or be unexported (golint)
    • unik/pkg/util/container.go
    • Line 21: warning: exported function InitContainers should have comment or be unexported (golint)
    • Line 33: warning: exported type Container should have comment or be unexported (golint)
    • Line 44: warning: exported function NewContainer should have comment or be unexported (golint)
    • Line 54: warning: exported method Container.WithEntrypoint should have comment or be unexported (golint)
    • Line 59: warning: exported method Container.WithVolume should have comment or be unexported (golint)
    • Line 64: warning: exported method Container.WithVolumes should have comment or be unexported (golint)
    • Line 71: warning: exported method Container.WithEnv should have comment or be unexported (golint)
    • Line 76: warning: exported method Container.WithEnvs should have comment or be unexported (golint)
    • Line 83: warning: exported method Container.WithNet should have comment or be unexported (golint)
    • Line 88: warning: exported method Container.WithName should have comment or be unexported (golint)
    • Line 93: warning: exported method Container.Interactive should have comment or be unexported (golint)
    • Line 98: warning: exported method Container.Privileged should have comment or be unexported (golint)
    • Line 103: warning: exported method Container.Run should have comment or be unexported (golint)
    • Line 111: warning: exported method Container.Output should have comment or be unexported (golint)
    • Line 115: warning: exported method Container.CombinedOutput should have comment or be unexported (golint)
    • Line 119: warning: exported method Container.Stop should have comment or be unexported (golint)
    • Line 123: warning: exported method Container.BuildCmd should have comment or be unexported (golint)
    • Line 175: warning: exported function IsDockerToolbox should have comment or be unexported (golint)
    • Line 179: warning: exported function GetToolboxMountPath should have comment or be unexported (golint)
    • unik/pkg/providers/virtualbox/delete_volume.go
    • Line 8: warning: exported method VirtualboxProvider.DeleteVolume should have comment or be unexported (golint)
    • Line 17: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • unik/pkg/providers/xen/stage.go
    • Line 14: warning: exported method XenProvider.Stage should have comment or be unexported (golint)
    • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/compilers/osv/osv_native.go
    • Line 10: warning: exported type OSvNativeCompiler should have comment or be unexported (golint)
    • Line 14: warning: exported method OSvNativeCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 43: warning: exported method OSvNativeCompiler.Usage should have comment or be unexported (golint)
    • unik/pkg/config/config.go
    • Line 3: warning: exported type DaemonConfig should have comment or be unexported (golint)
    • Line 8: warning: exported type Providers should have comment or be unexported (golint)
    • Line 21: warning: exported type Aws should have comment or be unexported (golint)
    • Line 27: warning: exported type Gcloud should have comment or be unexported (golint)
    • Line 33: warning: exported type Vsphere should have comment or be unexported (golint)
    • Line 43: warning: exported type Photon should have comment or be unexported (golint)
    • Line 49: warning: exported type Virtualbox should have comment or be unexported (golint)
    • Line 55: warning: exported type Qemu should have comment or be unexported (golint)
    • Line 60: warning: exported type Firecracker should have comment or be unexported (golint)
    • Line 69: warning: exported type Ukvm should have comment or be unexported (golint)
    • Line 74: warning: exported type Xen should have comment or be unexported (golint)
    • Line 80: warning: exported type Openstack should have comment or be unexported (golint)
    • Line 99: warning: exported type VirtualboxAdapterType should have comment or be unexported (golint)
    • Line 102: warning: exported const BridgedAdapter should have comment (or a comment on this block) or be unexported (golint)
    • Line 106: warning: exported type ClientConfig should have comment or be unexported (golint)
    • Line 110: warning: exported type HubConfig should have comment or be unexported (golint)
    • unik/pkg/compilers/osv/osv_java.go
    • Line 14: warning: exported type OSvJavaCompiler should have comment or be unexported (golint)
    • Line 25: warning: exported method OSvJavaCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 68: warning: exported method OSvJavaCompiler.Usage should have comment or be unexported (golint)
    • unik/pkg/compilers/mirage/mirage.go
    • Line 23: warning: exported type Type should have comment or be unexported (golint)
    • Line 26: warning: exported const XenType should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type MirageCompiler should have comment or be unexported (golint)
    • Line 35: warning: exported method MirageCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 218: warning: exported method MirageCompiler.Usage should have comment or be unexported (golint)
    • Line 218: warning: receiver name r should be consistent with previous receiver name c for MirageCompiler (golint)
    • unik/pkg/providers/virtualbox/virtualboxclient/client.go
    • Line 16: warning: exported type VboxVm should have comment or be unexported (golint)
    • Line 24: warning: exported type VboxDevice should have comment or be unexported (golint)
    • Line 131: warning: exported function Vms should have comment or be unexported (golint)
    • Line 169: warning: exported function GetVm should have comment or be unexported (golint)
    • Line 181: warning: exported function CreateVm should have comment or be unexported (golint)
    • Line 227: warning: exported function CreateVmNatless should have comment or be unexported (golint)
    • Line 259: warning: exported function ConfigureVmNetwork should have comment or be unexported (golint)
    • Line 275: warning: exported function DestroyVm should have comment or be unexported (golint)
    • Line 282: warning: exported function PowerOnVm should have comment or be unexported (golint)
    • Line 287: warning: exported function PowerOffVm should have comment or be unexported (golint)
    • Line 292: warning: exported function RefreshDiskUUID should have comment or be unexported (golint)
    • Line 297: warning: exported function AttachDisk should have comment or be unexported (golint)
    • Line 309: warning: exported function DetachDisk should have comment or be unexported (golint)
    • unik/pkg/providers/gcloud/stage.go
    • Line 20: warning: exported method GcloudProvider.Stage should have comment or be unexported (golint)
    • Line 30: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/providers/ukvm/stage.go
    • Line 14: warning: exported method UkvmProvider.Stage should have comment or be unexported (golint)
    • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/daemon/daemon.go
    • Line 48: warning: exported type UnikDaemon should have comment or be unexported (golint)
    • Line 56: warning: don't use underscores in Go names; const aws_provider should be awsProvider (golint)
    • Line 57: warning: don't use underscores in Go names; const vsphere_provider should be vsphereProvider (golint)
    • Line 58: warning: don't use underscores in Go names; const virtualbox_provider should be virtualboxProvider (golint)
    • Line 59: warning: don't use underscores in Go names; const qemu_provider should be qemuProvider (golint)
    • Line 60: warning: don't use underscores in Go names; const photon_provider should be photonProvider (golint)
    • Line 61: warning: don't use underscores in Go names; const xen_provider should be xenProvider (golint)
    • Line 62: warning: don't use underscores in Go names; const ukvm_provider should be ukvmProvider (golint)
    • Line 63: warning: don't use underscores in Go names; const gcloud_provider should be gcloudProvider (golint)
    • Line 64: warning: don't use underscores in Go names; const openstack_provider should be openstackProvider (golint)
    • Line 65: warning: don't use underscores in Go names; const firecracker_provider should be firecrackerProvider (golint)
    • Line 68: warning: exported function NewUnikDaemon should have comment or be unexported (golint)
    • Line 160: warning: don't use underscores in Go names; var orig_pass should be origPass (golint)
    • Line 427: warning: exported method UnikDaemon.Run should have comment or be unexported (golint)
    • Line 431: warning: exported method UnikDaemon.Stop should have comment or be unexported (golint)
    • Line 1250: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
    • unik/pkg/compilers/firecracker/firecracker-go.go
    • Line 13: warning: exported type FirecrackerCompiler should have comment or be unexported (golint)
    • Line 15: warning: exported method FirecrackerCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 41: warning: exported method FirecrackerCompiler.Usage should have comment or be unexported (golint)
    • unik/pkg/types/params.go
    • Line 5: warning: exported type RunInstanceParams should have comment or be unexported (golint)
    • Line 15: warning: exported type StageImageParams should have comment or be unexported (golint)
    • Line 22: warning: exported type CreateVolumeParams should have comment or be unexported (golint)
    • Line 28: warning: exported type CompileImageParams should have comment or be unexported (golint)
    • Line 36: warning: exported type PullImagePararms should have comment or be unexported (golint)
    • Line 42: warning: exported type PushImagePararms should have comment or be unexported (golint)
    • Line 47: warning: exported type RemoteDeleteImagePararms should have comment or be unexported (golint)
    • unik/pkg/os/device_linux.go
    • Line 18: warning: exported function Mount should have comment or be unexported (golint)
    • Line 21: warning: exported function MountDevice should have comment or be unexported (golint)
    • Line 36: warning: exported function Umount should have comment or be unexported (golint)
    • Line 61: warning: exported type MsDosPartioner should have comment or be unexported (golint)
    • Line 65: warning: exported method MsDosPartioner.MakeTable should have comment or be unexported (golint)
    • Line 70: warning: exported method MsDosPartioner.MakePart should have comment or be unexported (golint)
    • Line 75: warning: exported method MsDosPartioner.MakePartTillEnd should have comment or be unexported (golint)
    • Line 80: warning: exported method MsDosPartioner.Makebootable should have comment or be unexported (golint)
    • Line 85: warning: exported type DiskLabelPartioner should have comment or be unexported (golint)
    • Line 89: warning: exported method DiskLabelPartioner.MakeTable should have comment or be unexported (golint)
    • Line 94: warning: exported method DiskLabelPartioner.MakePart should have comment or be unexported (golint)
    • Line 99: warning: exported function ListParts should have comment or be unexported (golint)
    • Line 217: warning: exported type PartedPart should have comment or be unexported (golint)
    • Line 224: warning: exported method PartedPart.Size should have comment or be unexported (golint)
    • Line 227: warning: exported method PartedPart.Offset should have comment or be unexported (golint)
    • Line 231: warning: exported method PartedPart.Acquire should have comment or be unexported (golint)
    • Line 236: warning: exported method PartedPart.Release should have comment or be unexported (golint)
    • Line 243: warning: exported method PartedPart.Get should have comment or be unexported (golint)
    • Line 251: warning: comment on exported type LoDevice should be of the form "LoDevice ..." (with optional leading article) (golint)
    • Line 259: warning: exported function NewLoDevice should have comment or be unexported (golint)
    • Line 262: warning: exported function NewPartLoDevice should have comment or be unexported (golint)
    • Line 266: warning: exported method LoDevice.Acquire should have comment or be unexported (golint)
    • Line 290: warning: exported method LoDevice.Get should have comment or be unexported (golint)
    • Line 294: warning: exported method LoDevice.Release should have comment or be unexported (golint)
    • Line 298: warning: exported method LoDevice.Size should have comment or be unexported (golint)
    • Line 302: warning: exported method LoDevice.Offset should have comment or be unexported (golint)
    • unik/pkg/providers/xen/xenclient/client.go
    • Line 43: warning: exported type XenClient should have comment or be unexported (golint)
    • Line 48: warning: exported type CreateVmParams should have comment or be unexported (golint)
    • Line 57: warning: exported type VolumeConfig should have comment or be unexported (golint)
    • Line 62: warning: exported method XenClient.CreateVm should have comment or be unexported (golint)
    • Line 81: warning: exported method XenClient.DestroyVm should have comment or be unexported (golint)
    • Line 88: warning: exported method XenClient.ListVms should have comment or be unexported (golint)
    • unik/pkg/providers/vsphere/delete_volume.go
    • Line 7: warning: exported method VsphereProvider.DeleteVolume should have comment or be unexported (golint)
    • Line 16: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • unik/pkg/providers/gcloud/gcloud_provider.go
    • Line 16: warning: exported function GcloudStateFile should have comment or be unexported (golint)
    • Line 20: warning: exported type GcloudProvider should have comment or be unexported (golint)
    • Line 27: warning: exported function NewGcloudProvier should have comment or be unexported (golint)
    • Line 55: warning: exported method GcloudProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/providers/aws/stage.go
    • Line 28: warning: exported method AwsProvider.Stage should have comment or be unexported (golint)
    • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • unik/pkg/types/types.go
    • Line 8: warning: exported type InstanceState should have comment or be unexported (golint)
    • Line 11: warning: don't use underscores in Go names; const InstanceState_Running should be InstanceStateRunning (golint)
    • Line 11: warning: exported const InstanceState_Running should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: don't use underscores in Go names; const InstanceState_Stopped should be InstanceStateStopped (golint)
    • Line 13: warning: don't use underscores in Go names; const InstanceState_Pending should be InstanceStatePending (golint)
    • Line 14: warning: don't use underscores in Go names; const InstanceState_Unknown should be InstanceStateUnknown (golint)
    • Line 15: warning: don't use underscores in Go names; const InstanceState_Terminated should be InstanceStateTerminated (golint)
    • Line 16: warning: don't use underscores in Go names; const InstanceState_Error should be InstanceStateError (golint)
    • Line 17: warning: don't use underscores in Go names; const InstanceState_Paused should be InstanceStatePaused (golint)
    • Line 18: warning: don't use underscores in Go names; const InstanceState_Suspended should be InstanceStateSuspended (golint)
    • Line 21: warning: exported type Infrastructure should have comment or be unexported (golint)
    • Line 24: warning: don't use underscores in Go names; const Infrastructure_AWS should be InfrastructureAWS (golint)
    • Line 24: warning: exported const Infrastructure_AWS should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: don't use underscores in Go names; const Infrastructure_GCLOUD should be InfrastructureGCLOUD (golint)
    • Line 26: warning: don't use underscores in Go names; const Infrastructure_VSPHERE should be InfrastructureVSPHERE (golint)
    • Line 27: warning: don't use underscores in Go names; const Infrastructure_VIRTUALBOX should be InfrastructureVIRTUALBOX (golint)
    • Line 28: warning: don't use underscores in Go names; const Infrastructure_QEMU should be InfrastructureQEMU (golint)
    • Line 29: warning: don't use underscores in Go names; const Infrastructure_PHOTON should be InfrastructurePHOTON (golint)
    • Line 30: warning: don't use underscores in Go names; const Infrastructure_XEN should be InfrastructureXEN (golint)
    • Line 31: warning: don't use underscores in Go names; const Infrastructure_OPENSTACK should be InfrastructureOPENSTACK (golint)
    • Line 32: warning: don't use underscores in Go names; const Infrastructure_UKVM should be InfrastructureUKVM (golint)
    • Line 33: warning: don't use underscores in Go names; const Infrastructure_FIRECRACKER should be InfrastructureFIRECRACKER (golint)
    • Line 36: warning: exported type Image should have comment or be unexported (golint)
    • Line 46: warning: comment on exported type UserImage should be of the form "UserImage ..." (with optional leading article) (golint)
    • Line 59: warning: exported type Instance should have comment or be unexported (golint)
    • Line 76: warning: exported type Volume should have comment or be unexported (golint)
    • Line 92: warning: exported type RawImage should have comment or be unexported (golint)
    • Line 98: warning: exported type ImageFormat should have comment or be unexported (golint)
    • Line 101: warning: don't use underscores in Go names; const ImageFormat_RAW should be ImageFormatRAW (golint)
    • Line 101: warning: exported const ImageFormat_RAW should have comment (or a comment on this block) or be unexported (golint)
    • Line 102: warning: don't use underscores in Go names; const ImageFormat_QCOW2 should be ImageFormatQCOW2 (golint)
    • Line 103: warning: don't use underscores in Go names; const ImageFormat_VHD should be ImageFormatVHD (golint)
    • Line 104: warning: don't use underscores in Go names; const ImageFormat_VMDK should be ImageFormatVMDK (golint)
    • Line 105: warning: don't use underscores in Go names; const ImageFormat_Folder should be ImageFormatFolder (golint)
    • Line 108: warning: exported type XenVirtualizationType should have comment or be unexported (golint)
    • Line 111: warning: don't use underscores in Go names; const XenVirtualizationType_HVM should be XenVirtualizationTypeHVM (golint)
    • Line 111: warning: exported const XenVirtualizationType_HVM should have comment (or a comment on this block) or be unexported (golint)
    • Line 112: warning: don't use underscores in Go names; const XenVirtualizationType_Paravirtual should be XenVirtualizationTypeParavirtual (golint)
    • Line 115: warning: exported type StageSpec should have comment or be unexported (golint)
    • Line 120: warning: exported type StorageDriver should have comment or be unexported (golint)
    • Line 123: warning: don't use underscores in Go names; const StorageDriver_SCSI should be StorageDriverSCSI (golint)
    • Line 123: warning: exported const StorageDriver_SCSI should have comment (or a comment on this block) or be unexported (golint)
    • Line 124: warning: don't use underscores in Go names; const StorageDriver_SATA should be StorageDriverSATA (golint)
    • Line 125: warning: don't use underscores in Go names; const StorageDriver_IDE should be StorageDriverIDE (golint)
    • Line 128: warning: exported type VsphereNetworkType should have comment or be unexported (golint)
    • Line 131: warning: don't use underscores in Go names; const VsphereNetworkType_E1000 should be VsphereNetworkTypeE1000 (golint)
    • Line 131: warning: exported const VsphereNetworkType_E1000 should have comment (or a comment on this block) or be unexported (golint)
    • Line 132: warning: don't use underscores in Go names; const VsphereNetworkType_VMXNET3 should be VsphereNetworkTypeVMXNET3 (golint)
    • Line 135: warning: exported type RunSpec should have comment or be unexported (golint)
    • Line 145: warning: exported type DeviceMapping should have comment or be unexported (golint)
    • unik/pkg/compilers/osv/osv_node.go
    • Line 8: warning: exported type OSvNodeCompiler should have comment or be unexported (golint)
    • Line 12: warning: exported method OSvNodeCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 41: warning: exported method OSvNodeCompiler.Usage should have comment or be unexported (golint)
    • unik/pkg/providers/photon/photon_provider.go
    • Line 16: warning: exported type PhotonProvider should have comment or be unexported (golint)
    • Line 24: warning: exported function PhotonStateFile should have comment or be unexported (golint)
    • Line 40: warning: exported function NewPhotonProvider should have comment or be unexported (golint)
    • Line 65: warning: exported method PhotonProvider.WithState should have comment or be unexported (golint)
    • unik/containers/compilers/rump/go/gopatches/runtime/malloc.go
    • Line 163: warning: don't use underscores in Go names; const _MHeapMap_TotalBits should be _MHeapMapTotalBits (golint)
    • Line 165: warning: don't use underscores in Go names; const _MHeapMap_Bits should be _MHeapMapBits (golint)
    • Line 366: warning: don't use underscores in Go names; var _g_ should be _g (golint)
    • Line 393: warning: don't use underscores in Go names; func mHeap_SysAlloc should be mHeapSysAlloc (golint)
    • Line 397: warning: don't use underscores in Go names; var p_size should be pSize (golint)
    • Line 398: warning: don't use underscores in Go names; var new_end should be newEnd (golint)
    • Line 448: warning: don't use underscores in Go names; var p_size should be pSize (golint)
    • Line 460: warning: don't use underscores in Go names; var p_end should be pEnd (golint)
    • Line 767: warning: don't use underscores in Go names; func reflect_unsafe_New should be reflectUnsafeNew (golint)
    • Line 784: warning: don't use underscores in Go names; func reflect_unsafe_NewArray should be reflectUnsafeNewArray (golint)
    • unik/pkg/providers/aws/delete_volume.go
    • Line 9: warning: exported method AwsProvider.DeleteVolume should have comment or be unexported (golint)
    • Line 18: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • unik/pkg/compilers/osv/osv_aws.go
    • Line 7: warning: exported const OSV_AWS_MEMORY should have comment or be unexported (golint)
    • Line 9: warning: exported type AwsImageFinisher should have comment or be unexported (golint)
    • Line 11: warning: exported method AwsImageFinisher.FinishImage should have comment or be unexported (golint)
    • Line 27: warning: exported method AwsImageFinisher.UseEc2 should have comment or be unexported (golint)
    • unik/pkg/providers/virtualbox/virtualbox_provider.go
    • Line 16: warning: exported function VirtualboxStateFile should have comment or be unexported (golint)
    • Line 29: warning: exported const VboxUnikInstanceListener should have comment or be unexported (golint)
    • Line 32: warning: exported type VirtualboxProvider should have comment or be unexported (golint)
    • Line 38: warning: exported function NewVirtualboxProvider should have comment or be unexported (golint)
    • Line 72: warning: exported method VirtualboxProvider.WithState should have comment or be unexported (golint)
    • unik/pkg/state/base_state.go
    • Line 24: warning: exported function NewBasicState should have comment or be unexported (golint)
    • Line 33: warning: exported function BasicStateFromFile should have comment or be unexported (golint)
    • unik/pkg/compilers/includeos/includeos_qemu.go
    • Line 15: warning: exported type IncludeosQemuCompiler should have comment or be unexported (golint)
    • Line 17: warning: exported method IncludeosQemuCompiler.CompileRawImage should have comment or be unexported (golint)
    • Line 55: warning: exported method IncludeosQemuCompiler.Usage should have comment or be unexported (golint)
    • Line 55: warning: receiver name r should be consistent with previous receiver name i for IncludeosQemuCompiler (golint)

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • unik/pkg/daemon/daemon.go
    • Line 436: warning: cyclomatic complexity 108 of function (*UnikDaemon).initialize() is high (> 15) (gocyclo)
    • Line 68: warning: cyclomatic complexity 31 of function NewUnikDaemon() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!