Preparing report...

Report for github.com/geohot/minikeyvalue

D    Needs lots of improvement    Found 8 issues across 8 files

Tweet

gofmt0%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo75%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint25%

Golint is a linter for Go source code.

    • minikeyvalue/src/rebalance.go
    • Line 10: warning: exported type RebalanceRequest should have comment or be unexported (golint)
    • Line 22: warning: don't use underscores in Go names; var remote_test should be remoteTest (golint)
    • Line 46: warning: don't use underscores in Go names; var remote_from should be remoteFrom (golint)
    • Line 57: warning: don't use underscores in Go names; var needs_write should be needsWrite (golint)
    • Line 66: warning: don't use underscores in Go names; var remote_to should be remoteTo (golint)
    • Line 82: warning: don't use underscores in Go names; var delete_error should be deleteError (golint)
    • Line 84: warning: don't use underscores in Go names; var needs_delete should be needsDelete (golint)
    • Line 92: warning: don't use underscores in Go names; var remote_del should be remoteDel (golint)
    • Line 105: warning: exported method App.Rebalance should have comment or be unexported (golint)
    • minikeyvalue/src/rebuild.go
    • Line 13: warning: exported type File should have comment or be unexported (golint)
    • Line 19: warning: exported type RebuildRequest should have comment or be unexported (golint)
    • Line 24: warning: don't use underscores in Go names; func get_files should be getFiles (golint)
    • Line 106: warning: exported method App.Rebuild should have comment or be unexported (golint)
    • Line 130: warning: don't use underscores in Go names; var parse_volume should be parseVolume (golint)
    • Line 145: warning: don't use underscores in Go names; var has_subvolumes should be hasSubvolumes (golint)
    • minikeyvalue/src/server.go
    • Line 18: warning: exported type ListResponse should have comment or be unexported (golint)
    • Line 23: warning: exported method App.QueryHandler should have comment or be unexported (golint)
    • Line 229: warning: don't use underscores in Go names; var delete_error should be deleteError (golint)
    • minikeyvalue/tools/thrasher.go
    • Line 16: warning: don't use underscores in Go names; func remote_delete should be remoteDelete (golint)
    • Line 32: warning: don't use underscores in Go names; func remote_put should be remotePut (golint)
    • Line 49: warning: don't use underscores in Go names; func remote_get should be remoteGet (golint)
    • Line 56: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • minikeyvalue/src/lib.go
    • Line 18: warning: comment on exported type Deleted should be of the form "Deleted ..." (with optional leading article) (golint)
    • Line 21: warning: exported const NO should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported type Record should have comment or be unexported (golint)
    • Line 119: warning: don't use underscores in Go names; func needs_rebalance should be needsRebalance (golint)
    • Line 134: warning: don't use underscores in Go names; func remote_delete should be remoteDelete (golint)
    • Line 150: warning: don't use underscores in Go names; func remote_put should be remotePut (golint)
    • Line 167: warning: don't use underscores in Go names; func remote_get should be remoteGet (golint)
    • Line 174: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 183: warning: don't use underscores in Go names; func remote_head should be remoteHead (golint)
    • minikeyvalue/src/main.go
    • Line 16: warning: exported type App should have comment or be unexported (golint)
    • Line 31: warning: exported method App.UnlockKey should have comment or be unexported (golint)
    • Line 37: warning: exported method App.LockKey should have comment or be unexported (golint)
    • Line 47: warning: exported method App.GetRecord should have comment or be unexported (golint)
    • Line 54: warning: exported method App.PutRecord should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!