Preparing report...

Report for github.com/gmarik/gorack

B    Not bad!    Found 9 issues across 10 files

Tweet

gofmt70%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint40%

Golint is a linter for Go source code.

    • gorack/rack_request.go
    • Line 11: warning: exported type RackRequest should have comment or be unexported (golint)
    • Line 17: warning: exported function NewRackRequest should have comment or be unexported (golint)
    • Line 49: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • Line 54: warning: don't use underscores in Go names; range var sort_key should be sortKey (golint)
    • Line 64: warning: exported method RackRequest.WriteTo should have comment or be unexported (golint)
    • Line 64: warning: receiver name r should be consistent with previous receiver name rr for RackRequest (golint)
    • Line 79: warning: don't use underscores in Go names; func http_header should be httpHeader (golint)
    • gorack/rack_response.go
    • Line 16: warning: exported type RackResponse should have comment or be unexported (golint)
    • Line 23: warning: exported function NewRackResponse should have comment or be unexported (golint)
    • Line 27: warning: exported method RackResponse.Parse should have comment or be unexported (golint)
    • Line 109: warning: exported method RackResponse.WriteTo should have comment or be unexported (golint)
    • Line 114: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
    • gorack/main/gorack-server.go
    • Line 26: warning: don't use underscores in Go names; var config_path should be configPath (golint)
    • Line 27: warning: don't use underscores in Go names; var listen_address should be listenAddress (golint)
    • gorack/ipcio/ipcio.go
    • Line 8: warning: exported function RecvIo should have comment or be unexported (golint)
    • Line 28: warning: comment on exported function SendIo should be of the form "SendIo ..." (golint)
    • gorack/log_writer.go
    • Line 8: warning: exported type LogWriter should have comment or be unexported (golint)
    • Line 13: warning: exported function NewLogWriter should have comment or be unexported (golint)
    • gorack/rack_handler.go
    • Line 16: warning: exported var GoRackExec should have comment or be unexported (golint)
    • Line 18: warning: exported type RackHandler should have comment or be unexported (golint)
    • Line 19: warning: don't use underscores in Go names; struct field local_fd should be localFd (golint)
    • Line 24: warning: exported function NewRackHandler should have comment or be unexported (golint)
    • Line 47: warning: don't use underscores in Go names; var res_reader should be resReader (golint)
    • Line 47: warning: don't use underscores in Go names; var req_writer should be reqWriter (golint)
    • Line 84: warning: don't use underscores in Go names; var req_reader should be reqReader (golint)
    • Line 84: warning: don't use underscores in Go names; var req_writer should be reqWriter (golint)
    • Line 85: warning: don't use underscores in Go names; var res_reader should be resReader (golint)
    • Line 85: warning: don't use underscores in Go names; var res_writer should be resWriter (golint)
    • Line 114: warning: exported method RackHandler.StartRackProcess should have comment or be unexported (golint)
    • Line 123: warning: exported method RackHandler.StopRackProcess should have comment or be unexported (golint)

license0%

Checks whether your project has a LICENSE file.


ineffassign80%

IneffAssign detects ineffectual assignments in Go code.


misspell80%

Misspell Finds commonly misspelled English words