Go Report Card

Preparing report...

Report for github.com/gogap/aop

A    Great!    Found 13 issues across 14 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • aop/pointcut.go
    • Line 81: warning: cyclomatic complexity 20 of function (*Pointcut).IsMatch() is high (> 15) (gocyclo)
    • aop/aop.go
    • Line 30: warning: cyclomatic complexity 24 of function (*AOP).funcWrapper() is high (> 15) (gocyclo)

golint7%

Golint is a linter for Go source code.

    • aop/pointcut.go
    • Line 10: warning: exported type Pointcut should have comment or be unexported (golint)
    • Line 23: warning: exported method Pointcut.Execution should have comment or be unexported (golint)
    • Line 31: warning: exported method Pointcut.NotExecution should have comment or be unexported (golint)
    • Line 39: warning: exported method Pointcut.Bean should have comment or be unexported (golint)
    • Line 47: warning: exported method Pointcut.NotBean should have comment or be unexported (golint)
    • Line 55: warning: exported method Pointcut.Within should have comment or be unexported (golint)
    • Line 63: warning: exported method Pointcut.NotWithin should have comment or be unexported (golint)
    • Line 71: warning: exported function NewPointcut should have comment or be unexported (golint)
    • Line 77: warning: exported method Pointcut.ID should have comment or be unexported (golint)
    • Line 81: warning: exported method Pointcut.IsMatch should have comment or be unexported (golint)
    • aop/trace.go
    • Line 15: warning: exported type TraceItem should have comment or be unexported (golint)
    • Line 26: warning: exported type Trace should have comment or be unexported (golint)
    • Line 54: warning: exported method Trace.Items should have comment or be unexported (golint)
    • Line 58: warning: exported function StartTrace should have comment or be unexported (golint)
    • Line 73: warning: exported function StopTrace should have comment or be unexported (golint)
    • Line 88: warning: exported function IsTracing should have comment or be unexported (golint)
    • aop/example/main.go
    • Line 9: warning: exported type Auth should have comment or be unexported (golint)
    • Line 12: warning: exported method Auth.Login should have comment or be unexported (golint)
    • Line 20: warning: comment on exported method Auth.Before should be of the form "Before ..." (golint)
    • Line 30: warning: comment on exported method Auth.After should be of the form "After ..." (golint)
    • Line 35: warning: comment on exported method Auth.Around should be of the form "Around ..." (golint)
    • Line 47: warning: exported type Foo should have comment or be unexported (golint)
    • Line 50: warning: comment on exported method Foo.Bar should be of the form "Bar ..." (golint)
    • aop/advice.go
    • Line 3: warning: exported type AdviceOrdering should have comment or be unexported (golint)
    • Line 6: warning: exported const Before should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type Advice should have comment or be unexported (golint)
    • aop/aop.go
    • Line 12: warning: exported type AOP should have comment or be unexported (golint)
    • Line 17: warning: exported function NewAOP should have comment or be unexported (golint)
    • Line 21: warning: exported method AOP.SetBeanFactory should have comment or be unexported (golint)
    • Line 25: warning: exported method AOP.AddAspect should have comment or be unexported (golint)
    • Line 167: warning: exported method AOP.GetProxy should have comment or be unexported (golint)
    • aop/aspect.go
    • Line 7: warning: exported type Aspect should have comment or be unexported (golint)
    • Line 17: warning: exported function NewAspect should have comment or be unexported (golint)
    • Line 33: warning: exported method Aspect.ID should have comment or be unexported (golint)
    • Line 37: warning: exported method Aspect.BeanRefID should have comment or be unexported (golint)
    • Line 41: warning: exported method Aspect.AddPointcut should have comment or be unexported (golint)
    • Line 49: warning: exported method Aspect.AddAdvice should have comment or be unexported (golint)
    • Line 74: warning: exported method Aspect.SetBeanFactory should have comment or be unexported (golint)
    • Line 79: warning: exported method Aspect.GetMatchedAdvices should have comment or be unexported (golint)
    • aop/bean.go
    • Line 9: warning: exported type Bean should have comment or be unexported (golint)
    • Line 15: warning: exported function NewBean should have comment or be unexported (golint)
    • Line 46: warning: exported method Bean.ID should have comment or be unexported (golint)
    • Line 50: warning: exported method Bean.Class should have comment or be unexported (golint)
    • Line 69: warning: exported method Bean.Invoke should have comment or be unexported (golint)
    • Line 103: warning: exported method Bean.Call should have comment or be unexported (golint)
    • aop/method_metadata.go
    • Line 7: warning: exported type MethodMetadata should have comment or be unexported (golint)
    • Line 13: warning: exported method MethodMetadata.IsEqual should have comment or be unexported (golint)
    • aop/bean_factory.go
    • Line 7: warning: exported type BeanFactory should have comment or be unexported (golint)
    • Line 12: warning: exported type BeanFactoryAware should have comment or be unexported (golint)
    • Line 16: warning: exported type ClassicBeanFactory should have comment or be unexported (golint)
    • Line 20: warning: exported function NewClassicBeanFactory should have comment or be unexported (golint)
    • Line 26: warning: exported method ClassicBeanFactory.GetBean should have comment or be unexported (golint)
    • Line 39: warning: exported method ClassicBeanFactory.RegisterBean should have comment or be unexported (golint)
    • aop/errors.go
    • Line 8: warning: exported const AOPErrorNamespace should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported var ErrBeanInstanceIsNil should have comment or be unexported (golint)
    • aop/invoke_result.go
    • Line 10: warning: exported type Result should have comment or be unexported (golint)
    • Line 11: warning: exported type Args should have comment or be unexported (golint)
    • Line 13: warning: exported method Result.MapTo should have comment or be unexported (golint)
    • Line 17: warning: exported method Args.MapTo should have comment or be unexported (golint)
    • Line 42: warning: exported type InvokeResult should have comment or be unexported (golint)
    • Line 51: warning: exported method InvokeResult.End should have comment or be unexported (golint)
    • Line 86: warning: exported method InvokeResult.MethodName should have comment or be unexported (golint)
    • Line 90: warning: exported method InvokeResult.BeanID should have comment or be unexported (golint)
    • aop/join_point.go
    • Line 22: warning: exported type JoinPointer should have comment or be unexported (golint)
    • Line 28: warning: exported type ProceedingJoinPointer should have comment or be unexported (golint)
    • Line 34: warning: exported type JoinPoint should have comment or be unexported (golint)
    • Line 40: warning: exported method JoinPoint.CallID should have comment or be unexported (golint)
    • Line 44: warning: exported method JoinPoint.Args should have comment or be unexported (golint)
    • Line 48: warning: exported method JoinPoint.Target should have comment or be unexported (golint)
    • Line 52: warning: exported type ProceedingJoinPoint should have comment or be unexported (golint)
    • Line 58: warning: exported method ProceedingJoinPoint.Args should have comment or be unexported (golint)
    • Line 62: warning: exported method ProceedingJoinPoint.Target should have comment or be unexported (golint)
    • Line 66: warning: exported method ProceedingJoinPoint.Proceed should have comment or be unexported (golint)
    • aop/proxy.go
    • Line 9: warning: exported type Proxy should have comment or be unexported (golint)
    • Line 14: warning: exported function NewProxy should have comment or be unexported (golint)
    • Line 21: warning: exported method Proxy.BeanID should have comment or be unexported (golint)
    • Line 25: warning: exported method Proxy.Method should have comment or be unexported (golint)
    • Line 41: warning: exported method Proxy.Invoke should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign78%

IneffAssign detects ineffectual assignments in Go code.

    • aop/example/main.go
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: could not import github.com/gogap/aop (invalid package name: "") (ineffassign)
    • aop/aspect.go
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/gogap/errors (invalid package name: "") (ineffassign)
    • aop/aop.go
    • Line 4: warning: cannot find package "." in: (ineffassign)
    • Line 4: warning: could not import github.com/rs/xid (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!