gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• netstack/tcpip/iptables/iptables.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• netstack/tcpip/iptables/types.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• netstack/tcpip/link/fdbased/endpoint_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• netstack/tcpip/stack/transport_demuxer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• netstack/tcpip/transport/udp/endpoint.go
  • Line 457: warning: cyclomatic complexity 46 of function (*endpoint).SetSockOpt() is high (> 15) (gocyclo)
  • Line 334: warning: cyclomatic complexity 24 of function (*endpoint).write() is high (> 15) (gocyclo)
  • Line 685: warning: cyclomatic complexity 20 of function (*endpoint).GetSockOpt() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/endpoint.go
  • Line 1215: warning: cyclomatic complexity 37 of function (*endpoint).SetSockOpt() is high (> 15) (gocyclo)
  • Line 1458: warning: cyclomatic complexity 32 of function (*endpoint).GetSockOpt() is high (> 15) (gocyclo)
  • Line 1675: warning: cyclomatic complexity 27 of function (*endpoint).connect() is high (> 15) (gocyclo)
  • Line 77: warning: cyclomatic complexity 17 of function (EndpointState).String() is high (> 15) (gocyclo)
  • Line 1133: warning: cyclomatic complexity 17 of function (*endpoint).SetSockOptInt() is high (> 15) (gocyclo)

• netstack/tcpip/network/ipv6/icmp.go
  • Line 63: warning: cyclomatic complexity 37 of function (*endpoint).handleICMP() is high (> 15) (gocyclo)

• netstack/tcpip/adapters/gonet/gonet_test.go
  • Line 276: warning: cyclomatic complexity 16 of function TestCloseWrite() is high (> 15) (gocyclo)

• netstack/tcpip/sample/tun_tcp_echo/main.go
  • Line 71: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

• netstack/tcpip/transport/icmp/endpoint.go
  • Line 231: warning: cyclomatic complexity 21 of function (*endpoint).write() is high (> 15) (gocyclo)

• netstack/tcpip/network/ipv4/icmp.go
  • Line 56: warning: cyclomatic complexity 18 of function (*endpoint).handleICMP() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/snd.go
  • Line 1043: warning: cyclomatic complexity 28 of function (*sender).handleRcvdSegment() is high (> 15) (gocyclo)
  • Line 598: warning: cyclomatic complexity 22 of function (*sender).maybeSendSegment() is high (> 15) (gocyclo)
  • Line 791: warning: cyclomatic complexity 18 of function (*sender).sendData() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/tcp_noracedetector_test.go
  • Line 36: warning: cyclomatic complexity 17 of function DisabledTestFastRecovery() is high (> 15) (gocyclo)

• netstack/tcpip/sample/tun_tcp_connect/main.go
  • Line 95: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• netstack/tcpip/header/ndp_test.go
  • Line 277: warning: cyclomatic complexity 17 of function TestNDPPrefixInformationOption() is high (> 15) (gocyclo)

• netstack/tcpip/stack/stack_test.go
  • Line 719: warning: cyclomatic complexity 24 of function TestEndpointExpiration() is high (> 15) (gocyclo)
  • Line 2056: warning: cyclomatic complexity 24 of function TestNewPEBOnPromotionToPermanent() is high (> 15) (gocyclo)

• netstack/tcpip/stack/stack.go
  • Line 1005: warning: cyclomatic complexity 22 of function (*Stack).FindRoute() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/tcp_sack_test.go
  • Line 363: warning: cyclomatic complexity 19 of function TestSACKRecovery() is high (> 15) (gocyclo)

• netstack/tcpip/link/sniffer/sniffer.go
  • Line 292: warning: cyclomatic complexity 44 of function logPacket() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/tcp_test.go
  • Line 3780: warning: cyclomatic complexity 43 of function TestConnectAvoidsBoundPorts() is high (> 15) (gocyclo)
  • Line 4341: warning: cyclomatic complexity 18 of function TestListenBacklogFull() is high (> 15) (gocyclo)
  • Line 4947: warning: cyclomatic complexity 17 of function TestEndpointBindListenAcceptState() is high (> 15) (gocyclo)
  • Line 3420: warning: cyclomatic complexity 16 of function TestReusePort() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/rcv.go
  • Line 113: warning: cyclomatic complexity 18 of function (*receiver).consumeSegment() is high (> 15) (gocyclo)
  • Line 262: warning: cyclomatic complexity 16 of function (*receiver).handleRcvdSegmentClosing() is high (> 15) (gocyclo)

• netstack/tcpip/transport/raw/endpoint.go
  • Line 221: warning: cyclomatic complexity 18 of function (*endpoint).write() is high (> 15) (gocyclo)

• netstack/tcpip/tcpip.go
  • Line 1157: warning: cyclomatic complexity 17 of function (Address).String() is high (> 15) (gocyclo)

• netstack/tcpip/stack/ndp.go
  • Line 472: warning: cyclomatic complexity 32 of function (*ndpState).handleRA() is high (> 15) (gocyclo)

• netstack/tcpip/stack/ndp_test.go
  • Line 593: warning: cyclomatic complexity 25 of function TestSetNDPConfigurations() is high (> 15) (gocyclo)
  • Line 233: warning: cyclomatic complexity 20 of function TestDADResolve() is high (> 15) (gocyclo)
  • Line 911: warning: cyclomatic complexity 18 of function TestRouterDiscovery() is high (> 15) (gocyclo)
  • Line 1228: warning: cyclomatic complexity 18 of function TestPrefixDiscovery() is high (> 15) (gocyclo)

• netstack/tcpip/stack/transport_demuxer_test.go
  • Line 186: warning: cyclomatic complexity 17 of function TestDistribution() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/protocol.go
  • Line 175: warning: cyclomatic complexity 20 of function (*protocol).SetOption() is high (> 15) (gocyclo)

• netstack/tcpip/link/fdbased/endpoint_test.go
  • Line 139: warning: cyclomatic complexity 18 of function testWritePacket() is high (> 15) (gocyclo)

• netstack/tcpip/header/tcp.go
  • Line 318: warning: cyclomatic complexity 23 of function ParseSynOptions() is high (> 15) (gocyclo)
  • Line 399: warning: cyclomatic complexity 16 of function ParseTCPOptions() is high (> 15) (gocyclo)

• netstack/tcpip/stack/transport_test.go
  • Line 546: warning: cyclomatic complexity 16 of function TestTransportForwarding() is high (> 15) (gocyclo)

• netstack/tcpip/stack/nic.go
  • Line 740: warning: cyclomatic complexity 16 of function (*NIC).DeliverNetworkPacket() is high (> 15) (gocyclo)

• netstack/tcpip/transport/tcp/connect.go
  • Line 1088: warning: cyclomatic complexity 36 of function (*endpoint).protocolMainLoop() is high (> 15) (gocyclo)
  • Line 441: warning: cyclomatic complexity 18 of function (*handshake).execute() is high (> 15) (gocyclo)

• netstack/tcpip/checker/checker.go
  • Line 369: warning: cyclomatic complexity 30 of function TCPSynOptions() is high (> 15) (gocyclo)
  • Line 465: warning: cyclomatic complexity 19 of function TCPTimestampChecker() is high (> 15) (gocyclo)

golint96%

Golint is a linter for Go source code.

• netstack/tcpip/iptables/types.go
  • Line 139: warning: should omit 2nd value from range; this loop is equivalent to `for hook := range ...` (golint)

• netstack/tcpip/transport/raw/endpoint.go
  • Line 513: warning: receiver name ep should be consistent with previous receiver name e for endpoint (golint)

• netstack/tcpip/link/fdbased/endpoint_test.go
  • Line 442: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)

• netstack/tcpip/stack/nic.go
  • Line 550: warning: comment on exported method NIC.AddressRanges should be of the form "AddressRanges ..." (golint)

• netstack/tcpip/stack/stack.go
  • Line 812: warning: comment on exported method Stack.NICAddressRanges should be of the form "NICAddressRanges ..." (golint)

• netstack/tcpip/transport/tcp/accept.go
  • Line 440: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell95%

Misspell Finds commonly misspelled English words

• netstack/tcpip/stack/ndp.go
  • Line 100: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 289: warning: "attemped" is a misspelling of "attempted" (misspell)
  • Line 352: warning: "occured" is a misspelling of "occurred" (misspell)

• netstack/tcpip/stack/stack.go
  • Line 463: warning: "determins" is a misspelling of "determines" (misspell)

• netstack/tcpip/transport/tcp/rcv.go
  • Line 416: warning: "assasination" is a misspelling of "assassination" (misspell)

• netstack/tcpip/transport/tcp/snd.go
  • Line 540: warning: "determinig" is a misspelling of "determining" (misspell)
  • Line 977: warning: "oustanding" is a misspelling of "outstanding" (misspell)

• netstack/tcpip/link/fdbased/endpoint.go
  • Line 470: warning: "bondary" is a misspelling of "boundary" (misspell)

• netstack/tcpip/header/ipv4.go
  • Line 103: warning: "procotol" is a misspelling of "protocol" (misspell)

• netstack/tcpip/header/ndp_options.go
  • Line 41: warning: "becuase" is a misspelling of "because" (misspell)
  • Line 124: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 159: warning: "erroenous" is a misspelling of "erroneous" (misspell)