Preparing report...

Report for github.com/intelsdi-x/snap

(v0.16.1-beta)

A    Great!    Found 128 issues across 241 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt51%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • core/task.go
    • Line 169: warning: cyclomatic complexity 17 of function (*TaskCreationRequest).UnmarshalJSON() is high (> 15) (gocyclo)
    • control/control.go
    • Line 288: warning: cyclomatic complexity 20 of function (*pluginControl).Start() is high (> 15) (gocyclo)
    • Line 878: warning: cyclomatic complexity 16 of function (*pluginControl).CollectMetrics() is high (> 15) (gocyclo)
    • mgmt/tribe/tribe_test.go
    • Line 726: warning: cyclomatic complexity 35 of function TestTribePluginAgreement() is high (> 15) (gocyclo)
    • Line 441: warning: cyclomatic complexity 17 of function TestTribeAgreements() is high (> 15) (gocyclo)
    • Line 187: warning: cyclomatic complexity 16 of function TestTribeFullStateSyncOnJoin() is high (> 15) (gocyclo)
    • cmd/snapctl/task.go
    • Line 209: warning: cyclomatic complexity 20 of function (*task).setScheduleFromCliOptions() is high (> 15) (gocyclo)
    • snapd.go
    • Line 222: warning: cyclomatic complexity 39 of function action() is high (> 15) (gocyclo)
    • Line 876: warning: cyclomatic complexity 21 of function (*Config).UnmarshalJSON() is high (> 15) (gocyclo)
    • mgmt/tribe/delegate.go
    • Line 248: warning: cyclomatic complexity 34 of function (*delegate).MergeRemoteState() is high (> 15) (gocyclo)
    • Line 41: warning: cyclomatic complexity 30 of function (*delegate).NotifyMsg() is high (> 15) (gocyclo)
    • Line 163: warning: cyclomatic complexity 26 of function (*delegate).LocalState() is high (> 15) (gocyclo)
    • control/config.go
    • Line 496: warning: cyclomatic complexity 30 of function unmarshalPluginConfig() is high (> 15) (gocyclo)
    • Line 146: warning: cyclomatic complexity 21 of function (*Config).UnmarshalJSON() is high (> 15) (gocyclo)
    • Line 335: warning: cyclomatic complexity 16 of function (*pluginConfig).mergePluginConfigDataNode() is high (> 15) (gocyclo)
    • control/plugin/rpc/plugin.go
    • Line 93: warning: cyclomatic complexity 26 of function ToConfigPolicy() is high (> 15) (gocyclo)
    • Line 19: warning: cyclomatic complexity 19 of function NewGetConfigPolicyReply() is high (> 15) (gocyclo)
    • mgmt/rest/tribe_test.go
    • Line 152: warning: cyclomatic complexity 44 of function TestTribeTaskAgreements() is high (> 15) (gocyclo)
    • Line 459: warning: cyclomatic complexity 33 of function TestTribePluginAgreements() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell98%

Misspell Finds commonly misspelled English words