Report for github.com/jfbus/impressionist
A+ Excellent! Found 22 issues across 25 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint16%
Golint is a linter for Go source code.
-
-
impressionist/request/request.go
- Line 16: warning: exported type Request should have comment or be unexported (golint)
- Line 24: warning: exported function ParseRequest should have comment or be unexported (golint)
-
-
impressionist/provider/magick/provider.go
- Line 12: warning: exported type Provider should have comment or be unexported (golint)
- Line 14: warning: exported method Provider.Decode should have comment or be unexported (golint)
- Line 19: warning: exported method Provider.WriterMap should have comment or be unexported (golint)
- Line 26: warning: exported method Provider.FilterMap should have comment or be unexported (golint)
-
-
impressionist/storage/cache.go
- Line 11: warning: exported function InitCache should have comment or be unexported (golint)
-
-
impressionist/filter/filter.go
- Line 9: warning: exported type Image should have comment or be unexported (golint)
- Line 11: warning: exported type Filter should have comment or be unexported (golint)
- Line 15: warning: exported type Chain should have comment or be unexported (golint)
- Line 17: warning: exported method Chain.Apply should have comment or be unexported (golint)
-
-
impressionist/filter/predefined.go
- Line 10: warning: exported function Init should have comment or be unexported (golint)
-
-
impressionist/log/log.go
- Line 10: warning: exported function Init should have comment or be unexported (golint)
- Line 16: warning: exported function WithContext should have comment or be unexported (golint)
- Line 20: warning: exported function WithRequestId should have comment or be unexported (golint)
- Line 24: warning: exported function WithField should have comment or be unexported (golint)
- Line 28: warning: exported function WithFields should have comment or be unexported (golint)
- Line 32: warning: exported function Debugf should have comment or be unexported (golint)
- Line 36: warning: exported function Infof should have comment or be unexported (golint)
- Line 40: warning: exported function Printf should have comment or be unexported (golint)
- Line 44: warning: exported function Warnf should have comment or be unexported (golint)
- Line 48: warning: exported function Warningf should have comment or be unexported (golint)
- Line 52: warning: exported function Errorf should have comment or be unexported (golint)
- Line 56: warning: exported function Fatalf should have comment or be unexported (golint)
- Line 60: warning: exported function Panicf should have comment or be unexported (golint)
- Line 64: warning: exported function Debug should have comment or be unexported (golint)
- Line 68: warning: exported function Info should have comment or be unexported (golint)
- Line 72: warning: exported function Print should have comment or be unexported (golint)
- Line 76: warning: exported function Warn should have comment or be unexported (golint)
- Line 80: warning: exported function Warning should have comment or be unexported (golint)
- Line 84: warning: exported function Error should have comment or be unexported (golint)
- Line 88: warning: exported function Fatal should have comment or be unexported (golint)
- Line 92: warning: exported function Panic should have comment or be unexported (golint)
- Line 96: warning: exported function Debugln should have comment or be unexported (golint)
- Line 100: warning: exported function Infoln should have comment or be unexported (golint)
- Line 104: warning: exported function Println should have comment or be unexported (golint)
- Line 108: warning: exported function Warnln should have comment or be unexported (golint)
- Line 112: warning: exported function Warningln should have comment or be unexported (golint)
- Line 116: warning: exported function Errorln should have comment or be unexported (golint)
- Line 120: warning: exported function Fatalln should have comment or be unexported (golint)
- Line 124: warning: exported function Panicln should have comment or be unexported (golint)
-
-
impressionist/storage/storage.go
- Line 12: warning: exported var ErrStorageNotFound should have comment or be unexported (golint)
- Line 15: warning: exported function Init should have comment or be unexported (golint)
- Line 27: warning: exported function Get should have comment or be unexported (golint)
-
-
impressionist/provider/pure/filter.go
- Line 14: warning: exported type Crop should have comment or be unexported (golint)
- Line 18: warning: exported method Crop.Apply should have comment or be unexported (golint)
- Line 22: warning: exported function CropBuilder should have comment or be unexported (golint)
- Line 33: warning: exported type Resize should have comment or be unexported (golint)
- Line 38: warning: exported method Resize.Apply should have comment or be unexported (golint)
- Line 64: warning: exported function ResizeBuilder should have comment or be unexported (golint)
- Line 80: warning: exported type Apply should have comment or be unexported (golint)
- Line 84: warning: exported method Apply.Apply should have comment or be unexported (golint)
- Line 88: warning: exported function GrayscaleBuilder should have comment or be unexported (golint)
- Line 92: warning: exported function FlipBuilder should have comment or be unexported (golint)
- Line 105: warning: exported function RotateBuilder should have comment or be unexported (golint)
- Line 120: warning: exported type Blur should have comment or be unexported (golint)
- Line 124: warning: exported method Blur.Apply should have comment or be unexported (golint)
- Line 128: warning: exported function BlurBuilder should have comment or be unexported (golint)
-
-
impressionist/request/worker.go
- Line 11: warning: exported type Job should have comment or be unexported (golint)
- Line 18: warning: exported type JobResponse should have comment or be unexported (golint)
- Line 25: warning: exported function InitWorkers should have comment or be unexported (golint)
- Line 40: warning: exported function Work should have comment or be unexported (golint)
-
-
impressionist/filter/parse.go
- Line 13: warning: exported var ErrFilterNotFound should have comment or be unexported (golint)
- Line 18: warning: exported type FilterBuilder should have comment or be unexported (golint)
- Line 20: warning: exported function Parse should have comment or be unexported (golint)
- Line 47: warning: exported function ParseRect should have comment or be unexported (golint)
- Line 64: warning: exported function ParseDimensions should have comment or be unexported (golint)
- Line 83: warning: exported function ParseModifier should have comment or be unexported (golint)
-
-
impressionist/config/config.go
- Line 12: warning: exported type HttpConfig should have comment or be unexported (golint)
- Line 20: warning: exported type FilterConfig should have comment or be unexported (golint)
- Line 25: warning: exported type ImageConfig should have comment or be unexported (golint)
- Line 29: warning: exported type StorageConfig should have comment or be unexported (golint)
- Line 35: warning: exported type CacheConfig should have comment or be unexported (golint)
- Line 39: warning: exported type Config should have comment or be unexported (golint)
- Line 62: warning: exported function Load should have comment or be unexported (golint)
- Line 85: warning: exported function Get should have comment or be unexported (golint)
-
-
impressionist/provider/pure/provider.go
- Line 12: warning: exported type Provider should have comment or be unexported (golint)
- Line 14: warning: exported method Provider.Decode should have comment or be unexported (golint)
- Line 19: warning: exported method Provider.WriterMap should have comment or be unexported (golint)
- Line 26: warning: exported method Provider.FilterMap should have comment or be unexported (golint)
-
-
impressionist/request/middleware.go
- Line 12: warning: comment on exported type Logger should be of the form "Logger ..." (with optional leading article) (golint)
- Line 17: warning: comment on exported function NewLogger should be of the form "NewLogger ..." (golint)
-
-
impressionist/img/image.go
- Line 3: warning: exported type Img should have comment or be unexported (golint)
-
-
impressionist/provider/provider.go
- Line 10: warning: exported type Writer should have comment or be unexported (golint)
- Line 14: warning: exported type Provider should have comment or be unexported (golint)
- Line 22: warning: exported function Set should have comment or be unexported (golint)
- Line 26: warning: exported function Decode should have comment or be unexported (golint)
- Line 29: warning: exported function GetFilterMap should have comment or be unexported (golint)
- Line 32: warning: exported function GetWriter should have comment or be unexported (golint)
-
-
impressionist/provider/magick/filter.go
- Line 12: warning: exported type Crop should have comment or be unexported (golint)
- Line 16: warning: exported method Crop.Apply should have comment or be unexported (golint)
- Line 20: warning: exported function CropBuilder should have comment or be unexported (golint)
- Line 31: warning: exported type Resize should have comment or be unexported (golint)
- Line 36: warning: exported method Resize.Apply should have comment or be unexported (golint)
- Line 51: warning: exported function ResizeBuilder should have comment or be unexported (golint)
- Line 67: warning: exported type Grayscale should have comment or be unexported (golint)
- Line 69: warning: exported method Grayscale.Apply should have comment or be unexported (golint)
- Line 73: warning: exported function GrayscaleBuilder should have comment or be unexported (golint)
- Line 77: warning: exported type Flip should have comment or be unexported (golint)
- Line 79: warning: exported method Flip.Apply should have comment or be unexported (golint)
- Line 83: warning: exported type Flop should have comment or be unexported (golint)
- Line 85: warning: exported method Flop.Apply should have comment or be unexported (golint)
- Line 89: warning: exported function FlipBuilder should have comment or be unexported (golint)
-
-
impressionist/provider/magick/writer.go
- Line 10: warning: exported type PNGWriter should have comment or be unexported (golint)
- Line 19: warning: exported type JPEGWriter should have comment or be unexported (golint)
-
-
impressionist/storage/read.go
- Line 12: warning: exported var ErrFileNotFound should have comment or be unexported (golint)
- Line 13: warning: exported var ErrAccessDenied should have comment or be unexported (golint)
- Line 15: warning: exported function Read should have comment or be unexported (golint)
-
-
impressionist/provider/pure/writer.go
- Line 12: warning: exported type PNGWriter should have comment or be unexported (golint)
- Line 18: warning: exported type JPEGWriter should have comment or be unexported (golint)
-
-
impressionist/context/context.go
- Line 10: warning: exported var ErrTimeout should have comment or be unexported (golint)
- Line 12: warning: exported function New should have comment or be unexported (golint)
- Line 13: warning: should not use basic type untyped string as key in context.WithValue (golint)
- Line 16: warning: exported function DoWithTimeOut should have comment or be unexported (golint)
-
-
impressionist/request/handler.go
- Line 17: warning: exported var ErrBadRequest should have comment or be unexported (golint)
- Line 20: warning: exported function Display should have comment or be unexported (golint)
- Line 50: warning: exported function Error should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell96%
Misspell Finds commonly misspelled English words
-
-
impressionist/filter/parse_test.go
- Line 12: warning: "dimention" is a misspelling of "dimension" (misspell)