gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• quorum/crypto/bls12381/bls12_381.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• quorum/crypto/bls12381/isogeny.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• quorum/node/utils_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint69%

Golint is a linter for Go source code.

• quorum/cmd/geth/config.go
  • Line 287: warning: comment on exported function QuorumSetupPrivacyConfiguration should be of the form "QuorumSetupPrivacyConfiguration ..." (golint)

• quorum/internal/flags/helpers.go
  • Line 28: warning: exported var CommandHelpTemplate should have comment or be unexported (golint)
  • Line 110: warning: comment on exported type ByCategory should be of the form "ByCategory ..." (with optional leading article) (golint)
  • Line 132: warning: exported function FlagCategory should have comment or be unexported (golint)

• quorum/extension/services_factory.go
  • Line 13: warning: exported type ServicesFactory should have comment or be unexported (golint)
  • Line 19: warning: exported type DefaultServicesFactory should have comment or be unexported (golint)
  • Line 26: warning: exported function NewServicesFactory should have comment or be unexported (golint)
  • Line 48: warning: exported method DefaultServicesFactory.AccountManager should have comment or be unexported (golint)
  • Line 52: warning: exported method DefaultServicesFactory.DataHandler should have comment or be unexported (golint)
  • Line 56: warning: exported method DefaultServicesFactory.StateFetcher should have comment or be unexported (golint)

• quorum/eth/downloader/downloader.go
  • Line 42: warning: exported var MaxHashFetch should have comment or be unexported (golint)
  • Line 98: warning: exported type Downloader should have comment or be unexported (golint)

• quorum/log/format.go
  • Line 54: warning: exported type Format should have comment or be unexported (golint)

• quorum/rpc/constants_unix.go
  • Line 32: warning: don't use underscores in Go names; var max_path_size should be maxPathSize (golint)

• quorum/p2p/enode/urlv4.go
  • Line 203: warning: exported function HexPubkey should have comment or be unexported (golint)
  • Line 223: warning: comment on exported method Node.EnodeID should be of the form "EnodeID ..." (golint)
  • Line 241: warning: exported method Node.URLv4 should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/types/message.go
  • Line 16: warning: comment on exported function MessageCodes should be of the form "MessageCodes ..." (golint)
  • Line 26: warning: comment on exported type QBFTMessage should be of the form "QBFTMessage ..." (with optional leading article) (golint)

• quorum/core/mps/interface.go
  • Line 25: warning: exported type PrivateStateMetadataResolver should have comment or be unexported (golint)

• quorum/extension/privacyExtension/state_setter_test.go
  • Line 1: warning: don't use MixedCaps in package name; privacyExtension should be privacyextension (golint)

• quorum/light/lightchain.go
  • Line 126: warning: exported function NewMultitenantLightChain should have comment or be unexported (golint)
  • Line 239: warning: exported method LightChain.StateCache should have comment or be unexported (golint)
  • Line 451: warning: comment on exported method LightChain.GetTdOdr should be of the form "GetTdOdr ..." (golint)
  • Line 481: warning: receiver name bc should be consistent with previous receiver name lc for LightChain (golint)
  • Line 598: warning: exported method LightChain.SupportsMultitenancy should have comment or be unexported (golint)

• quorum/light/txpool.go
  • Line 449: warning: comment on exported method TxPool.AddBatch should be of the form "AddBatch ..." (golint)

• quorum/internal/ethapi/addrlock.go
  • Line 25: warning: exported type AddrLocker should have comment or be unexported (golint)

• quorum/p2p/enr/entries.go
  • Line 61: warning: exported method TCP.ENRKey should have comment or be unexported (golint)
  • Line 63: warning: comment on exported type TCP6 should be of the form "TCP6 ..." (with optional leading article) (golint)
  • Line 66: warning: exported method TCP6.ENRKey should have comment or be unexported (golint)
  • Line 71: warning: exported method UDP.ENRKey should have comment or be unexported (golint)
  • Line 73: warning: comment on exported type UDP6 should be of the form "UDP6 ..." (with optional leading article) (golint)
  • Line 76: warning: exported method UDP6.ENRKey should have comment or be unexported (golint)
  • Line 81: warning: exported const IDv4 should have comment or be unexported (golint)
  • Line 83: warning: exported method ID.ENRKey should have comment or be unexported (golint)
  • Line 90: warning: exported method IP.ENRKey should have comment or be unexported (golint)
  • Line 97: warning: comment on exported type RaftPort should be of the form "RaftPort ..." (with optional leading article) (golint)
  • Line 101: warning: exported method RaftPort.ENRKey should have comment or be unexported (golint)
  • Line 103: warning: exported type Hostname should have comment or be unexported (golint)
  • Line 105: warning: exported method Hostname.ENRKey should have comment or be unexported (golint)
  • Line 132: warning: exported method IPv4.ENRKey should have comment or be unexported (golint)
  • Line 157: warning: exported method IPv6.ENRKey should have comment or be unexported (golint)

• quorum/consensus/protocol.go
  • Line 1: warning: package comment should be of the form "Package consensus ..." (golint)
  • Line 24: warning: exported var IstanbulProtocol should have comment or be unexported (golint)
  • Line 38: warning: comment on exported var EthProtocol should be of the form "EthProtocol ..." (golint)

• quorum/cmd/utils/flags.go
  • Line 117: warning: comment on exported var DataDirFlag should be of the form "DataDirFlag ..." (golint)
  • Line 123: warning: exported var RaftLogDirFlag should have comment or be unexported (golint)
  • Line 231: warning: comment on exported var LightServeFlag should be of the form "LightServeFlag ..." (golint)
  • Line 270: warning: comment on exported var EthashCacheDirFlag should be of the form "EthashCacheDirFlag ..." (golint)
  • Line 308: warning: comment on exported var TxPoolLocalsFlag should be of the form "TxPoolLocalsFlag ..." (golint)
  • Line 362: warning: comment on exported var CacheFlag should be of the form "CacheFlag ..." (golint)
  • Line 402: warning: comment on exported var MiningEnabledFlag should be of the form "MiningEnabledFlag ..." (golint)
  • Line 449: warning: comment on exported var UnlockedAccountFlag should be of the form "UnlockedAccountFlag ..." (golint)
  • Line 483: warning: comment on exported var EthStatsURLFlag should be of the form "EthStatsURLFlag ..." (golint)
  • Line 496: warning: comment on exported var RPCClientToken should be of the form "RPCClientToken ..." (golint)
  • Line 517: warning: comment on exported var IPCDisabledFlag should be of the form "IPCDisabledFlag ..." (golint)
  • Line 602: warning: comment on exported var MaxPeersFlag should be of the form "MaxPeersFlag ..." (golint)
  • Line 653: warning: comment on exported var JSpathFlag should be of the form "JSpathFlag ..." (golint)
  • Line 660: warning: comment on exported var GpoBlocksFlag should be of the form "GpoBlocksFlag ..." (golint)
  • Line 695: warning: comment on exported var MetricsEnabledFlag should be of the form "MetricsEnabledFlag ..." (golint)
  • Line 743: warning: comment on exported var MetricsInfluxDBTagsFlag should be of the form "MetricsInfluxDBTagsFlag ..." (golint)
  • Line 763: warning: comment on exported var EVMCallTimeOutFlag should be of the form "EVMCallTimeOutFlag ..." (golint)
  • Line 770: warning: comment on exported var QuorumImmutabilityThreshold should be of the form "QuorumImmutabilityThreshold ..." (golint)
  • Line 777: warning: comment on exported var RaftModeFlag should be of the form "RaftModeFlag ..." (golint)
  • Line 807: warning: comment on exported var EnableNodePermissionFlag should be of the form "EnableNodePermissionFlag ..." (golint)
  • Line 817: warning: comment on exported var PluginSettingsFlag should be of the form "PluginSettingsFlag ..." (golint)
  • Line 834: warning: comment on exported var AccountPluginNewAccountConfigFlag should be of the form "AccountPluginNewAccountConfigFlag ..." (golint)
  • Line 839: warning: comment on exported var IstanbulRequestTimeoutFlag should be of the form "IstanbulRequestTimeoutFlag ..." (golint)
  • Line 850: warning: comment on exported var MultitenancyFlag should be of the form "MultitenancyFlag ..." (golint)
  • Line 856: warning: comment on exported var RevertReasonFlag should be of the form "RevertReasonFlag ..." (golint)
  • Line 862: warning: comment on exported var PrivateCacheTrieJournalFlag should be of the form "PrivateCacheTrieJournalFlag ..." (golint)
  • Line 869: warning: comment on exported var QuorumPTMUnixSocketFlag should be of the form "QuorumPTMUnixSocketFlag ..." (golint)
  • Line 1326: warning: exported function SetP2PConfig should have comment or be unexported (golint)
  • Line 1495: warning: comment on exported function SetPlugins should be of the form "SetPlugins ..." (golint)
  • Line 1990: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2020: warning: comment on exported function RegisterPluginService should be of the form "RegisterPluginService ..." (golint)
  • Line 2038: warning: comment on exported function RegisterPermissionService should be of the form "RegisterPermissionService ..." (golint)
  • Line 2052: warning: exported function RegisterRaftService should have comment or be unexported (golint)
  • Line 2100: warning: exported function RegisterExtensionService should have comment or be unexported (golint)
  • Line 2109: warning: exported function SetupMetrics should have comment or be unexported (golint)
  • Line 2137: warning: exported function SplitTagsFlag should have comment or be unexported (golint)
  • Line 2176: warning: exported function MakeGenesis should have comment or be unexported (golint)

• quorum/p2p/discover/v4wire/v4wire.go
  • Line 47: warning: comment on exported type Ping should be of the form "Ping ..." (with optional leading article) (golint)
  • Line 85: warning: comment on exported type ENRRequest should be of the form "ENRRequest ..." (with optional leading article) (golint)
  • Line 92: warning: comment on exported type ENRResponse should be of the form "ENRResponse ..." (with optional leading article) (golint)
  • Line 101: warning: comment on exported const MaxNeighbors should be of the form "MaxNeighbors ..." (golint)
  • Line 159: warning: exported type Packet should have comment or be unexported (golint)
  • Line 165: warning: exported method Ping.Name should have comment or be unexported (golint)
  • Line 166: warning: exported method Ping.Kind should have comment or be unexported (golint)
  • Line 167: warning: exported method Ping.ENRSeq should have comment or be unexported (golint)
  • Line 169: warning: exported method Pong.Name should have comment or be unexported (golint)
  • Line 170: warning: exported method Pong.Kind should have comment or be unexported (golint)
  • Line 171: warning: exported method Pong.ENRSeq should have comment or be unexported (golint)
  • Line 173: warning: exported method Findnode.Name should have comment or be unexported (golint)
  • Line 174: warning: exported method Findnode.Kind should have comment or be unexported (golint)
  • Line 176: warning: exported method Neighbors.Name should have comment or be unexported (golint)
  • Line 177: warning: exported method Neighbors.Kind should have comment or be unexported (golint)
  • Line 179: warning: exported method ENRRequest.Name should have comment or be unexported (golint)
  • Line 180: warning: exported method ENRRequest.Kind should have comment or be unexported (golint)
  • Line 182: warning: exported method ENRResponse.Name should have comment or be unexported (golint)
  • Line 183: warning: exported method ENRResponse.Kind should have comment or be unexported (golint)
  • Line 208: warning: exported var ErrPacketTooSmall should have comment or be unexported (golint)

• quorum/permission/core/types/contract.go
  • Line 29: warning: exported type ContractBackend should have comment or be unexported (golint)
  • Line 37: warning: exported type RoleService should have comment or be unexported (golint)
  • Line 42: warning: comment on exported type OrgService should be of the form "OrgService ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported type NodeService should be of the form "NodeService ..." (with optional leading article) (golint)
  • Line 59: warning: comment on exported type AccountService should be of the form "AccountService ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported type ControlService should be of the form "ControlService ..." (with optional leading article) (golint)
  • Line 75: warning: comment on exported type AuditService should be of the form "AuditService ..." (with optional leading article) (golint)
  • Line 81: warning: exported type InitService should have comment or be unexported (golint)
  • Line 122: warning: exported function BindContract should have comment or be unexported (golint)

• quorum/plugin/security/connector.go
  • Line 13: warning: exported const TLSConfigurationConnectorName should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported type TLSConfigurationSourcePluginConnector should have comment or be unexported (golint)
  • Line 21: warning: exported method TLSConfigurationSourcePluginConnector.GRPCServer should have comment or be unexported (golint)
  • Line 25: warning: exported method TLSConfigurationSourcePluginConnector.GRPCClient should have comment or be unexported (golint)
  • Line 31: warning: exported type AuthenticationManagerPluginConnector should have comment or be unexported (golint)
  • Line 35: warning: exported method AuthenticationManagerPluginConnector.GRPCServer should have comment or be unexported (golint)
  • Line 39: warning: exported method AuthenticationManagerPluginConnector.GRPCClient should have comment or be unexported (golint)

• quorum/raft/handler.go
  • Line 37: warning: exported type ProtocolManager should have comment or be unexported (golint)
  • Line 102: warning: exported function NewProtocolManager should have comment or be unexported (golint)
  • Line 134: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 141: warning: exported method ProtocolManager.Start should have comment or be unexported (golint)
  • Line 151: warning: exported method ProtocolManager.Stop should have comment or be unexported (golint)
  • Line 190: warning: exported method ProtocolManager.NodeInfo should have comment or be unexported (golint)
  • Line 329: warning: exported method ProtocolManager.ProposeNewPeer should have comment or be unexported (golint)
  • Line 374: warning: exported method ProtocolManager.ProposePeerRemoval should have comment or be unexported (golint)
  • Line 385: warning: exported method ProtocolManager.PromoteToPeer should have comment or be unexported (golint)
  • Line 405: warning: exported method ProtocolManager.WriteMsg should have comment or be unexported (golint)
  • Line 417: warning: exported method ProtocolManager.Process should have comment or be unexported (golint)
  • Line 421: warning: exported method ProtocolManager.IsIDRemoved should have comment or be unexported (golint)
  • Line 425: warning: exported method ProtocolManager.ReportUnreachable should have comment or be unexported (golint)
  • Line 431: warning: exported method ProtocolManager.ReportSnapshot should have comment or be unexported (golint)
  • Line 1072: warning: comment on exported method ProtocolManager.LeaderAddress should be of the form "LeaderAddress ..." (golint)
  • Line 1086: warning: comment on exported method ProtocolManager.FetchRaftId should be of the form "FetchRaftId ..." (golint)

• quorum/raft/peer.go
  • Line 14: warning: comment on exported type Address should be of the form "Address ..." (with optional leading article) (golint)
  • Line 30: warning: exported type ClusterInfo should have comment or be unexported (golint)
  • Line 62: warning: comment on exported type Peer should be of the form "Peer ..." (with optional leading article) (golint)

• quorum/les/lespay/client/api.go
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/metrics/gauge.go
  • Line 5: warning: comment on exported type Gauge should be of the form "Gauge ..." (with optional leading article) (golint)

• quorum/permission/core/types/backend.go
  • Line 31: warning: comment on exported type PermissionConfig should be of the form "PermissionConfig ..." (with optional leading article) (golint)
  • Line 52: warning: exported var ErrInvalidInput should have comment or be unexported (golint)
  • Line 87: warning: comment on exported type InterfaceBackend should be of the form "InterfaceBackend ..." (with optional leading article) (golint)
  • Line 94: warning: exported method InterfaceBackend.SetIsRaft should have comment or be unexported (golint)
  • Line 98: warning: exported function NewInterfaceBackend should have comment or be unexported (golint)
  • Line 102: warning: exported method InterfaceBackend.Node should have comment or be unexported (golint)
  • Line 106: warning: exported method InterfaceBackend.IsRaft should have comment or be unexported (golint)
  • Line 110: warning: exported method InterfaceBackend.DataDir should have comment or be unexported (golint)
  • Line 114: warning: comment on exported type StopEvent should be of the form "StopEvent ..." (with optional leading article) (golint)
  • Line 118: warning: comment on exported var StopFeed should be of the form "StopFeed ..." (golint)
  • Line 122: warning: exported type NodeOperation should have comment or be unexported (golint)
  • Line 125: warning: exported const NodeAdd should have comment (or a comment on this block) or be unexported (golint)
  • Line 129: warning: exported type Backend should have comment or be unexported (golint)
  • Line 156: warning: comment on exported function UpdateFile should be of the form "UpdateFile ..." (golint)
  • Line 200: warning: comment on exported function UpdateDisallowedNodes should be of the form "UpdateDisallowedNodes ..." (golint)
  • Line 216: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 222: warning: comment on exported function DisconnectNode should be of the form "DisconnectNode ..." (golint)
  • Line 253: warning: comment on exported function UpdatePermissionedNodes should be of the form "UpdatePermissionedNodes ..." (golint)
  • Line 274: warning: comment on exported function SubscribeStopEvent should be of the form "SubscribeStopEvent ..." (golint)
  • Line 281: warning: comment on exported function ParsePermissionConfig should be of the form "ParsePermissionConfig ..." (golint)
  • Line 327: warning: comment on exported function GetNodeDetails should be of the form "GetNodeDetails ..." (golint)
  • Line 348: warning: exported method PermissionConfig.IsEmpty should have comment or be unexported (golint)

• quorum/signer/core/stdioui.go
  • Line 27: warning: exported type StdIOUI should have comment or be unexported (golint)
  • Line 31: warning: exported function NewStdIOUI should have comment or be unexported (golint)
  • Line 40: warning: exported method StdIOUI.RegisterUIServer should have comment or be unexported (golint)
  • Line 63: warning: exported method StdIOUI.ApproveTx should have comment or be unexported (golint)
  • Line 69: warning: exported method StdIOUI.ApproveSignData should have comment or be unexported (golint)
  • Line 75: warning: exported method StdIOUI.ApproveListing should have comment or be unexported (golint)
  • Line 81: warning: exported method StdIOUI.ApproveNewAccount should have comment or be unexported (golint)
  • Line 87: warning: exported method StdIOUI.ShowError should have comment or be unexported (golint)
  • Line 94: warning: exported method StdIOUI.ShowInfo should have comment or be unexported (golint)
  • Line 100: warning: exported method StdIOUI.OnApprovedTx should have comment or be unexported (golint)
  • Line 107: warning: exported method StdIOUI.OnSignerStartup should have comment or be unexported (golint)
  • Line 113: warning: exported method StdIOUI.OnInputRequired should have comment or be unexported (golint)

• quorum/crypto/blake2b/blake2b.go
  • Line 26: warning: comment on exported const BlockSize should be of the form "BlockSize ..." (golint)
  • Line 28: warning: comment on exported const Size should be of the form "Size ..." (golint)
  • Line 30: warning: comment on exported const Size384 should be of the form "Size384 ..." (golint)
  • Line 32: warning: comment on exported const Size256 should be of the form "Size256 ..." (golint)

• quorum/extension/client.go
  • Line 12: warning: exported type Client should have comment or be unexported (golint)
  • Line 20: warning: exported type InProcessClient should have comment or be unexported (golint)
  • Line 24: warning: exported function NewInProcessClient should have comment or be unexported (golint)
  • Line 30: warning: exported method InProcessClient.SubscribeToLogs should have comment or be unexported (golint)
  • Line 36: warning: exported method InProcessClient.NextNonce should have comment or be unexported (golint)
  • Line 40: warning: exported method InProcessClient.TransactionByHash should have comment or be unexported (golint)
  • Line 45: warning: exported method InProcessClient.TransactionInBlock should have comment or be unexported (golint)
  • Line 49: warning: exported method InProcessClient.Close should have comment or be unexported (golint)

• quorum/internal/cmdtest/test_cmd.go
  • Line 38: warning: exported function NewTestCmd should have comment or be unexported (golint)
  • Line 42: warning: exported type TestCmd should have comment or be unexported (golint)
  • Line 89: warning: exported method TestCmd.SetTemplateFunc should have comment or be unexported (golint)
  • Line 187: warning: exported method TestCmd.WaitExit should have comment or be unexported (golint)
  • Line 191: warning: exported method TestCmd.Interrupt should have comment or be unexported (golint)
  • Line 218: warning: exported method TestCmd.CloseStdin should have comment or be unexported (golint)
  • Line 222: warning: exported method TestCmd.Kill should have comment or be unexported (golint)

• quorum/mobile/ethereum.go
  • Line 50: warning: exported method CallMsg.GetFrom should have comment or be unexported (golint)
  • Line 51: warning: exported method CallMsg.GetGas should have comment or be unexported (golint)
  • Line 52: warning: exported method CallMsg.GetGasPrice should have comment or be unexported (golint)
  • Line 53: warning: exported method CallMsg.GetValue should have comment or be unexported (golint)
  • Line 54: warning: exported method CallMsg.GetData should have comment or be unexported (golint)
  • Line 55: warning: exported method CallMsg.GetTo should have comment or be unexported (golint)
  • Line 62: warning: exported method CallMsg.SetFrom should have comment or be unexported (golint)
  • Line 63: warning: exported method CallMsg.SetGas should have comment or be unexported (golint)
  • Line 64: warning: exported method CallMsg.SetGasPrice should have comment or be unexported (golint)
  • Line 65: warning: exported method CallMsg.SetValue should have comment or be unexported (golint)
  • Line 66: warning: exported method CallMsg.SetData should have comment or be unexported (golint)
  • Line 67: warning: exported method CallMsg.SetTo should have comment or be unexported (golint)
  • Line 81: warning: exported method SyncProgress.GetStartingBlock should have comment or be unexported (golint)
  • Line 82: warning: exported method SyncProgress.GetCurrentBlock should have comment or be unexported (golint)
  • Line 83: warning: exported method SyncProgress.GetHighestBlock should have comment or be unexported (golint)
  • Line 84: warning: exported method SyncProgress.GetPulledStates should have comment or be unexported (golint)
  • Line 85: warning: exported method SyncProgress.GetKnownStates should have comment or be unexported (golint)
  • Line 139: warning: exported method FilterQuery.GetFromBlock should have comment or be unexported (golint)
  • Line 140: warning: exported method FilterQuery.GetToBlock should have comment or be unexported (golint)
  • Line 141: warning: exported method FilterQuery.GetAddresses should have comment or be unexported (golint)
  • Line 142: warning: exported method FilterQuery.GetTopics should have comment or be unexported (golint)
  • Line 144: warning: exported method FilterQuery.SetFromBlock should have comment or be unexported (golint)
  • Line 145: warning: exported method FilterQuery.SetToBlock should have comment or be unexported (golint)
  • Line 146: warning: exported method FilterQuery.SetAddresses should have comment or be unexported (golint)
  • Line 147: warning: exported method FilterQuery.SetTopics should have comment or be unexported (golint)

• quorum/plugin/helloworld/service.go
  • Line 5: warning: exported type PluginHelloWorld should have comment or be unexported (golint)
  • Line 9: warning: exported type PluginHelloWorldDeferFunc should have comment or be unexported (golint)
  • Line 11: warning: exported type ReloadablePluginHelloWorld should have comment or be unexported (golint)
  • Line 15: warning: exported method ReloadablePluginHelloWorld.Greeting should have comment or be unexported (golint)

• quorum/les/benchmark.go
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/permission/connection.go
  • Line 47: warning: exported function IsNodePermissioned should have comment or be unexported (golint)

• quorum/extension/backend.go
  • Line 26: warning: exported type PrivacyService should have comment or be unexported (golint)
  • Line 77: warning: exported function New should have comment or be unexported (golint)
  • Line 336: warning: exported method PrivacyService.Start should have comment or be unexported (golint)
  • Line 356: warning: exported method PrivacyService.Stop should have comment or be unexported (golint)
  • Line 363: warning: exported method PrivacyService.GenerateTransactOptions should have comment or be unexported (golint)
  • Line 390: warning: comment on exported method PrivacyService.GetAllParticipants should be of the form "GetAllParticipants ..." (golint)
  • Line 407: warning: comment on exported method PrivacyService.CheckIfContractCreator should be of the form "CheckIfContractCreator ..." (golint)

• quorum/tests/init.go
  • Line 172: warning: comment on exported function AvailableForks should be of the form "AvailableForks ..." (golint)

• quorum/tests/fuzzers/txfetcher/txfetcher_fuzzer.go
  • Line 51: warning: exported function Fuzz should have comment or be unexported (golint)

• quorum/consensus/istanbul/ibft/engine/engine.go
  • Line 28: warning: exported type SignerFn should have comment or be unexported (golint)
  • Line 30: warning: exported type Engine should have comment or be unexported (golint)
  • Line 37: warning: exported function NewEngine should have comment or be unexported (golint)
  • Line 45: warning: exported method Engine.Author should have comment or be unexported (golint)
  • Line 60: warning: exported method Engine.CommitHeader should have comment or be unexported (golint)
  • Line 65: warning: exported method Engine.VerifyBlockProposal should have comment or be unexported (golint)
  • Line 89: warning: exported method Engine.VerifyHeader should have comment or be unexported (golint)
  • Line 264: warning: exported method Engine.Prepare should have comment or be unexported (golint)
  • Line 375: warning: exported method Engine.SealHash should have comment or be unexported (golint)
  • Line 379: warning: exported method Engine.CalcDifficulty should have comment or be unexported (golint)
  • Line 383: warning: exported method Engine.Validators should have comment or be unexported (golint)
  • Line 392: warning: exported method Engine.Signers should have comment or be unexported (golint)
  • Line 414: warning: exported method Engine.Address should have comment or be unexported (golint)
  • Line 418: warning: exported method Engine.WriteVote should have comment or be unexported (golint)
  • Line 429: warning: exported method Engine.ReadVote should have comment or be unexported (golint)

• quorum/consensus/ethash/api.go
  • Line 86: warning: comment on exported method API.SubmitHashRate should be of the form "SubmitHashRate ..." (golint)

• quorum/core/types/derive_sha.go
  • Line 24: warning: exported type DerivableList should have comment or be unexported (golint)
  • Line 36: warning: exported function DeriveSha should have comment or be unexported (golint)

• quorum/extension/state_fetcher.go
  • Line 28: warning: comment on exported type APIBackendHelper should be of the form "APIBackendHelper ..." (with optional leading article) (golint)
  • Line 42: warning: comment on exported function NewStateFetcher should be of the form "NewStateFetcher ..." (golint)
  • Line 94: warning: comment on exported method StateFetcher.GetPrivacyMetaData should be of the form "GetPrivacyMetaData ..." (golint)
  • Line 109: warning: comment on exported method StateFetcher.GetStorageRoot should be of the form "GetStorageRoot ..." (golint)

• quorum/les/odr.go
  • Line 39: warning: exported function NewLesOdr should have comment or be unexported (golint)
  • Line 86: warning: exported const MsgBlockBodies should have comment (or a comment on this block) or be unexported (golint)

• quorum/permission/api.go
  • Line 29: warning: exported const AddOrg should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported type AccountUpdateAction should have comment or be unexported (golint)
  • Line 52: warning: exported const SuspendAccount should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported type NodeUpdateAction should have comment or be unexported (golint)
  • Line 62: warning: exported const SuspendNode should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported type OrgUpdateAction should have comment or be unexported (golint)
  • Line 72: warning: exported const SuspendOrg should have comment (or a comment on this block) or be unexported (golint)
  • Line 81: warning: exported type PendingOpInfo should have comment or be unexported (golint)
  • Line 93: warning: exported method QuorumControlsAPI.OrgList should have comment or be unexported (golint)
  • Line 97: warning: exported method QuorumControlsAPI.NodeList should have comment or be unexported (golint)
  • Line 101: warning: exported method QuorumControlsAPI.RoleList should have comment or be unexported (golint)
  • Line 105: warning: exported method QuorumControlsAPI.AcctList should have comment or be unexported (golint)
  • Line 109: warning: exported method QuorumControlsAPI.GetOrgDetails should have comment or be unexported (golint)
  • Line 153: warning: exported method QuorumControlsAPI.AddOrg should have comment or be unexported (golint)
  • Line 172: warning: exported method QuorumControlsAPI.AddSubOrg should have comment or be unexported (golint)
  • Line 190: warning: exported method QuorumControlsAPI.ApproveOrg should have comment or be unexported (golint)
  • Line 207: warning: exported method QuorumControlsAPI.UpdateOrgStatus should have comment or be unexported (golint)
  • Line 225: warning: exported method QuorumControlsAPI.AddNode should have comment or be unexported (golint)
  • Line 243: warning: exported method QuorumControlsAPI.UpdateNodeStatus should have comment or be unexported (golint)
  • Line 261: warning: exported method QuorumControlsAPI.ApproveOrgStatus should have comment or be unexported (golint)
  • Line 279: warning: exported method QuorumControlsAPI.AssignAdminRole should have comment or be unexported (golint)
  • Line 297: warning: exported method QuorumControlsAPI.ApproveAdminRole should have comment or be unexported (golint)
  • Line 315: warning: exported method QuorumControlsAPI.AddNewRole should have comment or be unexported (golint)
  • Line 333: warning: exported method QuorumControlsAPI.RemoveRole should have comment or be unexported (golint)
  • Line 351: warning: exported method QuorumControlsAPI.AddAccountToOrg should have comment or be unexported (golint)
  • Line 368: warning: exported method QuorumControlsAPI.ChangeAccountRole should have comment or be unexported (golint)
  • Line 386: warning: exported method QuorumControlsAPI.UpdateAccountStatus should have comment or be unexported (golint)
  • Line 404: warning: exported method QuorumControlsAPI.RecoverBlackListedNode should have comment or be unexported (golint)
  • Line 422: warning: exported method QuorumControlsAPI.ApproveBlackListedNodeRecovery should have comment or be unexported (golint)
  • Line 440: warning: exported method QuorumControlsAPI.RecoverBlackListedAccount should have comment or be unexported (golint)
  • Line 458: warning: exported method QuorumControlsAPI.ApproveBlackListedAccountRecovery should have comment or be unexported (golint)
  • Line 476: warning: exported method QuorumControlsAPI.TransactionAllowed should have comment or be unexported (golint)
  • Line 518: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 523: warning: exported method QuorumControlsAPI.ConnectionAllowed should have comment or be unexported (golint)
  • Line 531: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/p2p/discv5/net.go
  • Line 275: warning: exported method Network.RegisterTopic should have comment or be unexported (golint)
  • Line 291: warning: exported method Network.SearchTopic should have comment or be unexported (golint)

• quorum/signer/core/uiapi.go
  • Line 34: warning: comment on exported type UIServerAPI should be of the form "UIServerAPI ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported method UIServerAPI.ListAccounts should be of the form "ListAccounts ..." (golint)
  • Line 186: warning: receiver name api should be consistent with previous receiver name s for UIServerAPI (golint)
  • Line 204: warning: receiver name api should be consistent with previous receiver name s for UIServerAPI (golint)

• quorum/consensus/istanbul/ibft/types/message.go
  • Line 30: warning: exported const MsgPreprepare should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported type Message should have comment or be unexported (golint)
  • Line 75: warning: exported method Message.FromPayload should have comment or be unexported (golint)
  • Line 101: warning: exported method Message.Payload should have comment or be unexported (golint)
  • Line 105: warning: exported method Message.PayloadNoSig should have comment or be unexported (golint)
  • Line 115: warning: exported method Message.Decode should have comment or be unexported (golint)
  • Line 127: warning: exported function Encode should have comment or be unexported (golint)

• quorum/accounts/abi/bind/base.go
  • Line 37: warning: comment on exported type PrivateTxArgs should be of the form "PrivateTxArgs ..." (with optional leading article) (golint)

• quorum/core/types/receipt.go
  • Line 72: warning: comment on exported type QuorumReceiptExtraData should be of the form "QuorumReceiptExtraData ..." (with optional leading article) (golint)
  • Line 456: warning: exported method Receipt.FillReceiptExtraDataFromStorage should have comment or be unexported (golint)
  • Line 570: warning: exported method QuorumReceiptExtraData.DecodeRLP should have comment or be unexported (golint)
  • Line 597: warning: exported method QuorumReceiptExtraData.EncodeRLP should have comment or be unexported (golint)
  • Line 606: warning: exported method QuorumReceiptExtraData.IsEmpty should have comment or be unexported (golint)
  • Line 667: warning: exported type ReceiptForStorageMPSV1 should have comment or be unexported (golint)
  • Line 669: warning: comment on exported method ReceiptForStorageMPSV1.EncodeRLP should be of the form "EncodeRLP ..." (golint)

• quorum/core/types/transaction_signing.go
  • Line 31: warning: exported var ErrInvalidChainId should have comment or be unexported (golint)
  • Line 105: warning: comment on exported type EIP155Signer should be of the form "EIP155Signer ..." (with optional leading article) (golint)
  • Line 110: warning: exported function NewEIP155Signer should have comment or be unexported (golint)
  • Line 120: warning: exported method EIP155Signer.Equal should have comment or be unexported (golint)
  • Line 127: warning: exported method EIP155Signer.Sender should have comment or be unexported (golint)
  • Line 170: warning: comment on exported type HomesteadSigner should be of the form "HomesteadSigner ..." (with optional leading article) (golint)
  • Line 174: warning: exported method HomesteadSigner.Equal should have comment or be unexported (golint)
  • Line 181: warning: receiver name hs should be consistent with previous receiver name s for HomesteadSigner (golint)
  • Line 185: warning: exported method HomesteadSigner.Sender should have comment or be unexported (golint)
  • Line 185: warning: receiver name hs should be consistent with previous receiver name s for HomesteadSigner (golint)
  • Line 189: warning: exported type FrontierSigner should have comment or be unexported (golint)
  • Line 191: warning: exported method FrontierSigner.Equal should have comment or be unexported (golint)
  • Line 198: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)
  • Line 210: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)
  • Line 221: warning: exported method FrontierSigner.Sender should have comment or be unexported (golint)
  • Line 221: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)

• quorum/les/utils/expiredvalue.go
  • Line 70: warning: comment on exported method ExpiredValue.Value should be of the form "Value ..." (golint)
  • Line 76: warning: comment on exported method ExpiredValue.Add should be of the form "Add ..." (golint)
  • Line 100: warning: comment on exported method ExpiredValue.AddExp should be of the form "AddExp ..." (golint)
  • Line 112: warning: comment on exported method ExpiredValue.SubExp should be of the form "SubExp ..." (golint)
  • Line 141: warning: comment on exported method LinearExpiredValue.Value should be of the form "Value ..." (golint)
  • Line 156: warning: comment on exported method LinearExpiredValue.Add should be of the form "Add ..." (golint)
  • Line 242: warning: comment on exported function Float64ToFixed64 should be of the form "Float64ToFixed64 ..." (golint)
  • Line 247: warning: comment on exported method Fixed64.ToUint64 should be of the form "ToUint64 ..." (golint)
  • Line 252: warning: comment on exported method Fixed64.Fraction should be of the form "Fraction ..." (golint)
  • Line 262: warning: comment on exported method Fixed64.Pow2 should be of the form "Pow2 ..." (golint)

• quorum/p2p/nodestate/nodestate_test.go
  • Line 243: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 257: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/p2p/server.go
  • Line 384: warning: comment on exported method Server.SubscribeEvents should be of the form "SubscribeEvents ..." (golint)
  • Line 1175: warning: exported method Server.SetCheckPeerInRaft should have comment or be unexported (golint)
  • Line 1179: warning: exported method Server.SetIsNodePermissioned should have comment or be unexported (golint)

• quorum/accounts/pluggable/internal/testutils/matchers.go
  • Line 7: warning: exported type PointerMatcher should have comment or be unexported (golint)
  • Line 11: warning: exported method PointerMatcher.Matches should have comment or be unexported (golint)

• quorum/p2p/enode/node.go
  • Line 92: warning: comment on exported method Node.Incomplete should be of the form "Incomplete ..." (golint)
  • Line 141: warning: comment on exported method Node.Host should be of the form "Host ..." (golint)
  • Line 157: warning: comment on exported method Node.RaftPort should be of the form "RaftPort ..." (golint)
  • Line 167: warning: exported method Node.HasRaftPort should have comment or be unexported (golint)
  • Line 171: warning: comment on exported method Node.TCP should be of the form "TCP ..." (golint)
  • Line 249: warning: comment on exported method ID.GoString should be of the form "GoString ..." (golint)
  • Line 274: warning: comment on exported type EnodeID should be of the form "EnodeID ..." (with optional leading article) (golint)
  • Line 282: warning: comment on exported method EnodeID.GoString should be of the form "GoString ..." (golint)
  • Line 313: warning: comment on exported function RaftHexID should be of the form "RaftHexID ..." (golint)
  • Line 327: warning: exported function ParseID should have comment or be unexported (golint)

• quorum/private/engine/notinuse/notInUsePrivateTxManager.go
  • Line 10: warning: exported var ErrPrivateTxManagerNotInUse should have comment or be unexported (golint)
  • Line 12: warning: comment on exported type PrivateTransactionManager should be of the form "PrivateTransactionManager ..." (with optional leading article) (golint)
  • Line 16: warning: exported method PrivateTransactionManager.IsSender should have comment or be unexported (golint)
  • Line 20: warning: exported method PrivateTransactionManager.Groups should have comment or be unexported (golint)
  • Line 24: warning: exported method PrivateTransactionManager.GetParticipants should have comment or be unexported (golint)
  • Line 28: warning: exported method PrivateTransactionManager.Send should have comment or be unexported (golint)
  • Line 32: warning: exported method PrivateTransactionManager.EncryptPayload should have comment or be unexported (golint)
  • Line 36: warning: exported method PrivateTransactionManager.DecryptPayload should have comment or be unexported (golint)
  • Line 40: warning: exported method PrivateTransactionManager.StoreRaw should have comment or be unexported (golint)
  • Line 44: warning: exported method PrivateTransactionManager.SendSignedTx should have comment or be unexported (golint)
  • Line 48: warning: exported method PrivateTransactionManager.Receive should have comment or be unexported (golint)
  • Line 53: warning: exported method PrivateTransactionManager.ReceiveRaw should have comment or be unexported (golint)
  • Line 57: warning: exported method PrivateTransactionManager.Name should have comment or be unexported (golint)
  • Line 61: warning: exported method PrivateTransactionManager.HasFeature should have comment or be unexported (golint)

• quorum/les/protocol.go
  • Line 46: warning: comment on exported var ProtocolLengths should be of the form "ProtocolLengths ..." (golint)
  • Line 50: warning: exported const NetworkId should have comment (or a comment on this block) or be unexported (golint)
  • Line 138: warning: exported const ErrMsgTooLarge should have comment (or a comment on this block) or be unexported (golint)

• quorum/private/engine/tessera/tessera.go
  • Line 28: warning: exported function Is should have comment or be unexported (golint)
  • Line 33: warning: exported function New should have comment or be unexported (golint)
  • Line 184: warning: receiver name c should be consistent with previous receiver name t for tesseraPrivateTxManager (golint)
  • Line 303: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/internal/ethapi/api.go
  • Line 65: warning: exported type TransactionType should have comment or be unexported (golint)
  • Line 68: warning: exported const FillTransaction should have comment (or a comment on this block) or be unexported (golint)
  • Line 234: warning: comment on exported method PrivateAccountAPI.ListAccounts should be of the form "ListAccounts ..." (golint)
  • Line 652: warning: comment on exported type AccountResult should be of the form "AccountResult ..." (with optional leading article) (golint)
  • Line 662: warning: exported type StorageResult should have comment or be unexported (golint)
  • Line 910: warning: comment on exported function DoCall should be of the form "DoCall ..." (golint)
  • Line 1046: warning: exported function DoEstimateGas should have comment or be unexported (golint)
  • Line 1505: warning: comment on exported method PublicTransactionPoolAPI.GetContractPrivacyMetadata should be of the form "GetContractPrivacyMetadata ..." (golint)
  • Line 1649: warning: exported method SendTxArgs.IsPrivate should have comment or be unexported (golint)
  • Line 1658: warning: comment on exported type PrivateTxArgs should be of the form "PrivateTxArgs ..." (with optional leading article) (golint)
  • Line 1672: warning: exported method PrivateTxArgs.SetDefaultPrivateFrom should have comment or be unexported (golint)
  • Line 1684: warning: receiver name args should be consistent with previous receiver name s for SendTxArgs (golint)
  • Line 1748: warning: receiver name args should be consistent with previous receiver name s for SendTxArgs (golint)
  • Line 1758: warning: receiver name args should be consistent with previous receiver name s for SendTxArgs (golint)
  • Line 1765: warning: comment on exported function SubmitTransaction should be of the form "SubmitTransaction ..." (golint)
  • Line 1980: warning: comment on exported method PublicTransactionPoolAPI.SendRawPrivateTransaction should be of the form "SendRawPrivateTransaction ..." (golint)
  • Line 2359: warning: exported type AsyncSendTxArgs should have comment or be unexported (golint)
  • Line 2364: warning: exported type AsyncResultSuccess should have comment or be unexported (golint)
  • Line 2369: warning: exported type AsyncResultFailure should have comment or be unexported (golint)
  • Line 2374: warning: exported type Async should have comment or be unexported (golint)

• quorum/params/protocol_params.go
  • Line 22: warning: comment on exported const OriginalMinGasLimit should be of the form "OriginalMinGasLimit ..." (golint)
  • Line 24: warning: exported const OriginalGasLimitBoundDivisor should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: comment on exported const GasLimitBoundDivisor should be of the form "GasLimitBoundDivisor ..." (golint)
  • Line 83: warning: comment on exported const CallGasFrontier should be of the form "CallGasFrontier ..." (golint)
  • Line 99: warning: comment on exported const ExpByteFrontier should be of the form "ExpByteFrontier ..." (golint)
  • Line 103: warning: comment on exported const ExtcodeCopyBaseFrontier should be of the form "ExtcodeCopyBaseFrontier ..." (golint)
  • Line 145: warning: comment on exported const QuorumMaxPayloadBufferSize should be of the form "QuorumMaxPayloadBufferSize ..." (golint)
  • Line 149: warning: comment on exported var Bls12381MultiExpDiscountTable should be of the form "Bls12381MultiExpDiscountTable ..." (golint)
  • Line 153: warning: exported var DifficultyBoundDivisor should have comment or be unexported (golint)
  • Line 159: warning: exported function GetMaximumExtraDataSize should have comment or be unexported (golint)
  • Line 162: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/plugin/security/gateway.go
  • Line 22: warning: exported type TLSConfigurationSourcePluginGateway should have comment or be unexported (golint)
  • Line 26: warning: exported method TLSConfigurationSourcePluginGateway.Get should have comment or be unexported (golint)
  • Line 76: warning: exported type AuthenticationManagerPluginGateway should have comment or be unexported (golint)
  • Line 80: warning: exported method AuthenticationManagerPluginGateway.Authenticate should have comment or be unexported (golint)
  • Line 86: warning: exported method AuthenticationManagerPluginGateway.IsEnabled should have comment or be unexported (golint)

• quorum/p2p/simulations/simulation.go
  • Line 116: warning: exported type Step should have comment or be unexported (golint)
  • Line 128: warning: exported type Expectation should have comment or be unexported (golint)
  • Line 142: warning: exported type StepResult should have comment or be unexported (golint)

• quorum/accounts/manager.go
  • Line 139: warning: comment on exported method Manager.Backend should be of the form "Backend ..." (golint)

• quorum/consensus/istanbul/qbft/types/roundchange.go
  • Line 17: warning: comment on exported type RoundChange should be of the form "RoundChange ..." (with optional leading article) (golint)
  • Line 24: warning: exported function NewRoundChange should have comment or be unexported (golint)
  • Line 45: warning: exported type SignedRoundChangePayload should have comment or be unexported (golint)
  • Line 56: warning: exported method SignedRoundChangePayload.EncodeRLP should have comment or be unexported (golint)
  • Line 69: warning: exported method SignedRoundChangePayload.DecodeRLP should have comment or be unexported (golint)
  • Line 152: warning: exported method SignedRoundChangePayload.EncodePayloadForSigning should have comment or be unexported (golint)
  • Line 166: warning: exported method RoundChange.EncodeRLP should have comment or be unexported (golint)
  • Line 184: warning: exported method RoundChange.DecodeRLP should have comment or be unexported (golint)

• quorum/eth/handler.go
  • Line 66: warning: exported type ProtocolManager should have comment or be unexported (golint)
  • Line 269: warning: exported method ProtocolManager.Start should have comment or be unexported (golint)
  • Line 298: warning: exported method ProtocolManager.Stop should have comment or be unexported (golint)
  • Line 888: warning: comment on exported method ProtocolManager.Enqueue should be of the form "Enqueue ..." (golint)
  • Line 1057: warning: exported method ProtocolManager.FindPeers should have comment or be unexported (golint)
  • Line 1057: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• quorum/light/postprocess.go
  • Line 107: warning: exported var ChtTablePrefix should have comment or be unexported (golint)
  • Line 256: warning: comment on exported method ChtIndexerBackend.Prune should be of the form "Prune ..." (golint)
  • Line 303: warning: exported var BloomTrieTablePrefix should have comment or be unexported (golint)

• quorum/plugin/security/utils.go
  • Line 8: warning: exported type CipherSuite should have comment or be unexported (golint)
  • Line 9: warning: exported type CipherSuiteList should have comment or be unexported (golint)
  • Line 47: warning: exported method CipherSuiteList.ToUint16Array should have comment or be unexported (golint)

• quorum/permission/permission.go
  • Line 20: warning: comment on exported method PermissionCtrl.AfterStart should be of the form "AfterStart ..." (golint)

• quorum/p2p/simulations/network.go
  • Line 37: warning: exported var DialBanTimeout should have comment or be unexported (golint)
  • Line 457: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 475: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 654: warning: comment on exported method Network.InitConn should be of the form "InitConn ..." (golint)
  • Line 894: warning: exported method Network.SnapshotWithServices should have comment or be unexported (golint)
  • Line 1101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/cmd/devp2p/internal/v4test/discv4tests.go
  • Line 41: warning: comment on exported var Listen1 should be of the form "Listen1 ..." (golint)
  • Line 43: warning: comment on exported var Listen2 should be of the form "Listen2 ..." (golint)
  • Line 72: warning: comment on exported function BasicPing should be of the form "BasicPing ..." (golint)
  • Line 109: warning: comment on exported function PingWrongTo should be of the form "PingWrongTo ..." (golint)
  • Line 128: warning: comment on exported function PingWrongFrom should be of the form "PingWrongFrom ..." (golint)
  • Line 147: warning: comment on exported function PingExtraData should be of the form "PingExtraData ..." (golint)
  • Line 169: warning: comment on exported function PingExtraDataWrongFrom should be of the form "PingExtraDataWrongFrom ..." (golint)
  • Line 191: warning: comment on exported function PingPastExpiration should be of the form "PingPastExpiration ..." (golint)
  • Line 210: warning: comment on exported function WrongPacketType should be of the form "WrongPacketType ..." (golint)
  • Line 228: warning: comment on exported function BondThenPingWithWrongFrom should be of the form "BondThenPingWithWrongFrom ..." (golint)
  • Line 249: warning: comment on exported function FindnodeWithoutEndpointProof should be of the form "FindnodeWithoutEndpointProof ..." (golint)
  • Line 285: warning: comment on exported function UnsolicitedNeighbors should be of the form "UnsolicitedNeighbors ..." (golint)
  • Line 326: warning: comment on exported function FindnodePastExpiration should be of the form "FindnodePastExpiration ..." (golint)
  • Line 377: warning: comment on exported function FindnodeAmplificationInvalidPongHash should be of the form "FindnodeAmplificationInvalidPongHash ..." (golint)
  • Line 429: warning: comment on exported function FindnodeAmplificationWrongIP should be of the form "FindnodeAmplificationWrongIP ..." (golint)
  • Line 452: warning: exported var AllTests should have comment or be unexported (golint)

• quorum/rpc/context.go
  • Line 1: warning: package comment should be of the form "Package rpc ..." (golint)
  • Line 12: warning: exported type SecurityContext should have comment or be unexported (golint)
  • Line 15: warning: exported const HttpAuthorizationHeader should have comment (or a comment on this block) or be unexported (golint)

• quorum/eth/filters/filter_system.go
  • Line 55: warning: comment on exported const LastIndexSubscription should be of the form "LastIndexSubscription ..." (golint)

• quorum/plugin/account/connector.go
  • Line 12: warning: exported const ConnectorName should have comment or be unexported (golint)
  • Line 14: warning: exported type PluginConnector should have comment or be unexported (golint)
  • Line 18: warning: exported method PluginConnector.GRPCServer should have comment or be unexported (golint)
  • Line 22: warning: exported method PluginConnector.GRPCClient should have comment or be unexported (golint)

• quorum/rpc/websocket.go
  • Line 136: warning: comment on exported function DialWebsocketWithCustomTLS should be of the form "DialWebsocketWithCustomTLS ..." (golint)

• quorum/trie/stacktrie.go
  • Line 30: warning: exported var ErrCommitDisabled should have comment or be unexported (golint)
  • Line 107: warning: exported method StackTrie.Update should have comment or be unexported (golint)
  • Line 113: warning: exported method StackTrie.Reset should have comment or be unexported (golint)

• quorum/consensus/istanbul/backend/api.go
  • Line 43: warning: exported type Status should have comment or be unexported (golint)
  • Line 188: warning: exported method API.Status should have comment or be unexported (golint)
  • Line 257: warning: exported method API.IsValidator should have comment or be unexported (golint)

• quorum/core/mps/default_psr.go
  • Line 25: warning: exported function NewDefaultPrivateStateRepository should have comment or be unexported (golint)
  • Line 41: warning: exported method DefaultPrivateStateRepository.DefaultState should have comment or be unexported (golint)
  • Line 45: warning: exported method DefaultPrivateStateRepository.DefaultStateMetadata should have comment or be unexported (golint)
  • Line 49: warning: exported method DefaultPrivateStateRepository.IsMPS should have comment or be unexported (golint)
  • Line 53: warning: exported method DefaultPrivateStateRepository.StatePSI should have comment or be unexported (golint)
  • Line 60: warning: exported method DefaultPrivateStateRepository.Reset should have comment or be unexported (golint)
  • Line 86: warning: exported method DefaultPrivateStateRepository.Copy should have comment or be unexported (golint)
  • Line 95: warning: exported method DefaultPrivateStateRepository.MergeReceipts should have comment or be unexported (golint)

• quorum/plugin/initializer/service.go
  • Line 5: warning: exported type PluginInitializer should have comment or be unexported (golint)

• quorum/plugin/security/service.go
  • Line 11: warning: exported type TLSConfigurationSource should have comment or be unexported (golint)
  • Line 15: warning: exported type AuthenticationManager should have comment or be unexported (golint)
  • Line 20: warning: exported type AuthenticationManagerDeferFunc should have comment or be unexported (golint)
  • Line 22: warning: exported type DeferredAuthenticationManager should have comment or be unexported (golint)
  • Line 26: warning: exported method DeferredAuthenticationManager.Authenticate should have comment or be unexported (golint)
  • Line 34: warning: exported method DeferredAuthenticationManager.IsEnabled should have comment or be unexported (golint)
  • Line 42: warning: exported function NewDeferredAuthenticationManager should have comment or be unexported (golint)
  • Line 48: warning: exported type DisabledAuthenticationManager should have comment or be unexported (golint)
  • Line 51: warning: exported method DisabledAuthenticationManager.Authenticate should have comment or be unexported (golint)
  • Line 55: warning: exported method DisabledAuthenticationManager.IsEnabled should have comment or be unexported (golint)
  • Line 59: warning: exported function NewDisabledAuthenticationManager should have comment or be unexported (golint)

• quorum/core/blockchain.go
  • Line 97: warning: exported const TriesInMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 433: warning: comment on exported function NewMultitenantBlockChain should be of the form "NewMultitenantBlockChain ..." (golint)
  • Line 444: warning: exported method BlockChain.PrivateStateManager should have comment or be unexported (golint)
  • Line 448: warning: exported method BlockChain.SetPrivateStateManager should have comment or be unexported (golint)
  • Line 721: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 762: warning: comment on exported method BlockChain.StatePSI should be of the form "StatePSI ..." (golint)
  • Line 770: warning: comment on exported method BlockChain.StateAtPSI should be of the form "StateAtPSI ..." (golint)
  • Line 1204: warning: exported const NonStatTy should have comment (or a comment on this block) or be unexported (golint)
  • Line 1622: warning: comment on exported method BlockChain.CommitBlockWithState should be of the form "CommitBlockWithState ..." (golint)
  • Line 2747: warning: comment on exported method BlockChain.SupportsMultitenancy should be of the form "SupportsMultitenancy ..." (golint)
  • Line 2766: warning: comment on exported method BlockChain.SetSaveRevertReason should be of the form "SetSaveRevertReason ..." (golint)
  • Line 2771: warning: comment on exported method BlockChain.SaveRevertReason should be of the form "SaveRevertReason ..." (golint)

• quorum/p2p/discv5/node.go
  • Line 254: warning: comment on exported method NodeID.GoString should be of the form "GoString ..." (golint)

• quorum/plugin/settings.go
  • Line 23: warning: exported const HelloWorldPluginInterfaceName should have comment (or a comment on this block) or be unexported (golint)
  • Line 101: warning: exported type Version should have comment or be unexported (golint)
  • Line 103: warning: comment on exported type PluginDefinition should be of the form "PluginDefinition ..." (with optional leading article) (golint)
  • Line 115: warning: exported function ReadMultiFormatConfig should have comment or be unexported (golint)
  • Line 137: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 151: warning: comment on exported method PluginDefinition.FullName should be of the form "FullName ..." (golint)
  • Line 156: warning: comment on exported method PluginDefinition.DistFileName should be of the form "DistFileName ..." (golint)
  • Line 161: warning: comment on exported method PluginDefinition.SignatureFileName should be of the form "SignatureFileName ..." (golint)
  • Line 166: warning: comment on exported type PluginInterfaceName should be of the form "PluginInterfaceName ..." (with optional leading article) (golint)
  • Line 170: warning: comment on exported method PluginInterfaceName.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
  • Line 180: warning: exported method PluginInterfaceName.UnmarshalTOML should have comment or be unexported (golint)
  • Line 189: warning: exported method PluginInterfaceName.UnmarshalText should have comment or be unexported (golint)
  • Line 198: warning: comment on exported type Settings should be of the form "Settings ..." (with optional leading article) (golint)
  • Line 205: warning: exported method Settings.GetPluginDefinition should have comment or be unexported (golint)
  • Line 210: warning: exported method Settings.SetDefaults should have comment or be unexported (golint)
  • Line 241: warning: exported type PluginCentralConfiguration should have comment or be unexported (golint)
  • Line 257: warning: comment on exported method PluginCentralConfiguration.SetDefaults should be of the form "SetDefaults ..." (golint)
  • Line 273: warning: comment on exported type EnvironmentAwaredValue should be of the form "EnvironmentAwaredValue ..." (with optional leading article) (golint)
  • Line 277: warning: exported method EnvironmentAwaredValue.UnmarshalJSON should have comment or be unexported (golint)
  • Line 281: warning: exported method EnvironmentAwaredValue.UnmarshalTOML should have comment or be unexported (golint)
  • Line 285: warning: exported method EnvironmentAwaredValue.UnmarshalText should have comment or be unexported (golint)

• quorum/accounts/abi/bind/auth.go
  • Line 98: warning: comment on exported function NewWalletTransactor should be of the form "NewWalletTransactor ..." (golint)

• quorum/cmd/geth/accountcmd_plugin.go
  • Line 100: warning: error var invalidPluginFlagsErr should have name of the form errFoo (golint)

• quorum/p2p/peer_error.go
  • Line 70: warning: exported type DiscReason should have comment or be unexported (golint)
  • Line 73: warning: exported const DiscRequested should have comment (or a comment on this block) or be unexported (golint)

• quorum/p2p/discv5/table.go
  • Line 40: warning: exported type Table should have comment or be unexported (golint)

• quorum/tests/block_test_util.go
  • Line 98: warning: exported method BlockTest.Run should have comment or be unexported (golint)

• quorum/private/engine/tessera/tessera_version_reader.go
  • Line 14: warning: comment on exported function RetrieveTesseraAPIVersion should be of the form "RetrieveTesseraAPIVersion ..." (golint)

• quorum/core/asm/compiler.go
  • Line 42: warning: comment on exported function NewCompiler should be of the form "NewCompiler ..." (golint)

• quorum/crypto/ecies/ecies.go
  • Line 46: warning: exported var ErrImport should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method PublicKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 66: warning: comment on exported function ImportECDSAPublic should be of the form "ImportECDSAPublic ..." (golint)
  • Line 82: warning: comment on exported method PrivateKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 89: warning: comment on exported function ImportECDSA should be of the form "ImportECDSA ..." (golint)
  • Line 95: warning: comment on exported function GenerateKey should be of the form "GenerateKey ..." (golint)
  • Line 120: warning: comment on exported method PrivateKey.GenerateShared should be of the form "GenerateShared ..." (golint)
  • Line 141: warning: exported var ErrSharedTooLong should have comment or be unexported (golint)

• quorum/core/types/bloom9.go
  • Line 73: warning: comment on exported method Bloom.OrBloom should be of the form "OrBloom ..." (golint)

• quorum/extension/extensionContracts/gen.go
  • Line 1: warning: don't use MixedCaps in package name; extensionContracts should be extensioncontracts (golint)

• quorum/internal/web3ext/web3ext.go
  • Line 17: warning: package comment should be of the form "Package web3ext ..." (golint)
  • Line 20: warning: exported var Modules should have comment or be unexported (golint)
  • Line 44: warning: exported const ChequebookJs should have comment or be unexported (golint)
  • Line 75: warning: exported const CliqueJs should have comment or be unexported (golint)
  • Line 127: warning: exported const EthashJs should have comment or be unexported (golint)
  • Line 155: warning: exported const AdminJs should have comment or be unexported (golint)
  • Line 238: warning: exported const DebugJs should have comment or be unexported (golint)
  • Line 501: warning: exported const EthJs should have comment or be unexported (golint)
  • Line 643: warning: exported const MinerJs should have comment or be unexported (golint)
  • Line 688: warning: exported const NetJs should have comment or be unexported (golint)
  • Line 701: warning: exported const PersonalJs should have comment or be unexported (golint)
  • Line 757: warning: exported const RpcJs should have comment or be unexported (golint)
  • Line 770: warning: exported const ShhJs should have comment or be unexported (golint)
  • Line 790: warning: exported const SwarmfsJs should have comment or be unexported (golint)
  • Line 814: warning: exported const TxpoolJs should have comment or be unexported (golint)
  • Line 841: warning: don't use underscores in Go names; const Raft_JS should be RaftJS (golint)
  • Line 841: warning: exported const Raft_JS should have comment or be unexported (golint)
  • Line 885: warning: exported const QUORUM_NODE_JS should have comment or be unexported (golint)
  • Line 1040: warning: don't use underscores in Go names; const Istanbul_JS should be IstanbulJS (golint)
  • Line 1040: warning: exported const Istanbul_JS should have comment or be unexported (golint)
  • Line 1117: warning: exported const AccountingJs should have comment or be unexported (golint)
  • Line 1161: warning: exported const LESJs should have comment or be unexported (golint)
  • Line 1186: warning: don't use underscores in Go names; const Extension_JS should be ExtensionJS (golint)
  • Line 1186: warning: exported const Extension_JS should have comment or be unexported (golint)
  • Line 1232: warning: don't use underscores in Go names; const Account_Plugin_Js should be AccountPluginJs (golint)
  • Line 1232: warning: exported const Account_Plugin_Js should have comment or be unexported (golint)
  • Line 1251: warning: exported const LESPayJs should have comment or be unexported (golint)

• quorum/internal/debug/trace.go
  • Line 50: warning: comment on exported method HandlerT.StopGoTrace should be of the form "StopGoTrace ..." (golint)

• quorum/p2p/simulations/mocker.go
  • Line 39: warning: comment on exported function LookupMocker should be of the form "LookupMocker ..." (golint)
  • Line 44: warning: comment on exported function GetMockerList should be of the form "GetMockerList ..." (golint)

• quorum/rpc/client.go
  • Line 36: warning: exported var ErrClientQuit should have comment or be unexported (golint)
  • Line 189: warning: comment on exported function ClientFromContext should be of the form "ClientFromContext ..." (golint)
  • Line 352: warning: comment on exported method Client.BatchCallContext should be of the form "BatchCallContext ..." (golint)
  • Line 424: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 664: warning: comment on exported method Client.WithHTTPCredentials should be of the form "WithHTTPCredentials ..." (golint)
  • Line 679: warning: comment on exported method Client.WithPSIProvider should be of the form "WithPSIProvider ..." (golint)
  • Line 696: warning: comment on exported method Client.WithPSI should be of the form "WithPSI ..." (golint)

• quorum/metrics/sample.go
  • Line 13: warning: comment on exported type Sample should be of the form "Sample ..." (with optional leading article) (golint)
  • Line 217: warning: comment on exported method NilSample.Snapshot should be of the form "Snapshot ..." (golint)
  • Line 271: warning: comment on exported function SamplePercentile should be of the form "SamplePercentile ..." (golint)
  • Line 305: warning: exported function NewSampleSnapshot should have comment or be unexported (golint)
  • Line 397: warning: comment on exported type UniformSample should be of the form "UniformSample ..." (with optional leading article) (golint)

• quorum/node/node.go
  • Line 674: warning: comment on exported method Node.GetSecuritySupports should be of the form "GetSecuritySupports ..." (golint)
  • Line 693: warning: comment on exported method Node.IsPermissionEnabled should be of the form "IsPermissionEnabled ..." (golint)
  • Line 700: warning: comment on exported method Node.GetNodeKey should be of the form "GetNodeKey ..." (golint)
  • Line 707: warning: comment on exported method Node.PluginManager should be of the form "PluginManager ..." (golint)
  • Line 714: warning: comment on exported method Node.SetPluginManager should be of the form "SetPluginManager ..." (golint)
  • Line 721: warning: comment on exported method Node.Lifecycle should be of the form "Lifecycle ..." (golint)

• quorum/les/api.go
  • Line 340: warning: comment on exported method PrivateLightAPI.GetCheckpoint should be of the form "GetCheckpoint ..." (golint)

• quorum/core/default_psm.go
  • Line 16: warning: exported type DefaultPrivateStateManager should have comment or be unexported (golint)
  • Line 29: warning: exported method DefaultPrivateStateManager.StateRepository should have comment or be unexported (golint)
  • Line 33: warning: exported method DefaultPrivateStateManager.ResolveForManagedParty should have comment or be unexported (golint)
  • Line 37: warning: exported method DefaultPrivateStateManager.ResolveForUserContext should have comment or be unexported (golint)
  • Line 45: warning: exported method DefaultPrivateStateManager.PSIs should have comment or be unexported (golint)
  • Line 51: warning: exported method DefaultPrivateStateManager.NotIncludeAny should have comment or be unexported (golint)
  • Line 56: warning: exported method DefaultPrivateStateManager.CheckAt should have comment or be unexported (golint)
  • Line 61: warning: exported method DefaultPrivateStateManager.TrieDB should have comment or be unexported (golint)

• quorum/core/state/state_object.go
  • Line 36: warning: exported type Code should have comment or be unexported (golint)
  • Line 42: warning: exported type Storage should have comment or be unexported (golint)
  • Line 52: warning: exported method Storage.Copy should have comment or be unexported (golint)
  • Line 182: warning: receiver name so should be consistent with previous receiver name s for stateObject (golint)

• quorum/extension/api.go
  • Line 25: warning: exported type PrivateExtensionAPI should have comment or be unexported (golint)
  • Line 29: warning: exported function NewPrivateExtensionAPI should have comment or be unexported (golint)
  • Line 140: warning: comment on exported method PrivateExtensionAPI.ApproveExtension should be of the form "ApproveExtension ..." (golint)
  • Line 379: warning: comment on exported method PrivateExtensionAPI.GetExtensionStatus should be of the form "GetExtensionStatus ..." (golint)

• quorum/internal/build/archive.go
  • Line 30: warning: exported type Archive should have comment or be unexported (golint)
  • Line 44: warning: exported function NewArchive should have comment or be unexported (golint)
  • Line 107: warning: exported type ZipArchive should have comment or be unexported (golint)
  • Line 113: warning: exported function NewZipArchive should have comment or be unexported (golint)
  • Line 117: warning: exported method ZipArchive.Directory should have comment or be unexported (golint)
  • Line 122: warning: exported method ZipArchive.Header should have comment or be unexported (golint)
  • Line 136: warning: exported method ZipArchive.Close should have comment or be unexported (golint)
  • Line 143: warning: exported type TarballArchive should have comment or be unexported (golint)
  • Line 150: warning: exported function NewTarballArchive should have comment or be unexported (golint)
  • Line 156: warning: exported method TarballArchive.Directory should have comment or be unexported (golint)
  • Line 165: warning: exported method TarballArchive.Header should have comment or be unexported (golint)
  • Line 177: warning: exported method TarballArchive.Close should have comment or be unexported (golint)

• quorum/les/lespay/client/valuetracker.go
  • Line 216: warning: comment on exported method ValueTracker.StatsExpFactor should be of the form "StatsExpFactor ..." (golint)
  • Line 467: warning: exported type ServedRequest should have comment or be unexported (golint)
  • Line 489: warning: exported type RequestStatsItem should have comment or be unexported (golint)

• quorum/cmd/devp2p/internal/v5test/discv5tests.go
  • Line 49: warning: exported method Suite.AllTests should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method Suite.TestPing should be of the form "TestPing ..." (golint)
  • Line 87: warning: comment on exported method Suite.TestPingLargeRequestID should be of the form "TestPingLargeRequestID ..." (golint)
  • Line 106: warning: comment on exported method Suite.TestPingMultiIP should be of the form "TestPingMultiIP ..." (golint)
  • Line 156: warning: comment on exported method Suite.TestPingHandshakeInterrupted should be of the form "TestPingHandshakeInterrupted ..." (golint)
  • Line 183: warning: comment on exported method Suite.TestTalkRequest should be of the form "TestTalkRequest ..." (golint)
  • Line 218: warning: comment on exported method Suite.TestFindnodeZeroDistance should be of the form "TestFindnodeZeroDistance ..." (golint)
  • Line 235: warning: comment on exported method Suite.TestFindnodeResults should be of the form "TestFindnodeResults ..." (golint)

• quorum/rpc/inproc.go
  • Line 24: warning: exported type InProcServerReadyEvent should have comment or be unexported (golint)

• quorum/extension/data_handler.go
  • Line 38: warning: exported type DataHandler should have comment or be unexported (golint)
  • Line 44: warning: exported type JsonFileDataHandler should have comment or be unexported (golint)
  • Line 48: warning: exported function NewJsonFileDataHandler should have comment or be unexported (golint)
  • Line 54: warning: comment on exported method JsonFileDataHandler.Load should be of the form "Load ..." (golint)
  • Line 94: warning: exported method JsonFileDataHandler.Save should have comment or be unexported (golint)

• quorum/metrics/json.go
  • Line 29: warning: exported method PrefixedRegistry.MarshalJSON should have comment or be unexported (golint)

• quorum/params/network_params.go
  • Line 72: warning: comment on exported function GetImmutabilityThreshold should be of the form "GetImmutabilityThreshold ..." (golint)
  • Line 82: warning: exported function GetImmutabilityThresholdWithDefault should have comment or be unexported (golint)
  • Line 91: warning: comment on exported function SetQuorumImmutabilityThreshold should be of the form "SetQuorumImmutabilityThreshold ..." (golint)

• quorum/tests/fuzzers/stacktrie/trie_fuzzer.go
  • Line 115: warning: comment on exported function Fuzz should be of the form "Fuzz ..." (golint)
  • Line 130: warning: exported function Debug should have comment or be unexported (golint)

• quorum/cmd/evm/internal/t8ntool/execution.go
  • Line 41: warning: exported type Prestate should have comment or be unexported (golint)
  • Line 245: warning: exported function MakePreState should have comment or be unexported (golint)

• quorum/rpc/server.go
  • Line 30: warning: exported const MetadataApi should have comment or be unexported (golint)
  • Line 58: warning: comment on exported function NewProtectedServer should be of the form "NewProtectedServer ..." (golint)
  • Line 161: warning: exported method Server.EnableMultitenancy should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/core/justification.go
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/event/event.go
  • Line 174: warning: exported method TypeMuxSubscription.Chan should have comment or be unexported (golint)
  • Line 178: warning: exported method TypeMuxSubscription.Unsubscribe should have comment or be unexported (golint)
  • Line 183: warning: exported method TypeMuxSubscription.Closed should have comment or be unexported (golint)

• quorum/extension/subscriptions.go
  • Line 18: warning: exported function NewSubscriptionHandler should have comment or be unexported (golint)

• quorum/internal/jsre/jsre.go
  • Line 69: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 230: warning: comment on exported method JSRE.Stop should be of the form "Stop ..." (golint)
  • Line 239: warning: comment on exported method JSRE.Exec should be of the form "Exec ..." (golint)

• quorum/light/trie.go
  • Line 33: warning: exported function NewState should have comment or be unexported (golint)
  • Line 38: warning: exported function NewStateDatabase should have comment or be unexported (golint)

• quorum/plugin/base.go
  • Line 30: warning: comment on exported type MetaData should be of the form "MetaData ..." (with optional leading article) (golint)

• quorum/plugin/service.go
  • Line 15: warning: comment on exported type PluginManager should be of the form "PluginManager ..." (with optional leading article) (golint)
  • Line 29: warning: comment on exported method PluginManager.APIs should be of the form "APIs ..." (golint)
  • Line 42: warning: exported method PluginManager.Start should have comment or be unexported (golint)
  • Line 81: warning: comment on exported method PluginManager.IsEnabled should be of the form "IsEnabled ..." (golint)
  • Line 87: warning: comment on exported method PluginManager.GetPluginTemplate should be of the form "GetPluginTemplate ..." (golint)
  • Line 133: warning: exported method PluginManager.Stop should have comment or be unexported (golint)
  • Line 152: warning: comment on exported method PluginManager.PluginsInfo should be of the form "PluginsInfo ..." (golint)
  • Line 182: warning: exported method PluginManager.Reload should have comment or be unexported (golint)
  • Line 214: warning: exported function NewPluginManager should have comment or be unexported (golint)
  • Line 250: warning: exported function NewEmptyPluginManager should have comment or be unexported (golint)

• quorum/accounts/external/backend.go
  • Line 35: warning: exported type ExternalBackend should have comment or be unexported (golint)
  • Line 39: warning: exported method ExternalBackend.Wallets should have comment or be unexported (golint)
  • Line 43: warning: exported function NewExternalBackend should have comment or be unexported (golint)
  • Line 53: warning: exported method ExternalBackend.Subscribe should have comment or be unexported (golint)
  • Line 71: warning: exported function NewExternalSigner should have comment or be unexported (golint)
  • Line 89: warning: exported method ExternalSigner.URL should have comment or be unexported (golint)
  • Line 96: warning: exported method ExternalSigner.Status should have comment or be unexported (golint)
  • Line 100: warning: exported method ExternalSigner.Open should have comment or be unexported (golint)
  • Line 104: warning: exported method ExternalSigner.Close should have comment or be unexported (golint)
  • Line 108: warning: exported method ExternalSigner.Accounts should have comment or be unexported (golint)
  • Line 130: warning: exported method ExternalSigner.Contains should have comment or be unexported (golint)
  • Line 147: warning: exported method ExternalSigner.Derive should have comment or be unexported (golint)
  • Line 151: warning: exported method ExternalSigner.SelfDerive should have comment or be unexported (golint)
  • Line 176: warning: exported method ExternalSigner.SignText should have comment or be unexported (golint)
  • Line 199: warning: exported method ExternalSigner.SignTx should have comment or be unexported (golint)
  • Line 223: warning: exported method ExternalSigner.SignTextWithPassphrase should have comment or be unexported (golint)
  • Line 227: warning: exported method ExternalSigner.SignTxWithPassphrase should have comment or be unexported (golint)
  • Line 230: warning: exported method ExternalSigner.SignDataWithPassphrase should have comment or be unexported (golint)

• quorum/extension/extensionContracts/types.go
  • Line 1: warning: don't use MixedCaps in package name; extensionContracts should be extensioncontracts (golint)
  • Line 7: warning: exported type AccountWithMetadata should have comment or be unexported (golint)

• quorum/internal/build/util.go
  • Line 37: warning: exported var DryRunFlag should have comment or be unexported (golint)
  • Line 52: warning: exported function MustRunCommand should have comment or be unexported (golint)
  • Line 209: warning: comment on exported function IgnorePackages should be of the form "IgnorePackages ..." (golint)

• quorum/plugin/helloworld/gateway.go
  • Line 9: warning: exported type PluginGateway should have comment or be unexported (golint)
  • Line 13: warning: exported method PluginGateway.Greeting should have comment or be unexported (golint)

• quorum/tests/transaction_test_util.go
  • Line 47: warning: exported method TransactionTest.Run should have comment or be unexported (golint)

• quorum/core/asm/lexer.go
  • Line 56: warning: exported const Numbers should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: comment on exported function Lex should be of the form "Lex ..." (golint)

• quorum/consensus/ethash/consensus.go
  • Line 655: warning: comment on exported function AccumulateRewards should be of the form "AccumulateRewards ..." (golint)

• quorum/les/utils/timeutils.go
  • Line 26: warning: exported type UpdateTimer should have comment or be unexported (golint)
  • Line 33: warning: exported function NewUpdateTimer should have comment or be unexported (golint)
  • Line 49: warning: exported method UpdateTimer.Update should have comment or be unexported (golint)
  • Line 53: warning: exported method UpdateTimer.UpdateAt should have comment or be unexported (golint)

• quorum/signer/rules/rules.go
  • Line 34: warning: don't use underscores in Go names; var BigNumber_JS should be BigNumberJS (golint)
  • Line 34: warning: exported var BigNumber_JS should have comment or be unexported (golint)
  • Line 56: warning: exported function NewRuleEvaluator should have comment or be unexported (golint)

• quorum/plugin/account/reloadableimpl.go
  • Line 11: warning: exported type DispenseFunc should have comment or be unexported (golint)
  • Line 13: warning: exported type ReloadableService should have comment or be unexported (golint)
  • Line 17: warning: exported method ReloadableService.Status should have comment or be unexported (golint)
  • Line 25: warning: exported method ReloadableService.Open should have comment or be unexported (golint)
  • Line 33: warning: exported method ReloadableService.Close should have comment or be unexported (golint)
  • Line 41: warning: exported method ReloadableService.Accounts should have comment or be unexported (golint)
  • Line 50: warning: exported method ReloadableService.Contains should have comment or be unexported (golint)
  • Line 59: warning: exported method ReloadableService.Sign should have comment or be unexported (golint)
  • Line 67: warning: exported method ReloadableService.UnlockAndSign should have comment or be unexported (golint)
  • Line 75: warning: exported method ReloadableService.TimedUnlock should have comment or be unexported (golint)
  • Line 83: warning: exported method ReloadableService.Lock should have comment or be unexported (golint)
  • Line 91: warning: exported method ReloadableService.NewAccount should have comment or be unexported (golint)
  • Line 99: warning: exported method ReloadableService.ImportRawKey should have comment or be unexported (golint)

• quorum/crypto/secp256k1/curve.go
  • Line 89: warning: exported method BitCurve.Params should have comment or be unexported (golint)
  • Line 241: warning: exported method BitCurve.ScalarMult should have comment or be unexported (golint)

• quorum/core/vm/contracts.go
  • Line 105: warning: exported var PrecompiledAddressesYoloV2 should have comment or be unexported (golint)

• quorum/multitenancy/authorization.go
  • Line 16: warning: exported var ErrNotAuthorized should have comment or be unexported (golint)

• quorum/metrics/counter.go
  • Line 7: warning: comment on exported type Counter should be of the form "Counter ..." (with optional leading article) (golint)

• quorum/metrics/metrics.go
  • Line 1: warning: package comment should be of the form "Package metrics ..." (golint)

• quorum/metrics/registry.go
  • Line 53: warning: comment on exported type StandardRegistry should be of the form "StandardRegistry ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported function NewRegistry should be of the form "NewRegistry ..." (golint)
  • Line 65: warning: comment on exported method StandardRegistry.Each should be of the form "Each ..." (golint)
  • Line 79: warning: comment on exported method StandardRegistry.GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 104: warning: comment on exported method StandardRegistry.RunHealthchecks should be of the form "RunHealthchecks ..." (golint)
  • Line 184: warning: comment on exported method StandardRegistry.UnregisterAll should be of the form "UnregisterAll ..." (golint)
  • Line 228: warning: exported type PrefixedRegistry should have comment or be unexported (golint)
  • Line 233: warning: exported function NewPrefixedRegistry should have comment or be unexported (golint)
  • Line 240: warning: exported function NewPrefixedChildRegistry should have comment or be unexported (golint)
  • Line 247: warning: comment on exported method PrefixedRegistry.Each should be of the form "Each ..." (golint)
  • Line 279: warning: comment on exported method PrefixedRegistry.GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 293: warning: comment on exported method PrefixedRegistry.RunHealthchecks should be of the form "RunHealthchecks ..." (golint)
  • Line 309: warning: comment on exported method PrefixedRegistry.UnregisterAll should be of the form "UnregisterAll ..." (golint)
  • Line 315: warning: exported var DefaultRegistry should have comment or be unexported (golint)
  • Line 320: warning: comment on exported function Each should be of the form "Each ..." (golint)
  • Line 330: warning: comment on exported function GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 342: warning: comment on exported function MustRegister should be of the form "MustRegister ..." (golint)
  • Line 350: warning: comment on exported function RunHealthchecks should be of the form "RunHealthchecks ..." (golint)

• quorum/node/defaults.go
  • Line 31: warning: exported const DefaultHTTPHost should have comment (or a comment on this block) or be unexported (golint)

• quorum/permission/core/cache.go
  • Line 15: warning: exported type TransactionType should have comment or be unexported (golint)
  • Line 18: warning: exported const ValueTransferTxn should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type AccessType should have comment or be unexported (golint)
  • Line 26: warning: comment on exported const ReadOnly should be of the form "ReadOnly ..." (golint)
  • Line 30: warning: exported const Transact should have comment (or a comment on this block) or be unexported (golint)
  • Line 33: warning: comment on exported const ContractCall should be of the form "ContractCall ..." (golint)
  • Line 40: warning: exported type PermissionModelType should have comment or be unexported (golint)
  • Line 43: warning: exported const V1 should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported type OrgStatus should have comment or be unexported (golint)
  • Line 51: warning: exported const OrgPendingApproval should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported type OrgInfo should have comment or be unexported (golint)
  • Line 67: warning: exported type NodeStatus should have comment or be unexported (golint)
  • Line 70: warning: exported const NodePendingApproval should have comment (or a comment on this block) or be unexported (golint)
  • Line 77: warning: exported type AcctStatus should have comment or be unexported (golint)
  • Line 80: warning: exported const AcctPendingApproval should have comment (or a comment on this block) or be unexported (golint)
  • Line 90: warning: exported type NodeInfo should have comment or be unexported (golint)
  • Line 96: warning: exported type RoleInfo should have comment or be unexported (golint)
  • Line 105: warning: exported type AccountInfo should have comment or be unexported (golint)
  • Line 113: warning: exported type OrgDetailInfo should have comment or be unexported (golint)
  • Line 127: warning: exported var PermissionModel should have comment or be unexported (golint)
  • Line 128: warning: exported var PermissionTransactionAllowedFunc should have comment or be unexported (golint)
  • Line 130: warning: exported var OrgInfoMap should have comment or be unexported (golint)
  • Line 136: warning: exported type OrgKey should have comment or be unexported (golint)
  • Line 140: warning: exported type OrgCache should have comment or be unexported (golint)
  • Line 147: warning: exported method OrgCache.PopulateCacheFunc should have comment or be unexported (golint)
  • Line 151: warning: exported function NewOrgCache should have comment or be unexported (golint)
  • Line 160: warning: exported type RoleKey should have comment or be unexported (golint)
  • Line 165: warning: exported type RoleCache should have comment or be unexported (golint)
  • Line 171: warning: exported method RoleCache.PopulateCacheFunc should have comment or be unexported (golint)
  • Line 175: warning: exported function NewRoleCache should have comment or be unexported (golint)
  • Line 184: warning: exported type NodeKey should have comment or be unexported (golint)
  • Line 189: warning: exported type NodeCache should have comment or be unexported (golint)
  • Line 196: warning: exported method NodeCache.PopulateValidateFunc should have comment or be unexported (golint)
  • Line 200: warning: exported method NodeCache.PopulateCacheFunc should have comment or be unexported (golint)
  • Line 204: warning: exported function NewNodeCache should have comment or be unexported (golint)
  • Line 214: warning: exported type AccountKey should have comment or be unexported (golint)
  • Line 218: warning: exported type AcctCache should have comment or be unexported (golint)
  • Line 224: warning: exported method AcctCache.PopulateCacheFunc should have comment or be unexported (golint)
  • Line 228: warning: exported function NewAcctCache should have comment or be unexported (golint)
  • Line 238: warning: exported function SetSyncStatus should have comment or be unexported (golint)
  • Line 242: warning: exported function GetSyncStatus should have comment or be unexported (golint)
  • Line 253: warning: comment on exported function SetQIP714BlockReached should be of the form "SetQIP714BlockReached ..." (golint)
  • Line 259: warning: comment on exported function SetNetworkBootUpCompleted should be of the form "SetNetworkBootUpCompleted ..." (golint)
  • Line 265: warning: comment on exported function PermissionsEnabled should be of the form "PermissionsEnabled ..." (golint)
  • Line 269: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 274: warning: comment on exported function SetDefaults should be of the form "SetDefaults ..." (golint)
  • Line 286: warning: exported function GetDefaults should have comment or be unexported (golint)
  • Line 290: warning: exported function GetNodeUrl should have comment or be unexported (golint)
  • Line 297: warning: exported method OrgCache.UpsertOrg should have comment or be unexported (golint)
  • Line 319: warning: exported method OrgCache.UpsertOrgWithSubOrgList should have comment or be unexported (golint)
  • Line 339: warning: exported method OrgCache.GetOrg should have comment or be unexported (golint)
  • Line 360: warning: exported method OrgCache.GetOrgList should have comment or be unexported (golint)
  • Line 370: warning: exported method NodeCache.UpsertNode should have comment or be unexported (golint)
  • Line 375: warning: exported method NodeCache.GetNodeByUrl should have comment or be unexported (golint)
  • Line 401: warning: exported method NodeCache.GetNodeList should have comment or be unexported (golint)
  • Line 411: warning: exported method AcctCache.UpsertAccount should have comment or be unexported (golint)
  • Line 416: warning: exported method AcctCache.GetAccount should have comment or be unexported (golint)
  • Line 437: warning: exported method AcctCache.GetAcctList should have comment or be unexported (golint)
  • Line 447: warning: exported method AcctCache.GetAcctListOrg should have comment or be unexported (golint)
  • Line 459: warning: exported method AcctCache.GetAcctListRole should have comment or be unexported (golint)
  • Line 477: warning: exported method RoleCache.UpsertRole should have comment or be unexported (golint)
  • Line 483: warning: exported method RoleCache.GetRole should have comment or be unexported (golint)
  • Line 505: warning: exported method RoleCache.GetRoleList should have comment or be unexported (golint)
  • Line 515: warning: comment on exported function GetAcctAccess should be of the form "GetAcctAccess ..." (golint)
  • Line 556: warning: comment on exported function CheckIfAdminAccount should be of the form "CheckIfAdminAccount ..." (golint)
  • Line 581: warning: comment on exported function ValidateNodeForTxn should be of the form "ValidateNodeForTxn ..." (golint)
  • Line 622: warning: exported function IsV2Permission should have comment or be unexported (golint)
  • Line 626: warning: comment on exported function IsTransactionAllowed should be of the form "IsTransactionAllowed ..." (golint)

• quorum/les/server.go
  • Line 54: warning: exported type LesServer should have comment or be unexported (golint)
  • Line 78: warning: exported function NewLesServer should have comment or be unexported (golint)
  • Line 160: warning: exported method LesServer.APIs should have comment or be unexported (golint)
  • Line 183: warning: exported method LesServer.Protocols should have comment or be unexported (golint)

• quorum/core/types/block.go
  • Line 38: warning: exported var EmptyRootHash should have comment or be unexported (golint)
  • Line 212: warning: comment on exported type StorageBlock should be of the form "StorageBlock ..." (with optional leading article) (golint)
  • Line 318: warning: comment on exported method StorageBlock.DecodeRLP should be of the form "DecodeRLP ..." (golint)
  • Line 330: warning: exported method Block.Uncles should have comment or be unexported (golint)
  • Line 331: warning: exported method Block.Transactions should have comment or be unexported (golint)
  • Line 333: warning: exported method Block.Transaction should have comment or be unexported (golint)
  • Line 342: warning: exported method Block.Number should have comment or be unexported (golint)
  • Line 343: warning: exported method Block.GasLimit should have comment or be unexported (golint)
  • Line 344: warning: exported method Block.GasUsed should have comment or be unexported (golint)
  • Line 345: warning: exported method Block.Difficulty should have comment or be unexported (golint)
  • Line 346: warning: exported method Block.Time should have comment or be unexported (golint)
  • Line 348: warning: exported method Block.NumberU64 should have comment or be unexported (golint)
  • Line 349: warning: exported method Block.MixDigest should have comment or be unexported (golint)
  • Line 350: warning: exported method Block.Nonce should have comment or be unexported (golint)
  • Line 351: warning: exported method Block.Bloom should have comment or be unexported (golint)
  • Line 352: warning: exported method Block.Coinbase should have comment or be unexported (golint)
  • Line 353: warning: exported method Block.Root should have comment or be unexported (golint)
  • Line 354: warning: exported method Block.ParentHash should have comment or be unexported (golint)
  • Line 355: warning: exported method Block.TxHash should have comment or be unexported (golint)
  • Line 356: warning: exported method Block.ReceiptHash should have comment or be unexported (golint)
  • Line 357: warning: exported method Block.UncleHash should have comment or be unexported (golint)
  • Line 358: warning: exported method Block.Extra should have comment or be unexported (golint)
  • Line 360: warning: exported method Block.Header should have comment or be unexported (golint)
  • Line 390: warning: exported function CalcUncleHash should have comment or be unexported (golint)
  • Line 434: warning: exported type Blocks should have comment or be unexported (golint)

• quorum/cmd/geth/retesteth.go
  • Line 69: warning: exported type RetestethTestAPI should have comment or be unexported (golint)
  • Line 78: warning: exported type RetestethEthAPI should have comment or be unexported (golint)
  • Line 88: warning: exported type RetestethDebugAPI should have comment or be unexported (golint)
  • Line 100: warning: exported type RetestWeb3API should have comment or be unexported (golint)
  • Line 104: warning: exported type RetestethAPI should have comment or be unexported (golint)
  • Line 118: warning: exported type ChainParams should have comment or be unexported (golint)
  • Line 125: warning: exported type CParamsParams should have comment or be unexported (golint)
  • Line 148: warning: exported type CParamsGenesis should have comment or be unexported (golint)
  • Line 159: warning: exported type CParamsAccount should have comment or be unexported (golint)
  • Line 167: warning: exported type CPAccountPrecompiled should have comment or be unexported (golint)
  • Line 173: warning: exported type CPAPrecompiledLinear should have comment or be unexported (golint)
  • Line 178: warning: exported type AccountRangeResult should have comment or be unexported (golint)
  • Line 183: warning: exported type StorageRangeResult should have comment or be unexported (golint)
  • Line 188: warning: exported type SRItem should have comment or be unexported (golint)
  • Line 193: warning: exported type NoRewardEngine should have comment or be unexported (golint)
  • Line 198: warning: exported method NoRewardEngine.Protocol should have comment or be unexported (golint)
  • Line 202: warning: exported method NoRewardEngine.Author should have comment or be unexported (golint)
  • Line 202: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 206: warning: exported method NoRewardEngine.VerifyHeader should have comment or be unexported (golint)
  • Line 206: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 210: warning: exported method NoRewardEngine.VerifyHeaders should have comment or be unexported (golint)
  • Line 210: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 214: warning: exported method NoRewardEngine.VerifyUncles should have comment or be unexported (golint)
  • Line 214: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 218: warning: exported method NoRewardEngine.VerifySeal should have comment or be unexported (golint)
  • Line 218: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 222: warning: exported method NoRewardEngine.Prepare should have comment or be unexported (golint)
  • Line 222: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 226: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 235: warning: exported method NoRewardEngine.Finalize should have comment or be unexported (golint)
  • Line 235: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 245: warning: exported method NoRewardEngine.FinalizeAndAssemble should have comment or be unexported (golint)
  • Line 245: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 249: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 258: warning: exported method NoRewardEngine.Seal should have comment or be unexported (golint)
  • Line 258: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 262: warning: exported method NoRewardEngine.SealHash should have comment or be unexported (golint)
  • Line 262: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 266: warning: exported method NoRewardEngine.CalcDifficulty should have comment or be unexported (golint)
  • Line 266: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 270: warning: exported method NoRewardEngine.APIs should have comment or be unexported (golint)
  • Line 270: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 274: warning: exported method NoRewardEngine.Close should have comment or be unexported (golint)
  • Line 274: warning: receiver name e should be consistent with previous receiver name sb for NoRewardEngine (golint)
  • Line 278: warning: exported method RetestethAPI.SetChainParams should have comment or be unexported (golint)
  • Line 425: warning: exported method RetestethAPI.SendRawTransaction should have comment or be unexported (golint)
  • Line 447: warning: exported method RetestethAPI.MineBlocks should have comment or be unexported (golint)
  • Line 568: warning: exported method RetestethAPI.ModifyTimestamp should have comment or be unexported (golint)
  • Line 573: warning: exported method RetestethAPI.ImportRawBlock should have comment or be unexported (golint)
  • Line 585: warning: exported method RetestethAPI.RewindToBlock should have comment or be unexported (golint)
  • Line 597: warning: exported method RetestethAPI.GetLogHash should have comment or be unexported (golint)
  • Line 601: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 604: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 610: warning: exported method RetestethAPI.BlockNumber should have comment or be unexported (golint)
  • Line 614: warning: exported method RetestethAPI.GetBlockByNumber should have comment or be unexported (golint)
  • Line 628: warning: exported method RetestethAPI.GetBlockByHash should have comment or be unexported (golint)
  • Line 642: warning: exported method RetestethAPI.AccountRange should have comment or be unexported (golint)
  • Line 722: warning: exported method RetestethAPI.GetBalance should have comment or be unexported (golint)
  • Line 732: warning: exported method RetestethAPI.GetCode should have comment or be unexported (golint)
  • Line 741: warning: exported method RetestethAPI.GetTransactionCount should have comment or be unexported (golint)
  • Line 750: warning: exported method RetestethAPI.StorageRangeAt should have comment or be unexported (golint)
  • Line 845: warning: exported method RetestethAPI.ClientVersion should have comment or be unexported (golint)

• quorum/eth/config.go
  • Line 112: warning: exported type Config should have comment or be unexported (golint)

• quorum/signer/core/auditlog.go
  • Line 29: warning: exported type AuditLogger should have comment or be unexported (golint)
  • Line 34: warning: exported method AuditLogger.List should have comment or be unexported (golint)
  • Line 42: warning: exported method AuditLogger.New should have comment or be unexported (golint)
  • Line 46: warning: exported method AuditLogger.SignTransaction should have comment or be unexported (golint)
  • Line 64: warning: exported method AuditLogger.SignData should have comment or be unexported (golint)
  • Line 73: warning: exported method AuditLogger.SignGnosisSafeTx should have comment or be unexported (golint)
  • Line 91: warning: exported method AuditLogger.SignTypedData should have comment or be unexported (golint)
  • Line 99: warning: exported method AuditLogger.EcRecover should have comment or be unexported (golint)
  • Line 107: warning: exported method AuditLogger.Version should have comment or be unexported (golint)
  • Line 115: warning: exported function NewAuditLogger should have comment or be unexported (golint)

• quorum/crypto/bn256/cloudflare/bn256.go
  • Line 54: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 63: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 72: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 81: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 90: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 99: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 124: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 342: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 351: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 360: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 369: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 378: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 385: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 427: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• quorum/p2p/discover/v4_udp.go
  • Line 130: warning: exported function ListenV4 should have comment or be unexported (golint)

• quorum/permission/v1/backend.go
  • Line 14: warning: exported type Backend should have comment or be unexported (golint)
  • Line 19: warning: exported method Backend.ManageAccountPermissions should have comment or be unexported (golint)
  • Line 66: warning: exported method Backend.ManageRolePermissions should have comment or be unexported (golint)
  • Line 106: warning: exported method Backend.ManageOrgPermissions should have comment or be unexported (golint)
  • Line 158: warning: exported method Backend.ManageNodePermissions should have comment or be unexported (golint)
  • Line 258: warning: exported method Backend.MonitorNetworkBootUp should have comment or be unexported (golint)
  • Line 321: warning: exported method Backend.GetRoleService should have comment or be unexported (golint)
  • Line 330: warning: exported method Backend.GetOrgService should have comment or be unexported (golint)
  • Line 339: warning: exported method Backend.GetNodeService should have comment or be unexported (golint)
  • Line 348: warning: exported method Backend.GetAccountService should have comment or be unexported (golint)
  • Line 357: warning: exported method Backend.GetAuditService should have comment or be unexported (golint)
  • Line 366: warning: exported method Backend.GetControlService should have comment or be unexported (golint)

• quorum/p2p/discv5/topic.go
  • Line 37: warning: exported type Topic should have comment or be unexported (golint)

• quorum/plugin/verifier.go
  • Line 10: warning: comment on exported type Verifier should be of the form "Verifier ..." (with optional leading article) (golint)
  • Line 17: warning: exported type NonVerifier should have comment or be unexported (golint)
  • Line 20: warning: exported method NonVerifier.VerifySignature should have comment or be unexported (golint)
  • Line 24: warning: exported function NewNonVerifier should have comment or be unexported (golint)
  • Line 28: warning: exported function NewVerifier should have comment or be unexported (golint)
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/core/private_state_manager.go
  • Line 57: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/accounts/accounts.go
  • Line 39: warning: exported const MimetypeDataWithValidator should have comment (or a comment on this block) or be unexported (golint)
  • Line 215: warning: comment on exported const WalletDropped should be of the form "WalletDropped ..." (golint)

• quorum/metrics/exp/exp.go
  • Line 1: warning: package comment should be of the form "Package exp ..." (golint)

• quorum/eth/api_backend.go
  • Line 72: warning: exported method EthAPIBackend.CurrentBlock should have comment or be unexported (golint)
  • Line 76: warning: exported method EthAPIBackend.SetHead should have comment or be unexported (golint)
  • Line 81: warning: exported method EthAPIBackend.HeaderByNumber should have comment or be unexported (golint)
  • Line 94: warning: exported method EthAPIBackend.HeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 111: warning: exported method EthAPIBackend.HeaderByHash should have comment or be unexported (golint)
  • Line 115: warning: exported method EthAPIBackend.BlockByNumber should have comment or be unexported (golint)
  • Line 132: warning: exported method EthAPIBackend.BlockByHash should have comment or be unexported (golint)
  • Line 136: warning: exported method EthAPIBackend.BlockByNumberOrHash should have comment or be unexported (golint)
  • Line 157: warning: exported method EthAPIBackend.StateAndHeaderByNumber should have comment or be unexported (golint)
  • Line 190: warning: exported method EthAPIBackend.StateAndHeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 216: warning: exported method EthAPIBackend.GetReceipts should have comment or be unexported (golint)
  • Line 237: warning: exported method EthAPIBackend.GetLogs should have comment or be unexported (golint)
  • Line 252: warning: exported method EthAPIBackend.GetTd should have comment or be unexported (golint)
  • Line 256: warning: exported method EthAPIBackend.GetEVM should have comment or be unexported (golint)
  • Line 276: warning: exported method EthAPIBackend.SubscribeRemovedLogsEvent should have comment or be unexported (golint)
  • Line 280: warning: exported method EthAPIBackend.SubscribePendingLogsEvent should have comment or be unexported (golint)
  • Line 284: warning: exported method EthAPIBackend.SubscribeChainEvent should have comment or be unexported (golint)
  • Line 288: warning: exported method EthAPIBackend.SubscribeChainHeadEvent should have comment or be unexported (golint)
  • Line 292: warning: exported method EthAPIBackend.SubscribeChainSideEvent should have comment or be unexported (golint)
  • Line 296: warning: exported method EthAPIBackend.SubscribeLogsEvent should have comment or be unexported (golint)
  • Line 300: warning: exported method EthAPIBackend.SendTx should have comment or be unexported (golint)
  • Line 309: warning: exported method EthAPIBackend.GetPoolTransactions should have comment or be unexported (golint)
  • Line 321: warning: exported method EthAPIBackend.GetPoolTransaction should have comment or be unexported (golint)
  • Line 325: warning: exported method EthAPIBackend.GetTransaction should have comment or be unexported (golint)
  • Line 330: warning: exported method EthAPIBackend.GetPoolNonce should have comment or be unexported (golint)
  • Line 334: warning: exported method EthAPIBackend.Stats should have comment or be unexported (golint)
  • Line 338: warning: exported method EthAPIBackend.TxPoolContent should have comment or be unexported (golint)
  • Line 342: warning: exported method EthAPIBackend.TxPool should have comment or be unexported (golint)
  • Line 346: warning: exported method EthAPIBackend.SubscribeNewTxsEvent should have comment or be unexported (golint)
  • Line 350: warning: exported method EthAPIBackend.Downloader should have comment or be unexported (golint)
  • Line 354: warning: exported method EthAPIBackend.ProtocolVersion should have comment or be unexported (golint)
  • Line 358: warning: exported method EthAPIBackend.SuggestPrice should have comment or be unexported (golint)
  • Line 361: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 366: warning: exported method EthAPIBackend.ChainDb should have comment or be unexported (golint)
  • Line 370: warning: exported method EthAPIBackend.EventMux should have comment or be unexported (golint)
  • Line 374: warning: exported method EthAPIBackend.AccountManager should have comment or be unexported (golint)
  • Line 378: warning: exported method EthAPIBackend.ExtRPCEnabled should have comment or be unexported (golint)
  • Line 382: warning: exported method EthAPIBackend.CallTimeOut should have comment or be unexported (golint)
  • Line 386: warning: exported method EthAPIBackend.RPCGasCap should have comment or be unexported (golint)
  • Line 390: warning: exported method EthAPIBackend.RPCTxFeeCap should have comment or be unexported (golint)
  • Line 394: warning: exported method EthAPIBackend.BloomStatus should have comment or be unexported (golint)
  • Line 399: warning: exported method EthAPIBackend.ServiceFilter should have comment or be unexported (golint)
  • Line 405: warning: exported method EthAPIBackend.Engine should have comment or be unexported (golint)
  • Line 409: warning: exported method EthAPIBackend.CurrentHeader should have comment or be unexported (golint)
  • Line 413: warning: exported method EthAPIBackend.Miner should have comment or be unexported (golint)
  • Line 417: warning: exported method EthAPIBackend.StartMining should have comment or be unexported (golint)
  • Line 421: warning: comment on exported method EthAPIBackend.SupportsMultitenancy should be of the form "SupportsMultitenancy ..." (golint)
  • Line 431: warning: exported method EthAPIBackend.AccountExtraDataStateGetterByNumber should have comment or be unexported (golint)
  • Line 436: warning: comment on exported type EthAPIState should be of the form "EthAPIState ..." (with optional leading article) (golint)
  • Line 441: warning: exported method EthAPIState.GetBalance should have comment or be unexported (golint)
  • Line 448: warning: exported method EthAPIState.GetCode should have comment or be unexported (golint)
  • Line 455: warning: exported method EthAPIState.SetNonce should have comment or be unexported (golint)
  • Line 463: warning: exported method EthAPIState.SetCode should have comment or be unexported (golint)
  • Line 471: warning: exported method EthAPIState.SetBalance should have comment or be unexported (golint)
  • Line 479: warning: exported method EthAPIState.SetStorage should have comment or be unexported (golint)
  • Line 487: warning: exported method EthAPIState.SetState should have comment or be unexported (golint)
  • Line 495: warning: exported method EthAPIState.GetState should have comment or be unexported (golint)
  • Line 502: warning: exported method EthAPIState.GetNonce should have comment or be unexported (golint)
  • Line 509: warning: exported method EthAPIState.GetPrivacyMetadata should have comment or be unexported (golint)
  • Line 516: warning: exported method EthAPIState.GetManagedParties should have comment or be unexported (golint)
  • Line 523: warning: exported method EthAPIState.GetRLPEncodedStateObject should have comment or be unexported (golint)
  • Line 531: warning: exported method EthAPIState.GetProof should have comment or be unexported (golint)
  • Line 538: warning: exported method EthAPIState.GetStorageProof should have comment or be unexported (golint)
  • Line 545: warning: exported method EthAPIState.StorageTrie should have comment or be unexported (golint)
  • Line 559: warning: exported method EthAPIState.GetCodeHash should have comment or be unexported (golint)

• quorum/metrics/librato/client.go
  • Line 11: warning: exported const Operations should have comment or be unexported (golint)
  • Line 12: warning: exported const OperationsShort should have comment or be unexported (golint)
  • Line 14: warning: exported type LibratoClient should have comment or be unexported (golint)
  • Line 58: warning: exported type Measurement should have comment or be unexported (golint)
  • Line 59: warning: exported type Metric should have comment or be unexported (golint)
  • Line 61: warning: exported type Batch should have comment or be unexported (golint)
  • Line 68: warning: exported method LibratoClient.PostMetrics should have comment or be unexported (golint)

• quorum/log/doc.go
  • Line 1: warning: package comment should be of the form "Package log ..." (golint)

• quorum/metrics/runtime.go
  • Line 55: warning: comment on exported function CaptureRuntimeMemStats should be of the form "CaptureRuntimeMemStats ..." (golint)
  • Line 63: warning: comment on exported function CaptureRuntimeMemStatsOnce should be of the form "CaptureRuntimeMemStatsOnce ..." (golint)
  • Line 145: warning: comment on exported function RegisterRuntimeMemStats should be of the form "RegisterRuntimeMemStats ..." (golint)

• quorum/private/cache/cache.go
  • Line 11: warning: exported const DefaultExpiration should have comment (or a comment on this block) or be unexported (golint)
  • Line 15: warning: exported function NewDefaultCache should have comment or be unexported (golint)
  • Line 19: warning: exported type PrivateCacheItem should have comment or be unexported (golint)

• quorum/plugin/central.go
  • Line 21: warning: comment on exported type CentralClient should be of the form "CentralClient ..." (with optional leading article) (golint)
  • Line 27: warning: comment on exported function NewPluginCentralClient should be of the form "NewPluginCentralClient ..." (golint)
  • Line 60: warning: comment on exported method CentralClient.PublicKey should be of the form "PublicKey ..." (golint)
  • Line 75: warning: comment on exported method CentralClient.PluginSignature should be of the form "PluginSignature ..." (golint)
  • Line 89: warning: comment on exported method CentralClient.PluginDistribution should be of the form "PluginDistribution ..." (golint)
  • Line 180: warning: comment on exported type Dialer should be of the form "Dialer ..." (with optional leading article) (golint)

• quorum/plugin/downloader.go
  • Line 11: warning: comment on exported type Downloader should be of the form "Downloader ..." (with optional leading article) (golint)
  • Line 16: warning: exported function NewDownloader should have comment or be unexported (golint)
  • Line 22: warning: exported method Downloader.Download should have comment or be unexported (golint)

• quorum/consensus/istanbul/testutils/genesis.go
  • Line 16: warning: exported function Genesis should have comment or be unexported (golint)
  • Line 36: warning: exported function GenesisAndKeys should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/types/decode.go
  • Line 8: warning: exported function Decode should have comment or be unexported (golint)

• quorum/tests/fuzzers/rlp/rlp_fuzzer.go
  • Line 39: warning: exported function Fuzz should have comment or be unexported (golint)

• quorum/cmd/evm/internal/t8ntool/flags.go
  • Line 29: warning: exported var TraceFlag should have comment or be unexported (golint)

• quorum/raft/minter.go
  • Line 127: warning: exported type AddressTxes should have comment or be unexported (golint)

• quorum/crypto/bn256/google/constants.go
  • Line 19: warning: comment on exported var P should be of the form "P ..." (golint)

• quorum/core/vm/evm.go
  • Line 142: warning: exported type PublicState should have comment or be unexported (golint)
  • Line 143: warning: exported type PrivateState should have comment or be unexported (golint)
  • Line 202: warning: exported const Creation should have comment (or a comment on this block) or be unexported (golint)
  • Line 686: warning: exported method EVM.PublicState should have comment or be unexported (golint)
  • Line 687: warning: exported method EVM.PrivateState should have comment or be unexported (golint)
  • Line 688: warning: exported method EVM.SetCurrentTX should have comment or be unexported (golint)
  • Line 689: warning: exported method EVM.SetTxPrivacyMetadata should have comment or be unexported (golint)
  • Line 692: warning: exported method EVM.Push should have comment or be unexported (golint)
  • Line 710: warning: exported method EVM.Pop should have comment or be unexported (golint)
  • Line 718: warning: exported method EVM.Depth should have comment or be unexported (golint)
  • Line 720: warning: comment on exported method EVM.RevertToSnapshot should be of the form "RevertToSnapshot ..." (golint)
  • Line 728: warning: comment on exported method EVM.CreatedContracts should be of the form "CreatedContracts ..." (golint)
  • Line 741: warning: comment on exported method EVM.AffectedContracts should be of the form "AffectedContracts ..." (golint)
  • Line 755: warning: comment on exported method EVM.CalculateMerkleRoot should be of the form "CalculateMerkleRoot ..." (golint)

• quorum/node/api.go
  • Line 299: warning: comment on exported type QuorumNodeInfo should be of the form "QuorumNodeInfo ..." (with optional leading article) (golint)

• quorum/node/config.go
  • Line 459: warning: comment on exported method Config.ResolvePluginBaseDir should be of the form "ResolvePluginBaseDir ..." (golint)
  • Line 483: warning: comment on exported method Config.IsPermissionEnabled should be of the form "IsPermissionEnabled ..." (golint)

• quorum/core/events.go
  • Line 36: warning: exported type ChainEvent should have comment or be unexported (golint)
  • Line 42: warning: exported type ChainSideEvent should have comment or be unexported (golint)
  • Line 46: warning: exported type ChainHeadEvent should have comment or be unexported (golint)

• quorum/tests/fuzzers/abi/abifuzzer.go
  • Line 184: warning: exported function Fuzz should have comment or be unexported (golint)

• quorum/signer/core/types.go
  • Line 30: warning: exported type ValidationInfo should have comment or be unexported (golint)
  • Line 34: warning: exported type ValidationMessages should have comment or be unexported (golint)
  • Line 39: warning: exported const WARN should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported method ValidationMessages.Crit should have comment or be unexported (golint)
  • Line 47: warning: exported method ValidationMessages.Warn should have comment or be unexported (golint)
  • Line 50: warning: exported method ValidationMessages.Info should have comment or be unexported (golint)
  • Line 55: warning: receiver name v should be consistent with previous receiver name vs for ValidationMessages (golint)

• quorum/cmd/utils/flags_legacy.go
  • Line 28: warning: exported var ShowDeprecated should have comment or be unexported (golint)
  • Line 37: warning: exported var DeprecatedFlags should have comment or be unexported (golint)
  • Line 49: warning: comment on exported var LegacyMinerThreadsFlag should be of the form "LegacyMinerThreadsFlag ..." (golint)
  • Line 55: warning: exported var LegacyMinerGasTargetFlag should have comment or be unexported (golint)
  • Line 75: warning: comment on exported var LegacyLightServFlag should be of the form "LegacyLightServFlag ..." (golint)
  • Line 87: warning: comment on exported var LegacyTestnetFlag should be of the form "LegacyTestnetFlag ..." (golint)
  • Line 93: warning: comment on exported var LegacyRPCEnabledFlag should be of the form "LegacyRPCEnabledFlag ..." (golint)
  • Line 164: warning: comment on exported var LegacyGraphQLListenAddrFlag should be of the form "LegacyGraphQLListenAddrFlag ..." (golint)

• quorum/private/engine/tessera/tessera_version_checker.go
  • Line 13: warning: exported type Version should have comment or be unexported (golint)

• quorum/consensus/istanbul/ibft/core/testbackend_test.go
  • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 66: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 70: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 84: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 115: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 120: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 129: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 133: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 137: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 147: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 156: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 160: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• quorum/core/asm/asm.go
  • Line 17: warning: package comment should be of the form "Package asm ..." (golint)
  • Line 37: warning: comment on exported function NewInstructionIterator should be of the form "NewInstructionIterator ..." (golint)
  • Line 102: warning: comment on exported function PrintDisassembled should be of the form "PrintDisassembled ..." (golint)
  • Line 120: warning: comment on exported function Disassemble should be of the form "Disassemble ..." (golint)

• quorum/crypto/ecies/params.go
  • Line 49: warning: exported var DefaultCurve should have comment or be unexported (golint)
  • Line 60: warning: exported type ECIESParams should have comment or be unexported (golint)
  • Line 75: warning: exported var ECIES_AES128_SHA256 should have comment or be unexported (golint)
  • Line 115: warning: exported function AddParamsForCurve should have comment or be unexported (golint)

• quorum/p2p/peer.go
  • Line 38: warning: exported var ErrShuttingDown should have comment or be unexported (golint)
  • Line 220: warning: exported method Peer.Log should have comment or be unexported (golint)

• quorum/metrics/gauge_float64.go
  • Line 5: warning: comment on exported type GaugeFloat64 should be of the form "GaugeFloat64 ..." (with optional leading article) (golint)
  • Line 41: warning: comment on exported function NewFunctionalGaugeFloat64 should be of the form "NewFunctionalGaugeFloat64 ..." (golint)
  • Line 49: warning: comment on exported function NewRegisteredFunctionalGaugeFloat64 should be of the form "NewRegisteredFunctionalGaugeFloat64 ..." (golint)
  • Line 73: warning: comment on exported type NilGaugeFloat64 should be of the form "NilGaugeFloat64 ..." (with optional leading article) (golint)

• quorum/metrics/resetting_timer.go
  • Line 10: warning: comment on exported const InitialResettingTimerSliceCap should be of the form "InitialResettingTimerSliceCap ..." (golint)
  • Line 120: warning: comment on exported method StandardResettingTimer.Time should be of the form "Time ..." (golint)
  • Line 127: warning: comment on exported method StandardResettingTimer.Update should be of the form "Update ..." (golint)
  • Line 134: warning: comment on exported method StandardResettingTimer.UpdateSince should be of the form "UpdateSince ..." (golint)

• quorum/p2p/discv5/udp.go
  • Line 34: warning: exported const Version should have comment or be unexported (golint)

• quorum/consensus/istanbul/engine.go
  • Line 13: warning: exported type Engine should have comment or be unexported (golint)

• quorum/p2p/discover/v5wire/encoding_test.go
  • Line 253: warning: don't use underscores in Go names; var incorrect_challenge should be incorrectChallenge (golint)
  • Line 259: warning: don't use underscores in Go names; var incorrect_findnode should be incorrectFindnode (golint)
  • Line 260: warning: don't use underscores in Go names; var incorrect_findnode2 should be incorrectFindnode2 (golint)

• quorum/metrics/debug.go
  • Line 22: warning: comment on exported function CaptureDebugGCStats should be of the form "CaptureDebugGCStats ..." (golint)
  • Line 30: warning: comment on exported function CaptureDebugGCStatsOnce should be of the form "CaptureDebugGCStatsOnce ..." (golint)
  • Line 53: warning: comment on exported function RegisterDebugGCStats should be of the form "RegisterDebugGCStats ..." (golint)

• quorum/metrics/meter.go
  • Line 9: warning: comment on exported type Meter should be of the form "Meter ..." (with optional leading article) (golint)

• quorum/plugin/local_verifier.go
  • Line 10: warning: comment on exported const DefaultPublicKeyFile should be of the form "DefaultPublicKeyFile ..." (golint)
  • Line 14: warning: comment on exported type LocalVerifier should be of the form "LocalVerifier ..." (with optional leading article) (golint)
  • Line 20: warning: comment on exported function NewLocalVerifier should be of the form "NewLocalVerifier ..." (golint)
  • Line 39: warning: comment on exported method LocalVerifier.VerifySignature should be of the form "VerifySignature ..." (golint)

• quorum/rpc/http.go
  • Line 281: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 282: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 283: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 285: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 288: warning: should not use basic type string as key in context.WithValue (golint)

• quorum/rpc/testservice_test.go
  • Line 115: warning: error should be the last type when returning multiple items (golint)

• quorum/plugin/account/internal/testutils/matchers.go
  • Line 10: warning: exported type StatusRequestMatcher should have comment or be unexported (golint)
  • Line 14: warning: exported method StatusRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 26: warning: exported type OpenRequestMatcher should have comment or be unexported (golint)
  • Line 30: warning: exported method OpenRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 42: warning: exported type CloseRequestMatcher should have comment or be unexported (golint)
  • Line 46: warning: exported method CloseRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 58: warning: exported type AccountsRequestMatcher should have comment or be unexported (golint)
  • Line 62: warning: exported method AccountsRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 74: warning: exported type ContainsRequestMatcher should have comment or be unexported (golint)
  • Line 78: warning: exported method ContainsRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 90: warning: exported type SignRequestMatcher should have comment or be unexported (golint)
  • Line 94: warning: exported method SignRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 106: warning: exported type UnlockAndSignRequestMatcher should have comment or be unexported (golint)
  • Line 110: warning: exported method UnlockAndSignRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 122: warning: exported type TimedUnlockRequestMatcher should have comment or be unexported (golint)
  • Line 126: warning: exported method TimedUnlockRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 138: warning: exported type LockRequestMatcher should have comment or be unexported (golint)
  • Line 142: warning: exported method LockRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 154: warning: exported type NewAccountRequestMatcher should have comment or be unexported (golint)
  • Line 158: warning: exported method NewAccountRequestMatcher.Matches should have comment or be unexported (golint)
  • Line 170: warning: exported type ImportRawKeyRequestMatcher should have comment or be unexported (golint)
  • Line 174: warning: exported method ImportRawKeyRequestMatcher.Matches should have comment or be unexported (golint)

• quorum/private/engine/constellation/constellation.go
  • Line 19: warning: exported function Is should have comment or be unexported (golint)
  • Line 24: warning: exported function New should have comment or be unexported (golint)
  • Line 73: warning: receiver name ptm should be consistent with previous receiver name g for constellation (golint)

• quorum/rlp/encode.go
  • Line 28: warning: comment on exported var EmptyString should be of the form "EmptyString ..." (golint)
  • Line 31: warning: exported var EmptyList should have comment or be unexported (golint)

• quorum/crypto/bn256/google/gfp2.go
  • Line 105: warning: receiver name c should be consistent with previous receiver name e for gfP2 (golint)

• quorum/eth/backend.go
  • Line 394: warning: exported method Ethereum.ResetWithGenesisBlock should have comment or be unexported (golint)
  • Line 398: warning: exported method Ethereum.Etherbase should have comment or be unexported (golint)
  • Line 548: warning: exported method Ethereum.IsMining should have comment or be unexported (golint)
  • Line 549: warning: exported method Ethereum.Miner should have comment or be unexported (golint)
  • Line 551: warning: exported method Ethereum.AccountManager should have comment or be unexported (golint)
  • Line 552: warning: exported method Ethereum.BlockChain should have comment or be unexported (golint)
  • Line 553: warning: exported method Ethereum.TxPool should have comment or be unexported (golint)
  • Line 554: warning: exported method Ethereum.EventMux should have comment or be unexported (golint)
  • Line 555: warning: exported method Ethereum.Engine should have comment or be unexported (golint)
  • Line 556: warning: exported method Ethereum.ChainDb should have comment or be unexported (golint)
  • Line 557: warning: exported method Ethereum.IsListening should have comment or be unexported (golint)
  • Line 558: warning: exported method Ethereum.EthVersion should have comment or be unexported (golint)
  • Line 559: warning: exported method Ethereum.NetVersion should have comment or be unexported (golint)
  • Line 560: warning: exported method Ethereum.Downloader should have comment or be unexported (golint)
  • Line 561: warning: exported method Ethereum.Synced should have comment or be unexported (golint)
  • Line 562: warning: exported method Ethereum.ArchiveMode should have comment or be unexported (golint)
  • Line 563: warning: exported method Ethereum.BloomIndexer should have comment or be unexported (golint)
  • Line 636: warning: exported method Ethereum.CalcGasLimit should have comment or be unexported (golint)
  • Line 640: warning: comment on exported method Ethereum.ConsensusServicePendingLogsFeed should be of the form "ConsensusServicePendingLogsFeed ..." (golint)
  • Line 646: warning: comment on exported method Ethereum.SubscribePendingLogs should be of the form "SubscribePendingLogs ..." (golint)

• quorum/p2p/discover/v5_udp.go
  • Line 347: warning: comment on exported method UDPv5.RequestENR should be of the form "RequestENR ..." (golint)

• quorum/les/serverpool.go
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/p2p/simulations/http.go
  • Line 367: warning: comment on exported method Server.GetMockers should be of the form "GetMockers ..." (golint)
  • Line 722: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 737: warning: should not use basic type string as key in context.WithValue (golint)

• quorum/core/state_transition.go
  • Line 34: warning: comment on exported type StateTransition should be of the form "StateTransition ..." (with optional leading article) (golint)
  • Line 176: warning: exported function ApplyMessage should have comment or be unexported (golint)
  • Line 431: warning: comment on exported method StateTransition.SetTxPrivacyMetadata should be of the form "SetTxPrivacyMetadata ..." (golint)
  • Line 435: warning: exported method StateTransition.IsPrivacyEnhancementsEnabled should have comment or be unexported (golint)
  • Line 438: warning: exported method StateTransition.RevertToSnapshot should have comment or be unexported (golint)
  • Line 441: warning: exported method StateTransition.GetStatePrivacyMetadata should have comment or be unexported (golint)
  • Line 444: warning: exported method StateTransition.CalculateMerkleRoot should have comment or be unexported (golint)
  • Line 447: warning: exported method StateTransition.AffectedContracts should have comment or be unexported (golint)

• quorum/plugin/plugin_templates.go
  • Line 14: warning: comment on exported type HelloWorldPluginTemplate should be of the form "HelloWorldPluginTemplate ..." (with optional leading article) (golint)
  • Line 19: warning: exported method HelloWorldPluginTemplate.Get should have comment or be unexported (golint)
  • Line 31: warning: exported type SecurityPluginTemplate should have comment or be unexported (golint)
  • Line 70: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 82: warning: exported type ReloadableAccountServiceFactory should have comment or be unexported (golint)
  • Line 86: warning: exported method ReloadableAccountServiceFactory.Create should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/types/prepare.go
  • Line 12: warning: comment on exported type Prepare should be of the form "Prepare ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewPrepare should have comment or be unexported (golint)
  • Line 29: warning: exported function NewPrepareWithSigAndSource should have comment or be unexported (golint)
  • Line 40: warning: exported method Prepare.EncodePayloadForSigning should have comment or be unexported (golint)
  • Line 48: warning: exported method Prepare.EncodeRLP should have comment or be unexported (golint)
  • Line 60: warning: exported method Prepare.DecodeRLP should have comment or be unexported (golint)

• quorum/accounts/keystore/passphrase.go
  • Line 140: warning: comment on exported function EncryptDataV3 should be of the form "EncryptDataV3 ..." (golint)
  • Line 239: warning: exported function DecryptDataV3 should have comment or be unexported (golint)

• quorum/core/state/statedb.go
  • Line 205: warning: exported method StateDB.AddLog should have comment or be unexported (golint)
  • Line 216: warning: exported method StateDB.GetLogs should have comment or be unexported (golint)
  • Line 220: warning: exported method StateDB.Logs should have comment or be unexported (golint)
  • Line 284: warning: exported method StateDB.GetNonce should have comment or be unexported (golint)
  • Line 292: warning: comment on exported method StateDB.GetPrivacyMetadata should be of the form "GetPrivacyMetadata ..." (golint)
  • Line 301: warning: comment on exported method StateDB.GetCommittedStatePrivacyMetadata should be of the form "GetCommittedStatePrivacyMetadata ..." (golint)
  • Line 310: warning: comment on exported method StateDB.GetManagedParties should be of the form "GetManagedParties ..." (golint)
  • Line 311: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 319: warning: exported method StateDB.GetRLPEncodedStateObject should have comment or be unexported (golint)
  • Line 344: warning: exported method StateDB.GetCode should have comment or be unexported (golint)
  • Line 352: warning: exported method StateDB.GetCodeSize should have comment or be unexported (golint)
  • Line 360: warning: exported method StateDB.GetCodeHash should have comment or be unexported (golint)
  • Line 421: warning: exported method StateDB.HasSuicided should have comment or be unexported (golint)
  • Line 429: warning: comment on exported method StateDB.GetStorageRoot should be of the form "GetStorageRoot ..." (golint)
  • Line 459: warning: exported method StateDB.SetBalance should have comment or be unexported (golint)
  • Line 466: warning: exported method StateDB.SetNonce should have comment or be unexported (golint)
  • Line 473: warning: exported method StateDB.SetPrivacyMetadata should have comment or be unexported (golint)
  • Line 480: warning: exported method StateDB.SetManagedParties should have comment or be unexported (golint)
  • Line 480: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 487: warning: exported method StateDB.SetCode should have comment or be unexported (golint)
  • Line 494: warning: exported method StateDB.SetState should have comment or be unexported (golint)
  • Line 726: warning: exported method StateDB.ForEachStorage should have comment or be unexported (golint)
  • Line 726: warning: receiver name db should be consistent with previous receiver name s for StateDB (golint)

• quorum/metrics/histogram.go
  • Line 3: warning: comment on exported type Histogram should be of the form "Histogram ..." (with optional leading article) (golint)

• quorum/plugin/initializer/gateway.go
  • Line 9: warning: exported type PluginGateway should have comment or be unexported (golint)
  • Line 13: warning: exported method PluginGateway.Init should have comment or be unexported (golint)

• quorum/cmd/devp2p/internal/ethtest/suite.go
  • Line 63: warning: exported method Suite.AllTests should have comment or be unexported (golint)

• quorum/interfaces.go
  • Line 30: warning: error var NotFound should have name of the form ErrFoo (golint)

• quorum/consensus/istanbul/core.go
  • Line 5: warning: exported type Core should have comment or be unexported (golint)

• quorum/core/types/istanbul.go
  • Line 32: warning: exported var IstanbulExtraVanity should have comment or be unexported (golint)
  • Line 135: warning: exported type ValidatorVote should have comment or be unexported (golint)

• quorum/core/types/mps.go
  • Line 21: warning: exported function ToPrivateStateIdentifier should have comment or be unexported (golint)

• quorum/internal/jsre/pretty.go
  • Line 37: warning: exported var FunctionColor should have comment or be unexported (golint)

• quorum/eth/downloader/modes.go
  • Line 26: warning: exported const FullSync should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: comment on exported const BoundedFullSync should be of the form "BoundedFullSync ..." (golint)
  • Line 33: warning: exported method SyncMode.IsValid should have comment or be unexported (golint)
  • Line 51: warning: exported method SyncMode.MarshalText should have comment or be unexported (golint)
  • Line 64: warning: exported method SyncMode.UnmarshalText should have comment or be unexported (golint)

• quorum/multitenancy/types.go
  • Line 37: warning: exported method PrivateStateSecurityAttribute.WithPSI should have comment or be unexported (golint)
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/raft/api.go
  • Line 9: warning: exported type RaftNodeInfo should have comment or be unexported (golint)
  • Line 19: warning: exported type PublicRaftAPI should have comment or be unexported (golint)
  • Line 23: warning: exported function NewPublicRaftAPI should have comment or be unexported (golint)
  • Line 27: warning: exported method PublicRaftAPI.Role should have comment or be unexported (golint)
  • Line 46: warning: exported method PublicRaftAPI.AddPeer should have comment or be unexported (golint)
  • Line 53: warning: exported method PublicRaftAPI.AddLearner should have comment or be unexported (golint)
  • Line 60: warning: exported method PublicRaftAPI.PromoteToPeer should have comment or be unexported (golint)
  • Line 67: warning: exported method PublicRaftAPI.RemovePeer should have comment or be unexported (golint)
  • Line 74: warning: exported method PublicRaftAPI.Leader should have comment or be unexported (golint)
  • Line 83: warning: exported method PublicRaftAPI.Cluster should have comment or be unexported (golint)
  • Line 132: warning: exported method PublicRaftAPI.GetRaftId should have comment or be unexported (golint)

• quorum/accounts/abi/bind/backend.go
  • Line 35: warning: comment on exported var ErrNoPendingState should be of the form "ErrNoPendingState ..." (golint)
  • Line 39: warning: comment on exported var ErrNoCodeAfterDeploy should be of the form "ErrNoCodeAfterDeploy ..." (golint)

• quorum/metrics/log.go
  • Line 7: warning: exported type Logger should have comment or be unexported (golint)
  • Line 11: warning: exported function Log should have comment or be unexported (golint)
  • Line 15: warning: comment on exported function LogScaled should be of the form "LogScaled ..." (golint)

• quorum/consensus/clique/api.go
  • Line 124: warning: exported type Status should have comment or be unexported (golint)

• quorum/core/vm/runtime/env.go
  • Line 24: warning: exported function NewEnv should have comment or be unexported (golint)

• quorum/core/types/transaction.go
  • Line 39: warning: exported var ErrInvalidSig should have comment or be unexported (golint)
  • Line 57: warning: exported type Transaction should have comment or be unexported (golint)
  • Line 97: warning: exported function NewTransaction should have comment or be unexported (golint)
  • Line 101: warning: exported function NewContractCreation should have comment or be unexported (golint)
  • Line 132: warning: comment on exported function NewTxPrivacyMetadata should be of the form "NewTxPrivacyMetadata ..." (golint)
  • Line 139: warning: exported method Transaction.SetTxPrivacyMetadata should have comment or be unexported (golint)
  • Line 215: warning: exported method Transaction.Data should have comment or be unexported (golint)
  • Line 216: warning: exported method Transaction.Gas should have comment or be unexported (golint)
  • Line 217: warning: exported method Transaction.GasPrice should have comment or be unexported (golint)
  • Line 218: warning: exported method Transaction.GasPriceCmp should have comment or be unexported (golint)
  • Line 221: warning: exported method Transaction.GasPriceIntCmp should have comment or be unexported (golint)
  • Line 224: warning: exported method Transaction.Value should have comment or be unexported (golint)
  • Line 225: warning: exported method Transaction.Nonce should have comment or be unexported (golint)
  • Line 226: warning: exported method Transaction.CheckNonce should have comment or be unexported (golint)
  • Line 227: warning: exported method Transaction.PrivacyMetadata should have comment or be unexported (golint)
  • Line 239: warning: exported method Transaction.From should have comment or be unexported (golint)
  • Line 430: warning: exported method TxByPriceAndTime.Push should have comment or be unexported (golint)
  • Line 434: warning: exported method TxByPriceAndTime.Pop should have comment or be unexported (golint)
  • Line 523: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 536: warning: exported method Message.From should have comment or be unexported (golint)
  • Line 537: warning: exported method Message.To should have comment or be unexported (golint)
  • Line 538: warning: exported method Message.GasPrice should have comment or be unexported (golint)
  • Line 539: warning: exported method Message.Value should have comment or be unexported (golint)
  • Line 540: warning: exported method Message.Gas should have comment or be unexported (golint)
  • Line 541: warning: exported method Message.Nonce should have comment or be unexported (golint)
  • Line 542: warning: exported method Message.Data should have comment or be unexported (golint)
  • Line 543: warning: exported method Message.CheckNonce should have comment or be unexported (golint)
  • Line 545: warning: comment on exported method Message.IsPrivate should be of the form "IsPrivate ..." (golint)
  • Line 550: warning: comment on exported method Message.WithEmptyPrivateData should be of the form "WithEmptyPrivateData ..." (golint)
  • Line 558: warning: exported method Transaction.IsPrivate should have comment or be unexported (golint)
  • Line 565: warning: comment on exported method Transaction.SetPrivate should be of the form "SetPrivate ..." (golint)

• quorum/eth/api.go
  • Line 64: warning: comment on exported method PublicEthereumAPI.StorageRoot should be of the form "StorageRoot ..." (golint)
  • Line 67: warning: receiver name s should be consistent with previous receiver name api for PublicEthereumAPI (golint)
  • Line 326: warning: exported method PublicDebugAPI.PrivateStateRoot should have comment or be unexported (golint)
  • Line 334: warning: comment on exported method PublicDebugAPI.DumpAddress should be of the form "DumpAddress ..." (golint)

• quorum/eth/protocol.go
  • Line 77: warning: exported const ErrMsgTooLarge should have comment (or a comment on this block) or be unexported (golint)

• quorum/les/odr_requests.go
  • Line 48: warning: exported type LesOdrRequest should have comment or be unexported (golint)
  • Line 55: warning: exported function LesRequest should have comment or be unexported (golint)
  • Line 96: warning: comment on exported method BlockRequest.Validate should be of the form "Validate ..." (golint)
  • Line 154: warning: comment on exported method ReceiptsRequest.Validate should be of the form "Validate ..." (golint)
  • Line 185: warning: exported type ProofReq should have comment or be unexported (golint)
  • Line 191: warning: comment on exported type TrieRequest should be of the form "TrieRequest ..." (with optional leading article) (golint)
  • Line 216: warning: comment on exported method TrieRequest.Validate should be of the form "Validate ..." (golint)
  • Line 240: warning: exported type CodeReq should have comment or be unexported (golint)
  • Line 245: warning: comment on exported type CodeRequest should be of the form "CodeRequest ..." (with optional leading article) (golint)
  • Line 269: warning: comment on exported method CodeRequest.Validate should be of the form "Validate ..." (golint)
  • Line 304: warning: exported type HelperTrieReq should have comment or be unexported (golint)
  • Line 311: warning: exported type HelperTrieResps should have comment or be unexported (golint)
  • Line 316: warning: comment on exported type ChtRequest should be of the form "ChtRequest ..." (with optional leading article) (golint)
  • Line 332: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 351: warning: comment on exported method ChtRequest.Validate should be of the form "Validate ..." (golint)
  • Line 409: warning: exported type BloomReq should have comment or be unexported (golint)
  • Line 413: warning: comment on exported type BloomRequest should be of the form "BloomRequest ..." (with optional leading article) (golint)
  • Line 452: warning: comment on exported method BloomRequest.Validate should be of the form "Validate ..." (golint)
  • Line 509: warning: comment on exported method TxStatusRequest.Validate should be of the form "Validate ..." (golint)

• quorum/raft/minter_test.go
  • Line 174: warning: error should be the last type when returning multiple items (golint)

• quorum/consensus/istanbul/ibft/types/state.go
  • Line 3: warning: exported type State should have comment or be unexported (golint)
  • Line 6: warning: exported const StateAcceptRequest should have comment (or a comment on this block) or be unexported (golint)

• quorum/accounts/abi/bind/backends/simulated.go
  • Line 94: warning: comment on exported function NewSimulatedBackendFrom should be of the form "NewSimulatedBackendFrom ..." (golint)

• quorum/graphql/graphql.go
  • Line 54: warning: exported method Account.Address should have comment or be unexported (golint)
  • Line 58: warning: exported method Account.Balance should have comment or be unexported (golint)
  • Line 66: warning: exported method Account.TransactionCount should have comment or be unexported (golint)
  • Line 74: warning: exported method Account.Code should have comment or be unexported (golint)
  • Line 82: warning: exported method Account.Storage should have comment or be unexported (golint)
  • Line 97: warning: exported method Log.Transaction should have comment or be unexported (golint)
  • Line 101: warning: exported method Log.Account should have comment or be unexported (golint)
  • Line 109: warning: exported method Log.Index should have comment or be unexported (golint)
  • Line 113: warning: exported method Log.Topics should have comment or be unexported (golint)
  • Line 117: warning: exported method Log.Data should have comment or be unexported (golint)
  • Line 150: warning: exported method Transaction.Hash should have comment or be unexported (golint)
  • Line 154: warning: exported method Transaction.InputData should have comment or be unexported (golint)
  • Line 162: warning: exported method Transaction.Gas should have comment or be unexported (golint)
  • Line 170: warning: exported method Transaction.GasPrice should have comment or be unexported (golint)
  • Line 178: warning: exported method Transaction.Value should have comment or be unexported (golint)
  • Line 186: warning: exported method Transaction.Nonce should have comment or be unexported (golint)
  • Line 194: warning: exported method Transaction.To should have comment or be unexported (golint)
  • Line 210: warning: exported method Transaction.From should have comment or be unexported (golint)
  • Line 228: warning: exported method Transaction.Block should have comment or be unexported (golint)
  • Line 235: warning: exported method Transaction.Index should have comment or be unexported (golint)
  • Line 261: warning: exported method Transaction.Status should have comment or be unexported (golint)
  • Line 270: warning: exported method Transaction.GasUsed should have comment or be unexported (golint)
  • Line 279: warning: exported method Transaction.CumulativeGasUsed should have comment or be unexported (golint)
  • Line 288: warning: exported method Transaction.CreatedContract should have comment or be unexported (golint)
  • Line 300: warning: exported method Transaction.Logs should have comment or be unexported (golint)
  • Line 316: warning: comment on exported method Transaction.IsPrivate should be of the form "IsPrivate ..." (golint)
  • Line 327: warning: exported method Transaction.PrivateInputData should have comment or be unexported (golint)
  • Line 352: warning: exported method Transaction.R should have comment or be unexported (golint)
  • Line 361: warning: exported method Transaction.S should have comment or be unexported (golint)
  • Line 370: warning: exported method Transaction.V should have comment or be unexported (golint)
  • Line 379: warning: exported type BlockType should have comment or be unexported (golint)
  • Line 453: warning: exported method Block.Number should have comment or be unexported (golint)
  • Line 462: warning: exported method Block.Hash should have comment or be unexported (golint)
  • Line 473: warning: exported method Block.GasLimit should have comment or be unexported (golint)
  • Line 481: warning: exported method Block.GasUsed should have comment or be unexported (golint)
  • Line 489: warning: exported method Block.Parent should have comment or be unexported (golint)
  • Line 507: warning: exported method Block.Difficulty should have comment or be unexported (golint)
  • Line 515: warning: exported method Block.Timestamp should have comment or be unexported (golint)
  • Line 523: warning: exported method Block.Nonce should have comment or be unexported (golint)
  • Line 531: warning: exported method Block.MixHash should have comment or be unexported (golint)
  • Line 539: warning: exported method Block.TransactionsRoot should have comment or be unexported (golint)
  • Line 547: warning: exported method Block.StateRoot should have comment or be unexported (golint)
  • Line 555: warning: exported method Block.ReceiptsRoot should have comment or be unexported (golint)
  • Line 563: warning: exported method Block.OmmerHash should have comment or be unexported (golint)
  • Line 571: warning: exported method Block.OmmerCount should have comment or be unexported (golint)
  • Line 580: warning: exported method Block.Ommers should have comment or be unexported (golint)
  • Line 597: warning: exported method Block.ExtraData should have comment or be unexported (golint)
  • Line 605: warning: exported method Block.LogsBloom should have comment or be unexported (golint)
  • Line 613: warning: exported method Block.TotalDifficulty should have comment or be unexported (golint)
  • Line 649: warning: exported method Block.Miner should have comment or be unexported (golint)
  • Line 661: warning: exported method Block.TransactionCount should have comment or be unexported (golint)
  • Line 670: warning: exported method Block.Transactions should have comment or be unexported (golint)
  • Line 688: warning: exported method Block.TransactionAt should have comment or be unexported (golint)
  • Line 707: warning: exported method Block.OmmerAt should have comment or be unexported (golint)
  • Line 762: warning: exported method Block.Logs should have comment or be unexported (golint)
  • Line 790: warning: exported method Block.Account should have comment or be unexported (golint)
  • Line 824: warning: exported method CallResult.Data should have comment or be unexported (golint)
  • Line 828: warning: exported method CallResult.GasUsed should have comment or be unexported (golint)
  • Line 832: warning: exported method CallResult.Status should have comment or be unexported (golint)
  • Line 836: warning: exported method Block.Call should have comment or be unexported (golint)
  • Line 863: warning: exported method Block.EstimateGas should have comment or be unexported (golint)
  • Line 876: warning: exported type Pending should have comment or be unexported (golint)
  • Line 880: warning: exported method Pending.TransactionCount should have comment or be unexported (golint)
  • Line 885: warning: exported method Pending.Transactions should have comment or be unexported (golint)
  • Line 902: warning: exported method Pending.Account should have comment or be unexported (golint)
  • Line 913: warning: exported method Pending.Call should have comment or be unexported (golint)
  • Line 935: warning: exported method Pending.EstimateGas should have comment or be unexported (golint)
  • Line 947: warning: exported method Resolver.Block should have comment or be unexported (golint)
  • Line 984: warning: exported method Resolver.Blocks should have comment or be unexported (golint)
  • Line 1010: warning: exported method Resolver.Pending should have comment or be unexported (golint)
  • Line 1014: warning: exported method Resolver.Transaction should have comment or be unexported (golint)
  • Line 1029: warning: exported method Resolver.SendRawTransaction should have comment or be unexported (golint)
  • Line 1058: warning: exported method Resolver.Logs should have comment or be unexported (golint)
  • Line 1085: warning: exported method Resolver.GasPrice should have comment or be unexported (golint)
  • Line 1090: warning: exported method Resolver.ProtocolVersion should have comment or be unexported (golint)
  • Line 1094: warning: exported method Resolver.ChainID should have comment or be unexported (golint)
  • Line 1103: warning: exported method SyncState.StartingBlock should have comment or be unexported (golint)
  • Line 1107: warning: exported method SyncState.CurrentBlock should have comment or be unexported (golint)
  • Line 1111: warning: exported method SyncState.HighestBlock should have comment or be unexported (golint)
  • Line 1115: warning: exported method SyncState.PulledStates should have comment or be unexported (golint)
  • Line 1120: warning: exported method SyncState.KnownStates should have comment or be unexported (golint)

• quorum/les/client.go
  • Line 49: warning: exported type LightEthereum should have comment or be unexported (golint)
  • Line 205: warning: exported type LightDummyAPI should have comment or be unexported (golint)
  • Line 267: warning: exported method LightEthereum.ResetWithGenesisBlock should have comment or be unexported (golint)
  • Line 271: warning: exported method LightEthereum.BlockChain should have comment or be unexported (golint)
  • Line 272: warning: exported method LightEthereum.TxPool should have comment or be unexported (golint)
  • Line 273: warning: exported method LightEthereum.Engine should have comment or be unexported (golint)
  • Line 274: warning: exported method LightEthereum.LesVersion should have comment or be unexported (golint)
  • Line 275: warning: exported method LightEthereum.Downloader should have comment or be unexported (golint)
  • Line 276: warning: exported method LightEthereum.EventMux should have comment or be unexported (golint)

• quorum/cmd/devp2p/internal/ethtest/chain.go
  • Line 36: warning: exported type Chain should have comment or be unexported (golint)
  • Line 41: warning: exported method Chain.WriteTo should have comment or be unexported (golint)
  • Line 87: warning: exported method Chain.GetHeaders should have comment or be unexported (golint)

• quorum/internal/build/env.go
  • Line 30: warning: comment on exported var GitCommitFlag should be of the form "GitCommitFlag ..." (golint)
  • Line 32: warning: exported var GitBranchFlag should have comment or be unexported (golint)

• quorum/plugin/helloworld/connector.go
  • Line 12: warning: exported const ConnectorName should have comment or be unexported (golint)
  • Line 14: warning: exported type PluginConnector should have comment or be unexported (golint)
  • Line 18: warning: exported method PluginConnector.GRPCServer should have comment or be unexported (golint)
  • Line 22: warning: exported method PluginConnector.GRPCClient should have comment or be unexported (golint)

• quorum/consensus/istanbul/common/errors.go
  • Line 35: warning: comment on exported var ErrInvalidTimestamp should be of the form "ErrInvalidTimestamp ..." (golint)
  • Line 91: warning: comment on exported var ErrInvalidSigner should be of the form "ErrInvalidSigner ..." (golint)

• quorum/miner/miner.go
  • Line 70: warning: exported function New should have comment or be unexported (golint)
  • Line 149: warning: exported method Miner.Start should have comment or be unexported (golint)
  • Line 153: warning: exported method Miner.Stop should have comment or be unexported (golint)
  • Line 157: warning: exported method Miner.Close should have comment or be unexported (golint)
  • Line 161: warning: exported method Miner.Mining should have comment or be unexported (golint)
  • Line 165: warning: exported method Miner.HashRate should have comment or be unexported (golint)
  • Line 172: warning: exported method Miner.SetExtra should have comment or be unexported (golint)
  • Line 186: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 199: warning: exported method Miner.SetEtherbase should have comment or be unexported (golint)

• quorum/permission/core/permissions.go
  • Line 16: warning: comment on exported function IsNodePermissioned should be of the form "IsNodePermissioned ..." (golint)
  • Line 39: warning: exported function ParsePermissionedNodes should have comment or be unexported (golint)
  • Line 108: warning: comment on exported function CheckAccountPermission should be of the form "CheckAccountPermission ..." (golint)

• quorum/p2p/simulations/test.go
  • Line 34: warning: exported function NewNoopService should have comment or be unexported (golint)
  • Line 40: warning: exported method NoopService.Protocols should have comment or be unexported (golint)
  • Line 65: warning: exported method NoopService.APIs should have comment or be unexported (golint)
  • Line 69: warning: exported method NoopService.Start should have comment or be unexported (golint)
  • Line 73: warning: exported method NoopService.Stop should have comment or be unexported (golint)
  • Line 77: warning: exported function VerifyRing should have comment or be unexported (golint)
  • Line 96: warning: exported function VerifyChain should have comment or be unexported (golint)
  • Line 115: warning: exported function VerifyFull should have comment or be unexported (golint)
  • Line 133: warning: exported function VerifyStar should have comment or be unexported (golint)

• quorum/consensus/istanbul/backend/snapshot.go
  • Line 200: warning: comment on exported method Snapshot.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
  • Line 219: warning: comment on exported method Snapshot.MarshalJSON should be of the form "MarshalJSON ..." (golint)

• quorum/extension/extensionContracts/extensionHandler.go
  • Line 1: warning: don't use MixedCaps in package name; extensionContracts should be extensioncontracts (golint)
  • Line 5: warning: exported function UnpackStateSharedLog should have comment or be unexported (golint)
  • Line 13: warning: exported function UnpackNewExtensionCreatedLog should have comment or be unexported (golint)

• quorum/plugin/initializer/connector.go
  • Line 12: warning: exported const ConnectorName should have comment or be unexported (golint)
  • Line 14: warning: exported type PluginConnector should have comment or be unexported (golint)
  • Line 18: warning: exported method PluginConnector.GRPCServer should have comment or be unexported (golint)
  • Line 22: warning: exported method PluginConnector.GRPCClient should have comment or be unexported (golint)

• quorum/rlp/encode_test.go
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/p2p/discover/v5wire/session.go
  • Line 64: warning: exported function NewSessionCache should have comment or be unexported (golint)

• quorum/consensus/istanbul/config.go
  • Line 25: warning: exported type ProposerPolicyId should have comment or be unexported (golint)
  • Line 28: warning: exported const RoundRobin should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported function NewProposerPolicy should have comment or be unexported (golint)
  • Line 57: warning: exported method ProposerPolicy.MarshalTOML should have comment or be unexported (golint)
  • Line 62: warning: exported method ProposerPolicy.UnmarshalTOML should have comment or be unexported (golint)
  • Line 96: warning: exported type Config should have comment or be unexported (golint)
  • Line 106: warning: exported var DefaultConfig should have comment or be unexported (golint)

• quorum/crypto/bls12381/fp_test.go
  • Line 67: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 68: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 69: warning: don't use underscores in Go names; var big_c should be bigC (golint)
  • Line 71: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 72: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 101: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 101: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 103: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 104: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 133: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 133: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 171: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 223: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 223: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 306: warning: don't use underscores in Go names; var big_a should be bigA (golint)
  • Line 307: warning: don't use underscores in Go names; var big_b should be bigB (golint)
  • Line 308: warning: don't use underscores in Go names; var big_c should be bigC (golint)
  • Line 310: warning: don't use underscores in Go names; var out_1 should be out1 (golint)
  • Line 311: warning: don't use underscores in Go names; var out_2 should be out2 (golint)
  • Line 323: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 323: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 337: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 491: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 492: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 530: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 583: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 583: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 657: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 657: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 671: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 874: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 875: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 913: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 966: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 966: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1042: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1042: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1056: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 1183: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1184: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1222: warning: don't use underscores in Go names; var c_x should be cX (golint)
  • Line 1247: warning: don't use underscores in Go names; var c_1 should be c1 (golint)
  • Line 1247: warning: don't use underscores in Go names; var c_2 should be c2 (golint)
  • Line 1261: warning: don't use underscores in Go names; var c_x should be cX (golint)

• quorum/mobile/vm.go
  • Line 33: warning: exported method Log.GetAddress should have comment or be unexported (golint)
  • Line 34: warning: exported method Log.GetTopics should have comment or be unexported (golint)
  • Line 35: warning: exported method Log.GetData should have comment or be unexported (golint)
  • Line 36: warning: exported method Log.GetBlockNumber should have comment or be unexported (golint)
  • Line 37: warning: exported method Log.GetTxHash should have comment or be unexported (golint)
  • Line 38: warning: exported method Log.GetTxIndex should have comment or be unexported (golint)
  • Line 39: warning: exported method Log.GetBlockHash should have comment or be unexported (golint)
  • Line 40: warning: exported method Log.GetIndex should have comment or be unexported (golint)

• quorum/metrics/syslog.go
  • Line 11: warning: comment on exported function Syslog should be of the form "Syslog ..." (golint)

• quorum/private/private.go
  • Line 18: warning: comment on exported var P should be of the form "P ..." (golint)
  • Line 24: warning: exported type Identifiable should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type PrivateTransactionManager should be of the form "PrivateTransactionManager ..." (with optional leading article) (golint)
  • Line 48: warning: comment on exported function GetLegacyEnvironmentConfig should be of the form "GetLegacyEnvironmentConfig ..." (golint)
  • Line 53: warning: exported function FromEnvironmentOrNil should have comment or be unexported (golint)
  • Line 63: warning: exported function InitialiseConnection should have comment or be unexported (golint)
  • Line 69: warning: exported function IsQuorumPrivacyEnabled should have comment or be unexported (golint)
  • Line 73: warning: exported function NewPrivateTxManager should have comment or be unexported (golint)

• quorum/common/types.go
  • Line 46: warning: exported var ErrNotPrivateContract should have comment or be unexported (golint)
  • Line 53: warning: comment on exported type EncryptedPayloadHash should be of the form "EncryptedPayloadHash ..." (with optional leading article) (golint)
  • Line 56: warning: comment on exported type EncryptedPayloadHashes should be of the form "EncryptedPayloadHashes ..." (with optional leading article) (golint)
  • Line 67: warning: exported function Base64ToEncryptedPayloadHash should have comment or be unexported (golint)
  • Line 75: warning: exported method EncryptedPayloadHash.SetBytes should have comment or be unexported (golint)
  • Line 83: warning: exported method EncryptedPayloadHash.Hex should have comment or be unexported (golint)
  • Line 87: warning: exported method EncryptedPayloadHash.Bytes should have comment or be unexported (golint)
  • Line 95: warning: exported method EncryptedPayloadHash.ToBase64 should have comment or be unexported (golint)
  • Line 99: warning: exported method EncryptedPayloadHash.TerminalString should have comment or be unexported (golint)
  • Line 103: warning: exported method EncryptedPayloadHash.BytesTypeRef should have comment or be unexported (golint)
  • Line 108: warning: exported function EmptyEncryptedPayloadHash should have comment or be unexported (golint)
  • Line 123: warning: exported function StringToHash should have comment or be unexported (golint)
  • Line 185: warning: exported function EmptyHash should have comment or be unexported (golint)
  • Line 198: warning: exported method Hash.ToBase64 should have comment or be unexported (golint)
  • Line 202: warning: comment on exported function Base64ToHash should be of the form "Base64ToHash ..." (golint)
  • Line 261: warning: exported method EncryptedPayloadHashes.ToBase64s should have comment or be unexported (golint)
  • Line 269: warning: exported method EncryptedPayloadHashes.NotExist should have comment or be unexported (golint)
  • Line 274: warning: exported method EncryptedPayloadHashes.Add should have comment or be unexported (golint)
  • Line 278: warning: exported function Base64sToEncryptedPayloadHashes should have comment or be unexported (golint)
  • Line 290: warning: comment on exported function FormatTerminalString should be of the form "FormatTerminalString ..." (golint)
  • Line 296: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 316: warning: exported function StringToAddress should have comment or be unexported (golint)
  • Line 504: warning: exported type DecryptRequest should have comment or be unexported (golint)

• quorum/accounts/abi/bind/bind.go
  • Line 41: warning: exported const LangGo should have comment (or a comment on this block) or be unexported (golint)

• quorum/consensus/ethash/ethash.go
  • Line 44: warning: exported var ErrInvalidDumpMagic should have comment or be unexported (golint)
  • Line 395: warning: exported const ModeNormal should have comment (or a comment on this block) or be unexported (golint)

• quorum/les/lespay/client/requestbasket.go
  • Line 237: warning: receiver name r should be consistent with previous receiver name b for requestBasket (golint)
  • Line 242: warning: receiver name r should be consistent with previous receiver name b for requestBasket (golint)
  • Line 259: warning: receiver name r should be consistent with previous receiver name b for requestBasket (golint)

• quorum/p2p/enode/idscheme.go
  • Line 31: warning: comment on exported var ValidSchemes should be of the form "ValidSchemes ..." (golint)
  • Line 36: warning: exported var ValidSchemesForTesting should have comment or be unexported (golint)
  • Line 41: warning: comment on exported type V4ID should be of the form "V4ID ..." (with optional leading article) (golint)
  • Line 64: warning: exported method V4ID.Verify should have comment or be unexported (golint)
  • Line 80: warning: exported method V4ID.NodeAddr should have comment or be unexported (golint)
  • Line 95: warning: exported method Secp256k1.ENRKey should have comment or be unexported (golint)
  • Line 143: warning: exported method NullID.Verify should have comment or be unexported (golint)
  • Line 147: warning: exported method NullID.NodeAddr should have comment or be unexported (golint)
  • Line 153: warning: exported function SignNull should have comment or be unexported (golint)

• quorum/private/engine/common.go
  • Line 12: warning: exported const PrivacyGroupResident should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported var ErrPrivateTxManagerNotinUse should have comment or be unexported (golint)
  • Line 24: warning: exported type PrivacyGroup should have comment or be unexported (golint)
  • Line 33: warning: comment on exported type ExtraMetadata should be of the form "ExtraMetadata ..." (with optional leading article) (golint)
  • Line 48: warning: exported type Client should have comment or be unexported (golint)
  • Line 53: warning: exported method Client.FullPath should have comment or be unexported (golint)
  • Line 57: warning: exported method Client.Get should have comment or be unexported (golint)
  • Line 65: warning: exported type PrivacyFlagType should have comment or be unexported (golint)
  • Line 68: warning: exported const PrivacyFlagStandardPrivate should have comment (or a comment on this block) or be unexported (golint)
  • Line 73: warning: exported method PrivacyFlagType.IsNotStandardPrivate should have comment or be unexported (golint)
  • Line 77: warning: exported method PrivacyFlagType.IsStandardPrivate should have comment or be unexported (golint)
  • Line 81: warning: exported method PrivacyFlagType.Has should have comment or be unexported (golint)
  • Line 85: warning: exported method PrivacyFlagType.HasAll should have comment or be unexported (golint)
  • Line 93: warning: exported method PrivacyFlagType.Validate should have comment or be unexported (golint)
  • Line 100: warning: exported type PrivateTransactionManagerFeature should have comment or be unexported (golint)
  • Line 103: warning: exported const None should have comment (or a comment on this block) or be unexported (golint)
  • Line 109: warning: exported type FeatureSet should have comment or be unexported (golint)
  • Line 113: warning: exported function NewFeatureSet should have comment or be unexported (golint)
  • Line 121: warning: exported method FeatureSet.HasFeature should have comment or be unexported (golint)

• quorum/cmd/evm/main.go
  • Line 37: warning: exported var DebugFlag should have comment or be unexported (golint)

• quorum/console/bridge.go
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/internal/plugin/protocol.go
  • Line 10: warning: exported const DefaultProtocolVersion should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported var DefaultHandshakeConfig should have comment or be unexported (golint)

• quorum/core/genesis.go
  • Line 70: warning: exported method GenesisAlloc.UnmarshalJSON should have comment or be unexported (golint)
  • Line 418: warning: exported function DefaultYoloV2GenesisBlock should have comment or be unexported (golint)

• quorum/core/vm/runtime/runtime_test.go
  • Line 162: warning: don't use underscores in Go names; func benchmarkEVM_Create should be benchmarkEVMCreate (golint)

• quorum/eth/gasprice/gasprice.go
  • Line 34: warning: exported var DefaultMaxPrice should have comment or be unexported (golint)
  • Line 36: warning: exported type Config should have comment or be unexported (golint)

• quorum/metrics/healthcheck.go
  • Line 3: warning: comment on exported type Healthcheck should be of the form "Healthcheck ..." (with optional leading article) (golint)

• quorum/core/multiple_psm.go
  • Line 17: warning: exported type MultiplePrivateStateManager should have comment or be unexported (golint)
  • Line 35: warning: exported method MultiplePrivateStateManager.StateRepository should have comment or be unexported (golint)
  • Line 40: warning: exported method MultiplePrivateStateManager.ResolveForManagedParty should have comment or be unexported (golint)
  • Line 48: warning: exported method MultiplePrivateStateManager.ResolveForUserContext should have comment or be unexported (golint)
  • Line 60: warning: exported method MultiplePrivateStateManager.PSIs should have comment or be unexported (golint)
  • Line 68: warning: exported method MultiplePrivateStateManager.NotIncludeAny should have comment or be unexported (golint)
  • Line 72: warning: exported method MultiplePrivateStateManager.CheckAt should have comment or be unexported (golint)
  • Line 77: warning: exported method MultiplePrivateStateManager.TrieDB should have comment or be unexported (golint)

• quorum/cmd/evm/internal/t8ntool/transition.go
  • Line 39: warning: exported const ErrorEVM should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported type NumberedError should have comment or be unexported (golint)
  • Line 54: warning: exported function NewError should have comment or be unexported (golint)
  • Line 62: warning: exported method NumberedError.Code should have comment or be unexported (golint)
  • Line 72: warning: exported function Main should have comment or be unexported (golint)
  • Line 196: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 216: warning: exported type Alloc should have comment or be unexported (golint)
  • Line 218: warning: exported method Alloc.OnRoot should have comment or be unexported (golint)
  • Line 220: warning: exported method Alloc.OnAccount should have comment or be unexported (golint)

• quorum/common/math/big.go
  • Line 74: warning: comment on exported function NewDecimal256 should be of the form "NewDecimal256 ..." (golint)

• quorum/cmd/utils/customflags.go
  • Line 33: warning: comment on exported type DirectoryString should be of the form "DirectoryString ..." (with optional leading article) (golint)
  • Line 42: warning: exported method DirectoryString.Set should have comment or be unexported (golint)
  • Line 47: warning: comment on exported type DirectoryFlag should be of the form "DirectoryFlag ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported method DirectoryFlag.Apply should be of the form "Apply ..." (golint)
  • Line 68: warning: exported method DirectoryFlag.GetName should have comment or be unexported (golint)
  • Line 72: warning: exported method DirectoryFlag.Set should have comment or be unexported (golint)
  • Line 84: warning: exported type TextMarshaler should have comment or be unexported (golint)
  • Line 114: warning: exported method TextMarshalerFlag.GetName should have comment or be unexported (golint)
  • Line 122: warning: exported method TextMarshalerFlag.Apply should have comment or be unexported (golint)
  • Line 165: warning: exported method BigFlag.GetName should have comment or be unexported (golint)
  • Line 173: warning: exported method BigFlag.Apply should have comment or be unexported (golint)
  • Line 202: warning: exported function HomeDir should have comment or be unexported (golint)

• quorum/core/mps/multiple_psr.go
  • Line 32: warning: exported function NewMultiplePrivateStateRepository should have comment or be unexported (golint)
  • Line 58: warning: exported method MultiplePrivateStateRepository.DefaultState should have comment or be unexported (golint)
  • Line 62: warning: exported method MultiplePrivateStateRepository.DefaultStateMetadata should have comment or be unexported (golint)
  • Line 66: warning: exported method MultiplePrivateStateRepository.IsMPS should have comment or be unexported (golint)
  • Line 70: warning: exported method MultiplePrivateStateRepository.StatePSI should have comment or be unexported (golint)
  • Line 111: warning: exported method MultiplePrivateStateRepository.Reset should have comment or be unexported (golint)
  • Line 132: warning: comment on exported method MultiplePrivateStateRepository.CommitAndWrite should be of the form "CommitAndWrite ..." (golint)
  • Line 166: warning: comment on exported method MultiplePrivateStateRepository.Commit should be of the form "Commit ..." (golint)
  • Line 190: warning: exported method MultiplePrivateStateRepository.Copy should have comment or be unexported (golint)
  • Line 205: warning: exported method MultiplePrivateStateRepository.MergeReceipts should have comment or be unexported (golint)

• quorum/internal/ethapi/api_test.go
  • Line 743: warning: receiver name sb should be consistent with previous receiver name msb for MPSStubBackend (golint)
  • Line 846: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/signer/core/signed_data.go
  • Line 43: warning: exported type SigFormat should have comment or be unexported (golint)
  • Line 49: warning: exported var IntendedValidator should have comment or be unexported (golint)
  • Line 67: warning: exported type ValidatorData should have comment or be unexported (golint)
  • Line 72: warning: exported type TypedData should have comment or be unexported (golint)
  • Line 79: warning: exported type Type should have comment or be unexported (golint)
  • Line 105: warning: exported type Types should have comment or be unexported (golint)
  • Line 107: warning: exported type TypePriority should have comment or be unexported (golint)
  • Line 112: warning: exported type TypedDataMessage should have comment or be unexported (golint)
  • Line 114: warning: exported type TypedDataDomain should have comment or be unexported (golint)
  • Line 267: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 270: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 288: warning: comment on exported function SignTextValidator should be of the form "SignTextValidator ..." (golint)
  • Line 617: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 810: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 816: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 829: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/cmd/evm/internal/compiler/compiler.go
  • Line 26: warning: exported function Compile should have comment or be unexported (golint)

• quorum/common/http/client.go
  • Line 12: warning: exported function CreateClient should have comment or be unexported (golint)

• quorum/metrics/timer.go
  • Line 8: warning: comment on exported type Timer should be of the form "Timer ..." (with optional leading article) (golint)
  • Line 221: warning: comment on exported method StandardTimer.Time should be of the form "Time ..." (golint)
  • Line 228: warning: comment on exported method StandardTimer.Update should be of the form "Update ..." (golint)
  • Line 236: warning: comment on exported method StandardTimer.UpdateSince should be of the form "UpdateSince ..." (golint)

• quorum/core/tx_pool.go
  • Line 86: warning: exported var ErrInvalidGasPrice should have comment or be unexported (golint)
  • Line 128: warning: exported const TxStatusUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 799: warning: comment on exported method TxPool.AddRemotesSync should be of the form "AddRemotesSync ..." (golint)
  • Line 1651: warning: comment on exported function GetChainHeadChannleSize should be of the form "GetChainHeadChannleSize ..." (golint)

• quorum/eth/filters/filter.go
  • Line 36: warning: exported type Backend should have comment or be unexported (golint)

• quorum/core/rawdb/database_quorum.go
  • Line 1: warning: package comment should be of the form "Package rawdb ..." (golint)
  • Line 42: warning: comment on exported function GetIsQuorumEIP155Activated should be of the form "GetIsQuorumEIP155Activated ..." (golint)
  • Line 54: warning: exported function GetPrivateStateRoot should have comment or be unexported (golint)
  • Line 59: warning: exported function GetPrivateStatesTrieRoot should have comment or be unexported (golint)
  • Line 64: warning: exported function GetAccountExtraDataRoot should have comment or be unexported (golint)
  • Line 69: warning: exported function WritePrivateStateRoot should have comment or be unexported (golint)
  • Line 73: warning: exported function WritePrivateStatesTrieRoot should have comment or be unexported (golint)
  • Line 119: warning: exported function NewAccountExtraDataLinker should have comment or be unexported (golint)

• quorum/log/logger.go
  • Line 18: warning: exported type Lvl should have comment or be unexported (golint)
  • Line 21: warning: exported const LvlCrit should have comment (or a comment on this block) or be unexported (golint)

• quorum/p2p/enr/enr.go
  • Line 46: warning: exported const SizeLimit should have comment or be unexported (golint)
  • Line 49: warning: exported var ErrInvalidSig should have comment or be unexported (golint)
  • Line 68: warning: exported method SchemeMap.Verify should have comment or be unexported (golint)
  • Line 76: warning: exported method SchemeMap.NodeAddr should have comment or be unexported (golint)

• quorum/p2p/discover/v5wire/msg.go
  • Line 62: warning: comment on exported type Whoareyou should be of the form "Whoareyou ..." (with optional leading article) (golint)
  • Line 76: warning: comment on exported type Ping should be of the form "Ping ..." (with optional leading article) (golint)
  • Line 82: warning: comment on exported type Pong should be of the form "Pong ..." (with optional leading article) (golint)
  • Line 90: warning: comment on exported type Findnode should be of the form "Findnode ..." (with optional leading article) (golint)
  • Line 96: warning: comment on exported type Nodes should be of the form "Nodes ..." (with optional leading article) (golint)
  • Line 103: warning: comment on exported type TalkRequest should be of the form "TalkRequest ..." (with optional leading article) (golint)
  • Line 110: warning: comment on exported type TalkResponse should be of the form "TalkResponse ..." (with optional leading article) (golint)
  • Line 116: warning: comment on exported type RequestTicket should be of the form "RequestTicket ..." (with optional leading article) (golint)
  • Line 122: warning: comment on exported type Ticket should be of the form "Ticket ..." (with optional leading article) (golint)
  • Line 128: warning: comment on exported type Regtopic should be of the form "Regtopic ..." (with optional leading article) (golint)
  • Line 135: warning: comment on exported type Regconfirmation should be of the form "Regconfirmation ..." (with optional leading article) (golint)
  • Line 141: warning: comment on exported type TopicQuery should be of the form "TopicQuery ..." (with optional leading article) (golint)
  • Line 186: warning: exported method Whoareyou.Name should have comment or be unexported (golint)
  • Line 187: warning: exported method Whoareyou.Kind should have comment or be unexported (golint)
  • Line 188: warning: exported method Whoareyou.RequestID should have comment or be unexported (golint)
  • Line 189: warning: exported method Whoareyou.SetRequestID should have comment or be unexported (golint)
  • Line 191: warning: exported method Unknown.Name should have comment or be unexported (golint)
  • Line 192: warning: exported method Unknown.Kind should have comment or be unexported (golint)
  • Line 193: warning: exported method Unknown.RequestID should have comment or be unexported (golint)
  • Line 194: warning: exported method Unknown.SetRequestID should have comment or be unexported (golint)
  • Line 196: warning: exported method Ping.Name should have comment or be unexported (golint)
  • Line 197: warning: exported method Ping.Kind should have comment or be unexported (golint)
  • Line 198: warning: exported method Ping.RequestID should have comment or be unexported (golint)
  • Line 199: warning: exported method Ping.SetRequestID should have comment or be unexported (golint)
  • Line 201: warning: exported method Pong.Name should have comment or be unexported (golint)
  • Line 202: warning: exported method Pong.Kind should have comment or be unexported (golint)
  • Line 203: warning: exported method Pong.RequestID should have comment or be unexported (golint)
  • Line 204: warning: exported method Pong.SetRequestID should have comment or be unexported (golint)
  • Line 206: warning: exported method Findnode.Name should have comment or be unexported (golint)
  • Line 207: warning: exported method Findnode.Kind should have comment or be unexported (golint)
  • Line 208: warning: exported method Findnode.RequestID should have comment or be unexported (golint)
  • Line 209: warning: exported method Findnode.SetRequestID should have comment or be unexported (golint)
  • Line 211: warning: exported method Nodes.Name should have comment or be unexported (golint)
  • Line 212: warning: exported method Nodes.Kind should have comment or be unexported (golint)
  • Line 213: warning: exported method Nodes.RequestID should have comment or be unexported (golint)
  • Line 214: warning: exported method Nodes.SetRequestID should have comment or be unexported (golint)
  • Line 216: warning: exported method TalkRequest.Name should have comment or be unexported (golint)
  • Line 217: warning: exported method TalkRequest.Kind should have comment or be unexported (golint)
  • Line 218: warning: exported method TalkRequest.RequestID should have comment or be unexported (golint)
  • Line 219: warning: exported method TalkRequest.SetRequestID should have comment or be unexported (golint)
  • Line 221: warning: exported method TalkResponse.Name should have comment or be unexported (golint)
  • Line 222: warning: exported method TalkResponse.Kind should have comment or be unexported (golint)
  • Line 223: warning: exported method TalkResponse.RequestID should have comment or be unexported (golint)
  • Line 224: warning: exported method TalkResponse.SetRequestID should have comment or be unexported (golint)
  • Line 226: warning: exported method RequestTicket.Name should have comment or be unexported (golint)
  • Line 227: warning: exported method RequestTicket.Kind should have comment or be unexported (golint)
  • Line 228: warning: exported method RequestTicket.RequestID should have comment or be unexported (golint)
  • Line 229: warning: exported method RequestTicket.SetRequestID should have comment or be unexported (golint)
  • Line 231: warning: exported method Regtopic.Name should have comment or be unexported (golint)
  • Line 232: warning: exported method Regtopic.Kind should have comment or be unexported (golint)
  • Line 233: warning: exported method Regtopic.RequestID should have comment or be unexported (golint)
  • Line 234: warning: exported method Regtopic.SetRequestID should have comment or be unexported (golint)
  • Line 236: warning: exported method Ticket.Name should have comment or be unexported (golint)
  • Line 237: warning: exported method Ticket.Kind should have comment or be unexported (golint)
  • Line 238: warning: exported method Ticket.RequestID should have comment or be unexported (golint)
  • Line 239: warning: exported method Ticket.SetRequestID should have comment or be unexported (golint)
  • Line 241: warning: exported method Regconfirmation.Name should have comment or be unexported (golint)
  • Line 242: warning: exported method Regconfirmation.Kind should have comment or be unexported (golint)
  • Line 243: warning: exported method Regconfirmation.RequestID should have comment or be unexported (golint)
  • Line 244: warning: exported method Regconfirmation.SetRequestID should have comment or be unexported (golint)
  • Line 246: warning: exported method TopicQuery.Name should have comment or be unexported (golint)
  • Line 247: warning: exported method TopicQuery.Kind should have comment or be unexported (golint)
  • Line 248: warning: exported method TopicQuery.RequestID should have comment or be unexported (golint)
  • Line 249: warning: exported method TopicQuery.SetRequestID should have comment or be unexported (golint)

• quorum/p2p/simulations/connect.go
  • Line 27: warning: exported var ErrNodeNotFound should have comment or be unexported (golint)

• quorum/tests/fuzzers/keystore/keystore-fuzzer.go
  • Line 25: warning: exported function Fuzz should have comment or be unexported (golint)

• quorum/tests/state_test_util.go
  • Line 56: warning: exported method StateTest.UnmarshalJSON should have comment or be unexported (golint)
  • Line 131: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 222: warning: exported function MakePreState should have comment or be unexported (golint)

• quorum/rpc/handler.go
  • Line 414: warning: should not use basic type string as key in context.WithValue (golint)

• quorum/consensus/istanbul/qbft/types/commit.go
  • Line 11: warning: comment on exported type Commit should be of the form "Commit ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewCommit should have comment or be unexported (golint)
  • Line 30: warning: exported method Commit.EncodePayloadForSigning should have comment or be unexported (golint)
  • Line 38: warning: exported method Commit.EncodeRLP should have comment or be unexported (golint)
  • Line 44: warning: exported method Commit.DecodeRLP should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/types/common.go
  • Line 10: warning: comment on exported type CommonPayload should be of the form "CommonPayload ..." (with optional leading article) (golint)
  • Line 19: warning: exported method CommonPayload.Code should have comment or be unexported (golint)
  • Line 23: warning: exported method CommonPayload.Source should have comment or be unexported (golint)
  • Line 27: warning: exported method CommonPayload.SetSource should have comment or be unexported (golint)
  • Line 31: warning: exported method CommonPayload.View should have comment or be unexported (golint)
  • Line 35: warning: exported method CommonPayload.Signature should have comment or be unexported (golint)
  • Line 39: warning: exported method CommonPayload.SetSignature should have comment or be unexported (golint)

• quorum/accounts/keystore/keystore.go
  • Line 44: warning: exported var ErrLocked should have comment or be unexported (golint)

• quorum/eth/downloader/events.go
  • Line 21: warning: exported type DoneEvent should have comment or be unexported (golint)
  • Line 24: warning: exported type StartEvent should have comment or be unexported (golint)
  • Line 25: warning: exported type FailedEvent should have comment or be unexported (golint)

• quorum/permission/v2/contract.go
  • Line 18: warning: exported type PermissionModelV2 should have comment or be unexported (golint)
  • Line 24: warning: exported type Audit should have comment or be unexported (golint)
  • Line 28: warning: exported type Role should have comment or be unexported (golint)
  • Line 32: warning: exported type Account should have comment or be unexported (golint)
  • Line 36: warning: exported type Control should have comment or be unexported (golint)
  • Line 40: warning: exported type Org should have comment or be unexported (golint)
  • Line 44: warning: exported type Node should have comment or be unexported (golint)
  • Line 48: warning: exported type Init should have comment or be unexported (golint)
  • Line 65: warning: exported method Account.AssignAccountRole should have comment or be unexported (golint)
  • Line 69: warning: exported method Account.UpdateAccountStatus should have comment or be unexported (golint)
  • Line 73: warning: exported method Account.StartBlacklistedAccountRecovery should have comment or be unexported (golint)
  • Line 77: warning: exported method Account.ApproveBlacklistedAccountRecovery should have comment or be unexported (golint)
  • Line 81: warning: exported method Account.ApproveAdminRole should have comment or be unexported (golint)
  • Line 85: warning: exported method Account.AssignAdminRole should have comment or be unexported (golint)
  • Line 89: warning: exported method Init.GetAccountDetailsFromIndex should have comment or be unexported (golint)
  • Line 93: warning: exported method Init.GetNumberOfAccounts should have comment or be unexported (golint)
  • Line 97: warning: exported method Init.GetRoleDetailsFromIndex should have comment or be unexported (golint)
  • Line 108: warning: exported method Init.GetNumberOfRoles should have comment or be unexported (golint)
  • Line 112: warning: exported method Init.GetNumberOfOrgs should have comment or be unexported (golint)
  • Line 116: warning: exported method Init.UpdateNetworkBootStatus should have comment or be unexported (golint)
  • Line 120: warning: exported method Init.AddAdminAccount should have comment or be unexported (golint)
  • Line 124: warning: exported method Init.AddAdminNode should have comment or be unexported (golint)
  • Line 132: warning: exported method Init.SetPolicy should have comment or be unexported (golint)
  • Line 136: warning: exported method Init.Init should have comment or be unexported (golint)
  • Line 140: warning: exported method Init.GetAccountDetails should have comment or be unexported (golint)
  • Line 144: warning: exported method Init.GetNodeDetailsFromIndex should have comment or be unexported (golint)
  • Line 152: warning: exported method Init.GetNumberOfNodes should have comment or be unexported (golint)
  • Line 156: warning: exported method Init.GetNodeDetails should have comment or be unexported (golint)
  • Line 164: warning: exported method Init.GetRoleDetails should have comment or be unexported (golint)
  • Line 175: warning: exported method Init.GetSubOrgIndexes should have comment or be unexported (golint)
  • Line 179: warning: exported method Init.GetOrgInfo should have comment or be unexported (golint)
  • Line 183: warning: exported method Init.GetNetworkBootStatus should have comment or be unexported (golint)
  • Line 187: warning: exported method Init.GetOrgDetails should have comment or be unexported (golint)
  • Line 191: warning: comment on exported method Init.BindContracts should be of the form "BindContracts ..." (golint)
  • Line 206: warning: exported method Audit.ValidatePendingOp should have comment or be unexported (golint)
  • Line 220: warning: exported method Audit.CheckPendingOp should have comment or be unexported (golint)
  • Line 225: warning: exported method Control.ConnectionAllowed should have comment or be unexported (golint)
  • Line 235: warning: exported method Control.TransactionAllowed should have comment or be unexported (golint)
  • Line 244: warning: exported method Role.RemoveRole should have comment or be unexported (golint)
  • Line 248: warning: exported method Role.AddNewRole should have comment or be unexported (golint)
  • Line 255: warning: exported method Org.ApproveOrgStatus should have comment or be unexported (golint)
  • Line 259: warning: exported method Org.UpdateOrgStatus should have comment or be unexported (golint)
  • Line 263: warning: exported method Org.ApproveOrg should have comment or be unexported (golint)
  • Line 271: warning: exported method Org.AddSubOrg should have comment or be unexported (golint)
  • Line 279: warning: exported method Org.AddOrg should have comment or be unexported (golint)
  • Line 287: warning: exported method Node.ApproveBlacklistedNodeRecovery should have comment or be unexported (golint)
  • Line 295: warning: exported method Node.StartBlacklistedNodeRecovery should have comment or be unexported (golint)
  • Line 303: warning: exported method Node.AddNode should have comment or be unexported (golint)
  • Line 312: warning: exported method Node.UpdateNodeStatus should have comment or be unexported (golint)

• quorum/signer/storage/storage.go
  • Line 29: warning: exported type Storage should have comment or be unexported (golint)
  • Line 72: warning: exported function NewEphemeralStorage should have comment or be unexported (golint)
  • Line 82: warning: exported method NoStorage.Put should have comment or be unexported (golint)
  • Line 83: warning: exported method NoStorage.Del should have comment or be unexported (golint)
  • Line 84: warning: exported method NoStorage.Get should have comment or be unexported (golint)

• quorum/tests/fuzzers/trie/trie-fuzzer.go
  • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 90: warning: exported function Generate should have comment or be unexported (golint)
  • Line 129: warning: comment on exported function Fuzz should be of the form "Fuzz ..." (golint)

• quorum/plugin/account/service.go
  • Line 10: warning: exported type Service should have comment or be unexported (golint)
  • Line 23: warning: exported type CreatorService should have comment or be unexported (golint)

• quorum/consensus/istanbul/types.go
  • Line 44: warning: exported type Request should have comment or be unexported (golint)
  • Line 96: warning: exported type Preprepare should have comment or be unexported (golint)
  • Line 121: warning: exported type Subject should have comment or be unexported (golint)

• quorum/consensus/istanbul/validator.go
  • Line 27: warning: exported type Validator should have comment or be unexported (golint)
  • Line 37: warning: exported type Validators should have comment or be unexported (golint)
  • Line 56: warning: exported type ValidatorSortByFunc should have comment or be unexported (golint)
  • Line 58: warning: exported function ValidatorSortByString should have comment or be unexported (golint)
  • Line 64: warning: exported function ValidatorSortByByte should have comment or be unexported (golint)
  • Line 70: warning: exported method ValidatorSortByFunc.Sort should have comment or be unexported (golint)
  • Line 80: warning: exported type ValidatorSet should have comment or be unexported (golint)
  • Line 112: warning: exported type ProposalSelector should have comment or be unexported (golint)

• quorum/crypto/bls12381/gt.go
  • Line 32: warning: exported method E.Set should have comment or be unexported (golint)
  • Line 48: warning: receiver name g should be consistent with previous receiver name e for E (golint)

• quorum/les/lespay/server/balance_tracker.go
  • Line 264: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/light/txpool_test.go
  • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• quorum/log/emit_checkpoint.go
  • Line 4: warning: exported const TxCreated should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported var DoEmitCheckpoints should have comment or be unexported (golint)
  • Line 16: warning: exported function EmitCheckpoint should have comment or be unexported (golint)

• quorum/p2p/nat/nat.go
  • Line 32: warning: comment on exported type Interface should be of the form "Interface ..." (with optional leading article) (golint)
  • Line 133: warning: exported method ExtIP.ExternalIP should have comment or be unexported (golint)
  • Line 138: warning: exported method ExtIP.AddMapping should have comment or be unexported (golint)
  • Line 139: warning: exported method ExtIP.DeleteMapping should have comment or be unexported (golint)
  • Line 222: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/tests/difficulty_test_util.go
  • Line 32: warning: exported type DifficultyTest should have comment or be unexported (golint)
  • Line 50: warning: exported method DifficultyTest.Run should have comment or be unexported (golint)

• quorum/trie/proof.go
  • Line 457: warning: error should be the last type when returning multiple items (golint)

• quorum/consensus/istanbul/qbft/engine/engine.go
  • Line 24: warning: exported type SignerFn should have comment or be unexported (golint)
  • Line 26: warning: exported type Engine should have comment or be unexported (golint)
  • Line 33: warning: exported function NewEngine should have comment or be unexported (golint)
  • Line 41: warning: exported method Engine.Author should have comment or be unexported (golint)
  • Line 45: warning: exported method Engine.CommitHeader should have comment or be unexported (golint)
  • Line 81: warning: exported method Engine.VerifyBlockProposal should have comment or be unexported (golint)
  • Line 105: warning: exported method Engine.VerifyHeader should have comment or be unexported (golint)
  • Line 146: warning: exported method Engine.VerifyHeaders should have comment or be unexported (golint)
  • Line 302: warning: exported method Engine.Prepare should have comment or be unexported (golint)
  • Line 331: warning: exported function WriteValidators should have comment or be unexported (golint)
  • Line 379: warning: exported method Engine.SealHash should have comment or be unexported (golint)
  • Line 384: warning: exported method Engine.CalcDifficulty should have comment or be unexported (golint)
  • Line 388: warning: exported method Engine.Validators should have comment or be unexported (golint)
  • Line 397: warning: exported method Engine.Signers should have comment or be unexported (golint)
  • Line 419: warning: exported method Engine.Address should have comment or be unexported (golint)
  • Line 444: warning: exported method Engine.WriteVote should have comment or be unexported (golint)
  • Line 451: warning: exported function WriteVote should have comment or be unexported (golint)
  • Line 464: warning: exported method Engine.ReadVote should have comment or be unexported (golint)

• quorum/core/mps/types.go
  • Line 30: warning: exported type PrivateStateType should have comment or be unexported (golint)
  • Line 33: warning: exported const Resident should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported method PrivateStateMetadata.NotIncludeAny should have comment or be unexported (golint)
  • Line 65: warning: exported function NewPrivateStateMetadata should have comment or be unexported (golint)

• quorum/les/utils/weighted_select.go
  • Line 30: warning: exported type WrsItem should have comment or be unexported (golint)
  • Line 31: warning: exported type WeightFn should have comment or be unexported (golint)

• quorum/les/lespay/client/timestats.go
  • Line 35: warning: comment on exported type ResponseTimeWeights should be of the form "ResponseTimeWeights ..." (with optional leading article) (golint)

• quorum/mobile/interface.go
  • Line 45: warning: exported method Interface.SetBool should have comment or be unexported (golint)
  • Line 46: warning: exported method Interface.SetBools should have comment or be unexported (golint)
  • Line 47: warning: exported method Interface.SetString should have comment or be unexported (golint)
  • Line 48: warning: exported method Interface.SetStrings should have comment or be unexported (golint)
  • Line 49: warning: exported method Interface.SetBinary should have comment or be unexported (golint)
  • Line 50: warning: exported method Interface.SetBinaries should have comment or be unexported (golint)
  • Line 51: warning: exported method Interface.SetAddress should have comment or be unexported (golint)
  • Line 52: warning: exported method Interface.SetAddresses should have comment or be unexported (golint)
  • Line 53: warning: exported method Interface.SetHash should have comment or be unexported (golint)
  • Line 54: warning: exported method Interface.SetHashes should have comment or be unexported (golint)
  • Line 55: warning: exported method Interface.SetInt8 should have comment or be unexported (golint)
  • Line 56: warning: exported method Interface.SetInt16 should have comment or be unexported (golint)
  • Line 57: warning: exported method Interface.SetInt32 should have comment or be unexported (golint)
  • Line 58: warning: exported method Interface.SetInt64 should have comment or be unexported (golint)
  • Line 59: warning: exported method Interface.SetInt8s should have comment or be unexported (golint)
  • Line 66: warning: exported method Interface.SetInt16s should have comment or be unexported (golint)
  • Line 73: warning: exported method Interface.SetInt32s should have comment or be unexported (golint)
  • Line 80: warning: exported method Interface.SetInt64s should have comment or be unexported (golint)
  • Line 87: warning: exported method Interface.SetUint8 should have comment or be unexported (golint)
  • Line 88: warning: exported method Interface.SetUint16 should have comment or be unexported (golint)
  • Line 89: warning: exported method Interface.SetUint32 should have comment or be unexported (golint)
  • Line 90: warning: exported method Interface.SetUint64 should have comment or be unexported (golint)
  • Line 91: warning: exported method Interface.SetUint8s should have comment or be unexported (golint)
  • Line 98: warning: exported method Interface.SetUint16s should have comment or be unexported (golint)
  • Line 105: warning: exported method Interface.SetUint32s should have comment or be unexported (golint)
  • Line 112: warning: exported method Interface.SetUint64s should have comment or be unexported (golint)
  • Line 119: warning: exported method Interface.SetBigInt should have comment or be unexported (golint)
  • Line 120: warning: exported method Interface.SetBigInts should have comment or be unexported (golint)
  • Line 122: warning: exported method Interface.SetDefaultBool should have comment or be unexported (golint)
  • Line 123: warning: exported method Interface.SetDefaultBools should have comment or be unexported (golint)
  • Line 124: warning: exported method Interface.SetDefaultString should have comment or be unexported (golint)
  • Line 125: warning: exported method Interface.SetDefaultStrings should have comment or be unexported (golint)
  • Line 126: warning: exported method Interface.SetDefaultBinary should have comment or be unexported (golint)
  • Line 127: warning: exported method Interface.SetDefaultBinaries should have comment or be unexported (golint)
  • Line 128: warning: exported method Interface.SetDefaultAddress should have comment or be unexported (golint)
  • Line 129: warning: exported method Interface.SetDefaultAddresses should have comment or be unexported (golint)
  • Line 130: warning: exported method Interface.SetDefaultHash should have comment or be unexported (golint)
  • Line 131: warning: exported method Interface.SetDefaultHashes should have comment or be unexported (golint)
  • Line 132: warning: exported method Interface.SetDefaultInt8 should have comment or be unexported (golint)
  • Line 133: warning: exported method Interface.SetDefaultInt8s should have comment or be unexported (golint)
  • Line 134: warning: exported method Interface.SetDefaultInt16 should have comment or be unexported (golint)
  • Line 135: warning: exported method Interface.SetDefaultInt16s should have comment or be unexported (golint)
  • Line 136: warning: exported method Interface.SetDefaultInt32 should have comment or be unexported (golint)
  • Line 137: warning: exported method Interface.SetDefaultInt32s should have comment or be unexported (golint)
  • Line 138: warning: exported method Interface.SetDefaultInt64 should have comment or be unexported (golint)
  • Line 139: warning: exported method Interface.SetDefaultInt64s should have comment or be unexported (golint)
  • Line 140: warning: exported method Interface.SetDefaultUint8 should have comment or be unexported (golint)
  • Line 141: warning: exported method Interface.SetDefaultUint8s should have comment or be unexported (golint)
  • Line 142: warning: exported method Interface.SetDefaultUint16 should have comment or be unexported (golint)
  • Line 143: warning: exported method Interface.SetDefaultUint16s should have comment or be unexported (golint)
  • Line 144: warning: exported method Interface.SetDefaultUint32 should have comment or be unexported (golint)
  • Line 145: warning: exported method Interface.SetDefaultUint32s should have comment or be unexported (golint)
  • Line 146: warning: exported method Interface.SetDefaultUint64 should have comment or be unexported (golint)
  • Line 147: warning: exported method Interface.SetDefaultUint64s should have comment or be unexported (golint)
  • Line 148: warning: exported method Interface.SetDefaultBigInt should have comment or be unexported (golint)
  • Line 149: warning: exported method Interface.SetDefaultBigInts should have comment or be unexported (golint)
  • Line 151: warning: exported method Interface.GetBool should have comment or be unexported (golint)
  • Line 152: warning: exported method Interface.GetBools should have comment or be unexported (golint)
  • Line 153: warning: exported method Interface.GetString should have comment or be unexported (golint)
  • Line 154: warning: exported method Interface.GetStrings should have comment or be unexported (golint)
  • Line 155: warning: exported method Interface.GetBinary should have comment or be unexported (golint)
  • Line 156: warning: exported method Interface.GetBinaries should have comment or be unexported (golint)
  • Line 157: warning: exported method Interface.GetAddress should have comment or be unexported (golint)
  • Line 158: warning: exported method Interface.GetAddresses should have comment or be unexported (golint)
  • Line 159: warning: exported method Interface.GetHash should have comment or be unexported (golint)
  • Line 160: warning: exported method Interface.GetHashes should have comment or be unexported (golint)
  • Line 161: warning: exported method Interface.GetInt8 should have comment or be unexported (golint)
  • Line 162: warning: exported method Interface.GetInt16 should have comment or be unexported (golint)
  • Line 163: warning: exported method Interface.GetInt32 should have comment or be unexported (golint)
  • Line 164: warning: exported method Interface.GetInt64 should have comment or be unexported (golint)
  • Line 165: warning: exported method Interface.GetInt8s should have comment or be unexported (golint)
  • Line 173: warning: exported method Interface.GetInt16s should have comment or be unexported (golint)
  • Line 181: warning: exported method Interface.GetInt32s should have comment or be unexported (golint)
  • Line 189: warning: exported method Interface.GetInt64s should have comment or be unexported (golint)
  • Line 197: warning: exported method Interface.GetUint8 should have comment or be unexported (golint)
  • Line 200: warning: exported method Interface.GetUint16 should have comment or be unexported (golint)
  • Line 203: warning: exported method Interface.GetUint32 should have comment or be unexported (golint)
  • Line 206: warning: exported method Interface.GetUint64 should have comment or be unexported (golint)
  • Line 209: warning: exported method Interface.GetUint8s should have comment or be unexported (golint)
  • Line 217: warning: exported method Interface.GetUint16s should have comment or be unexported (golint)
  • Line 225: warning: exported method Interface.GetUint32s should have comment or be unexported (golint)
  • Line 233: warning: exported method Interface.GetUint64s should have comment or be unexported (golint)
  • Line 241: warning: exported method Interface.GetBigInt should have comment or be unexported (golint)
  • Line 242: warning: exported method Interface.GetBigInts should have comment or be unexported (golint)

• quorum/plugin/account/gateway.go
  • Line 199: warning: exported function ToUrl should have comment or be unexported (golint)

• quorum/trie/committer.go
  • Line 183: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/cmd/utils/cmd.go
  • Line 66: warning: exported function StartNode should have comment or be unexported (golint)
  • Line 88: warning: exported function ImportChain should have comment or be unexported (golint)

• quorum/accounts/keystore/key.go
  • Line 42: warning: exported type Key should have comment or be unexported (golint)
  • Line 81: warning: exported type CryptoJSON should have comment or be unexported (golint)
  • Line 94: warning: exported method Key.MarshalJSON should have comment or be unexported (golint)
  • Line 105: warning: exported method Key.UnmarshalJSON should have comment or be unexported (golint)

• quorum/p2p/message.go
  • Line 73: warning: exported type MsgReader should have comment or be unexported (golint)
  • Line 77: warning: exported type MsgWriter should have comment or be unexported (golint)

• quorum/core/headerchain.go
  • Line 234: warning: exported method HeaderChain.ValidateHeaderChain should have comment or be unexported (golint)
  • Line 372: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 471: warning: exported method HeaderChain.GetCanonicalHash should have comment or be unexported (golint)

• quorum/crypto/bn256/google/gfp12.go
  • Line 133: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• quorum/core/state/snapshot/snapshot.go
  • Line 155: warning: comment on exported type Tree should be of the form "Tree ..." (with optional leading article) (golint)
  • Line 730: warning: comment on exported method Tree.DiskRoot should be of the form "DiskRoot ..." (golint)

• quorum/core/vm/eips.go
  • Line 47: warning: exported function ValidEip should have comment or be unexported (golint)
  • Line 51: warning: exported function ActivateableEips should have comment or be unexported (golint)

• quorum/tests/vm_test_util.go
  • Line 42: warning: exported method VMTest.UnmarshalJSON should have comment or be unexported (golint)
  • Line 81: warning: exported method VMTest.Run should have comment or be unexported (golint)

• quorum/cmd/devp2p/internal/ethtest/types.go
  • Line 37: warning: exported type Message should have comment or be unexported (golint)
  • Line 41: warning: exported type Error should have comment or be unexported (golint)
  • Line 47: warning: exported method Error.Code should have comment or be unexported (golint)
  • Line 66: warning: exported method Hello.Code should have comment or be unexported (golint)
  • Line 73: warning: exported method Disconnect.Code should have comment or be unexported (golint)
  • Line 75: warning: exported type Ping should have comment or be unexported (golint)
  • Line 77: warning: exported method Ping.Code should have comment or be unexported (golint)
  • Line 79: warning: exported type Pong should have comment or be unexported (golint)
  • Line 81: warning: exported method Pong.Code should have comment or be unexported (golint)
  • Line 93: warning: exported method Status.Code should have comment or be unexported (golint)
  • Line 101: warning: exported method NewBlockHashes.Code should have comment or be unexported (golint)
  • Line 109: warning: exported method NewBlock.Code should have comment or be unexported (golint)
  • Line 119: warning: exported method GetBlockHeaders.Code should have comment or be unexported (golint)
  • Line 121: warning: exported type BlockHeaders should have comment or be unexported (golint)
  • Line 123: warning: exported method BlockHeaders.Code should have comment or be unexported (golint)
  • Line 164: warning: exported method GetBlockBodies.Code should have comment or be unexported (golint)
  • Line 169: warning: exported method BlockBodies.Code should have comment or be unexported (golint)

• quorum/rpc/security.go
  • Line 30: warning: exported type SecurityContextResolver should have comment or be unexported (golint)
  • Line 36: warning: comment on exported type HttpCredentialsProviderFunc should be of the form "HttpCredentialsProviderFunc ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported type PSIProviderFunc should be of the form "PSIProviderFunc ..." (with optional leading article) (golint)
  • Line 85: warning: comment on exported function SecureCall should be of the form "SecureCall ..." (golint)

• quorum/crypto/bls12381/g1.go
  • Line 30: warning: exported method PointG1.Set should have comment or be unexported (golint)
  • Line 231: warning: comment on exported method G1.Affine should be of the form "Affine ..." (golint)
  • Line 269: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/metrics/librato/librato.go
  • Line 24: warning: exported type Reporter should have comment or be unexported (golint)
  • Line 35: warning: exported function NewReporter should have comment or be unexported (golint)
  • Line 39: warning: exported function Librato should have comment or be unexported (golint)
  • Line 43: warning: exported method Reporter.Run should have comment or be unexported (golint)
  • Line 83: warning: exported method Reporter.BuildRequest should have comment or be unexported (golint)

• quorum/metrics/ewma.go
  • Line 10: warning: comment on exported type EWMA should be of the form "EWMA ..." (with optional leading article) (golint)

• quorum/params/version.go
  • Line 24: warning: exported const VersionMajor should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: comment on exported var QuorumVersion should be of the form "QuorumVersion ..." (golint)
  • Line 67: warning: exported function VersionWithCommit should have comment or be unexported (golint)

• quorum/accounts/pluggable/backend.go
  • Line 12: warning: exported var BackendType should have comment or be unexported (golint)
  • Line 14: warning: exported type Backend should have comment or be unexported (golint)
  • Line 18: warning: exported function NewBackend should have comment or be unexported (golint)
  • Line 31: warning: exported method Backend.Wallets should have comment or be unexported (golint)
  • Line 45: warning: exported method Backend.SetPluginService should have comment or be unexported (golint)
  • Line 49: warning: exported method Backend.TimedUnlock should have comment or be unexported (golint)
  • Line 53: warning: exported method Backend.Lock should have comment or be unexported (golint)
  • Line 64: warning: exported method Backend.NewAccount should have comment or be unexported (golint)
  • Line 68: warning: exported method Backend.ImportRawKey should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/core/types.go
  • Line 27: warning: exported type State should have comment or be unexported (golint)
  • Line 30: warning: exported const StateAcceptRequest should have comment (or a comment on this block) or be unexported (golint)

• quorum/crypto/secp256k1/secp256.go
  • Line 52: warning: exported var ErrInvalidMsgLen should have comment or be unexported (golint)

• quorum/extension/privacyExtension/state_set_utilities_test.go
  • Line 1: warning: don't use MixedCaps in package name; privacyExtension should be privacyextension (golint)

• quorum/crypto/bls12381/field_element.go
  • Line 173: warning: receiver name e should be consistent with previous receiver name fe for fe (golint)

• quorum/internal/debug/flags.go
  • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 36: warning: exported var Memsize should have comment or be unexported (golint)
  • Line 122: warning: exported var DeprecatedFlags should have comment or be unexported (golint)
  • Line 205: warning: exported function StartPProf should have comment or be unexported (golint)

• quorum/params/config.go
  • Line 253: warning: exported var TestChainConfig should have comment or be unexported (golint)
  • Line 302: warning: exported type MaxCodeConfigStruct should have comment or be unexported (golint)
  • Line 425: warning: comment on exported method ChainConfig.IsValid should be of the form "IsValid ..." (golint)
  • Line 501: warning: comment on exported method ChainConfig.IsQIP714 should be of the form "IsQIP714 ..." (golint)
  • Line 514: warning: comment on exported method ChainConfig.GetMaxCodeSize should be of the form "GetMaxCodeSize ..." (golint)
  • Line 539: warning: comment on exported method ChainConfig.CheckMaxCodeConfigData should be of the form "CheckMaxCodeConfigData ..." (golint)
  • Line 566: warning: error should be the last type when returning multiple items (golint)

• quorum/les/serverpool_test.go
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 138: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/core/state_processor.go
  • Line 127: warning: comment on exported function PrivateStateDBForTxn should be of the form "PrivateStateDBForTxn ..." (golint)

• quorum/consensus/istanbul/utils.go
  • Line 27: warning: exported function RLPHash should have comment or be unexported (golint)
  • Line 55: warning: exported function CheckValidatorSignature should have comment or be unexported (golint)

• quorum/contracts/checkpointoracle/oracle_test.go
  • Line 282: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 305: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• quorum/core/state/access_list.go
  • Line 58: warning: receiver name a should be consistent with previous receiver name al for accessList (golint)

• quorum/core/vm/interface.go
  • Line 29: warning: exported type AccountExtraDataStateGetter should have comment or be unexported (golint)
  • Line 35: warning: exported type AccountExtraDataStateSetter should have comment or be unexported (golint)
  • Line 40: warning: comment on exported type MinimalApiState should be of the form "MinimalApiState ..." (with optional leading article) (golint)

• quorum/log/root.go
  • Line 9: warning: exported var StdoutHandler should have comment or be unexported (golint)

• quorum/mobile/p2p.go
  • Line 32: warning: exported method NodeInfo.GetID should have comment or be unexported (golint)
  • Line 33: warning: exported method NodeInfo.GetName should have comment or be unexported (golint)
  • Line 34: warning: exported method NodeInfo.GetEnode should have comment or be unexported (golint)
  • Line 35: warning: exported method NodeInfo.GetIP should have comment or be unexported (golint)
  • Line 36: warning: exported method NodeInfo.GetDiscoveryPort should have comment or be unexported (golint)
  • Line 37: warning: exported method NodeInfo.GetListenerPort should have comment or be unexported (golint)
  • Line 38: warning: exported method NodeInfo.GetListenerAddress should have comment or be unexported (golint)
  • Line 39: warning: exported method NodeInfo.GetProtocols should have comment or be unexported (golint)
  • Line 52: warning: exported method PeerInfo.GetID should have comment or be unexported (golint)
  • Line 53: warning: exported method PeerInfo.GetName should have comment or be unexported (golint)
  • Line 54: warning: exported method PeerInfo.GetCaps should have comment or be unexported (golint)
  • Line 55: warning: exported method PeerInfo.GetLocalAddress should have comment or be unexported (golint)
  • Line 56: warning: exported method PeerInfo.GetRemoteAddress should have comment or be unexported (golint)

• quorum/permission/backend.go
  • Line 24: warning: exported type PermissionCtrl should have comment or be unexported (golint)
  • Line 49: warning: comment on exported function NewQuorumPermissionCtrl should be of the form "NewQuorumPermissionCtrl ..." (golint)
  • Line 98: warning: exported method PermissionCtrl.Start should have comment or be unexported (golint)
  • Line 118: warning: exported method PermissionCtrl.Stop should have comment or be unexported (golint)
  • Line 125: warning: exported method PermissionCtrl.IsV2Permission should have comment or be unexported (golint)
  • Line 129: warning: exported function NewPermissionContractService should have comment or be unexported (golint)
  • Line 150: warning: exported method PermissionCtrl.NewPermissionRoleService should have comment or be unexported (golint)
  • Line 158: warning: exported method PermissionCtrl.NewPermissionOrgService should have comment or be unexported (golint)
  • Line 166: warning: exported method PermissionCtrl.NewPermissionNodeService should have comment or be unexported (golint)
  • Line 174: warning: exported method PermissionCtrl.NewPermissionAccountService should have comment or be unexported (golint)
  • Line 182: warning: exported method PermissionCtrl.NewPermissionAuditService should have comment or be unexported (golint)
  • Line 186: warning: exported method PermissionCtrl.NewPermissionControlService should have comment or be unexported (golint)
  • Line 194: warning: exported method PermissionCtrl.ConnectionAllowed should have comment or be unexported (golint)
  • Line 202: warning: exported method PermissionCtrl.IsTransactionAllowed should have comment or be unexported (golint)

• quorum/rlp/decode.go
  • Line 36: warning: error var EOL should have name of the form ErrFoo (golint)
  • Line 39: warning: exported var ErrExpectedString should have comment or be unexported (golint)
  • Line 510: warning: exported const Byte should have comment (or a comment on this block) or be unexported (golint)

• quorum/rpc/subscription.go
  • Line 37: warning: comment on exported var ErrSubscriptionNotFound should be of the form "ErrSubscriptionNotFound ..." (golint)

• quorum/mobile/bind.go
  • Line 38: warning: exported type MobileSigner should have comment or be unexported (golint)
  • Line 42: warning: exported method MobileSigner.Sign should have comment or be unexported (golint)
  • Line 60: warning: exported method CallOpts.IsPending should have comment or be unexported (golint)
  • Line 61: warning: exported method CallOpts.GetGasLimit should have comment or be unexported (golint)
  • Line 67: warning: exported method CallOpts.SetPending should have comment or be unexported (golint)
  • Line 68: warning: exported method CallOpts.SetGasLimit should have comment or be unexported (golint)
  • Line 69: warning: exported method CallOpts.SetContext should have comment or be unexported (golint)
  • Line 70: warning: exported method CallOpts.SetFrom should have comment or be unexported (golint)
  • Line 93: warning: exported method TransactOpts.GetFrom should have comment or be unexported (golint)
  • Line 94: warning: exported method TransactOpts.GetNonce should have comment or be unexported (golint)
  • Line 95: warning: exported method TransactOpts.GetValue should have comment or be unexported (golint)
  • Line 96: warning: exported method TransactOpts.GetGasPrice should have comment or be unexported (golint)
  • Line 97: warning: exported method TransactOpts.GetGasLimit should have comment or be unexported (golint)
  • Line 106: warning: exported method TransactOpts.SetFrom should have comment or be unexported (golint)
  • Line 107: warning: exported method TransactOpts.SetNonce should have comment or be unexported (golint)
  • Line 108: warning: exported method TransactOpts.SetSigner should have comment or be unexported (golint)
  • Line 117: warning: exported method TransactOpts.SetValue should have comment or be unexported (golint)
  • Line 118: warning: exported method TransactOpts.SetGasPrice should have comment or be unexported (golint)
  • Line 119: warning: exported method TransactOpts.SetGasLimit should have comment or be unexported (golint)
  • Line 120: warning: exported method TransactOpts.SetContext should have comment or be unexported (golint)
  • Line 163: warning: exported method BoundContract.GetAddress should have comment or be unexported (golint)
  • Line 164: warning: exported method BoundContract.GetDeployer should have comment or be unexported (golint)

• quorum/signer/core/api.go
  • Line 132: warning: exported function StartClefAccountManager should have comment or be unexported (golint)
  • Line 230: warning: comment on exported type ListRequest should be of the form "ListRequest ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type ListResponse should be of the form "ListResponse ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type NewAccountRequest should be of the form "NewAccountRequest ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type NewAccountResponse should be of the form "NewAccountResponse ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type SignDataRequest should be of the form "SignDataRequest ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type SignDataResponse should be of the form "SignDataResponse ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type StartupInfo should be of the form "StartupInfo ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type UserInputRequest should be of the form "UserInputRequest ..." (with optional leading article) (golint)
  • Line 230: warning: comment on exported type UserInputResponse should be of the form "UserInputResponse ..." (with optional leading article) (golint)
  • Line 285: warning: exported var ErrRequestDenied should have comment or be unexported (golint)
  • Line 603: warning: exported method SignerAPI.SignGnosisSafeTx should have comment or be unexported (golint)
  • Line 630: warning: comment on exported method SignerAPI.Version should be of the form "Version ..." (golint)

• quorum/raft/snapshot.go
  • Line 26: warning: exported type SnapshotWithHostnames should have comment or be unexported (golint)
  • Line 32: warning: exported type AddressWithoutHostname should have comment or be unexported (golint)
  • Line 40: warning: exported type SnapshotWithoutHostnames should have comment or be unexported (golint)
  • Line 46: warning: exported type ByRaftId should have comment or be unexported (golint)
  • Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 287: warning: exported method SnapshotWithHostnames.EncodeRLP should have comment or be unexported (golint)

• quorum/raft/backend.go
  • Line 22: warning: exported type RaftService should have comment or be unexported (golint)
  • Line 42: warning: exported function New should have comment or be unexported (golint)
  • Line 84: warning: exported method RaftService.AccountManager should have comment or be unexported (golint)
  • Line 85: warning: exported method RaftService.BlockChain should have comment or be unexported (golint)
  • Line 86: warning: exported method RaftService.ChainDb should have comment or be unexported (golint)
  • Line 87: warning: exported method RaftService.DappDb should have comment or be unexported (golint)
  • Line 88: warning: exported method RaftService.EventMux should have comment or be unexported (golint)
  • Line 89: warning: exported method RaftService.TxPool should have comment or be unexported (golint)

• quorum/consensus/istanbul/common/constants.go
  • Line 11: warning: exported var DefaultDifficulty should have comment or be unexported (golint)

• quorum/crypto/bn256/cloudflare/gfp12.go
  • Line 113: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• quorum/crypto/bn256/google/bn256.go
  • Line 168: warning: comment on exported function RandomG2 should be of the form "RandomG2 ..." (golint)
  • Line 226: warning: receiver name n should be consistent with previous receiver name e for G2 (golint)
  • Line 309: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 318: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 327: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 336: warning: receiver name n should be consistent with previous receiver name g for GT (golint)
  • Line 374: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• quorum/core/state/account_extra_data.go
  • Line 28: warning: comment on exported type AccountExtraData should be of the form "AccountExtraData ..." (with optional leading article) (golint)
  • Line 42: warning: exported method AccountExtraData.DecodeRLP should have comment or be unexported (golint)
  • Line 81: warning: exported method AccountExtraData.EncodeRLP should have comment or be unexported (golint)
  • Line 120: warning: comment on exported type PrivacyMetadata should be of the form "PrivacyMetadata ..." (with optional leading article) (golint)
  • Line 138: warning: exported method PrivacyMetadata.DecodeRLP should have comment or be unexported (golint)
  • Line 148: warning: exported method PrivacyMetadata.EncodeRLP should have comment or be unexported (golint)
  • Line 155: warning: exported function NewStatePrivacyMetadata should have comment or be unexported (golint)

• quorum/core/vm/memory.go
  • Line 71: warning: comment on exported method Memory.GetCopy should be of the form "GetCopy ..." (golint)

• quorum/mobile/types.go
  • Line 129: warning: exported method Header.GetParentHash should have comment or be unexported (golint)
  • Line 130: warning: exported method Header.GetUncleHash should have comment or be unexported (golint)
  • Line 131: warning: exported method Header.GetCoinbase should have comment or be unexported (golint)
  • Line 132: warning: exported method Header.GetRoot should have comment or be unexported (golint)
  • Line 133: warning: exported method Header.GetTxHash should have comment or be unexported (golint)
  • Line 134: warning: exported method Header.GetReceiptHash should have comment or be unexported (golint)
  • Line 135: warning: exported method Header.GetBloom should have comment or be unexported (golint)
  • Line 136: warning: exported method Header.GetDifficulty should have comment or be unexported (golint)
  • Line 137: warning: exported method Header.GetNumber should have comment or be unexported (golint)
  • Line 138: warning: exported method Header.GetGasLimit should have comment or be unexported (golint)
  • Line 139: warning: exported method Header.GetGasUsed should have comment or be unexported (golint)
  • Line 140: warning: exported method Header.GetTime should have comment or be unexported (golint)
  • Line 141: warning: exported method Header.GetExtra should have comment or be unexported (golint)
  • Line 142: warning: exported method Header.GetMixDigest should have comment or be unexported (golint)
  • Line 143: warning: exported method Header.GetNonce should have comment or be unexported (golint)
  • Line 144: warning: exported method Header.GetHash should have comment or be unexported (golint)
  • Line 205: warning: exported method Block.GetParentHash should have comment or be unexported (golint)
  • Line 206: warning: exported method Block.GetUncleHash should have comment or be unexported (golint)
  • Line 207: warning: exported method Block.GetCoinbase should have comment or be unexported (golint)
  • Line 208: warning: exported method Block.GetRoot should have comment or be unexported (golint)
  • Line 209: warning: exported method Block.GetTxHash should have comment or be unexported (golint)
  • Line 210: warning: exported method Block.GetReceiptHash should have comment or be unexported (golint)
  • Line 211: warning: exported method Block.GetBloom should have comment or be unexported (golint)
  • Line 212: warning: exported method Block.GetDifficulty should have comment or be unexported (golint)
  • Line 213: warning: exported method Block.GetNumber should have comment or be unexported (golint)
  • Line 214: warning: exported method Block.GetGasLimit should have comment or be unexported (golint)
  • Line 215: warning: exported method Block.GetGasUsed should have comment or be unexported (golint)
  • Line 216: warning: exported method Block.GetTime should have comment or be unexported (golint)
  • Line 217: warning: exported method Block.GetExtra should have comment or be unexported (golint)
  • Line 218: warning: exported method Block.GetMixDigest should have comment or be unexported (golint)
  • Line 219: warning: exported method Block.GetNonce should have comment or be unexported (golint)
  • Line 220: warning: exported method Block.GetHash should have comment or be unexported (golint)
  • Line 221: warning: exported method Block.GetHeader should have comment or be unexported (golint)
  • Line 222: warning: exported method Block.GetUncles should have comment or be unexported (golint)
  • Line 223: warning: exported method Block.GetTransactions should have comment or be unexported (golint)
  • Line 224: warning: exported method Block.GetTransaction should have comment or be unexported (golint)
  • Line 286: warning: exported method Transaction.GetData should have comment or be unexported (golint)
  • Line 287: warning: exported method Transaction.GetGas should have comment or be unexported (golint)
  • Line 288: warning: exported method Transaction.GetGasPrice should have comment or be unexported (golint)
  • Line 289: warning: exported method Transaction.GetValue should have comment or be unexported (golint)
  • Line 290: warning: exported method Transaction.GetNonce should have comment or be unexported (golint)
  • Line 292: warning: exported method Transaction.GetHash should have comment or be unexported (golint)
  • Line 293: warning: exported method Transaction.GetCost should have comment or be unexported (golint)
  • Line 295: warning: comment on exported method Transaction.GetSigHash should be of the form "GetSigHash ..." (golint)
  • Line 298: warning: comment on exported method Transaction.GetFrom should be of the form "GetFrom ..." (golint)
  • Line 308: warning: exported method Transaction.GetTo should have comment or be unexported (golint)
  • Line 315: warning: exported method Transaction.WithSignature should have comment or be unexported (golint)
  • Line 383: warning: exported method Receipt.GetStatus should have comment or be unexported (golint)
  • Line 384: warning: exported method Receipt.GetPostState should have comment or be unexported (golint)
  • Line 385: warning: exported method Receipt.GetCumulativeGasUsed should have comment or be unexported (golint)
  • Line 386: warning: exported method Receipt.GetBloom should have comment or be unexported (golint)
  • Line 387: warning: exported method Receipt.GetLogs should have comment or be unexported (golint)
  • Line 388: warning: exported method Receipt.GetTxHash should have comment or be unexported (golint)
  • Line 389: warning: exported method Receipt.GetContractAddress should have comment or be unexported (golint)
  • Line 390: warning: exported method Receipt.GetGasUsed should have comment or be unexported (golint)

• quorum/p2p/enode/nodedb.go
  • Line 464: warning: comment on exported method DB.Close should be of the form "Close ..." (golint)

• quorum/core/state/dump.go
  • Line 114: warning: exported method StateDB.DumpToCollector should have comment or be unexported (golint)
  • Line 192: warning: exported method StateDB.DumpAddress should have comment or be unexported (golint)
  • Line 192: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• quorum/les/flowcontrol/manager.go
  • Line 157: warning: comment on exported method ClientManager.SetCapacityLimits should be of the form "SetCapacityLimits ..." (golint)

• quorum/multitenancy/docs.go
  • Line 1: warning: package comment should be of the form "Package multitenancy ..." (golint)

• quorum/internal/ethapi/backend.go
  • Line 102: warning: exported function GetAPIs should have comment or be unexported (golint)

• quorum/les/peer.go
  • Line 766: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/private/engine/constellation/node.go
  • Line 14: warning: exported type Client should have comment or be unexported (golint)
  • Line 18: warning: exported method Client.SendPayload should have comment or be unexported (golint)
  • Line 50: warning: exported method Client.ReceivePayload should have comment or be unexported (golint)

• quorum/common/prque/lazyqueue.go
  • Line 51: warning: exported type PriorityCallback should have comment or be unexported (golint)
  • Line 52: warning: exported type MaxPriorityCallback should have comment or be unexported (golint)

• quorum/raft/events.go
  • Line 7: warning: exported type InvalidRaftOrdering should have comment or be unexported (golint)

• quorum/core/types/transaction_signing_private.go
  • Line 25: warning: comment on exported type QuorumPrivateTxSigner should be of the form "QuorumPrivateTxSigner ..." (with optional leading article) (golint)
  • Line 29: warning: exported method QuorumPrivateTxSigner.Sender should have comment or be unexported (golint)
  • Line 35: warning: receiver name qs should be consistent with previous receiver name s for QuorumPrivateTxSigner (golint)
  • Line 48: warning: exported method QuorumPrivateTxSigner.Equal should have comment or be unexported (golint)

• quorum/ethclient/ethclient.go
  • Line 47: warning: exported function DialContext should have comment or be unexported (golint)
  • Line 60: warning: comment on exported function NewClientWithPTM should be of the form "NewClientWithPTM ..." (golint)
  • Line 67: warning: comment on exported method Client.WithPrivateTransactionManager should be of the form "WithPrivateTransactionManager ..." (golint)
  • Line 79: warning: exported method Client.Close should have comment or be unexported (golint)
  • Line 85: warning: comment on exported method Client.ChainID should be of the form "ChainID ..." (golint)
  • Line 551: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 556: warning: comment on exported method Client.PreparePrivateTransaction should be of the form "PreparePrivateTransaction ..." (golint)

• quorum/crypto/bls12381/g2.go
  • Line 290: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/p2p/nodestate/nodestate.go
  • Line 36: warning: exported var ErrInvalidField should have comment or be unexported (golint)
  • Line 120: warning: comment on exported type Setup should be of the form "Setup ..." (with optional leading article) (golint)
  • Line 298: warning: receiver name f should be consistent with previous receiver name a for Flags (golint)

• quorum/params/quorum.go
  • Line 4: warning: exported const PERMISSIONED_CONFIG should have comment (or a comment on this block) or be unexported (golint)

• quorum/les/api_backend.go
  • Line 45: warning: exported type LesApiBackend should have comment or be unexported (golint)
  • Line 51: warning: exported method LesApiBackend.ChainConfig should have comment or be unexported (golint)
  • Line 55: warning: exported method LesApiBackend.PSMR should have comment or be unexported (golint)
  • Line 59: warning: exported method LesApiBackend.CurrentBlock should have comment or be unexported (golint)
  • Line 63: warning: exported method LesApiBackend.SetHead should have comment or be unexported (golint)
  • Line 68: warning: exported method LesApiBackend.HeaderByNumber should have comment or be unexported (golint)
  • Line 75: warning: exported method LesApiBackend.HeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 95: warning: exported method LesApiBackend.HeaderByHash should have comment or be unexported (golint)
  • Line 99: warning: exported method LesApiBackend.BlockByNumber should have comment or be unexported (golint)
  • Line 107: warning: exported method LesApiBackend.BlockByHash should have comment or be unexported (golint)
  • Line 111: warning: exported method LesApiBackend.BlockByNumberOrHash should have comment or be unexported (golint)
  • Line 131: warning: exported method LesApiBackend.StateAndHeaderByNumber should have comment or be unexported (golint)
  • Line 142: warning: exported method LesApiBackend.StateAndHeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 159: warning: exported method LesApiBackend.GetReceipts should have comment or be unexported (golint)
  • Line 166: warning: exported method LesApiBackend.GetLogs should have comment or be unexported (golint)
  • Line 173: warning: exported method LesApiBackend.GetTd should have comment or be unexported (golint)
  • Line 180: warning: exported method LesApiBackend.GetEVM should have comment or be unexported (golint)
  • Line 186: warning: exported method LesApiBackend.SendTx should have comment or be unexported (golint)
  • Line 190: warning: exported method LesApiBackend.RemoveTx should have comment or be unexported (golint)
  • Line 194: warning: exported method LesApiBackend.GetPoolTransactions should have comment or be unexported (golint)
  • Line 198: warning: exported method LesApiBackend.GetPoolTransaction should have comment or be unexported (golint)
  • Line 202: warning: exported method LesApiBackend.GetTransaction should have comment or be unexported (golint)
  • Line 206: warning: exported method LesApiBackend.GetPoolNonce should have comment or be unexported (golint)
  • Line 210: warning: exported method LesApiBackend.Stats should have comment or be unexported (golint)
  • Line 214: warning: exported method LesApiBackend.TxPoolContent should have comment or be unexported (golint)
  • Line 218: warning: exported method LesApiBackend.SubscribeNewTxsEvent should have comment or be unexported (golint)
  • Line 222: warning: exported method LesApiBackend.SubscribeChainEvent should have comment or be unexported (golint)
  • Line 226: warning: exported method LesApiBackend.SubscribeChainHeadEvent should have comment or be unexported (golint)
  • Line 230: warning: exported method LesApiBackend.SubscribeChainSideEvent should have comment or be unexported (golint)
  • Line 234: warning: exported method LesApiBackend.SubscribeLogsEvent should have comment or be unexported (golint)
  • Line 238: warning: exported method LesApiBackend.SubscribePendingLogsEvent should have comment or be unexported (golint)
  • Line 245: warning: exported method LesApiBackend.SubscribeRemovedLogsEvent should have comment or be unexported (golint)
  • Line 249: warning: exported method LesApiBackend.Downloader should have comment or be unexported (golint)
  • Line 253: warning: exported method LesApiBackend.ProtocolVersion should have comment or be unexported (golint)
  • Line 257: warning: exported method LesApiBackend.SuggestPrice should have comment or be unexported (golint)
  • Line 261: warning: exported method LesApiBackend.ChainDb should have comment or be unexported (golint)
  • Line 265: warning: exported method LesApiBackend.AccountManager should have comment or be unexported (golint)
  • Line 269: warning: exported method LesApiBackend.ExtRPCEnabled should have comment or be unexported (golint)
  • Line 273: warning: comment on exported method LesApiBackend.CallTimeOut should be of the form "CallTimeOut ..." (golint)
  • Line 280: warning: exported method LesApiBackend.RPCGasCap should have comment or be unexported (golint)
  • Line 284: warning: exported method LesApiBackend.RPCTxFeeCap should have comment or be unexported (golint)
  • Line 288: warning: exported method LesApiBackend.BloomStatus should have comment or be unexported (golint)
  • Line 296: warning: exported method LesApiBackend.ServiceFilter should have comment or be unexported (golint)
  • Line 302: warning: exported method LesApiBackend.Engine should have comment or be unexported (golint)
  • Line 306: warning: exported method LesApiBackend.CurrentHeader should have comment or be unexported (golint)
  • Line 310: warning: comment on exported method LesApiBackend.SupportsMultitenancy should be of the form "SupportsMultitenancy ..." (golint)
  • Line 319: warning: exported method LesApiBackend.AccountExtraDataStateGetterByNumber should have comment or be unexported (golint)

• quorum/plugin/online_verifier.go
  • Line 3: warning: comment on exported type OnlineVerifier should be of the form "OnlineVerifier ..." (with optional leading article) (golint)
  • Line 8: warning: exported function NewOnlineVerifier should have comment or be unexported (golint)
  • Line 12: warning: comment on exported method OnlineVerifier.VerifySignature should be of the form "VerifySignature ..." (golint)

• quorum/cmd/clef/main.go
  • Line 829: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 919: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 920: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 921: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 1052: warning: should not use basic type string as key in context.WithValue (golint)

• quorum/consensus/istanbul/qbft/types/preprepare.go
  • Line 13: warning: exported type Preprepare should have comment or be unexported (golint)
  • Line 20: warning: exported function NewPreprepare should have comment or be unexported (golint)
  • Line 31: warning: exported method Preprepare.EncodePayloadForSigning should have comment or be unexported (golint)
  • Line 39: warning: exported method Preprepare.EncodeRLP should have comment or be unexported (golint)
  • Line 54: warning: exported method Preprepare.DecodeRLP should have comment or be unexported (golint)

• quorum/consensus/istanbul/backend/backend.go
  • Line 79: warning: exported type Backend should have comment or be unexported (golint)
  • Line 123: warning: exported method Backend.Engine should have comment or be unexported (golint)
  • Line 127: warning: exported method Backend.EngineForBlockNumber should have comment or be unexported (golint)
  • Line 138: warning: comment on exported method Backend.CalcDifficulty should be of the form "CalcDifficulty ..." (golint)
  • Line 336: warning: exported method Backend.LastProposal should have comment or be unexported (golint)
  • Line 353: warning: exported method Backend.HasBadProposal should have comment or be unexported (golint)
  • Line 360: warning: exported method Backend.Close should have comment or be unexported (golint)
  • Line 375: warning: comment on exported method Backend.IsQBFTConsensusAt should be of the form "IsQBFTConsensusAt ..." (golint)

• quorum/core/vm/logger_json.go
  • Line 29: warning: exported type JSONLogger should have comment or be unexported (golint)
  • Line 44: warning: exported method JSONLogger.CaptureStart should have comment or be unexported (golint)

• quorum/extension/contract_facade.go
  • Line 13: warning: exported type ManagementContractFacade should have comment or be unexported (golint)
  • Line 22: warning: exported type EthclientManagementContractFacade should have comment or be unexported (golint)
  • Line 26: warning: exported function NewManagementContractFacade should have comment or be unexported (golint)
  • Line 30: warning: exported method EthclientManagementContractFacade.Transactor should have comment or be unexported (golint)
  • Line 34: warning: exported method EthclientManagementContractFacade.Caller should have comment or be unexported (golint)
  • Line 38: warning: exported method EthclientManagementContractFacade.Deploy should have comment or be unexported (golint)
  • Line 43: warning: exported method EthclientManagementContractFacade.GetAllVoters should have comment or be unexported (golint)
  • Line 64: warning: exported method EthclientManagementContractFacade.Close should have comment or be unexported (golint)

• quorum/node/errors.go
  • Line 27: warning: exported var ErrDatadirUsed should have comment or be unexported (golint)

• quorum/permission/v2/backend.go
  • Line 14: warning: exported type Backend should have comment or be unexported (golint)
  • Line 19: warning: exported method Backend.ManageAccountPermissions should have comment or be unexported (golint)
  • Line 66: warning: exported method Backend.ManageRolePermissions should have comment or be unexported (golint)
  • Line 105: warning: exported method Backend.ManageOrgPermissions should have comment or be unexported (golint)
  • Line 156: warning: exported method Backend.ManageNodePermissions should have comment or be unexported (golint)
  • Line 261: warning: exported method Backend.MonitorNetworkBootUp should have comment or be unexported (golint)
  • Line 297: warning: exported method Backend.GetRoleService should have comment or be unexported (golint)
  • Line 307: warning: exported method Backend.GetOrgService should have comment or be unexported (golint)
  • Line 315: warning: exported method Backend.GetNodeService should have comment or be unexported (golint)
  • Line 323: warning: exported method Backend.GetAccountService should have comment or be unexported (golint)
  • Line 332: warning: exported method Backend.GetAuditService should have comment or be unexported (golint)
  • Line 341: warning: exported method Backend.GetControlService should have comment or be unexported (golint)

• quorum/plugin/api.go
  • Line 3: warning: exported type PluginManagerAPI should have comment or be unexported (golint)
  • Line 7: warning: exported function NewPluginManagerAPI should have comment or be unexported (golint)
  • Line 13: warning: exported method PluginManagerAPI.ReloadPlugin should have comment or be unexported (golint)

• quorum/common/http/config.go
  • Line 13: warning: exported const NoConnection should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported const TlsOff should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type Config should have comment or be unexported (golint)
  • Line 40: warning: exported var NoConnectionConfig should have comment or be unexported (golint)
  • Line 45: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 52: warning: exported function IsSocketConfigured should have comment or be unexported (golint)
  • Line 56: warning: comment on exported function FetchConfigOrIgnore should be of the form "FetchConfigOrIgnore ..." (golint)
  • Line 93: warning: exported function LoadConfigFile should have comment or be unexported (golint)
  • Line 111: warning: exported method Config.Validate should have comment or be unexported (golint)
  • Line 154: warning: exported method Config.SetSocket should have comment or be unexported (golint)
  • Line 163: warning: exported method Config.SetHttpUrl should have comment or be unexported (golint)
  • Line 168: warning: exported method Config.SetTimeout should have comment or be unexported (golint)
  • Line 172: warning: exported method Config.SetDialTimeout should have comment or be unexported (golint)
  • Line 176: warning: exported method Config.SetHttpIdleConnTimeout should have comment or be unexported (golint)
  • Line 180: warning: exported method Config.SetHttpWriteBufferSize should have comment or be unexported (golint)
  • Line 184: warning: exported method Config.SetHttpReadBufferSize should have comment or be unexported (golint)
  • Line 188: warning: exported method Config.SetTlsMode should have comment or be unexported (golint)
  • Line 192: warning: exported method Config.SetTlsRootCA should have comment or be unexported (golint)
  • Line 196: warning: exported method Config.SetTlsClientCert should have comment or be unexported (golint)
  • Line 200: warning: exported method Config.SetTlsClientKey should have comment or be unexported (golint)
  • Line 204: warning: exported method Config.SetTlsInsecureSkipVerify should have comment or be unexported (golint)

• quorum/accounts/abi/argument.go
  • Line 34: warning: exported type Arguments should have comment or be unexported (golint)
  • Line 36: warning: exported type ArgumentMarshaling should have comment or be unexported (golint)

• quorum/crypto/crypto.go
  • Line 163: warning: exported function FromECDSAPub should have comment or be unexported (golint)
  • Line 263: warning: exported function PubkeyToAddress should have comment or be unexported (golint)

• quorum/extension/privacyExtension/state_set_utilities.go
  • Line 1: warning: don't use MixedCaps in package name; privacyExtension should be privacyextension (golint)

• quorum/extension/privacyExtension/state_setter.go
  • Line 1: warning: don't use MixedCaps in package name; privacyExtension should be privacyextension (golint)
  • Line 16: warning: exported var DefaultExtensionHandler should have comment or be unexported (golint)
  • Line 18: warning: exported type ExtensionHandler should have comment or be unexported (golint)
  • Line 24: warning: exported function Init should have comment or be unexported (golint)
  • Line 28: warning: exported function NewExtensionHandler should have comment or be unexported (golint)
  • Line 32: warning: exported method ExtensionHandler.SupportMultitenancy should have comment or be unexported (golint)
  • Line 36: warning: exported method ExtensionHandler.SetPSMR should have comment or be unexported (golint)
  • Line 40: warning: exported method ExtensionHandler.CheckExtensionAndSetPrivateState should have comment or be unexported (golint)
  • Line 87: warning: exported method ExtensionHandler.FetchStateData should have comment or be unexported (golint)
  • Line 110: warning: exported method ExtensionHandler.FetchDataFromPTM should have comment or be unexported (golint)
  • Line 127: warning: exported method ExtensionHandler.UuidIsOwn should have comment or be unexported (golint)

• quorum/common/prque/prque.go
  • Line 24: warning: comment on exported type Prque should be of the form "Prque ..." (with optional leading article) (golint)
  • Line 34: warning: comment on exported method Prque.Push should be of the form "Push ..." (golint)
  • Line 45: warning: comment on exported method Prque.Pop should be of the form "Pop ..." (golint)
  • Line 52: warning: comment on exported method Prque.PopItem should be of the form "PopItem ..." (golint)
  • Line 65: warning: comment on exported method Prque.Empty should be of the form "Empty ..." (golint)
  • Line 70: warning: comment on exported method Prque.Size should be of the form "Size ..." (golint)
  • Line 75: warning: comment on exported method Prque.Reset should be of the form "Reset ..." (golint)

• quorum/consensus/istanbul/validator/validator.go
  • Line 26: warning: exported function New should have comment or be unexported (golint)
  • Line 32: warning: exported function NewSet should have comment or be unexported (golint)
  • Line 36: warning: exported function ExtractValidators should have comment or be unexported (golint)
  • Line 46: warning: comment on exported function ValidExtraData should be of the form "ValidExtraData ..." (golint)
  • Line 51: warning: exported function SortedAddresses should have comment or be unexported (golint)

• quorum/core/vm/operations_acl.go
  • Line 28: warning: exported const ColdAccountAccessCostEIP2929 should have comment (or a comment on this block) or be unexported (golint)

• quorum/les/lespay/server/balance.go
  • Line 591: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/p2p/simulations/adapters/exec.go
  • Line 532: warning: exported method SnapshotAPI.Snapshot should have comment or be unexported (golint)

• quorum/les/server_handler.go
  • Line 51: warning: exported const MaxHeaderFetch should have comment (or a comment on this block) or be unexported (golint)

• quorum/signer/core/cliui.go
  • Line 33: warning: exported type CommandlineUI should have comment or be unexported (golint)
  • Line 38: warning: exported function NewCommandlineUI should have comment or be unexported (golint)
  • Line 42: warning: exported method CommandlineUI.RegisterUIServer should have comment or be unexported (golint)
  • Line 61: warning: exported method CommandlineUI.OnInputRequired should have comment or be unexported (golint)
  • Line 221: warning: exported method CommandlineUI.OnApprovedTx should have comment or be unexported (golint)
  • Line 230: warning: exported method CommandlineUI.OnSignerStartup should have comment or be unexported (golint)

• quorum/consensus/istanbul/qbft/engine/apply_extra.go
  • Line 5: warning: exported type ApplyQBFTExtra should have comment or be unexported (golint)
  • Line 7: warning: exported function Combine should have comment or be unexported (golint)
  • Line 19: warning: exported function ApplyHeaderQBFTExtra should have comment or be unexported (golint)

• quorum/consensus/istanbul/backend/handler.go
  • Line 36: warning: exported const NewBlockMsg should have comment (or a comment on this block) or be unexported (golint)
  • Line 140: warning: exported method Backend.NewChainHead should have comment or be unexported (golint)

• quorum/extension/types.go
  • Line 33: warning: exported type ExtensionContract should have comment or be unexported (golint)

• quorum/les/lespay/server/prioritypool.go
  • Line 291: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• quorum/permission/v1/contract.go
  • Line 17: warning: exported type PermissionModelV1 should have comment or be unexported (golint)
  • Line 23: warning: exported type Audit should have comment or be unexported (golint)
  • Line 27: warning: exported type Role should have comment or be unexported (golint)
  • Line 31: warning: exported type Control should have comment or be unexported (golint)
  • Line 34: warning: exported type Org should have comment or be unexported (golint)
  • Line 38: warning: exported type Node should have comment or be unexported (golint)
  • Line 42: warning: exported type Account should have comment or be unexported (golint)
  • Line 46: warning: exported type Init should have comment or be unexported (golint)
  • Line 66: warning: exported method Init.GetAccountDetailsFromIndex should have comment or be unexported (golint)
  • Line 70: warning: exported method Init.GetNumberOfAccounts should have comment or be unexported (golint)
  • Line 74: warning: exported method Init.GetRoleDetailsFromIndex should have comment or be unexported (golint)
  • Line 85: warning: exported method Init.GetNumberOfRoles should have comment or be unexported (golint)
  • Line 89: warning: exported method Init.GetNumberOfOrgs should have comment or be unexported (golint)
  • Line 93: warning: exported method Init.UpdateNetworkBootStatus should have comment or be unexported (golint)
  • Line 97: warning: exported method Init.AddAdminAccount should have comment or be unexported (golint)
  • Line 101: warning: exported method Init.AddAdminNode should have comment or be unexported (golint)
  • Line 105: warning: exported method Init.SetPolicy should have comment or be unexported (golint)
  • Line 109: warning: exported method Init.Init should have comment or be unexported (golint)
  • Line 113: warning: exported method Init.GetAccountDetails should have comment or be unexported (golint)
  • Line 117: warning: exported method Init.GetNodeDetailsFromIndex should have comment or be unexported (golint)
  • Line 122: warning: exported method Init.GetNumberOfNodes should have comment or be unexported (golint)
  • Line 126: warning: exported method Init.GetNodeDetails should have comment or be unexported (golint)
  • Line 131: warning: exported method Init.GetRoleDetails should have comment or be unexported (golint)
  • Line 142: warning: exported method Init.GetSubOrgIndexes should have comment or be unexported (golint)
  • Line 146: warning: exported method Init.GetOrgInfo should have comment or be unexported (golint)
  • Line 150: warning: exported method Init.GetNetworkBootStatus should have comment or be unexported (golint)
  • Line 154: warning: exported method Init.GetOrgDetails should have comment or be unexported (golint)
  • Line 158: warning: exported method Audit.ValidatePendingOp should have comment or be unexported (golint)
  • Line 163: warning: exported method Audit.CheckPendingOp should have comment or be unexported (golint)
  • Line 168: warning: exported method Control.ConnectionAllowed should have comment or be unexported (golint)
  • Line 183: warning: exported method Control.TransactionAllowed should have comment or be unexported (golint)
  • Line 204: warning: exported method Role.RemoveRole should have comment or be unexported (golint)
  • Line 208: warning: exported method Role.AddNewRole should have comment or be unexported (golint)
  • Line 215: warning: exported method Org.ApproveOrgStatus should have comment or be unexported (golint)
  • Line 219: warning: exported method Org.UpdateOrgStatus should have comment or be unexported (golint)
  • Line 223: warning: exported method Org.ApproveOrg should have comment or be unexported (golint)
  • Line 227: warning: exported method Org.AddSubOrg should have comment or be unexported (golint)
  • Line 231: warning: exported method Org.AddOrg should have comment or be unexported (golint)
  • Line 235: warning: exported method Node.ApproveBlacklistedNodeRecovery should have comment or be unexported (golint)
  • Line 239: warning: exported method Node.StartBlacklistedNodeRecovery should have comment or be unexported (golint)
  • Line 243: warning: exported method Node.AddNode should have comment or be unexported (golint)
  • Line 247: warning: exported method Node.UpdateNodeStatus should have comment or be unexported (golint)
  • Line 251: warning: exported method Account.AssignAccountRole should have comment or be unexported (golint)
  • Line 255: warning: exported method Account.UpdateAccountStatus should have comment or be unexported (golint)
  • Line 259: warning: exported method Account.StartBlacklistedAccountRecovery should have comment or be unexported (golint)
  • Line 263: warning: exported method Account.ApproveBlacklistedAccountRecovery should have comment or be unexported (golint)
  • Line 267: warning: exported method Account.ApproveAdminRole should have comment or be unexported (golint)
  • Line 271: warning: exported method Account.AssignAdminRole should have comment or be unexported (golint)
  • Line 275: warning: comment on exported method Init.BindContracts should be of the form "BindContracts ..." (golint)

• quorum/rpc/types.go
  • Line 75: warning: exported type BlockNumber should have comment or be unexported (golint)
  • Line 78: warning: exported const PendingBlockNumber should have comment (or a comment on this block) or be unexported (golint)
  • Line 118: warning: exported method BlockNumber.Int64 should have comment or be unexported (golint)
  • Line 122: warning: exported type BlockNumberOrHash should have comment or be unexported (golint)
  • Line 128: warning: exported method BlockNumberOrHash.UnmarshalJSON should have comment or be unexported (golint)
  • Line 168: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 183: warning: exported method BlockNumberOrHash.Number should have comment or be unexported (golint)
  • Line 190: warning: exported method BlockNumberOrHash.Hash should have comment or be unexported (golint)
  • Line 197: warning: exported function BlockNumberOrHashWithNumber should have comment or be unexported (golint)
  • Line 205: warning: exported function BlockNumberOrHashWithHash should have comment or be unexported (golint)

gocyclo86%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• quorum/consensus/ethash/sealer.go
  • Line 51: warning: cyclomatic complexity 18 of function (*Ethash).Seal() is high (> 15) (gocyclo)
  • Line 266: warning: cyclomatic complexity 17 of function (*remoteSealer).loop() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/backend/engine_test.go
  • Line 352: warning: cyclomatic complexity 27 of function TestVerifyHeaders() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/handler.go
  • Line 74: warning: cyclomatic complexity 16 of function (*core).handleEvents() is high (> 15) (gocyclo)

• quorum/cmd/abigen/main.go
  • Line 124: warning: cyclomatic complexity 31 of function abigen() is high (> 15) (gocyclo)

• quorum/consensus/ethash/consensus.go
  • Line 247: warning: cyclomatic complexity 18 of function (*Ethash).verifyHeader() is high (> 15) (gocyclo)

• quorum/eth/peer.go
  • Line 579: warning: cyclomatic complexity 22 of function (*peer).Handshake() is high (> 15) (gocyclo)

• quorum/core/blockchain_test.go
  • Line 2075: warning: cyclomatic complexity 28 of function TestTransactionIndices() is high (> 15) (gocyclo)
  • Line 594: warning: cyclomatic complexity 28 of function TestFastVsFullChains() is high (> 15) (gocyclo)
  • Line 2202: warning: cyclomatic complexity 21 of function TestSkipStaleTxIndicesInFastSync() is high (> 15) (gocyclo)
  • Line 2728: warning: cyclomatic complexity 19 of function TestDeleteRecreateSlotsAcrossManyBlocks() is high (> 15) (gocyclo)
  • Line 1834: warning: cyclomatic complexity 18 of function testInsertKnownChainData() is high (> 15) (gocyclo)
  • Line 380: warning: cyclomatic complexity 17 of function testReorg() is high (> 15) (gocyclo)
  • Line 1261: warning: cyclomatic complexity 17 of function TestEIP155Transition() is high (> 15) (gocyclo)
  • Line 826: warning: cyclomatic complexity 17 of function TestChainTxReorgs() is high (> 15) (gocyclo)

• quorum/core/genesis.go
  • Line 155: warning: cyclomatic complexity 25 of function SetupGenesisBlock() is high (> 15) (gocyclo)

• quorum/cmd/utils/cmd.go
  • Line 88: warning: cyclomatic complexity 17 of function ImportChain() is high (> 15) (gocyclo)

• quorum/les/api.go
  • Line 110: warning: cyclomatic complexity 17 of function (*PrivateLightServerAPI).setParams() is high (> 15) (gocyclo)
  • Line 217: warning: cyclomatic complexity 17 of function (*PrivateLightServerAPI).Benchmark() is high (> 15) (gocyclo)

• quorum/core/rawdb/freezer.go
  • Line 267: warning: cyclomatic complexity 39 of function (*freezer).freeze() is high (> 15) (gocyclo)

• quorum/eth/filters/api.go
  • Line 485: warning: cyclomatic complexity 26 of function (*FilterCriteria).UnmarshalJSON() is high (> 15) (gocyclo)

• quorum/eth/fetcher/tx_fetcher.go
  • Line 346: warning: cyclomatic complexity 76 of function (*TxFetcher).loop() is high (> 15) (gocyclo)

• quorum/accounts/usbwallet/hub.go
  • Line 134: warning: cyclomatic complexity 22 of function (*Hub).refreshWallets() is high (> 15) (gocyclo)

• quorum/p2p/simulations/http_test.go
  • Line 596: warning: cyclomatic complexity 33 of function TestHTTPSnapshot() is high (> 15) (gocyclo)
  • Line 477: warning: cyclomatic complexity 16 of function (*expectEvents).expect() is high (> 15) (gocyclo)

• quorum/les/clientpool.go
  • Line 108: warning: cyclomatic complexity 16 of function newClientPool() is high (> 15) (gocyclo)

• quorum/core/rawdb/database.go
  • Line 273: warning: cyclomatic complexity 43 of function InspectDatabase() is high (> 15) (gocyclo)

• quorum/core/rawdb/chain_iterator.go
  • Line 90: warning: cyclomatic complexity 17 of function iterateTransactions() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/qbft/core/justification_test.go
  • Line 71: warning: cyclomatic complexity 20 of function testParameterizedCase() is high (> 15) (gocyclo)

• quorum/cmd/faucet/faucet.go
  • Line 311: warning: cyclomatic complexity 50 of function (*faucet).apiHandler() is high (> 15) (gocyclo)
  • Line 99: warning: cyclomatic complexity 19 of function main() is high (> 15) (gocyclo)

• quorum/accounts/abi/abi_test.go
  • Line 858: warning: cyclomatic complexity 19 of function TestUnpackIntoMapNamingConflict() is high (> 15) (gocyclo)

• quorum/consensus/clique/api.go
  • Line 134: warning: cyclomatic complexity 16 of function (*API).Status() is high (> 15) (gocyclo)

• quorum/les/fetcher.go
  • Line 259: warning: cyclomatic complexity 48 of function (*lightFetcher).mainloop() is high (> 15) (gocyclo)

• quorum/eth/filters/filter_test.go
  • Line 99: warning: cyclomatic complexity 23 of function TestFilters() is high (> 15) (gocyclo)

• quorum/eth/filters/filter_system.go
  • Line 443: warning: cyclomatic complexity 16 of function (*EventSystem).eventLoop() is high (> 15) (gocyclo)

• quorum/extension/api.go
  • Line 221: warning: cyclomatic complexity 21 of function (*PrivateExtensionAPI).ExtendContract() is high (> 15) (gocyclo)

• quorum/accounts/abi/bind/bind.go
  • Line 50: warning: cyclomatic complexity 33 of function Bind() is high (> 15) (gocyclo)

• quorum/accounts/usbwallet/trezor.go
  • Line 276: warning: cyclomatic complexity 19 of function (*trezorDriver).trezorExchange() is high (> 15) (gocyclo)

• quorum/core/dao_test.go
  • Line 31: warning: cyclomatic complexity 22 of function TestDAOForkRangeExtradata() is high (> 15) (gocyclo)

• quorum/console/bridge.go
  • Line 102: warning: cyclomatic complexity 23 of function (*bridge).OpenWallet() is high (> 15) (gocyclo)

• quorum/tests/rlp_test_util.go
  • Line 124: warning: cyclomatic complexity 16 of function checkDecodeFromJSON() is high (> 15) (gocyclo)

• quorum/eth/downloader/downloader.go
  • Line 770: warning: cyclomatic complexity 46 of function (*Downloader).findAncestor() is high (> 15) (gocyclo)
  • Line 1498: warning: cyclomatic complexity 45 of function (*Downloader).processHeaders() is high (> 15) (gocyclo)
  • Line 1323: warning: cyclomatic complexity 44 of function (*Downloader).fetchParts() is high (> 15) (gocyclo)
  • Line 985: warning: cyclomatic complexity 42 of function (*Downloader).fetchHeaders() is high (> 15) (gocyclo)
  • Line 451: warning: cyclomatic complexity 26 of function (*Downloader).syncWithPeer() is high (> 15) (gocyclo)
  • Line 1725: warning: cyclomatic complexity 22 of function (*Downloader).processFastSyncContent() is high (> 15) (gocyclo)
  • Line 2161: warning: cyclomatic complexity 22 of function (*Downloader).fetchBoundedHeaders() is high (> 15) (gocyclo)
  • Line 371: warning: cyclomatic complexity 18 of function (*Downloader).synchronise() is high (> 15) (gocyclo)
  • Line 650: warning: cyclomatic complexity 18 of function (*Downloader).fetchHead() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_genesis.go
  • Line 39: warning: cyclomatic complexity 16 of function (*wizard).makeGenesis() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/backlog_test.go
  • Line 35: warning: cyclomatic complexity 33 of function TestCheckMessage() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/core.go
  • Line 185: warning: cyclomatic complexity 17 of function (*core).startNewRound() is high (> 15) (gocyclo)

• quorum/cmd/geth/retesteth.go
  • Line 278: warning: cyclomatic complexity 26 of function (*RetestethAPI).SetChainParams() is high (> 15) (gocyclo)
  • Line 464: warning: cyclomatic complexity 20 of function (*RetestethAPI).mineBlock() is high (> 15) (gocyclo)
  • Line 750: warning: cyclomatic complexity 16 of function (*RetestethAPI).StorageRangeAt() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_intro.go
  • Line 47: warning: cyclomatic complexity 28 of function (*wizard).run() is high (> 15) (gocyclo)

• quorum/cmd/evm/internal/t8ntool/transition.go
  • Line 72: warning: cyclomatic complexity 22 of function Main() is high (> 15) (gocyclo)

• quorum/p2p/simulations/network.go
  • Line 956: warning: cyclomatic complexity 21 of function (*Network).Load() is high (> 15) (gocyclo)

• quorum/core/types/receipt_test.go
  • Line 300: warning: cyclomatic complexity 16 of function testReceiptFields() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/wipe_test.go
  • Line 30: warning: cyclomatic complexity 21 of function TestWipe() is high (> 15) (gocyclo)

• quorum/core/vm/gas_table.go
  • Line 96: warning: cyclomatic complexity 17 of function gasSStore() is high (> 15) (gocyclo)

• quorum/eth/filters/filter.go
  • Line 299: warning: cyclomatic complexity 17 of function filterLogs() is high (> 15) (gocyclo)

• quorum/accounts/keystore/account_cache.go
  • Line 233: warning: cyclomatic complexity 16 of function (*accountCache).scanAccounts() is high (> 15) (gocyclo)

• quorum/cmd/clef/main.go
  • Line 584: warning: cyclomatic complexity 22 of function signer() is high (> 15) (gocyclo)

• quorum/eth/downloader/queue.go
  • Line 689: warning: cyclomatic complexity 17 of function (*queue).DeliverHeaders() is high (> 15) (gocyclo)

• quorum/core/blockchain.go
  • Line 1249: warning: cyclomatic complexity 65 of function (*BlockChain).InsertReceiptChain() is high (> 15) (gocyclo)
  • Line 1857: warning: cyclomatic complexity 52 of function (*BlockChain).insertChain() is high (> 15) (gocyclo)
  • Line 234: warning: cyclomatic complexity 37 of function NewBlockChain() is high (> 15) (gocyclo)
  • Line 2295: warning: cyclomatic complexity 33 of function (*BlockChain).reorg() is high (> 15) (gocyclo)
  • Line 1646: warning: cyclomatic complexity 30 of function (*BlockChain).writeBlockWithState() is high (> 15) (gocyclo)
  • Line 559: warning: cyclomatic complexity 22 of function (*BlockChain).SetHeadBeyondRoot() is high (> 15) (gocyclo)
  • Line 2175: warning: cyclomatic complexity 21 of function (*BlockChain).insertSideChain() is high (> 15) (gocyclo)
  • Line 2483: warning: cyclomatic complexity 18 of function (*BlockChain).maintainTxIndex() is high (> 15) (gocyclo)
  • Line 1102: warning: cyclomatic complexity 16 of function (*BlockChain).Stop() is high (> 15) (gocyclo)

• quorum/tests/fuzzers/trie/trie-fuzzer.go
  • Line 147: warning: cyclomatic complexity 16 of function runRandTest() is high (> 15) (gocyclo)

• quorum/les/sync_test.go
  • Line 43: warning: cyclomatic complexity 16 of function testCheckpointSyncing() is high (> 15) (gocyclo)

• quorum/core/state_processor.go
  • Line 225: warning: cyclomatic complexity 25 of function ApplyTransaction() is high (> 15) (gocyclo)

• quorum/accounts/scwallet/wallet.go
  • Line 440: warning: cyclomatic complexity 25 of function (*Wallet).selfDerive() is high (> 15) (gocyclo)
  • Line 338: warning: cyclomatic complexity 17 of function (*Wallet).Open() is high (> 15) (gocyclo)

• quorum/core/bloombits/matcher.go
  • Line 259: warning: cyclomatic complexity 30 of function (*Matcher).subMatch() is high (> 15) (gocyclo)
  • Line 381: warning: cyclomatic complexity 24 of function (*Matcher).distributor() is high (> 15) (gocyclo)

• quorum/les/server_handler.go
  • Line 207: warning: cyclomatic complexity 140 of function (*serverHandler).handleMsg() is high (> 15) (gocyclo)

• quorum/les/distributor.go
  • Line 192: warning: cyclomatic complexity 18 of function (*requestDistributor).nextRequest() is high (> 15) (gocyclo)

• quorum/eth/protocol_test.go
  • Line 281: warning: cyclomatic complexity 19 of function testSendTransactions() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_faucet.go
  • Line 29: warning: cyclomatic complexity 21 of function (*wizard).deployFaucet() is high (> 15) (gocyclo)

• quorum/raft/handler.go
  • Line 834: warning: cyclomatic complexity 25 of function (*ProtocolManager).eventLoop() is high (> 15) (gocyclo)
  • Line 445: warning: cyclomatic complexity 20 of function (*ProtocolManager).startRaft() is high (> 15) (gocyclo)

• quorum/les/peer.go
  • Line 564: warning: cyclomatic complexity 18 of function (*serverPeer).Handshake() is high (> 15) (gocyclo)

• quorum/core/vm/interpreter.go
  • Line 142: warning: cyclomatic complexity 35 of function (*EVMInterpreter).Run() is high (> 15) (gocyclo)

• quorum/eth/fetcher/block_fetcher.go
  • Line 332: warning: cyclomatic complexity 86 of function (*BlockFetcher).loop() is high (> 15) (gocyclo)

• quorum/trie/stacktrie.go
  • Line 282: warning: cyclomatic complexity 17 of function (*StackTrie).hash() is high (> 15) (gocyclo)
  • Line 136: warning: cyclomatic complexity 16 of function (*StackTrie).insert() is high (> 15) (gocyclo)

• quorum/accounts/abi/reflect.go
  • Line 186: warning: cyclomatic complexity 17 of function mapArgNamesToStructFields() is high (> 15) (gocyclo)

• quorum/p2p/simulations/mocker_test.go
  • Line 33: warning: cyclomatic complexity 25 of function TestMocker() is high (> 15) (gocyclo)

• quorum/p2p/simulations/http.go
  • Line 382: warning: cyclomatic complexity 18 of function (*Server).StreamNetworkEvents() is high (> 15) (gocyclo)

• quorum/miner/worker.go
  • Line 948: warning: cyclomatic complexity 31 of function (*worker).commitNewWork() is high (> 15) (gocyclo)
  • Line 453: warning: cyclomatic complexity 28 of function (*worker).mainLoop() is high (> 15) (gocyclo)
  • Line 834: warning: cyclomatic complexity 22 of function (*worker).commitTransactions() is high (> 15) (gocyclo)
  • Line 357: warning: cyclomatic complexity 20 of function (*worker).newWorkLoop() is high (> 15) (gocyclo)

• quorum/les/pruner_test.go
  • Line 30: warning: cyclomatic complexity 26 of function TestLightPruner() is high (> 15) (gocyclo)

• quorum/ethclient/ethclient.go
  • Line 125: warning: cyclomatic complexity 21 of function (*Client).getBlock() is high (> 15) (gocyclo)

• quorum/accounts/abi/unpack.go
  • Line 193: warning: cyclomatic complexity 20 of function toGoType() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/ssh.go
  • Line 49: warning: cyclomatic complexity 21 of function dial() is high (> 15) (gocyclo)

• quorum/p2p/discover/v4_udp.go
  • Line 409: warning: cyclomatic complexity 22 of function (*UDPv4).loop() is high (> 15) (gocyclo)

• quorum/crypto/blake2b/blake2b_test.go
  • Line 154: warning: cyclomatic complexity 18 of function testHashes2X() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_dashboard.go
  • Line 27: warning: cyclomatic complexity 34 of function (*wizard).deployDashboard() is high (> 15) (gocyclo)

• quorum/mobile/android_test.go
  • Line 157: warning: cyclomatic complexity 18 of function TestAndroid() is high (> 15) (gocyclo)

• quorum/core/rawdb/freezer_table.go
  • Line 199: warning: cyclomatic complexity 19 of function (*freezerTable).repair() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/iterator_test.go
  • Line 308: warning: cyclomatic complexity 17 of function TestAccountIteratorTraversalValues() is high (> 15) (gocyclo)
  • Line 402: warning: cyclomatic complexity 17 of function TestStorageIteratorTraversalValues() is high (> 15) (gocyclo)

• quorum/core/state_transition.go
  • Line 238: warning: cyclomatic complexity 26 of function (*StateTransition).TransitionDb() is high (> 15) (gocyclo)

• quorum/accounts/abi/bind/backends/simulated.go
  • Line 453: warning: cyclomatic complexity 20 of function (*SimulatedBackend).EstimateGas() is high (> 15) (gocyclo)

• quorum/consensus/clique/snapshot_test.go
  • Line 99: warning: cyclomatic complexity 27 of function TestClique() is high (> 15) (gocyclo)

• quorum/mobile/geth.go
  • Line 115: warning: cyclomatic complexity 19 of function NewNode() is high (> 15) (gocyclo)

• quorum/p2p/discv5/ticket.go
  • Line 758: warning: cyclomatic complexity 18 of function (*topicRadius).recalcRadius() is high (> 15) (gocyclo)

• quorum/rpc/subscription_test.go
  • Line 49: warning: cyclomatic complexity 16 of function TestSubscriptions() is high (> 15) (gocyclo)

• quorum/common/http/config.go
  • Line 111: warning: cyclomatic complexity 18 of function (*Config).Validate() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_netstats.go
  • Line 201: warning: cyclomatic complexity 29 of function (serverStats).render() is high (> 15) (gocyclo)
  • Line 73: warning: cyclomatic complexity 23 of function (*wizard).gatherStats() is high (> 15) (gocyclo)

• quorum/cmd/geth/consolecmd.go
  • Line 90: warning: cyclomatic complexity 17 of function readTLSClientConfig() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/qbft/types/roundchange.go
  • Line 184: warning: cyclomatic complexity 25 of function (*RoundChange).DecodeRLP() is high (> 15) (gocyclo)

• quorum/les/api_test.go
  • Line 94: warning: cyclomatic complexity 48 of function testCapacityAPI() is high (> 15) (gocyclo)

• quorum/accounts/usbwallet/wallet.go
  • Line 305: warning: cyclomatic complexity 28 of function (*wallet).selfDerive() is high (> 15) (gocyclo)

• quorum/accounts/abi/unpack_test.go
  • Line 504: warning: cyclomatic complexity 36 of function TestUnmarshal() is high (> 15) (gocyclo)

• quorum/console/console.go
  • Line 392: warning: cyclomatic complexity 17 of function (*Console).Interactive() is high (> 15) (gocyclo)
  • Line 479: warning: cyclomatic complexity 16 of function countIndents() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/generate.go
  • Line 156: warning: cyclomatic complexity 32 of function (*diskLayer).generate() is high (> 15) (gocyclo)

• quorum/core/chain_indexer.go
  • Line 304: warning: cyclomatic complexity 20 of function (*ChainIndexer).updateLoop() is high (> 15) (gocyclo)

• quorum/cmd/checkpoint-admin/exec.go
  • Line 125: warning: cyclomatic complexity 18 of function sign() is high (> 15) (gocyclo)

• quorum/p2p/message_test.go
  • Line 88: warning: cyclomatic complexity 19 of function TestEOFSignal() is high (> 15) (gocyclo)

• quorum/extension/backend.go
  • Line 202: warning: cyclomatic complexity 20 of function (*PrivacyService).watchForCompletionEvents() is high (> 15) (gocyclo)

• quorum/eth/handler_test.go
  • Line 316: warning: cyclomatic complexity 22 of function testGetNodeData() is high (> 15) (gocyclo)

• quorum/les/sync.go
  • Line 90: warning: cyclomatic complexity 20 of function (*clientHandler).synchronise() is high (> 15) (gocyclo)

• quorum/core/vm/evm.go
  • Line 512: warning: cyclomatic complexity 33 of function (*EVM).create() is high (> 15) (gocyclo)
  • Line 269: warning: cyclomatic complexity 20 of function (*EVM).Call() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/backend/snapshot_test.go
  • Line 73: warning: cyclomatic complexity 19 of function TestVoting() is high (> 15) (gocyclo)

• quorum/p2p/simulations/mocker.go
  • Line 103: warning: cyclomatic complexity 16 of function probabilistic() is high (> 15) (gocyclo)

• quorum/permission/v2/backend.go
  • Line 156: warning: cyclomatic complexity 22 of function (*Backend).ManageNodePermissions() is high (> 15) (gocyclo)

• quorum/les/client_handler.go
  • Line 140: warning: cyclomatic complexity 36 of function (*clientHandler).handleMsg() is high (> 15) (gocyclo)

• quorum/ethdb/dbtest/testsuite.go
  • Line 30: warning: cyclomatic complexity 45 of function TestDatabaseSuite() is high (> 15) (gocyclo)

• quorum/core/tx_pool_test.go
  • Line 985: warning: cyclomatic complexity 29 of function testTransactionQueueTimeLimiting() is high (> 15) (gocyclo)
  • Line 682: warning: cyclomatic complexity 28 of function TestTransactionPostponing() is high (> 15) (gocyclo)
  • Line 1358: warning: cyclomatic complexity 24 of function TestTransactionPoolRepricing() is high (> 15) (gocyclo)
  • Line 1541: warning: cyclomatic complexity 20 of function TestTransactionPoolUnderpricing() is high (> 15) (gocyclo)
  • Line 587: warning: cyclomatic complexity 19 of function TestTransactionDropping() is high (> 15) (gocyclo)
  • Line 1861: warning: cyclomatic complexity 19 of function testTransactionJournaling() is high (> 15) (gocyclo)
  • Line 1712: warning: cyclomatic complexity 17 of function TestTransactionDeduplication() is high (> 15) (gocyclo)
  • Line 1778: warning: cyclomatic complexity 17 of function TestTransactionReplacement() is high (> 15) (gocyclo)

• quorum/accounts/abi/bind/base.go
  • Line 218: warning: cyclomatic complexity 18 of function (*BoundContract).transact() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_node.go
  • Line 30: warning: cyclomatic complexity 25 of function (*wizard).deployNode() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/preprepare_test.go
  • Line 36: warning: cyclomatic complexity 23 of function TestHandlePreprepare() is high (> 15) (gocyclo)

• quorum/core/state/sync_test.go
  • Line 400: warning: cyclomatic complexity 18 of function TestIncompleteStateSync() is high (> 15) (gocyclo)
  • Line 162: warning: cyclomatic complexity 17 of function testIterativeStateSync() is high (> 15) (gocyclo)

• quorum/eth/handler.go
  • Line 426: warning: cyclomatic complexity 124 of function (*ProtocolManager).handleMsg() is high (> 15) (gocyclo)

• quorum/cmd/evm/internal/t8ntool/execution.go
  • Line 83: warning: cyclomatic complexity 19 of function (*Prestate).Apply() is high (> 15) (gocyclo)

• quorum/cmd/geth/main.go
  • Line 404: warning: cyclomatic complexity 35 of function startNode() is high (> 15) (gocyclo)
  • Line 318: warning: cyclomatic complexity 21 of function prepare() is high (> 15) (gocyclo)

• quorum/internal/ethapi/api.go
  • Line 1046: warning: cyclomatic complexity 32 of function DoEstimateGas() is high (> 15) (gocyclo)
  • Line 2114: warning: cyclomatic complexity 22 of function (*PublicTransactionPoolAPI).Resend() is high (> 15) (gocyclo)
  • Line 1684: warning: cyclomatic complexity 17 of function (*SendTxArgs).setDefaults() is high (> 15) (gocyclo)
  • Line 913: warning: cyclomatic complexity 17 of function DoCall() is high (> 15) (gocyclo)

• quorum/p2p/server.go
  • Line 704: warning: cyclomatic complexity 20 of function (*Server).run() is high (> 15) (gocyclo)
  • Line 941: warning: cyclomatic complexity 17 of function (*Server).setupConn() is high (> 15) (gocyclo)
  • Line 546: warning: cyclomatic complexity 17 of function (*Server).setupDiscovery() is high (> 15) (gocyclo)

• quorum/permission/v1/backend.go
  • Line 158: warning: cyclomatic complexity 22 of function (*Backend).ManageNodePermissions() is high (> 15) (gocyclo)

• quorum/permission/permission_test.go
  • Line 89: warning: cyclomatic complexity 25 of function setup() is high (> 15) (gocyclo)

• quorum/p2p/discv5/net.go
  • Line 354: warning: cyclomatic complexity 53 of function (*Network).loop() is high (> 15) (gocyclo)
  • Line 867: warning: cyclomatic complexity 28 of function init() is high (> 15) (gocyclo)
  • Line 1146: warning: cyclomatic complexity 18 of function (*Network).handleQueryEvent() is high (> 15) (gocyclo)

• quorum/tests/fuzzers/txfetcher/txfetcher_fuzzer.go
  • Line 51: warning: cyclomatic complexity 29 of function Fuzz() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/qbft/core/handler.go
  • Line 93: warning: cyclomatic complexity 16 of function (*core).handleEvents() is high (> 15) (gocyclo)

• quorum/consensus/clique/snapshot.go
  • Line 185: warning: cyclomatic complexity 28 of function (*Snapshot).apply() is high (> 15) (gocyclo)

• quorum/trie/trie.go
  • Line 360: warning: cyclomatic complexity 25 of function (*Trie).delete() is high (> 15) (gocyclo)
  • Line 268: warning: cyclomatic complexity 19 of function (*Trie).insert() is high (> 15) (gocyclo)
  • Line 170: warning: cyclomatic complexity 17 of function (*Trie).tryGetNode() is high (> 15) (gocyclo)

• quorum/ethstats/ethstats.go
  • Line 184: warning: cyclomatic complexity 31 of function (*Service).loop() is high (> 15) (gocyclo)
  • Line 334: warning: cyclomatic complexity 23 of function (*Service).readLoop() is high (> 15) (gocyclo)

• quorum/eth/backend.go
  • Line 99: warning: cyclomatic complexity 34 of function New() is high (> 15) (gocyclo)

• quorum/cmd/evm/staterunner.go
  • Line 51: warning: cyclomatic complexity 17 of function stateTestCmd() is high (> 15) (gocyclo)

• quorum/ethdb/leveldb/leveldb.go
  • Line 231: warning: cyclomatic complexity 41 of function (*Database).meter() is high (> 15) (gocyclo)

• quorum/miner/worker_test.go
  • Line 431: warning: cyclomatic complexity 16 of function testAdjustInterval() is high (> 15) (gocyclo)

• quorum/tests/block_test_util.go
  • Line 220: warning: cyclomatic complexity 16 of function validateHeader() is high (> 15) (gocyclo)

• quorum/trie/sync.go
  • Line 361: warning: cyclomatic complexity 16 of function (*Sync).children() is high (> 15) (gocyclo)

• quorum/cmd/bootnode/main.go
  • Line 37: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• quorum/cmd/puppeth/wizard_ethstats.go
  • Line 28: warning: cyclomatic complexity 19 of function (*wizard).deployEthstats() is high (> 15) (gocyclo)

• quorum/les/lespay/client/valuetracker_test.go
  • Line 40: warning: cyclomatic complexity 24 of function TestValueTracker() is high (> 15) (gocyclo)

• quorum/params/config.go
  • Line 696: warning: cyclomatic complexity 34 of function (*ChainConfig).checkCompatible() is high (> 15) (gocyclo)

• quorum/contracts/checkpointoracle/oracle_test.go
  • Line 167: warning: cyclomatic complexity 16 of function TestCheckpointRegister() is high (> 15) (gocyclo)

• quorum/core/state/statedb_test.go
  • Line 765: warning: cyclomatic complexity 28 of function TestStateDBAccessList() is high (> 15) (gocyclo)
  • Line 602: warning: cyclomatic complexity 21 of function TestCopyCopyCommitCopy() is high (> 15) (gocyclo)
  • Line 530: warning: cyclomatic complexity 17 of function TestCopyCommitCopy() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/conversion.go
  • Line 153: warning: cyclomatic complexity 20 of function generateTrieRoot() is high (> 15) (gocyclo)

• quorum/trie/proof_test.go
  • Line 511: warning: cyclomatic complexity 18 of function TestBadRangeProof() is high (> 15) (gocyclo)
  • Line 193: warning: cyclomatic complexity 17 of function TestRangeProofWithNonExistentProof() is high (> 15) (gocyclo)

• quorum/consensus/clique/clique.go
  • Line 245: warning: cyclomatic complexity 22 of function (*Clique).verifyHeader() is high (> 15) (gocyclo)
  • Line 349: warning: cyclomatic complexity 21 of function (*Clique).snapshot() is high (> 15) (gocyclo)
  • Line 585: warning: cyclomatic complexity 16 of function (*Clique).Seal() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/commit_test.go
  • Line 32: warning: cyclomatic complexity 24 of function TestHandleCommit() is high (> 15) (gocyclo)

• quorum/p2p/simulations/network_test.go
  • Line 38: warning: cyclomatic complexity 49 of function TestSnapshot() is high (> 15) (gocyclo)
  • Line 289: warning: cyclomatic complexity 21 of function TestNetworkSimulation() is high (> 15) (gocyclo)

• quorum/p2p/dial.go
  • Line 224: warning: cyclomatic complexity 23 of function (*dialScheduler).loop() is high (> 15) (gocyclo)

• quorum/eth/api_tracer.go
  • Line 145: warning: cyclomatic complexity 45 of function (*PrivateDebugAPI).traceChain() is high (> 15) (gocyclo)
  • Line 575: warning: cyclomatic complexity 25 of function (*PrivateDebugAPI).standardTraceBlockToFile() is high (> 15) (gocyclo)
  • Line 720: warning: cyclomatic complexity 17 of function (*PrivateDebugAPI).computeStateDB() is high (> 15) (gocyclo)
  • Line 822: warning: cyclomatic complexity 16 of function (*PrivateDebugAPI).TraceCall() is high (> 15) (gocyclo)

• quorum/trie/proof.go
  • Line 219: warning: cyclomatic complexity 28 of function unsetInternal() is high (> 15) (gocyclo)
  • Line 457: warning: cyclomatic complexity 24 of function VerifyRangeProof() is high (> 15) (gocyclo)
  • Line 137: warning: cyclomatic complexity 17 of function proofToPath() is high (> 15) (gocyclo)

• quorum/accounts/abi/type.go
  • Line 68: warning: cyclomatic complexity 29 of function NewType() is high (> 15) (gocyclo)
  • Line 272: warning: cyclomatic complexity 16 of function (Type).pack() is high (> 15) (gocyclo)

• quorum/internal/jsre/jsre.go
  • Line 106: warning: cyclomatic complexity 19 of function (*JSRE).runEventLoop() is high (> 15) (gocyclo)

• quorum/internal/jsre/pretty.go
  • Line 122: warning: cyclomatic complexity 18 of function (ppctx).printObject() is high (> 15) (gocyclo)

• quorum/metrics/ewma_test.go
  • Line 86: warning: cyclomatic complexity 17 of function TestEWMA5() is high (> 15) (gocyclo)
  • Line 17: warning: cyclomatic complexity 17 of function TestEWMA1() is high (> 15) (gocyclo)
  • Line 155: warning: cyclomatic complexity 17 of function TestEWMA15() is high (> 15) (gocyclo)

• quorum/eth/fetcher/tx_fetcher_test.go
  • Line 1253: warning: cyclomatic complexity 87 of function testTransactionFetcher() is high (> 15) (gocyclo)

• quorum/core/blockchain_snapshot_test.go
  • Line 609: warning: cyclomatic complexity 33 of function testSnapshot() is high (> 15) (gocyclo)

• quorum/accounts/abi/topics.go
  • Line 31: warning: cyclomatic complexity 22 of function MakeTopics() is high (> 15) (gocyclo)

• quorum/cmd/evm/runner.go
  • Line 106: warning: cyclomatic complexity 36 of function runCmd() is high (> 15) (gocyclo)

• quorum/eth/filters/api_test.go
  • Line 28: warning: cyclomatic complexity 40 of function TestUnmarshalJSONNewFilterArgs() is high (> 15) (gocyclo)

• quorum/eth/downloader/statesync.go
  • Line 509: warning: cyclomatic complexity 16 of function (*stateSync).process() is high (> 15) (gocyclo)

• quorum/cmd/utils/flags.go
  • Line 1776: warning: cyclomatic complexity 53 of function SetEthConfig() is high (> 15) (gocyclo)
  • Line 1326: warning: cyclomatic complexity 28 of function SetP2PConfig() is high (> 15) (gocyclo)
  • Line 2194: warning: cyclomatic complexity 19 of function MakeChain() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/ibft/core/prepare_test.go
  • Line 33: warning: cyclomatic complexity 27 of function TestHandlePrepare() is high (> 15) (gocyclo)

• quorum/permission/api.go
  • Line 670: warning: cyclomatic complexity 28 of function (*QuorumControlsAPI).valAccountStatusChange() is high (> 15) (gocyclo)
  • Line 610: warning: cyclomatic complexity 26 of function (*QuorumControlsAPI).valNodeStatusChange() is high (> 15) (gocyclo)

• quorum/les/clientpool_test.go
  • Line 125: warning: cyclomatic complexity 18 of function testClientPool() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/qbft/core/backlog.go
  • Line 45: warning: cyclomatic complexity 17 of function (*core).checkMessage() is high (> 15) (gocyclo)

• quorum/p2p/discover/v5wire/msg.go
  • Line 149: warning: cyclomatic complexity 16 of function DecodeMessage() is high (> 15) (gocyclo)

• quorum/core/state/state_test.go
  • Line 262: warning: cyclomatic complexity 17 of function compareStateObjects() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/disklayer_test.go
  • Line 221: warning: cyclomatic complexity 23 of function TestDiskPartialMerge() is high (> 15) (gocyclo)

• quorum/core/state/snapshot/snapshot.go
  • Line 428: warning: cyclomatic complexity 22 of function diffToDisk() is high (> 15) (gocyclo)
  • Line 267: warning: cyclomatic complexity 18 of function (*Tree).Cap() is high (> 15) (gocyclo)

• quorum/les/costtracker.go
  • Line 244: warning: cyclomatic complexity 26 of function (*costTracker).gfLoop() is high (> 15) (gocyclo)

• quorum/core/state/statedb.go
  • Line 936: warning: cyclomatic complexity 22 of function (*StateDB).Commit() is high (> 15) (gocyclo)

• quorum/rlp/encode.go
  • Line 330: warning: cyclomatic complexity 18 of function makeWriter() is high (> 15) (gocyclo)

• quorum/eth/downloader/downloader_test.go
  • Line 1022: warning: cyclomatic complexity 16 of function testInvalidHeaderRollback() is high (> 15) (gocyclo)

• quorum/core/tx_pool.go
  • Line 1303: warning: cyclomatic complexity 21 of function (*TxPool).truncatePending() is high (> 15) (gocyclo)
  • Line 536: warning: cyclomatic complexity 19 of function (*TxPool).validateTx() is high (> 15) (gocyclo)
  • Line 331: warning: cyclomatic complexity 17 of function (*TxPool).loop() is high (> 15) (gocyclo)
  • Line 610: warning: cyclomatic complexity 17 of function (*TxPool).add() is high (> 15) (gocyclo)

• quorum/core/blockchain_sethead_test.go
  • Line 56: warning: cyclomatic complexity 20 of function (*rewindTest).dump() is high (> 15) (gocyclo)
  • Line 1952: warning: cyclomatic complexity 20 of function testSetHead() is high (> 15) (gocyclo)
  • Line 2062: warning: cyclomatic complexity 19 of function verifyNoGaps() is high (> 15) (gocyclo)

• quorum/core/blockchain_repair_test.go
  • Line 1753: warning: cyclomatic complexity 20 of function testRepair() is high (> 15) (gocyclo)

• quorum/accounts/abi/pack_test.go
  • Line 59: warning: cyclomatic complexity 16 of function TestMethodPack() is high (> 15) (gocyclo)

• quorum/consensus/istanbul/backend/engine.go
  • Line 332: warning: cyclomatic complexity 18 of function (*Backend).snapshot() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!