Preparing report...

Report for github.com/pace/bricks

A+    Excellent!    Found 63 issues across 214 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint79%

Golint is a linter for Go source code.

    • bricks/http/oauth2/oauth2.go
    • Line 20: warning: comment on exported type Middleware should be of the form "Middleware ..." (with optional leading article) (golint)
    • Line 26: warning: comment on exported function NewMiddleware should be of the form "NewMiddleware ..." (golint)
    • Line 177: warning: context.Context should be the first parameter of a function (golint)
    • Line 182: warning: comment on exported function BearerToken should be of the form "BearerToken ..." (golint)
    • Line 192: warning: comment on exported function WithBearerToken should be of the form "WithBearerToken ..." (golint)
    • bricks/backend/couchdb/db.go
    • Line 18: warning: exported function DefaultDatabase should have comment or be unexported (golint)
    • Line 22: warning: exported function Database should have comment or be unexported (golint)
    • Line 71: warning: exported function Client should have comment or be unexported (golint)
    • Line 97: warning: exported function ParseConfig should have comment or be unexported (golint)
    • bricks/pkg/cache/testsuite/cache.go
    • Line 18: warning: exported type CacheTestSuite should have comment or be unexported (golint)
    • Line 23: warning: exported method CacheTestSuite.TestPut should have comment or be unexported (golint)
    • Line 91: warning: exported method CacheTestSuite.TestGet should have comment or be unexported (golint)
    • Line 194: warning: exported method CacheTestSuite.TestForget should have comment or be unexported (golint)
    • bricks/backend/couchdb/auth.go
    • Line 8: warning: exported type AuthTransport should have comment or be unexported (golint)
    • Line 13: warning: exported method AuthTransport.RoundTrip should have comment or be unexported (golint)
    • Line 18: warning: exported method AuthTransport.Transport should have comment or be unexported (golint)
    • Line 18: warning: receiver name rt should be consistent with previous receiver name l for AuthTransport (golint)
    • Line 22: warning: exported method AuthTransport.SetTransport should have comment or be unexported (golint)
    • bricks/backend/objstore/objstore.go
    • Line 32: warning: exported function RegisterHealthchecks should have comment or be unexported (golint)
    • Line 36: warning: comment on exported function Client should be of the form "Client ..." (golint)
    • Line 41: warning: comment on exported function DefaultClientFromEnv should be of the form "DefaultClientFromEnv ..." (golint)
    • bricks/maintenance/errors/raven/http.go
    • Line 13: warning: exported function NewHttp should have comment or be unexported (golint)
    • Line 48: warning: comment on exported type Http should be of the form "Http ..." (with optional leading article) (golint)
    • Line 64: warning: exported method Http.Class should have comment or be unexported (golint)
    • Line 66: warning: comment on exported function RecoveryHandler should be of the form "RecoveryHandler ..." (golint)
    • bricks/http/oauth2/middleware/scopes_middleware.go
    • Line 17: warning: comment on exported type ScopesMiddleware should be of the form "ScopesMiddleware ..." (with optional leading article) (golint)
    • Line 23: warning: comment on exported function NewScopesMiddleware should be of the form "NewScopesMiddleware ..." (golint)
    • bricks/pkg/redact/redact.go
    • Line 10: warning: exported type PatternRedactor should have comment or be unexported (golint)
    • Line 22: warning: exported method PatternRedactor.Mask should have comment or be unexported (golint)
    • Line 32: warning: comment on exported method PatternRedactor.AddPatterns should be of the form "AddPatterns ..." (golint)
    • Line 51: warning: exported method PatternRedactor.SetScheme should have comment or be unexported (golint)
    • Line 55: warning: exported method PatternRedactor.Clone should have comment or be unexported (golint)
    • bricks/maintenance/errors/raven/interfaces.go
    • Line 3: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
    • Line 12: warning: exported method Message.Class should have comment or be unexported (golint)
    • Line 14: warning: comment on exported type Template should be of the form "Template ..." (with optional leading article) (golint)
    • Line 27: warning: exported method Template.Class should have comment or be unexported (golint)
    • Line 29: warning: comment on exported type User should be of the form "User ..." (with optional leading article) (golint)
    • Line 38: warning: exported method User.Class should have comment or be unexported (golint)
    • Line 40: warning: comment on exported type Query should be of the form "Query ..." (with optional leading article) (golint)
    • Line 49: warning: exported method Query.Class should have comment or be unexported (golint)
    • bricks/backend/redis/redis.go
    • Line 187: warning: receiver name l should be consistent with previous receiver name lt for logtracer (golint)
    • Line 212: warning: receiver name l should be consistent with previous receiver name lt for logtracer (golint)
    • Line 216: warning: receiver name l should be consistent with previous receiver name lt for logtracer (golint)
    • bricks/pkg/redact/pattern.go
    • Line 24: warning: exported var PatternIBAN should have comment or be unexported (golint)
    • Line 32: warning: comment on exported var PatternCCVisa should be of the form "PatternCCVisa ..." (golint)
    • Line 35: warning: comment on exported var PatternCCMasterCard should be of the form "PatternCCMasterCard ..." (golint)
    • Line 38: warning: comment on exported var PatternCCAmericanExpress should be of the form "PatternCCAmericanExpress ..." (golint)
    • Line 41: warning: comment on exported var PatternCCDinersClub should be of the form "PatternCCDinersClub ..." (golint)
    • Line 44: warning: comment on exported var PatternCCDiscover should be of the form "PatternCCDiscover ..." (golint)
    • Line 47: warning: comment on exported var PatternCCJCB should be of the form "PatternCCJCB ..." (golint)
    • bricks/locale/locale.go
    • Line 4: warning: package comment should be of the form "Package locale ..." (golint)
    • Line 25: warning: exported var ErrNoTimezone should have comment or be unexported (golint)
    • Line 51: warning: comment on exported method Locale.HasLanguage should be of the form "HasLanguage ..." (golint)
    • bricks/maintenance/log/sink.go
    • Line 201: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 208: warning: exported type SinkOption should have comment or be unexported (golint)
    • Line 210: warning: exported function Silent should have comment or be unexported (golint)
    • Line 216: warning: exported function CustomSize should have comment or be unexported (golint)
    • bricks/maintenance/errors/raven/client.go
    • Line 38: warning: exported var ErrPacketDropped should have comment or be unexported (golint)
    • Line 45: warning: exported type Severity should have comment or be unexported (golint)
    • Line 56: warning: exported type Timestamp should have comment or be unexported (golint)
    • Line 58: warning: exported method Timestamp.MarshalJSON should have comment or be unexported (golint)
    • Line 62: warning: exported method Timestamp.UnmarshalJSON should have comment or be unexported (golint)
    • Line 62: warning: receiver name timestamp should be consistent with previous receiver name t for Timestamp (golint)
    • Line 72: warning: exported method Timestamp.Format should have comment or be unexported (golint)
    • Line 72: warning: receiver name timestamp should be consistent with previous receiver name t for Timestamp (golint)
    • Line 84: warning: exported type Culpriter should have comment or be unexported (golint)
    • Line 88: warning: exported type Transport should have comment or be unexported (golint)
    • Line 92: warning: exported type Extra should have comment or be unexported (golint)
    • Line 99: warning: exported type Tag should have comment or be unexported (golint)
    • Line 104: warning: exported type Tags should have comment or be unexported (golint)
    • Line 106: warning: exported method Tag.MarshalJSON should have comment or be unexported (golint)
    • Line 110: warning: exported method Tag.UnmarshalJSON should have comment or be unexported (golint)
    • Line 110: warning: receiver name t should be consistent with previous receiver name tag for Tag (golint)
    • Line 119: warning: exported method Tags.UnmarshalJSON should have comment or be unexported (golint)
    • Line 147: warning: comment on exported type Packet should be of the form "Packet ..." (with optional leading article) (golint)
    • Line 175: warning: exported type Breadcrumb should have comment or be unexported (golint)
    • Line 260: warning: exported method Packet.AddTags should have comment or be unexported (golint)
    • Line 279: warning: exported method Packet.JSON should have comment or be unexported (golint)
    • Line 346: warning: comment on exported var MaxQueueBuffer should be of the form "MaxQueueBuffer ..." (golint)
    • Line 443: warning: comment on exported var DefaultClient should be of the form "DefaultClient ..." (golint)
    • Line 446: warning: exported method Client.SetIgnoreErrors should have comment or be unexported (golint)
    • Line 465: warning: exported function SetIgnoreErrors should have comment or be unexported (golint)
    • Line 471: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 510: warning: comment on exported function SetDSN should be of the form "SetDSN ..." (golint)
    • Line 514: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 521: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 528: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 535: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 560: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 575: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 665: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 686: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 709: warning: comment on exported method Client.CaptureError should be of the form "CaptureError ..." (golint)
    • Line 711: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 733: warning: comment on exported function CaptureError should be of the form "CaptureError ..." (golint)
    • Line 740: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 768: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 806: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 846: warning: exported method Client.Close should have comment or be unexported (golint)
    • Line 846: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 850: warning: exported function Close should have comment or be unexported (golint)
    • Line 853: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 860: warning: exported method Client.URL should have comment or be unexported (golint)
    • Line 860: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 867: warning: exported function URL should have comment or be unexported (golint)
    • Line 869: warning: exported method Client.ProjectID should have comment or be unexported (golint)
    • Line 869: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 876: warning: exported function ProjectID should have comment or be unexported (golint)
    • Line 878: warning: exported method Client.Release should have comment or be unexported (golint)
    • Line 878: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 885: warning: exported function Release should have comment or be unexported (golint)
    • Line 887: warning: exported function IncludePaths should have comment or be unexported (golint)
    • Line 889: warning: exported method Client.IncludePaths should have comment or be unexported (golint)
    • Line 889: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 896: warning: exported function SetIncludePaths should have comment or be unexported (golint)
    • Line 898: warning: exported method Client.SetIncludePaths should have comment or be unexported (golint)
    • Line 898: warning: receiver name client should be consistent with previous receiver name c for Client (golint)
    • Line 905: warning: exported method Client.SetUserContext should have comment or be unexported (golint)
    • Line 911: warning: exported method Client.SetHttpContext should have comment or be unexported (golint)
    • Line 917: warning: exported method Client.SetTagsContext should have comment or be unexported (golint)
    • Line 923: warning: exported method Client.ClearContext should have comment or be unexported (golint)
    • Line 929: warning: exported function SetUserContext should have comment or be unexported (golint)
    • Line 930: warning: exported function SetHttpContext should have comment or be unexported (golint)
    • Line 931: warning: exported function SetTagsContext should have comment or be unexported (golint)
    • Line 932: warning: exported function ClearContext should have comment or be unexported (golint)
    • Line 940: warning: exported method HTTPTransport.Send should have comment or be unexported (golint)
    • bricks/maintenance/errors/raven/exception.go
    • Line 10: warning: exported function NewException should have comment or be unexported (golint)
    • Line 23: warning: comment on exported type Exception should be of the form "Exception ..." (with optional leading article) (golint)
    • Line 34: warning: exported method Exception.Class should have comment or be unexported (golint)
    • Line 36: warning: exported method Exception.Culprit should have comment or be unexported (golint)
    • Line 50: warning: exported method Exceptions.Class should have comment or be unexported (golint)
    • bricks/pkg/redact/scheme.go
    • Line 8: warning: exported type RedactionScheme should have comment or be unexported (golint)
    • Line 30: warning: comment on exported function RedactionSchemeKeepLastJWTNoSignature should be of the form "RedactionSchemeKeepLastJWTNoSignature ..." (golint)
    • bricks/maintenance/errors/raven/stacktrace.go
    • Line 20: warning: comment on exported type Stacktrace should be of the form "Stacktrace ..." (with optional leading article) (golint)
    • Line 26: warning: exported method Stacktrace.Class should have comment or be unexported (golint)
    • Line 28: warning: exported method Stacktrace.Culprit should have comment or be unexported (golint)
    • Line 38: warning: exported type StacktraceFrame should have comment or be unexported (golint)
    • Line 54: warning: comment on exported function GetOrNewStacktrace should be of the form "GetOrNewStacktrace ..." (golint)
    • Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 82: warning: comment on exported function NewStacktrace should be of the form "NewStacktrace ..." (golint)
    • Line 117: warning: comment on exported function NewStacktraceFrame should be of the form "NewStacktraceFrame ..." (golint)
    • bricks/locale/http.go
    • Line 9: warning: exported const HeaderAcceptLanguage should have comment (or a comment on this block) or be unexported (golint)
    • bricks/tools/testserver/main.go
    • Line 37: warning: exported type OauthBackend should have comment or be unexported (golint)
    • Line 39: warning: exported method OauthBackend.IntrospectToken should have comment or be unexported (golint)
    • Line 48: warning: exported type TestService should have comment or be unexported (golint)
    • Line 50: warning: exported method TestService.GetTest should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell94%

Misspell Finds commonly misspelled English words