Report for github.com/percona/qan-agent
A+ Excellent! Found 99 issues across 149 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo93%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
qan-agent/qan/analyzer/mysql/worker/slowlog/worker.go
- Line 174: warning: cyclomatic complexity 19 of function (*Worker).Run() is high (> 15) (gocyclo)
-
-
qan-agent/query/plugin/mysql/tableinfo/tableinfo.go
- Line 29: warning: cyclomatic complexity 16 of function TableInfo() is high (> 15) (gocyclo)
-
-
qan-agent/agent/agent.go
- Line 104: warning: cyclomatic complexity 24 of function (*Agent).Run() is high (> 15) (gocyclo)
- Line 474: warning: cyclomatic complexity 18 of function (*Agent).Handle() is high (> 15) (gocyclo)
-
-
qan-agent/bin/percona-qan-agent/main.go
- Line 152: warning: cyclomatic complexity 21 of function run() is high (> 15) (gocyclo)
-
-
qan-agent/qan/manager.go
- Line 167: warning: cyclomatic complexity 18 of function (*Manager).Handle() is high (> 15) (gocyclo)
-
-
qan-agent/qan/analyzer/mysql/analyzer.go
- Line 284: warning: cyclomatic complexity 17 of function (*RealAnalyzer).run() is high (> 15) (gocyclo)
- Line 213: warning: cyclomatic complexity 16 of function (*RealAnalyzer).configureMySQL() is high (> 15) (gocyclo)
-
-
qan-agent/data/spooler.go
- Line 289: warning: cyclomatic complexity 19 of function (*DiskvSpooler).run() is high (> 15) (gocyclo)
-
-
qan-agent/pct/basedir.go
- Line 53: warning: cyclomatic complexity 16 of function (*basedir).Init() is high (> 15) (gocyclo)
-
-
qan-agent/data/data_test.go
- Line 178: warning: cyclomatic complexity 17 of function (*DiskvSpoolerTestSuite).TestSpoolGzipData() is high (> 15) (gocyclo)
golint42%
Golint is a linter for Go source code.
-
-
qan-agent/client/ws.go
- Line 36: warning: exported const SEND_BUFFER_SIZE should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported var ErrNoLink should have comment or be unexported (golint)
- Line 44: warning: exported type WebsocketClient should have comment or be unexported (golint)
- Line 66: warning: exported function NewWebsocketClient should have comment or be unexported (golint)
- Line 90: warning: exported method WebsocketClient.Start should have comment or be unexported (golint)
- Line 99: warning: exported method WebsocketClient.Stop should have comment or be unexported (golint)
- Line 109: warning: exported method WebsocketClient.Connect should have comment or be unexported (golint)
- Line 139: warning: exported method WebsocketClient.ConnectOnce should have comment or be unexported (golint)
- Line 229: warning: exported method WebsocketClient.Disconnect should have comment or be unexported (golint)
- Line 236: warning: exported method WebsocketClient.DisconnectOnce should have comment or be unexported (golint)
- Line 393: warning: exported method WebsocketClient.SendChan should have comment or be unexported (golint)
- Line 397: warning: exported method WebsocketClient.RecvChan should have comment or be unexported (golint)
- Line 401: warning: exported method WebsocketClient.Send should have comment or be unexported (golint)
- Line 415: warning: exported method WebsocketClient.SendBytes should have comment or be unexported (golint)
- Line 429: warning: exported method WebsocketClient.Recv should have comment or be unexported (golint)
- Line 443: warning: exported method WebsocketClient.ConnectChan should have comment or be unexported (golint)
- Line 447: warning: exported method WebsocketClient.ErrorChan should have comment or be unexported (golint)
- Line 451: warning: exported method WebsocketClient.Conn should have comment or be unexported (golint)
- Line 455: warning: exported method WebsocketClient.Status should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/worker/perfschema/worker.go
- Line 79: warning: exported type WorkerFactory should have comment or be unexported (golint)
- Line 83: warning: exported type RealWorkerFactory should have comment or be unexported (golint)
- Line 93: warning: exported function NewRealWorkerFactory should have comment or be unexported (golint)
- Line 100: warning: exported method RealWorkerFactory.Make should have comment or be unexported (golint)
- Line 212: warning: exported type GetDigestRowsFunc should have comment or be unexported (golint)
- Line 214: warning: exported type Worker should have comment or be unexported (golint)
- Line 236: warning: exported function NewWorker should have comment or be unexported (golint)
- Line 255: warning: exported method Worker.Setup should have comment or be unexported (golint)
- Line 273: warning: exported method Worker.Run should have comment or be unexported (golint)
- Line 307: warning: exported method Worker.Cleanup should have comment or be unexported (golint)
- Line 322: warning: exported method Worker.Stop should have comment or be unexported (golint)
- Line 332: warning: exported method Worker.Status should have comment or be unexported (golint)
- Line 336: warning: exported method Worker.SetConfig should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/collector/collector.go
- Line 16: warning: exported const MgoTimeoutTail should have comment (or a comment on this block) or be unexported (golint)
- Line 19: warning: exported function New should have comment or be unexported (golint)
- Line 26: warning: exported type Collector should have comment or be unexported (golint)
- Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 109: warning: exported method Collector.Status should have comment or be unexported (golint)
- Line 109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 160: warning: exported method Collector.Name should have comment or be unexported (golint)
- Line 160: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/test/version/version.go
- Line 9: warning: exported function Constraint should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/worker/slowlog/worker.go
- Line 40: warning: exported type WorkerFactory should have comment or be unexported (golint)
- Line 44: warning: exported type RealWorkerFactory should have comment or be unexported (golint)
- Line 48: warning: exported function NewRealWorkerFactory should have comment or be unexported (golint)
- Line 55: warning: exported method RealWorkerFactory.Make should have comment or be unexported (golint)
- Line 61: warning: exported type Job should have comment or be unexported (golint)
- Line 75: warning: exported type Worker should have comment or be unexported (golint)
- Line 97: warning: exported function NewWorker should have comment or be unexported (golint)
- Line 139: warning: exported method Worker.Setup should have comment or be unexported (golint)
- Line 174: warning: exported method Worker.Run should have comment or be unexported (golint)
- Line 342: warning: exported method Worker.Stop should have comment or be unexported (golint)
- Line 352: warning: exported method Worker.Cleanup should have comment or be unexported (golint)
- Line 358: warning: exported method Worker.Status should have comment or be unexported (golint)
- Line 362: warning: exported method Worker.SetConfig should have comment or be unexported (golint)
- Line 366: warning: exported method Worker.SetLogParser should have comment or be unexported (golint)
- Line 372: warning: exported method Worker.MakeLogParser should have comment or be unexported (golint)
-
-
qan-agent/test/profiling/profiling.go
- Line 30: warning: exported type Profiling should have comment or be unexported (golint)
- Line 36: warning: exported function New should have comment or be unexported (golint)
- Line 44: warning: exported method Profiling.Enable should have comment or be unexported (golint)
- Line 50: warning: exported method Profiling.Disable should have comment or be unexported (golint)
- Line 56: warning: exported method Profiling.Drop should have comment or be unexported (golint)
- Line 65: warning: exported method Profiling.Exist should have comment or be unexported (golint)
- Line 77: warning: exported method Profiling.Reset should have comment or be unexported (golint)
- Line 93: warning: exported method Profiling.EnableAll should have comment or be unexported (golint)
- Line 99: warning: exported method Profiling.DisableAll should have comment or be unexported (golint)
- Line 105: warning: exported method Profiling.DropAll should have comment or be unexported (golint)
- Line 111: warning: exported method Profiling.ResetAll should have comment or be unexported (golint)
- Line 124: warning: exported method Profiling.Run should have comment or be unexported (golint)
- Line 134: warning: exported method Profiling.RunDB should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/sender/sender.go
- Line 13: warning: exported function New should have comment or be unexported (golint)
- Line 21: warning: exported type Sender should have comment or be unexported (golint)
- Line 38: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 71: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 87: warning: exported method Sender.Status should have comment or be unexported (golint)
- Line 87: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 97: warning: exported method Sender.Name should have comment or be unexported (golint)
- Line 97: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/test/rootdir/rootdir.go
- Line 9: warning: exported function RootDir should have comment or be unexported (golint)
-
-
qan-agent/test/mock/mysql_factory.go
- Line 24: warning: exported type ConnectionFactory should have comment or be unexported (golint)
- Line 28: warning: exported method ConnectionFactory.Make should have comment or be unexported (golint)
-
-
qan-agent/pct/cmd/cmd.go
- Line 31: warning: exported var DefaultTimeout should have comment or be unexported (golint)
- Line 35: warning: exported var ErrNotFound should have comment or be unexported (golint)
- Line 40: warning: comment on exported type Cmd should be of the form "Cmd ..." (with optional leading article) (golint)
- Line 45: warning: exported type CmdFactory should have comment or be unexported (golint)
- Line 49: warning: comment on exported var Factory should be of the form "Factory ..." (golint)
- Line 55: warning: exported type RealCmdFactory should have comment or be unexported (golint)
- Line 58: warning: exported method RealCmdFactory.Make should have comment or be unexported (golint)
- Line 62: warning: exported type RealCmd should have comment or be unexported (golint)
- Line 73: warning: exported function NewRealCmd should have comment or be unexported (golint)
- Line 81: warning: exported method RealCmd.Run should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/mongo.go
- Line 19: warning: exported function New should have comment or be unexported (golint)
- Line 35: warning: comment on exported type MongoAnalyzer should be of the form "MongoAnalyzer ..." (with optional leading article) (golint)
- Line 136: warning: exported method MongoAnalyzer.GetDefaults should have comment or be unexported (golint)
- Line 155: warning: exported type Profiler should have comment or be unexported (golint)
-
-
qan-agent/log/relay.go
- Line 32: warning: exported const BUFFER_SIZE should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported type Relay should have comment or be unexported (golint)
- Line 54: warning: exported function NewRelay should have comment or be unexported (golint)
- Line 78: warning: exported method Relay.LogChan should have comment or be unexported (golint)
- Line 82: warning: exported method Relay.LogLevelChan should have comment or be unexported (golint)
- Line 86: warning: exported method Relay.Status should have comment or be unexported (golint)
- Line 90: warning: exported method Relay.Run should have comment or be unexported (golint)
- Line 145: warning: exported method Relay.Stop should have comment or be unexported (golint)
-
-
qan-agent/query/manager.go
- Line 35: warning: exported const SERVICE_NAME should have comment (or a comment on this block) or be unexported (golint)
- Line 38: warning: exported type Manager should have comment or be unexported (golint)
- Line 48: warning: exported function NewManager should have comment or be unexported (golint)
- Line 62: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 80: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 99: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 140: warning: exported method Manager.Status should have comment or be unexported (golint)
- Line 144: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 148: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/mysql.go
- Line 24: warning: exported function New should have comment or be unexported (golint)
- Line 188: warning: exported method MySQLAnalyzer.GetDefaults should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/util/util.go
- Line 9: warning: exported function GetMySQLConfig should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/profiler.go
- Line 18: warning: exported function New should have comment or be unexported (golint)
- Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 182: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/data/sender.go
- Line 29: warning: exported const MAX_SEND_ERRORS should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported type Sender should have comment or be unexported (golint)
- Line 49: warning: exported function NewSender should have comment or be unexported (golint)
- Line 62: warning: exported method Sender.Start should have comment or be unexported (golint)
- Line 72: warning: exported method Sender.Stop should have comment or be unexported (golint)
- Line 81: warning: exported method Sender.Status should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/status/status.go
- Line 15: warning: exported function New should have comment or be unexported (golint)
-
-
qan-agent/test/mock/service.go
- Line 28: warning: exported type MockServiceManager should have comment or be unexported (golint)
- Line 39: warning: exported function NewMockServiceManager should have comment or be unexported (golint)
- Line 54: warning: exported method MockServiceManager.Start should have comment or be unexported (golint)
- Line 64: warning: exported method MockServiceManager.Stop should have comment or be unexported (golint)
- Line 73: warning: exported method MockServiceManager.Status should have comment or be unexported (golint)
- Line 78: warning: exported method MockServiceManager.GetConfig should have comment or be unexported (golint)
- Line 88: warning: exported method MockServiceManager.IsRunning should have comment or be unexported (golint)
- Line 93: warning: exported method MockServiceManager.Handle should have comment or be unexported (golint)
- Line 98: warning: exported method MockServiceManager.Reset should have comment or be unexported (golint)
- Line 102: warning: exported method MockServiceManager.GetDefaults should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/parser/parser.go
- Line 13: warning: exported function New should have comment or be unexported (golint)
- Line 23: warning: exported type Parser should have comment or be unexported (golint)
- Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 71: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 87: warning: exported method Parser.Status should have comment or be unexported (golint)
- Line 87: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 97: warning: exported method Parser.Name should have comment or be unexported (golint)
- Line 97: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/ticker/ticker.go
- Line 29: warning: exported type Ticker should have comment or be unexported (golint)
- Line 37: warning: exported type TickerFactory should have comment or be unexported (golint)
- Line 41: warning: exported type RealTickerFactory should have comment or be unexported (golint)
- Line 44: warning: exported method RealTickerFactory.Make should have comment or be unexported (golint)
- Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 52: warning: exported type EvenTicker should have comment or be unexported (golint)
- Line 61: warning: exported function NewEvenTicker should have comment or be unexported (golint)
- Line 72: warning: exported method EvenTicker.Run should have comment or be unexported (golint)
- Line 94: warning: exported method EvenTicker.Stop should have comment or be unexported (golint)
- Line 101: warning: exported method EvenTicker.Add should have comment or be unexported (golint)
- Line 109: warning: exported method EvenTicker.Remove should have comment or be unexported (golint)
- Line 117: warning: exported method EvenTicker.ETA should have comment or be unexported (golint)
-
-
qan-agent/query/plugin/mysql/explain/explain.go
- Line 29: warning: exported function Explain should have comment or be unexported (golint)
-
-
qan-agent/pct/client.go
- Line 25: warning: exported type WebsocketClient should have comment or be unexported (golint)
-
-
qan-agent/test/mock/api.go
- Line 29: warning: exported type APIResponse should have comment or be unexported (golint)
- Line 35: warning: exported type API should have comment or be unexported (golint)
- Line 47: warning: exported function NewAPI should have comment or be unexported (golint)
- Line 58: warning: exported function PingAPI should have comment or be unexported (golint)
- Line 66: warning: exported method API.AgentLink should have comment or be unexported (golint)
- Line 70: warning: exported method API.AgentUuid should have comment or be unexported (golint)
- Line 74: warning: exported method API.Conn should have comment or be unexported (golint)
- Line 78: warning: exported method API.Connect should have comment or be unexported (golint)
- Line 82: warning: exported method API.ConnectOnce should have comment or be unexported (golint)
- Line 86: warning: exported method API.GetConnectionConfig should have comment or be unexported (golint)
- Line 95: warning: exported method API.ConnectChan should have comment or be unexported (golint)
- Line 99: warning: exported method API.CreateInstance should have comment or be unexported (golint)
- Line 103: warning: exported method API.Disconnect should have comment or be unexported (golint)
- Line 107: warning: exported method API.DisconnectOnce should have comment or be unexported (golint)
- Line 111: warning: exported method API.EntryLink should have comment or be unexported (golint)
- Line 115: warning: exported method API.ErrorChan should have comment or be unexported (golint)
- Line 119: warning: exported method API.Get should have comment or be unexported (golint)
- Line 145: warning: exported method API.Hostname should have comment or be unexported (golint)
- Line 149: warning: exported method API.Init should have comment or be unexported (golint)
- Line 153: warning: exported method API.Origin should have comment or be unexported (golint)
- Line 157: warning: exported method API.Post should have comment or be unexported (golint)
- Line 161: warning: exported method API.Put should have comment or be unexported (golint)
- Line 171: warning: exported method API.Recv should have comment or be unexported (golint)
- Line 175: warning: exported method API.RecvChan should have comment or be unexported (golint)
- Line 179: warning: exported method API.SendBytes should have comment or be unexported (golint)
- Line 183: warning: exported method API.SendChan should have comment or be unexported (golint)
- Line 187: warning: exported method API.Start should have comment or be unexported (golint)
- Line 191: warning: exported method API.Status should have comment or be unexported (golint)
- Line 195: warning: exported method API.Send should have comment or be unexported (golint)
- Line 199: warning: exported method API.Stop should have comment or be unexported (golint)
- Line 203: warning: exported method API.URL should have comment or be unexported (golint)
-
-
qan-agent/mrms/checker/mysql.go
- Line 28: warning: exported type MySQL should have comment or be unexported (golint)
- Line 36: warning: exported function NewMySQL should have comment or be unexported (golint)
- Line 44: warning: exported method MySQL.Check should have comment or be unexported (golint)
- Line 101: warning: exported method MySQL.DSN should have comment or be unexported (golint)
-
-
qan-agent/test/cmdtest/cmdtest.go
- Line 27: warning: exported type CmdTest should have comment or be unexported (golint)
- Line 33: warning: exported function NewCmdTest should have comment or be unexported (golint)
- Line 50: warning: exported method CmdTest.Run should have comment or be unexported (golint)
- Line 79: warning: exported method CmdTest.ReadLine should have comment or be unexported (golint)
- Line 94: warning: exported method CmdTest.Output should have comment or be unexported (golint)
-
-
qan-agent/test/app.go
- Line 32: warning: exported function FileExists should have comment or be unexported (golint)
- Line 43: warning: exported function GetStatus should have comment or be unexported (golint)
- Line 65: warning: exported function DrainLogChan should have comment or be unexported (golint)
- Line 75: warning: exported function DrainSendChan should have comment or be unexported (golint)
- Line 85: warning: exported function DrainRecvChan should have comment or be unexported (golint)
- Line 95: warning: exported function DrainTraceChan should have comment or be unexported (golint)
- Line 109: warning: exported function DrainBoolChan should have comment or be unexported (golint)
- Line 119: warning: exported function DrainRecvData should have comment or be unexported (golint)
- Line 129: warning: exported function DrainDataChan should have comment or be unexported (golint)
- Line 139: warning: exported function CopyFile should have comment or be unexported (golint)
- Line 144: warning: exported function ClearDir should have comment or be unexported (golint)
- Line 158: warning: exported function LoadReport should have comment or be unexported (golint)
-
-
qan-agent/test/mock/ticker.go
- Line 28: warning: exported type Ticker should have comment or be unexported (golint)
- Line 34: warning: exported function NewTicker should have comment or be unexported (golint)
- Line 43: warning: exported method Ticker.Run should have comment or be unexported (golint)
- Line 51: warning: exported method Ticker.Stop should have comment or be unexported (golint)
- Line 56: warning: exported method Ticker.Add should have comment or be unexported (golint)
- Line 60: warning: exported method Ticker.Remove should have comment or be unexported (golint)
- Line 63: warning: exported method Ticker.ETA should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/factory/factory.go
- Line 38: warning: exported type UnknownTypeError should have comment or be unexported (golint)
- Line 44: warning: exported type Factory should have comment or be unexported (golint)
- Line 52: warning: exported function New should have comment or be unexported (golint)
- Line 69: warning: exported method Factory.Make should have comment or be unexported (golint)
- Line 74: warning: should not use basic type string as key in context.WithValue (golint)
-
-
qan-agent/instance/manager.go
- Line 34: warning: exported var ErrDuplicateInstance should have comment or be unexported (golint)
- Line 39: warning: exported type ErrInstanceNotFound should have comment or be unexported (golint)
- Line 45: warning: exported type Manager should have comment or be unexported (golint)
- Line 55: warning: exported function NewManager should have comment or be unexported (golint)
- Line 74: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 91: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 98: warning: exported method Manager.Status should have comment or be unexported (golint)
- Line 102: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 124: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 128: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
- Line 132: warning: exported method Manager.Repo should have comment or be unexported (golint)
- Line 136: warning: exported function GetMySQLInfo should have comment or be unexported (golint)
-
-
qan-agent/test/mock/null_mysql.go
- Line 30: warning: error var ERR_NOT_FOUND should have name of the form ErrFoo (golint)
- Line 30: warning: exported var ERR_NOT_FOUND should have comment or be unexported (golint)
- Line 32: warning: exported type NullMySQL should have comment or be unexported (golint)
- Line 50: warning: exported function NewNullMySQL should have comment or be unexported (golint)
- Line 62: warning: exported method NullMySQL.DB should have comment or be unexported (golint)
- Line 66: warning: exported method NullMySQL.DSN should have comment or be unexported (golint)
- Line 70: warning: exported method NullMySQL.Connect should have comment or be unexported (golint)
- Line 74: warning: exported method NullMySQL.Close should have comment or be unexported (golint)
- Line 78: warning: exported method NullMySQL.Explain should have comment or be unexported (golint)
- Line 82: warning: exported method NullMySQL.TableInfo should have comment or be unexported (golint)
- Line 86: warning: exported method NullMySQL.Set should have comment or be unexported (golint)
- Line 98: warning: exported method NullMySQL.Exec should have comment or be unexported (golint)
- Line 110: warning: exported method NullMySQL.GetSet should have comment or be unexported (golint)
- Line 114: warning: exported method NullMySQL.GetExec should have comment or be unexported (golint)
- Line 118: warning: exported method NullMySQL.Reset should have comment or be unexported (golint)
- Line 127: warning: exported method NullMySQL.GetGlobalVarBoolean should have comment or be unexported (golint)
- Line 135: warning: exported method NullMySQL.GetGlobalVarString should have comment or be unexported (golint)
- Line 143: warning: exported method NullMySQL.GetGlobalVarNumeric should have comment or be unexported (golint)
- Line 151: warning: exported method NullMySQL.GetGlobalVarInteger should have comment or be unexported (golint)
- Line 159: warning: exported method NullMySQL.SetGlobalVarNumeric should have comment or be unexported (golint)
- Line 165: warning: exported method NullMySQL.SetGlobalVarInteger should have comment or be unexported (golint)
- Line 171: warning: exported method NullMySQL.SetGlobalVarString should have comment or be unexported (golint)
- Line 177: warning: exported method NullMySQL.Uptime should have comment or be unexported (golint)
- Line 182: warning: exported method NullMySQL.AtLeastVersion should have comment or be unexported (golint)
- Line 192: warning: exported method NullMySQL.SetAtLeastVersion should have comment or be unexported (golint)
- Line 197: warning: exported method NullMySQL.GetUptimeCount should have comment or be unexported (golint)
- Line 201: warning: exported method NullMySQL.SetUptime should have comment or be unexported (golint)
- Line 205: warning: exported method NullMySQL.UTCOffset should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/mongo_test.go
- Line 29: warning: should not use basic type string as key in context.WithValue (golint)
-
-
qan-agent/mysql/error.go
- Line 27: warning: exported function MySQLErrorCode should have comment or be unexported (golint)
- Line 35: warning: exported function FormatError should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/analyzer.go
- Line 40: warning: exported const MIN_SLOWLOG_ROTATION_SIZE should have comment or be unexported (golint)
- Line 44: warning: exported type RealAnalyzer should have comment or be unexported (golint)
- Line 67: warning: exported function NewRealAnalyzer should have comment or be unexported (golint)
- Line 104: warning: exported method RealAnalyzer.Start should have comment or be unexported (golint)
- Line 121: warning: exported method RealAnalyzer.Stop should have comment or be unexported (golint)
- Line 136: warning: exported method RealAnalyzer.Status should have comment or be unexported (golint)
- Line 147: warning: exported method RealAnalyzer.Config should have comment or be unexported (golint)
- Line 151: warning: exported method RealAnalyzer.SetConfig should have comment or be unexported (golint)
- Line 155: warning: exported method RealAnalyzer.GetDefaults should have comment or be unexported (golint)
- Line 155: warning: receiver name m should be consistent with previous receiver name a for RealAnalyzer (golint)
- Line 161: warning: comment on exported method RealAnalyzer.TakeOverPerconaServerRotation should be of the form "TakeOverPerconaServerRotation ..." (golint)
-
-
qan-agent/data/manager.go
- Line 34: warning: exported const DEFAULT_DATA_ENCODING should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported type Manager should have comment or be unexported (golint)
- Line 58: warning: exported function NewManager should have comment or be unexported (golint)
- Line 76: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 150: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 167: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 185: warning: exported method Manager.Status should have comment or be unexported (golint)
- Line 189: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 207: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
- Line 217: warning: exported method Manager.Spooler should have comment or be unexported (golint)
- Line 221: warning: exported method Manager.Sender should have comment or be unexported (golint)
-
-
qan-agent/query/plugin/mongo/explain/explain.go
- Line 30: warning: exported const MgoTimeoutDialInfo should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported function Explain should have comment or be unexported (golint)
-
-
qan-agent/test/mock/interval_iter/interval_iter.go
- Line 18: warning: don't use an underscore in package name (golint)
- Line 28: warning: exported type IntervalIterFactory should have comment or be unexported (golint)
- Line 34: warning: exported method IntervalIterFactory.Make should have comment or be unexported (golint)
- Line 44: warning: exported method IntervalIterFactory.Reset should have comment or be unexported (golint)
- Line 50: warning: exported type Iter should have comment or be unexported (golint)
- Line 58: warning: exported function NewIter should have comment or be unexported (golint)
- Line 70: warning: exported method Iter.Start should have comment or be unexported (golint)
- Line 75: warning: exported method Iter.Stop should have comment or be unexported (golint)
- Line 81: warning: exported method Iter.IntervalChan should have comment or be unexported (golint)
- Line 85: warning: exported method Iter.TickChan should have comment or be unexported (golint)
- Line 103: warning: exported method Iter.Calls should have comment or be unexported (golint)
- Line 107: warning: exported method Iter.Reset should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/worker/slowlog/iter.go
- Line 29: warning: exported type FilenameFunc should have comment or be unexported (golint)
- Line 31: warning: exported type Iter should have comment or be unexported (golint)
- Line 41: warning: exported function NewIter should have comment or be unexported (golint)
- Line 53: warning: exported method Iter.Start should have comment or be unexported (golint)
- Line 57: warning: exported method Iter.Stop should have comment or be unexported (golint)
- Line 63: warning: exported method Iter.IntervalChan should have comment or be unexported (golint)
- Line 67: warning: exported method Iter.TickChan should have comment or be unexported (golint)
-
-
qan-agent/ticker/manager.go
- Line 27: warning: exported type Manager should have comment or be unexported (golint)
- Line 33: warning: exported type Clock should have comment or be unexported (golint)
- Line 44: warning: exported function NewClock should have comment or be unexported (golint)
- Line 58: warning: exported method Clock.Add should have comment or be unexported (golint)
- Line 88: warning: exported method Clock.Remove should have comment or be unexported (golint)
- Line 105: warning: exported method Clock.ETA should have comment or be unexported (golint)
- Line 115: warning: comment on exported function Began should be of the form "Began ..." (golint)
-
-
qan-agent/mrms/manager.go
- Line 28: warning: exported const SERVICE_NAME should have comment (or a comment on this block) or be unexported (golint)
- Line 32: warning: exported type Manager should have comment or be unexported (golint)
- Line 39: warning: exported function NewManager should have comment or be unexported (golint)
- Line 49: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 60: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 71: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 75: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
- Line 79: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 83: warning: exported method Manager.Status should have comment or be unexported (golint)
-
-
qan-agent/mysql/mysql.go
- Line 35: warning: exported var ErrNotConnected should have comment or be unexported (golint)
- Line 38: warning: exported type Query should have comment or be unexported (golint)
- Line 44: warning: exported type Connector should have comment or be unexported (golint)
- Line 61: warning: exported type Connection should have comment or be unexported (golint)
- Line 68: warning: exported function NewConnection should have comment or be unexported (golint)
- Line 76: warning: exported method Connection.DB should have comment or be unexported (golint)
- Line 80: warning: exported method Connection.DSN should have comment or be unexported (golint)
- Line 84: warning: exported method Connection.Connect should have comment or be unexported (golint)
- Line 110: warning: exported method Connection.Close should have comment or be unexported (golint)
- Line 123: warning: exported method Connection.Set should have comment or be unexported (golint)
- Line 150: warning: exported method Connection.Exec should have comment or be unexported (golint)
- Line 162: warning: exported method Connection.GetGlobalVarBoolean should have comment or be unexported (golint)
- Line 167: warning: exported method Connection.GetGlobalVarString should have comment or be unexported (golint)
- Line 172: warning: exported method Connection.GetGlobalVarNumeric should have comment or be unexported (golint)
- Line 177: warning: exported method Connection.GetGlobalVarInteger should have comment or be unexported (golint)
- Line 195: warning: exported method Connection.Uptime should have comment or be unexported (golint)
- Line 206: warning: comment on exported method Connection.AtLeastVersion should be of the form "AtLeastVersion ..." (golint)
- Line 238: warning: exported method Connection.UTCOffset should have comment or be unexported (golint)
- Line 272: warning: exported function Distro should have comment or be unexported (golint)
-
-
qan-agent/log/manager.go
- Line 33: warning: exported const DEFAULT_LOG_LEVEL should have comment (or a comment on this block) or be unexported (golint)
- Line 36: warning: exported type Manager should have comment or be unexported (golint)
- Line 49: warning: exported function NewManager should have comment or be unexported (golint)
- Line 60: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 93: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 98: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 146: warning: exported method Manager.Status should have comment or be unexported (golint)
- Line 150: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 166: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
- Line 172: warning: exported method Manager.Relay should have comment or be unexported (golint)
-
-
qan-agent/test/mock/ticker_factory.go
- Line 24: warning: exported type TickerFactory should have comment or be unexported (golint)
- Line 30: warning: exported function NewTickerFactory should have comment or be unexported (golint)
- Line 37: warning: exported method TickerFactory.Make should have comment or be unexported (golint)
- Line 47: warning: exported method TickerFactory.Set should have comment or be unexported (golint)
-
-
qan-agent/pct/backoff.go
- Line 26: warning: exported type Backoff should have comment or be unexported (golint)
- Line 35: warning: exported function NewBackoff should have comment or be unexported (golint)
- Line 44: warning: exported method Backoff.Wait should have comment or be unexported (golint)
- Line 63: warning: exported method Backoff.Success should have comment or be unexported (golint)
-
-
qan-agent/pct/errors.go
- Line 25: warning: exported type ServiceIsRunningError should have comment or be unexported (golint)
- Line 35: warning: exported type ServiceIsNotRunningError should have comment or be unexported (golint)
- Line 45: warning: exported type UnknownServiceError should have comment or be unexported (golint)
- Line 55: warning: exported type CmdTimeoutError should have comment or be unexported (golint)
- Line 65: warning: exported type UnknownCmdError should have comment or be unexported (golint)
- Line 75: warning: exported type QueueFullError should have comment or be unexported (golint)
- Line 89: warning: exported type CmdRejectedError should have comment or be unexported (golint)
- Line 100: warning: exported type InvalidInstanceError should have comment or be unexported (golint)
- Line 111: warning: exported var ErrNoSystemTree should have comment or be unexported (golint)
-
-
qan-agent/test/mock/clock.go
- Line 24: warning: exported type Clock should have comment or be unexported (golint)
- Line 30: warning: exported function NewClock should have comment or be unexported (golint)
- Line 38: warning: exported method Clock.Add should have comment or be unexported (golint)
- Line 42: warning: exported method Clock.Remove should have comment or be unexported (golint)
- Line 46: warning: exported method Clock.ETA should have comment or be unexported (golint)
-
-
qan-agent/query/plugin/mysql/tableinfo/tableinfo.go
- Line 29: warning: exported function TableInfo should have comment or be unexported (golint)
-
-
qan-agent/test/wait.go
- Line 32: warning: exported var Ts should have comment or be unexported (golint)
- Line 34: warning: exported function WaitCmd should have comment or be unexported (golint)
- Line 48: warning: exported function WaitReply should have comment or be unexported (golint)
- Line 62: warning: exported function WaitReplyCmd should have comment or be unexported (golint)
- Line 79: warning: exported function WaitStatusReply should have comment or be unexported (golint)
- Line 92: warning: exported function WaitData should have comment or be unexported (golint)
- Line 106: warning: exported function WaitBytes should have comment or be unexported (golint)
- Line 120: warning: exported function WaitLog should have comment or be unexported (golint)
- Line 139: warning: exported function WaitTrace should have comment or be unexported (golint)
- Line 153: warning: exported function WaitErr should have comment or be unexported (golint)
- Line 167: warning: exported function WaitFiles should have comment or be unexported (golint)
- Line 180: warning: exported function WaitStatus should have comment or be unexported (golint)
- Line 198: warning: exported function WaitStatusPrefix should have comment or be unexported (golint)
- Line 217: warning: exported function WaitState should have comment or be unexported (golint)
-
-
qan-agent/ticker/wait.go
- Line 27: warning: exported type WaitTicker should have comment or be unexported (golint)
- Line 34: warning: exported function NewWaitTicker should have comment or be unexported (golint)
- Line 42: warning: exported method WaitTicker.Run should have comment or be unexported (golint)
- Line 74: warning: exported method WaitTicker.Stop should have comment or be unexported (golint)
- Line 81: warning: exported method WaitTicker.Add should have comment or be unexported (golint)
- Line 85: warning: exported method WaitTicker.Remove should have comment or be unexported (golint)
- Line 89: warning: exported method WaitTicker.ETA should have comment or be unexported (golint)
-
-
qan-agent/test/fakeapi/handlers.go
- Line 29: warning: exported method FakeApi.AppendPing should have comment or be unexported (golint)
- Line 40: warning: exported method FakeApi.AppendInstancesId should have comment or be unexported (golint)
- Line 48: warning: exported method FakeApi.AppendInstances should have comment or be unexported (golint)
-
-
qan-agent/pct/basedir.go
- Line 29: warning: exported const DEFAULT_BASEDIR should have comment (or a comment on this block) or be unexported (golint)
- Line 32: warning: comment on exported const CONFIG_DIR should be of the form "CONFIG_DIR ..." (golint)
- Line 51: warning: exported var Basedir should have comment or be unexported (golint)
-
-
qan-agent/query/plugin/plugin.go
- Line 24: warning: exported type Plugin should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/monitors.go
- Line 12: warning: exported const MgoTimeoutDialInfo should have comment (or a comment on this block) or be unexported (golint)
- Line 22: warning: exported function NewMonitors should have comment or be unexported (golint)
- Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 118: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/data/spooler.go
- Line 38: warning: exported const WRITE_BUFFER should have comment (or a comment on this block) or be unexported (golint)
- Line 42: warning: exported var ErrSpoolTimeout should have comment or be unexported (golint)
- Line 44: warning: exported type Spooler should have comment or be unexported (golint)
- Line 56: warning: comment on exported type DiskvSpooler should be of the form "DiskvSpooler ..." (with optional leading article) (golint)
- Line 79: warning: exported function NewDiskvSpooler should have comment or be unexported (golint)
- Line 100: warning: exported method DiskvSpooler.Start should have comment or be unexported (golint)
- Line 162: warning: exported method DiskvSpooler.Stop should have comment or be unexported (golint)
- Line 171: warning: exported method DiskvSpooler.Status should have comment or be unexported (golint)
- Line 224: warning: exported method DiskvSpooler.Files should have comment or be unexported (golint)
- Line 229: warning: exported method DiskvSpooler.CancelFiles should have comment or be unexported (golint)
- Line 242: warning: exported method DiskvSpooler.Remove should have comment or be unexported (golint)
- Line 262: warning: exported method DiskvSpooler.Reject should have comment or be unexported (golint)
- Line 276: warning: exported method DiskvSpooler.Purge should have comment or be unexported (golint)
- Line 280: warning: exported method DiskvSpooler.PurgeChan should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/worker/perfschema/iter.go
- Line 27: warning: exported type Iter should have comment or be unexported (golint)
- Line 35: warning: exported function NewIter should have comment or be unexported (golint)
- Line 45: warning: exported method Iter.Start should have comment or be unexported (golint)
- Line 49: warning: exported method Iter.Stop should have comment or be unexported (golint)
- Line 55: warning: exported method Iter.IntervalChan should have comment or be unexported (golint)
- Line 59: warning: exported method Iter.TickChan should have comment or be unexported (golint)
-
-
qan-agent/test/mock/spooler.go
- Line 24: warning: exported type Spooler should have comment or be unexported (golint)
- Line 32: warning: exported function NewSpooler should have comment or be unexported (golint)
- Line 41: warning: exported method Spooler.Start should have comment or be unexported (golint)
- Line 45: warning: exported method Spooler.Stop should have comment or be unexported (golint)
- Line 49: warning: exported method Spooler.Status should have comment or be unexported (golint)
- Line 62: warning: exported method Spooler.Files should have comment or be unexported (golint)
- Line 73: warning: exported method Spooler.CancelFiles should have comment or be unexported (golint)
- Line 80: warning: exported method Spooler.Remove should have comment or be unexported (golint)
- Line 85: warning: exported method Spooler.Reject should have comment or be unexported (golint)
- Line 90: warning: exported method Spooler.Reset should have comment or be unexported (golint)
-
-
qan-agent/test/mock/log_parser.go
- Line 24: warning: exported type LogParser should have comment or be unexported (golint)
- Line 28: warning: exported function NewLogParser should have comment or be unexported (golint)
- Line 35: warning: exported method LogParser.Start should have comment or be unexported (golint)
- Line 39: warning: exported method LogParser.Stop should have comment or be unexported (golint)
- Line 44: warning: exported method LogParser.EventChan should have comment or be unexported (golint)
- Line 48: warning: exported method LogParser.Send should have comment or be unexported (golint)
-
-
qan-agent/test/mock/qan_analyzer.go
- Line 28: warning: exported type QanAnalyzer should have comment or be unexported (golint)
- Line 39: warning: exported function NewQanAnalyzer should have comment or be unexported (golint)
- Line 55: warning: exported method QanAnalyzer.Start should have comment or be unexported (golint)
- Line 60: warning: exported method QanAnalyzer.Stop should have comment or be unexported (golint)
- Line 65: warning: exported method QanAnalyzer.Status should have comment or be unexported (golint)
- Line 75: warning: exported method QanAnalyzer.Config should have comment or be unexported (golint)
- Line 79: warning: exported method QanAnalyzer.SetConfig should have comment or be unexported (golint)
- Line 83: warning: exported method QanAnalyzer.ValidateConfig should have comment or be unexported (golint)
- Line 87: warning: exported method QanAnalyzer.GetDefaults should have comment or be unexported (golint)
- Line 111: warning: exported type AnalyzerArgs should have comment or be unexported (golint)
- Line 119: warning: exported type QanAnalyzerFactory should have comment or be unexported (golint)
- Line 125: warning: exported function NewQanAnalyzerFactory should have comment or be unexported (golint)
- Line 133: warning: exported method QanAnalyzerFactory.Make should have comment or be unexported (golint)
-
-
qan-agent/test/mock/ws_server.go
- Line 30: warning: exported function NewWebsocketServer should have comment or be unexported (golint)
- Line 38: warning: exported type WebsocketServer should have comment or be unexported (golint)
- Line 44: warning: comment on exported method WebsocketServer.Run should be of the form "Run ..." (golint)
- Line 54: warning: comment on exported method WebsocketServer.RunWss should be of the form "RunWss ..." (golint)
- Line 127: warning: exported function NewClients should have comment or be unexported (golint)
-
-
qan-agent/instance/repo.go
- Line 33: warning: exported type ByUUID should have comment or be unexported (golint)
- Line 39: warning: exported type Repo should have comment or be unexported (golint)
- Line 48: warning: comment on exported function NewRepo should be of the form "NewRepo ..." (golint)
- Line 61: warning: comment on exported method Repo.Init should be of the form "Init ..." (golint)
- Line 91: warning: exported method Repo.List should have comment or be unexported (golint)
- Line 104: warning: exported method Repo.Add should have comment or be unexported (golint)
- Line 132: warning: exported method Repo.Get should have comment or be unexported (golint)
- Line 192: warning: exported method Repo.Remove should have comment or be unexported (golint)
-
-
qan-agent/pct/logger.go
- Line 27: warning: exported type Logger should have comment or be unexported (golint)
- Line 33: warning: exported function NewLogger should have comment or be unexported (golint)
- Line 41: warning: exported method Logger.Service should have comment or be unexported (golint)
- Line 45: warning: exported method Logger.LogChan should have comment or be unexported (golint)
- Line 49: warning: exported method Logger.Debug should have comment or be unexported (golint)
- Line 53: warning: exported method Logger.DebugOffline should have comment or be unexported (golint)
- Line 58: warning: exported method Logger.Info should have comment or be unexported (golint)
- Line 62: warning: exported method Logger.Warn should have comment or be unexported (golint)
- Line 70: warning: exported method Logger.Fatal should have comment or be unexported (golint)
-
-
qan-agent/test/mock/cmd.go
- Line 24: warning: exported type CmdFactory should have comment or be unexported (golint)
- Line 28: warning: exported method CmdFactory.Make should have comment or be unexported (golint)
- Line 34: warning: exported type MockCmd should have comment or be unexported (golint)
- Line 42: warning: exported function NewMockCmd should have comment or be unexported (golint)
- Line 49: warning: exported method MockCmd.Run should have comment or be unexported (golint)
-
-
qan-agent/test/mock/null_client.go
- Line 25: warning: exported type NullClient should have comment or be unexported (golint)
- Line 31: warning: exported method NullClient.Connect should have comment or be unexported (golint)
- Line 34: warning: exported method NullClient.ConnectOnce should have comment or be unexported (golint)
- Line 38: warning: exported method NullClient.Disconnect should have comment or be unexported (golint)
- Line 42: warning: exported method NullClient.Start should have comment or be unexported (golint)
- Line 45: warning: exported method NullClient.Stop should have comment or be unexported (golint)
- Line 48: warning: exported method NullClient.SendChan should have comment or be unexported (golint)
- Line 52: warning: exported method NullClient.RecvChan should have comment or be unexported (golint)
- Line 56: warning: exported method NullClient.SendBytes should have comment or be unexported (golint)
- Line 60: warning: exported method NullClient.Send should have comment or be unexported (golint)
- Line 64: warning: exported method NullClient.Recv should have comment or be unexported (golint)
- Line 68: warning: exported method NullClient.ErrorChan should have comment or be unexported (golint)
- Line 72: warning: exported method NullClient.ConnectChan should have comment or be unexported (golint)
- Line 76: warning: exported method NullClient.Conn should have comment or be unexported (golint)
-
-
qan-agent/test/mock/ws_client.go
- Line 27: warning: exported type WebsocketClient should have comment or be unexported (golint)
- Line 49: warning: exported function NewWebsocketClient should have comment or be unexported (golint)
- Line 69: warning: exported method WebsocketClient.Connect should have comment or be unexported (golint)
- Line 89: warning: exported method WebsocketClient.ConnectOnce should have comment or be unexported (golint)
- Line 97: warning: exported method WebsocketClient.Disconnect should have comment or be unexported (golint)
- Line 106: warning: exported method WebsocketClient.DisconnectOnce should have comment or be unexported (golint)
- Line 114: warning: exported method WebsocketClient.Start should have comment or be unexported (golint)
- Line 135: warning: exported method WebsocketClient.Stop should have comment or be unexported (golint)
- Line 138: warning: exported method WebsocketClient.SendChan should have comment or be unexported (golint)
- Line 142: warning: exported method WebsocketClient.RecvChan should have comment or be unexported (golint)
- Line 146: warning: exported method WebsocketClient.Send should have comment or be unexported (golint)
- Line 158: warning: exported method WebsocketClient.SendBytes should have comment or be unexported (golint)
- Line 163: warning: exported method WebsocketClient.Recv should have comment or be unexported (golint)
- Line 173: warning: exported method WebsocketClient.ConnectChan should have comment or be unexported (golint)
- Line 177: warning: exported method WebsocketClient.ErrorChan should have comment or be unexported (golint)
- Line 181: warning: exported method WebsocketClient.Conn should have comment or be unexported (golint)
- Line 185: warning: exported method WebsocketClient.SetConnectChan should have comment or be unexported (golint)
- Line 191: warning: exported method WebsocketClient.Status should have comment or be unexported (golint)
-
-
qan-agent/qan/manager.go
- Line 42: warning: exported var ErrNotRunning should have comment or be unexported (golint)
- Line 65: warning: exported function NewManager should have comment or be unexported (golint)
- Line 86: warning: exported method Manager.Start should have comment or be unexported (golint)
- Line 137: warning: exported method Manager.Stop should have comment or be unexported (golint)
- Line 155: warning: exported method Manager.Status should have comment or be unexported (golint)
- Line 167: warning: exported method Manager.Handle should have comment or be unexported (golint)
- Line 258: warning: exported method Manager.GetConfig should have comment or be unexported (golint)
- Line 283: warning: exported method Manager.GetDefaults should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/monitor.go
- Line 17: warning: exported function NewMonitor should have comment or be unexported (golint)
- Line 52: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 91: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/pct/status.go
- Line 27: warning: exported type StatusReporter should have comment or be unexported (golint)
- Line 31: warning: exported type Status should have comment or be unexported (golint)
- Line 36: warning: exported function NewStatus should have comment or be unexported (golint)
- Line 48: warning: exported method Status.Update should have comment or be unexported (golint)
- Line 57: warning: exported method Status.UpdateRe should have comment or be unexported (golint)
- Line 66: warning: exported method Status.Get should have comment or be unexported (golint)
- Line 76: warning: exported method Status.All should have comment or be unexported (golint)
- Line 86: warning: exported method Status.Merge should have comment or be unexported (golint)
-
-
qan-agent/test/fakeapi/fakeapi.go
- Line 26: warning: exported const WS_SCHEME should have comment or be unexported (golint)
- Line 28: warning: exported type FakeApi should have comment or be unexported (golint)
- Line 33: warning: exported function NewFakeApi should have comment or be unexported (golint)
- Line 40: warning: exported method FakeApi.Close should have comment or be unexported (golint)
- Line 44: warning: exported method FakeApi.URL should have comment or be unexported (golint)
- Line 48: warning: exported method FakeApi.WSURL should have comment or be unexported (golint)
- Line 52: warning: exported method FakeApi.Append should have comment or be unexported (golint)
-
-
qan-agent/test/mock/data_client.go
- Line 27: warning: exported type DataClient should have comment or be unexported (golint)
- Line 41: warning: exported function NewDataClient should have comment or be unexported (golint)
- Line 53: warning: exported method DataClient.Connect should have comment or be unexported (golint)
- Line 59: warning: exported method DataClient.ConnectOnce should have comment or be unexported (golint)
- Line 72: warning: exported method DataClient.Disconnect should have comment or be unexported (golint)
- Line 78: warning: exported method DataClient.DisconnectOnce should have comment or be unexported (golint)
- Line 83: warning: exported method DataClient.Start should have comment or be unexported (golint)
- Line 86: warning: exported method DataClient.Stop should have comment or be unexported (golint)
- Line 89: warning: exported method DataClient.SendChan should have comment or be unexported (golint)
- Line 93: warning: exported method DataClient.RecvChan should have comment or be unexported (golint)
- Line 97: warning: exported method DataClient.Send should have comment or be unexported (golint)
- Line 102: warning: comment on exported method DataClient.SendBytes should be of the form "SendBytes ..." (golint)
- Line 109: warning: comment on exported method DataClient.Recv should be of the form "Recv ..." (golint)
- Line 122: warning: exported method DataClient.ConnectChan should have comment or be unexported (golint)
- Line 126: warning: exported method DataClient.ErrorChan should have comment or be unexported (golint)
- Line 130: warning: exported method DataClient.Conn should have comment or be unexported (golint)
- Line 134: warning: exported method DataClient.SetConnectChan should have comment or be unexported (golint)
- Line 138: warning: exported method DataClient.Status should have comment or be unexported (golint)
-
-
qan-agent/bin/percona-qan-agent-installer/installer/installer.go
- Line 33: warning: exported type Flags should have comment or be unexported (golint)
- Line 39: warning: exported type Installer should have comment or be unexported (golint)
- Line 61: warning: exported function NewInstaller should have comment or be unexported (golint)
- Line 75: warning: exported method Installer.Run should have comment or be unexported (golint)
- Line 101: warning: exported method Installer.CreateOSInstance should have comment or be unexported (golint)
- Line 126: warning: exported method Installer.CreateAgent should have comment or be unexported (golint)
- Line 151: warning: exported method Installer.GetDefaultConfigs should have comment or be unexported (golint)
-
-
qan-agent/query/plugin/errors.go
- Line 20: warning: exported type UnknownCmdError should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/report/report.go
- Line 33: warning: comment on exported type Result should be of the form "Result ..." (with optional leading article) (golint)
- Line 44: warning: exported type ByQueryTime should have comment or be unexported (golint)
- Line 54: warning: exported function MakeReport should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/factory/iter.go
- Line 32: warning: exported type RealIntervalIterFactory should have comment or be unexported (golint)
- Line 36: warning: exported function NewRealIntervalIterFactory should have comment or be unexported (golint)
- Line 43: warning: exported method RealIntervalIterFactory.Make should have comment or be unexported (golint)
- Line 75: warning: exported function AbsDataFile should have comment or be unexported (golint)
-
-
qan-agent/mrms/monitor.go
- Line 34: warning: exported const MONITOR_NAME should have comment or be unexported (golint)
- Line 36: warning: exported type Checker should have comment or be unexported (golint)
- Line 46: warning: exported type Monitor should have comment or be unexported (golint)
- Line 56: warning: exported type RealMonitor should have comment or be unexported (golint)
- Line 67: warning: exported function NewRealMonitor should have comment or be unexported (golint)
- Line 88: warning: exported method RealMonitor.Start should have comment or be unexported (golint)
- Line 95: warning: exported method RealMonitor.Stop should have comment or be unexported (golint)
- Line 103: warning: exported method RealMonitor.Status should have comment or be unexported (golint)
- Line 107: warning: exported method RealMonitor.Add should have comment or be unexported (golint)
- Line 139: warning: exported method RealMonitor.Remove should have comment or be unexported (golint)
- Line 159: warning: exported method RealMonitor.Check should have comment or be unexported (golint)
- Line 199: warning: exported method RealMonitor.ListenerCount should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mongo/profiler/aggregator/aggregator.go
- Line 21: warning: exported const DefaultInterval should have comment (or a comment on this block) or be unexported (golint)
- Line 79: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 107: warning: exported method Aggregator.Start should have comment or be unexported (golint)
- Line 107: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 142: warning: exported method Aggregator.Stop should have comment or be unexported (golint)
- Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 160: warning: exported method Aggregator.Status should have comment or be unexported (golint)
- Line 160: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 199: warning: exported method Aggregator.Flush should have comment or be unexported (golint)
- Line 199: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 205: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 214: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 232: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 237: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 241: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 251: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
qan-agent/agent/agent.go
- Line 45: warning: exported const DEFAULT_KEEPALIVE should have comment (or a comment on this block) or be unexported (golint)
- Line 50: warning: exported const CMD_QUEUE_SIZE should have comment (or a comment on this block) or be unexported (golint)
- Line 56: warning: exported var ErrStop should have comment or be unexported (golint)
- Line 59: warning: exported type Agent should have comment or be unexported (golint)
- Line 79: warning: exported type CollectInfoData should have comment or be unexported (golint)
- Line 84: warning: exported function NewAgent should have comment or be unexported (golint)
- Line 104: warning: exported method Agent.Run should have comment or be unexported (golint)
- Line 296: warning: exported function LoadConfig should have comment or be unexported (golint)
- Line 319: warning: exported method Agent.GetConfig should have comment or be unexported (golint)
- Line 474: warning: exported method Agent.Handle should have comment or be unexported (golint)
- Line 588: warning: exported method Agent.GetAllConfigs should have comment or be unexported (golint)
- Line 608: warning: exported method Agent.GetDefaults should have comment or be unexported (golint)
- Line 856: warning: exported method Agent.Status should have comment or be unexported (golint)
- Line 860: warning: exported method Agent.AllStatus should have comment or be unexported (golint)
-
-
qan-agent/pct/service.go
- Line 24: warning: exported type ServiceManager should have comment or be unexported (golint)
-
-
qan-agent/pct/sync.go
- Line 24: warning: exported type SyncChan should have comment or be unexported (golint)
- Line 32: warning: exported function NewSyncChan should have comment or be unexported (golint)
- Line 43: warning: exported method SyncChan.Start should have comment or be unexported (golint)
- Line 53: warning: exported method SyncChan.Stop should have comment or be unexported (golint)
- Line 57: warning: exported method SyncChan.Wait should have comment or be unexported (golint)
- Line 64: warning: exported method SyncChan.Done should have comment or be unexported (golint)
- Line 72: warning: exported method SyncChan.Graceful should have comment or be unexported (golint)
- Line 76: warning: exported method SyncChan.IsGraceful should have comment or be unexported (golint)
- Line 82: warning: exported function MakeStartLock should have comment or be unexported (golint)
-
-
qan-agent/pct/sys.go
- Line 30: warning: exported function FileSize should have comment or be unexported (golint)
- Line 38: warning: exported function SameFile should have comment or be unexported (golint)
- Line 54: warning: exported function MakeDir should have comment or be unexported (golint)
- Line 62: warning: exported function RemoveFile should have comment or be unexported (golint)
- Line 73: warning: exported function FileExists should have comment or be unexported (golint)
- Line 84: warning: exported function Mbps should have comment or be unexported (golint)
- Line 95: warning: exported function Bytes should have comment or be unexported (golint)
- Line 117: warning: exported function Duration should have comment or be unexported (golint)
- Line 175: warning: exported function TimeString should have comment or be unexported (golint)
- Line 179: warning: exported function AtLeastVersion should have comment or be unexported (golint)
- Line 194: warning: exported function ToBool should have comment or be unexported (golint)
-
-
qan-agent/test/mock/mrms_monitor.go
- Line 26: warning: exported type MrmsMonitor should have comment or be unexported (golint)
- Line 31: warning: exported function NewMrmsMonitor should have comment or be unexported (golint)
- Line 36: warning: exported method MrmsMonitor.Add should have comment or be unexported (golint)
- Line 42: warning: exported method MrmsMonitor.Remove should have comment or be unexported (golint)
- Line 46: warning: exported method MrmsMonitor.Check should have comment or be unexported (golint)
- Line 49: warning: exported method MrmsMonitor.Start should have comment or be unexported (golint)
- Line 53: warning: exported method MrmsMonitor.Stop should have comment or be unexported (golint)
- Line 57: warning: exported method MrmsMonitor.Status should have comment or be unexported (golint)
- Line 63: warning: exported method MrmsMonitor.ListenerCount should have comment or be unexported (golint)
- Line 67: warning: comment on exported method MrmsMonitor.SimulateMySQLRestart should be of the form "SimulateMySQLRestart ..." (golint)
-
-
qan-agent/agent/release/release.go
- Line 20: warning: exported var VERSION should have comment or be unexported (golint)
-
-
qan-agent/mysql/factory.go
- Line 20: warning: exported type ConnectionFactory should have comment or be unexported (golint)
- Line 24: warning: exported type RealConnectionFactory should have comment or be unexported (golint)
- Line 27: warning: exported method RealConnectionFactory.Make should have comment or be unexported (golint)
-
-
qan-agent/pct/api.go
- Line 36: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 44: warning: exported type ConnectionConfig should have comment or be unexported (golint)
- Line 51: warning: exported type APIConnector should have comment or be unexported (golint)
- Line 69: warning: exported type TimeoutClientConfig should have comment or be unexported (golint)
- Line 79: warning: exported function TimeoutDialer should have comment or be unexported (golint)
- Line 92: warning: exported type API should have comment or be unexported (golint)
- Line 107: warning: exported function NewAPI should have comment or be unexported (golint)
- Line 129: warning: exported method API.GetConnectionConfig should have comment or be unexported (golint)
- Line 138: warning: exported function Ping should have comment or be unexported (golint)
- Line 166: warning: exported function URL should have comment or be unexported (golint)
- Line 188: warning: exported method API.Connect should have comment or be unexported (golint)
- Line 233: warning: exported method API.Init should have comment or be unexported (golint)
- Line 317: warning: exported method API.Get should have comment or be unexported (golint)
- Line 353: warning: exported method API.EntryLink should have comment or be unexported (golint)
- Line 359: warning: exported method API.AgentLink should have comment or be unexported (golint)
- Line 365: warning: exported method API.Origin should have comment or be unexported (golint)
- Line 370: warning: exported method API.Hostname should have comment or be unexported (golint)
- Line 376: warning: exported method API.URL should have comment or be unexported (golint)
- Line 380: warning: exported method API.AgentUuid should have comment or be unexported (golint)
- Line 386: warning: exported method API.Post should have comment or be unexported (golint)
- Line 390: warning: exported method API.Put should have comment or be unexported (golint)
- Line 414: warning: exported method API.CreateInstance should have comment or be unexported (golint)
-
-
qan-agent/data/stats.go
- Line 28: warning: exported var DebugStats should have comment or be unexported (golint)
- Line 30: warning: exported type SentInfo should have comment or be unexported (golint)
- Line 42: warning: exported type SentReport should have comment or be unexported (golint)
- Line 57: warning: exported var BaseReportFormat should have comment or be unexported (golint)
- Line 61: warning: exported type SenderStats should have comment or be unexported (golint)
- Line 70: warning: exported function NewSenderStats should have comment or be unexported (golint)
- Line 79: warning: exported method SenderStats.Sent should have comment or be unexported (golint)
- Line 128: warning: exported method SenderStats.Report should have comment or be unexported (golint)
- Line 153: warning: exported function FormatSentReport should have comment or be unexported (golint)
- Line 161: warning: exported method SenderStats.Dump should have comment or be unexported (golint)
-
-
qan-agent/test/mock/qan_worker/qan_worker.go
- Line 18: warning: don't use an underscore in package name (golint)
- Line 26: warning: exported type QanWorker should have comment or be unexported (golint)
- Line 39: warning: exported function NewQanWorker should have comment or be unexported (golint)
- Line 53: warning: exported method QanWorker.Setup should have comment or be unexported (golint)
- Line 59: warning: exported method QanWorker.Run should have comment or be unexported (golint)
- Line 64: warning: exported method QanWorker.Stop should have comment or be unexported (golint)
- Line 69: warning: exported method QanWorker.Cleanup should have comment or be unexported (golint)
- Line 74: warning: exported method QanWorker.Status should have comment or be unexported (golint)
- Line 80: warning: exported method QanWorker.SetConfig should have comment or be unexported (golint)
-
-
qan-agent/qan/analyzer/mysql/config/config.go
- Line 31: warning: exported var DefaultRemoveOldSlowLogs should have comment or be unexported (golint)
- Line 34: warning: exported type MySQLVarType should have comment or be unexported (golint)
- Line 37: warning: exported const MySQLVarTypeBoolean should have comment (or a comment on this block) or be unexported (golint)
- Line 74: warning: exported function ReadInfoFromShowGlobalStatus should have comment or be unexported (golint)
- Line 104: warning: exported function ValidateConfig should have comment or be unexported (golint)
ineffassign93%
IneffAssign detects ineffectual assignments in Go code.
-
-
qan-agent/agent/agent_test.go
- Line 673: warning: ineffectual assignment to err (ineffassign)
-
-
qan-agent/pct/cmd/cmd_test.go
- Line 70: warning: ineffectual assignment to err (ineffassign)
-
-
qan-agent/query/plugin/mysql/explain/explain_test.go
- Line 233: warning: ineffectual assignment to err (ineffassign)
- Line 1074: warning: ineffectual assignment to err (ineffassign)
-
-
qan-agent/qan/analyzer/mysql/worker/perfschema/perfschema_test.go
- Line 490: warning: ineffectual assignment to err (ineffassign)
- Line 504: warning: ineffectual assignment to err (ineffassign)
- Line 592: warning: ineffectual assignment to err (ineffassign)
- Line 606: warning: ineffectual assignment to err (ineffassign)
- Line 678: warning: ineffectual assignment to err (ineffassign)
-
-
qan-agent/mrms/monitor_test.go
- Line 109: warning: ineffectual assignment to gotInstance (ineffassign)
-
-
qan-agent/test/mock/ws_client.go
- Line 166: warning: ineffectual assignment to data (ineffassign)
-
-
qan-agent/query/plugin/mongo/mongo_test.go
- Line 89: warning: ineffectual assignment to err (ineffassign)
-
-
qan-agent/data/stats_test.go
- Line 151: warning: ineffectual assignment to got (ineffassign)
-
-
qan-agent/qan/analyzer/mysql/worker/perfschema/worker.go
- Line 408: warning: ineffectual assignment to seconds (ineffassign)
-
-
qan-agent/pct/api.go
- Line 177: warning: ineffectual assignment to relativePath (ineffassign)
- Line 396: warning: ineffectual assignment to err (ineffassign)
misspell95%
Misspell Finds commonly misspelled English words
-
-
qan-agent/qan/analyzer/mongo/profiler/collector/collector_test.go
- Line 165: warning: "recieve" is a misspelling of "receive" (misspell)
-
-
qan-agent/qan/manager_test.go
- Line 408: warning: "Feburary" is a misspelling of "February" (misspell)
-
-
qan-agent/data/sender.go
- Line 245: warning: "Recieved" is a misspelling of "Received" (misspell)
- Line 256: warning: "Recieved" is a misspelling of "Received" (misspell)
-
-
qan-agent/agent/agent.go
- Line 109: warning: "receving" is a misspelling of "receiving" (misspell)
-
-
qan-agent/agent/agent_test.go
- Line 790: warning: "recieved" is a misspelling of "received" (misspell)
- Line 810: warning: "recieved" is a misspelling of "received" (misspell)
-
-
qan-agent/qan/analyzer/mysql/worker/slowlog/slowlog_test.go
- Line 505: warning: "Feburary" is a misspelling of "February" (misspell)
-
-
qan-agent/client/client_test.go
- Line 215: warning: "Recieve" is a misspelling of "Receive" (misspell)
- Line 413: warning: "slighly" is a misspelling of "slightly" (misspell)