Preparing report...

Report for github.com/qri-io/qri

(v0.10.0)

A+    Excellent!    Found 66 issues across 479 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • p2p/dag.go
    • Line 55: warning: cyclomatic complexity 28 of function newDAGInfo() is high (> 15) (gocyclo)
    • base/dsfs/dataset_test.go
    • Line 119: warning: cyclomatic complexity 28 of function TestCreateDataset() is high (> 15) (gocyclo)
    • Line 425: warning: cyclomatic complexity 23 of function TestWriteDataset() is high (> 15) (gocyclo)
    • lib/lib.go
    • Line 318: warning: cyclomatic complexity 60 of function NewInstance() is high (> 15) (gocyclo)
    • dscache/dscache.go
    • Line 87: warning: cyclomatic complexity 20 of function (*Dscache).VerboseString() is high (> 15) (gocyclo)
    • base/save.go
    • Line 22: warning: cyclomatic complexity 20 of function SaveDataset() is high (> 15) (gocyclo)
    • cmd/get.go
    • Line 129: warning: cyclomatic complexity 19 of function (*GetOptions).Run() is high (> 15) (gocyclo)
    • cmd/ref_select_test.go
    • Line 14: warning: cyclomatic complexity 31 of function TestBasicRefSelect() is high (> 15) (gocyclo)
    • Line 116: warning: cyclomatic complexity 20 of function TestGetCurrentRefSelect() is high (> 15) (gocyclo)
    • cmd/dag.go
    • Line 210: warning: cyclomatic complexity 16 of function (*DAGOptions).Info() is high (> 15) (gocyclo)
    • lib/profile.go
    • Line 118: warning: cyclomatic complexity 16 of function (profileImpl).SetProfile() is high (> 15) (gocyclo)
    • config/profile.go
    • Line 240: warning: cyclomatic complexity 16 of function (*ProfilePod).SetField() is high (> 15) (gocyclo)
    • lib/diff.go
    • Line 162: warning: cyclomatic complexity 33 of function (diffImpl).Diff() is high (> 15) (gocyclo)
    • Line 59: warning: cyclomatic complexity 17 of function (*DiffParams).diffMode() is high (> 15) (gocyclo)
    • repo/refstore.go
    • Line 156: warning: cyclomatic complexity 27 of function canonicalizeProfile() is high (> 15) (gocyclo)
    • base/fill/path_value_test.go
    • Line 7: warning: cyclomatic complexity 43 of function TestFillPathValue() is high (> 15) (gocyclo)
    • Line 204: warning: cyclomatic complexity 17 of function TestGetPathValue() is high (> 15) (gocyclo)
    • base/dataset.go
    • Line 135: warning: cyclomatic complexity 22 of function ListDatasets() is high (> 15) (gocyclo)
    • Line 99: warning: cyclomatic complexity 18 of function CloseDataset() is high (> 15) (gocyclo)
    • Line 24: warning: cyclomatic complexity 16 of function OpenDataset() is high (> 15) (gocyclo)
    • base/body_test.go
    • Line 71: warning: cyclomatic complexity 16 of function TestConvertBodyFormat() is high (> 15) (gocyclo)
    • lib/datasets.go
    • Line 855: warning: cyclomatic complexity 47 of function (datasetImpl).Save() is high (> 15) (gocyclo)
    • Line 1123: warning: cyclomatic complexity 40 of function (datasetImpl).Remove() is high (> 15) (gocyclo)
    • Line 1369: warning: cyclomatic complexity 31 of function (datasetImpl).Validate() is high (> 15) (gocyclo)
    • Line 463: warning: cyclomatic complexity 30 of function formFileDataset() is high (> 15) (gocyclo)
    • Line 774: warning: cyclomatic complexity 16 of function (datasetImpl).Activity() is high (> 15) (gocyclo)
    • api/fsi_test.go
    • Line 74: warning: cyclomatic complexity 19 of function TestNoHistory() is high (> 15) (gocyclo)
    • Line 311: warning: cyclomatic complexity 18 of function TestCheckoutAndRestore() is high (> 15) (gocyclo)
    • lib/dispatch.go
    • Line 295: warning: cyclomatic complexity 33 of function (*Instance).registerOne() is high (> 15) (gocyclo)
    • Line 85: warning: cyclomatic complexity 26 of function (*Instance).dispatchMethodCall() is high (> 15) (gocyclo)
    • dsref/generate.go
    • Line 62: warning: cyclomatic complexity 58 of function convertWordsStateMachine() is high (> 15) (gocyclo)
    • sql/preprocess/preprocess.go
    • Line 290: warning: cyclomatic complexity 19 of function (*processor).scan() is high (> 15) (gocyclo)
    • Line 492: warning: cyclomatic complexity 17 of function (tokenType).String() is high (> 15) (gocyclo)
    • lib/http.go
    • Line 102: warning: cyclomatic complexity 20 of function (HTTPClient).do() is high (> 15) (gocyclo)
    • changes/changes.go
    • Line 388: warning: cyclomatic complexity 65 of function (*service).Report() is high (> 15) (gocyclo)
    • Line 298: warning: cyclomatic complexity 38 of function (*service).columnStatsDelta() is high (> 15) (gocyclo)
    • lib/collection.go
    • Line 60: warning: cyclomatic complexity 27 of function (collectionImpl).List() is high (> 15) (gocyclo)
    • cmd/print.go
    • Line 241: warning: cyclomatic complexity 19 of function PrintProgressBarsOnEvents() is high (> 15) (gocyclo)
    • lib/file.go
    • Line 55: warning: cyclomatic complexity 18 of function readSingleFile() is high (> 15) (gocyclo)
    • fsi/init.go
    • Line 41: warning: cyclomatic complexity 31 of function (*FSI).InitDataset() is high (> 15) (gocyclo)
    • base/fill/struct.go
    • Line 116: warning: cyclomatic complexity 30 of function putValueToPlace() is high (> 15) (gocyclo)
    • Line 275: warning: cyclomatic complexity 21 of function putValueToUnit() is high (> 15) (gocyclo)
    • remote/remote_test.go
    • Line 31: warning: cyclomatic complexity 17 of function TestDatasetPullPushDeleteFeedsPreviewHTTP() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!