Go Report Card

Preparing report...

Report for github.com/sabey/patrol

A    Great!    Found 42 issues across 50 files

Tweet
Last refresh:

Refresh now

gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo72%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • patrol/app_api.go
    • Line 7: warning: cyclomatic complexity 17 of function (*App).apiRequest() is high (> 15) (gocyclo)
    • patrol/app.go
    • Line 299: warning: cyclomatic complexity 34 of function (*App).startApp() is high (> 15) (gocyclo)
    • Line 550: warning: cyclomatic complexity 16 of function (*App).isAppRunning() is high (> 15) (gocyclo)
    • patrol/config.go
    • Line 180: warning: cyclomatic complexity 30 of function (*Config).Validate() is high (> 15) (gocyclo)

golint20%

Golint is a linter for Go source code.

    • patrol/patrol_tick.go
    • Line 11: warning: error var ERR_PATROL_ALREADYRUNNING should have name of the form ErrFoo (golint)
    • Line 11: warning: exported var ERR_PATROL_ALREADYRUNNING should have comment or be unexported (golint)
    • Line 12: warning: error var ERR_PATROL_NOTRUNNING should have name of the form ErrFoo (golint)
    • Line 13: warning: error var ERR_PATROL_SHUTDOWN should have name of the form ErrFoo (golint)
    • Line 16: warning: exported method Patrol.Start should have comment or be unexported (golint)
    • Line 16: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 30: warning: exported method Patrol.Stop should have comment or be unexported (golint)
    • Line 30: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/cas/cas.go
    • Line 9: warning: don't use underscores in Go names; const cas_init_max_range should be casInitMaxRange (golint)
    • patrol/patrol_services.go
    • Line 8: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 23: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 38: warning: don't use underscores in Go names; var is_running_err should be isRunningErr (golint)
    • Line 39: warning: don't use underscores in Go names; var is_running should be isRunning (golint)
    • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • patrol/file.go
    • Line 10: warning: error var ERR_PATH_INVALID should have name of the form ErrFoo (golint)
    • Line 10: warning: exported var ERR_PATH_INVALID should have comment or be unexported (golint)
    • Line 11: warning: error var ERR_DIRECTORY should have name of the form ErrFoo (golint)
    • Line 14: warning: exported function OpenFile should have comment or be unexported (golint)
    • patrol/patrol.go
    • Line 12: warning: exported const TICKEVERY_MIN should have comment (or a comment on this block) or be unexported (golint)
    • Line 21: warning: exported const PATROL_ENV_UNITTEST_KEY should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported function CreatePatrol should have comment or be unexported (golint)
    • Line 92: warning: exported type Patrol should have comment or be unexported (golint)
    • Line 95: warning: don't use underscores in Go names; struct field instance_id should be instanceID (golint)
    • Line 102: warning: don't use underscores in Go names; struct field ticker_running should be tickerRunning (golint)
    • Line 103: warning: don't use underscores in Go names; struct field ticker_stop should be tickerStop (golint)
    • Line 107: warning: exported method Patrol.IsValid should have comment or be unexported (golint)
    • Line 107: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 113: warning: exported method Patrol.GetInstanceID should have comment or be unexported (golint)
    • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 116: warning: exported method Patrol.IsRunning should have comment or be unexported (golint)
    • Line 116: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 121: warning: exported method Patrol.GetStarted should have comment or be unexported (golint)
    • Line 121: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 126: warning: exported method Patrol.GetConfig should have comment or be unexported (golint)
    • Line 126: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 129: warning: exported method Patrol.GetApps should have comment or be unexported (golint)
    • Line 129: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 137: warning: exported method Patrol.GetApp should have comment or be unexported (golint)
    • Line 137: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 142: warning: exported method Patrol.GetServices should have comment or be unexported (golint)
    • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 150: warning: exported method Patrol.GetService should have comment or be unexported (golint)
    • Line 150: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 155: warning: exported method Patrol.Shutdown should have comment or be unexported (golint)
    • Line 155: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 166: warning: exported method Patrol.IsShutdown should have comment or be unexported (golint)
    • Line 166: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_api.go
    • Line 8: warning: don't use underscores in Go names; const api_endpoint_none should be apiEndpointNone (golint)
    • Line 9: warning: don't use underscores in Go names; const api_endpoint_http should be apiEndpointHTTP (golint)
    • Line 10: warning: don't use underscores in Go names; const api_endpoint_udp should be apiEndpointUDP (golint)
    • Line 11: warning: don't use underscores in Go names; const api_endpoint_status should be apiEndpointStatus (golint)
    • Line 12: warning: don't use underscores in Go names; const api_endpoint_snapshot should be apiEndpointSnapshot (golint)
    • Line 15: warning: exported method Patrol.API should have comment or be unexported (golint)
    • Line 15: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_server_test.go
    • Line 39: warning: don't use underscores in Go names; var cmd_app should be cmdApp (golint)
    • Line 61: warning: don't use underscores in Go names; var cmd_server should be cmdServer (golint)
    • Line 180: warning: don't use underscores in Go names; var cmd_app should be cmdApp (golint)
    • Line 202: warning: don't use underscores in Go names; var cmd_server should be cmdServer (golint)
    • Line 321: warning: don't use underscores in Go names; var cmd_app should be cmdApp (golint)
    • Line 343: warning: don't use underscores in Go names; var cmd_server should be cmdServer (golint)
    • Line 462: warning: don't use underscores in Go names; var cmd_server should be cmdServer (golint)
    • patrol/http/index.go
    • Line 27: warning: exported function Index should have comment or be unexported (golint)
    • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 85: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 157: warning: exported type Data should have comment or be unexported (golint)
    • Line 164: warning: exported type StatusPost should have comment or be unexported (golint)
    • patrol/patrol/main.go
    • Line 15: warning: don't use underscores in Go names; var config_path should be configPath (golint)
    • Line 19: warning: don't use underscores in Go names; var shutdown_c should be shutdownC (golint)
    • Line 20: warning: don't use underscores in Go names; var shutdown_is should be shutdownIs (golint)
    • Line 21: warning: don't use underscores in Go names; var shutdown_mu should be shutdownMu (golint)
    • patrol/app_exec_test.go
    • Line 725: warning: don't use underscores in Go names; var udp_done should be udpDone (golint)
    • Line 726: warning: don't use underscores in Go names; var udp_mu should be udpMu (golint)
    • patrol/cas/service.go
    • Line 10: warning: exported type Service should have comment or be unexported (golint)
    • Line 25: warning: don't use underscores in Go names; struct field run_once should be runOnce (golint)
    • Line 26: warning: don't use underscores in Go names; struct field run_once_consumed should be runOnceConsumed (golint)
    • Line 45: warning: don't use underscores in Go names; struct field locked_read should be lockedRead (golint)
    • Line 46: warning: don't use underscores in Go names; struct field locked_write should be lockedWrite (golint)
    • Line 48: warning: don't use underscores in Go names; struct field mu_internal should be muInternal (golint)
    • Line 49: warning: don't use underscores in Go names; struct field mu_external should be muExternal (golint)
    • Line 52: warning: exported function CreateService should have comment or be unexported (golint)
    • Line 62: warning: exported method Service.IsValid should have comment or be unexported (golint)
    • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 68: warning: exported method Service.Lock should have comment or be unexported (golint)
    • Line 68: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 76: warning: exported method Service.Unlock should have comment or be unexported (golint)
    • Line 76: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 84: warning: exported method Service.RLock should have comment or be unexported (golint)
    • Line 84: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 90: warning: exported method Service.RUnlock should have comment or be unexported (golint)
    • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: exported method Service.Increment should have comment or be unexported (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 112: warning: exported method Service.GetCAS should have comment or be unexported (golint)
    • Line 112: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 120: warning: exported method Service.GetKeyValue should have comment or be unexported (golint)
    • Line 120: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 133: warning: exported method Service.SetKeyValue should have comment or be unexported (golint)
    • Line 133: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 149: warning: exported method Service.ReplaceKeyValue should have comment or be unexported (golint)
    • Line 149: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 166: warning: exported method Service.GetStarted should have comment or be unexported (golint)
    • Line 166: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 174: warning: exported method Service.SetStarted should have comment or be unexported (golint)
    • Line 174: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 190: warning: exported method Service.GetLastSeen should have comment or be unexported (golint)
    • Line 190: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 198: warning: exported method Service.SetLastSeen should have comment or be unexported (golint)
    • Line 198: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 214: warning: exported method Service.IsDisabled should have comment or be unexported (golint)
    • Line 214: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 222: warning: exported method Service.SetDisabled should have comment or be unexported (golint)
    • Line 222: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 238: warning: exported method Service.IsRestart should have comment or be unexported (golint)
    • Line 238: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 246: warning: exported method Service.SetRestart should have comment or be unexported (golint)
    • Line 246: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 262: warning: exported method Service.IsRunOnce should have comment or be unexported (golint)
    • Line 262: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 270: warning: exported method Service.SetRunOnce should have comment or be unexported (golint)
    • Line 270: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 271: warning: don't use underscores in Go names; method parameter run_once should be runOnce (golint)
    • Line 286: warning: exported method Service.IsRunOnceConsumed should have comment or be unexported (golint)
    • Line 286: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 294: warning: exported method Service.SetRunOnceConsumed should have comment or be unexported (golint)
    • Line 294: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 295: warning: don't use underscores in Go names; method parameter run_once_consumed should be runOnceConsumed (golint)
    • patrol/api_status.go
    • Line 3: warning: don't use underscores in Go names; type API_Status should be APIStatus (golint)
    • Line 3: warning: exported type API_Status should have comment or be unexported (golint)
    • Line 14: warning: exported method Patrol.GetStatus should have comment or be unexported (golint)
    • Line 14: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/app_api.go
    • Line 7: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 15: warning: don't use underscores in Go names; var cas_valid should be casValid (golint)
    • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 159: warning: exported method App.Snapshot should have comment or be unexported (golint)
    • Line 159: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/config_api.go
    • Line 7: warning: exported type ConfigHTTP should have comment or be unexported (golint)
    • Line 14: warning: exported method ConfigHTTP.IsValid should have comment or be unexported (golint)
    • Line 14: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 20: warning: exported method ConfigHTTP.Clone should have comment or be unexported (golint)
    • Line 20: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 31: warning: exported type ConfigUDP should have comment or be unexported (golint)
    • Line 37: warning: exported method ConfigUDP.IsValid should have comment or be unexported (golint)
    • Line 37: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 43: warning: exported method ConfigUDP.Clone should have comment or be unexported (golint)
    • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_http_status.go
    • Line 8: warning: exported method Patrol.ServeHTTPStatus should have comment or be unexported (golint)
    • Line 8: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/http/std.go
    • Line 10: warning: exported function STDOut should have comment or be unexported (golint)
    • Line 17: warning: exported function STDErr should have comment or be unexported (golint)
    • patrol/unittest/testapp/main.go
    • Line 23: warning: don't use underscores in Go names; var unittesting_server should be unittestingServer (golint)
    • Line 57: warning: don't use underscores in Go names; var ping_read should be pingRead (golint)
    • Line 58: warning: don't use underscores in Go names; var ping_done should be pingDone (golint)
    • Line 59: warning: don't use underscores in Go names; var ping_mu should be pingMu (golint)
    • patrol/funcs.go
    • Line 7: warning: exported function IsAppServiceID should have comment or be unexported (golint)
    • Line 35: warning: exported function IsPathClean should have comment or be unexported (golint)
    • patrol/history.go
    • Line 3: warning: exported type History should have comment or be unexported (golint)
    • Line 17: warning: exported method History.IsValid should have comment or be unexported (golint)
    • Line 17: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 23: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/app.go
    • Line 21: warning: comment on exported const APP_NAME_MAXLENGTH should be of the form "APP_NAME_MAXLENGTH ..." (golint)
    • Line 23: warning: comment on exported const APP_PING_TIMEOUT_MIN should be of the form "APP_PING_TIMEOUT_MIN ..." (golint)
    • Line 25: warning: exported const APP_PING_TIMEOUT_DEFAULT should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: comment on exported const APP_ENV_APP_ID should be of the form "APP_ENV_APP_ID ..." (golint)
    • Line 65: warning: error var ERR_APP_PING_EXPIRED should have name of the form ErrFoo (golint)
    • Line 65: warning: exported var ERR_APP_PING_EXPIRED should have comment or be unexported (golint)
    • Line 66: warning: error var ERR_APP_KEEPALIVE_PATROL_NOTRUNNING should have name of the form ErrFoo (golint)
    • Line 67: warning: error var ERR_APP_PIDFILE_NOTFOUND should have name of the form ErrFoo (golint)
    • Line 68: warning: error var ERR_APP_PIDFILE_INVALID should have name of the form ErrFoo (golint)
    • Line 71: warning: exported type App should have comment or be unexported (golint)
    • Line 78: warning: don't use underscores in Go names; struct field instance_id should be instanceID (golint)
    • Line 85: warning: exported method App.IsValid should have comment or be unexported (golint)
    • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 91: warning: exported method App.GetID should have comment or be unexported (golint)
    • Line 91: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 94: warning: exported method App.GetInstanceID should have comment or be unexported (golint)
    • Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 99: warning: exported method App.GetPatrol should have comment or be unexported (golint)
    • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: exported method App.GetConfig should have comment or be unexported (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 105: warning: exported method App.GetCAS should have comment or be unexported (golint)
    • Line 105: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 110: warning: exported method App.IsRunning should have comment or be unexported (golint)
    • Line 110: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 115: warning: exported method App.GetStarted should have comment or be unexported (golint)
    • Line 115: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 120: warning: exported method App.GetStartedLog should have comment or be unexported (golint)
    • Line 120: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 125: warning: exported method App.GetLastSeen should have comment or be unexported (golint)
    • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 137: warning: exported method App.IsDisabled should have comment or be unexported (golint)
    • Line 137: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 142: warning: exported method App.IsRestart should have comment or be unexported (golint)
    • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 147: warning: exported method App.IsRunOnce should have comment or be unexported (golint)
    • Line 147: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 152: warning: exported method App.IsRunOnceConsumed should have comment or be unexported (golint)
    • Line 152: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 157: warning: exported method App.Toggle should have comment or be unexported (golint)
    • Line 157: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 164: warning: exported method App.Enable should have comment or be unexported (golint)
    • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 169: warning: exported method App.Disable should have comment or be unexported (golint)
    • Line 169: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 174: warning: exported method App.Restart should have comment or be unexported (golint)
    • Line 174: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 179: warning: exported method App.EnableRunOnce should have comment or be unexported (golint)
    • Line 179: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 184: warning: exported method App.DisableRunOnce should have comment or be unexported (golint)
    • Line 184: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 189: warning: exported method App.GetKeyValue should have comment or be unexported (golint)
    • Line 189: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 194: warning: exported method App.SetKeyValue should have comment or be unexported (golint)
    • Line 194: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 201: warning: exported method App.ReplaceKeyValue should have comment or be unexported (golint)
    • Line 201: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 208: warning: exported method App.GetHistory should have comment or be unexported (golint)
    • Line 208: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 213: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 221: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 299: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 369: warning: don't use underscores in Go names; var std_merge should be stdMerge (golint)
    • Line 525: warning: don't use underscores in Go names; var exit_code should be exitCode (golint)
    • Line 550: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 658: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 671: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 687: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 714: warning: exported method App.GetPID should have comment or be unexported (golint)
    • Line 714: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 720: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 728: warning: don't use underscores in Go names; func parameter started_log should be startedLog (golint)
    • Line 744: warning: exported method App.GetStdoutLog should have comment or be unexported (golint)
    • Line 744: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 765: warning: exported method App.GetStderrLog should have comment or be unexported (golint)
    • Line 765: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 786: warning: exported method App.IsSTDMerged should have comment or be unexported (golint)
    • Line 786: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/config.go
    • Line 11: warning: exported const SECRET_MAX_LENGTH should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: error var ERR_CONFIG_NIL should have name of the form ErrFoo (golint)
    • Line 15: warning: exported var ERR_CONFIG_NIL should have comment or be unexported (golint)
    • Line 16: warning: error var ERR_PATROL_EMPTY should have name of the form ErrFoo (golint)
    • Line 17: warning: error var ERR_APPS_KEY_EMPTY should have name of the form ErrFoo (golint)
    • Line 18: warning: error var ERR_APPS_KEY_INVALID should have name of the form ErrFoo (golint)
    • Line 19: warning: error var ERR_APPS_APP_NIL should have name of the form ErrFoo (golint)
    • Line 20: warning: error var ERR_SERVICES_KEY_EMPTY should have name of the form ErrFoo (golint)
    • Line 21: warning: error var ERR_SERVICES_KEY_INVALID should have name of the form ErrFoo (golint)
    • Line 22: warning: error var ERR_SERVICES_SERVICE_NIL should have name of the form ErrFoo (golint)
    • Line 23: warning: error var ERR_APP_LABEL_DUPLICATE should have name of the form ErrFoo (golint)
    • Line 24: warning: error var ERR_SERVICE_LABEL_DUPLICATE should have name of the form ErrFoo (golint)
    • Line 25: warning: error var ERR_LISTEN_HTTP_EMPTY should have name of the form ErrFoo (golint)
    • Line 26: warning: error var ERR_LISTEN_UDP_EMPTY should have name of the form ErrFoo (golint)
    • Line 27: warning: error var ERR_SECRET_TOOLONG should have name of the form ErrFoo (golint)
    • Line 30: warning: exported function LoadConfig should have comment or be unexported (golint)
    • Line 61: warning: exported type Config should have comment or be unexported (golint)
    • Line 138: warning: exported method Config.IsValid should have comment or be unexported (golint)
    • Line 138: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 144: warning: exported method Config.Clone should have comment or be unexported (golint)
    • Line 144: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 180: warning: exported method Config.Validate should have comment or be unexported (golint)
    • Line 180: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/config_service.go
    • Line 9: warning: error var ERR_SERVICE_EMPTY should have name of the form ErrFoo (golint)
    • Line 9: warning: exported var ERR_SERVICE_EMPTY should have comment or be unexported (golint)
    • Line 10: warning: error var ERR_SERVICE_MAXLENGTH should have name of the form ErrFoo (golint)
    • Line 11: warning: error var ERR_SERVICE_NAME_EMPTY should have name of the form ErrFoo (golint)
    • Line 12: warning: error var ERR_SERVICE_NAME_MAXLENGTH should have name of the form ErrFoo (golint)
    • Line 13: warning: error var ERR_SERVICE_MANAGEMENT_INVALID should have name of the form ErrFoo (golint)
    • Line 14: warning: error var ERR_SERVICE_MANAGEMENT_START_INVALID should have name of the form ErrFoo (golint)
    • Line 15: warning: error var ERR_SERVICE_MANAGEMENT_STATUS_INVALID should have name of the form ErrFoo (golint)
    • Line 16: warning: error var ERR_SERVICE_MANAGEMENT_STOP_INVALID should have name of the form ErrFoo (golint)
    • Line 17: warning: error var ERR_SERVICE_MANAGEMENT_RESTART_INVALID should have name of the form ErrFoo (golint)
    • Line 18: warning: error var ERR_SERVICE_INVALID_EXITCODE should have name of the form ErrFoo (golint)
    • Line 19: warning: error var ERR_SERVICE_DUPLICATE_EXITCODE should have name of the form ErrFoo (golint)
    • Line 22: warning: exported type ConfigService should have comment or be unexported (golint)
    • Line 108: warning: exported method ConfigService.IsValid should have comment or be unexported (golint)
    • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 114: warning: exported method ConfigService.Clone should have comment or be unexported (golint)
    • Line 114: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 164: warning: exported method ConfigService.Validate should have comment or be unexported (golint)
    • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 275: warning: exported method ConfigService.GetManagementStart should have comment or be unexported (golint)
    • Line 275: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 281: warning: exported method ConfigService.GetManagementStatus should have comment or be unexported (golint)
    • Line 281: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 287: warning: exported method ConfigService.GetManagementStop should have comment or be unexported (golint)
    • Line 287: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 293: warning: exported method ConfigService.GetManagementRestart should have comment or be unexported (golint)
    • Line 293: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 299: warning: exported method ConfigService.GetManagementStartParameter should have comment or be unexported (golint)
    • Line 299: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 305: warning: exported method ConfigService.GetManagementStatusParameter should have comment or be unexported (golint)
    • Line 305: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 311: warning: exported method ConfigService.GetManagementStopParameter should have comment or be unexported (golint)
    • Line 311: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 317: warning: exported method ConfigService.GetManagementRestartParameter should have comment or be unexported (golint)
    • Line 317: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_http_api.go
    • Line 10: warning: exported method Patrol.ServeHTTPAPI should have comment or be unexported (golint)
    • Line 10: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_udp.go
    • Line 8: warning: exported method Patrol.HandleUDPConnection should have comment or be unexported (golint)
    • Line 8: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/service.go
    • Line 13: warning: comment on exported const SERVICE_NAME_MAXLENGTH should be of the form "SERVICE_NAME_MAXLENGTH ..." (golint)
    • Line 15: warning: comment on exported const SERVICE_MAXLENGTH should be of the form "SERVICE_MAXLENGTH ..." (golint)
    • Line 20: warning: comment on exported const SERVICE_MANAGEMENT_SERVICE should be of the form "SERVICE_MANAGEMENT_SERVICE ..." (golint)
    • Line 23: warning: comment on exported const SERVICE_MANAGEMENT_INITD should be of the form "SERVICE_MANAGEMENT_INITD ..." (golint)
    • Line 28: warning: exported type Service should have comment or be unexported (golint)
    • Line 35: warning: don't use underscores in Go names; struct field instance_id should be instanceID (golint)
    • Line 42: warning: exported method Service.IsValid should have comment or be unexported (golint)
    • Line 42: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 48: warning: exported method Service.GetID should have comment or be unexported (golint)
    • Line 48: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 51: warning: exported method Service.GetInstanceID should have comment or be unexported (golint)
    • Line 51: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 56: warning: exported method Service.GetPatrol should have comment or be unexported (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 59: warning: exported method Service.GetConfig should have comment or be unexported (golint)
    • Line 59: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 62: warning: exported method Service.GetCAS should have comment or be unexported (golint)
    • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 67: warning: exported method Service.IsRunning should have comment or be unexported (golint)
    • Line 67: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 72: warning: exported method Service.GetStarted should have comment or be unexported (golint)
    • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 77: warning: exported method Service.GetLastSeen should have comment or be unexported (golint)
    • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 82: warning: exported method Service.IsDisabled should have comment or be unexported (golint)
    • Line 82: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 87: warning: exported method Service.IsRestart should have comment or be unexported (golint)
    • Line 87: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 92: warning: exported method Service.IsRunOnce should have comment or be unexported (golint)
    • Line 92: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 97: warning: exported method Service.IsRunOnceConsumed should have comment or be unexported (golint)
    • Line 97: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: exported method Service.Toggle should have comment or be unexported (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 109: warning: exported method Service.Enable should have comment or be unexported (golint)
    • Line 109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 114: warning: exported method Service.Disable should have comment or be unexported (golint)
    • Line 114: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 119: warning: exported method Service.Restart should have comment or be unexported (golint)
    • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 124: warning: exported method Service.EnableRunOnce should have comment or be unexported (golint)
    • Line 124: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 129: warning: exported method Service.DisableRunOnce should have comment or be unexported (golint)
    • Line 129: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 134: warning: exported method Service.GetKeyValue should have comment or be unexported (golint)
    • Line 134: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 139: warning: exported method Service.SetKeyValue should have comment or be unexported (golint)
    • Line 139: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 146: warning: exported method Service.ReplaceKeyValue should have comment or be unexported (golint)
    • Line 146: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 153: warning: exported method Service.GetHistory should have comment or be unexported (golint)
    • Line 153: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 158: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 166: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 221: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 248: warning: don't use underscores in Go names; var exit_code should be exitCode (golint)
    • Line 270: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 290: warning: don't use underscores in Go names; var exit_code should be exitCode (golint)
    • Line 325: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 345: warning: don't use underscores in Go names; var exit_code should be exitCode (golint)
    • Line 366: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 386: warning: don't use underscores in Go names; var exit_code should be exitCode (golint)
    • patrol/service_api.go
    • Line 3: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 8: warning: don't use underscores in Go names; var cas_valid should be casValid (golint)
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 70: warning: exported method Service.Snapshot should have comment or be unexported (golint)
    • Line 70: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/unittest/testserver/main.go
    • Line 17: warning: don't use underscores in Go names; var config_path should be configPath (golint)
    • Line 21: warning: don't use underscores in Go names; var shutdown_c should be shutdownC (golint)
    • Line 22: warning: don't use underscores in Go names; var shutdown_is should be shutdownIs (golint)
    • Line 23: warning: don't use underscores in Go names; var shutdown_mu should be shutdownMu (golint)
    • patrol/cas/app.go
    • Line 10: warning: exported type App should have comment or be unexported (golint)
    • Line 17: warning: don't use underscores in Go names; struct field started_log should be startedLog (golint)
    • Line 26: warning: don't use underscores in Go names; struct field run_once should be runOnce (golint)
    • Line 27: warning: don't use underscores in Go names; struct field run_once_consumed should be runOnceConsumed (golint)
    • Line 36: warning: don't use underscores in Go names; struct field exit_code should be exitCode (golint)
    • Line 55: warning: don't use underscores in Go names; struct field locked_read should be lockedRead (golint)
    • Line 56: warning: don't use underscores in Go names; struct field locked_write should be lockedWrite (golint)
    • Line 58: warning: don't use underscores in Go names; struct field mu_internal should be muInternal (golint)
    • Line 59: warning: don't use underscores in Go names; struct field mu_external should be muExternal (golint)
    • Line 62: warning: exported function CreateApp should have comment or be unexported (golint)
    • Line 72: warning: exported method App.IsValid should have comment or be unexported (golint)
    • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 78: warning: exported method App.Lock should have comment or be unexported (golint)
    • Line 78: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 86: warning: exported method App.Unlock should have comment or be unexported (golint)
    • Line 86: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 94: warning: exported method App.RLock should have comment or be unexported (golint)
    • Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 100: warning: exported method App.RUnlock should have comment or be unexported (golint)
    • Line 100: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 106: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 112: warning: exported method App.Increment should have comment or be unexported (golint)
    • Line 112: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 122: warning: exported method App.GetCAS should have comment or be unexported (golint)
    • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 130: warning: exported method App.GetKeyValue should have comment or be unexported (golint)
    • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 143: warning: exported method App.SetKeyValue should have comment or be unexported (golint)
    • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 159: warning: exported method App.ReplaceKeyValue should have comment or be unexported (golint)
    • Line 159: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 176: warning: exported method App.GetStarted should have comment or be unexported (golint)
    • Line 176: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 184: warning: exported method App.SetStarted should have comment or be unexported (golint)
    • Line 184: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 200: warning: exported method App.GetStartedLog should have comment or be unexported (golint)
    • Line 200: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 208: warning: exported method App.SetStartedLog should have comment or be unexported (golint)
    • Line 208: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 209: warning: don't use underscores in Go names; method parameter started_log should be startedLog (golint)
    • Line 224: warning: exported method App.GetLastSeen should have comment or be unexported (golint)
    • Line 224: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 232: warning: exported method App.SetLastSeen should have comment or be unexported (golint)
    • Line 232: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 248: warning: exported method App.IsDisabled should have comment or be unexported (golint)
    • Line 248: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 256: warning: exported method App.SetDisabled should have comment or be unexported (golint)
    • Line 256: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 272: warning: exported method App.IsRestart should have comment or be unexported (golint)
    • Line 272: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 280: warning: exported method App.SetRestart should have comment or be unexported (golint)
    • Line 280: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 296: warning: exported method App.IsRunOnce should have comment or be unexported (golint)
    • Line 296: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 304: warning: exported method App.SetRunOnce should have comment or be unexported (golint)
    • Line 304: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 305: warning: don't use underscores in Go names; method parameter run_once should be runOnce (golint)
    • Line 320: warning: exported method App.IsRunOnceConsumed should have comment or be unexported (golint)
    • Line 320: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 328: warning: exported method App.SetRunOnceConsumed should have comment or be unexported (golint)
    • Line 328: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 329: warning: don't use underscores in Go names; method parameter run_once_consumed should be runOnceConsumed (golint)
    • Line 344: warning: exported method App.GetPID should have comment or be unexported (golint)
    • Line 344: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 352: warning: exported method App.SetPID should have comment or be unexported (golint)
    • Line 352: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 368: warning: exported method App.GetExitCode should have comment or be unexported (golint)
    • Line 368: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 376: warning: exported method App.SetExitCode should have comment or be unexported (golint)
    • Line 376: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 377: warning: don't use underscores in Go names; method parameter exit_code should be exitCode (golint)
    • patrol/cas/app_test.go
    • Line 181: warning: don't use underscores in Go names; var i_mu should be iMu (golint)
    • Line 464: warning: don't use underscores in Go names; var i_mu should be iMu (golint)
    • patrol/timestamp.go
    • Line 9: warning: exported type Timestamp should have comment or be unexported (golint)
    • Line 14: warning: exported method Timestamp.UnmarshalJSON should have comment or be unexported (golint)
    • Line 14: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 36: warning: exported method Timestamp.MarshalJSON should have comment or be unexported (golint)
    • Line 36: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/config_app.go
    • Line 14: warning: error var ERR_APP_NAME_EMPTY should have name of the form ErrFoo (golint)
    • Line 14: warning: exported var ERR_APP_NAME_EMPTY should have comment or be unexported (golint)
    • Line 15: warning: error var ERR_APP_NAME_MAXLENGTH should have name of the form ErrFoo (golint)
    • Line 16: warning: error var ERR_APP_WORKINGDIRECTORY_EMPTY should have name of the form ErrFoo (golint)
    • Line 17: warning: error var ERR_APP_WORKINGDIRECTORY_RELATIVE should have name of the form ErrFoo (golint)
    • Line 18: warning: error var ERR_APP_WORKINGDIRECTORY_UNCLEAN should have name of the form ErrFoo (golint)
    • Line 19: warning: error var ERR_APP_BINARY_EMPTY should have name of the form ErrFoo (golint)
    • Line 20: warning: error var ERR_APP_BINARY_UNCLEAN should have name of the form ErrFoo (golint)
    • Line 21: warning: error var ERR_APP_LOGDIRECTORY_EMPTY should have name of the form ErrFoo (golint)
    • Line 22: warning: error var ERR_APP_LOGDIRECTORY_UNCLEAN should have name of the form ErrFoo (golint)
    • Line 23: warning: error var ERR_APP_KEEPALIVE_INVALID should have name of the form ErrFoo (golint)
    • Line 24: warning: error var ERR_APP_PIDPATH_EMPTY should have name of the form ErrFoo (golint)
    • Line 25: warning: error var ERR_APP_PIDPATH_UNCLEAN should have name of the form ErrFoo (golint)
    • Line 26: warning: error var ERR_APP_EXECUTETIMEOUT_INVALID should have name of the form ErrFoo (golint)
    • Line 29: warning: exported type ConfigApp should have comment or be unexported (golint)
    • Line 194: warning: exported method ConfigApp.IsValid should have comment or be unexported (golint)
    • Line 194: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 200: warning: exported method ConfigApp.Clone should have comment or be unexported (golint)
    • Line 200: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 267: warning: exported method ConfigApp.Validate should have comment or be unexported (golint)
    • Line 267: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • patrol/patrol_apps.go
    • Line 9: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 37: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 46: warning: don't use underscores in Go names; var can_start_pingable should be canStartPingable (golint)
    • Line 58: warning: don't use underscores in Go names; var is_running_err should be isRunningErr (golint)
    • Line 59: warning: don't use underscores in Go names; var is_running should be isRunning (golint)
    • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • patrol/api.go
    • Line 8: warning: exported const API_TOGGLE_STATE_ENABLE should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported const LISTEN_HTTP_PORT_DEFAULT should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: comment on exported type API_Request should be of the form "API_Request ..." (with optional leading article) (golint)
    • Line 25: warning: don't use underscores in Go names; type API_Request should be APIRequest (golint)
    • Line 72: warning: exported method API_Request.IsValid should have comment or be unexported (golint)
    • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 79: warning: comment on exported type API_Response should be of the form "API_Response ..." (with optional leading article) (golint)
    • Line 85: warning: don't use underscores in Go names; type API_Response should be APIResponse (golint)
    • Line 138: warning: don't use underscores in Go names; type api_response should be apiResponse (golint)
    • Line 158: warning: exported method API_Response.IsValid should have comment or be unexported (golint)
    • Line 158: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 164: warning: exported method API_Response.UnmarshalJSON should have comment or be unexported (golint)
    • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 207: warning: exported method API_Response.NewAPITimestamp should have comment or be unexported (golint)
    • Line 207: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 213: warning: exported method API_Response.NewAPIHistory should have comment or be unexported (golint)
    • Line 213: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 224: warning: comment on exported method Patrol.NewAPIResponse should be of the form "NewAPIResponse ..." (golint)
    • Line 225: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 230: warning: exported method Patrol.NewAPIHistory should have comment or be unexported (golint)
    • Line 230: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 237: warning: exported method Patrol.NewAPITimestamp should have comment or be unexported (golint)
    • Line 237: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign84%

IneffAssign detects ineffectual assignments in Go code.

    • patrol/api_test.go
    • Line 6: warning: cannot find package "." in: (ineffassign)
    • Line 6: warning: could not import sabey.co/unittest (invalid package name: "") (ineffassign)
    • patrol/cas/app_test.go
    • Line 5: warning: cannot find package "." in: (ineffassign)
    • Line 5: warning: could not import sabey.co/unittest (invalid package name: "") (ineffassign)
    • patrol/http/index.go
    • Line 10: warning: cannot find package "." in: (ineffassign)
    • Line 10: warning: could not import sabey.co/patrol (invalid package name: "") (ineffassign)
    • patrol/patrol/http.go
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: could not import sabey.co/patrol (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import sabey.co/patrol/http (invalid package name: "") (ineffassign)
    • patrol/app.go
    • Line 13: warning: cannot find package "." in: (ineffassign)
    • Line 13: warning: could not import sabey.co/patrol/cas (invalid package name: "") (ineffassign)
    • Line 13: warning: could not import sabey.co/patrol/cas (invalid package name: "") (ineffassign)

misspell96%

Misspell Finds commonly misspelled English words