Preparing report...

Report for github.com/sorenmat/k8s-rds

A    Great!    Found 11 issues across 15 files

Tweet

gofmt86%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint33%

Golint is a linter for Go source code.

    • k8s-rds/local/local_service.go
    • Line 61: warning: exported method Local.DeleteService should have comment or be unexported (golint)
    • Line 75: warning: exported method Local.GetSecret should have comment or be unexported (golint)
    • k8s-rds/kube/client.go
    • Line 12: warning: exported function Client should have comment or be unexported (golint)
    • Line 44: warning: exported function Config should have comment or be unexported (golint)
    • k8s-rds/kube/service.go
    • Line 15: warning: exported type Kube should have comment or be unexported (golint)
    • Line 61: warning: exported method Kube.DeleteService should have comment or be unexported (golint)
    • Line 71: warning: exported method Kube.GetSecret should have comment or be unexported (golint)
    • k8s-rds/client/client.go
    • Line 18: warning: exported function CrdClient should have comment or be unexported (golint)
    • Line 23: warning: exported type Crdclient should have comment or be unexported (golint)
    • Line 30: warning: exported method Crdclient.Create should have comment or be unexported (golint)
    • Line 38: warning: exported method Crdclient.Update should have comment or be unexported (golint)
    • Line 48: warning: exported method Crdclient.Delete should have comment or be unexported (golint)
    • Line 55: warning: exported method Crdclient.Get should have comment or be unexported (golint)
    • Line 63: warning: exported method Crdclient.List should have comment or be unexported (golint)
    • Line 72: warning: comment on exported method Crdclient.NewListWatch should be of the form "NewListWatch ..." (golint)
    • k8s-rds/rds/rds_provider.go
    • Line 24: warning: exported type RDS should have comment or be unexported (golint)
    • Line 33: warning: exported function New should have comment or be unexported (golint)
    • Line 160: warning: exported method RDS.DeleteDatabase should have comment or be unexported (golint)
    • Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • k8s-rds/rds/service.go
    • Line 61: warning: exported method RDS.DeleteService should have comment or be unexported (golint)
    • Line 75: warning: exported method RDS.GetSecret should have comment or be unexported (golint)
    • k8s-rds/local/local_provider.go
    • Line 20: warning: exported type Local should have comment or be unexported (golint)
    • Line 27: warning: exported function New should have comment or be unexported (golint)
    • Line 80: warning: var iterationWaitPeriodSec is of type time.Duration; don't use unit-specific suffix "Sec" (golint)
    • k8s-rds/crd/crd.go
    • Line 17: warning: exported const CRDPlural should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported function NewDatabaseCRD should have comment or be unexported (golint)
    • Line 177: warning: exported type DatabaseStatus should have comment or be unexported (golint)
    • Line 182: warning: exported type DatabaseList should have comment or be unexported (golint)
    • Line 188: warning: exported method Database.DeepCopyObject should have comment or be unexported (golint)
    • Line 192: warning: exported method DatabaseList.DeepCopyObject should have comment or be unexported (golint)
    • Line 196: warning: exported var SchemeGroupVersion should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!