Report for github.com/travisjeffery/jocko
A+ Excellent! Found 92 issues across 128 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
jocko/protocol/create_topic_requests_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
jocko/jocko/leader.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
jocko/jocko/fsm/fsm.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
jocko/jocko/fsm/fsm_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint31%
Golint is a linter for Go source code.
-
-
jocko/protocol/create_topic_requests.go
- Line 5: warning: exported type CreateTopicRequest should have comment or be unexported (golint)
- Line 13: warning: exported type CreateTopicRequests should have comment or be unexported (golint)
- Line 21: warning: exported method CreateTopicRequests.Encode should have comment or be unexported (golint)
- Line 59: warning: exported method CreateTopicRequests.Decode should have comment or be unexported (golint)
- Line 138: warning: exported method CreateTopicRequests.Key should have comment or be unexported (golint)
- Line 142: warning: exported method CreateTopicRequests.Version should have comment or be unexported (golint)
-
-
jocko/protocol/fetch_response.go
- Line 5: warning: exported type AbortedTransaction should have comment or be unexported (golint)
- Line 10: warning: exported method AbortedTransaction.Decode should have comment or be unexported (golint)
- Line 20: warning: exported method AbortedTransaction.Encode should have comment or be unexported (golint)
- Line 26: warning: exported type FetchPartitionResponse should have comment or be unexported (golint)
- Line 35: warning: exported method FetchPartitionResponse.Decode should have comment or be unexported (golint)
- Line 73: warning: exported method FetchPartitionResponse.Encode should have comment or be unexported (golint)
- Line 96: warning: exported type FetchTopicResponse should have comment or be unexported (golint)
- Line 101: warning: exported type FetchPartitionResponses should have comment or be unexported (golint)
- Line 103: warning: exported type FetchResponse should have comment or be unexported (golint)
- Line 110: warning: exported type FetchTopicResponses should have comment or be unexported (golint)
- Line 112: warning: exported method FetchResponse.Encode should have comment or be unexported (golint)
- Line 136: warning: exported method FetchResponse.Decode should have comment or be unexported (golint)
- Line 177: warning: exported method FetchResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/produce_response.go
- Line 5: warning: exported type ProducePartitionResponse should have comment or be unexported (golint)
- Line 13: warning: exported type ProduceTopicResponse should have comment or be unexported (golint)
- Line 18: warning: exported type ProduceResponse should have comment or be unexported (golint)
- Line 25: warning: exported method ProduceResponse.Encode should have comment or be unexported (golint)
- Line 54: warning: exported type ProduceTopicResponses should have comment or be unexported (golint)
- Line 56: warning: exported type ProducePartitionResponses should have comment or be unexported (golint)
- Line 58: warning: exported method ProduceResponse.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/stop_replica_request.go
- Line 3: warning: exported type StopReplicaPartition should have comment or be unexported (golint)
- Line 8: warning: exported type StopReplicaRequest should have comment or be unexported (golint)
- Line 16: warning: exported method StopReplicaRequest.Encode should have comment or be unexported (golint)
- Line 36: warning: exported method StopReplicaRequest.Decode should have comment or be unexported (golint)
- Line 65: warning: exported method StopReplicaRequest.Key should have comment or be unexported (golint)
- Line 69: warning: exported method StopReplicaRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/sync_group_request.go
- Line 3: warning: exported type GroupAssignment should have comment or be unexported (golint)
- Line 8: warning: exported type SyncGroupRequest should have comment or be unexported (golint)
- Line 17: warning: exported method SyncGroupRequest.Encode should have comment or be unexported (golint)
- Line 39: warning: exported method SyncGroupRequest.Decode should have comment or be unexported (golint)
- Line 69: warning: exported method SyncGroupRequest.Key should have comment or be unexported (golint)
- Line 73: warning: exported method SyncGroupRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/update_metadata_request.go
- Line 3: warning: exported type UpdateMetadataRequest should have comment or be unexported (golint)
- Line 7: warning: exported method UpdateMetadataRequest.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method UpdateMetadataRequest.Decode should have comment or be unexported (golint)
- Line 15: warning: exported method UpdateMetadataRequest.Key should have comment or be unexported (golint)
- Line 19: warning: exported method UpdateMetadataRequest.Version should have comment or be unexported (golint)
-
-
jocko/jocko/config/config.go
- Line 12: warning: exported const DefaultLANSerfPort should have comment (or a comment on this block) or be unexported (golint)
-
-
jocko/protocol/crc_field.go
- Line 8: warning: exported type CRCField should have comment or be unexported (golint)
- Line 12: warning: exported method CRCField.SaveOffset should have comment or be unexported (golint)
- Line 16: warning: exported method CRCField.ReserveSize should have comment or be unexported (golint)
- Line 20: warning: exported method CRCField.Fill should have comment or be unexported (golint)
- Line 26: warning: exported method CRCField.Check should have comment or be unexported (golint)
-
-
jocko/protocol/message.go
- Line 5: warning: exported type Message should have comment or be unexported (golint)
- Line 14: warning: exported method Message.Encode should have comment or be unexported (golint)
- Line 31: warning: exported method Message.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/error.go
- Line 6: warning: exported var ErrUnknown should have comment or be unexported (golint)
- Line 134: warning: exported method Error.Code should have comment or be unexported (golint)
- Line 149: warning: exported method Error.WithErr should have comment or be unexported (golint)
-
-
jocko/protocol/find_coordinator_request.go
- Line 5: warning: exported type CoordinatorType should have comment or be unexported (golint)
- Line 8: warning: exported const CoordinatorGroup should have comment (or a comment on this block) or be unexported (golint)
- Line 12: warning: exported type FindCoordinatorRequest should have comment or be unexported (golint)
- Line 19: warning: exported method FindCoordinatorRequest.Encode should have comment or be unexported (golint)
- Line 29: warning: exported method FindCoordinatorRequest.Decode should have comment or be unexported (golint)
- Line 45: warning: exported method FindCoordinatorRequest.Key should have comment or be unexported (golint)
- Line 49: warning: exported method FindCoordinatorRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/leave_group_request.go
- Line 3: warning: exported type LeaveGroupRequest should have comment or be unexported (golint)
- Line 10: warning: exported method LeaveGroupRequest.Encode should have comment or be unexported (golint)
- Line 17: warning: exported method LeaveGroupRequest.Decode should have comment or be unexported (golint)
- Line 26: warning: exported method LeaveGroupRequest.Key should have comment or be unexported (golint)
- Line 30: warning: exported method LeaveGroupRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/offset_commit_response.go
- Line 5: warning: exported type OffsetCommitResponse should have comment or be unexported (golint)
- Line 12: warning: exported type OffsetCommitTopicResponse should have comment or be unexported (golint)
- Line 17: warning: exported type OffsetCommitPartitionResponse should have comment or be unexported (golint)
- Line 22: warning: exported method OffsetCommitResponse.Encode should have comment or be unexported (golint)
- Line 44: warning: exported method OffsetCommitResponse.Decode should have comment or be unexported (golint)
-
-
jocko/jocko/server.go
- Line 35: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
- Line 58: warning: exported function NewServer should have comment or be unexported (golint)
- Line 125: warning: exported method Server.Leave should have comment or be unexported (golint)
- Line 296: warning: exported method Server.ID should have comment or be unexported (golint)
-
-
jocko/jocko/state/store.go
- Line 23: warning: exported type Store should have comment or be unexported (golint)
- Line 32: warning: exported function NewStore should have comment or be unexported (golint)
-
-
jocko/jocko/structs/topic_config.go
- Line 3: warning: exported type TopicConfig should have comment or be unexported (golint)
- Line 5: warning: exported function NewTopicConfig should have comment or be unexported (golint)
- Line 200: warning: exported method TopicConfig.Set should have comment or be unexported (golint)
- Line 204: warning: exported method TopicConfig.Get should have comment or be unexported (golint)
- Line 208: warning: exported method TopicConfig.GetValue should have comment or be unexported (golint)
- Line 219: warning: exported method TopicConfig.SetValue should have comment or be unexported (golint)
- Line 229: warning: exported type ConfigEntry should have comment or be unexported (golint)
- Line 236: warning: exported type TopicConfigEntry should have comment or be unexported (golint)
-
-
jocko/protocol/leader_and_isr_response.go
- Line 3: warning: exported type LeaderAndISRPartition should have comment or be unexported (golint)
- Line 9: warning: exported type LeaderAndISRResponse should have comment or be unexported (golint)
- Line 16: warning: exported method LeaderAndISRResponse.Encode should have comment or be unexported (golint)
- Line 32: warning: exported method LeaderAndISRResponse.Decode should have comment or be unexported (golint)
- Line 59: warning: exported method LeaderAndISRResponse.Key should have comment or be unexported (golint)
- Line 63: warning: exported method LeaderAndISRResponse.Version should have comment or be unexported (golint)
- Line 67: warning: exported type LeaderAndISRPartitions should have comment or be unexported (golint)
-
-
jocko/protocol/leave_group_response.go
- Line 5: warning: exported type LeaveGroupResponse should have comment or be unexported (golint)
- Line 12: warning: exported method LeaveGroupResponse.Encode should have comment or be unexported (golint)
- Line 20: warning: exported method LeaveGroupResponse.Decode should have comment or be unexported (golint)
- Line 33: warning: exported method LeaveGroupResponse.Key should have comment or be unexported (golint)
- Line 37: warning: exported method LeaveGroupResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/sasl_handshake_request.go
- Line 3: warning: exported type SaslHandshakeRequest should have comment or be unexported (golint)
- Line 7: warning: exported method SaslHandshakeRequest.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method SaslHandshakeRequest.Decode should have comment or be unexported (golint)
- Line 15: warning: exported method SaslHandshakeRequest.Key should have comment or be unexported (golint)
- Line 19: warning: exported method SaslHandshakeRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/stop_replica_response.go
- Line 3: warning: exported type StopReplicaResponsePartition should have comment or be unexported (golint)
- Line 9: warning: exported type StopReplicaResponse should have comment or be unexported (golint)
- Line 14: warning: exported method StopReplicaResponse.Encode should have comment or be unexported (golint)
- Line 29: warning: exported method StopReplicaResponse.Decode should have comment or be unexported (golint)
-
-
jocko/jocko/structs/structs.go
- Line 9: warning: exported type MessageType should have comment or be unexported (golint)
- Line 12: warning: exported const RegisterNodeRequestType should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported type CheckID should have comment or be unexported (golint)
- Line 24: warning: exported const SerfCheckID should have comment (or a comment on this block) or be unexported (golint)
- Line 34: warning: exported const HealthPassing should have comment (or a comment on this block) or be unexported (golint)
- Line 40: warning: exported type RegisterGroupRequest should have comment or be unexported (golint)
- Line 44: warning: exported type RegisterNodeRequest should have comment or be unexported (golint)
- Line 48: warning: exported type DeregisterNodeRequest should have comment or be unexported (golint)
- Line 52: warning: exported type RegisterTopicRequest should have comment or be unexported (golint)
- Line 56: warning: exported type DeregisterTopicRequest should have comment or be unexported (golint)
- Line 60: warning: exported type RegisterPartitionRequest should have comment or be unexported (golint)
- Line 64: warning: exported type DeregisterPartitionRequest should have comment or be unexported (golint)
- Line 84: warning: exported type RaftIndex should have comment or be unexported (golint)
- Line 119: warning: comment on exported type Topic should be of the form "Topic ..." (with optional leading article) (golint)
- Line 135: warning: comment on exported type Partition should be of the form "Partition ..." (with optional leading article) (golint)
- Line 156: warning: comment on exported type Member should be of the form "Member ..." (with optional leading article) (golint)
- Line 163: warning: exported type GroupState should have comment or be unexported (golint)
- Line 166: warning: exported const GroupStatePreparingRebalance should have comment (or a comment on this block) or be unexported (golint)
- Line 173: warning: comment on exported type Group should be of the form "Group ..." (with optional leading article) (golint)
-
-
jocko/jocko/fsm/index.go
- Line 15: warning: exported method IntFieldIndex.FromObject should have comment or be unexported (golint)
- Line 40: warning: exported method IntFieldIndex.FromArgs should have comment or be unexported (golint)
-
-
jocko/protocol/offset_commit_request.go
- Line 3: warning: exported type OffsetCommitRequest should have comment or be unexported (golint)
- Line 13: warning: exported type OffsetCommitTopicRequest should have comment or be unexported (golint)
- Line 18: warning: exported type OffsetCommitPartitionRequest should have comment or be unexported (golint)
- Line 25: warning: exported method OffsetCommitRequest.Encode should have comment or be unexported (golint)
- Line 47: warning: exported method OffsetCommitRequest.Decode should have comment or be unexported (golint)
- Line 97: warning: exported method OffsetCommitRequest.Version should have comment or be unexported (golint)
- Line 101: warning: exported method OffsetCommitRequest.Key should have comment or be unexported (golint)
-
-
jocko/jocko/context.go
- Line 13: warning: exported type Context should have comment or be unexported (golint)
- Line 24: warning: exported method Context.Request should have comment or be unexported (golint)
- Line 28: warning: exported method Context.Response should have comment or be unexported (golint)
- Line 32: warning: exported method Context.Header should have comment or be unexported (golint)
- Line 32: warning: receiver name c should be consistent with previous receiver name ctx for Context (golint)
- Line 36: warning: exported method Context.Deadline should have comment or be unexported (golint)
- Line 40: warning: exported method Context.Done should have comment or be unexported (golint)
- Line 44: warning: exported method Context.Err should have comment or be unexported (golint)
- Line 52: warning: exported method Context.Value should have comment or be unexported (golint)
-
-
jocko/jocko/testing.go
- Line 25: warning: exported function NewTestServer should have comment or be unexported (golint)
- Line 96: warning: exported function TestJoin should have comment or be unexported (golint)
-
-
jocko/jocko/util/util.go
- Line 9: warning: exported function Dump should have comment or be unexported (golint)
- Line 14: warning: exported function Hash should have comment or be unexported (golint)
-
-
jocko/commitlog/compact_cleaner.go
- Line 7: warning: exported type CompactCleaner should have comment or be unexported (golint)
- Line 12: warning: exported function NewCompactCleaner should have comment or be unexported (golint)
- Line 18: warning: exported method CompactCleaner.Clean should have comment or be unexported (golint)
- Line 74: warning: exported function Hash should have comment or be unexported (golint)
-
-
jocko/commitlog/delete_cleaner.go
- Line 3: warning: exported type Cleaner should have comment or be unexported (golint)
- Line 10: warning: exported type DeleteCleaner should have comment or be unexported (golint)
- Line 16: warning: exported function NewDeleteCleaner should have comment or be unexported (golint)
- Line 22: warning: exported method DeleteCleaner.Clean should have comment or be unexported (golint)
-
-
jocko/protocol/controlled_shutdown_response.go
- Line 3: warning: exported type ControlledShutdownResponse should have comment or be unexported (golint)
- Line 7: warning: exported method ControlledShutdownResponse.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method ControlledShutdownResponse.Decode should have comment or be unexported (golint)
- Line 17: warning: exported method ControlledShutdownResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/encoder.go
- Line 7: warning: exported type PacketEncoder should have comment or be unexported (golint)
- Line 25: warning: exported type PushEncoder should have comment or be unexported (golint)
- Line 31: warning: exported type Encoder should have comment or be unexported (golint)
- Line 35: warning: exported function Encode should have comment or be unexported (golint)
- Line 52: warning: exported type LenEncoder should have comment or be unexported (golint)
- Line 57: warning: exported method LenEncoder.PutBool should have comment or be unexported (golint)
- Line 61: warning: exported method LenEncoder.PutInt8 should have comment or be unexported (golint)
- Line 65: warning: exported method LenEncoder.PutInt16 should have comment or be unexported (golint)
- Line 69: warning: exported method LenEncoder.PutInt32 should have comment or be unexported (golint)
- Line 73: warning: exported method LenEncoder.PutInt64 should have comment or be unexported (golint)
- Line 77: warning: exported method LenEncoder.PutArrayLength should have comment or be unexported (golint)
- Line 87: warning: exported method LenEncoder.PutBytes should have comment or be unexported (golint)
- Line 95: warning: exported method LenEncoder.PutRawBytes should have comment or be unexported (golint)
- Line 103: warning: exported method LenEncoder.PutString should have comment or be unexported (golint)
- Line 112: warning: exported method LenEncoder.PutNullableString should have comment or be unexported (golint)
- Line 120: warning: exported method LenEncoder.PutStringArray should have comment or be unexported (golint)
- Line 135: warning: exported method LenEncoder.PutInt32Array should have comment or be unexported (golint)
- Line 144: warning: exported method LenEncoder.PutInt64Array should have comment or be unexported (golint)
- Line 153: warning: exported method LenEncoder.Push should have comment or be unexported (golint)
- Line 157: warning: exported method LenEncoder.Pop should have comment or be unexported (golint)
- Line 159: warning: exported type ByteEncoder should have comment or be unexported (golint)
- Line 165: warning: exported method ByteEncoder.Bytes should have comment or be unexported (golint)
- Line 169: warning: exported function NewByteEncoder should have comment or be unexported (golint)
- Line 173: warning: exported method ByteEncoder.PutBool should have comment or be unexported (golint)
- Line 173: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 180: warning: exported method ByteEncoder.PutInt8 should have comment or be unexported (golint)
- Line 180: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 185: warning: exported method ByteEncoder.PutInt16 should have comment or be unexported (golint)
- Line 185: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 190: warning: exported method ByteEncoder.PutInt32 should have comment or be unexported (golint)
- Line 190: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 195: warning: exported method ByteEncoder.PutInt64 should have comment or be unexported (golint)
- Line 195: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 200: warning: exported method ByteEncoder.PutArrayLength should have comment or be unexported (golint)
- Line 200: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 205: warning: exported method ByteEncoder.PutRawBytes should have comment or be unexported (golint)
- Line 205: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 211: warning: exported method ByteEncoder.PutBytes should have comment or be unexported (golint)
- Line 211: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 220: warning: exported method ByteEncoder.PutString should have comment or be unexported (golint)
- Line 220: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 227: warning: exported method ByteEncoder.PutNullableString should have comment or be unexported (golint)
- Line 227: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 235: warning: exported method ByteEncoder.PutStringArray should have comment or be unexported (golint)
- Line 235: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 250: warning: exported method ByteEncoder.PutInt32Array should have comment or be unexported (golint)
- Line 250: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 261: warning: exported method ByteEncoder.PutInt64Array should have comment or be unexported (golint)
- Line 261: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 272: warning: exported method ByteEncoder.Push should have comment or be unexported (golint)
- Line 272: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
- Line 278: warning: exported method ByteEncoder.Pop should have comment or be unexported (golint)
- Line 278: warning: receiver name e should be consistent with previous receiver name b for ByteEncoder (golint)
-
-
jocko/protocol/leader_and_isr_request.go
- Line 3: warning: exported type PartitionState should have comment or be unexported (golint)
- Line 15: warning: exported type LiveLeader should have comment or be unexported (golint)
- Line 21: warning: exported type LeaderAndISRRequest should have comment or be unexported (golint)
- Line 30: warning: exported method LeaderAndISRRequest.Encode should have comment or be unexported (golint)
- Line 69: warning: exported method LeaderAndISRRequest.Decode should have comment or be unexported (golint)
- Line 132: warning: exported method LeaderAndISRRequest.Key should have comment or be unexported (golint)
- Line 136: warning: exported method LeaderAndISRRequest.Version should have comment or be unexported (golint)
- Line 140: warning: exported type LiveLeaders should have comment or be unexported (golint)
- Line 142: warning: exported type PartitionStates should have comment or be unexported (golint)
- Line 144: warning: exported type Int32s should have comment or be unexported (golint)
-
-
jocko/protocol/offsets_response.go
- Line 5: warning: exported type PartitionResponse should have comment or be unexported (golint)
- Line 13: warning: exported type OffsetResponse should have comment or be unexported (golint)
- Line 18: warning: exported type OffsetsResponse should have comment or be unexported (golint)
- Line 25: warning: exported method OffsetsResponse.Encode should have comment or be unexported (golint)
- Line 56: warning: exported method OffsetsResponse.Decode should have comment or be unexported (golint)
- Line 117: warning: exported method OffsetsResponse.Version should have comment or be unexported (golint)
-
-
jocko/testutil/wait.go
- Line 11: warning: exported function WaitForResult should have comment or be unexported (golint)
-
-
jocko/commitlog/message.go
- Line 3: warning: exported type Message should have comment or be unexported (golint)
- Line 5: warning: exported function NewMessage should have comment or be unexported (golint)
- Line 9: warning: exported method Message.Crc should have comment or be unexported (golint)
- Line 13: warning: exported method Message.MagicByte should have comment or be unexported (golint)
- Line 17: warning: exported method Message.Attributes should have comment or be unexported (golint)
- Line 21: warning: exported method Message.Timestamp should have comment or be unexported (golint)
- Line 28: warning: exported method Message.Key should have comment or be unexported (golint)
- Line 36: warning: exported method Message.Value should have comment or be unexported (golint)
- Line 44: warning: exported method Message.Size should have comment or be unexported (golint)
-
-
jocko/jocko/fsm/fsm.go
- Line 42: warning: exported type NodeID should have comment or be unexported (golint)
- Line 43: warning: exported type Tracer should have comment or be unexported (golint)
- Line 92: warning: exported method FSM.Apply should have comment or be unexported (golint)
- Line 101: warning: exported method FSM.Restore should have comment or be unexported (golint)
- Line 148: warning: exported method FSM.Snapshot should have comment or be unexported (golint)
- Line 165: warning: exported type Store should have comment or be unexported (golint)
- Line 175: warning: exported function NewStore should have comment or be unexported (golint)
- Line 240: warning: exported method Store.GetNodes should have comment or be unexported (golint)
- Line 317: warning: exported method Store.EnsureRegistration should have comment or be unexported (golint)
- Line 379: warning: exported method Store.EnsureTopic should have comment or be unexported (golint)
- Line 451: warning: exported method Store.GetTopics should have comment or be unexported (golint)
- Line 503: warning: exported method Store.EnsureGroup should have comment or be unexported (golint)
- Line 570: warning: exported method Store.GetGroups should have comment or be unexported (golint)
- Line 651: warning: exported method Store.EnsurePartition should have comment or be unexported (golint)
- Line 738: warning: exported method Store.GetPartitions should have comment or be unexported (golint)
- Line 801: warning: exported method Store.Restore should have comment or be unexported (golint)
- Line 829: warning: exported method Store.Snapshot should have comment or be unexported (golint)
-
-
jocko/protocol/alter_configs_response.go
- Line 5: warning: exported type AlterConfigsResponse should have comment or be unexported (golint)
- Line 12: warning: exported type AlterConfigResourceResponse should have comment or be unexported (golint)
- Line 19: warning: exported method AlterConfigsResponse.Encode should have comment or be unexported (golint)
- Line 35: warning: exported method AlterConfigsResponse.Decode should have comment or be unexported (golint)
- Line 66: warning: exported method AlterConfigsResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/delete_topic_request.go
- Line 5: warning: exported type DeleteTopicsRequest should have comment or be unexported (golint)
- Line 12: warning: exported method DeleteTopicsRequest.Encode should have comment or be unexported (golint)
- Line 20: warning: exported method DeleteTopicsRequest.Decode should have comment or be unexported (golint)
- Line 34: warning: exported method DeleteTopicsRequest.Key should have comment or be unexported (golint)
- Line 38: warning: exported method DeleteTopicsRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/describe_configs_request.go
- Line 5: warning: exported type DescribeConfigsRequest should have comment or be unexported (golint)
- Line 12: warning: exported type DescribeConfigsResource should have comment or be unexported (golint)
- Line 18: warning: exported method DescribeConfigsRequest.Encode should have comment or be unexported (golint)
- Line 37: warning: exported method DescribeConfigsRequest.Decode should have comment or be unexported (golint)
- Line 65: warning: exported method DescribeConfigsRequest.Key should have comment or be unexported (golint)
- Line 69: warning: exported method DescribeConfigsRequest.Version should have comment or be unexported (golint)
-
-
jocko/mock/proxy.go
- Line 22: warning: exported method Client.Messages should have comment or be unexported (golint)
- Line 26: warning: exported method Client.Fetch should have comment or be unexported (golint)
- Line 47: warning: exported method Client.CreateTopics should have comment or be unexported (golint)
- Line 51: warning: exported method Client.LeaderAndISR should have comment or be unexported (golint)
-
-
jocko/protocol/delete_topic_response.go
- Line 5: warning: exported type DeleteTopicsResponse should have comment or be unexported (golint)
- Line 12: warning: exported method DeleteTopicsResponse.Encode should have comment or be unexported (golint)
- Line 24: warning: exported method DeleteTopicsResponse.Decode should have comment or be unexported (golint)
- Line 55: warning: exported method DeleteTopicsResponse.Version should have comment or be unexported (golint)
- Line 55: warning: receiver name r should be consistent with previous receiver name c for DeleteTopicsResponse (golint)
-
-
jocko/protocol/describe_groups_request.go
- Line 3: warning: exported type DescribeGroupsRequest should have comment or be unexported (golint)
- Line 9: warning: exported method DescribeGroupsRequest.Encode should have comment or be unexported (golint)
- Line 13: warning: exported method DescribeGroupsRequest.Decode should have comment or be unexported (golint)
- Line 19: warning: exported method DescribeGroupsRequest.Key should have comment or be unexported (golint)
- Line 23: warning: exported method DescribeGroupsRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/fetch_request.go
- Line 5: warning: exported type IsolationLevel should have comment or be unexported (golint)
- Line 8: warning: exported const ReadUncommitted should have comment (or a comment on this block) or be unexported (golint)
- Line 12: warning: exported type FetchPartition should have comment or be unexported (golint)
- Line 18: warning: exported type FetchTopic should have comment or be unexported (golint)
- Line 23: warning: exported type FetchRequest should have comment or be unexported (golint)
- Line 34: warning: exported method FetchRequest.Encode should have comment or be unexported (golint)
- Line 67: warning: exported method FetchRequest.Decode should have comment or be unexported (golint)
- Line 134: warning: exported method FetchRequest.Key should have comment or be unexported (golint)
- Line 138: warning: exported method FetchRequest.Version should have comment or be unexported (golint)
- Line 142: warning: exported type FetchPartitions should have comment or be unexported (golint)
- Line 144: warning: exported type FetchTopics should have comment or be unexported (golint)
-
-
jocko/protocol/request.go
- Line 3: warning: exported type Body should have comment or be unexported (golint)
- Line 9: warning: exported type Request should have comment or be unexported (golint)
- Line 15: warning: exported method Request.Encode should have comment or be unexported (golint)
-
-
jocko/commitlog/reader.go
- Line 10: warning: exported type Reader should have comment or be unexported (golint)
- Line 47: warning: exported method CommitLog.NewReader should have comment or be unexported (golint)
-
-
jocko/protocol/api_versions_response.go
- Line 5: warning: exported type APIVersionsResponse should have comment or be unexported (golint)
- Line 13: warning: exported type APIVersion should have comment or be unexported (golint)
- Line 19: warning: exported method APIVersionsResponse.Encode should have comment or be unexported (golint)
- Line 36: warning: exported method APIVersionsResponse.Decode should have comment or be unexported (golint)
- Line 75: warning: exported method APIVersionsResponse.Version should have comment or be unexported (golint)
- Line 75: warning: receiver name r should be consistent with previous receiver name c for APIVersionsResponse (golint)
-
-
jocko/protocol/list_groups_response.go
- Line 5: warning: exported type ListGroup should have comment or be unexported (golint)
- Line 10: warning: exported type ListGroupsResponse should have comment or be unexported (golint)
- Line 18: warning: exported method ListGroupsResponse.Encode should have comment or be unexported (golint)
- Line 37: warning: exported method ListGroupsResponse.Decode should have comment or be unexported (golint)
- Line 68: warning: exported method ListGroupsResponse.Key should have comment or be unexported (golint)
- Line 72: warning: exported method ListGroupsResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/offset_fetch_request.go
- Line 5: warning: exported type OffsetFetchRequest should have comment or be unexported (golint)
- Line 12: warning: exported type OffsetFetchTopicRequest should have comment or be unexported (golint)
- Line 17: warning: exported method OffsetFetchRequest.Encode should have comment or be unexported (golint)
- Line 35: warning: exported method OffsetFetchRequest.Decode should have comment or be unexported (golint)
- Line 59: warning: exported method OffsetFetchRequest.Key should have comment or be unexported (golint)
- Line 63: warning: exported method OffsetFetchRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/produce_request.go
- Line 5: warning: exported type Data should have comment or be unexported (golint)
- Line 10: warning: exported type TopicData should have comment or be unexported (golint)
- Line 15: warning: exported type ProduceRequest should have comment or be unexported (golint)
- Line 24: warning: exported method ProduceRequest.Encode should have comment or be unexported (golint)
- Line 52: warning: exported method ProduceRequest.Decode should have comment or be unexported (golint)
- Line 103: warning: exported method ProduceRequest.Key should have comment or be unexported (golint)
- Line 107: warning: exported method ProduceRequest.Version should have comment or be unexported (golint)
- Line 111: warning: exported type TopicDatas should have comment or be unexported (golint)
- Line 113: warning: exported type Datas should have comment or be unexported (golint)
-
-
jocko/commitlog/index.go
- Line 16: warning: exported var ErrIndexCorrupt should have comment or be unexported (golint)
- Line 29: warning: exported type Index should have comment or be unexported (golint)
- Line 37: warning: exported type Entry should have comment or be unexported (golint)
- Line 66: warning: exported function NewIndex should have comment or be unexported (golint)
- Line 97: warning: exported method Index.WriteEntry should have comment or be unexported (golint)
- Line 136: warning: exported method Index.ReadAt should have comment or be unexported (golint)
- Line 150: warning: exported method Index.WriteAt should have comment or be unexported (golint)
- Line 156: warning: exported method Index.Sync should have comment or be unexported (golint)
- Line 168: warning: exported method Index.Close should have comment or be unexported (golint)
- Line 178: warning: exported method Index.Name should have comment or be unexported (golint)
- Line 182: warning: exported method Index.TruncateEntries should have comment or be unexported (golint)
- Line 192: warning: exported method Index.SanityCheck should have comment or be unexported (golint)
- Line 212: warning: exported type IndexScanner should have comment or be unexported (golint)
- Line 218: warning: exported function NewIndexScanner should have comment or be unexported (golint)
- Line 222: warning: exported method IndexScanner.Scan should have comment or be unexported (golint)
-
-
jocko/commitlog/message_set.go
- Line 9: warning: exported type MessageSet should have comment or be unexported (golint)
- Line 11: warning: exported function NewMessageSet should have comment or be unexported (golint)
- Line 23: warning: exported method MessageSet.Offset should have comment or be unexported (golint)
- Line 27: warning: exported method MessageSet.PutOffset should have comment or be unexported (golint)
- Line 31: warning: exported method MessageSet.Size should have comment or be unexported (golint)
- Line 35: warning: exported method MessageSet.Payload should have comment or be unexported (golint)
- Line 39: warning: exported method MessageSet.Messages should have comment or be unexported (golint)
-
-
jocko/protocol/create_topics_response.go
- Line 5: warning: exported type TopicErrorCode should have comment or be unexported (golint)
- Line 11: warning: exported type CreateTopicsResponse should have comment or be unexported (golint)
- Line 18: warning: exported method CreateTopicsResponse.Encode should have comment or be unexported (golint)
- Line 39: warning: exported method CreateTopicsResponse.Decode should have comment or be unexported (golint)
- Line 80: warning: exported method CreateTopicsResponse.Version should have comment or be unexported (golint)
- Line 80: warning: receiver name r should be consistent with previous receiver name c for CreateTopicsResponse (golint)
-
-
jocko/protocol/size_field.go
- Line 5: warning: exported type SizeField should have comment or be unexported (golint)
- Line 9: warning: exported method SizeField.SaveOffset should have comment or be unexported (golint)
- Line 13: warning: exported method SizeField.ReserveSize should have comment or be unexported (golint)
- Line 17: warning: exported method SizeField.Fill should have comment or be unexported (golint)
- Line 22: warning: exported method SizeField.Check should have comment or be unexported (golint)
-
-
jocko/jocko/commitlog.go
- Line 5: warning: exported type CommitLog should have comment or be unexported (golint)
-
-
jocko/jocko/metrics.go
- Line 5: warning: comment on exported type Counter should be of the form "Counter ..." (with optional leading article) (golint)
-
-
jocko/testutil/testutil.go
- Line 16: warning: exported function TestConfig should have comment or be unexported (golint)
-
-
jocko/protocol/describe_configs_response.go
- Line 5: warning: exported type DescribeConfigsResponse should have comment or be unexported (golint)
- Line 12: warning: exported type DescribeConfigsResourceResponse should have comment or be unexported (golint)
- Line 20: warning: exported type DescribeConfigsEntry should have comment or be unexported (golint)
- Line 29: warning: exported type DescribeConfigsSynonym should have comment or be unexported (golint)
- Line 35: warning: exported method DescribeConfigsResponse.Encode should have comment or be unexported (golint)
- Line 81: warning: exported method DescribeConfigsResponse.Decode should have comment or be unexported (golint)
- Line 159: warning: exported method DescribeConfigsResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/heartbeat_response.go
- Line 5: warning: exported type HeartbeatResponse should have comment or be unexported (golint)
- Line 12: warning: exported method HeartbeatResponse.Encode should have comment or be unexported (golint)
- Line 17: warning: exported method HeartbeatResponse.Decode should have comment or be unexported (golint)
- Line 31: warning: exported method HeartbeatResponse.Key should have comment or be unexported (golint)
- Line 35: warning: exported method HeartbeatResponse.Version should have comment or be unexported (golint)
-
-
jocko/jocko/dialer.go
- Line 63: warning: exported function DialContext should have comment or be unexported (golint)
- Line 72: warning: exported method Dialer.DialContext should have comment or be unexported (golint)
- Line 183: warning: exported type SASL should have comment or be unexported (golint)
-
-
jocko/jocko/metadata/metadata.go
- Line 11: warning: exported type NodeID should have comment or be unexported (golint)
- Line 13: warning: exported method NodeID.Int32 should have comment or be unexported (golint)
- Line 21: warning: exported type Broker should have comment or be unexported (golint)
- Line 33: warning: exported method Broker.Host should have comment or be unexported (golint)
- Line 41: warning: exported method Broker.Port should have comment or be unexported (golint)
-
-
jocko/protocol/decoder.go
- Line 8: warning: exported var ErrInsufficientData should have comment or be unexported (golint)
- Line 9: warning: exported var ErrInvalidStringLength should have comment or be unexported (golint)
- Line 10: warning: exported var ErrInvalidArrayLength should have comment or be unexported (golint)
- Line 11: warning: exported var ErrInvalidByteSliceLength should have comment or be unexported (golint)
- Line 13: warning: exported type PacketDecoder should have comment or be unexported (golint)
- Line 31: warning: exported type Decoder should have comment or be unexported (golint)
- Line 35: warning: exported type VersionedDecoder should have comment or be unexported (golint)
- Line 39: warning: exported type PushDecoder should have comment or be unexported (golint)
- Line 46: warning: exported function Decode should have comment or be unexported (golint)
- Line 51: warning: exported type ByteDecoder should have comment or be unexported (golint)
- Line 57: warning: exported method ByteDecoder.Offset should have comment or be unexported (golint)
- Line 61: warning: exported function NewDecoder should have comment or be unexported (golint)
- Line 67: warning: exported method ByteDecoder.Bool should have comment or be unexported (golint)
- Line 75: warning: exported method ByteDecoder.Int8 should have comment or be unexported (golint)
- Line 81: warning: exported method ByteDecoder.Int16 should have comment or be unexported (golint)
- Line 87: warning: exported method ByteDecoder.Int32 should have comment or be unexported (golint)
- Line 97: warning: exported method ByteDecoder.Int64 should have comment or be unexported (golint)
- Line 107: warning: exported method ByteDecoder.ArrayLength should have comment or be unexported (golint)
- Line 125: warning: exported method ByteDecoder.Bytes should have comment or be unexported (golint)
- Line 193: warning: exported method ByteDecoder.NullableString should have comment or be unexported (golint)
- Line 203: warning: exported method ByteDecoder.Int32Array should have comment or be unexported (golint)
- Line 232: warning: exported method ByteDecoder.Int64Array should have comment or be unexported (golint)
- Line 261: warning: exported method ByteDecoder.StringArray should have comment or be unexported (golint)
- Line 281: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 288: warning: exported method ByteDecoder.Push should have comment or be unexported (golint)
- Line 300: warning: exported method ByteDecoder.Pop should have comment or be unexported (golint)
-
-
jocko/protocol/describe_groups_response.go
- Line 5: warning: exported type DescribeGroupsResponse should have comment or be unexported (golint)
- Line 12: warning: exported method DescribeGroupsResponse.Encode should have comment or be unexported (golint)
- Line 27: warning: exported method DescribeGroupsResponse.Decode should have comment or be unexported (golint)
- Line 50: warning: exported method DescribeGroupsResponse.Key should have comment or be unexported (golint)
- Line 54: warning: exported type Group should have comment or be unexported (golint)
- Line 63: warning: exported method Group.Encode should have comment or be unexported (golint)
- Line 91: warning: exported method Group.Decode should have comment or be unexported (golint)
- Line 128: warning: exported type GroupMember should have comment or be unexported (golint)
- Line 135: warning: exported method GroupMember.Encode should have comment or be unexported (golint)
- Line 152: warning: exported method GroupMember.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/heartbeat_request.go
- Line 3: warning: exported type HeartbeatRequest should have comment or be unexported (golint)
- Line 11: warning: exported method HeartbeatRequest.Encode should have comment or be unexported (golint)
- Line 19: warning: exported method HeartbeatRequest.Decode should have comment or be unexported (golint)
- Line 34: warning: exported method HeartbeatRequest.Key should have comment or be unexported (golint)
- Line 38: warning: exported method HeartbeatRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/offsets_request.go
- Line 3: warning: exported type OffsetsPartition should have comment or be unexported (golint)
- Line 9: warning: exported type OffsetsTopic should have comment or be unexported (golint)
- Line 14: warning: exported type OffsetsRequest should have comment or be unexported (golint)
- Line 22: warning: exported method OffsetsRequest.Encode should have comment or be unexported (golint)
- Line 52: warning: exported method OffsetsRequest.Decode should have comment or be unexported (golint)
- Line 104: warning: exported method OffsetsRequest.Key should have comment or be unexported (golint)
- Line 108: warning: exported method OffsetsRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/request_header.go
- Line 5: warning: exported type RequestHeader should have comment or be unexported (golint)
- Line 18: warning: exported method RequestHeader.Encode should have comment or be unexported (golint)
- Line 29: warning: exported method RequestHeader.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/sasl_handshake_response.go
- Line 3: warning: exported type SaslHandshakeResponse should have comment or be unexported (golint)
- Line 5: warning: exported method SaslHandshakeResponse.Encode should have comment or be unexported (golint)
- Line 9: warning: exported method SaslHandshakeResponse.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/api_versions.go
- Line 3: warning: exported var APIVersions should have comment or be unexported (golint)
-
-
jocko/protocol/join_group_response.go
- Line 5: warning: exported type Member should have comment or be unexported (golint)
- Line 10: warning: exported type JoinGroupResponse should have comment or be unexported (golint)
- Line 22: warning: exported method JoinGroupResponse.Encode should have comment or be unexported (golint)
- Line 51: warning: exported method JoinGroupResponse.Decode should have comment or be unexported (golint)
- Line 96: warning: exported method JoinGroupResponse.Key should have comment or be unexported (golint)
- Line 100: warning: exported method JoinGroupResponse.Version should have comment or be unexported (golint)
-
-
jocko/jocko/broker.go
- Line 37: warning: exported var ErrTopicExists should have comment or be unexported (golint)
- Line 92: warning: comment on exported function NewBroker should be of the form "NewBroker ..." (golint)
- Line 212: warning: comment on exported method Broker.JoinLAN should be of the form "JoinLAN ..." (golint)
- Line 1314: warning: exported method Broker.LANMembers should have comment or be unexported (golint)
- Line 1318: warning: comment on exported type Replica should be of the form "Replica ..." (with optional leading article) (golint)
-
-
jocko/jocko/replica_lookup.go
- Line 14: warning: exported function NewReplicaLookup should have comment or be unexported (golint)
-
-
jocko/protocol/api_versions_requests.go
- Line 3: warning: exported type APIVersionsRequest should have comment or be unexported (golint)
- Line 7: warning: exported method APIVersionsRequest.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method APIVersionsRequest.Decode should have comment or be unexported (golint)
- Line 16: warning: exported method APIVersionsRequest.Key should have comment or be unexported (golint)
- Line 20: warning: exported method APIVersionsRequest.Version should have comment or be unexported (golint)
- Line 20: warning: receiver name r should be consistent with previous receiver name c for APIVersionsRequest (golint)
-
-
jocko/protocol/find_coordinator_response.go
- Line 5: warning: exported type Coordinator should have comment or be unexported (golint)
- Line 11: warning: exported type FindCoordinatorResponse should have comment or be unexported (golint)
- Line 20: warning: exported method FindCoordinatorResponse.Encode should have comment or be unexported (golint)
- Line 38: warning: exported method FindCoordinatorResponse.Decode should have comment or be unexported (golint)
- Line 69: warning: exported method FindCoordinatorResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/list_groups_request.go
- Line 3: warning: exported type ListGroupsRequest should have comment or be unexported (golint)
- Line 7: warning: exported method ListGroupsRequest.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method ListGroupsRequest.Decode should have comment or be unexported (golint)
- Line 16: warning: exported method ListGroupsRequest.Key should have comment or be unexported (golint)
- Line 20: warning: exported method ListGroupsRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/message_set.go
- Line 3: warning: exported type MessageSet should have comment or be unexported (golint)
- Line 10: warning: exported method MessageSet.Encode should have comment or be unexported (golint)
- Line 22: warning: exported method MessageSet.Decode should have comment or be unexported (golint)
-
-
jocko/protocol/metadata_request.go
- Line 3: warning: exported type MetadataRequest should have comment or be unexported (golint)
- Line 10: warning: exported method MetadataRequest.Encode should have comment or be unexported (golint)
- Line 21: warning: exported method MetadataRequest.Decode should have comment or be unexported (golint)
- Line 33: warning: exported method MetadataRequest.Key should have comment or be unexported (golint)
- Line 37: warning: exported method MetadataRequest.Version should have comment or be unexported (golint)
- Line 41: warning: exported type Strings should have comment or be unexported (golint)
-
-
jocko/protocol/metadata_response.go
- Line 3: warning: exported type Broker should have comment or be unexported (golint)
- Line 10: warning: exported type PartitionMetadata should have comment or be unexported (golint)
- Line 18: warning: exported type TopicMetadata should have comment or be unexported (golint)
- Line 24: warning: exported type MetadataResponse should have comment or be unexported (golint)
- Line 32: warning: exported method MetadataResponse.Encode should have comment or be unexported (golint)
- Line 72: warning: exported method MetadataResponse.Decode should have comment or be unexported (golint)
- Line 152: warning: exported method MetadataResponse.Version should have comment or be unexported (golint)
- Line 156: warning: exported type Brokers should have comment or be unexported (golint)
- Line 158: warning: exported type TopicMetadatas should have comment or be unexported (golint)
- Line 160: warning: exported type PartitionMetadatas should have comment or be unexported (golint)
-
-
jocko/protocol/offset_fetch_response.go
- Line 3: warning: exported type OffsetFetchTopicResponse should have comment or be unexported (golint)
- Line 8: warning: exported type OffsetFetchPartition should have comment or be unexported (golint)
- Line 15: warning: exported type OffsetFetchResponse should have comment or be unexported (golint)
- Line 21: warning: exported method OffsetFetchResponse.Encode should have comment or be unexported (golint)
- Line 44: warning: exported method OffsetFetchResponse.Decode should have comment or be unexported (golint)
- Line 79: warning: exported method OffsetFetchResponse.Version should have comment or be unexported (golint)
-
-
jocko/protocol/response.go
- Line 3: warning: exported type ResponseBody should have comment or be unexported (golint)
- Line 8: warning: exported type Response should have comment or be unexported (golint)
- Line 14: warning: exported method Response.Encode should have comment or be unexported (golint)
- Line 28: warning: exported method Response.Decode should have comment or be unexported (golint)
-
-
jocko/commitlog/segment.go
- Line 22: warning: exported type Segment should have comment or be unexported (golint)
- Line 37: warning: exported function NewSegment should have comment or be unexported (golint)
- Line 76: warning: exported method Segment.BuildIndex should have comment or be unexported (golint)
- Line 141: warning: exported method Segment.IsFull should have comment or be unexported (golint)
- Line 167: warning: exported method Segment.ReadAt should have comment or be unexported (golint)
- Line 173: warning: exported method Segment.Close should have comment or be unexported (golint)
- Line 245: warning: exported type SegmentScanner should have comment or be unexported (golint)
- Line 250: warning: exported function NewSegmentScanner should have comment or be unexported (golint)
-
-
jocko/protocol/alter_configs_request.go
- Line 3: warning: exported type AlterConfigsRequest should have comment or be unexported (golint)
- Line 10: warning: exported type AlterConfigsResource should have comment or be unexported (golint)
- Line 16: warning: exported type AlterConfigsEntry should have comment or be unexported (golint)
- Line 21: warning: exported method AlterConfigsRequest.Encode should have comment or be unexported (golint)
- Line 46: warning: exported method AlterConfigsRequest.Decode should have comment or be unexported (golint)
- Line 85: warning: exported method AlterConfigsRequest.Key should have comment or be unexported (golint)
- Line 89: warning: exported method AlterConfigsRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/update_metadata_response.go
- Line 3: warning: exported type UpdateMetadataResponse should have comment or be unexported (golint)
- Line 6: warning: exported method UpdateMetadataResponse.Encode should have comment or be unexported (golint)
- Line 10: warning: exported method UpdateMetadataResponse.Decode should have comment or be unexported (golint)
-
-
jocko/jocko/replicator.go
- Line 31: warning: exported type ReplicatorConfig should have comment or be unexported (golint)
-
-
jocko/log/log.go
- Line 10: warning: exported var Debug should have comment or be unexported (golint)
- Line 20: warning: exported type Level should have comment or be unexported (golint)
- Line 23: warning: exported var DebugLevel should have comment or be unexported (golint)
- Line 28: warning: exported function New should have comment or be unexported (golint)
- Line 41: warning: exported function SetPrefix should have comment or be unexported (golint)
- Line 47: warning: exported function SetLevel should have comment or be unexported (golint)
- Line 51: warning: exported function NewStdLogger should have comment or be unexported (golint)
-
-
jocko/commitlog/commitlog.go
- Line 17: warning: exported var ErrSegmentNotFound should have comment or be unexported (golint)
- Line 21: warning: exported type CleanupPolicy should have comment or be unexported (golint)
- Line 24: warning: exported const DeleteCleanupPolicy should have comment (or a comment on this block) or be unexported (golint)
- Line 31: warning: exported type CommitLog should have comment or be unexported (golint)
- Line 40: warning: exported type Options should have comment or be unexported (golint)
- Line 49: warning: exported function New should have comment or be unexported (golint)
- Line 135: warning: exported method CommitLog.Append should have comment or be unexported (golint)
- Line 164: warning: exported method CommitLog.NewestOffset should have comment or be unexported (golint)
- Line 168: warning: exported method CommitLog.OldestOffset should have comment or be unexported (golint)
- Line 178: warning: exported method CommitLog.Close should have comment or be unexported (golint)
- Line 189: warning: exported method CommitLog.Delete should have comment or be unexported (golint)
- Line 196: warning: exported method CommitLog.Truncate should have comment or be unexported (golint)
- Line 213: warning: exported method CommitLog.Segments should have comment or be unexported (golint)
-
-
jocko/protocol/controlled_shutdown_request.go
- Line 3: warning: exported type ControlledShutdownRequest should have comment or be unexported (golint)
- Line 7: warning: exported method ControlledShutdownRequest.Encode should have comment or be unexported (golint)
- Line 11: warning: exported method ControlledShutdownRequest.Decode should have comment or be unexported (golint)
- Line 15: warning: exported method ControlledShutdownRequest.Key should have comment or be unexported (golint)
- Line 19: warning: exported method ControlledShutdownRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/join_group_request.go
- Line 3: warning: exported type GroupProtocol should have comment or be unexported (golint)
- Line 8: warning: exported type JoinGroupRequest should have comment or be unexported (golint)
- Line 19: warning: exported method JoinGroupRequest.Encode should have comment or be unexported (golint)
- Line 44: warning: exported method JoinGroupRequest.Decode should have comment or be unexported (golint)
- Line 81: warning: exported method JoinGroupRequest.Key should have comment or be unexported (golint)
- Line 85: warning: exported method JoinGroupRequest.Version should have comment or be unexported (golint)
-
-
jocko/protocol/protocol.go
- Line 9: warning: exported var Encoding should have comment or be unexported (golint)
- Line 11: warning: exported function Read should have comment or be unexported (golint)
- Line 15: warning: exported function Write should have comment or be unexported (golint)
- Line 19: warning: exported function Size should have comment or be unexported (golint)
- Line 23: warning: exported function MakeInt16 should have comment or be unexported (golint)
- Line 27: warning: exported function MakeInt32 should have comment or be unexported (golint)
- Line 31: warning: exported function MakeInt64 should have comment or be unexported (golint)
- Line 35: warning: exported function ExpectZeroSize should have comment or be unexported (golint)
-
-
jocko/protocol/sync_group_response.go
- Line 5: warning: exported type SyncGroupResponse should have comment or be unexported (golint)
- Line 13: warning: exported method SyncGroupResponse.Encode should have comment or be unexported (golint)
- Line 21: warning: exported method SyncGroupResponse.Decode should have comment or be unexported (golint)
- Line 37: warning: exported method SyncGroupResponse.Key should have comment or be unexported (golint)
-
-
jocko/jocko/broker_lookup.go
- Line 18: warning: exported function NewBrokerLookup should have comment or be unexported (golint)
gocyclo94%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
jocko/jocko/fsm/fsm_test.go
- Line 209: warning: cyclomatic complexity 23 of function TestStore_RegisterGroup() is high (> 15) (gocyclo)
-
-
jocko/protocol/describe_configs_response.go
- Line 81: warning: cyclomatic complexity 21 of function (*DescribeConfigsResponse).Decode() is high (> 15) (gocyclo)
-
-
jocko/protocol/create_topic_requests.go
- Line 59: warning: cyclomatic complexity 19 of function (*CreateTopicRequests).Decode() is high (> 15) (gocyclo)
-
-
jocko/protocol/metadata_response.go
- Line 72: warning: cyclomatic complexity 18 of function (*MetadataResponse).Decode() is high (> 15) (gocyclo)
-
-
jocko/protocol/leader_and_isr_request.go
- Line 69: warning: cyclomatic complexity 18 of function (*LeaderAndISRRequest).Decode() is high (> 15) (gocyclo)
-
-
jocko/protocol/offset_commit_request.go
- Line 47: warning: cyclomatic complexity 16 of function (*OffsetCommitRequest).Decode() is high (> 15) (gocyclo)
-
-
jocko/protocol/fetch_request.go
- Line 67: warning: cyclomatic complexity 16 of function (*FetchRequest).Decode() is high (> 15) (gocyclo)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell99%
Misspell Finds commonly misspelled English words
-
-
jocko/jocko/metadata/metadata_test.go
- Line 15: warning: "minumum" is a misspelling of "minimum" (misspell)