gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• aresdb/utils/metrics.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/memstore/common/primary_key_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/tasks/Module.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/handlers/module.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/handlers/placement_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/broker/query_compiler.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/query/common/hll.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/memstore/common/data_value.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/memstore/common/upsert_batch.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/query/aql_context.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/memstore/vectors/vector_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/subscriber/common/job/streaming_processor_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/common/log.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/handlers/composite.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/subscriber/common/message/message_parser_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/mutators/module.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/api/schema_handler.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/datanode/options.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/controller/mutators/etcd/placement_mutator_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/memstore/backfill.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/query/aql_compiler_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/query/hll_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• aresdb/integration/ares_suite_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint77%

Golint is a linter for Go source code.

• aresdb/redolog/file_redolog_manager.go
  • Line 29: warning: comment on exported type FileRedoLogManager should be of the form "FileRedoLogManager ..." (with optional leading article) (golint)
  • Line 392: warning: exported method FileRedoLogManager.WaitForRecoveryDone should have comment or be unexported (golint)
  • Line 396: warning: comment on exported method FileRedoLogManager.GetTotalSize should be of the form "GetTotalSize ..." (golint)
  • Line 403: warning: exported method FileRedoLogManager.GetNumFiles should have comment or be unexported (golint)
  • Line 409: warning: exported method FileRedoLogManager.GetBatchReceived should have comment or be unexported (golint)
  • Line 413: warning: exported method FileRedoLogManager.GetBatchRecovered should have comment or be unexported (golint)

• aresdb/controller/models/Instance.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/models/job.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/memstore/list/memory_pool.go
  • Line 33: warning: exported type HostMemoryChangeReporter should have comment or be unexported (golint)

• aresdb/memstore/tests/test_factory_base.go
  • Line 31: warning: comment on exported type TestFactoryBase should be of the form "TestFactoryBase ..." (with optional leading article) (golint)
  • Line 45: warning: exported type RawVectorParty should have comment or be unexported (golint)

• aresdb/datanode/bootstrap/bootstrap_server.go
  • Line 46: warning: exported type PeerDataNodeServerImpl should have comment or be unexported (golint)
  • Line 76: warning: exported function NewPeerDataNodeServer should have comment or be unexported (golint)
  • Line 108: warning: comment on exported method PeerDataNodeServerImpl.ReleaseToken should be of the form "ReleaseToken ..." (golint)
  • Line 393: warning: exported method PeerDataNodeServerImpl.FetchVectorPartyRawData should have comment or be unexported (golint)

• aresdb/utils/http.go
  • Line 33: warning: exported const HTTPContentTypeHeaderKey should have comment (or a comment on this block) or be unexported (golint)

• aresdb/memstore/scheduler.go
  • Line 269: warning: error should be the last type when returning multiple items (golint)

• aresdb/cmd/subscriber/main.go
  • Line 23: warning: exported type Params should have comment or be unexported (golint)
  • Line 29: warning: exported type Result should have comment or be unexported (golint)
  • Line 46: warning: exported function Execute should have comment or be unexported (golint)
  • Line 126: warning: exported function Init should have comment or be unexported (golint)

• aresdb/controller/mutators/etcd/common.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/datanode/bootstrap/bootstrap_details.go
  • Line 28: warning: exported function NewBootstrapDetails should have comment or be unexported (golint)

• aresdb/memstore/common/upsert_batch.go
  • Line 187: warning: comment on exported method UpsertBatch.GetColumnLen should be of the form "GetColumnLen ..." (golint)
  • Line 192: warning: comment on exported method UpsertBatch.GetColumMode should be of the form "GetColumMode ..." (golint)
  • Line 197: warning: comment on exported method UpsertBatch.GetColumnUpdateMode should be of the form "GetColumnUpdateMode ..." (golint)
  • Line 202: warning: comment on exported method UpsertBatch.ReadGoValue should be of the form "ReadGoValue ..." (golint)

• aresdb/query/aql_postprocessor.go
  • Line 225: warning: exported method AQLQueryContext.ResultsRowsFlushed should have comment or be unexported (golint)

• aresdb/memstore/test_factory.go
  • Line 192: warning: exported function GetFactory should have comment or be unexported (golint)

• aresdb/cluster/topology/map.go
  • Line 90: warning: receiver name t should be consistent with previous receiver name sm for staticMap (golint)

• aresdb/memstore/list/test_factory.go
  • Line 41: warning: exported function GetFactory should have comment or be unexported (golint)
  • Line 45: warning: exported function ToArrayArchiveVectorParty should have comment or be unexported (golint)
  • Line 49: warning: exported function ToArrayLiveVectorParty should have comment or be unexported (golint)
  • Line 53: warning: exported function ToArrayVectorParty should have comment or be unexported (golint)

• aresdb/query/expr/token.go
  • Line 32: warning: comment on exported const ILLEGAL should be of the form "ILLEGAL ..." (golint)
  • Line 34: warning: exported const EOF should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: don't use underscores in Go names; const literal_beg should be literalBeg (golint)
  • Line 38: warning: comment on exported const IDENT should be of the form "IDENT ..." (golint)
  • Line 48: warning: don't use underscores in Go names; const literal_end should be literalEnd (golint)
  • Line 50: warning: don't use underscores in Go names; const operator_beg should be operatorBeg (golint)
  • Line 52: warning: don't use underscores in Go names; const unary_operator_beg should be unaryOperatorBeg (golint)
  • Line 58: warning: comment on exported const GET_WEEK_START should be of the form "GET_WEEK_START ..." (golint)
  • Line 67: warning: comment on exported const GET_HLL_VALUE should be of the form "GET_HLL_VALUE ..." (golint)
  • Line 69: warning: comment on exported const ARRAY_LENGTH should be of the form "ARRAY_LENGTH ..." (golint)
  • Line 71: warning: don't use underscores in Go names; const unary_operator_end should be unaryOperatorEnd (golint)
  • Line 73: warning: don't use underscores in Go names; const derived_unary_operator_beg should be derivedUnaryOperatorBeg (golint)
  • Line 78: warning: don't use underscores in Go names; const derived_unary_operator_end should be derivedUnaryOperatorEnd (golint)
  • Line 80: warning: don't use underscores in Go names; const binary_operator_beg should be binaryOperatorBeg (golint)
  • Line 102: warning: comment on exported const EQ should be of the form "EQ ..." (golint)
  • Line 109: warning: comment on exported const GEOGRAPHY_INTERSECTS should be of the form "GEOGRAPHY_INTERSECTS ..." (golint)
  • Line 111: warning: comment on exported const ARRAY_CONTAINS should be of the form "ARRAY_CONTAINS ..." (golint)
  • Line 114: warning: don't use underscores in Go names; const binary_operator_end should be binaryOperatorEnd (golint)
  • Line 115: warning: don't use underscores in Go names; const operator_end should be operatorEnd (golint)
  • Line 122: warning: don't use underscores in Go names; const keyword_beg should be keywordBeg (golint)
  • Line 123: warning: comment on exported const ALL should be of the form "ALL ..." (golint)
  • Line 159: warning: don't use underscores in Go names; const keyword_end should be keywordEnd (golint)
  • Line 295: warning: exported method Token.MarshalJSON should have comment or be unexported (golint)

• aresdb/controller/mutators/common/types.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 96: warning: comment on exported type PlacementMutator should be of the form "PlacementMutator ..." (with optional leading article) (golint)

• aresdb/metastore/common/data_type.go
  • Line 18: warning: comment on exported const EnumDelimiter should be of the form "EnumDelimiter ..." (golint)

• aresdb/controller/tasks/common/errors.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/datanode/client/query_client.go
  • Line 27: warning: should not use dot imports (golint)

• aresdb/controller/mutators/etcd/enum_mutator.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/memstore/list/slab.go
  • Line 24: warning: comment on exported type Loc should be of the form "Loc ..." (with optional leading article) (golint)
  • Line 44: warning: exported function IsNilAddr should have comment or be unexported (golint)

• aresdb/cmd/broker/cmd/cmd.go
  • Line 43: warning: exported function Execute should have comment or be unexported (golint)

• aresdb/controller/mutators/mocks/NamespaceMutator.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/tasks/etcd/leader_elector.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/handlers/error.go
  • Line 15: warning: package comment should be of the form "Package handlers ..." (golint)

• aresdb/metastore/common/errors.go
  • Line 74: warning: exported var ErrMissingTimeColumn should have comment or be unexported (golint)

• aresdb/query/common/aql_query_result.go
  • Line 18: warning: exported const MatrixDataKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 105: warning: exported method AQLQueryResult.Append should have comment or be unexported (golint)

• aresdb/cluster/kvstore/transaction.go
  • Line 1: warning: package comment should be of the form "Package kvstore ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/cgoutils/memory.go
  • Line 31: warning: exported function IsDeviceMemoryImplementation should have comment or be unexported (golint)
  • Line 35: warning: exported function IsPooledMemory should have comment or be unexported (golint)
  • Line 39: warning: exported function SupportHashReduction should have comment or be unexported (golint)

• aresdb/broker/config/config.go
  • Line 21: warning: exported type BrokerConfig should have comment or be unexported (golint)

• aresdb/subscriber/common/message/message_decoder.go
  • Line 52: warning: comment on exported type StringMessage should be of the form "StringMessage ..." (with optional leading article) (golint)
  • Line 58: warning: exported function NewStringMessage should have comment or be unexported (golint)
  • Line 65: warning: exported method StringMessage.Key should have comment or be unexported (golint)
  • Line 69: warning: exported method StringMessage.Value should have comment or be unexported (golint)
  • Line 73: warning: exported method StringMessage.Topic should have comment or be unexported (golint)
  • Line 77: warning: exported method StringMessage.Partition should have comment or be unexported (golint)
  • Line 81: warning: exported method StringMessage.Offset should have comment or be unexported (golint)
  • Line 85: warning: exported method StringMessage.Ack should have comment or be unexported (golint)
  • Line 89: warning: exported method StringMessage.Nack should have comment or be unexported (golint)
  • Line 93: warning: exported method StringMessage.Cluster should have comment or be unexported (golint)

• aresdb/controller/tasks/etcd/ingestion_assignment.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/broker/broker_schema_mutator.go
  • Line 34: warning: exported function NewBrokerSchemaMutator should have comment or be unexported (golint)
  • Line 40: warning: comment on exported method BrokerSchemaMutator.ListTables should be of the form "ListTables ..." (golint)
  • Line 51: warning: exported method BrokerSchemaMutator.GetTable should have comment or be unexported (golint)
  • Line 61: warning: exported method BrokerSchemaMutator.CreateTable should have comment or be unexported (golint)
  • Line 65: warning: exported method BrokerSchemaMutator.DeleteTable should have comment or be unexported (golint)
  • Line 69: warning: exported method BrokerSchemaMutator.UpdateTableConfig should have comment or be unexported (golint)
  • Line 73: warning: exported method BrokerSchemaMutator.UpdateTable should have comment or be unexported (golint)
  • Line 77: warning: exported method BrokerSchemaMutator.AddColumn should have comment or be unexported (golint)
  • Line 86: warning: exported method BrokerSchemaMutator.UpdateColumn should have comment or be unexported (golint)
  • Line 96: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 104: warning: exported method BrokerSchemaMutator.DeleteColumn should have comment or be unexported (golint)
  • Line 114: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 122: warning: comment on exported method BrokerSchemaMutator.GetSchema should be of the form "GetSchema ..." (golint)
  • Line 130: warning: exported method BrokerSchemaMutator.GetSchemas should have comment or be unexported (golint)
  • Line 134: warning: exported method BrokerSchemaMutator.UpdateEnum should have comment or be unexported (golint)

• aresdb/broker/common/types.go
  • Line 38: warning: exported type QueryPlan should have comment or be unexported (golint)
  • Line 49: warning: exported type MergeNode should have comment or be unexported (golint)

• aresdb/datanode/types.go
  • Line 26: warning: exported type DataNode should have comment or be unexported (golint)

• aresdb/datanode/client/types.go
  • Line 1: warning: package comment should be of the form "Package client ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 30: warning: exported type Peer should have comment or be unexported (golint)
  • Line 43: warning: exported type DataNodeQueryClient should have comment or be unexported (golint)

• aresdb/query/context/query_context_helper.go
  • Line 47: warning: comment on exported method QueryContextHelper.ResolveColumn should be of the form "ResolveColumn ..." (golint)

• aresdb/query/expr/scanner.go
  • Line 470: warning: exported function ScanDelimited should have comment or be unexported (golint)

• aresdb/query/common/dim_util.go
  • Line 42: warning: comment on exported function DimValResVectorSize should be of the form "DimValResVectorSize ..." (golint)

• aresdb/utils/key.go
  • Line 1: warning: package comment should be of the form "Package utils ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/broker/query_compiler.go
  • Line 385: warning: exported method QueryContext.InitQCHelper should have comment or be unexported (golint)
  • Line 391: warning: exported method QueryContext.GetSchema should have comment or be unexported (golint)
  • Line 395: warning: exported method QueryContext.GetTableID should have comment or be unexported (golint)
  • Line 400: warning: exported method QueryContext.GetQuery should have comment or be unexported (golint)
  • Line 404: warning: exported method QueryContext.SetError should have comment or be unexported (golint)
  • Line 408: warning: exported method QueryContext.IsDataOnly should have comment or be unexported (golint)

• aresdb/memstore/common/schema.go
  • Line 190: warning: comment on exported method TableSchema.CreateEnumDict should be of the form "CreateEnumDict ..." (golint)

• aresdb/utils/env.go
  • Line 17: warning: exported type AresEnv should have comment or be unexported (golint)
  • Line 20: warning: exported const EnvProd should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported type EnvironmentContext should have comment or be unexported (golint)
  • Line 72: warning: exported function IsTest should have comment or be unexported (golint)
  • Line 76: warning: exported function IsDev should have comment or be unexported (golint)
  • Line 80: warning: exported function IsProd should have comment or be unexported (golint)
  • Line 84: warning: exported function IsStaging should have comment or be unexported (golint)

• aresdb/cluster/topology/healthtracking_dynamic.go
  • Line 46: warning: exported function NewHealthTrackingDynamicTopology should have comment or be unexported (golint)

• aresdb/controller/tasks/common/types.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/memstore/common/primary_key.go
  • Line 25: warning: exported const BucketSize should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: comment on exported const NumHashes should be of the form "NumHashes ..." (golint)

• aresdb/examples/utils/example_utils.go
  • Line 35: warning: exported type TableCreationResp should have comment or be unexported (golint)
  • Line 57: warning: exported function PanicIfErr should have comment or be unexported (golint)
  • Line 166: warning: exported function MakeQuery should have comment or be unexported (golint)
  • Line 196: warning: exported function CreateTable should have comment or be unexported (golint)
  • Line 228: warning: exported function IngestDataForTable should have comment or be unexported (golint)

• aresdb/subscriber/config/service_config.go
  • Line 109: warning: exported type EtcdConfig should have comment or be unexported (golint)
  • Line 115: warning: exported type EtcdClusterConfig should have comment or be unexported (golint)
  • Line 124: warning: don't use underscores in Go names; const Sink_Undefined should be SinkUndefined (golint)
  • Line 124: warning: exported const Sink_Undefined should have comment (or a comment on this block) or be unexported (golint)
  • Line 125: warning: don't use underscores in Go names; const Sink_AresDB should be SinkAresDB (golint)
  • Line 126: warning: don't use underscores in Go names; const Sink_Kafka should be SinkKafka (golint)
  • Line 260: warning: exported method SinkConfig.GetSinkMode should have comment or be unexported (golint)

• aresdb/query/common/hll.go
  • Line 1037: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)

• aresdb/memstore/common/upsert_batch_builder.go
  • Line 46: warning: exported const V1 should have comment (or a comment on this block) or be unexported (golint)
  • Line 401: warning: exported method UpsertBatchBuilder.MarkFactTable should have comment or be unexported (golint)
  • Line 471: warning: exported function AdditionUpdate should have comment or be unexported (golint)

• aresdb/controller/mutators/mocks/SubscriberMutator.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/cluster/topology/types.go
  • Line 81: warning: exported type MapWatch should have comment or be unexported (golint)

• aresdb/controller/mutators/etcd/schema_mutator.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/handlers/doc.go
  • Line 1: warning: package comment should be of the form "Package handlers ..." (golint)

• aresdb/memstore/common/batch.go
  • Line 111: warning: exported method Batch.Dump should have comment or be unexported (golint)

• aresdb/redolog/redolog_manager.go
  • Line 31: warning: comment on exported type NextUpsertFunc should be of the form "NextUpsertFunc ..." (with optional leading article) (golint)

• aresdb/query/aql_context.go
  • Line 436: warning: comment on exported method AQLQueryContext.InitQCHelper should be of the form "InitQCHelper ..." (golint)
  • Line 443: warning: exported method AQLQueryContext.GetSchema should have comment or be unexported (golint)
  • Line 447: warning: exported method AQLQueryContext.GetTableID should have comment or be unexported (golint)
  • Line 452: warning: exported method AQLQueryContext.GetQuery should have comment or be unexported (golint)
  • Line 456: warning: exported method AQLQueryContext.SetError should have comment or be unexported (golint)
  • Line 460: warning: exported method AQLQueryContext.IsDataOnly should have comment or be unexported (golint)

• aresdb/memstore/options.go
  • Line 22: warning: exported type Option should have comment or be unexported (golint)
  • Line 24: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)

• aresdb/query/common/aql.go
  • Line 151: warning: exported method Dimension.IsTimeDimension should have comment or be unexported (golint)

• aresdb/controller/mutators/mocks/JobMutator.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/memstore/list/archive_vector_party.go
  • Line 31: warning: exported const ListVectorPartyHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 186: warning: comment on exported method ArchiveVectorParty.GetListValue should be of the form "GetListValue ..." (golint)
  • Line 382: warning: comment on exported method ArchiveVectorParty.SliceIndex should be of the form "SliceIndex ..." (golint)

• aresdb/memstore/list/live_vector_party.go
  • Line 328: warning: comment on exported method LiveVectorParty.GetListValue should be of the form "GetListValue ..." (golint)
  • Line 377: warning: comment on exported method LiveVectorParty.SetDataValue should be of the form "SetDataValue ..." (golint)

• aresdb/api/common/query_request.go
  • Line 21: warning: comment on exported type RequestContext should be of the form "RequestContext ..." (with optional leading article) (golint)

• aresdb/redolog/redolog_manager_master.go
  • Line 27: warning: comment on exported type RedoLogManagerMaster should be of the form "RedoLogManagerMaster ..." (with optional leading article) (golint)

• aresdb/subscriber/common/sink/kafka.go
  • Line 36: warning: exported type KafkaPublisher should have comment or be unexported (golint)
  • Line 46: warning: exported function NewKafkaPublisher should have comment or be unexported (golint)

• aresdb/client/mocks/Connector.go
  • Line 15: warning: package comment should be of the form "Package mocks ..." (golint)

• aresdb/broker/common/constant.go
  • Line 19: warning: exported type AggType should have comment or be unexported (golint)
  • Line 22: warning: exported const Count should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported var CallNameToAggType should have comment or be unexported (golint)

• aresdb/cmd/arescli/main.go
  • Line 101: warning: exported function Execute should have comment or be unexported (golint)

• aresdb/metastore/schema_fetch.go
  • Line 78: warning: exported method SchemaFetchJob.FetchSchema should have comment or be unexported (golint)

• aresdb/controller/models/assignment.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/cmd/controller/cmd/cmd.go
  • Line 40: warning: exported var Module should have comment or be unexported (golint)
  • Line 43: warning: exported type Params should have comment or be unexported (golint)
  • Line 66: warning: exported function Execute should have comment or be unexported (golint)
  • Line 97: warning: exported function Init should have comment or be unexported (golint)

• aresdb/query/common/dimval.go
  • Line 26: warning: comment on exported const NULLString should be of the form "NULLString ..." (golint)
  • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• aresdb/controller/tasks/Module.go
  • Line 56: warning: exported var Module should have comment or be unexported (golint)

• aresdb/controller/mutators/common/job_config_validator.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/utils/kafka.go
  • Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• aresdb/controller/mutators/etcd/assignment_mutator.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/common/config.go
  • Line 92: warning: comment on exported type DiskRedoLogConfig should be of the form "DiskRedoLogConfig ..." (with optional leading article) (golint)
  • Line 98: warning: comment on exported type KafkaRedoLogConfig should be of the form "KafkaRedoLogConfig ..." (with optional leading article) (golint)
  • Line 108: warning: comment on exported type RedoLogConfig should be of the form "RedoLogConfig ..." (with optional leading article) (golint)

• aresdb/memstore/common/data_value.go
  • Line 232: warning: comment on exported type ArrayValue should be of the form "ArrayValue ..." (with optional leading article) (golint)
  • Line 802: warning: exported function CalculateListNilOffset should have comment or be unexported (golint)

• aresdb/memstore/common/types.go
  • Line 7: warning: exported type TableSchemaReader should have comment or be unexported (golint)
  • Line 17: warning: exported type EnumUpdater should have comment or be unexported (golint)

• aresdb/controller/client/controller.go
  • Line 123: warning: exported method ControllerHTTPClient.GetSchemaHash should have comment or be unexported (golint)
  • Line 138: warning: exported method ControllerHTTPClient.GetAllSchema should have comment or be unexported (golint)
  • Line 152: warning: exported method ControllerHTTPClient.GetNamespaces should have comment or be unexported (golint)

• aresdb/controller/mutators/mocks/IngestionAssignmentMutator.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/subscriber/common/consumer/kafka/kafka.go
  • Line 1: warning: package comment should be of the form "Package kafka ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)
  • Line 307: warning: exported method KafkaConsumer.Close should have comment or be unexported (golint)
  • Line 330: warning: exported method KafkaMessage.Key should have comment or be unexported (golint)
  • Line 334: warning: exported method KafkaMessage.Value should have comment or be unexported (golint)
  • Line 338: warning: exported method KafkaMessage.Topic should have comment or be unexported (golint)
  • Line 342: warning: exported method KafkaMessage.Partition should have comment or be unexported (golint)
  • Line 346: warning: exported method KafkaMessage.Offset should have comment or be unexported (golint)
  • Line 350: warning: exported method KafkaMessage.Ack should have comment or be unexported (golint)
  • Line 356: warning: exported method KafkaMessage.Nack should have comment or be unexported (golint)
  • Line 360: warning: exported method KafkaMessage.Cluster should have comment or be unexported (golint)

• aresdb/broker/handler.go
  • Line 30: warning: exported type QueryHandler should have comment or be unexported (golint)
  • Line 36: warning: exported function NewQueryHandler should have comment or be unexported (golint)
  • Line 43: warning: exported method QueryHandler.Register should have comment or be unexported (golint)
  • Line 48: warning: exported method QueryHandler.HandleSQL should have comment or be unexported (golint)
  • Line 91: warning: exported method QueryHandler.HandleAQL should have comment or be unexported (golint)

• aresdb/controller/mutators/mocks/TableSchemaMutator.go
  • Line 1: warning: package comment should be of the form "Package mocks ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/utils/io.go
  • Line 29: warning: exported type WriteSyncCloser should have comment or be unexported (golint)

• aresdb/utils/serialization.go
  • Line 398: warning: receiver name cr should be consistent with previous receiver name cb for ClosableBuffer (golint)

• aresdb/controller/mutators/common/errors.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/testing/utils.go
  • Line 39: warning: exported method TestReadWriteSyncCloser.Sync should have comment or be unexported (golint)
  • Line 48: warning: exported type GinkgoTestReporter should have comment or be unexported (golint)
  • Line 50: warning: exported method GinkgoTestReporter.Errorf should have comment or be unexported (golint)
  • Line 54: warning: exported method GinkgoTestReporter.Fatalf should have comment or be unexported (golint)
  • Line 58: warning: exported function MockKafkaConsumerFunc should have comment or be unexported (golint)

• aresdb/subscriber/common/rules/job_config.go
  • Line 169: warning: comment on exported method JobConfig.GetPrimaryKeyBytes should be of the form "GetPrimaryKeyBytes ..." (golint)

• aresdb/redolog/kafka_redolog_manager.go
  • Line 268: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• aresdb/datanode/bootstrap/types.go
  • Line 51: warning: exported const Waiting should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: comment on exported type BootstrapDetails should be of the form "BootstrapDetails ..." (with optional leading article) (golint)

• aresdb/utils/mocks/ReadCloser.go
  • Line 15: warning: package comment should be of the form "Package mocks ..." (golint)

• aresdb/broker/query_plan_agg.go
  • Line 52: warning: exported function NewMergeNode should have comment or be unexported (golint)
  • Line 149: warning: exported method BlockingScanNode.Execute should have comment or be unexported (golint)
  • Line 432: warning: exported method AggQueryPlan.Execute should have comment or be unexported (golint)

• aresdb/controller/models/subscriber.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/mutators/etcd/namespace_mutator.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/controller/mutators/etcd/job_mutator.go
  • Line 1: warning: package comment should be of the form "Package etcd ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/utils/consistenthasing/consistenthashing.go
  • Line 1: warning: package comment should be of the form "Package consistenthasing ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/memstore/bootstrap.go
  • Line 1: warning: package comment should be of the form "Package memstore ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/broker/query_plan_non_agg.go
  • Line 38: warning: exported method StreamingScanNode.Execute should have comment or be unexported (golint)
  • Line 98: warning: exported function NewNonAggQueryPlan should have comment or be unexported (golint)
  • Line 164: warning: exported method NonAggQueryPlan.Execute should have comment or be unexported (golint)

• aresdb/memstore/common/data_type.go
  • Line 410: warning: exported function UUIDFromString should have comment or be unexported (golint)
  • Line 561: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)

• aresdb/client/connector.go
  • Line 70: warning: exported type TableSchema should have comment or be unexported (golint)
  • Line 109: warning: exported function NewUpsertBatchBuilderImpl should have comment or be unexported (golint)

• aresdb/api/debug_handler.go
  • Line 759: warning: comment on exported method DebugHandler.BootstrapRetry should be of the form "BootstrapRetry ..." (golint)

• aresdb/query/expr/ast.go
  • Line 39: warning: exported const UnknownType should have comment (or a comment on this block) or be unexported (golint)
  • Line 88: warning: exported method Type.MarshalJSON should have comment or be unexported (golint)

• aresdb/cluster/kvstore/etcd.go
  • Line 1: warning: package comment should be of the form "Package kvstore ..." (golint)
  • Line 1: warning: package comment should not have leading space (golint)

• aresdb/subscriber/common/sink/sink.go
  • Line 56: warning: exported function Shard should have comment or be unexported (golint)

• aresdb/utils/test_utils.go
  • Line 41: warning: exported method TestingTMock.Fatalf should have comment or be unexported (golint)

gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• aresdb/memstore/vector_party.go
  • Line 508: warning: cyclomatic complexity 18 of function (*cVectorParty).Read() is high (> 15) (gocyclo)
  • Line 264: warning: cyclomatic complexity 16 of function (*cVectorParty).Equals() is high (> 15) (gocyclo)

• aresdb/broker/result_merge.go
  • Line 47: warning: cyclomatic complexity 25 of function (*resultMergeContext).mergeResultsRecursive() is high (> 15) (gocyclo)

• aresdb/datanode/datanode.go
  • Line 597: warning: cyclomatic complexity 26 of function (*dataNode).assignShardSet() is high (> 15) (gocyclo)

• aresdb/query/sql/sql_parser.go
  • Line 956: warning: cyclomatic complexity 21 of function (*ASTBuilder).VisitFunctionCall() is high (> 15) (gocyclo)
  • Line 405: warning: cyclomatic complexity 17 of function (*ASTBuilder).VisitQuerySpecification() is high (> 15) (gocyclo)

• aresdb/memstore/common/upsert_batch_builder.go
  • Line 154: warning: cyclomatic complexity 49 of function (*columnBuilder).AppendToBuffer() is high (> 15) (gocyclo)

• aresdb/controller/tasks/etcd/ingestion_assignment.go
  • Line 317: warning: cyclomatic complexity 20 of function (*ingestionAssignmentTask).processIngestionAssignment() is high (> 15) (gocyclo)

• aresdb/query/aql_postprocessor.go
  • Line 66: warning: cyclomatic complexity 17 of function (*AQLQueryContext).flushResultBuffer() is high (> 15) (gocyclo)

• aresdb/api/common/request.go
  • Line 46: warning: cyclomatic complexity 36 of function ReadRequest() is high (> 15) (gocyclo)

• aresdb/memstore/list/archive_vector_party.go
  • Line 252: warning: cyclomatic complexity 17 of function (*ArchiveVectorParty).Read() is high (> 15) (gocyclo)

• aresdb/metastore/schema_fetch.go
  • Line 101: warning: cyclomatic complexity 17 of function (*SchemaFetchJob).applySchemaChange() is high (> 15) (gocyclo)

• aresdb/memstore/backfill.go
  • Line 108: warning: cyclomatic complexity 18 of function (*TableShard).createNewArchiveStoreVersionForBackfill() is high (> 15) (gocyclo)
  • Line 436: warning: cyclomatic complexity 16 of function (*backfillContext).backfill() is high (> 15) (gocyclo)

• aresdb/utils/hash.go
  • Line 90: warning: cyclomatic complexity 17 of function Murmur3Sum128() is high (> 15) (gocyclo)

• aresdb/memstore/ingestion.go
  • Line 364: warning: cyclomatic complexity 33 of function (*TableShard).writeBatchRecords() is high (> 15) (gocyclo)
  • Line 172: warning: cyclomatic complexity 30 of function (*TableShard).insertPrimaryKeys() is high (> 15) (gocyclo)

• aresdb/query/aql_compiler.go
  • Line 1139: warning: cyclomatic complexity 28 of function (*AQLQueryContext).processMeasure() is high (> 15) (gocyclo)
  • Line 658: warning: cyclomatic complexity 26 of function (*AQLQueryContext).matchPrefilters() is high (> 15) (gocyclo)
  • Line 344: warning: cyclomatic complexity 23 of function (*AQLQueryContext).parseExprs() is high (> 15) (gocyclo)
  • Line 105: warning: cyclomatic complexity 18 of function (*AQLQueryContext).adjustFilterToTimeFilter() is high (> 15) (gocyclo)
  • Line 799: warning: cyclomatic complexity 18 of function (*AQLQueryContext).processFilters() is high (> 15) (gocyclo)

• aresdb/query/expr/ast.go
  • Line 507: warning: cyclomatic complexity 17 of function CloneExpr() is high (> 15) (gocyclo)

• aresdb/redolog/kafka_redolog_manager.go
  • Line 203: warning: cyclomatic complexity 18 of function (*kafkaRedoLogManager).Iterator() is high (> 15) (gocyclo)

• aresdb/query/common/time_filter.go
  • Line 241: warning: cyclomatic complexity 24 of function parseTimeFilterExpression() is high (> 15) (gocyclo)
  • Line 149: warning: cyclomatic complexity 18 of function parseAbsoluteTime() is high (> 15) (gocyclo)

• aresdb/query/common/dimval.go
  • Line 146: warning: cyclomatic complexity 20 of function formatTimeDimension() is high (> 15) (gocyclo)
  • Line 36: warning: cyclomatic complexity 19 of function ReadDimension() is high (> 15) (gocyclo)

• aresdb/memstore/list/live_vector_party.go
  • Line 173: warning: cyclomatic complexity 17 of function (*LiveVectorParty).Read() is high (> 15) (gocyclo)

• aresdb/query/time_series_aggregate.go
  • Line 493: warning: cyclomatic complexity 20 of function (*oopkBatchContext).processExpression() is high (> 15) (gocyclo)
  • Line 127: warning: cyclomatic complexity 16 of function makeDefaultValue() is high (> 15) (gocyclo)

• aresdb/client/connector.go
  • Line 382: warning: cyclomatic complexity 36 of function (*UpsertBatchBuilderImpl).PrepareUpsertBatch() is high (> 15) (gocyclo)
  • Line 285: warning: cyclomatic complexity 17 of function (*UpsertBatchBuilderImpl).prepareEnumCases() is high (> 15) (gocyclo)

• aresdb/api/debug_handler.go
  • Line 141: warning: cyclomatic complexity 22 of function (*DebugHandler).ShowBatch() is high (> 15) (gocyclo)

• aresdb/api/query_handler.go
  • Line 107: warning: cyclomatic complexity 18 of function (*QueryHandler).handleAQLInternal() is high (> 15) (gocyclo)

• aresdb/query/context/query_context_helper.go
  • Line 132: warning: cyclomatic complexity 137 of function (*QueryContextHelper).Rewrite() is high (> 15) (gocyclo)

• aresdb/memstore/common/upsert_batch.go
  • Line 437: warning: cyclomatic complexity 18 of function readUpsertBatch() is high (> 15) (gocyclo)

• aresdb/broker/query_plan_non_agg.go
  • Line 164: warning: cyclomatic complexity 30 of function (*NonAggQueryPlan).Execute() is high (> 15) (gocyclo)

• aresdb/datanode/bootstrap/bootstrap_server.go
  • Line 233: warning: cyclomatic complexity 23 of function (*PeerDataNodeServerImpl).FetchTableShardMetaData() is high (> 15) (gocyclo)

• aresdb/query/expr/parser.go
  • Line 359: warning: cyclomatic complexity 28 of function (*Parser).parseUnaryExpr() is high (> 15) (gocyclo)

• aresdb/memstore/common/data_value.go
  • Line 621: warning: cyclomatic complexity 33 of function (*ArrayValue).Write() is high (> 15) (gocyclo)
  • Line 350: warning: cyclomatic complexity 31 of function ValueFromString() is high (> 15) (gocyclo)
  • Line 807: warning: cyclomatic complexity 29 of function GetDataValue() is high (> 15) (gocyclo)
  • Line 258: warning: cyclomatic complexity 23 of function (DataValue).ConvertToHumanReadable() is high (> 15) (gocyclo)

• aresdb/subscriber/common/job/controller.go
  • Line 277: warning: cyclomatic complexity 28 of function (*Controller).SyncUpJobConfigs() is high (> 15) (gocyclo)

• aresdb/memstore/common/data_type.go
  • Line 145: warning: cyclomatic complexity 29 of function NewDataType() is high (> 15) (gocyclo)
  • Line 224: warning: cyclomatic complexity 18 of function ConvertValueForType() is high (> 15) (gocyclo)

• aresdb/broker/query_compiler.go
  • Line 70: warning: cyclomatic complexity 16 of function (*QueryContext).GetRewrittenQuery() is high (> 15) (gocyclo)

• aresdb/query/expr/scanner.go
  • Line 53: warning: cyclomatic complexity 36 of function (*Scanner).scan() is high (> 15) (gocyclo)

• aresdb/query/common/hll.go
  • Line 217: warning: cyclomatic complexity 24 of function parseOldTimeseriesHLLResult() is high (> 15) (gocyclo)
  • Line 364: warning: cyclomatic complexity 23 of function parseTimeseriesHLLResult() is high (> 15) (gocyclo)
  • Line 1028: warning: cyclomatic complexity 20 of function traverseRecursive() is high (> 15) (gocyclo)

• aresdb/metastore/validator.go
  • Line 80: warning: cyclomatic complexity 32 of function (tableSchemaValidatorImpl).validateIndividualSchema() is high (> 15) (gocyclo)
  • Line 186: warning: cyclomatic complexity 24 of function (tableSchemaValidatorImpl).validateSchemaUpdate() is high (> 15) (gocyclo)

• aresdb/memstore/schema.go
  • Line 150: warning: cyclomatic complexity 19 of function (*memStoreImpl).applyTableSchema() is high (> 15) (gocyclo)

• aresdb/query/aql_processor.go
  • Line 1455: warning: cyclomatic complexity 23 of function shouldSkipLiveBatchWithFilter() is high (> 15) (gocyclo)
  • Line 49: warning: cyclomatic complexity 19 of function (*AQLQueryContext).ProcessQuery() is high (> 15) (gocyclo)
  • Line 985: warning: cyclomatic complexity 18 of function (*AQLQueryContext).calculateMemoryRequirement() is high (> 15) (gocyclo)
  • Line 163: warning: cyclomatic complexity 18 of function (*AQLQueryContext).processShard() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!