gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• tilt/internal/docker/fake_client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/ignore/path_matcher_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/buildcontrol/live_update_build_and_deployer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/k8s/fake_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/containerupdate/docker_container_updater_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/telemetry/controller_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/k8swatch/event_watch_manager_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/podlogstream/podsource.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/hud/webview/convert_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/build_and_deployer_live_update_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/build_and_deployer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/pkg/model/squash_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/tiltfile/docker_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/kubernetesapply/reconciler_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/build/path_mapping_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/tiltfile/filewatch_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/tiltfile/tiltfile_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/build/boil_runs_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/buildcontrol/build_control_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/store/build_result.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/testdata_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/k8s/watch_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/kubernetesapply/disco_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/store/engine_state.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/pkg/model/logstore/logstore_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/pkg/model/target_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/k8s/registry_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/cmd/controller_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/engine/dockerprune/docker_pruner_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/hud/server/logs_reader_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/hud/renderer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/build/container_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/build/tar_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/controllers/core/kubernetesdiscovery/portforwards_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/hud/printer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/pkg/model/logstore/logstore.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• tilt/internal/k8s/env_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint43%

Golint is a linter for Go source code.

• tilt/internal/store/actions.go
  • Line 15: warning: exported type ErrorAction should have comment or be unexported (golint)
  • Line 19: warning: exported method ErrorAction.Action should have comment or be unexported (golint)
  • Line 21: warning: exported function NewErrorAction should have comment or be unexported (golint)
  • Line 25: warning: exported type LogAction should have comment or be unexported (golint)
  • Line 34: warning: exported method LogAction.Action should have comment or be unexported (golint)
  • Line 36: warning: exported method LogAction.Summarize should have comment or be unexported (golint)
  • Line 40: warning: exported method LogAction.ManifestName should have comment or be unexported (golint)
  • Line 44: warning: exported method LogAction.Level should have comment or be unexported (golint)
  • Line 48: warning: exported method LogAction.Time should have comment or be unexported (golint)
  • Line 52: warning: exported method LogAction.Fields should have comment or be unexported (golint)
  • Line 56: warning: exported method LogAction.Message should have comment or be unexported (golint)
  • Line 60: warning: exported method LogAction.SpanID should have comment or be unexported (golint)
  • Line 68: warning: exported function NewLogAction should have comment or be unexported (golint)
  • Line 79: warning: exported function NewGlobalLogAction should have comment or be unexported (golint)
  • Line 89: warning: exported type K8sEventAction should have comment or be unexported (golint)
  • Line 94: warning: exported method K8sEventAction.Action should have comment or be unexported (golint)
  • Line 96: warning: exported function NewK8sEventAction should have comment or be unexported (golint)
  • Line 100: warning: exported method K8sEventAction.ToLogAction should have comment or be unexported (golint)
  • Line 121: warning: exported type AnalyticsUserOptAction should have comment or be unexported (golint)
  • Line 125: warning: exported method AnalyticsUserOptAction.Action should have comment or be unexported (golint)
  • Line 127: warning: exported type AnalyticsNudgeSurfacedAction should have comment or be unexported (golint)
  • Line 129: warning: exported method AnalyticsNudgeSurfacedAction.Action should have comment or be unexported (golint)
  • Line 131: warning: exported type TiltCloudStatusReceivedAction should have comment or be unexported (golint)
  • Line 139: warning: exported method TiltCloudStatusReceivedAction.Action should have comment or be unexported (golint)
  • Line 141: warning: exported type UserStartedTiltCloudRegistrationAction should have comment or be unexported (golint)
  • Line 143: warning: exported method UserStartedTiltCloudRegistrationAction.Action should have comment or be unexported (golint)
  • Line 145: warning: exported type PanicAction should have comment or be unexported (golint)
  • Line 149: warning: exported method PanicAction.Action should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/log.go
  • Line 11: warning: exported type BuildEntry should have comment or be unexported (golint)
  • Line 17: warning: exported function LogBuildEntry should have comment or be unexported (golint)

• tilt/internal/k8s/helm.go
  • Line 16: warning: comment on exported type HelmKubeClient should be of the form "HelmKubeClient ..." (with optional leading article) (golint)

• tilt/internal/docker/client.go
  • Line 46: warning: exported var BuiltByTiltLabel should have comment or be unexported (golint)
  • Line 64: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
  • Line 102: warning: exported type ExitError should have comment or be unexported (golint)
  • Line 110: warning: exported function IsExitError should have comment or be unexported (golint)
  • Line 119: warning: exported type Cli should have comment or be unexported (golint)
  • Line 129: warning: exported function NewDockerClient should have comment or be unexported (golint)
  • Line 173: warning: exported function SupportedVersion should have comment or be unexported (golint)
  • Line 205: warning: comment on exported function SupportsBuildkit should be of the form "SupportsBuildkit ..." (golint)
  • Line 234: warning: comment on exported function CreateClientOpts should be of the form "CreateClientOpts ..." (golint)
  • Line 373: warning: exported method Cli.CheckConnected should have comment or be unexported (golint)
  • Line 374: warning: exported method Cli.SetOrchestrator should have comment or be unexported (golint)
  • Line 375: warning: exported method Cli.Env should have comment or be unexported (golint)
  • Line 379: warning: exported method Cli.BuilderVersion should have comment or be unexported (golint)
  • Line 383: warning: exported method Cli.ServerVersion should have comment or be unexported (golint)
  • Line 387: warning: exported method Cli.ImagePush should have comment or be unexported (golint)
  • Line 427: warning: exported method Cli.ImageBuild should have comment or be unexported (golint)
  • Line 489: warning: exported method Cli.ContainerRestartNoWait should have comment or be unexported (golint)
  • Line 497: warning: exported method Cli.ExecInContainer should have comment or be unexported (golint)

• tilt/internal/rty/interactive_tester.go
  • Line 29: warning: exported type InteractiveTester should have comment or be unexported (golint)
  • Line 37: warning: exported type ErrorReporter should have comment or be unexported (golint)
  • Line 43: warning: exported function NewInteractiveTester should have comment or be unexported (golint)
  • Line 57: warning: exported method InteractiveTester.T should have comment or be unexported (golint)
  • Line 61: warning: exported method InteractiveTester.Run should have comment or be unexported (golint)
  • Line 331: warning: comment on exported function InitScreenAndRun should be of the form "InitScreenAndRun ..." (golint)

• tilt/internal/analytics/utils.go
  • Line 8: warning: exported function HashMD5 should have comment or be unexported (golint)

• tilt/internal/tiltfile/watch/tiltignore.go
  • Line 15: warning: exported const TiltignoreFileName should have comment or be unexported (golint)
  • Line 17: warning: comment on exported function TiltignorePath should be of the form "TiltignorePath ..." (golint)
  • Line 22: warning: exported function ReadTiltignore should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/buildcontroller.go
  • Line 5: warning: comment on exported function BuildTargets should be of the form "BuildTargets ..." (golint)

• tilt/pkg/model/k8s_target.go
  • Line 13: warning: comment on exported type PodReadinessMode should be of the form "PodReadinessMode ..." (with optional leading article) (golint)
  • Line 20: warning: comment on exported const PodReadinessNone should be of the form "PodReadinessNone ..." (golint)
  • Line 23: warning: comment on exported const PodReadinessWait should be of the form "PodReadinessWait ..." (golint)
  • Line 26: warning: comment on exported const PodReadinessIgnore should be of the form "PodReadinessIgnore ..." (golint)
  • Line 29: warning: exported type K8sTarget should have comment or be unexported (golint)
  • Line 63: warning: exported function NewK8sTargetForTesting should have comment or be unexported (golint)
  • Line 70: warning: exported method K8sTarget.Empty should have comment or be unexported (golint)
  • Line 72: warning: exported method K8sTarget.HasJob should have comment or be unexported (golint)
  • Line 81: warning: exported method K8sTarget.DependencyIDs should have comment or be unexported (golint)
  • Line 85: warning: exported method K8sTarget.RefInjectCounts should have comment or be unexported (golint)
  • Line 89: warning: exported method K8sTarget.Validate should have comment or be unexported (golint)
  • Line 101: warning: exported method K8sTarget.ID should have comment or be unexported (golint)
  • Line 108: warning: comment on exported method K8sTarget.WithDependencyIDs should be of the form "WithDependencyIDs ..." (golint)
  • Line 140: warning: exported method K8sTarget.WithRefInjectCounts should have comment or be unexported (golint)
  • Line 147: warning: exported function ToLiveUpdateOnlyMap should have comment or be unexported (golint)

• tilt/pkg/model/user_config_state.go
  • Line 5: warning: exported type UserConfigState should have comment or be unexported (golint)
  • Line 10: warning: exported function NewUserConfigState should have comment or be unexported (golint)
  • Line 14: warning: exported method UserConfigState.WithArgs should have comment or be unexported (golint)

• tilt/internal/k8s/pod_template.go
  • Line 11: warning: exported const TiltPodTemplateHashLabel should have comment or be unexported (golint)
  • Line 13: warning: exported type PodTemplateSpecHash should have comment or be unexported (golint)
  • Line 15: warning: exported function HashPodTemplateSpec should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function InjectPodTemplateSpecHashes should be of the form "InjectPodTemplateSpecHashes ..." (golint)

• tilt/internal/engine/metrics/wire.go
  • Line 7: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/controllers/core/kubernetesapply/hash.go
  • Line 27: warning: comment on exported function ComputeInputHash should be of the form "ComputeInputHash ..." (golint)

• tilt/internal/cloud/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/controllers/core/kubernetesdiscovery/dispatch.go
  • Line 5: warning: exported type Dispatcher should have comment or be unexported (golint)

• tilt/pkg/logger/logger.go
  • Line 52: warning: exported type LogHandler should have comment or be unexported (golint)
  • Line 56: warning: exported type Level should have comment or be unexported (golint)
  • Line 64: warning: exported method Level.ToProtoID should have comment or be unexported (golint)
  • Line 68: warning: comment on exported method Level.ShouldDisplay should be of the form "ShouldDisplay ..." (golint)
  • Line 74: warning: exported method Level.AsSevereAs should have comment or be unexported (golint)
  • Line 79: warning: exported var NoneLvl should have comment or be unexported (golint)
  • Line 89: warning: exported var LoggerContextKey should have comment or be unexported (golint)
  • Line 91: warning: exported function Get should have comment or be unexported (golint)
  • Line 102: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 120: warning: exported function NewTestLogger should have comment or be unexported (golint)
  • Line 127: warning: exported function WithLogger should have comment or be unexported (golint)
  • Line 139: warning: exported function Blue should have comment or be unexported (golint)
  • Line 140: warning: exported function Yellow should have comment or be unexported (golint)
  • Line 141: warning: exported function Green should have comment or be unexported (golint)
  • Line 142: warning: exported function Red should have comment or be unexported (golint)
  • Line 144: warning: exported function CtxWithLogHandler should have comment or be unexported (golint)
  • Line 150: warning: comment on exported function CtxWithForkedOutput should be of the form "CtxWithForkedOutput ..." (golint)

• tilt/internal/tiltfile/value/doc.go
  • Line 1: warning: package comment should be of the form "Package value ..." (golint)

• tilt/internal/tiltfile/value/name.go
  • Line 10: warning: comment on exported type Name should be of the form "Name ..." (with optional leading article) (golint)
  • Line 18: warning: exported method Name.Unpack should have comment or be unexported (golint)

• tilt/internal/tiltfile/metrics.go
  • Line 17: warning: exported var TiltfileExecDuration should have comment or be unexported (golint)
  • Line 22: warning: exported var TiltfileExecDurationDistribution should have comment or be unexported (golint)
  • Line 27: warning: exported var TiltfileExecDurationView should have comment or be unexported (golint)
  • Line 35: warning: exported var TiltfileExecCount should have comment or be unexported (golint)

• tilt/internal/tiltfile/encoding/plugin.go
  • Line 5: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 7: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 24: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/engine/k8swatch/service_watch.go
  • Line 17: warning: exported type ServiceWatcher should have comment or be unexported (golint)
  • Line 26: warning: exported function NewServiceWatcher should have comment or be unexported (golint)
  • Line 45: warning: exported method ServiceWatcher.OnChange should have comment or be unexported (golint)
  • Line 146: warning: exported function DispatchServiceChange should have comment or be unexported (golint)

• tilt/internal/container/helpers.go
  • Line 5: warning: exported function FamiliarString should have comment or be unexported (golint)

• tilt/internal/controllers/core/podlogstream/podlogstreamcontroller.go
  • Line 33: warning: comment on exported type Controller should be of the form "Controller ..." (with optional leading article) (golint)
  • Line 57: warning: exported function NewController should have comment or be unexported (golint)
  • Line 108: warning: exported method Controller.TearDown should have comment or be unexported (golint)
  • Line 108: warning: receiver name c should be consistent with previous receiver name m for Controller (golint)
  • Line 131: warning: receiver name r should be consistent with previous receiver name m for Controller (golint)
  • Line 255: warning: receiver name c should be consistent with previous receiver name m for Controller (golint)
  • Line 376: warning: receiver name r should be consistent with previous receiver name m for Controller (golint)
  • Line 411: warning: receiver name r should be consistent with previous receiver name m for Controller (golint)
  • Line 431: warning: receiver name r should be consistent with previous receiver name m for Controller (golint)
  • Line 459: warning: exported method Controller.CreateBuilder should have comment or be unexported (golint)
  • Line 459: warning: receiver name c should be consistent with previous receiver name m for Controller (golint)
  • Line 467: warning: exported type PodLogWatch should have comment or be unexported (golint)

• tilt/internal/controllers/core/filewatch/action.go
  • Line 17: warning: exported type FileWatchUpdateStatusAction should have comment or be unexported (golint)
  • Line 22: warning: exported method FileWatchUpdateStatusAction.Summarize should have comment or be unexported (golint)
  • Line 26: warning: exported method FileWatchUpdateStatusAction.Action should have comment or be unexported (golint)
  • Line 28: warning: exported function NewFileWatchUpdateStatusAction should have comment or be unexported (golint)
  • Line 32: warning: exported function HandleFileWatchUpdateStatusEvent should have comment or be unexported (golint)

• tilt/internal/k8s/json_path.go
  • Line 9: warning: comment on exported type JSONPath should be of the form "JSONPath ..." (with optional leading article) (golint)
  • Line 17: warning: exported function NewJSONPath should have comment or be unexported (golint)
  • Line 30: warning: comment on exported method JSONPath.FindStrings should be of the form "FindStrings ..." (golint)
  • Line 44: warning: comment on exported method JSONPath.VisitStrings should be of the form "VisitStrings ..." (golint)

• tilt/internal/docker/state.go
  • Line 5: warning: comment on exported const ZeroTime should be of the form "ZeroTime ..." (golint)
  • Line 8: warning: exported function HasStarted should have comment or be unexported (golint)
  • Line 12: warning: exported function HasFinished should have comment or be unexported (golint)

• tilt/internal/store/subscriber.go
  • Line 14: warning: exported const MaxBackoff should have comment or be unexported (golint)
  • Line 16: warning: comment on exported type Subscriber should be of the form "Subscriber ..." (with optional leading article) (golint)
  • Line 36: warning: comment on exported type SetUpper should be of the form "SetUpper ..." (with optional leading article) (golint)
  • Line 49: warning: exported type TearDowner should have comment or be unexported (golint)
  • Line 53: warning: comment on exported type SubscriberLifecycle should be of the form "SubscriberLifecycle ..." (with optional leading article) (golint)

• tilt/internal/dockerfile/ast.go
  • Line 21: warning: exported type AST should have comment or be unexported (golint)
  • Line 26: warning: exported function ParseAST should have comment or be unexported (golint)
  • Line 135: warning: exported method AST.InjectImageDigest should have comment or be unexported (golint)
  • Line 147: warning: comment on exported method AST.Traverse should be of the form "Traverse ..." (golint)
  • Line 163: warning: exported method AST.Print should have comment or be unexported (golint)

• tilt/internal/hud/server/server.go
  • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 15: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 30: warning: exported const TiltTokenCookieName should have comment or be unexported (golint)
  • Line 52: warning: exported type HeadsUpServer should have comment or be unexported (golint)
  • Line 62: warning: exported function ProvideHeadsUpServer should have comment or be unexported (golint)
  • Line 116: warning: exported method HeadsUpServer.Router should have comment or be unexported (golint)
  • Line 120: warning: exported method HeadsUpServer.ViewJSON should have comment or be unexported (golint)
  • Line 136: warning: comment on exported method HeadsUpServer.DumpEngineJSON should be of the form "DumpEngineJSON ..." (golint)
  • Line 148: warning: exported method HeadsUpServer.SnapshotJSON should have comment or be unexported (golint)
  • Line 165: warning: exported method HeadsUpServer.HandleAnalyticsOpt should have comment or be unexported (golint)
  • Line 193: warning: exported method HeadsUpServer.HandleAnalytics should have comment or be unexported (golint)
  • Line 218: warning: exported method HeadsUpServer.HandleSetTiltfileArgs should have comment or be unexported (golint)
  • Line 228: warning: exported method HeadsUpServer.HandleTrigger should have comment or be unexported (golint)
  • Line 255: warning: exported function SendToTriggerQueue should have comment or be unexported (golint)
  • Line 267: warning: exported method HeadsUpServer.HandleOverrideTriggerMode should have comment or be unexported (golint)
  • Line 305: warning: exported method HeadsUpServer.HandleNewSnapshot should have comment or be unexported (golint)

• tilt/pkg/assets/dev.go
  • Line 52: warning: exported function NewDevServer should have comment or be unexported (golint)

• tilt/internal/container/container.go
  • Line 11: warning: exported type ID should have comment or be unexported (golint)
  • Line 12: warning: exported type Name should have comment or be unexported (golint)
  • Line 14: warning: exported method ID.Empty should have comment or be unexported (golint)
  • Line 16: warning: exported method ID.ShortStr should have comment or be unexported (golint)
  • Line 23: warning: exported function ShortStrs should have comment or be unexported (golint)
  • Line 33: warning: exported function ParseNamed should have comment or be unexported (golint)
  • Line 37: warning: exported function ParseNamedMulti should have comment or be unexported (golint)
  • Line 49: warning: exported function ParseNamedTagged should have comment or be unexported (golint)
  • Line 62: warning: exported function MustParseNamedTagged should have comment or be unexported (golint)
  • Line 70: warning: exported function MustParseNamed should have comment or be unexported (golint)
  • Line 78: warning: exported function MustWithTag should have comment or be unexported (golint)
  • Line 86: warning: exported function NewIDSet should have comment or be unexported (golint)

• tilt/pkg/model/build_status.go
  • Line 7: warning: exported const BuildHistoryLimit should have comment or be unexported (golint)
  • Line 9: warning: exported type BuildType should have comment or be unexported (golint)
  • Line 11: warning: exported const BuildTypeImage should have comment or be unexported (golint)
  • Line 12: warning: exported const BuildTypeLiveUpdate should have comment or be unexported (golint)
  • Line 13: warning: exported const BuildTypeDockerCompose should have comment or be unexported (golint)
  • Line 14: warning: exported const BuildTypeK8s should have comment or be unexported (golint)
  • Line 15: warning: exported const BuildTypeLocal should have comment or be unexported (golint)
  • Line 17: warning: exported type BuildRecord should have comment or be unexported (golint)
  • Line 34: warning: exported method BuildRecord.Empty should have comment or be unexported (golint)
  • Line 38: warning: exported method BuildRecord.Duration should have comment or be unexported (golint)
  • Line 48: warning: exported method BuildRecord.HasBuildType should have comment or be unexported (golint)
  • Line 48: warning: receiver name r should be consistent with previous receiver name bs for BuildRecord (golint)

• tilt/internal/controllers/core/filewatch/controller.go
  • Line 53: warning: exported function NewController should have comment or be unexported (golint)
  • Line 63: warning: exported method Controller.Reconcile should have comment or be unexported (golint)
  • Line 91: warning: exported method Controller.CreateBuilder should have comment or be unexported (golint)

• tilt/pkg/model/target_graph.go
  • Line 5: warning: exported type TargetGraph should have comment or be unexported (golint)
  • Line 11: warning: exported function NewTargetGraph should have comment or be unexported (golint)
  • Line 23: warning: comment on exported method TargetGraph.IsSingleSourceDAG should be of the form "IsSingleSourceDAG ..." (golint)
  • Line 45: warning: comment on exported method TargetGraph.VisitTree should be of the form "VisitTree ..." (golint)
  • Line 79: warning: comment on exported method TargetGraph.DepsOf should be of the form "DepsOf ..." (golint)
  • Line 93: warning: comment on exported method TargetGraph.IsDeployedImage should be of the form "IsDeployedImage ..." (golint)
  • Line 110: warning: exported method TargetGraph.Images should have comment or be unexported (golint)
  • Line 114: warning: comment on exported method TargetGraph.DeployedImages should be of the form "DeployedImages ..." (golint)

• tilt/internal/testutils/manifestutils/manifest.go
  • Line 9: warning: exported function NewManifestTargetWithPod should have comment or be unexported (golint)

• tilt/internal/tiltfile/version/version.go
  • Line 14: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 18: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 24: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 30: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 66: warning: exported function MustState should have comment or be unexported (golint)
  • Line 74: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/label.go
  • Line 11: warning: exported type LabelValue should have comment or be unexported (golint)
  • Line 13: warning: exported method LabelValue.Unpack should have comment or be unexported (golint)
  • Line 45: warning: exported type LabelSet should have comment or be unexported (golint)

• tilt/internal/engine/runtimelog/reader.go
  • Line 10: warning: comment on exported type HardCancelReader should be of the form "HardCancelReader ..." (with optional leading article) (golint)
  • Line 21: warning: exported function NewHardCancelReader should have comment or be unexported (golint)
  • Line 25: warning: exported method HardCancelReader.LastReadTime should have comment or be unexported (golint)

• tilt/internal/controllers/core/portforward/types.go
  • Line 9: warning: exported type PortForward should have comment or be unexported (golint)
  • Line 10: warning: exported type PortForwardSpec should have comment or be unexported (golint)
  • Line 11: warning: exported type PortForwardStatus should have comment or be unexported (golint)
  • Line 12: warning: exported type ObjectMeta should have comment or be unexported (golint)
  • Line 13: warning: exported type Forward should have comment or be unexported (golint)
  • Line 14: warning: exported type ForwardStatus should have comment or be unexported (golint)

• tilt/internal/cloud/cloud_status_manager.go
  • Line 28: warning: exported const TiltTokenHeaderName should have comment or be unexported (golint)
  • Line 29: warning: exported const TiltTeamIDNameHeaderName should have comment or be unexported (golint)
  • Line 31: warning: exported function NewStatusManager should have comment or be unexported (golint)
  • Line 42: warning: exported type CloudStatusManager should have comment or be unexported (golint)
  • Line 55: warning: exported function ProvideHttpClient should have comment or be unexported (golint)
  • Line 59: warning: exported type HttpClient should have comment or be unexported (golint)
  • Line 80: warning: exported method CloudStatusManager.CheckStatus should have comment or be unexported (golint)
  • Line 173: warning: exported method CloudStatusManager.OnChange should have comment or be unexported (golint)

• tilt/internal/hud/server/token.go
  • Line 8: warning: exported type BearerToken should have comment or be unexported (golint)
  • Line 10: warning: comment on exported function NewBearerToken should be of the form "NewBearerToken ..." (golint)

• tilt/pkg/model/metrics.go
  • Line 5: warning: exported var DefaultReportingPeriod should have comment or be unexported (golint)
  • Line 7: warning: comment on exported type MetricsSettings should be of the form "MetricsSettings ..." (with optional leading article) (golint)
  • Line 24: warning: exported function DefaultMetricsSettings should have comment or be unexported (golint)
  • Line 32: warning: comment on exported type MetricsMode should be of the form "MetricsMode ..." (with optional leading article) (golint)
  • Line 35: warning: exported const MetricsDefault should have comment or be unexported (golint)
  • Line 36: warning: exported const MetricsDisabled should have comment or be unexported (golint)
  • Line 37: warning: exported const MetricsLocal should have comment or be unexported (golint)
  • Line 38: warning: exported const MetricsProd should have comment or be unexported (golint)

• tilt/internal/engine/runtimelog/docker_compose_log_manager.go
  • Line 17: warning: comment on exported type DockerComposeLogManager should be of the form "DockerComposeLogManager ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewDockerComposeLogManager should have comment or be unexported (golint)
  • Line 94: warning: exported method DockerComposeLogManager.OnChange should have comment or be unexported (golint)
  • Line 146: warning: exported type DockerComposeLogActionWriter should have comment or be unexported (golint)
  • Line 201: warning: exported function SpanIDForDCService should have comment or be unexported (golint)

• tilt/internal/engine/uisession/subscriber.go
  • Line 17: warning: exported type Subscriber should have comment or be unexported (golint)
  • Line 21: warning: exported function NewSubscriber should have comment or be unexported (golint)
  • Line 25: warning: exported method Subscriber.OnChange should have comment or be unexported (golint)

• tilt/internal/engine/k8swatch/reducers.go
  • Line 21: warning: exported function HandleKubernetesDiscoveryUpdateStatusAction should have comment or be unexported (golint)
  • Line 25: warning: exported function UpdateK8sRuntimeState should have comment or be unexported (golint)
  • Line 113: warning: exported function CheckForContainerCrash should have comment or be unexported (golint)

• tilt/internal/analytics/tilt_analytics.go
  • Line 9: warning: exported const TagVersion should have comment or be unexported (golint)
  • Line 10: warning: exported const TagOS should have comment or be unexported (golint)
  • Line 11: warning: exported const TagGitRepoHash should have comment or be unexported (golint)
  • Line 12: warning: exported const TagSubcommand should have comment or be unexported (golint)
  • Line 14: warning: comment on exported type TiltAnalytics should be of the form "TiltAnalytics ..." (with optional leading article) (golint)
  • Line 39: warning: exported function NewTiltAnalytics should have comment or be unexported (golint)
  • Line 60: warning: comment on exported function NewMemoryTiltAnalyticsForTest should be of the form "NewMemoryTiltAnalyticsForTest ..." (golint)
  • Line 72: warning: exported method TiltAnalytics.GlobalTag should have comment or be unexported (golint)
  • Line 75: warning: exported method TiltAnalytics.MachineHash should have comment or be unexported (golint)
  • Line 79: warning: exported method TiltAnalytics.GitRepoHash should have comment or be unexported (golint)
  • Line 83: warning: exported method TiltAnalytics.Count should have comment or be unexported (golint)
  • Line 89: warning: exported method TiltAnalytics.Incr should have comment or be unexported (golint)
  • Line 95: warning: exported method TiltAnalytics.Timer should have comment or be unexported (golint)
  • Line 101: warning: exported method TiltAnalytics.Flush should have comment or be unexported (golint)
  • Line 105: warning: exported method TiltAnalytics.UserOpt should have comment or be unexported (golint)
  • Line 109: warning: exported method TiltAnalytics.TiltfileOpt should have comment or be unexported (golint)
  • Line 113: warning: exported method TiltAnalytics.EffectiveOpt should have comment or be unexported (golint)
  • Line 123: warning: exported method TiltAnalytics.SetUserOpt should have comment or be unexported (golint)
  • Line 131: warning: exported method TiltAnalytics.SetTiltfileOpt should have comment or be unexported (golint)
  • Line 135: warning: exported method TiltAnalytics.WithoutGlobalTags should have comment or be unexported (golint)

• tilt/internal/hud/tabview.go
  • Line 13: warning: exported type TabView should have comment or be unexported (golint)
  • Line 19: warning: exported function NewTabView should have comment or be unexported (golint)
  • Line 27: warning: exported method TabView.Build should have comment or be unexported (golint)

• tilt/internal/controllers/core/uisession/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/cli/client/config.go
  • Line 11: warning: exported type TiltClientConfig should have comment or be unexported (golint)
  • Line 13: warning: comment on exported function ProvideClientConfig should be of the form "ProvideClientConfig ..." (golint)

• tilt/internal/cli/tiltfile_result.go
  • Line 22: warning: comment on exported const TiltfileErrExitCode should be of the form "TiltfileErrExitCode ..." (golint)

• tilt/internal/store/tiltfiles/reducers.go
  • Line 8: warning: exported function HandleTiltfileUpsertAction should have comment or be unexported (golint)
  • Line 29: warning: exported function HandleTiltfileDeleteAction should have comment or be unexported (golint)

• tilt/internal/testutils/context.go
  • Line 28: warning: exported function ForkedCtxAndAnalyticsWithOpterForTest should have comment or be unexported (golint)
  • Line 38: warning: comment on exported function ForkedCtxAndAnalyticsForTest should be of the form "ForkedCtxAndAnalyticsForTest ..." (golint)
  • Line 45: warning: exported function FailOnNonCanceledErr should have comment or be unexported (golint)

• tilt/internal/cli/client/getter.go
  • Line 40: warning: comment on exported type Getter should be of the form "Getter ..." (with optional leading article) (golint)
  • Line 47: warning: exported function NewGetter should have comment or be unexported (golint)
  • Line 89: warning: exported method Getter.ToRESTMapper should have comment or be unexported (golint)

• tilt/internal/build/tag.go
  • Line 3: warning: comment on exported var ImageTagPrefix should be of the form "ImageTagPrefix ..." (golint)

• tilt/internal/k8s/fake_client.go
  • Line 25: warning: comment on exported const MagicTestContainerID should be of the form "MagicTestContainerID ..." (golint)
  • Line 35: warning: comment on exported type PodAndCName should be of the form "PodAndCName ..." (with optional leading article) (golint)
  • Line 41: warning: exported type FakeK8sClient should have comment or be unexported (golint)
  • Line 97: warning: exported type ExecCall should have comment or be unexported (golint)
  • Line 123: warning: exported method FakeK8sClient.UpsertService should have comment or be unexported (golint)
  • Line 137: warning: exported method FakeK8sClient.UpsertPod should have comment or be unexported (golint)
  • Line 150: warning: exported method FakeK8sClient.UpsertEvent should have comment or be unexported (golint)
  • Line 164: warning: exported method FakeK8sClient.PodFromInformerCache should have comment or be unexported (golint)
  • Line 174: warning: exported method FakeK8sClient.WatchServices should have comment or be unexported (golint)
  • Line 212: warning: exported method FakeK8sClient.WatchEvents should have comment or be unexported (golint)
  • Line 255: warning: exported method FakeK8sClient.WatchMeta should have comment or be unexported (golint)
  • Line 259: warning: exported method FakeK8sClient.EmitPodDelete should have comment or be unexported (golint)
  • Line 273: warning: exported method FakeK8sClient.WatchPods should have comment or be unexported (golint)
  • Line 311: warning: exported function NewFakeK8sClient should have comment or be unexported (golint)
  • Line 323: warning: exported method FakeK8sClient.TearDown should have comment or be unexported (golint)
  • Line 347: warning: exported method FakeK8sClient.Upsert should have comment or be unexported (golint)
  • Line 373: warning: exported method FakeK8sClient.Delete should have comment or be unexported (golint)
  • Line 408: warning: exported method FakeK8sClient.GetMetaByReference should have comment or be unexported (golint)
  • Line 421: warning: exported method FakeK8sClient.ListMeta should have comment or be unexported (golint)
  • Line 444: warning: exported method FakeK8sClient.SetLogsForPodContainer should have comment or be unexported (golint)
  • Line 449: warning: exported method FakeK8sClient.SetLogReaderForPodContainer should have comment or be unexported (golint)
  • Line 456: warning: exported method FakeK8sClient.ContainerLogs should have comment or be unexported (golint)
  • Line 480: warning: exported function FakePodStatus should have comment or be unexported (golint)
  • Line 501: warning: exported function FakePodSpec should have comment or be unexported (golint)
  • Line 521: warning: exported method FakeK8sClient.CreatePortForwarder should have comment or be unexported (golint)
  • Line 526: warning: exported method FakeK8sClient.ContainerRuntime should have comment or be unexported (golint)
  • Line 536: warning: exported method FakeK8sClient.LocalRegistry should have comment or be unexported (golint)
  • Line 543: warning: exported method FakeK8sClient.NodeIP should have comment or be unexported (golint)
  • Line 550: warning: exported method FakeK8sClient.Exec should have comment or be unexported (golint)
  • Line 585: warning: exported type ReaderCloser should have comment or be unexported (golint)
  • Line 589: warning: exported method ReaderCloser.Close should have comment or be unexported (golint)
  • Line 595: warning: exported type FakePortForwarder should have comment or be unexported (golint)
  • Line 605: warning: exported function NewFakePortForwarder should have comment or be unexported (golint)
  • Line 615: warning: exported method FakePortForwarder.Addresses should have comment or be unexported (golint)
  • Line 619: warning: exported method FakePortForwarder.LocalPort should have comment or be unexported (golint)
  • Line 622: warning: exported method FakePortForwarder.Namespace should have comment or be unexported (golint)
  • Line 626: warning: exported method FakePortForwarder.ForwardPorts should have comment or be unexported (golint)
  • Line 644: warning: exported method FakePortForwarder.ReadyCh should have comment or be unexported (golint)
  • Line 653: warning: exported type FakePortForwardClient should have comment or be unexported (golint)
  • Line 658: warning: exported function NewFakePortForwardClient should have comment or be unexported (golint)
  • Line 664: warning: exported type PortForwardCall should have comment or be unexported (golint)
  • Line 672: warning: exported method FakePortForwardClient.CreatePortForwarder should have comment or be unexported (golint)
  • Line 688: warning: exported method FakePortForwardClient.CreatePortForwardCallCount should have comment or be unexported (golint)
  • Line 694: warning: exported method FakePortForwardClient.LastForwardPortPodID should have comment or be unexported (golint)
  • Line 703: warning: exported method FakePortForwardClient.LastForwardPortRemotePort should have comment or be unexported (golint)
  • Line 712: warning: exported method FakePortForwardClient.LastForwardPortHost should have comment or be unexported (golint)
  • Line 721: warning: exported method FakePortForwardClient.LastForwarder should have comment or be unexported (golint)
  • Line 730: warning: exported method FakePortForwardClient.LastForwardContext should have comment or be unexported (golint)
  • Line 739: warning: exported method FakePortForwardClient.PortForwardCalls should have comment or be unexported (golint)

• tilt/internal/k8s/image.go
  • Line 15: warning: comment on exported function InjectImagePullPolicy should be of the form "InjectImagePullPolicy ..." (golint)
  • Line 30: warning: comment on exported function InjectImageDigest should be of the form "InjectImageDigest ..." (golint)
  • Line 134: warning: exported function InjectCommandAndArgs should have comment or be unexported (golint)
  • Line 206: warning: exported method K8sEntity.FindImages should have comment or be unexported (golint)
  • Line 259: warning: exported function PodContainsRef should have comment or be unexported (golint)
  • Line 268: warning: exported function FindImageRefMatching should have comment or be unexported (golint)
  • Line 282: warning: exported function FindImageNamedTaggedMatching should have comment or be unexported (golint)

• tilt/internal/tiltfile/analytics/analytics.go
  • Line 11: warning: exported type Settings should have comment or be unexported (golint)
  • Line 16: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 19: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 23: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 30: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 85: warning: exported function MustState should have comment or be unexported (golint)
  • Line 93: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/rty/error.go
  • Line 3: warning: comment on exported type ErrorHandler should be of the form "ErrorHandler ..." (with optional leading article) (golint)
  • Line 13: warning: exported type SkipErrorHandler should have comment or be unexported (golint)
  • Line 15: warning: exported method SkipErrorHandler.Errorf should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/duration.go
  • Line 10: warning: comment on exported type Duration should be of the form "Duration ..." (with optional leading article) (golint)
  • Line 13: warning: exported method Duration.IsZero should have comment or be unexported (golint)
  • Line 17: warning: exported method Duration.AsDuration should have comment or be unexported (golint)
  • Line 21: warning: exported method Duration.Unpack should have comment or be unexported (golint)

• tilt/internal/controllers/core/cmd/probe_fake.go
  • Line 12: warning: exported function NewFakeProberManager should have comment or be unexported (golint)
  • Line 16: warning: exported type FakeProberManager should have comment or be unexported (golint)
  • Line 29: warning: exported method FakeProberManager.HTTPGet should have comment or be unexported (golint)
  • Line 36: warning: exported method FakeProberManager.TCPSocket should have comment or be unexported (golint)
  • Line 43: warning: exported method FakeProberManager.Exec should have comment or be unexported (golint)
  • Line 50: warning: exported method FakeProberManager.ProbeCount should have comment or be unexported (golint)

• tilt/internal/k8s/exec.go
  • Line 14: warning: exported method K8sClient.Exec should have comment or be unexported (golint)

• tilt/internal/tiltfile/config/resources.go
  • Line 46: warning: comment on exported method Settings.EnabledResources should be of the form "EnabledResources ..." (golint)

• tilt/internal/engine/buildcontrol/build_and_deployer.go
  • Line 10: warning: exported type BuildAndDeployer should have comment or be unexported (golint)

• tilt/internal/container/reference.go
  • Line 28: warning: exported function NewRefSet should have comment or be unexported (golint)
  • Line 36: warning: exported function MustSimpleRefSet should have comment or be unexported (golint)
  • Line 46: warning: exported method RefSet.WithoutRegistry should have comment or be unexported (golint)
  • Line 50: warning: exported method RefSet.Registry should have comment or be unexported (golint)
  • Line 54: warning: exported method RefSet.MustWithRegistry should have comment or be unexported (golint)
  • Line 63: warning: exported method RefSet.Validate should have comment or be unexported (golint)
  • Line 144: warning: comment on exported type TaggedRefs should be of the form "TaggedRefs ..." (with optional leading article) (golint)

• tilt/internal/controllers/core/filewatch/fsevent/fake.go
  • Line 9: warning: exported type FakeTimerMaker should have comment or be unexported (golint)
  • Line 15: warning: exported method FakeTimerMaker.Maker should have comment or be unexported (golint)
  • Line 40: warning: exported function MakeFakeTimerMaker should have comment or be unexported (golint)

• tilt/internal/tiltfile/dockerprune/docker_prune.go
  • Line 14: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 22: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 31: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 77: warning: exported function MustState should have comment or be unexported (golint)
  • Line 85: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/store/mode.go
  • Line 3: warning: comment on exported type EngineMode should be of the form "EngineMode ..." (with optional leading article) (golint)
  • Line 18: warning: exported method EngineMode.WatchesFiles should have comment or be unexported (golint)
  • Line 22: warning: exported method EngineMode.WatchesRuntime should have comment or be unexported (golint)
  • Line 26: warning: exported method EngineMode.IsCIMode should have comment or be unexported (golint)

• tilt/internal/feature/flags.go
  • Line 7: warning: comment on exported type Status should be of the form "Status ..." (with optional leading article) (golint)
  • Line 15: warning: exported const Active should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported const MultipleContainersPerPod should have comment or be unexported (golint)
  • Line 22: warning: exported const Events should have comment or be unexported (golint)
  • Line 23: warning: exported const Snapshots should have comment or be unexported (golint)
  • Line 24: warning: exported const UpdateHistory should have comment or be unexported (golint)
  • Line 25: warning: exported const Facets should have comment or be unexported (golint)
  • Line 26: warning: exported const Labels should have comment or be unexported (golint)
  • Line 69: warning: comment on exported function FromDefaults should be of the form "FromDefaults ..." (golint)

• tilt/pkg/model/label_pair.go
  • Line 3: warning: exported type LabelPair should have comment or be unexported (golint)
  • Line 8: warning: exported function ToLabelPairs should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/uisession_types.go
  • Line 51: warning: comment on exported type UISessionList should be of the form "UISessionList ..." (with optional leading article) (golint)
  • Line 69: warning: exported method UISession.GetObjectMeta should have comment or be unexported (golint)
  • Line 73: warning: exported method UISession.NamespaceScoped should have comment or be unexported (golint)
  • Line 77: warning: exported method UISession.New should have comment or be unexported (golint)
  • Line 81: warning: exported method UISession.NewList should have comment or be unexported (golint)
  • Line 85: warning: exported method UISession.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 93: warning: exported method UISession.IsStorageVersion should have comment or be unexported (golint)
  • Line 97: warning: exported method UISession.Validate should have comment or be unexported (golint)
  • Line 104: warning: exported method UISessionList.GetListMeta should have comment or be unexported (golint)
  • Line 178: warning: exported method UISession.GetStatus should have comment or be unexported (golint)
  • Line 185: warning: exported method UISessionStatus.CopyTo should have comment or be unexported (golint)
  • Line 189: warning: comment on exported type UIFeatureFlag should be of the form "UIFeatureFlag ..." (with optional leading article) (golint)
  • Line 208: warning: comment on exported type TiltBuild should be of the form "TiltBuild ..." (with optional leading article) (golint)
  • Line 227: warning: comment on exported type VersionSettings should be of the form "VersionSettings ..." (with optional leading article) (golint)

• tilt/pkg/assets/precompiled.go
  • Line 22: warning: exported function NewPrecompiledServer should have comment or be unexported (golint)

• tilt/internal/k8s/portforward/portforward.go
  • Line 185: warning: exported method PortForwarder.Addresses should have comment or be unexported (golint)

• tilt/internal/user/wire.go
  • Line 7: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/ignore/ephemeral.go
  • Line 8: warning: comment on exported var EphemeralPathMatcher should be of the form "EphemeralPathMatcher ..." (golint)

• tilt/internal/controllers/manager.go
  • Line 19: warning: exported type UncachedObjects should have comment or be unexported (golint)
  • Line 21: warning: exported function ProvideUncachedObjects should have comment or be unexported (golint)
  • Line 25: warning: exported type TiltServerControllerManager should have comment or be unexported (golint)
  • Line 39: warning: exported function NewTiltServerControllerManager should have comment or be unexported (golint)
  • Line 48: warning: exported method TiltServerControllerManager.GetManager should have comment or be unexported (golint)
  • Line 52: warning: exported method TiltServerControllerManager.GetClient should have comment or be unexported (golint)
  • Line 59: warning: exported method TiltServerControllerManager.SetUp should have comment or be unexported (golint)
  • Line 123: warning: exported method TiltServerControllerManager.TearDown should have comment or be unexported (golint)

• tilt/internal/controllers/apicmp/delta.go
  • Line 16: warning: exported function Comparators should have comment or be unexported (golint)
  • Line 41: warning: exported function DeepEqual should have comment or be unexported (golint)

• tilt/internal/controllers/fake/fake.go
  • Line 10: warning: exported function NewFakeTiltClient should have comment or be unexported (golint)

• tilt/internal/store/sleep.go
  • Line 8: warning: exported type Sleeper should have comment or be unexported (golint)
  • Line 24: warning: exported function DefaultSleeper should have comment or be unexported (golint)

• tilt/internal/cli/flags.go
  • Line 73: warning: exported function ProvideKubeContextOverride should have comment or be unexported (golint)
  • Line 77: warning: exported function ProvideNamespaceOverride should have comment or be unexported (golint)

• tilt/pkg/assets/context.go
  • Line 8: warning: exported type PublicPathPrefixContextKey should have comment or be unexported (golint)

• tilt/internal/k8s/pod.go
  • Line 14: warning: exported method K8sClient.ContainerLogs should have comment or be unexported (golint)
  • Line 26: warning: exported function PodIDFromPod should have comment or be unexported (golint)

• tilt/internal/analytics/env.go
  • Line 19: warning: comment on exported function IsAnalyticsDisabledFromEnv should be of the form "IsAnalyticsDisabledFromEnv ..." (golint)

• tilt/internal/hud/server/actions.go
  • Line 7: warning: exported type AppendToTriggerQueueAction should have comment or be unexported (golint)
  • Line 12: warning: exported method AppendToTriggerQueueAction.Action should have comment or be unexported (golint)
  • Line 14: warning: exported type SetTiltfileArgsAction should have comment or be unexported (golint)
  • Line 18: warning: exported method SetTiltfileArgsAction.Action should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type OverrideTriggerModeAction should be of the form "OverrideTriggerModeAction ..." (with optional leading article) (golint)
  • Line 26: warning: exported method OverrideTriggerModeAction.Action should have comment or be unexported (golint)

• tilt/internal/controllers/core/cmd/execer.go
  • Line 21: warning: exported var DefaultGracePeriod should have comment or be unexported (golint)
  • Line 23: warning: exported type Execer should have comment or be unexported (golint)
  • Line 36: warning: exported type FakeExecer should have comment or be unexported (golint)
  • Line 42: warning: exported function NewFakeExecer should have comment or be unexported (golint)
  • Line 48: warning: exported method FakeExecer.Start should have comment or be unexported (golint)
  • Line 115: warning: exported method FakeExecer.RequireNoKnownProcess should have comment or be unexported (golint)
  • Line 115: warning: receiver name fe should be consistent with previous receiver name e for FakeExecer (golint)
  • Line 125: warning: exported function ProvideExecer should have comment or be unexported (golint)
  • Line 134: warning: exported function NewProcessExecer should have comment or be unexported (golint)

• tilt/internal/controllers/indexer/indexer.go
  • Line 15: warning: comment on exported type Key should be of the form "Key ..." (with optional leading article) (golint)
  • Line 21: warning: exported type KeyFunc should have comment or be unexported (golint)
  • Line 23: warning: comment on exported type Indexer should be of the form "Indexer ..." (with optional leading article) (golint)
  • Line 44: warning: exported function NewIndexer should have comment or be unexported (golint)
  • Line 52: warning: comment on exported method Indexer.OnReconcile should be of the form "OnReconcile ..." (golint)
  • Line 74: warning: comment on exported method Indexer.Enqueue should be of the form "Enqueue ..." (golint)
  • Line 88: warning: comment on exported method Indexer.EnqueueKey should be of the form "EnqueueKey ..." (golint)

• tilt/internal/tiltfile/tiltextension/plugin.go
  • Line 1: warning: package comment should be of the form "Package tiltextension ..." (golint)
  • Line 19: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 24: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 31: warning: exported type State should have comment or be unexported (golint)
  • Line 35: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 41: warning: exported type Fetcher should have comment or be unexported (golint)
  • Line 46: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 63: warning: exported method Plugin.LocalPath should have comment or be unexported (golint)
  • Line 105: warning: exported function MustState should have comment or be unexported (golint)
  • Line 113: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/doc.go
  • Line 1: warning: package comment should be of the form "Package starkit ..." (golint)

• tilt/internal/store/reducer.go
  • Line 5: warning: exported type Reducer should have comment or be unexported (golint)
  • Line 7: warning: exported var EmptyReducer should have comment or be unexported (golint)

• tilt/internal/ignore/path_matcher.go
  • Line 22: warning: comment on exported function CreateBuildContextFilter should be of the form "CreateBuildContextFilter ..." (golint)
  • Line 44: warning: exported type IgnorableTarget should have comment or be unexported (golint)
  • Line 52: warning: comment on exported function IgnoresToMatcher should be of the form "IgnoresToMatcher ..." (golint)
  • Line 78: warning: comment on exported function TargetToFileWatchIgnores should be of the form "TargetToFileWatchIgnores ..." (golint)
  • Line 103: warning: comment on exported function CreateFileChangeFilter should be of the form "CreateFileChangeFilter ..." (golint)
  • Line 108: warning: exported type DirectoryMatcher should have comment or be unexported (golint)
  • Line 114: warning: exported function NewDirectoryMatcher should have comment or be unexported (golint)
  • Line 122: warning: exported method DirectoryMatcher.Dir should have comment or be unexported (golint)
  • Line 126: warning: exported method DirectoryMatcher.Matches should have comment or be unexported (golint)
  • Line 130: warning: exported method DirectoryMatcher.MatchesEntireDir should have comment or be unexported (golint)

• tilt/internal/k8s/label.go
  • Line 16: warning: exported function InjectLabels should have comment or be unexported (golint)
  • Line 20: warning: exported function OverwriteLabels should have comment or be unexported (golint)

• tilt/internal/k8s/minikube_fake.go
  • Line 5: warning: exported type FakeMinikube should have comment or be unexported (golint)
  • Line 10: warning: exported method FakeMinikube.Version should have comment or be unexported (golint)
  • Line 14: warning: exported method FakeMinikube.DockerEnv should have comment or be unexported (golint)
  • Line 18: warning: exported method FakeMinikube.NodeIP should have comment or be unexported (golint)

• tilt/internal/ospath/display.go
  • Line 5: warning: comment on exported function FileDisplayName should be of the form "FileDisplayName ..." (golint)
  • Line 18: warning: comment on exported function FileListDisplayNames should be of the form "FileListDisplayNames ..." (golint)
  • Line 30: warning: exported function FormatFileChangeList should have comment or be unexported (golint)

• tilt/internal/rty/canvas.go
  • Line 11: warning: exported type Canvas should have comment or be unexported (golint)
  • Line 33: warning: exported type TempCanvas should have comment or be unexported (golint)
  • Line 54: warning: exported method TempCanvas.Size should have comment or be unexported (golint)
  • Line 58: warning: exported method TempCanvas.Close should have comment or be unexported (golint)
  • Line 73: warning: exported method TempCanvas.SetContent should have comment or be unexported (golint)
  • Line 89: warning: exported method TempCanvas.GetContent should have comment or be unexported (golint)
  • Line 103: warning: exported type SubCanvas should have comment or be unexported (golint)
  • Line 148: warning: exported method SubCanvas.Size should have comment or be unexported (golint)
  • Line 152: warning: exported method SubCanvas.Close should have comment or be unexported (golint)
  • Line 159: warning: exported method SubCanvas.SetContent should have comment or be unexported (golint)
  • Line 191: warning: exported method SubCanvas.GetContent should have comment or be unexported (golint)
  • Line 195: warning: exported type ScreenCanvas should have comment or be unexported (golint)
  • Line 206: warning: exported method ScreenCanvas.Size should have comment or be unexported (golint)
  • Line 210: warning: exported method ScreenCanvas.SetContent should have comment or be unexported (golint)
  • Line 217: warning: exported method ScreenCanvas.Close should have comment or be unexported (golint)
  • Line 221: warning: exported method ScreenCanvas.GetContent should have comment or be unexported (golint)

• tilt/internal/tiltfile/sys/sys.go
  • Line 11: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 17: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 21: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/analytics/fake.go
  • Line 11: warning: exported type FakeOpter should have comment or be unexported (golint)
  • Line 17: warning: exported function NewFakeOpter should have comment or be unexported (golint)
  • Line 21: warning: exported function DefaultFakeOpter should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeOpter.ReadUserOpt should have comment or be unexported (golint)
  • Line 34: warning: exported method FakeOpter.SetUserOpt should have comment or be unexported (golint)
  • Line 41: warning: exported method FakeOpter.Calls should have comment or be unexported (golint)
  • Line 47: warning: exported method FakeOpter.WaitUntilCount should have comment or be unexported (golint)

• tilt/internal/build/options.go
  • Line 11: warning: exported function Options should have comment or be unexported (golint)

• tilt/pkg/assets/fake.go
  • Line 11: warning: exported function NewFakeServer should have comment or be unexported (golint)

• tilt/pkg/model/telemetry_settings.go
  • Line 5: warning: exported const DefaultTelemetryPeriod should have comment or be unexported (golint)
  • Line 7: warning: exported type TelemetrySettings should have comment or be unexported (golint)

• tilt/internal/user/fake.go
  • Line 3: warning: exported function NewFakePrefs should have comment or be unexported (golint)
  • Line 7: warning: exported type FakePrefs should have comment or be unexported (golint)
  • Line 11: warning: exported method FakePrefs.Get should have comment or be unexported (golint)
  • Line 15: warning: exported method FakePrefs.Update should have comment or be unexported (golint)

• tilt/internal/container/ignore.go
  • Line 3: warning: exported const IstioInitContainerName should have comment or be unexported (golint)
  • Line 4: warning: exported const IstioSidecarContainerName should have comment or be unexported (golint)

• tilt/internal/user/helpers.go
  • Line 5: warning: exported function UpdateMetricsMode should have comment or be unexported (golint)

• tilt/pkg/model/secret_settings.go
  • Line 3: warning: exported type SecretSettings should have comment or be unexported (golint)
  • Line 7: warning: exported function DefaultSecretSettings should have comment or be unexported (golint)

• tilt/internal/k8s/uid.go
  • Line 5: warning: exported type UIDSet should have comment or be unexported (golint)
  • Line 7: warning: exported function NewUIDSet should have comment or be unexported (golint)
  • Line 15: warning: exported method UIDSet.Add should have comment or be unexported (golint)
  • Line 21: warning: exported method UIDSet.Contains should have comment or be unexported (golint)

• tilt/internal/user/api.go
  • Line 5: warning: comment on exported type Prefs should be of the form "Prefs ..." (with optional leading article) (golint)
  • Line 13: warning: comment on exported type PrefsInterface should be of the form "PrefsInterface ..." (with optional leading article) (golint)

• tilt/internal/dockerfile/inject.go
  • Line 9: warning: exported function InjectImageDigest should have comment or be unexported (golint)

• tilt/internal/dockercompose/event.go
  • Line 9: warning: exported type Event should have comment or be unexported (golint)
  • Line 18: warning: exported type Attributes should have comment or be unexported (golint)
  • Line 23: warning: exported function EventFromJsonStr should have comment or be unexported (golint)
  • Line 32: warning: comment on exported type Type should be of the form "Type ..." (with optional leading article) (golint)
  • Line 36: warning: comment on exported const TypeUnknown should be of the form "TypeUnknown ..." (golint)
  • Line 38: warning: exported const TypeContainer should have comment (or a comment on this block) or be unexported (golint)
  • Line 54: warning: exported method Type.MarshalJSON should have comment or be unexported (golint)
  • Line 59: warning: exported method Type.UnmarshalJSON should have comment or be unexported (golint)
  • Line 70: warning: exported type Action should have comment or be unexported (golint)
  • Line 75: warning: comment on exported const ActionUnknown should be of the form "ActionUnknown ..." (golint)
  • Line 77: warning: exported const ActionAttach should have comment (or a comment on this block) or be unexported (golint)
  • Line 137: warning: exported method Action.MarshalJSON should have comment or be unexported (golint)
  • Line 142: warning: exported method Action.UnmarshalJSON should have comment or be unexported (golint)

• tilt/internal/controllers/core/podlogstream/types.go
  • Line 9: warning: exported type PodLogStream should have comment or be unexported (golint)
  • Line 10: warning: exported type PodLogStreamSpec should have comment or be unexported (golint)
  • Line 11: warning: exported type PodLogStreamStatus should have comment or be unexported (golint)
  • Line 12: warning: exported type ContainerLogStreamStatus should have comment or be unexported (golint)
  • Line 13: warning: exported type ObjectMeta should have comment or be unexported (golint)

• tilt/internal/tiltfile/encoding/starlark.go
  • Line 10: warning: exported function ConvertStructuredDataToStarlark should have comment or be unexported (golint)

• tilt/internal/engine/parse.go
  • Line 8: warning: exported function ParseYAMLFromManifests should have comment or be unexported (golint)

• tilt/internal/k8s/encoder.go
  • Line 60: warning: exported type TypeIndex should have comment or be unexported (golint)
  • Line 62: warning: exported method TypeIndex.Contains should have comment or be unexported (golint)

• tilt/pkg/model/telemetry_state.go
  • Line 7: warning: exported type TelemetryStatus should have comment or be unexported (golint)

• tilt/pkg/model/version_settings.go
  • Line 3: warning: exported type VersionSettings should have comment or be unexported (golint)

• tilt/internal/k8s/extract.go
  • Line 11: warning: exported function ExtractPods should have comment or be unexported (golint)
  • Line 28: warning: exported function ExtractPodTemplateSpec should have comment or be unexported (golint)
  • Line 213: warning: exported var NoFilter should have comment or be unexported (golint)

• tilt/pkg/model/globalyaml.go
  • Line 3: warning: comment on exported const UnresourcedYAMLManifestName should be of the form "UnresourcedYAMLManifestName ..." (golint)

• tilt/internal/engine/buildcontrol/actions.go
  • Line 11: warning: exported type BuildStartedAction should have comment or be unexported (golint)
  • Line 20: warning: exported method BuildStartedAction.Action should have comment or be unexported (golint)
  • Line 22: warning: exported type BuildCompleteAction should have comment or be unexported (golint)
  • Line 30: warning: exported method BuildCompleteAction.Action should have comment or be unexported (golint)
  • Line 32: warning: exported function NewBuildCompleteAction should have comment or be unexported (golint)

• tilt/internal/controllers/core/filewatch/fsevent/factories.go
  • Line 10: warning: exported type WatcherMaker should have comment or be unexported (golint)
  • Line 12: warning: exported type TimerMaker should have comment or be unexported (golint)
  • Line 14: warning: exported function ProvideWatcherMaker should have comment or be unexported (golint)
  • Line 20: warning: exported function ProvideTimerMaker should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/kubernetesapply_types.go
  • Line 34: warning: exported const KubernetesApplyTimeoutDefault should have comment or be unexported (golint)
  • Line 68: warning: comment on exported type KubernetesApplyList should be of the form "KubernetesApplyList ..." (with optional leading article) (golint)
  • Line 152: warning: exported method KubernetesApply.GetSpec should have comment or be unexported (golint)
  • Line 156: warning: exported method KubernetesApply.GetObjectMeta should have comment or be unexported (golint)
  • Line 160: warning: exported method KubernetesApply.NamespaceScoped should have comment or be unexported (golint)
  • Line 164: warning: exported method KubernetesApply.ShortNames should have comment or be unexported (golint)
  • Line 168: warning: exported method KubernetesApply.New should have comment or be unexported (golint)
  • Line 172: warning: exported method KubernetesApply.NewList should have comment or be unexported (golint)
  • Line 176: warning: exported method KubernetesApply.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 184: warning: exported method KubernetesApply.IsStorageVersion should have comment or be unexported (golint)
  • Line 188: warning: exported method KubernetesApply.Validate should have comment or be unexported (golint)
  • Line 211: warning: exported method KubernetesApplyList.GetListMeta should have comment or be unexported (golint)
  • Line 253: warning: exported method KubernetesApply.GetStatus should have comment or be unexported (golint)
  • Line 260: warning: exported method KubernetesApplyStatus.CopyTo should have comment or be unexported (golint)
  • Line 264: warning: comment on exported type KubernetesImageLocator should be of the form "KubernetesImageLocator ..." (with optional leading article) (golint)
  • Line 284: warning: exported type KubernetesImageObjectDescriptor should have comment or be unexported (golint)
  • Line 292: warning: exported type KubernetesDiscoveryTemplateSpec should have comment or be unexported (golint)
  • Line 301: warning: exported type KubernetesDiscoveryStrategy should have comment or be unexported (golint)
  • Line 304: warning: comment on exported var KubernetesDiscoveryStrategyDefault should be of the form "KubernetesDiscoveryStrategyDefault ..." (golint)
  • Line 309: warning: comment on exported var KubernetesDiscoveryStrategySelectorsOnly should be of the form "KubernetesDiscoveryStrategySelectorsOnly ..." (golint)

• tilt/pkg/model/update_settings.go
  • Line 10: warning: exported const DefaultMaxParallelUpdates should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported type UpdateSettings should have comment or be unexported (golint)
  • Line 18: warning: exported method UpdateSettings.MaxParallelUpdates should have comment or be unexported (golint)
  • Line 26: warning: exported method UpdateSettings.WithMaxParallelUpdates should have comment or be unexported (golint)
  • Line 35: warning: exported method UpdateSettings.K8sUpsertTimeout should have comment or be unexported (golint)
  • Line 43: warning: exported method UpdateSettings.WithK8sUpsertTimeout should have comment or be unexported (golint)
  • Line 52: warning: exported function DefaultUpdateSettings should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/function.go
  • Line 5: warning: exported type Function should have comment or be unexported (golint)

• tilt/internal/containerupdate/docker_container_updater.go
  • Line 20: warning: exported type DockerUpdater should have comment or be unexported (golint)
  • Line 26: warning: exported function NewDockerUpdater should have comment or be unexported (golint)
  • Line 30: warning: exported method DockerUpdater.WillBuildToKubeContext should have comment or be unexported (golint)
  • Line 34: warning: exported method DockerUpdater.UpdateContainer should have comment or be unexported (golint)

• tilt/internal/hud/edits.go
  • Line 11: warning: exported type EditStatusLineComponent should have comment or be unexported (golint)
  • Line 17: warning: exported function NewEditStatusLine should have comment or be unexported (golint)
  • Line 23: warning: exported method EditStatusLineComponent.Size should have comment or be unexported (golint)
  • Line 81: warning: exported method EditStatusLineComponent.Render should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/portforward_types.go
  • Line 36: warning: comment on exported type PortForward should be of the form "PortForward ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported type PortForwardList should be of the form "PortForwardList ..." (with optional leading article) (golint)
  • Line 92: warning: exported method PortForward.GetObjectMeta should have comment or be unexported (golint)
  • Line 96: warning: exported method PortForward.NamespaceScoped should have comment or be unexported (golint)
  • Line 100: warning: exported method PortForward.ShortNames should have comment or be unexported (golint)
  • Line 104: warning: exported method PortForward.New should have comment or be unexported (golint)
  • Line 108: warning: exported method PortForward.NewList should have comment or be unexported (golint)
  • Line 112: warning: exported method PortForward.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 120: warning: exported method PortForward.IsStorageVersion should have comment or be unexported (golint)
  • Line 124: warning: exported method PortForward.Validate should have comment or be unexported (golint)
  • Line 164: warning: exported method PortForwardList.GetListMeta should have comment or be unexported (golint)
  • Line 173: warning: exported type ForwardStatus should have comment or be unexported (golint)
  • Line 198: warning: exported method PortForward.GetStatus should have comment or be unexported (golint)
  • Line 205: warning: exported method PortForwardStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/cli/cli.go
  • Line 35: warning: exported function Execute should have comment or be unexported (golint)

• tilt/internal/store/build_result.go
  • Line 19: warning: comment on exported type BuildResult should be of the form "BuildResult ..." (with optional leading article) (golint)
  • Line 37: warning: exported type LocalBuildResult should have comment or be unexported (golint)
  • Line 41: warning: exported method LocalBuildResult.TargetID should have comment or be unexported (golint)
  • Line 42: warning: exported method LocalBuildResult.BuildType should have comment or be unexported (golint)
  • Line 44: warning: exported function NewLocalBuildResult should have comment or be unexported (golint)
  • Line 50: warning: exported type ImageBuildResult should have comment or be unexported (golint)
  • Line 66: warning: exported method ImageBuildResult.TargetID should have comment or be unexported (golint)
  • Line 67: warning: exported method ImageBuildResult.BuildType should have comment or be unexported (golint)
  • Line 69: warning: comment on exported function NewImageBuildResult should be of the form "NewImageBuildResult ..." (golint)
  • Line 81: warning: comment on exported function NewImageBuildResultSingleRef should be of the form "NewImageBuildResultSingleRef ..." (golint)
  • Line 86: warning: exported type LiveUpdateBuildResult should have comment or be unexported (golint)
  • Line 96: warning: exported method LiveUpdateBuildResult.TargetID should have comment or be unexported (golint)
  • Line 97: warning: exported method LiveUpdateBuildResult.BuildType should have comment or be unexported (golint)
  • Line 99: warning: comment on exported function NewLiveUpdateBuildResult should be of the form "NewLiveUpdateBuildResult ..." (golint)
  • Line 107: warning: exported type DockerComposeBuildResult should have comment or be unexported (golint)
  • Line 122: warning: exported method DockerComposeBuildResult.TargetID should have comment or be unexported (golint)
  • Line 123: warning: exported method DockerComposeBuildResult.BuildType should have comment or be unexported (golint)
  • Line 125: warning: comment on exported function NewDockerComposeDeployResult should be of the form "NewDockerComposeDeployResult ..." (golint)
  • Line 134: warning: exported type K8sBuildResult should have comment or be unexported (golint)
  • Line 146: warning: exported method K8sBuildResult.TargetID should have comment or be unexported (golint)
  • Line 147: warning: exported method K8sBuildResult.BuildType should have comment or be unexported (golint)
  • Line 159: warning: exported function LocalImageRefFromBuildResult should have comment or be unexported (golint)
  • Line 167: warning: exported function ClusterImageRefFromBuildResult should have comment or be unexported (golint)
  • Line 175: warning: exported type BuildResultSet should have comment or be unexported (golint)
  • Line 177: warning: exported method BuildResultSet.LiveUpdatedContainerIDs should have comment or be unexported (golint)
  • Line 188: warning: exported method BuildResultSet.DeployedEntities should have comment or be unexported (golint)
  • Line 202: warning: exported method BuildResultSet.DeployedPodTemplateSpecHashes should have comment or be unexported (golint)
  • Line 213: warning: exported function MergeBuildResultsSet should have comment or be unexported (golint)
  • Line 224: warning: exported method BuildResultSet.BuildTypes should have comment or be unexported (golint)
  • Line 238: warning: comment on exported method BuildResultSet.OneAndOnlyLiveUpdatedContainerID should be of the form "OneAndOnlyLiveUpdatedContainerID ..." (golint)
  • Line 270: warning: comment on exported type ImageBuildResultSet should be of the form "ImageBuildResultSet ..." (with optional leading article) (golint)
  • Line 273: warning: exported method ImageBuildResultSet.ToBuildResultSet should have comment or be unexported (golint)
  • Line 281: warning: comment on exported type BuildState should be of the form "BuildState ..." (with optional leading article) (golint)
  • Line 317: warning: exported function NewBuildState should have comment or be unexported (golint)
  • Line 333: warning: exported method BuildState.WithRunningContainers should have comment or be unexported (golint)
  • Line 338: warning: exported method BuildState.WithRunningContainerError should have comment or be unexported (golint)
  • Line 343: warning: exported method BuildState.WithFullBuildTriggered should have comment or be unexported (golint)
  • Line 348: warning: comment on exported method BuildState.OneContainerInfo should be of the form "OneContainerInfo ..." (golint)
  • Line 356: warning: exported method BuildState.LastLocalImageAsString should have comment or be unexported (golint)
  • Line 364: warning: comment on exported method BuildState.FilesChanged should be of the form "FilesChanged ..." (golint)
  • Line 376: warning: comment on exported method BuildState.IsEmpty should be of the form "IsEmpty ..." (golint)
  • Line 381: warning: exported method BuildState.HasLastResult should have comment or be unexported (golint)
  • Line 385: warning: comment on exported method BuildState.NeedsImageBuild should be of the form "NeedsImageBuild ..." (golint)
  • Line 397: warning: exported type BuildStateSet should have comment or be unexported (golint)
  • Line 399: warning: exported method BuildStateSet.FullBuildTriggered should have comment or be unexported (golint)
  • Line 408: warning: exported method BuildStateSet.Empty should have comment or be unexported (golint)
  • Line 412: warning: exported method BuildStateSet.FilesChanged should have comment or be unexported (golint)
  • Line 428: warning: comment on exported type ContainerInfo should be of the form "ContainerInfo ..." (with optional leading article) (golint)
  • Line 436: warning: exported method ContainerInfo.Empty should have comment or be unexported (golint)
  • Line 440: warning: exported function IDsForInfos should have comment or be unexported (golint)
  • Line 448: warning: exported function AllRunningContainers should have comment or be unexported (golint)
  • Line 468: warning: comment on exported function RunningContainersForTargetForOnePod should be of the form "RunningContainersForTargetForOnePod ..." (golint)
  • Line 519: warning: exported function RunningContainersForDC should have comment or be unexported (golint)
  • Line 525: warning: exported var BuildStateClean should have comment or be unexported (golint)

• tilt/internal/dockercompose/fake_client.go
  • Line 18: warning: exported type FakeDCClient should have comment or be unexported (golint)
  • Line 34: warning: comment on exported type UpCall should be of the form "UpCall ..." (with optional leading article) (golint)
  • Line 41: warning: context.Context should be the first parameter of a function (golint)
  • Line 41: warning: exported function NewFakeDockerComposeClient should have comment or be unexported (golint)
  • Line 50: warning: exported method FakeDCClient.Up should have comment or be unexported (golint)
  • Line 56: warning: exported method FakeDCClient.Down should have comment or be unexported (golint)
  • Line 65: warning: exported method FakeDCClient.StreamLogs should have comment or be unexported (golint)
  • Line 87: warning: exported method FakeDCClient.StreamEvents should have comment or be unexported (golint)
  • Line 108: warning: exported method FakeDCClient.SendEvent should have comment or be unexported (golint)
  • Line 117: warning: exported method FakeDCClient.Config should have comment or be unexported (golint)
  • Line 121: warning: exported method FakeDCClient.Project should have comment or be unexported (golint)
  • Line 132: warning: exported method FakeDCClient.ContainerID should have comment or be unexported (golint)

• tilt/internal/hud/prompt/wire.go
  • Line 7: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/kubernetesdiscovery_types.go
  • Line 37: warning: comment on exported type KubernetesDiscovery should be of the form "KubernetesDiscovery ..." (with optional leading article) (golint)
  • Line 47: warning: comment on exported type KubernetesDiscoveryList should be of the form "KubernetesDiscoveryList ..." (with optional leading article) (golint)
  • Line 155: warning: exported method KubernetesDiscovery.GetObjectMeta should have comment or be unexported (golint)
  • Line 159: warning: exported method KubernetesDiscovery.NamespaceScoped should have comment or be unexported (golint)
  • Line 163: warning: exported method KubernetesDiscovery.ShortNames should have comment or be unexported (golint)
  • Line 167: warning: exported method KubernetesDiscovery.New should have comment or be unexported (golint)
  • Line 171: warning: exported method KubernetesDiscovery.NewList should have comment or be unexported (golint)
  • Line 175: warning: exported method KubernetesDiscovery.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 183: warning: exported method KubernetesDiscovery.IsStorageVersion should have comment or be unexported (golint)
  • Line 187: warning: exported method KubernetesDiscovery.Validate should have comment or be unexported (golint)
  • Line 203: warning: exported method KubernetesDiscoveryList.GetListMeta should have comment or be unexported (golint)
  • Line 221: warning: exported method KubernetesDiscovery.GetStatus should have comment or be unexported (golint)
  • Line 228: warning: exported method KubernetesDiscoveryStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/rty/scroll.go
  • Line 7: warning: exported type StatefulComponent should have comment or be unexported (golint)
  • Line 11: warning: exported type TextScrollLayout should have comment or be unexported (golint)
  • Line 18: warning: exported function NewTextScrollLayout should have comment or be unexported (golint)
  • Line 22: warning: exported method TextScrollLayout.Add should have comment or be unexported (golint)
  • Line 26: warning: exported method TextScrollLayout.Size should have comment or be unexported (golint)
  • Line 30: warning: exported type TextScrollState should have comment or be unexported (golint)
  • Line 44: warning: exported method TextScrollLayout.Render should have comment or be unexported (golint)
  • Line 49: warning: exported method TextScrollLayout.RenderStateful should have comment or be unexported (golint)
  • Line 190: warning: exported type TextScrollController should have comment or be unexported (golint)
  • Line 194: warning: exported method TextScrollController.Top should have comment or be unexported (golint)
  • Line 203: warning: exported method TextScrollController.Bottom should have comment or be unexported (golint)
  • Line 207: warning: exported method TextScrollController.Up should have comment or be unexported (golint)
  • Line 223: warning: exported method TextScrollController.Down should have comment or be unexported (golint)
  • Line 249: warning: exported method TextScrollController.ToggleFollow should have comment or be unexported (golint)
  • Line 253: warning: exported method TextScrollController.SetFollow should have comment or be unexported (golint)
  • Line 257: warning: exported function NewScrollingWrappingTextArea should have comment or be unexported (golint)
  • Line 266: warning: exported type ElementScrollLayout should have comment or be unexported (golint)
  • Line 273: warning: exported function NewElementScrollLayout should have comment or be unexported (golint)
  • Line 277: warning: exported method ElementScrollLayout.Add should have comment or be unexported (golint)
  • Line 281: warning: exported method ElementScrollLayout.Size should have comment or be unexported (golint)
  • Line 285: warning: exported type ElementScrollState should have comment or be unexported (golint)
  • Line 296: warning: exported method ElementScrollLayout.Render should have comment or be unexported (golint)
  • Line 301: warning: exported method ElementScrollLayout.RenderStateful should have comment or be unexported (golint)
  • Line 399: warning: exported type ElementScrollController should have comment or be unexported (golint)
  • Line 439: warning: exported method ElementScrollController.GetSelectedIndex should have comment or be unexported (golint)
  • Line 443: warning: exported method ElementScrollController.GetSelectedChild should have comment or be unexported (golint)
  • Line 450: warning: exported method ElementScrollController.Up should have comment or be unexported (golint)
  • Line 458: warning: exported method ElementScrollController.Down should have comment or be unexported (golint)
  • Line 465: warning: exported method ElementScrollController.Top should have comment or be unexported (golint)
  • Line 469: warning: exported method ElementScrollController.Bottom should have comment or be unexported (golint)

• tilt/internal/tiltfile/os/environ_methods.go
  • Line 65: warning: don't use underscores in Go names; func environ_get should be environGet (golint)
  • Line 81: warning: don't use underscores in Go names; func environ_clear should be environClear (golint)
  • Line 89: warning: don't use underscores in Go names; func environ_items should be environItems (golint)
  • Line 102: warning: don't use underscores in Go names; func environ_keys should be environKeys (golint)
  • Line 110: warning: don't use underscores in Go names; func environ_pop should be environPop (golint)
  • Line 126: warning: don't use underscores in Go names; func environ_popitem should be environPopitem (golint)
  • Line 144: warning: don't use underscores in Go names; func environ_setdefault should be environSetdefault (golint)
  • Line 162: warning: don't use underscores in Go names; func environ_update should be environUpdate (golint)
  • Line 239: warning: don't use underscores in Go names; func environ_values should be environValues (golint)

• tilt/integration/tilt.go
  • Line 23: warning: exported type TiltDriver should have comment or be unexported (golint)
  • Line 30: warning: exported type TiltDriverOption should have comment or be unexported (golint)
  • Line 32: warning: exported function TiltDriverUseRandomFreePort should have comment or be unexported (golint)
  • Line 39: warning: exported function NewTiltDriver should have comment or be unexported (golint)
  • Line 76: warning: exported method TiltDriver.DumpEngine should have comment or be unexported (golint)
  • Line 81: warning: exported method TiltDriver.Down should have comment or be unexported (golint)
  • Line 86: warning: exported method TiltDriver.CI should have comment or be unexported (golint)
  • Line 100: warning: exported method TiltDriver.Up should have comment or be unexported (golint)
  • Line 136: warning: exported method TiltDriver.Args should have comment or be unexported (golint)
  • Line 141: warning: exported method TiltDriver.APIResources should have comment or be unexported (golint)
  • Line 156: warning: exported method TiltDriver.Get should have comment or be unexported (golint)
  • Line 164: warning: exported type TiltUpResponse should have comment or be unexported (golint)
  • Line 172: warning: exported method TiltUpResponse.Done should have comment or be unexported (golint)
  • Line 176: warning: exported method TiltUpResponse.Err should have comment or be unexported (golint)
  • Line 182: warning: exported method TiltUpResponse.Kill should have comment or be unexported (golint)
  • Line 189: warning: comment on exported method TiltUpResponse.KillAndDumpThreads should be of the form "KillAndDumpThreads ..." (golint)

• tilt/internal/controllers/core/uibutton/reconciler.go
  • Line 18: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 25: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 32: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
  • Line 54: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)

• tilt/internal/k8s/runtime.go
  • Line 60: warning: exported method K8sClient.ContainerRuntime should have comment or be unexported (golint)
  • Line 64: warning: exported function ProvideContainerRuntime should have comment or be unexported (golint)

• tilt/internal/hud/view/view.go
  • Line 13: warning: exported const LogLineCount should have comment or be unexported (golint)
  • Line 15: warning: exported const TiltfileResourceName should have comment or be unexported (golint)
  • Line 17: warning: exported type ResourceInfoView should have comment or be unexported (golint)
  • Line 24: warning: exported type DCResourceInfo should have comment or be unexported (golint)
  • Line 33: warning: exported function NewDCResourceInfo should have comment or be unexported (golint)
  • Line 47: warning: exported method DCResourceInfo.RuntimeSpanID should have comment or be unexported (golint)
  • Line 48: warning: exported method DCResourceInfo.Status should have comment or be unexported (golint)
  • Line 51: warning: exported method DCResourceInfo.RuntimeStatus should have comment or be unexported (golint)
  • Line 53: warning: exported type K8sResourceInfo should have comment or be unexported (golint)
  • Line 67: warning: exported method K8sResourceInfo.RuntimeSpanID should have comment or be unexported (golint)
  • Line 68: warning: exported method K8sResourceInfo.Status should have comment or be unexported (golint)
  • Line 69: warning: exported method K8sResourceInfo.RuntimeStatus should have comment or be unexported (golint)
  • Line 71: warning: comment on exported type TiltfileResourceInfo should be of the form "TiltfileResourceInfo ..." (with optional leading article) (golint)
  • Line 78: warning: exported method TiltfileResourceInfo.RuntimeSpanID should have comment or be unexported (golint)
  • Line 79: warning: exported method TiltfileResourceInfo.Status should have comment or be unexported (golint)
  • Line 80: warning: exported method TiltfileResourceInfo.RuntimeStatus should have comment or be unexported (golint)
  • Line 84: warning: exported type YAMLResourceInfo should have comment or be unexported (golint)
  • Line 91: warning: exported method YAMLResourceInfo.RuntimeSpanID should have comment or be unexported (golint)
  • Line 92: warning: exported method YAMLResourceInfo.Status should have comment or be unexported (golint)
  • Line 93: warning: exported method YAMLResourceInfo.RuntimeStatus should have comment or be unexported (golint)
  • Line 97: warning: exported type LocalResourceInfo should have comment or be unexported (golint)
  • Line 103: warning: exported function NewLocalResourceInfo should have comment or be unexported (golint)
  • Line 110: warning: exported method LocalResourceInfo.RuntimeSpanID should have comment or be unexported (golint)
  • Line 111: warning: exported method LocalResourceInfo.Status should have comment or be unexported (golint)
  • Line 112: warning: exported method LocalResourceInfo.RuntimeStatus should have comment or be unexported (golint)
  • Line 114: warning: exported type Resource should have comment or be unexported (golint)
  • Line 133: warning: exported method Resource.DockerComposeTarget should have comment or be unexported (golint)
  • Line 142: warning: exported method Resource.DCInfo should have comment or be unexported (golint)
  • Line 147: warning: exported method Resource.IsDC should have comment or be unexported (golint)
  • Line 152: warning: exported method Resource.K8sInfo should have comment or be unexported (golint)
  • Line 157: warning: exported method Resource.IsK8s should have comment or be unexported (golint)
  • Line 162: warning: exported method Resource.YAMLInfo should have comment or be unexported (golint)
  • Line 167: warning: exported method Resource.IsYAML should have comment or be unexported (golint)
  • Line 172: warning: exported method Resource.LastBuild should have comment or be unexported (golint)
  • Line 179: warning: exported method Resource.DefaultCollapse should have comment or be unexported (golint)
  • Line 198: warning: exported method Resource.IsCollapsed should have comment or be unexported (golint)
  • Line 202: warning: comment on exported type View should be of the form "View ..." (with optional leading article) (golint)
  • Line 215: warning: exported method View.TiltfileErrorMessage should have comment or be unexported (golint)
  • Line 228: warning: exported method View.Resource should have comment or be unexported (golint)
  • Line 237: warning: exported type ViewState should have comment or be unexported (golint)
  • Line 248: warning: exported type TabState should have comment or be unexported (golint)
  • Line 251: warning: exported const TabAllLog should have comment (or a comment on this block) or be unexported (golint)
  • Line 256: warning: exported type CollapseState should have comment or be unexported (golint)
  • Line 259: warning: exported const CollapseAuto should have comment (or a comment on this block) or be unexported (golint)
  • Line 264: warning: exported method CollapseState.IsCollapsed should have comment or be unexported (golint)
  • Line 275: warning: exported method ViewState.CycleViewLogState should have comment or be unexported (golint)
  • Line 286: warning: exported type TiltLogState should have comment or be unexported (golint)
  • Line 289: warning: exported const TiltLogShort should have comment (or a comment on this block) or be unexported (golint)
  • Line 294: warning: exported type ResourceViewState should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/hold_set.go
  • Line 8: warning: exported type HoldSet should have comment or be unexported (golint)
  • Line 10: warning: exported method HoldSet.RemoveIneligibleTargets should have comment or be unexported (golint)
  • Line 31: warning: exported method HoldSet.AddHold should have comment or be unexported (golint)
  • Line 48: warning: comment on exported method HoldSet.Fill should be of the form "Fill ..." (golint)

• tilt/internal/controllers/core/cmd/controller.go
  • Line 37: warning: comment on exported type Controller should be of the form "Controller ..." (with optional leading article) (golint)
  • Line 58: warning: exported function NewController should have comment or be unexported (golint)
  • Line 72: warning: exported method Controller.Reconcile should have comment or be unexported (golint)
  • Line 96: warning: exported method Controller.TearDown should have comment or be unexported (golint)
  • Line 290: warning: comment on exported method Controller.ForceRun should be of the form "ForceRun ..." (golint)
  • Line 613: warning: exported method Controller.CreateBuilder should have comment or be unexported (golint)
  • Line 613: warning: receiver name r should be consistent with previous receiver name c for Controller (golint)
  • Line 673: warning: exported const Unknown should have comment (or a comment on this block) or be unexported (golint)

• tilt/pkg/apis/identifiers.go
  • Line 19: warning: exported const MaxNameLength should have comment or be unexported (golint)
  • Line 25: warning: exported function Key should have comment or be unexported (golint)
  • Line 29: warning: exported function KeyFromMeta should have comment or be unexported (golint)

• tilt/internal/store/hold.go
  • Line 3: warning: comment on exported type Hold should be of the form "Hold ..." (with optional leading article) (golint)
  • Line 8: warning: exported const HoldNone should have comment (or a comment on this block) or be unexported (golint)

• tilt/internal/store/runtime_state.go
  • Line 18: warning: exported type RuntimeState should have comment or be unexported (golint)
  • Line 38: warning: exported type LocalRuntimeState should have comment or be unexported (golint)
  • Line 51: warning: exported method LocalRuntimeState.RuntimeState should have comment or be unexported (golint)
  • Line 53: warning: exported method LocalRuntimeState.RuntimeStatus should have comment or be unexported (golint)
  • Line 57: warning: exported method LocalRuntimeState.RuntimeStatusError should have comment or be unexported (golint)
  • Line 65: warning: exported method LocalRuntimeState.HasEverBeenReadyOrSucceeded should have comment or be unexported (golint)
  • Line 69: warning: exported type K8sRuntimeState should have comment or be unexported (golint)
  • Line 92: warning: exported method K8sRuntimeState.RuntimeState should have comment or be unexported (golint)
  • Line 96: warning: exported function NewK8sRuntimeStateWithPods should have comment or be unexported (golint)
  • Line 106: warning: exported function NewK8sRuntimeState should have comment or be unexported (golint)
  • Line 117: warning: exported method K8sRuntimeState.RuntimeStatusError should have comment or be unexported (golint)
  • Line 126: warning: exported method K8sRuntimeState.RuntimeStatus should have comment or be unexported (golint)
  • Line 160: warning: exported method K8sRuntimeState.HasEverBeenReadyOrSucceeded should have comment or be unexported (golint)
  • Line 170: warning: exported method K8sRuntimeState.PodLen should have comment or be unexported (golint)
  • Line 174: warning: exported method K8sRuntimeState.ContainsID should have comment or be unexported (golint)
  • Line 179: warning: exported method K8sRuntimeState.PodList should have comment or be unexported (golint)
  • Line 187: warning: comment on exported method K8sRuntimeState.MostRecentPod should be of the form "MostRecentPod ..." (golint)
  • Line 195: warning: exported method K8sRuntimeState.HasOKPodTemplateSpecHash should have comment or be unexported (golint)
  • Line 205: warning: exported method K8sRuntimeState.DeployedUIDSet should have comment or be unexported (golint)
  • Line 223: warning: exported function AllPodContainers should have comment or be unexported (golint)
  • Line 230: warning: exported function AllPodContainersReady should have comment or be unexported (golint)
  • Line 243: warning: exported function AllPodContainerRestarts should have comment or be unexported (golint)
  • Line 251: warning: exported method K8sRuntimeState.VisiblePodContainerRestarts should have comment or be unexported (golint)
  • Line 259: warning: exported function AllPodContainerPorts should have comment or be unexported (golint)
  • Line 267: warning: exported type PodTemplateSpecHashSet should have comment or be unexported (golint)
  • Line 269: warning: exported function NewPodTemplateSpecHashSet should have comment or be unexported (golint)
  • Line 273: warning: exported method PodTemplateSpecHashSet.Add should have comment or be unexported (golint)
  • Line 279: warning: exported method PodTemplateSpecHashSet.Contains should have comment or be unexported (golint)
  • Line 283: warning: exported type PodSet should have comment or be unexported (golint)
  • Line 285: warning: exported method PodSet.MostRecentPod should have comment or be unexported (golint)
  • Line 299: warning: exported method PodSet.Filter should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/path.go
  • Line 9: warning: exported type LocalPath should have comment or be unexported (golint)
  • Line 14: warning: exported function NewLocalPathUnpacker should have comment or be unexported (golint)
  • Line 20: warning: exported method LocalPath.Unpack should have comment or be unexported (golint)
  • Line 30: warning: exported type LocalPathList should have comment or be unexported (golint)
  • Line 35: warning: exported function NewLocalPathListUnpacker should have comment or be unexported (golint)
  • Line 41: warning: exported method LocalPathList.Unpack should have comment or be unexported (golint)

• tilt/internal/engine/configs/configs_controller.go
  • Line 17: warning: exported type ConfigsController should have comment or be unexported (golint)
  • Line 24: warning: exported function NewConfigsController should have comment or be unexported (golint)
  • Line 111: warning: exported method ConfigsController.OnChange should have comment or be unexported (golint)

• tilt/pkg/model/watch_settings.go
  • Line 3: warning: exported type WatchSettings should have comment or be unexported (golint)
  • Line 7: warning: exported method WatchSettings.Empty should have comment or be unexported (golint)
  • Line 11: warning: exported type Dockerignore should have comment or be unexported (golint)
  • Line 22: warning: exported method Dockerignore.Empty should have comment or be unexported (golint)

• tilt/pkg/logger/fields.go
  • Line 3: warning: comment on exported type Fields should be of the form "Fields ..." (with optional leading article) (golint)
  • Line 8: warning: exported const FieldNameProgressID should have comment or be unexported (golint)
  • Line 9: warning: exported const FieldNameBuildEvent should have comment or be unexported (golint)
  • Line 11: warning: comment on exported const FieldNameProgressMustPrint should be of the form "FieldNameProgressMustPrint ..." (golint)

• tilt/web/web.go
  • Line 10: warning: exported function StaticPath should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8scontext/k8scontext.go
  • Line 13: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 20: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 27: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 31: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 80: warning: exported type State should have comment or be unexported (golint)
  • Line 86: warning: exported method State.KubeContext should have comment or be unexported (golint)
  • Line 90: warning: exported method State.IsAllowed should have comment or be unexported (golint)
  • Line 104: warning: exported function MustState should have comment or be unexported (golint)
  • Line 112: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/controllers/core/podlogstream/podsource.go
  • Line 24: warning: comment on exported type PodSource should be of the form "PodSource ..." (with optional leading article) (golint)
  • Line 45: warning: exported function NewPodSource should have comment or be unexported (golint)
  • Line 54: warning: exported method PodSource.Start should have comment or be unexported (golint)
  • Line 62: warning: exported method PodSource.TearDown should have comment or be unexported (golint)

• tilt/internal/engine/build_and_deployer.go
  • Line 19: warning: exported type BuildOrder should have comment or be unexported (golint)
  • Line 34: warning: exported type FallbackTester should have comment or be unexported (golint)
  • Line 47: warning: exported function NewCompositeBuildAndDeployer should have comment or be unexported (golint)
  • Line 51: warning: exported method CompositeBuildAndDeployer.BuildAndDeploy should have comment or be unexported (golint)
  • Line 112: warning: exported function DefaultBuildOrder should have comment or be unexported (golint)

• tilt/internal/engine/build_and_deployer_live_update_test.go
  • Line 141: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/pkg/procutil/procutil_unix.go
  • Line 11: warning: exported function SetOptNewProcessGroup should have comment or be unexported (golint)
  • Line 15: warning: exported function KillProcessGroup should have comment or be unexported (golint)
  • Line 24: warning: exported function GracefullyShutdownProcess should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/error.go
  • Line 13: warning: comment on exported function UnpackBacktrace should be of the form "UnpackBacktrace ..." (golint)

• tilt/internal/build/custom_builder.go
  • Line 20: warning: exported type CustomBuilder should have comment or be unexported (golint)
  • Line 24: warning: exported type ExecCustomBuilder should have comment or be unexported (golint)
  • Line 29: warning: exported function NewExecCustomBuilder should have comment or be unexported (golint)
  • Line 36: warning: exported method ExecCustomBuilder.Build should have comment or be unexported (golint)

• tilt/pkg/model/build_reason.go
  • Line 5: warning: exported type BuildReason should have comment or be unexported (golint)
  • Line 7: warning: exported const BuildReasonNone should have comment or be unexported (golint)
  • Line 10: warning: exported const BuildReasonFlagChangedFiles should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: comment on exported const BuildReasonFlagCrash should be of the form "BuildReasonFlagCrash ..." (golint)
  • Line 22: warning: comment on exported const BuildReasonFlagTiltfileArgs should be of the form "BuildReasonFlagTiltfileArgs ..." (golint)
  • Line 25: warning: comment on exported const BuildReasonFlagChangedDeps should be of the form "BuildReasonFlagChangedDeps ..." (golint)
  • Line 34: warning: exported method BuildReason.With should have comment or be unexported (golint)
  • Line 38: warning: exported method BuildReason.Has should have comment or be unexported (golint)
  • Line 42: warning: exported method BuildReason.HasTrigger should have comment or be unexported (golint)
  • Line 51: warning: exported method BuildReason.IsCrashOnly should have comment or be unexported (golint)

• tilt/pkg/model/logstore/logline.go
  • Line 10: warning: exported type LogLine should have comment or be unexported (golint)

• tilt/internal/testutils/tar.go
  • Line 17: warning: exported type ExpectedFile should have comment or be unexported (golint)
  • Line 42: warning: comment on exported function AssertFileInTar should be of the form "AssertFileInTar ..." (golint)
  • Line 47: warning: comment on exported function AssertFilesInTar should be of the form "AssertFilesInTar ..." (golint)

• tilt/internal/store/k8sconv/doc.go
  • Line 1: warning: package comment should be of the form "Package k8sconv ..." (golint)

• tilt/internal/controllers/core/uiresource/reconciler.go
  • Line 18: warning: comment on exported type Reconciler should be of the form "Reconciler ..." (with optional leading article) (golint)
  • Line 31: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 38: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
  • Line 60: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)

• tilt/pkg/logger/prefixed_logger.go
  • Line 18: warning: exported function NewPrefixedLogger should have comment or be unexported (golint)

• tilt/pkg/model/cmd.go
  • Line 9: warning: exported type Cmd should have comment or be unexported (golint)
  • Line 15: warning: exported method Cmd.IsShellStandardForm should have comment or be unexported (golint)
  • Line 19: warning: exported method Cmd.IsWindowsStandardForm should have comment or be unexported (golint)
  • Line 23: warning: comment on exported method Cmd.ShellStandardScript should be of the form "ShellStandardScript ..." (golint)
  • Line 32: warning: exported method Cmd.EntrypointStr should have comment or be unexported (golint)
  • Line 44: warning: exported method Cmd.RunStr should have comment or be unexported (golint)
  • Line 56: warning: exported function ArgListToString should have comment or be unexported (golint)
  • Line 80: warning: exported method Cmd.Empty should have comment or be unexported (golint)
  • Line 84: warning: comment on exported function ToHostCmd should be of the form "ToHostCmd ..." (golint)
  • Line 95: warning: exported function ToHostCmdInDir should have comment or be unexported (golint)
  • Line 101: warning: exported function ToHostCmdInDirWithEnv should have comment or be unexported (golint)
  • Line 107: warning: comment on exported function ToBatCmd should be of the form "ToBatCmd ..." (golint)
  • Line 118: warning: exported function ToUnixCmd should have comment or be unexported (golint)
  • Line 125: warning: exported function ToUnixCmdInDir should have comment or be unexported (golint)
  • Line 131: warning: exported function ToUnixCmds should have comment or be unexported (golint)
  • Line 139: warning: exported function ToRun should have comment or be unexported (golint)
  • Line 143: warning: exported function ToRuns should have comment or be unexported (golint)

• tilt/internal/engine/analytics/analytics_reporter.go
  • Line 16: warning: exported type AnalyticsReporter should have comment or be unexported (golint)
  • Line 24: warning: exported method AnalyticsReporter.OnChange should have comment or be unexported (golint)
  • Line 60: warning: exported function ProvideAnalyticsReporter should have comment or be unexported (golint)

• tilt/internal/testutils/podbuilder/podbuilder.go
  • Line 23: warning: exported function FakeContainerID should have comment or be unexported (golint)
  • Line 27: warning: exported function FakeContainerIDAtIndex should have comment or be unexported (golint)
  • Line 35: warning: exported function FakeContainerIDSet should have comment or be unexported (golint)
  • Line 43: warning: comment on exported type PodBuilder should be of the form "PodBuilder ..." (with optional leading article) (golint)
  • Line 84: warning: exported function New should have comment or be unexported (golint)
  • Line 97: warning: comment on exported method PodBuilder.WithUnknownOwner should be of the form "WithUnknownOwner ..." (golint)
  • Line 104: warning: exported method PodBuilder.WithPodLabel should have comment or be unexported (golint)
  • Line 109: warning: exported method PodBuilder.ManifestName should have comment or be unexported (golint)
  • Line 113: warning: exported method PodBuilder.WithTemplateSpecHash should have comment or be unexported (golint)
  • Line 118: warning: exported method PodBuilder.WithNoTemplateSpecHash should have comment or be unexported (golint)
  • Line 123: warning: exported method PodBuilder.RestartCount should have comment or be unexported (golint)
  • Line 127: warning: exported method PodBuilder.WithRestartCount should have comment or be unexported (golint)
  • Line 132: warning: exported method PodBuilder.WithResourceVersion should have comment or be unexported (golint)
  • Line 137: warning: exported method PodBuilder.WithPodUID should have comment or be unexported (golint)
  • Line 142: warning: exported method PodBuilder.WithPodName should have comment or be unexported (golint)
  • Line 151: warning: exported method PodBuilder.WithPhase should have comment or be unexported (golint)
  • Line 156: warning: exported method PodBuilder.WithImage should have comment or be unexported (golint)
  • Line 160: warning: exported method PodBuilder.WithImageAtIndex should have comment or be unexported (golint)
  • Line 165: warning: exported method PodBuilder.WithContainerID should have comment or be unexported (golint)
  • Line 169: warning: exported method PodBuilder.WithContainerIDAtIndex should have comment or be unexported (golint)
  • Line 178: warning: exported method PodBuilder.WithContainerReady should have comment or be unexported (golint)
  • Line 182: warning: exported method PodBuilder.WithContainerReadyAtIndex should have comment or be unexported (golint)
  • Line 187: warning: exported method PodBuilder.WithCreationTime should have comment or be unexported (golint)
  • Line 192: warning: exported method PodBuilder.WithDeletionTime should have comment or be unexported (golint)
  • Line 197: warning: exported method PodBuilder.PodName should have comment or be unexported (golint)
  • Line 204: warning: exported method PodBuilder.PodUID should have comment or be unexported (golint)
  • Line 211: warning: exported method PodBuilder.WithDeploymentUID should have comment or be unexported (golint)
  • Line 247: warning: exported method PodBuilder.DeploymentUID should have comment or be unexported (golint)
  • Line 420: warning: exported type PodObjectTree should have comment or be unexported (golint)
  • Line 422: warning: exported method PodObjectTree.Pod should have comment or be unexported (golint)
  • Line 426: warning: exported method PodObjectTree.ReplicaSet should have comment or be unexported (golint)
  • Line 430: warning: exported method PodObjectTree.Deployment should have comment or be unexported (golint)
  • Line 434: warning: comment on exported method PodBuilder.ObjectTreeEntities should be of the form "ObjectTreeEntities ..." (golint)
  • Line 446: warning: exported method PodBuilder.Build should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8s/state.go
  • Line 17: warning: exported function DuplicateYAMLDetectedError should have comment or be unexported (golint)
  • Line 22: warning: exported type ObjectSpec should have comment or be unexported (golint)
  • Line 31: warning: comment on exported type State should be of the form "State ..." (with optional leading article) (golint)
  • Line 37: warning: exported function NewState should have comment or be unexported (golint)
  • Line 43: warning: exported method State.Entities should have comment or be unexported (golint)
  • Line 51: warning: exported method State.EntityCount should have comment or be unexported (golint)
  • Line 55: warning: exported method State.Append should have comment or be unexported (golint)

• tilt/internal/xdg/base.go
  • Line 12: warning: exported type Base should have comment or be unexported (golint)
  • Line 25: warning: exported function NewTiltDevBase should have comment or be unexported (golint)

• tilt/internal/engine/session/controller.go
  • Line 52: warning: exported function NewController should have comment or be unexported (golint)
  • Line 61: warning: exported method Controller.OnChange should have comment or be unexported (golint)

• tilt/internal/yaml/utils.go
  • Line 11: warning: exported function ConcatYAML should have comment or be unexported (golint)

• tilt/internal/store/engine_state.go
  • Line 29: warning: exported type EngineState should have comment or be unexported (golint)
  • Line 128: warning: exported type CloudStatus should have comment or be unexported (golint)
  • Line 135: warning: exported method EngineState.MainTiltfilePath should have comment or be unexported (golint)
  • Line 143: warning: comment on exported method EngineState.AnalyticsEffectiveOpt should be of the form "AnalyticsEffectiveOpt ..." (golint)
  • Line 155: warning: exported method EngineState.ManifestNamesForTargetID should have comment or be unexported (golint)
  • Line 181: warning: exported method EngineState.IsCurrentlyBuilding should have comment or be unexported (golint)
  • Line 185: warning: comment on exported method EngineState.BuildStatus should be of the form "BuildStatus ..." (golint)
  • Line 198: warning: exported method EngineState.AvailableBuildSlots should have comment or be unexported (golint)
  • Line 208: warning: exported method EngineState.UpsertManifestTarget should have comment or be unexported (golint)
  • Line 217: warning: exported method EngineState.RemoveManifestTarget should have comment or be unexported (golint)
  • Line 229: warning: exported method EngineState.Manifest should have comment or be unexported (golint)
  • Line 237: warning: exported method EngineState.ManifestState should have comment or be unexported (golint)
  • Line 250: warning: comment on exported method EngineState.Manifests should be of the form "Manifests ..." (golint)
  • Line 263: warning: comment on exported method EngineState.ManifestStates should be of the form "ManifestStates ..." (golint)
  • Line 276: warning: comment on exported method EngineState.Targets should be of the form "Targets ..." (golint)
  • Line 289: warning: comment on exported method EngineState.GetTiltfileStates should be of the form "GetTiltfileStates ..." (golint)
  • Line 302: warning: exported method EngineState.TargetsBesides should have comment or be unexported (golint)
  • Line 315: warning: exported method EngineState.ManifestInTriggerQueue should have comment or be unexported (golint)
  • Line 324: warning: exported method EngineState.AppendToTriggerQueue should have comment or be unexported (golint)
  • Line 344: warning: exported method EngineState.RemoveFromTriggerQueue should have comment or be unexported (golint)
  • Line 358: warning: exported method EngineState.IsEmpty should have comment or be unexported (golint)
  • Line 362: warning: exported method EngineState.LastMainTiltfileError should have comment or be unexported (golint)
  • Line 371: warning: exported method EngineState.MainTiltfileState should have comment or be unexported (golint)
  • Line 375: warning: exported method EngineState.MainConfigPaths should have comment or be unexported (golint)
  • Line 379: warning: exported method EngineState.HasDockerBuild should have comment or be unexported (golint)
  • Line 390: warning: exported method EngineState.InitialBuildsCompleted should have comment or be unexported (golint)
  • Line 409: warning: comment on exported type BuildStatus should be of the form "BuildStatus ..." (with optional leading article) (golint)
  • Line 442: warning: exported method BuildStatus.IsEmpty should have comment or be unexported (golint)
  • Line 448: warning: exported method BuildStatus.ClearPendingChangesBefore should have comment or be unexported (golint)
  • Line 461: warning: exported type ManifestState should have comment or be unexported (golint)
  • Line 492: warning: exported function NewState should have comment or be unexported (golint)
  • Line 544: warning: exported method ManifestState.TargetID should have comment or be unexported (golint)
  • Line 551: warning: exported method ManifestState.BuildStatus should have comment or be unexported (golint)
  • Line 559: warning: exported method ManifestState.MutableBuildStatus should have comment or be unexported (golint)
  • Line 568: warning: exported method ManifestState.DCRuntimeState should have comment or be unexported (golint)
  • Line 573: warning: exported method ManifestState.IsDC should have comment or be unexported (golint)
  • Line 578: warning: exported method ManifestState.K8sRuntimeState should have comment or be unexported (golint)
  • Line 583: warning: exported method ManifestState.IsK8s should have comment or be unexported (golint)
  • Line 588: warning: exported method ManifestState.LocalRuntimeState should have comment or be unexported (golint)
  • Line 593: warning: exported method ManifestState.ActiveBuild should have comment or be unexported (golint)
  • Line 597: warning: exported method ManifestState.IsBuilding should have comment or be unexported (golint)
  • Line 601: warning: exported method ManifestState.LastBuild should have comment or be unexported (golint)
  • Line 608: warning: exported method ManifestState.AddCompletedBuild should have comment or be unexported (golint)
  • Line 615: warning: exported method ManifestState.StartedFirstBuild should have comment or be unexported (golint)
  • Line 619: warning: exported method ManifestState.MostRecentPod should have comment or be unexported (golint)
  • Line 623: warning: exported method ManifestState.PodWithID should have comment or be unexported (golint)
  • Line 632: warning: exported method ManifestState.AddPendingFileChange should have comment or be unexported (golint)
  • Line 666: warning: exported method ManifestState.HasPendingFileChanges should have comment or be unexported (golint)
  • Line 675: warning: exported method ManifestState.HasPendingDependencyChanges should have comment or be unexported (golint)
  • Line 684: warning: exported method ManifestTarget.NextBuildReason should have comment or be unexported (golint)
  • Line 705: warning: comment on exported method ManifestState.HasPendingChanges should be of the form "HasPendingChanges ..." (golint)
  • Line 715: warning: comment on exported method ManifestState.HasPendingChangesBeforeOrEqual should be of the form "HasPendingChangesBeforeOrEqual ..." (golint)
  • Line 746: warning: exported method ManifestState.UpdateStatus should have comment or be unexported (golint)
  • Line 774: warning: exported function ManifestTargetEndpoints should have comment or be unexported (golint)
  • Line 818: warning: exported function StateToView should have comment or be unexported (golint)
  • Line 897: warning: exported const MainTiltfileManifestName should have comment or be unexported (golint)
  • Line 956: warning: receiver name s should be consistent with previous receiver name e for EngineState (golint)

• tilt/internal/dockerfile/label.go
  • Line 3: warning: exported type Label should have comment or be unexported (golint)
  • Line 4: warning: exported type LabelValue should have comment or be unexported (golint)
  • Line 5: warning: exported type Labels should have comment or be unexported (golint)

• tilt/internal/k8s/client.go
  • Line 44: warning: exported type Namespace should have comment or be unexported (golint)
  • Line 45: warning: exported type NamespaceOverride should have comment or be unexported (golint)
  • Line 46: warning: exported type PodID should have comment or be unexported (golint)
  • Line 47: warning: exported type NodeID should have comment or be unexported (golint)
  • Line 48: warning: exported type ServiceName should have comment or be unexported (golint)
  • Line 49: warning: exported type KubeContext should have comment or be unexported (golint)
  • Line 50: warning: exported type KubeContextOverride should have comment or be unexported (golint)
  • Line 52: warning: comment on exported const DefaultNamespace should be of the form "DefaultNamespace ..." (golint)
  • Line 55: warning: exported var ForbiddenFieldsRe should have comment or be unexported (golint)
  • Line 57: warning: exported method PodID.Empty should have comment or be unexported (golint)
  • Line 62: warning: exported method Namespace.Empty should have comment or be unexported (golint)
  • Line 71: warning: exported type Client should have comment or be unexported (golint)
  • Line 111: warning: exported type RESTMapper should have comment or be unexported (golint)
  • Line 116: warning: exported type K8sClient should have comment or be unexported (golint)
  • Line 138: warning: exported function ProvideK8sClient should have comment or be unexported (golint)
  • Line 208: warning: exported function ServiceURL should have comment or be unexported (golint)
  • Line 263: warning: exported method K8sClient.ToRESTConfig should have comment or be unexported (golint)
  • Line 266: warning: exported method K8sClient.ToDiscoveryClient should have comment or be unexported (golint)
  • Line 269: warning: exported method K8sClient.ToRESTMapper should have comment or be unexported (golint)
  • Line 272: warning: exported method K8sClient.ToRawKubeConfigLoader should have comment or be unexported (golint)
  • Line 276: warning: exported method K8sClient.Upsert should have comment or be unexported (golint)
  • Line 469: warning: exported var MetadataAnnotationsTooLongRe should have comment or be unexported (golint)
  • Line 495: warning: comment on exported method K8sClient.Delete should be of the form "Delete ..." (golint)
  • Line 549: warning: exported method K8sClient.ListMeta should have comment or be unexported (golint)
  • Line 569: warning: exported method K8sClient.GetMetaByReference should have comment or be unexported (golint)
  • Line 600: warning: exported function ReferenceGVK should have comment or be unexported (golint)
  • Line 619: warning: exported function ProvideServerVersion should have comment or be unexported (golint)
  • Line 626: warning: exported type ClientsetOrError should have comment or be unexported (golint)
  • Line 631: warning: exported function ProvideClientset should have comment or be unexported (golint)
  • Line 639: warning: exported function ProvideClientConfig should have comment or be unexported (golint)
  • Line 654: warning: comment on exported function ProvideConfigNamespace should be of the form "ProvideConfigNamespace ..." (golint)
  • Line 672: warning: exported type RESTConfigOrError should have comment or be unexported (golint)
  • Line 677: warning: exported function ProvideRESTConfig should have comment or be unexported (golint)

• tilt/pkg/model/tilt_subcommand.go
  • Line 3: warning: comment on exported type TiltSubcommand should be of the form "TiltSubcommand ..." (with optional leading article) (golint)

• tilt/internal/ospath/ospath.go
  • Line 10: warning: comment on exported function MustAbs should be of the form "MustAbs ..." (golint)
  • Line 19: warning: comment on exported function Child should be of the form "Child ..." (golint)
  • Line 81: warning: comment on exported function IsChild should be of the form "IsChild ..." (golint)
  • Line 98: warning: exported function RealChild should have comment or be unexported (golint)
  • Line 112: warning: comment on exported function RealAbs should be of the form "RealAbs ..." (golint)
  • Line 130: warning: comment on exported function Realwd should be of the form "Realwd ..." (golint)
  • Line 139: warning: exported function IsRegularFile should have comment or be unexported (golint)
  • Line 148: warning: exported function IsDir should have comment or be unexported (golint)
  • Line 157: warning: exported function IsBrokenSymlink should have comment or be unexported (golint)

• tilt/internal/engine/dcwatch/event_watcher.go
  • Line 16: warning: exported type EventWatcher should have comment or be unexported (golint)
  • Line 22: warning: exported function NewEventWatcher should have comment or be unexported (golint)
  • Line 29: warning: exported method EventWatcher.OnChange should have comment or be unexported (golint)
  • Line 98: warning: exported function NewEventAction should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/docker_compose_build_and_deployer.go
  • Line 22: warning: exported type DockerComposeBuildAndDeployer should have comment or be unexported (golint)
  • Line 31: warning: exported function NewDockerComposeBuildAndDeployer should have comment or be unexported (golint)
  • Line 60: warning: exported method DockerComposeBuildAndDeployer.BuildAndDeploy should have comment or be unexported (golint)

• tilt/internal/container/runtime.go
  • Line 5: warning: comment on exported type Runtime should be of the form "Runtime ..." (with optional leading article) (golint)
  • Line 10: warning: exported const RuntimeDocker should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported function RuntimeFromVersionString should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/uiresource_types.go
  • Line 49: warning: comment on exported type UIResourceList should be of the form "UIResourceList ..." (with optional leading article) (golint)
  • Line 67: warning: exported method UIResource.GetObjectMeta should have comment or be unexported (golint)
  • Line 71: warning: exported method UIResource.GetSpec should have comment or be unexported (golint)
  • Line 75: warning: exported method UIResource.NamespaceScoped should have comment or be unexported (golint)
  • Line 79: warning: exported method UIResource.New should have comment or be unexported (golint)
  • Line 83: warning: exported method UIResource.NewList should have comment or be unexported (golint)
  • Line 87: warning: exported method UIResource.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 95: warning: exported method UIResource.IsStorageVersion should have comment or be unexported (golint)
  • Line 99: warning: exported method UIResource.Validate should have comment or be unexported (golint)
  • Line 106: warning: exported method UIResourceList.GetListMeta should have comment or be unexported (golint)
  • Line 186: warning: exported method UIResource.GetStatus should have comment or be unexported (golint)
  • Line 193: warning: exported method UIResourceStatus.CopyTo should have comment or be unexported (golint)
  • Line 213: warning: comment on exported const UIResourceTargetTypeUnspecified should be of the form "UIResourceTargetTypeUnspecified ..." (golint)
  • Line 216: warning: comment on exported const UIResourceTargetTypeImage should be of the form "UIResourceTargetTypeImage ..." (golint)
  • Line 219: warning: comment on exported const UIResourceTargetTypeKubernetes should be of the form "UIResourceTargetTypeKubernetes ..." (golint)
  • Line 222: warning: comment on exported const UIResourceTargetTypeDockerCompose should be of the form "UIResourceTargetTypeDockerCompose ..." (golint)
  • Line 225: warning: comment on exported const UIResourceTargetTypeLocal should be of the form "UIResourceTargetTypeLocal ..." (golint)
  • Line 255: warning: comment on exported type UIBuildTerminated should be of the form "UIBuildTerminated ..." (with optional leading article) (golint)

• tilt/internal/tiltfile/io/io.go
  • Line 18: warning: exported type WatchType should have comment or be unexported (golint)
  • Line 21: warning: comment on exported const WatchFileOnly should be of the form "WatchFileOnly ..." (golint)
  • Line 24: warning: comment on exported const WatchRecursive should be of the form "WatchRecursive ..." (golint)
  • Line 28: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 30: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 34: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 38: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 62: warning: exported method Plugin.OnExec should have comment or be unexported (golint)
  • Line 176: warning: comment on exported type ReadState should be of the form "ReadState ..." (with optional leading article) (golint)
  • Line 181: warning: exported function ReadFile should have comment or be unexported (golint)
  • Line 189: warning: exported function RecordReadPath should have comment or be unexported (golint)
  • Line 234: warning: exported function MustState should have comment or be unexported (golint)
  • Line 242: warning: exported function GetState should have comment or be unexported (golint)

• tilt/pkg/apis/core/doc.go
  • Line 20: warning: package comment should be of the form "Package core ..." (golint)

• tilt/internal/tiltfile/telemetry/telemetry.go
  • Line 14: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 16: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 20: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 26: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 74: warning: exported function MustState should have comment or be unexported (golint)
  • Line 82: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/hud/webview/convert.go
  • Line 26: warning: comment on exported const UISessionName should be of the form "UISessionName ..." (golint)
  • Line 30: warning: comment on exported function CompleteView should be of the form "CompleteView ..." (golint)
  • Line 88: warning: comment on exported function LogUpdate should be of the form "LogUpdate ..." (golint)
  • Line 136: warning: comment on exported function ToUISession should be of the form "ToUISession ..." (golint)
  • Line 183: warning: comment on exported function ToUIResourceList should be of the form "ToUIResourceList ..." (golint)
  • Line 262: warning: exported function TiltfileResourceProtoView should have comment or be unexported (golint)
  • Line 336: warning: exported function LogSegmentToEvent should have comment or be unexported (golint)

• tilt/pkg/model/trigger_mode.go
  • Line 3: warning: exported type TriggerMode should have comment or be unexported (golint)
  • Line 25: warning: exported var TriggerModes should have comment or be unexported (golint)
  • Line 32: warning: exported function ValidTriggerMode should have comment or be unexported (golint)
  • Line 35: warning: exported method TriggerMode.AutoOnChange should have comment or be unexported (golint)
  • Line 39: warning: exported method TriggerMode.AutoInitial should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/podlogstream_types.go
  • Line 36: warning: comment on exported type PodLogStream should be of the form "PodLogStream ..." (with optional leading article) (golint)
  • Line 49: warning: comment on exported type PodLogStreamList should be of the form "PodLogStreamList ..." (with optional leading article) (golint)
  • Line 104: warning: exported method PodLogStream.GetObjectMeta should have comment or be unexported (golint)
  • Line 108: warning: exported method PodLogStream.NamespaceScoped should have comment or be unexported (golint)
  • Line 112: warning: exported method PodLogStream.New should have comment or be unexported (golint)
  • Line 116: warning: exported method PodLogStream.NewList should have comment or be unexported (golint)
  • Line 120: warning: exported method PodLogStream.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 128: warning: exported method PodLogStream.IsStorageVersion should have comment or be unexported (golint)
  • Line 132: warning: exported method PodLogStream.ShortNames should have comment or be unexported (golint)
  • Line 136: warning: exported method PodLogStream.Validate should have comment or be unexported (golint)
  • Line 143: warning: exported method PodLogStreamList.GetListMeta should have comment or be unexported (golint)
  • Line 184: warning: exported method PodLogStream.GetStatus should have comment or be unexported (golint)
  • Line 191: warning: exported method PodLogStreamStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/k8s/portforward.go
  • Line 20: warning: exported type PortForwardClient should have comment or be unexported (golint)
  • Line 26: warning: exported type PortForwarder should have comment or be unexported (golint)
  • Line 68: warning: exported method K8sClient.CreatePortForwarder should have comment or be unexported (golint)
  • Line 92: warning: exported function ProvidePortForwardClient should have comment or be unexported (golint)

• tilt/internal/controllers/core/uiresource/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/controllers/core/portforward/reconciler.go
  • Line 30: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 42: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 51: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 58: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
  • Line 227: warning: exported method Reconciler.TearDown should have comment or be unexported (golint)

• tilt/internal/hud/server/websocketlist.go
  • Line 7: warning: exported type WebsocketList should have comment or be unexported (golint)
  • Line 12: warning: exported function NewWebsocketList should have comment or be unexported (golint)
  • Line 16: warning: exported method WebsocketList.Add should have comment or be unexported (golint)
  • Line 22: warning: exported method WebsocketList.Remove should have comment or be unexported (golint)
  • Line 33: warning: comment on exported method WebsocketList.ForEach should be of the form "ForEach ..." (golint)

• tilt/internal/engine/actions.go
  • Line 16: warning: exported function NewErrorAction should have comment or be unexported (golint)
  • Line 20: warning: exported type InitAction should have comment or be unexported (golint)
  • Line 35: warning: exported method InitAction.Action should have comment or be unexported (golint)
  • Line 37: warning: exported type ManifestReloadedAction should have comment or be unexported (golint)
  • Line 43: warning: exported method ManifestReloadedAction.Action should have comment or be unexported (golint)
  • Line 45: warning: exported type HudStoppedAction should have comment or be unexported (golint)
  • Line 49: warning: exported method HudStoppedAction.Action should have comment or be unexported (golint)
  • Line 51: warning: exported function NewHudStoppedAction should have comment or be unexported (golint)
  • Line 55: warning: exported type UIDUpdateAction should have comment or be unexported (golint)
  • Line 62: warning: exported method UIDUpdateAction.Action should have comment or be unexported (golint)
  • Line 64: warning: exported type TelemetryScriptRanAction should have comment or be unexported (golint)
  • Line 68: warning: exported method TelemetryScriptRanAction.Action should have comment or be unexported (golint)

• tilt/internal/hud/printer.go
  • Line 13: warning: exported type Stdout should have comment or be unexported (golint)
  • Line 15: warning: exported type IncrementalPrinter should have comment or be unexported (golint)
  • Line 20: warning: exported function NewIncrementalPrinter should have comment or be unexported (golint)
  • Line 27: warning: exported method IncrementalPrinter.PrintNewline should have comment or be unexported (golint)
  • Line 31: warning: exported method IncrementalPrinter.Print should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/runtimestatus_types.go
  • Line 7: warning: comment on exported const RuntimeStatusUnknown should be of the form "RuntimeStatusUnknown ..." (golint)
  • Line 10: warning: comment on exported const RuntimeStatusOK should be of the form "RuntimeStatusOK ..." (golint)
  • Line 13: warning: comment on exported const RuntimeStatusPending should be of the form "RuntimeStatusPending ..." (golint)
  • Line 16: warning: comment on exported const RuntimeStatusError should be of the form "RuntimeStatusError ..." (golint)
  • Line 19: warning: comment on exported const RuntimeStatusNotApplicable should be of the form "RuntimeStatusNotApplicable ..." (golint)

• tilt/pkg/assets/server.go
  • Line 8: warning: comment on exported type PackageDir should be of the form "PackageDir ..." (with optional leading article) (golint)
  • Line 15: warning: exported type Server should have comment or be unexported (golint)

• tilt/internal/tiltfile/git/git.go
  • Line 13: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 15: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 19: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 23: warning: exported function NewGitRepo should have comment or be unexported (golint)

• tilt/internal/k8s/jsonpath/doc.go
  • Line 17: warning: package comment should be of the form "Package jsonpath ..." (golint)

• tilt/internal/containerupdate/exec_updater.go
  • Line 17: warning: exported type ExecUpdater should have comment or be unexported (golint)
  • Line 23: warning: exported function NewExecUpdater should have comment or be unexported (golint)
  • Line 27: warning: exported method ExecUpdater.UpdateContainer should have comment or be unexported (golint)

• tilt/internal/controllers/fake/fixture.go
  • Line 36: warning: exported type ControllerFixture should have comment or be unexported (golint)
  • Line 46: warning: exported type ControllerFixtureBuilder should have comment or be unexported (golint)
  • Line 51: warning: exported function NewControllerFixtureBuilder should have comment or be unexported (golint)
  • Line 58: warning: exported method ControllerFixtureBuilder.Build should have comment or be unexported (golint)
  • Line 82: warning: exported method ControllerFixture.Stdout should have comment or be unexported (golint)
  • Line 86: warning: exported method ControllerFixture.T should have comment or be unexported (golint)
  • Line 86: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 95: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 99: warning: exported method ControllerFixture.Context should have comment or be unexported (golint)
  • Line 99: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 103: warning: exported method ControllerFixture.KeyForObject should have comment or be unexported (golint)
  • Line 103: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 107: warning: exported method ControllerFixture.MustReconcile should have comment or be unexported (golint)
  • Line 107: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 114: warning: exported method ControllerFixture.Get should have comment or be unexported (golint)
  • Line 114: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 124: warning: exported method ControllerFixture.MustGet should have comment or be unexported (golint)
  • Line 124: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 133: warning: exported method ControllerFixture.List should have comment or be unexported (golint)
  • Line 133: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 139: warning: exported method ControllerFixture.Create should have comment or be unexported (golint)
  • Line 139: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 146: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)
  • Line 152: warning: exported method ControllerFixture.Delete should have comment or be unexported (golint)
  • Line 152: warning: receiver name f should be consistent with previous receiver name b for ControllerFixture (golint)

• tilt/internal/store/safe.go
  • Line 8: warning: comment on exported function SafeGo should be of the form "SafeGo ..." (golint)

• tilt/internal/engine/buildcontrol/image_build_and_deployer.go
  • Line 30: warning: exported type KINDLoader should have comment or be unexported (golint)
  • Line 55: warning: exported function NewKINDLoader should have comment or be unexported (golint)
  • Line 62: warning: exported type ImageBuildAndDeployer should have comment or be unexported (golint)
  • Line 75: warning: exported function NewImageBuildAndDeployer should have comment or be unexported (golint)
  • Line 102: warning: exported method ImageBuildAndDeployer.BuildAndDeploy should have comment or be unexported (golint)
  • Line 354: warning: comment on exported function InjectImageDependencies should be of the form "InjectImageDependencies ..." (golint)

• tilt/internal/engine/local/reducers.go
  • Line 11: warning: comment on exported function HandleCmdUpdateStatusAction should be of the form "HandleCmdUpdateStatusAction ..." (golint)
  • Line 83: warning: comment on exported function HandleCmdCreateAction should be of the form "HandleCmdCreateAction ..." (golint)
  • Line 101: warning: comment on exported function HandleCmdDeleteAction should be of the form "HandleCmdDeleteAction ..." (golint)

• tilt/internal/engine/local/servercontroller.go
  • Line 18: warning: exported const AnnotationOwnerName should have comment or be unexported (golint)
  • Line 19: warning: exported const AnnotationOwnerKind should have comment or be unexported (golint)
  • Line 21: warning: comment on exported const AnnotationDepStatus should be of the form "AnnotationDepStatus ..." (golint)
  • Line 24: warning: comment on exported type ServerController should be of the form "ServerController ..." (with optional leading article) (golint)
  • Line 45: warning: exported function NewServerController should have comment or be unexported (golint)
  • Line 53: warning: exported method ServerController.OnChange should have comment or be unexported (golint)
  • Line 268: warning: exported type CmdServer should have comment or be unexported (golint)
  • Line 275: warning: exported type CmdServerSpec should have comment or be unexported (golint)
  • Line 286: warning: exported type CmdServerStatus should have comment or be unexported (golint)
  • Line 289: warning: exported function SpanIDForServeLog should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/register.go
  • Line 31: warning: exported const Version should have comment or be unexported (golint)
  • Line 39: warning: comment on exported const AnnotationSpanID should be of the form "AnnotationSpanID ..." (golint)
  • Line 43: warning: comment on exported const OwnerKindTiltfile should be of the form "OwnerKindTiltfile ..." (golint)
  • Line 49: warning: exported function AllResourceObjects should have comment or be unexported (golint)
  • Line 70: warning: exported function AllResourceLists should have comment or be unexported (golint)
  • Line 92: warning: exported var AddToScheme should have comment or be unexported (golint)
  • Line 116: warning: comment on exported function NewScheme should be of the form "NewScheme ..." (golint)

• tilt/internal/k8s/minikube.go
  • Line 28: warning: exported type MinikubeClient should have comment or be unexported (golint)
  • Line 38: warning: exported function ProvideMinikubeClient should have comment or be unexported (golint)

• tilt/internal/kustomize/ordering.go
  • Line 31: warning: exported var OrderFirst should have comment or be unexported (golint)
  • Line 56: warning: exported var TypeOrders should have comment or be unexported (golint)

• tilt/internal/tiltfile/v1alpha1/plugin.go
  • Line 14: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 22: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 26: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 30: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 30: warning: receiver name p should be consistent with previous receiver name e for Plugin (golint)
  • Line 44: warning: receiver name p should be consistent with previous receiver name e for Plugin (golint)
  • Line 78: warning: exported function MustState should have comment or be unexported (golint)
  • Line 86: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/controllers/core/extensionrepo/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/tiltfile/fake.go
  • Line 9: warning: exported type FakeTiltfileLoader should have comment or be unexported (golint)
  • Line 17: warning: exported function NewFakeTiltfileLoader should have comment or be unexported (golint)
  • Line 21: warning: exported method FakeTiltfileLoader.Load should have comment or be unexported (golint)
  • Line 29: warning: comment on exported method FakeTiltfileLoader.PassedUserConfigState should be of the form "PassedUserConfigState ..." (golint)

• tilt/internal/testutils/manifestbuilder/manifestbuilder.go
  • Line 23: warning: exported type ManifestBuilder should have comment or be unexported (golint)
  • Line 42: warning: exported function New should have comment or be unexported (golint)
  • Line 58: warning: exported method ManifestBuilder.WithNamedJSONPathImageLocator should have comment or be unexported (golint)
  • Line 66: warning: exported method ManifestBuilder.WithK8sPodReadiness should have comment or be unexported (golint)
  • Line 71: warning: exported method ManifestBuilder.WithK8sYAML should have comment or be unexported (golint)
  • Line 76: warning: exported method ManifestBuilder.WithK8sPodSelectors should have comment or be unexported (golint)
  • Line 81: warning: exported method ManifestBuilder.WithDockerCompose should have comment or be unexported (golint)
  • Line 86: warning: exported method ManifestBuilder.WithLocalResource should have comment or be unexported (golint)
  • Line 92: warning: exported method ManifestBuilder.WithLocalServeCmd should have comment or be unexported (golint)
  • Line 97: warning: exported method ManifestBuilder.WithLocalAllowParallel should have comment or be unexported (golint)
  • Line 102: warning: exported method ManifestBuilder.WithTriggerMode should have comment or be unexported (golint)
  • Line 107: warning: exported method ManifestBuilder.WithImageTarget should have comment or be unexported (golint)
  • Line 112: warning: exported method ManifestBuilder.WithImageTargets should have comment or be unexported (golint)
  • Line 117: warning: exported method ManifestBuilder.WithLiveUpdate should have comment or be unexported (golint)
  • Line 121: warning: exported method ManifestBuilder.WithLiveUpdateAtIndex should have comment or be unexported (golint)
  • Line 140: warning: exported method ManifestBuilder.WithResourceDeps should have comment or be unexported (golint)
  • Line 145: warning: exported method ManifestBuilder.Build should have comment or be unexported (golint)
  • Line 196: warning: exported type Fixture should have comment or be unexported (golint)

• tilt/pkg/model/docker_prune.go
  • Line 5: warning: comment on exported const DockerPruneDefaultMaxAge should be of the form "DockerPruneDefaultMaxAge ..." (golint)
  • Line 8: warning: comment on exported const DockerPruneDefaultInterval should be of the form "DockerPruneDefaultInterval ..." (golint)
  • Line 11: warning: comment on exported const DockerPruneDefaultKeepRecent should be of the form "DockerPruneDefaultKeepRecent ..." (golint)
  • Line 14: warning: exported type DockerPruneSettings should have comment or be unexported (golint)
  • Line 22: warning: exported function DefaultDockerPruneSettings should have comment or be unexported (golint)

• tilt/internal/testutils/servicebuilder/servicebuilder.go
  • Line 15: warning: exported type ServiceBuilder should have comment or be unexported (golint)
  • Line 25: warning: exported function New should have comment or be unexported (golint)
  • Line 32: warning: exported method ServiceBuilder.WithUID should have comment or be unexported (golint)
  • Line 37: warning: exported method ServiceBuilder.WithPort should have comment or be unexported (golint)
  • Line 42: warning: exported method ServiceBuilder.WithNodePort should have comment or be unexported (golint)
  • Line 47: warning: exported method ServiceBuilder.WithIP should have comment or be unexported (golint)
  • Line 63: warning: exported method ServiceBuilder.Build should have comment or be unexported (golint)

• tilt/internal/hud/prompt/action.go
  • Line 5: warning: exported type SwitchTerminalModeAction should have comment or be unexported (golint)
  • Line 9: warning: exported method SwitchTerminalModeAction.Action should have comment or be unexported (golint)

• tilt/internal/cloud/snapshot_uploader.go
  • Line 18: warning: exported type SnapshotID should have comment or be unexported (golint)
  • Line 20: warning: exported type SnapshotUploader should have comment or be unexported (golint)
  • Line 30: warning: exported function NewSnapshotUploader should have comment or be unexported (golint)

• tilt/pkg/logger/deferred.go
  • Line 9: warning: comment on exported type DeferredLogger should be of the form "DeferredLogger ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewDeferredLogger should have comment or be unexported (golint)
  • Line 35: warning: exported method DeferredLogger.CopyBuffered should have comment or be unexported (golint)
  • Line 47: warning: comment on exported method DeferredLogger.SetOutput should be of the form "SetOutput ..." (golint)
  • Line 58: warning: comment on exported method DeferredLogger.Original should be of the form "Original ..." (golint)

• tilt/internal/engine/dcwatch/actions.go
  • Line 11: warning: exported type EventAction should have comment or be unexported (golint)
  • Line 17: warning: exported method EventAction.Action should have comment or be unexported (golint)

• tilt/internal/store/store.go
  • Line 18: warning: comment on exported type RStore should be of the form "RStore ..." (with optional leading article) (golint)
  • Line 26: warning: comment on exported type Store should be of the form "Store ..." (with optional leading article) (golint)
  • Line 45: warning: exported function NewStore should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function NewStoreWithFakeReducer should be of the form "NewStoreWithFakeReducer ..." (golint)
  • Line 86: warning: exported method Store.StateMutex should have comment or be unexported (golint)
  • Line 90: warning: exported method Store.AddSubscriber should have comment or be unexported (golint)
  • Line 94: warning: exported method Store.RemoveSubscriber should have comment or be unexported (golint)
  • Line 98: warning: comment on exported method Store.NotifySubscribers should be of the form "NotifySubscribers ..." (golint)
  • Line 103: warning: comment on exported method Store.RLockState should be of the form "RLockState ..." (golint)
  • Line 111: warning: exported method Store.RUnlockState should have comment or be unexported (golint)
  • Line 115: warning: exported method Store.LockMutableStateForTesting should have comment or be unexported (golint)
  • Line 120: warning: exported method Store.UnlockMutableState should have comment or be unexported (golint)
  • Line 124: warning: exported method Store.Dispatch should have comment or be unexported (golint)
  • Line 129: warning: exported method Store.Close should have comment or be unexported (golint)
  • Line 133: warning: exported method Store.SetUpSubscribersForTesting should have comment or be unexported (golint)
  • Line 137: warning: exported method Store.Loop should have comment or be unexported (golint)
  • Line 232: warning: exported type Action should have comment or be unexported (golint)
  • Line 255: warning: exported type LogActionsFlag should have comment or be unexported (golint)

• tilt/internal/engine/k8swatch/event_watch_manager.go
  • Line 20: warning: comment on exported type EventWatchManager should be of the form "EventWatchManager ..." (with optional leading article) (golint)
  • Line 45: warning: exported function NewEventWatchManager should have comment or be unexported (golint)
  • Line 74: warning: exported method EventWatchManager.OnChange should have comment or be unexported (golint)
  • Line 213: warning: exported const ImagePullingReason should have comment or be unexported (golint)
  • Line 214: warning: exported const ImagePulledReason should have comment or be unexported (golint)
  • Line 216: warning: exported function ShouldLogEvent should have comment or be unexported (golint)

• tilt/pkg/model/logstore/reader.go
  • Line 5: warning: comment on exported type Reader should be of the form "Reader ..." (with optional leading article) (golint)
  • Line 11: warning: exported function NewReader should have comment or be unexported (golint)
  • Line 15: warning: exported method Reader.Checkpoint should have comment or be unexported (golint)
  • Line 25: warning: exported method Reader.Empty should have comment or be unexported (golint)
  • Line 45: warning: exported method Reader.ContinuingString should have comment or be unexported (golint)
  • Line 55: warning: exported method Reader.ContinuingLines should have comment or be unexported (golint)
  • Line 65: warning: exported method Reader.Tail should have comment or be unexported (golint)
  • Line 75: warning: exported method Reader.TailSpan should have comment or be unexported (golint)
  • Line 85: warning: exported method Reader.Warnings should have comment or be unexported (golint)

• tilt/internal/store/manifest_target.go
  • Line 8: warning: exported type ManifestTarget should have comment or be unexported (golint)
  • Line 13: warning: exported function NewManifestTarget should have comment or be unexported (golint)
  • Line 20: warning: exported method ManifestTarget.Spec should have comment or be unexported (golint)
  • Line 24: warning: exported method ManifestTarget.Status should have comment or be unexported (golint)
  • Line 28: warning: exported method ManifestTarget.UpdateStatus should have comment or be unexported (golint)
  • Line 28: warning: receiver name mt should be consistent with previous receiver name t for ManifestTarget (golint)

• tilt/internal/dockerignore/ignore.go
  • Line 49: warning: exported function NewDockerIgnoreTester should have comment or be unexported (golint)
  • Line 93: warning: exported function NewDockerPatternMatcher should have comment or be unexported (golint)
  • Line 125: warning: exported function DockerIgnoreTesterFromContents should have comment or be unexported (golint)

• tilt/internal/engine/metrics/controller.go
  • Line 20: warning: exported type MetricsState should have comment or be unexported (golint)
  • Line 27: warning: exported method MetricsState.Enabled should have comment or be unexported (golint)
  • Line 37: warning: exported type Controller should have comment or be unexported (golint)
  • Line 46: warning: exported function NewController should have comment or be unexported (golint)
  • Line 65: warning: exported method Controller.OnChange should have comment or be unexported (golint)

• tilt/pkg/model/live_update.go
  • Line 7: warning: comment on exported type LiveUpdate should be of the form "LiveUpdate ..." (with optional leading article) (golint)
  • Line 17: warning: exported function NewLiveUpdate should have comment or be unexported (golint)
  • Line 55: warning: exported method LiveUpdate.Empty should have comment or be unexported (golint)
  • Line 57: warning: exported type LiveUpdateStep should have comment or be unexported (golint)
  • Line 61: warning: comment on exported type LiveUpdateFallBackOnStep should be of the form "LiveUpdateFallBackOnStep ..." (with optional leading article) (golint)
  • Line 68: warning: comment on exported type LiveUpdateSyncStep should be of the form "LiveUpdateSyncStep ..." (with optional leading article) (golint)
  • Line 82: warning: comment on exported type LiveUpdateRunStep should be of the form "LiveUpdateRunStep ..." (with optional leading article) (golint)
  • Line 96: warning: comment on exported type LiveUpdateRestartContainerStep should be of the form "LiveUpdateRestartContainerStep ..." (with optional leading article) (golint)
  • Line 114: warning: exported method LiveUpdate.SyncSteps should have comment or be unexported (golint)
  • Line 125: warning: exported method LiveUpdate.RunSteps should have comment or be unexported (golint)
  • Line 136: warning: exported method LiveUpdate.ShouldRestart should have comment or be unexported (golint)

• tilt/internal/testutils/bufsync/bufsync.go
  • Line 12: warning: exported type ThreadSafeBuffer should have comment or be unexported (golint)
  • Line 17: warning: exported function NewThreadSafeBuffer should have comment or be unexported (golint)
  • Line 35: warning: exported method ThreadSafeBuffer.WaitUntilContains should have comment or be unexported (golint)
  • Line 48: warning: exported method ThreadSafeBuffer.Reset should have comment or be unexported (golint)

• tilt/internal/tiltfile/loaddynamic/load.go
  • Line 10: warning: comment on exported type LoadDynamicFn should be of the form "LoadDynamicFn ..." (with optional leading article) (golint)
  • Line 30: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 34: warning: exported method LoadDynamicFn.OnStart should have comment or be unexported (golint)

• tilt/internal/dockercompose/client.go
  • Line 28: warning: exported type DockerComposeClient should have comment or be unexported (golint)
  • Line 42: warning: comment on exported function NewDockerComposeClient should be of the form "NewDockerComposeClient ..." (golint)
  • Line 283: warning: exported function FormatError should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/metrics.go
  • Line 20: warning: exported var K8sDeployDuration should have comment or be unexported (golint)
  • Line 25: warning: exported var K8sDeployObjects should have comment or be unexported (golint)
  • Line 27: warning: exported var K8sDeployDurationDistribution should have comment or be unexported (golint)
  • Line 31: warning: exported var K8sDeployDurationView should have comment or be unexported (golint)
  • Line 39: warning: exported var K8sDeployCount should have comment or be unexported (golint)
  • Line 47: warning: exported var K8sDeployObjectsCount should have comment or be unexported (golint)

• tilt/pkg/model/target.go
  • Line 12: warning: exported type TargetType should have comment or be unexported (golint)
  • Line 13: warning: exported type TargetName should have comment or be unexported (golint)
  • Line 18: warning: comment on exported const TargetTypeK8s should be of the form "TargetTypeK8s ..." (golint)
  • Line 21: warning: comment on exported const TargetTypeImage should be of the form "TargetTypeImage ..." (golint)
  • Line 24: warning: comment on exported const TargetTypeDockerCompose should be of the form "TargetTypeDockerCompose ..." (golint)
  • Line 29: warning: comment on exported const TargetTypeLocal should be of the form "TargetTypeLocal ..." (golint)
  • Line 32: warning: comment on exported const TargetTypeManifest should be of the form "TargetTypeManifest ..." (golint)
  • Line 37: warning: comment on exported const TargetTypeConfigs should be of the form "TargetTypeConfigs ..." (golint)
  • Line 41: warning: exported type TargetID should have comment or be unexported (golint)
  • Line 46: warning: exported method TargetID.Empty should have comment or be unexported (golint)
  • Line 57: warning: exported function TargetIDSet should have comment or be unexported (golint)
  • Line 65: warning: exported type TargetSpec should have comment or be unexported (golint)
  • Line 75: warning: exported type TargetStatus should have comment or be unexported (golint)
  • Line 81: warning: exported type Target should have comment or be unexported (golint)
  • Line 86: warning: comment on exported function DedupeTargetIDs should be of the form "DedupeTargetIDs ..." (golint)
  • Line 99: warning: comment on exported function MakeTargetMap should be of the form "MakeTargetMap ..." (golint)
  • Line 108: warning: comment on exported function TopologicalSort should be of the form "TopologicalSort ..." (golint)

• tilt/internal/tiltfile/git/repo.go
  • Line 14: warning: exported type Repo should have comment or be unexported (golint)
  • Line 24: warning: exported method Repo.Type should have comment or be unexported (golint)
  • Line 28: warning: exported method Repo.Freeze should have comment or be unexported (golint)
  • Line 30: warning: exported method Repo.Truth should have comment or be unexported (golint)
  • Line 34: warning: exported method Repo.Hash should have comment or be unexported (golint)
  • Line 38: warning: exported method Repo.Attr should have comment or be unexported (golint)
  • Line 48: warning: exported method Repo.AttrNames should have comment or be unexported (golint)
  • Line 62: warning: exported method Repo.MakeLocalPath should have comment or be unexported (golint)

• tilt/internal/store/tiltfiles/actions.go
  • Line 7: warning: exported type TiltfileUpsertAction should have comment or be unexported (golint)
  • Line 11: warning: exported function NewTiltfileUpsertAction should have comment or be unexported (golint)
  • Line 15: warning: exported method TiltfileUpsertAction.Action should have comment or be unexported (golint)
  • Line 17: warning: exported type TiltfileDeleteAction should have comment or be unexported (golint)
  • Line 21: warning: exported function NewTiltfileDeleteAction should have comment or be unexported (golint)
  • Line 25: warning: exported method TiltfileDeleteAction.Action should have comment or be unexported (golint)

• tilt/internal/rty/layouts.go
  • Line 13: warning: exported type Dir should have comment or be unexported (golint)
  • Line 16: warning: exported const DirHor should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported var EmptyLayout should have comment or be unexported (golint)
  • Line 22: warning: exported function IsEmpty should have comment or be unexported (golint)
  • Line 26: warning: exported type Align should have comment or be unexported (golint)
  • Line 29: warning: exported const AlignStart should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: exported function NewFlexLayout should have comment or be unexported (golint)
  • Line 47: warning: exported method FlexLayout.Add should have comment or be unexported (golint)
  • Line 66: warning: exported method FlexLayout.Size should have comment or be unexported (golint)
  • Line 70: warning: exported method FlexLayout.Render should have comment or be unexported (golint)
  • Line 140: warning: exported type ConcatLayout should have comment or be unexported (golint)
  • Line 147: warning: exported function NewConcatLayout should have comment or be unexported (golint)
  • Line 151: warning: exported method ConcatLayout.Add should have comment or be unexported (golint)
  • Line 156: warning: comment on exported method ConcatLayout.AddDynamic should be of the form "AddDynamic ..." (golint)
  • Line 239: warning: exported method ConcatLayout.Size should have comment or be unexported (golint)
  • Line 248: warning: exported method ConcatLayout.Render should have comment or be unexported (golint)
  • Line 291: warning: exported function NewLines should have comment or be unexported (golint)
  • Line 295: warning: exported type Line should have comment or be unexported (golint)
  • Line 301: warning: exported function NewLine should have comment or be unexported (golint)
  • Line 305: warning: exported function OneLine should have comment or be unexported (golint)
  • Line 311: warning: exported method Line.Add should have comment or be unexported (golint)
  • Line 315: warning: exported method Line.Size should have comment or be unexported (golint)
  • Line 319: warning: exported method Line.Render should have comment or be unexported (golint)
  • Line 332: warning: comment on exported type FillerString should be of the form "FillerString ..." (with optional leading article) (golint)
  • Line 339: warning: exported function NewFillerString should have comment or be unexported (golint)
  • Line 343: warning: exported method FillerString.Size should have comment or be unexported (golint)
  • Line 347: warning: exported method FillerString.Render should have comment or be unexported (golint)
  • Line 354: warning: exported type ColorLayout should have comment or be unexported (golint)
  • Line 362: warning: exported function Fg should have comment or be unexported (golint)
  • Line 370: warning: exported function Bg should have comment or be unexported (golint)
  • Line 378: warning: exported method ColorLayout.Size should have comment or be unexported (golint)
  • Line 382: warning: exported method ColorLayout.Render should have comment or be unexported (golint)
  • Line 396: warning: exported type Box should have comment or be unexported (golint)
  • Line 420: warning: comment on exported function NewGrowingBox should be of the form "NewGrowingBox ..." (golint)
  • Line 427: warning: comment on exported function NewBox should be of the form "NewBox ..." (golint)
  • Line 448: warning: exported function NewWindow should have comment or be unexported (golint)
  • Line 454: warning: exported function NewGrowingWindow should have comment or be unexported (golint)
  • Line 460: warning: exported method Box.SetInner should have comment or be unexported (golint)
  • Line 464: warning: exported method Box.SetTitle should have comment or be unexported (golint)
  • Line 468: warning: exported method Box.Size should have comment or be unexported (golint)
  • Line 471: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 481: warning: exported method Box.Render should have comment or be unexported (golint)
  • Line 563: warning: exported function NewFixedSize should have comment or be unexported (golint)
  • Line 567: warning: exported method FixedSizeLayout.Size should have comment or be unexported (golint)
  • Line 586: warning: exported method FixedSizeLayout.Render should have comment or be unexported (golint)
  • Line 591: warning: exported type ModalLayout should have comment or be unexported (golint)
  • Line 600: warning: comment on exported function NewModalLayout should be of the form "NewModalLayout ..." (golint)
  • Line 607: warning: exported method ModalLayout.Size should have comment or be unexported (golint)
  • Line 620: warning: exported method ModalLayout.Render should have comment or be unexported (golint)
  • Line 646: warning: exported type MinLengthLayout should have comment or be unexported (golint)
  • Line 652: warning: exported function NewMinLengthLayout should have comment or be unexported (golint)
  • Line 659: warning: exported method MinLengthLayout.SetAlign should have comment or be unexported (golint)
  • Line 664: warning: exported method MinLengthLayout.Add should have comment or be unexported (golint)
  • Line 669: warning: exported method MinLengthLayout.Size should have comment or be unexported (golint)
  • Line 669: warning: receiver name ml should be consistent with previous receiver name l for MinLengthLayout (golint)
  • Line 694: warning: exported method MinLengthLayout.Render should have comment or be unexported (golint)
  • Line 694: warning: receiver name ml should be consistent with previous receiver name l for MinLengthLayout (golint)
  • Line 720: warning: exported type MaxLengthLayout should have comment or be unexported (golint)
  • Line 726: warning: exported function NewMaxLengthLayout should have comment or be unexported (golint)
  • Line 734: warning: exported method MaxLengthLayout.Size should have comment or be unexported (golint)
  • Line 748: warning: exported method MaxLengthLayout.Render should have comment or be unexported (golint)
  • Line 752: warning: comment on exported type TailLayout should be of the form "TailLayout ..." (with optional leading article) (golint)
  • Line 760: warning: exported function NewTailLayout should have comment or be unexported (golint)
  • Line 764: warning: exported method TailLayout.Size should have comment or be unexported (golint)
  • Line 768: warning: exported method TailLayout.Render should have comment or be unexported (golint)

• tilt/internal/tiltfile/os/os.go
  • Line 15: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 27: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/engine/upper_test.go
  • Line 4144: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/tiltfile/updatesettings/update_settings.go
  • Line 15: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 22: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 26: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 83: warning: exported function MustState should have comment or be unexported (golint)
  • Line 91: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/controllers/wire.go
  • Line 32: warning: exported function ProvideControllers should have comment or be unexported (golint)
  • Line 61: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/containerupdate/container_updater.go
  • Line 11: warning: exported type ContainerUpdater should have comment or be unexported (golint)

• tilt/internal/controllers/core/tiltfile/log.go
  • Line 18: warning: exported function NewTiltfileLogWriter should have comment or be unexported (golint)
  • Line 27: warning: exported function SpanIDForLoadCount should have comment or be unexported (golint)

• tilt/internal/k8s/watch.go
  • Line 30: warning: exported type InformerSet should have comment or be unexported (golint)
  • Line 65: warning: exported var PodGVR should have comment or be unexported (golint)
  • Line 66: warning: exported var ServiceGVR should have comment or be unexported (golint)
  • Line 67: warning: exported var EventGVR should have comment or be unexported (golint)
  • Line 73: warning: comment on exported type ObjectUpdate should be of the form "ObjectUpdate ..." (with optional leading article) (golint)
  • Line 80: warning: comment on exported method ObjectUpdate.AsPod should be of the form "AsPod ..." (golint)
  • Line 89: warning: comment on exported method ObjectUpdate.AsNamespacedName should be of the form "AsNamespacedName ..." (golint)
  • Line 104: warning: comment on exported method ObjectUpdate.AsDeletedKey should be of the form "AsDeletedKey ..." (golint)
  • Line 342: warning: exported method K8sClient.WatchMeta should have comment or be unexported (golint)

• tilt/internal/k8s/jsonpath/parser.go
  • Line 36: warning: exported type Parser should have comment or be unexported (golint)
  • Line 46: warning: exported var ErrSyntax should have comment or be unexported (golint)
  • Line 63: warning: exported function NewParser should have comment or be unexported (golint)
  • Line 80: warning: exported method Parser.Parse should have comment or be unexported (golint)

• tilt/internal/controllers/core/filewatch/watcher.go
  • Line 22: warning: exported const DetectedOverflowErrMsg should have comment or be unexported (golint)

• tilt/internal/controllers/core/tiltfile/buildsource.go
  • Line 26: warning: exported type BuildEntry should have comment or be unexported (golint)
  • Line 36: warning: exported method BuildEntry.WithLogger should have comment or be unexported (golint)
  • Line 41: warning: exported type BuildSource should have comment or be unexported (golint)
  • Line 49: warning: exported function NewBuildSource should have comment or be unexported (golint)
  • Line 53: warning: exported method BuildSource.Start should have comment or be unexported (golint)
  • Line 65: warning: exported method BuildSource.Entry should have comment or be unexported (golint)
  • Line 71: warning: exported method BuildSource.SetEntry should have comment or be unexported (golint)
  • Line 82: warning: exported method BuildSource.Add should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/configmap_types.go
  • Line 51: warning: comment on exported type ConfigMapList should be of the form "ConfigMapList ..." (with optional leading article) (golint)
  • Line 64: warning: exported method ConfigMap.GetObjectMeta should have comment or be unexported (golint)
  • Line 68: warning: exported method ConfigMap.NamespaceScoped should have comment or be unexported (golint)
  • Line 72: warning: exported method ConfigMap.ShortNames should have comment or be unexported (golint)
  • Line 76: warning: exported method ConfigMap.New should have comment or be unexported (golint)
  • Line 80: warning: exported method ConfigMap.NewList should have comment or be unexported (golint)
  • Line 84: warning: exported method ConfigMap.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 92: warning: exported method ConfigMap.IsStorageVersion should have comment or be unexported (golint)
  • Line 96: warning: exported method ConfigMap.Validate should have comment or be unexported (golint)
  • Line 103: warning: exported method ConfigMapList.GetListMeta should have comment or be unexported (golint)

• tilt/internal/k8s/env.go
  • Line 17: warning: exported type ClusterName should have comment or be unexported (golint)
  • Line 18: warning: exported type Env should have comment or be unexported (golint)
  • Line 38: warning: exported method Env.IsDevCluster should have comment or be unexported (golint)
  • Line 49: warning: exported function ProvideKubeContext should have comment or be unexported (golint)
  • Line 53: warning: exported function ProvideKubeConfig should have comment or be unexported (golint)
  • Line 75: warning: exported function ProvideClusterName should have comment or be unexported (golint)
  • Line 84: warning: exported function ProvideEnv should have comment or be unexported (golint)

• tilt/internal/tiltfile/shlex/shlex.go
  • Line 11: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 13: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 17: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/rty/components.go
  • Line 11: warning: exported type RTY should have comment or be unexported (golint)
  • Line 22: warning: exported type ElementScroller should have comment or be unexported (golint)
  • Line 30: warning: exported type TextScroller should have comment or be unexported (golint)
  • Line 46: warning: exported type Writer should have comment or be unexported (golint)
  • Line 63: warning: exported const GROW should have comment or be unexported (golint)

• tilt/internal/cloud/cloudurl/url.go
  • Line 11: warning: comment on exported type Address should be of the form "Address ..." (with optional leading article) (golint)
  • Line 16: warning: exported function ProvideAddress should have comment or be unexported (golint)
  • Line 25: warning: exported function URL should have comment or be unexported (golint)

• tilt/internal/controllers/core/kubernetesdiscovery/reconciler.go
  • Line 48: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 88: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 96: warning: exported function NewReconciler should have comment or be unexported (golint)

• tilt/internal/build/boil_runs.go
  • Line 7: warning: exported function BoilRuns should have comment or be unexported (golint)

• tilt/internal/token/token.go
  • Line 12: warning: exported type Token should have comment or be unexported (golint)
  • Line 18: warning: exported function GetOrCreateToken should have comment or be unexported (golint)

• tilt/internal/engine/k8srollout/podmonitor.go
  • Line 25: warning: exported type PodMonitor should have comment or be unexported (golint)
  • Line 30: warning: exported function NewPodMonitor should have comment or be unexported (golint)
  • Line 72: warning: exported method PodMonitor.OnChange should have comment or be unexported (golint)

• tilt/internal/analytics/context.go
  • Line 9: warning: exported function WithAnalytics should have comment or be unexported (golint)
  • Line 13: warning: exported function Get should have comment or be unexported (golint)

• tilt/internal/hud/renderer.go
  • Line 19: warning: exported type Renderer should have comment or be unexported (golint)
  • Line 26: warning: exported function NewRenderer should have comment or be unexported (golint)
  • Line 33: warning: exported method Renderer.Render should have comment or be unexported (golint)
  • Line 271: warning: exported method Renderer.SetUp should have comment or be unexported (golint)
  • Line 306: warning: exported method Renderer.RTY should have comment or be unexported (golint)
  • Line 313: warning: exported method Renderer.Reset should have comment or be unexported (golint)

• tilt/internal/hud/server/logs_reader.go
  • Line 27: warning: exported type WebsocketReader should have comment or be unexported (golint)
  • Line 50: warning: exported type ViewHandler should have comment or be unexported (golint)
  • Line 54: warning: exported type LogStreamer should have comment or be unexported (golint)
  • Line 68: warning: exported function NewLogStreamer should have comment or be unexported (golint)
  • Line 81: warning: exported method LogStreamer.Handle should have comment or be unexported (golint)
  • Line 112: warning: exported function StreamLogs should have comment or be unexported (golint)
  • Line 127: warning: exported method WebsocketReader.Listen should have comment or be unexported (golint)

• tilt/internal/tiltfile/starlarkstruct/struct.go
  • Line 9: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 12: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 16: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/docker/clients.go
  • Line 9: warning: exported type LocalClient should have comment or be unexported (golint)
  • Line 10: warning: exported type ClusterClient should have comment or be unexported (golint)
  • Line 12: warning: comment on exported function ProvideClusterCli should be of the form "ProvideClusterCli ..." (golint)
  • Line 30: warning: exported function ProvideLocalCli should have comment or be unexported (golint)

• tilt/internal/hud/resourceview.go
  • Line 19: warning: comment on exported const DeployCellMinWidth should be of the form "DeployCellMinWidth ..." (golint)
  • Line 21: warning: exported const BuildDurCellMinWidth should have comment or be unexported (golint)
  • Line 22: warning: exported const BuildStatusCellMinWidth should have comment or be unexported (golint)
  • Line 23: warning: exported const MaxInlineErrHeight should have comment or be unexported (golint)
  • Line 25: warning: exported type ResourceView should have comment or be unexported (golint)
  • Line 35: warning: exported function NewResourceView should have comment or be unexported (golint)
  • Line 47: warning: exported method ResourceView.Build should have comment or be unexported (golint)
  • Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/tiltfile/tiltfile_state.go
  • Line 386: warning: receiver name t should be consistent with previous receiver name m for triggerMode (golint)
  • Line 390: warning: receiver name t should be consistent with previous receiver name m for triggerMode (golint)
  • Line 394: warning: receiver name t should be consistent with previous receiver name m for triggerMode (golint)
  • Line 398: warning: receiver name t should be consistent with previous receiver name m for triggerMode (golint)
  • Line 405: warning: exported const TriggerModeUnset should have comment (or a comment on this block) or be unexported (golint)
  • Line 413: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 428: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 909: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/watch/notify.go
  • Line 19: warning: exported type FileEvent should have comment or be unexported (golint)
  • Line 23: warning: exported function NewFileEvent should have comment or be unexported (golint)
  • Line 30: warning: exported method FileEvent.Path should have comment or be unexported (golint)
  • Line 34: warning: exported type Notify should have comment or be unexported (golint)
  • Line 48: warning: comment on exported type PathMatcher should be of the form "PathMatcher ..." (with optional leading article) (golint)
  • Line 63: warning: exported type EmptyMatcher should have comment or be unexported (golint)
  • Line 66: warning: exported method EmptyMatcher.Matches should have comment or be unexported (golint)
  • Line 67: warning: exported method EmptyMatcher.MatchesEntireDir should have comment or be unexported (golint)
  • Line 71: warning: exported function NewWatcher should have comment or be unexported (golint)
  • Line 75: warning: exported const WindowsBufferSizeEnvVar should have comment or be unexported (golint)
  • Line 79: warning: exported function DesiredWindowsBufferSize should have comment or be unexported (golint)
  • Line 90: warning: exported function IsWindowsShortReadError should have comment or be unexported (golint)

• tilt/internal/build/path_mapping.go
  • Line 40: warning: exported method PathMapping.PrettyStr should have comment or be unexported (golint)
  • Line 44: warning: exported method PathMapping.Filter should have comment or be unexported (golint)
  • Line 78: warning: exported function FilterMappings should have comment or be unexported (golint)
  • Line 154: warning: exported function SyncsToPathMappings should have comment or be unexported (golint)
  • Line 165: warning: comment on exported function MissingLocalPaths should be of the form "MissingLocalPaths ..." (golint)
  • Line 183: warning: exported function PathMappingsToContainerPaths should have comment or be unexported (golint)
  • Line 191: warning: exported function PathMappingsToLocalPaths should have comment or be unexported (golint)

• tilt/pkg/assets/middleware.go
  • Line 13: warning: comment on exported function StripPrefix should be of the form "StripPrefix ..." (golint)
  • Line 30: warning: comment on exported function InferVersion should be of the form "InferVersion ..." (golint)

• tilt/internal/k8s/registry.go
  • Line 30: warning: exported type RuntimeSource should have comment or be unexported (golint)
  • Line 34: warning: exported type NaiveRuntimeSource should have comment or be unexported (golint)
  • Line 38: warning: exported function NewNaiveRuntimeSource should have comment or be unexported (golint)
  • Line 42: warning: exported method NaiveRuntimeSource.Runtime should have comment or be unexported (golint)
  • Line 205: warning: exported method K8sClient.LocalRegistry should have comment or be unexported (golint)

• tilt/internal/testutils/tempdir/temp_dir_fixture.go
  • Line 15: warning: exported type TempDirFixture should have comment or be unexported (golint)
  • Line 24: warning: exported function SanitizeFileName should have comment or be unexported (golint)
  • Line 28: warning: exported function NewTempDirFixture should have comment or be unexported (golint)
  • Line 40: warning: exported method TempDirFixture.T should have comment or be unexported (golint)
  • Line 44: warning: exported method TempDirFixture.Path should have comment or be unexported (golint)
  • Line 48: warning: exported method TempDirFixture.Chdir should have comment or be unexported (golint)
  • Line 62: warning: exported method TempDirFixture.JoinPath should have comment or be unexported (golint)
  • Line 77: warning: exported method TempDirFixture.JoinPaths should have comment or be unexported (golint)
  • Line 85: warning: comment on exported method TempDirFixture.WriteFile should be of the form "WriteFile ..." (golint)
  • Line 100: warning: comment on exported method TempDirFixture.CopyFile should be of the form "CopyFile ..." (golint)
  • Line 109: warning: exported method TempDirFixture.WriteSymlink should have comment or be unexported (golint)
  • Line 121: warning: exported method TempDirFixture.MkdirAll should have comment or be unexported (golint)
  • Line 129: warning: exported method TempDirFixture.TouchFiles should have comment or be unexported (golint)
  • Line 135: warning: exported method TempDirFixture.Rm should have comment or be unexported (golint)
  • Line 143: warning: exported method TempDirFixture.NewFile should have comment or be unexported (golint)
  • Line 147: warning: exported method TempDirFixture.TempDir should have comment or be unexported (golint)
  • Line 155: warning: exported method TempDirFixture.TearDown should have comment or be unexported (golint)

• tilt/internal/tiltfile/tiltextension/store.go
  • Line 19: warning: exported type Store should have comment or be unexported (golint)
  • Line 26: warning: exported type ModuleContents should have comment or be unexported (golint)
  • Line 41: warning: exported type LocalStore should have comment or be unexported (golint)
  • Line 45: warning: exported type Metadata should have comment or be unexported (golint)
  • Line 51: warning: exported type MetadataFile should have comment or be unexported (golint)
  • Line 55: warning: exported function NewLocalStore should have comment or be unexported (golint)
  • Line 61: warning: exported method LocalStore.ModulePath should have comment or be unexported (golint)

• tilt/internal/controllers/core/kubernetesdiscovery/container_restart.go
  • Line 17: warning: exported type ContainerRestartDetector should have comment or be unexported (golint)
  • Line 19: warning: exported function NewContainerRestartDetector should have comment or be unexported (golint)
  • Line 23: warning: exported method ContainerRestartDetector.Detect should have comment or be unexported (golint)

• tilt/internal/build/error.go
  • Line 14: warning: comment on exported const TaskKillExitCode should be of the form "TaskKillExitCode ..." (golint)
  • Line 17: warning: exported function WrapCodeExitError should have comment or be unexported (golint)
  • Line 28: warning: comment on exported function WrapContainerExecError should be of the form "WrapContainerExecError ..." (golint)
  • Line 47: warning: comment on exported type RunStepFailure should be of the form "RunStepFailure ..." (with optional leading article) (golint)
  • Line 54: warning: exported method RunStepFailure.Empty should have comment or be unexported (golint)
  • Line 62: warning: exported function IsRunStepFailure should have comment or be unexported (golint)
  • Line 67: warning: exported function MaybeRunStepFailure should have comment or be unexported (golint)

• tilt/internal/tracer/span_collector.go
  • Line 43: warning: exported function NewSpanCollector should have comment or be unexported (golint)
  • Line 85: warning: comment on exported method SpanCollector.OnStart should be of the form "OnStart ..." (golint)
  • Line 89: warning: exported method SpanCollector.OnEnd should have comment or be unexported (golint)
  • Line 93: warning: exported method SpanCollector.Shutdown should have comment or be unexported (golint)
  • Line 97: warning: comment on exported method SpanCollector.GetOutgoingSpans should be of the form "GetOutgoingSpans ..." (golint)
  • Line 122: warning: exported method SpanCollector.Close should have comment or be unexported (golint)

• tilt/internal/git/remote.go
  • Line 10: warning: exported type GitRemote should have comment or be unexported (golint)
  • Line 16: warning: exported function ProvideGitRemote should have comment or be unexported (golint)

• tilt/pkg/assets/prod.go
  • Line 20: warning: comment on exported type AssetBucket should be of the form "AssetBucket ..." (with optional leading article) (golint)
  • Line 25: warning: exported const ProdAssetBucket should have comment or be unexported (golint)
  • Line 26: warning: exported const WebVersionKey should have comment or be unexported (golint)
  • Line 37: warning: exported function NewProdServer should have comment or be unexported (golint)
  • Line 114: warning: exported function RewriteContentURLs should have comment or be unexported (golint)

• tilt/internal/tiltfile/include/include.go
  • Line 9: warning: comment on exported type IncludeFn should be of the form "IncludeFn ..." (with optional leading article) (golint)
  • Line 20: warning: exported method IncludeFn.OnStart should have comment or be unexported (golint)

• tilt/internal/rty/tokenizer.go
  • Line 8: warning: comment on exported type Tokenizer should be of the form "Tokenizer ..." (with optional leading article) (golint)
  • Line 25: warning: exported function NewTokenizer should have comment or be unexported (golint)
  • Line 32: warning: exported method Tokenizer.Next should have comment or be unexported (golint)

• tilt/internal/controllers/core/extensionrepo/reconciler.go
  • Line 28: warning: exported type Downloader should have comment or be unexported (golint)
  • Line 35: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 42: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 49: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method Reconciler.Reconcile should be of the form "Reconcile ..." (golint)

• tilt/internal/hud/server/websocket.go
  • Line 34: warning: exported type WebsocketSubscriber should have comment or be unexported (golint)
  • Line 47: warning: exported type WebsocketConn should have comment or be unexported (golint)
  • Line 55: warning: exported function NewWebsocketSubscriber should have comment or be unexported (golint)
  • Line 66: warning: exported method WebsocketSubscriber.TearDown should have comment or be unexported (golint)
  • Line 70: warning: comment on exported method WebsocketSubscriber.Stream should be of the form "Stream ..." (golint)
  • Line 119: warning: exported method WebsocketSubscriber.OnChange should have comment or be unexported (golint)
  • Line 155: warning: comment on exported method WebsocketSubscriber.SendUISessionUpdate should be of the form "SendUISessionUpdate ..." (golint)
  • Line 182: warning: comment on exported method WebsocketSubscriber.SendUIResourceUpdate should be of the form "SendUIResourceUpdate ..." (golint)
  • Line 206: warning: comment on exported method WebsocketSubscriber.SendUIButtonUpdate should be of the form "SendUIButtonUpdate ..." (golint)
  • Line 264: warning: exported method HeadsUpServer.ViewWebsocket should have comment or be unexported (golint)

• tilt/pkg/model/tilt_build.go
  • Line 8: warning: comment on exported type TiltBuild should be of the form "TiltBuild ..." (with optional leading article) (golint)
  • Line 17: warning: exported method TiltBuild.Empty should have comment or be unexported (golint)
  • Line 21: warning: exported method TiltBuild.AnalyticsVersion should have comment or be unexported (golint)
  • Line 29: warning: exported method TiltBuild.WebVersion should have comment or be unexported (golint)
  • Line 34: warning: exported method TiltBuild.HumanBuildStamp should have comment or be unexported (golint)

• tilt/internal/tiltfile/tiltextension/github_fetcher.go
  • Line 14: warning: exported type Downloader should have comment or be unexported (golint)
  • Line 19: warning: exported type TempDirDownloader should have comment or be unexported (golint)
  • Line 23: warning: exported function NewTempDirDownloader should have comment or be unexported (golint)
  • Line 31: warning: exported method TempDirDownloader.RootDir should have comment or be unexported (golint)
  • Line 35: warning: exported method TempDirDownloader.Download should have comment or be unexported (golint)
  • Line 40: warning: exported type GithubFetcher should have comment or be unexported (golint)
  • Line 44: warning: exported function NewGithubFetcher should have comment or be unexported (golint)
  • Line 48: warning: exported method GithubFetcher.CleanUp should have comment or be unexported (golint)
  • Line 52: warning: exported method GithubFetcher.Fetch should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/bool.go
  • Line 9: warning: comment on exported type BoolOrNone should be of the form "BoolOrNone ..." (with optional leading article) (golint)
  • Line 15: warning: exported method BoolOrNone.Unpack should have comment or be unexported (golint)

• tilt/internal/dockercompose/state.go
  • Line 15: warning: exported method Event.IsStartupEvent should have comment or be unexported (golint)
  • Line 22: warning: exported type State should have comment or be unexported (golint)
  • Line 37: warning: exported method State.RuntimeState should have comment or be unexported (golint)
  • Line 39: warning: exported method State.RuntimeStatus should have comment or be unexported (golint)
  • Line 56: warning: exported method State.RuntimeStatusError should have comment or be unexported (golint)
  • Line 70: warning: exported method State.WithContainerState should have comment or be unexported (golint)
  • Line 75: warning: exported method State.WithSpanID should have comment or be unexported (golint)
  • Line 80: warning: exported method State.WithContainerID should have comment or be unexported (golint)
  • Line 85: warning: exported method State.WithStartTime should have comment or be unexported (golint)
  • Line 90: warning: exported method State.WithLastReadyTime should have comment or be unexported (golint)
  • Line 95: warning: exported method State.HasEverBeenReadyOrSucceeded should have comment or be unexported (golint)

• tilt/internal/hud/hud.go
  • Line 24: warning: comment on exported const DefaultRefreshInterval should be of the form "DefaultRefreshInterval ..." (golint)
  • Line 31: warning: exported type HeadsUpDisplay should have comment or be unexported (golint)
  • Line 37: warning: exported type Hud should have comment or be unexported (golint)
  • Line 52: warning: exported function NewHud should have comment or be unexported (golint)
  • Line 61: warning: exported method Hud.SetNarrationMessage should have comment or be unexported (golint)
  • Line 70: warning: exported method Hud.Run should have comment or be unexported (golint)
  • Line 119: warning: exported method Hud.Close should have comment or be unexported (golint)
  • Line 259: warning: exported method Hud.OnChange should have comment or be unexported (golint)
  • Line 301: warning: exported method Hud.Refresh should have comment or be unexported (golint)

• tilt/internal/cli/metrics.go
  • Line 19: warning: comment on exported var KeySubCommand should be of the form "KeySubCommand ..." (golint)
  • Line 23: warning: exported var CommandCountMeasure should have comment or be unexported (golint)
  • Line 28: warning: exported var CommandCount should have comment or be unexported (golint)
  • Line 70: warning: exported function ProvideDeferredExporter should have comment or be unexported (golint)
  • Line 74: warning: exported function ProvideMeter should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/extractors.go
  • Line 104: warning: comment on exported function IsImageDeployedToK8s should be of the form "IsImageDeployedToK8s ..." (golint)
  • Line 116: warning: comment on exported function IsImageDeployedToDC should be of the form "IsImageDeployedToDC ..." (golint)
  • Line 128: warning: comment on exported function HasFileChangesTree should be of the form "HasFileChangesTree ..." (golint)

• tilt/internal/k8s/names.go
  • Line 10: warning: exported function DuplicateYAMLDetectedError should have comment or be unexported (golint)
  • Line 14: warning: comment on exported function UniqueNames should be of the form "UniqueNames ..." (golint)

• tilt/internal/docker/buildkit/ssh.go
  • Line 32: warning: exported function ParseSSHSpecs should have comment or be unexported (golint)

• tilt/internal/store/terminal.go
  • Line 3: warning: comment on exported type TerminalMode should be of the form "TerminalMode ..." (with optional leading article) (golint)
  • Line 7: warning: comment on exported const TerminalModeDefault should be of the form "TerminalModeDefault ..." (golint)
  • Line 11: warning: comment on exported const TerminalModeHUD should be of the form "TerminalModeHUD ..." (golint)
  • Line 14: warning: comment on exported const TerminalModeStream should be of the form "TerminalModeStream ..." (golint)
  • Line 19: warning: comment on exported const TerminalModePrompt should be of the form "TerminalModePrompt ..." (golint)

• tilt/internal/hud/prompt/prompt.go
  • Line 20: warning: exported type TerminalInput should have comment or be unexported (golint)
  • Line 25: warning: exported type OpenInput should have comment or be unexported (golint)
  • Line 27: warning: exported function TTYOpen should have comment or be unexported (golint)
  • Line 31: warning: exported type TerminalPrompt should have comment or be unexported (golint)
  • Line 49: warning: exported function NewTerminalPrompt should have comment or be unexported (golint)
  • Line 63: warning: comment on exported method TerminalPrompt.SetInitOutput should be of the form "SetInitOutput ..." (golint)
  • Line 93: warning: exported method TerminalPrompt.TearDown should have comment or be unexported (golint)
  • Line 101: warning: exported method TerminalPrompt.OnChange should have comment or be unexported (golint)
  • Line 236: warning: exported function StartStatusLine should have comment or be unexported (golint)

• tilt/internal/hud/server/wire.go
  • Line 9: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/k8s/entity.go
  • Line 24: warning: exported type K8sEntity should have comment or be unexported (golint)
  • Line 28: warning: exported function NewK8sEntity should have comment or be unexported (golint)
  • Line 46: warning: exported function SortedEntities should have comment or be unexported (golint)
  • Line 52: warning: exported function ReverseSortedEntities should have comment or be unexported (golint)
  • Line 58: warning: exported method K8sEntity.Meta should have comment or be unexported (golint)
  • Line 66: warning: exported method K8sEntity.ToObjectReference should have comment or be unexported (golint)
  • Line 78: warning: exported method K8sEntity.WithNamespace should have comment or be unexported (golint)
  • Line 84: warning: exported method K8sEntity.GVK should have comment or be unexported (golint)
  • Line 109: warning: exported method K8sEntity.SetUID should have comment or be unexported (golint)
  • Line 113: warning: exported method K8sEntity.Name should have comment or be unexported (golint)
  • Line 117: warning: exported method K8sEntity.Namespace should have comment or be unexported (golint)
  • Line 125: warning: exported method K8sEntity.NamespaceOrDefault should have comment or be unexported (golint)
  • Line 133: warning: exported method K8sEntity.UID should have comment or be unexported (golint)
  • Line 137: warning: exported method K8sEntity.Annotations should have comment or be unexported (golint)
  • Line 141: warning: exported method K8sEntity.Labels should have comment or be unexported (golint)
  • Line 145: warning: comment on exported method K8sEntity.ImmutableOnceCreated should be of the form "ImmutableOnceCreated ..." (golint)
  • Line 150: warning: exported method K8sEntity.DeepCopy should have comment or be unexported (golint)
  • Line 154: warning: exported function CopyEntities should have comment or be unexported (golint)
  • Line 177: warning: exported function ImmutableEntities should have comment or be unexported (golint)
  • Line 187: warning: exported function MutableEntities should have comment or be unexported (golint)
  • Line 197: warning: exported type LoadBalancerSpec should have comment or be unexported (golint)
  • Line 203: warning: exported type LoadBalancer should have comment or be unexported (golint)
  • Line 208: warning: exported function ToLoadBalancerSpecs should have comment or be unexported (golint)
  • Line 219: warning: comment on exported function ToLoadBalancerSpec should be of the form "ToLoadBalancerSpec ..." (golint)
  • Line 266: warning: exported function FilterByImage should have comment or be unexported (golint)
  • Line 270: warning: exported function FilterBySelectorMatchesLabels should have comment or be unexported (golint)
  • Line 274: warning: exported function FilterByMetadataLabels should have comment or be unexported (golint)
  • Line 278: warning: exported function FilterByHasPodTemplateSpec should have comment or be unexported (golint)
  • Line 288: warning: exported function FilterByMatchesPodTemplateSpec should have comment or be unexported (golint)
  • Line 311: warning: exported method K8sEntity.HasName should have comment or be unexported (golint)
  • Line 315: warning: exported method K8sEntity.HasNamespace should have comment or be unexported (golint)
  • Line 323: warning: exported method K8sEntity.HasKind should have comment or be unexported (golint)
  • Line 328: warning: exported function NewNamespaceEntity should have comment or be unexported (golint)

• tilt/internal/sliceutils/sliceutils.go
  • Line 9: warning: comment on exported function DedupedAndSorted should be of the form "DedupedAndSorted ..." (golint)
  • Line 23: warning: comment on exported function QuotedStringList should be of the form "QuotedStringList ..." (golint)
  • Line 32: warning: exported function BulletedIndentedStringList should have comment or be unexported (golint)
  • Line 40: warning: exported function StringSliceEquals should have comment or be unexported (golint)
  • Line 64: warning: comment on exported function AppendWithoutDupes should be of the form "AppendWithoutDupes ..." (golint)
  • Line 81: warning: exported type EscapeSplitOptions should have comment or be unexported (golint)
  • Line 86: warning: exported function NewEscapeSplitOptions should have comment or be unexported (golint)
  • Line 93: warning: exported function UnescapeAndSplit should have comment or be unexported (golint)
  • Line 139: warning: exported function EscapeAndJoin should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/live_update_build_and_deployer.go
  • Line 28: warning: exported type LiveUpdateBuildAndDeployer should have comment or be unexported (golint)
  • Line 36: warning: exported function NewLiveUpdateBuildAndDeployer should have comment or be unexported (golint)
  • Line 61: warning: exported method LiveUpdateBuildAndDeployer.BuildAndDeploy should have comment or be unexported (golint)
  • Line 174: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/pkg/logger/func_logger.go
  • Line 18: warning: exported function NewFuncLogger should have comment or be unexported (golint)
  • Line 82: warning: exported type FuncLoggerWriter should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/session_types.go
  • Line 63: warning: exported type ExitCondition should have comment or be unexported (golint)
  • Line 82: warning: exported method Session.GetObjectMeta should have comment or be unexported (golint)
  • Line 86: warning: exported method Session.NamespaceScoped should have comment or be unexported (golint)
  • Line 90: warning: exported method Session.New should have comment or be unexported (golint)
  • Line 94: warning: exported method Session.NewList should have comment or be unexported (golint)
  • Line 98: warning: exported method Session.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 106: warning: exported method Session.IsStorageVersion should have comment or be unexported (golint)
  • Line 110: warning: exported method Session.Validate should have comment or be unexported (golint)
  • Line 142: warning: exported method SessionList.GetListMeta should have comment or be unexported (golint)
  • Line 249: warning: exported method Session.GetStatus should have comment or be unexported (golint)
  • Line 256: warning: exported method SessionStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/cli/updog.go
  • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/tiltfile/starkit/environment.go
  • Line 23: warning: comment on exported function ExecFile should be of the form "ExecFile ..." (golint)
  • Line 34: warning: comment on exported function UnpackArgs should be of the form "UnpackArgs ..." (golint)
  • Line 43: warning: exported type BuiltinCall should have comment or be unexported (golint)
  • Line 49: warning: comment on exported type Environment should be of the form "Environment ..." (with optional leading article) (golint)
  • Line 75: warning: exported method Environment.AddLoadInterceptor should have comment or be unexported (golint)
  • Line 79: warning: exported method Environment.SetArgUnpacker should have comment or be unexported (golint)
  • Line 83: warning: comment on exported method Environment.StartPath should be of the form "StartPath ..." (golint)
  • Line 88: warning: comment on exported method Environment.AddBuiltin should be of the form "AddBuiltin ..." (golint)
  • Line 116: warning: exported method Environment.AddValue should have comment or be unexported (golint)
  • Line 149: warning: exported method Environment.SetPrint should have comment or be unexported (golint)
  • Line 153: warning: exported method Environment.SetContext should have comment or be unexported (golint)
  • Line 157: warning: comment on exported method Environment.SetFakeFileSystem should be of the form "SetFakeFileSystem ..." (golint)
  • Line 293: warning: exported type ArgUnpacker should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/local_target_build_and_deployer.go
  • Line 21: warning: comment on exported type LocalTargetBuildAndDeployer should be of the form "LocalTargetBuildAndDeployer ..." (with optional leading article) (golint)
  • Line 28: warning: exported function NewLocalTargetBuildAndDeployer should have comment or be unexported (golint)
  • Line 39: warning: exported method LocalTargetBuildAndDeployer.BuildAndDeploy should have comment or be unexported (golint)

• tilt/pkg/model/image_target.go
  • Line 15: warning: exported type LiveUpdateSpec should have comment or be unexported (golint)
  • Line 28: warning: exported type ImageTarget should have comment or be unexported (golint)
  • Line 54: warning: exported function MustNewImageTarget should have comment or be unexported (golint)
  • Line 58: warning: exported function ImageID should have comment or be unexported (golint)
  • Line 69: warning: exported method ImageTarget.MustWithRef should have comment or be unexported (golint)
  • Line 77: warning: exported method ImageTarget.ID should have comment or be unexported (golint)
  • Line 81: warning: exported method ImageTarget.DependencyIDs should have comment or be unexported (golint)
  • Line 85: warning: exported method ImageTarget.WithDependencyIDs should have comment or be unexported (golint)
  • Line 90: warning: exported method ImageTarget.Validate should have comment or be unexported (golint)
  • Line 126: warning: exported type BuildDetails should have comment or be unexported (golint)
  • Line 130: warning: exported method ImageTarget.DockerBuildInfo should have comment or be unexported (golint)
  • Line 135: warning: exported method ImageTarget.IsDockerBuild should have comment or be unexported (golint)
  • Line 140: warning: exported method ImageTarget.LiveUpdateInfo should have comment or be unexported (golint)
  • Line 151: warning: exported method ImageTarget.CustomBuildInfo should have comment or be unexported (golint)
  • Line 156: warning: exported method ImageTarget.IsCustomBuild should have comment or be unexported (golint)
  • Line 161: warning: exported method ImageTarget.WithBuildDetails should have comment or be unexported (golint)
  • Line 174: warning: comment on exported method ImageTarget.MaybeIgnoreRegistry should be of the form "MaybeIgnoreRegistry ..." (golint)
  • Line 203: warning: exported method ImageTarget.WithRepos should have comment or be unexported (golint)
  • Line 208: warning: exported method ImageTarget.WithDockerignores should have comment or be unexported (golint)
  • Line 213: warning: exported method ImageTarget.WithOverrideCommand should have comment or be unexported (golint)
  • Line 220: warning: exported method ImageTarget.Dockerignores should have comment or be unexported (golint)
  • Line 224: warning: exported method ImageTarget.LocalPaths should have comment or be unexported (golint)
  • Line 234: warning: exported method ImageTarget.LocalRepos should have comment or be unexported (golint)
  • Line 238: warning: exported method ImageTarget.IgnoredLocalDirectories should have comment or be unexported (golint)
  • Line 242: warning: exported method ImageTarget.TiltFilename should have comment or be unexported (golint)
  • Line 246: warning: exported method ImageTarget.WithTiltFilename should have comment or be unexported (golint)
  • Line 251: warning: comment on exported method ImageTarget.Dependencies should be of the form "Dependencies ..." (golint)
  • Line 257: warning: exported function ImageTargetsByID should have comment or be unexported (golint)
  • Line 265: warning: exported type DockerBuild should have comment or be unexported (golint)
  • Line 297: warning: exported type DockerBuildTarget should have comment or be unexported (golint)
  • Line 301: warning: exported type CustomBuild should have comment or be unexported (golint)
  • Line 324: warning: exported method CustomBuild.WithTag should have comment or be unexported (golint)
  • Line 329: warning: exported method CustomBuild.SkipsPush should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8s/types.go
  • Line 12: warning: comment on exported type DiscoveryStrategy should be of the form "DiscoveryStrategy ..." (with optional leading article) (golint)
  • Line 15: warning: exported method DiscoveryStrategy.Unpack should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/module.go
  • Line 9: warning: comment on exported type Module should be of the form "Module ..." (with optional leading article) (golint)
  • Line 15: warning: exported method Module.Freeze should have comment or be unexported (golint)
  • Line 17: warning: exported method Module.Type should have comment or be unexported (golint)
  • Line 19: warning: exported method Module.Hash should have comment or be unexported (golint)
  • Line 23: warning: exported method Module.Attr should have comment or be unexported (golint)
  • Line 28: warning: exported method Module.AttrNames should have comment or be unexported (golint)
  • Line 36: warning: exported method Module.Truth should have comment or be unexported (golint)

• tilt/internal/engine/session/actions.go
  • Line 13: warning: exported type SessionUpdateStatusAction should have comment or be unexported (golint)
  • Line 20: warning: exported method SessionUpdateStatusAction.Summarize should have comment or be unexported (golint)
  • Line 24: warning: exported function NewSessionUpdateStatusAction should have comment or be unexported (golint)
  • Line 31: warning: exported method SessionUpdateStatusAction.Action should have comment or be unexported (golint)
  • Line 33: warning: exported function HandleSessionUpdateStatusAction should have comment or be unexported (golint)

• tilt/internal/hud/fake_hud.go
  • Line 17: warning: exported type FakeHud should have comment or be unexported (golint)
  • Line 26: warning: exported function NewFakeHud should have comment or be unexported (golint)
  • Line 33: warning: exported method FakeHud.Run should have comment or be unexported (golint)
  • Line 42: warning: exported method FakeHud.OnChange should have comment or be unexported (golint)
  • Line 61: warning: context.Context should be the first parameter of a function (golint)
  • Line 61: warning: exported method FakeHud.WaitUntilResource should have comment or be unexported (golint)
  • Line 71: warning: context.Context should be the first parameter of a function (golint)
  • Line 71: warning: exported method FakeHud.WaitUntil should have comment or be unexported (golint)

• tilt/internal/store/metrics.go
  • Line 5: warning: exported type MetricsServing should have comment or be unexported (golint)

• tilt/pkg/model/logstore/prefix.go
  • Line 10: warning: exported function SourcePrefix should have comment or be unexported (golint)

• tilt/internal/tracer/otel.go
  • Line 12: warning: exported function InitOpenTelemetry should have comment or be unexported (golint)

• tilt/internal/engine/uiresource/subscriber.go
  • Line 16: warning: comment on exported type Subscriber should be of the form "Subscriber ..." (with optional leading article) (golint)
  • Line 23: warning: exported function NewSubscriber should have comment or be unexported (golint)
  • Line 35: warning: exported method Subscriber.OnChange should have comment or be unexported (golint)

• tilt/internal/engine/subscribers.go
  • Line 25: warning: comment on exported function ProvideSubscribersAPIOnly should be of the form "ProvideSubscribersAPIOnly ..." (golint)
  • Line 46: warning: exported function ProvideSubscribers should have comment or be unexported (golint)

• tilt/internal/k8s/labels.go
  • Line 9: warning: comment on exported const ManagedByLabel should be of the form "ManagedByLabel ..." (golint)
  • Line 11: warning: exported const ManagedByValue should have comment or be unexported (golint)
  • Line 13: warning: exported const ManifestNameLabel should have comment or be unexported (golint)
  • Line 15: warning: exported function TiltManagedByLabel should have comment or be unexported (golint)
  • Line 22: warning: exported function ManagedByTiltSelector should have comment or be unexported (golint)
  • Line 26: warning: exported function NewTiltLabelMap should have comment or be unexported (golint)
  • Line 32: warning: exported function LabelPairsToSelector should have comment or be unexported (golint)

• tilt/internal/tiltfile/probe/probe.go
  • Line 25: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 29: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 33: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 49: warning: exported type Probe should have comment or be unexported (golint)
  • Line 71: warning: exported method Probe.Type should have comment or be unexported (golint)
  • Line 148: warning: exported type ExecAction should have comment or be unexported (golint)
  • Line 155: warning: exported method ExecAction.ValueOrNone should have comment or be unexported (golint)
  • Line 179: warning: exported method ExecAction.Type should have comment or be unexported (golint)
  • Line 198: warning: exported type HTTPGetAction should have comment or be unexported (golint)
  • Line 220: warning: exported method HTTPGetAction.ValueOrNone should have comment or be unexported (golint)
  • Line 229: warning: exported method HTTPGetAction.Type should have comment or be unexported (golint)
  • Line 265: warning: exported type TCPSocketAction should have comment or be unexported (golint)
  • Line 287: warning: exported method TCPSocketAction.ValueOrNone should have comment or be unexported (golint)
  • Line 296: warning: exported method TCPSocketAction.Type should have comment or be unexported (golint)

• tilt/internal/k8s/serialize.go
  • Line 17: warning: exported function ParseYAMLFromString should have comment or be unexported (golint)
  • Line 87: warning: comment on exported function ParseYAML should be of the form "ParseYAML ..." (golint)
  • Line 131: warning: comment on exported function SerializeSpecYAML should be of the form "SerializeSpecYAML ..." (golint)
  • Line 143: warning: exported function SerializeSpecYAMLToBuffer should have comment or be unexported (golint)

• tilt/pkg/model/logstore/logstore.go
  • Line 27: warning: exported type Span should have comment or be unexported (golint)
  • Line 33: warning: exported method Span.Clone should have comment or be unexported (golint)
  • Line 38: warning: exported type SpanID should have comment or be unexported (golint)
  • Line 40: warning: exported type LogSegment should have comment or be unexported (golint)
  • Line 60: warning: comment on exported method LogSegment.CanContinueLine should be of the form "CanContinueLine ..." (golint)
  • Line 65: warning: exported method LogSegment.StartsLine should have comment or be unexported (golint)
  • Line 69: warning: exported method LogSegment.IsComplete should have comment or be unexported (golint)
  • Line 74: warning: exported method LogSegment.Len should have comment or be unexported (golint)
  • Line 117: warning: exported type LogEvent should have comment or be unexported (golint)
  • Line 130: warning: comment on exported type Checkpoint should be of the form "Checkpoint ..." (with optional leading article) (golint)
  • Line 136: warning: comment on exported type LogStore should be of the form "LogStore ..." (with optional leading article) (golint)
  • Line 161: warning: exported function NewLogStoreForTesting should have comment or be unexported (golint)
  • Line 167: warning: exported function NewLogStore should have comment or be unexported (golint)
  • Line 176: warning: exported method LogStore.Checkpoint should have comment or be unexported (golint)
  • Line 237: warning: exported method LogStore.ScrubSecretsStartingAt should have comment or be unexported (golint)
  • Line 246: warning: exported method LogStore.Append should have comment or be unexported (golint)
  • Line 281: warning: exported method LogStore.Empty should have comment or be unexported (golint)
  • Line 285: warning: comment on exported method LogStore.Tail should be of the form "Tail ..." (golint)
  • Line 290: warning: comment on exported method LogStore.TailSpan should be of the form "TailSpan ..." (golint)
  • Line 371: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 412: warning: comment on exported method LogStore.ContinuingString should be of the form "ContinuingString ..." (golint)
  • Line 427: warning: exported method LogStore.ContinuingStringWithOptions should have comment or be unexported (golint)
  • Line 436: warning: exported method LogStore.IsLastSegmentUncompleted should have comment or be unexported (golint)
  • Line 444: warning: exported method LogStore.ContinuingLines should have comment or be unexported (golint)
  • Line 448: warning: exported method LogStore.ContinuingLinesWithOptions should have comment or be unexported (golint)
  • Line 511: warning: exported method LogStore.ToLogList should have comment or be unexported (golint)
  • Line 591: warning: exported method LogStore.SpanLog should have comment or be unexported (golint)
  • Line 599: warning: exported method LogStore.Warnings should have comment or be unexported (golint)
  • Line 632: warning: exported method LogStore.ManifestLog should have comment or be unexported (golint)
  • Line 664: warning: exported type LineOptions should have comment or be unexported (golint)

• tilt/internal/engine/telemetry/start_tracker.go
  • Line 11: warning: exported type StartTracker should have comment or be unexported (golint)
  • Line 17: warning: exported function NewStartTracker should have comment or be unexported (golint)
  • Line 21: warning: exported method StartTracker.OnChange should have comment or be unexported (golint)

• tilt/internal/k8s/jsonpath/jsonpath.go
  • Line 29: warning: exported type JSONPath should have comment or be unexported (golint)
  • Line 79: warning: exported method JSONPath.FindResults should have comment or be unexported (golint)

• tilt/internal/controllers/core/extension/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/build/docker_builder.go
  • Line 38: warning: comment on exported type DockerKubeConnection should be of the form "DockerKubeConnection ..." (with optional leading article) (golint)
  • Line 44: warning: exported type DockerBuilder should have comment or be unexported (golint)
  • Line 54: warning: exported function DefaultDockerBuilder should have comment or be unexported (golint)
  • Line 60: warning: exported function NewDockerImageBuilder should have comment or be unexported (golint)

• tilt/internal/rty/text.go
  • Line 11: warning: exported type StringBuilder should have comment or be unexported (golint)
  • Line 19: warning: exported function NewStringBuilder should have comment or be unexported (golint)
  • Line 65: warning: exported type StringLayout should have comment or be unexported (golint)
  • Line 71: warning: exported function TextString should have comment or be unexported (golint)
  • Line 75: warning: exported function ColoredString should have comment or be unexported (golint)
  • Line 79: warning: exported function BgColoredString should have comment or be unexported (golint)
  • Line 83: warning: exported method StringLayout.Size should have comment or be unexported (golint)
  • Line 87: warning: exported method StringLayout.Render should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/filewatch_types.go
  • Line 36: warning: comment on exported type FileWatch should be of the form "FileWatch ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported type FileWatchList should be of the form "FileWatchList ..." (with optional leading article) (golint)
  • Line 63: warning: exported type IgnoreDef should have comment or be unexported (golint)
  • Line 78: warning: exported method FileWatch.GetObjectMeta should have comment or be unexported (golint)
  • Line 82: warning: exported method FileWatch.GetSpec should have comment or be unexported (golint)
  • Line 86: warning: exported method FileWatch.NamespaceScoped should have comment or be unexported (golint)
  • Line 90: warning: exported method FileWatch.ShortNames should have comment or be unexported (golint)
  • Line 94: warning: exported method FileWatch.New should have comment or be unexported (golint)
  • Line 98: warning: exported method FileWatch.NewList should have comment or be unexported (golint)
  • Line 102: warning: exported method FileWatch.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 110: warning: exported method FileWatch.IsStorageVersion should have comment or be unexported (golint)
  • Line 114: warning: exported method FileWatch.Validate should have comment or be unexported (golint)
  • Line 126: warning: exported method FileWatchList.GetListMeta should have comment or be unexported (golint)
  • Line 148: warning: exported type FileEvent should have comment or be unexported (golint)
  • Line 161: warning: exported method FileWatch.GetStatus should have comment or be unexported (golint)
  • Line 168: warning: exported method FileWatchStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/path.go
  • Line 9: warning: comment on exported function AbsPath should be of the form "AbsPath ..." (golint)
  • Line 18: warning: exported function AbsWorkingDir should have comment or be unexported (golint)
  • Line 22: warning: comment on exported function CurrentExecPath should be of the form "CurrentExecPath ..." (golint)

• tilt/internal/containerupdate/fake_container_updater.go
  • Line 11: warning: exported type FakeContainerUpdater should have comment or be unexported (golint)
  • Line 17: warning: exported type UpdateContainerCall should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeContainerUpdater.SetUpdateErr should have comment or be unexported (golint)
  • Line 29: warning: exported method FakeContainerUpdater.UpdateContainer should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/objectselector.go
  • Line 3: warning: comment on exported type ObjectSelector should be of the form "ObjectSelector ..." (with optional leading article) (golint)

• tilt/internal/engine/buildcontrol/build_errors.go
  • Line 12: warning: comment on exported type RedirectToNextBuilder should be of the form "RedirectToNextBuilder ..." (with optional leading article) (golint)
  • Line 27: warning: exported function WrapRedirectToNextBuilder should have comment or be unexported (golint)
  • Line 31: warning: exported function SilentRedirectToNextBuilderf should have comment or be unexported (golint)
  • Line 36: warning: exported function RedirectToNextBuilderInfof should have comment or be unexported (golint)
  • Line 42: warning: comment on exported type DontFallBackError should be of the form "DontFallBackError ..." (with optional leading article) (golint)
  • Line 48: warning: exported function WrapDontFallBackError should have comment or be unexported (golint)
  • Line 55: warning: exported function DontFallBackErrorf should have comment or be unexported (golint)
  • Line 59: warning: exported function IsDontFallBackError should have comment or be unexported (golint)
  • Line 66: warning: comment on exported function IsFatalError should be of the form "IsFatalError ..." (golint)
  • Line 73: warning: exported function ShouldFallBackForErr should have comment or be unexported (golint)

• tilt/internal/hud/terminal_stream.go
  • Line 10: warning: exported type TerminalStream should have comment or be unexported (golint)
  • Line 16: warning: exported function NewTerminalStream should have comment or be unexported (golint)
  • Line 20: warning: comment on exported method TerminalStream.TearDown should be of the form "TearDown ..." (golint)
  • Line 44: warning: exported method TerminalStream.OnChange should have comment or be unexported (golint)

• tilt/internal/controllers/core/tiltfile/filewatch.go
  • Line 17: warning: exported type WatchInputs should have comment or be unexported (golint)
  • Line 27: warning: exported type WatchableTarget should have comment or be unexported (golint)
  • Line 63: warning: comment on exported function ToFileWatchObjects should be of the form "ToFileWatchObjects ..." (golint)

• tilt/internal/tiltfile/wire.go
  • Line 11: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/pkg/model/matcher.go
  • Line 11: warning: exported type PathMatcher should have comment or be unexported (golint)
  • Line 26: warning: exported var EmptyMatcher should have comment or be unexported (golint)
  • Line 108: warning: exported function NewPathSet should have comment or be unexported (golint)
  • Line 115: warning: exported method PathSet.Empty should have comment or be unexported (golint)
  • Line 134: warning: exported type CompositePathMatcher should have comment or be unexported (golint)
  • Line 138: warning: exported function NewCompositeMatcher should have comment or be unexported (golint)
  • Line 145: warning: exported method CompositePathMatcher.Matches should have comment or be unexported (golint)
  • Line 158: warning: exported method CompositePathMatcher.MatchesEntireDir should have comment or be unexported (golint)

• tilt/internal/tiltfile/links/links.go
  • Line 17: warning: exported type Link should have comment or be unexported (golint)
  • Line 24: warning: comment on exported type LinkList should be of the form "LinkList ..." (with optional leading article) (golint)
  • Line 30: warning: exported method LinkList.Unpack should have comment or be unexported (golint)
  • Line 76: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 81: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 85: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/docker/options.go
  • Line 5: warning: exported type BuildOptions should have comment or be unexported (golint)

• tilt/internal/docker/test_state.go
  • Line 11: warning: exported function NewCreatedContainerState should have comment or be unexported (golint)
  • Line 19: warning: exported function NewRunningContainerState should have comment or be unexported (golint)
  • Line 27: warning: exported function NewExitSuccessContainerState should have comment or be unexported (golint)
  • Line 35: warning: exported function NewExitErrorContainerState should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/plugin.go
  • Line 5: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 11: warning: exported type OnExecPlugin should have comment or be unexported (golint)
  • Line 18: warning: exported type OnBuiltinCallPlugin should have comment or be unexported (golint)
  • Line 25: warning: comment on exported type StatefulPlugin should be of the form "StatefulPlugin ..." (with optional leading article) (golint)

• tilt/internal/engine/analytics/analytics_updater.go
  • Line 13: warning: exported type CmdTags should have comment or be unexported (golint)
  • Line 15: warning: exported method CmdTags.AsMap should have comment or be unexported (golint)
  • Line 19: warning: exported type AnalyticsUpdater should have comment or be unexported (golint)
  • Line 26: warning: exported function NewAnalyticsUpdater should have comment or be unexported (golint)
  • Line 35: warning: exported method AnalyticsUpdater.OnChange should have comment or be unexported (golint)

• tilt/internal/cloud/io.go
  • Line 18: warning: exported type Snapshotter should have comment or be unexported (golint)
  • Line 23: warning: exported function NewSnapshotter should have comment or be unexported (golint)
  • Line 30: warning: exported method Snapshotter.WriteSnapshot should have comment or be unexported (golint)
  • Line 50: warning: exported function WriteSnapshotTo should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8s.go
  • Line 28: warning: error var emptyYAMLError should have name of the form errFoo (golint)
  • Line 374: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 835: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/docker/wire.go
  • Line 5: warning: exported function ProvideLocalAsDefault should have comment or be unexported (golint)
  • Line 8: warning: exported function ProvideClusterAsDefault should have comment or be unexported (golint)
  • Line 12: warning: comment on exported var SwitchWireSet should be of the form "SwitchWireSet ..." (golint)
  • Line 22: warning: comment on exported var ClusterWireSet should be of the form "ClusterWireSet ..." (golint)
  • Line 30: warning: comment on exported var LocalWireSet should be of the form "LocalWireSet ..." (golint)
  • Line 37: warning: exported function ProvideEmptyClusterEnv should have comment or be unexported (golint)

• tilt/internal/store/logger.go
  • Line 16: warning: exported function NewLogActionLogger should have comment or be unexported (golint)
  • Line 24: warning: comment on exported function MustObjectLogHandler should be of the form "MustObjectLogHandler ..." (golint)
  • Line 34: warning: comment on exported function WithObjectLogHandler should be of the form "WithObjectLogHandler ..." (golint)

• tilt/pkg/apis/core/v1alpha1/tiltfile_types.go
  • Line 49: warning: comment on exported type TiltfileList should be of the form "TiltfileList ..." (with optional leading article) (golint)
  • Line 75: warning: exported method Tiltfile.GetObjectMeta should have comment or be unexported (golint)
  • Line 79: warning: exported method Tiltfile.NamespaceScoped should have comment or be unexported (golint)
  • Line 83: warning: exported method Tiltfile.New should have comment or be unexported (golint)
  • Line 87: warning: exported method Tiltfile.NewList should have comment or be unexported (golint)
  • Line 91: warning: exported method Tiltfile.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 99: warning: exported method Tiltfile.IsStorageVersion should have comment or be unexported (golint)
  • Line 103: warning: exported method Tiltfile.Validate should have comment or be unexported (golint)
  • Line 110: warning: exported method TiltfileList.GetListMeta should have comment or be unexported (golint)
  • Line 132: warning: exported method Tiltfile.GetStatus should have comment or be unexported (golint)
  • Line 139: warning: exported method TiltfileStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/engine/buildcontroller.go
  • Line 16: warning: exported type BuildController should have comment or be unexported (golint)
  • Line 35: warning: exported function NewBuildController should have comment or be unexported (golint)
  • Line 79: warning: exported method BuildController.DisableForTesting should have comment or be unexported (golint)
  • Line 83: warning: exported method BuildController.OnChange should have comment or be unexported (golint)
  • Line 134: warning: exported type BuildLogActionWriter should have comment or be unexported (golint)
  • Line 145: warning: exported function SpanIDForBuildLog should have comment or be unexported (golint)

• tilt/internal/localexec/localexec.go
  • Line 16: warning: comment on exported type Env should be of the form "Env ..." (with optional leading article) (golint)
  • Line 22: warning: exported function EmptyEnv should have comment or be unexported (golint)
  • Line 28: warning: exported function DefaultEnv should have comment or be unexported (golint)
  • Line 46: warning: exported method Env.Add should have comment or be unexported (golint)

• tilt/pkg/model/logstore.go
  • Line 3: warning: exported type LogSpanID should have comment or be unexported (golint)

• tilt/internal/k8s/locator.go
  • Line 17: warning: exported type ImageLocator should have comment or be unexported (golint)
  • Line 40: warning: exported function LocatorMatchesOne should have comment or be unexported (golint)
  • Line 49: warning: exported type JSONPathImageLocator should have comment or be unexported (golint)
  • Line 54: warning: exported function MustJSONPathImageLocator should have comment or be unexported (golint)
  • Line 62: warning: exported function NewJSONPathImageLocator should have comment or be unexported (golint)
  • Line 73: warning: exported method JSONPathImageLocator.ToSpec should have comment or be unexported (golint)
  • Line 80: warning: exported method JSONPathImageLocator.EqualsImageLocator should have comment or be unexported (golint)
  • Line 90: warning: exported method JSONPathImageLocator.MatchesType should have comment or be unexported (golint)
  • Line 101: warning: exported method JSONPathImageLocator.Extract should have comment or be unexported (golint)
  • Line 123: warning: exported method JSONPathImageLocator.Inject should have comment or be unexported (golint)
  • Line 153: warning: exported type JSONPathImageObjectLocator should have comment or be unexported (golint)
  • Line 160: warning: exported function MustJSONPathImageObjectLocator should have comment or be unexported (golint)
  • Line 168: warning: exported function NewJSONPathImageObjectLocator should have comment or be unexported (golint)
  • Line 181: warning: exported method JSONPathImageObjectLocator.EqualsImageLocator should have comment or be unexported (golint)
  • Line 192: warning: exported method JSONPathImageObjectLocator.MatchesType should have comment or be unexported (golint)
  • Line 224: warning: exported method JSONPathImageObjectLocator.Extract should have comment or be unexported (golint)
  • Line 244: warning: comment on exported method JSONPathImageObjectLocator.Inject should be of the form "Inject ..." (golint)
  • Line 275: warning: exported method JSONPathImageObjectLocator.ToSpec should have comment or be unexported (golint)

• tilt/internal/store/json.go
  • Line 17: warning: exported function CreateEngineStateEncoder should have comment or be unexported (golint)

• tilt/internal/build/tar.go
  • Line 21: warning: exported type ArchiveBuilder should have comment or be unexported (golint)
  • Line 27: warning: exported function NewArchiveBuilder should have comment or be unexported (golint)
  • Line 36: warning: exported method ArchiveBuilder.Close should have comment or be unexported (golint)
  • Line 105: warning: comment on exported method ArchiveBuilder.Paths should be of the form "Paths ..." (golint)
  • Line 275: warning: exported function TarDfOnly should have comment or be unexported (golint)
  • Line 284: warning: exported function TarPath should have comment or be unexported (golint)
  • Line 299: warning: exported function TarArchiveForPaths should have comment or be unexported (golint)

• tilt/tools/devlog/log_to_file.go
  • Line 45: warning: comment on exported function Logf should be of the form "Logf ..." (golint)

• tilt/internal/build/moby/archive_unix.go
  • Line 31: warning: exported function ChmodTarEntry should have comment or be unexported (golint)

• tilt/pkg/model/secret.go
  • Line 14: warning: comment on exported type SecretSet should be of the form "SecretSet ..." (with optional leading article) (golint)
  • Line 21: warning: exported method SecretSet.AddAll should have comment or be unexported (golint)
  • Line 27: warning: exported method SecretSet.AddSecret should have comment or be unexported (golint)
  • Line 39: warning: exported method SecretSet.Scrub should have comment or be unexported (golint)
  • Line 46: warning: exported type Secret should have comment or be unexported (golint)
  • Line 60: warning: exported method Secret.Scrub should have comment or be unexported (golint)

• tilt/pkg/model/orchestrator.go
  • Line 3: warning: comment on exported type Orchestrator should be of the form "Orchestrator ..." (with optional leading article) (golint)
  • Line 6: warning: exported const OrchestratorUnknown should have comment or be unexported (golint)
  • Line 7: warning: exported const OrchestratorK8s should have comment or be unexported (golint)
  • Line 8: warning: exported const OrchestratorDC should have comment or be unexported (golint)

• tilt/internal/tiltfile/print/print.go
  • Line 12: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 15: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 19: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/dockerfile/dockerfile.go
  • Line 14: warning: exported var ErrAddInDockerfile should have comment or be unexported (golint)
  • Line 17: warning: exported type Dockerfile should have comment or be unexported (golint)
  • Line 19: warning: exported method Dockerfile.Empty should have comment or be unexported (golint)
  • Line 23: warning: comment on exported function FromExisting should be of the form "FromExisting ..." (golint)
  • Line 30: warning: exported method Dockerfile.Append should have comment or be unexported (golint)
  • Line 34: warning: exported method Dockerfile.Join should have comment or be unexported (golint)
  • Line 38: warning: exported method Dockerfile.WithLabel should have comment or be unexported (golint)
  • Line 42: warning: exported method Dockerfile.AddAll should have comment or be unexported (golint)
  • Line 46: warning: exported method Dockerfile.Run should have comment or be unexported (golint)
  • Line 50: warning: exported method Dockerfile.Entrypoint should have comment or be unexported (golint)
  • Line 54: warning: exported method Dockerfile.RmPaths should have comment or be unexported (golint)
  • Line 77: warning: comment on exported method Dockerfile.SplitIntoBaseDockerfile should be of the form "SplitIntoBaseDockerfile ..." (golint)
  • Line 116: warning: exported method Dockerfile.ValidateBaseDockerfile should have comment or be unexported (golint)
  • Line 133: warning: comment on exported method Dockerfile.FindImages should be of the form "FindImages ..." (golint)

• tilt/internal/controllers/builder.go
  • Line 16: warning: exported type Controller should have comment or be unexported (golint)
  • Line 21: warning: exported type ControllerBuilder should have comment or be unexported (golint)
  • Line 26: warning: exported function NewControllerBuilder should have comment or be unexported (golint)
  • Line 37: warning: exported method ControllerBuilder.OnChange should have comment or be unexported (golint)
  • Line 41: warning: exported method ControllerBuilder.SetUp should have comment or be unexported (golint)
  • Line 78: warning: exported method ControllerBuilder.TearDown should have comment or be unexported (golint)

• tilt/internal/container/default_registry.go
  • Line 17: warning: exported type Registry should have comment or be unexported (golint)
  • Line 52: warning: exported method Registry.Empty should have comment or be unexported (golint)
  • Line 54: warning: exported function NewRegistry should have comment or be unexported (golint)
  • Line 59: warning: exported function MustNewRegistry should have comment or be unexported (golint)
  • Line 67: warning: exported function NewRegistryWithHostFromCluster should have comment or be unexported (golint)
  • Line 72: warning: exported function MustNewRegistryWithHostFromCluster should have comment or be unexported (golint)
  • Line 80: warning: exported method Registry.Validate should have comment or be unexported (golint)
  • Line 145: warning: exported method Registry.ReplaceRegistryForLocalRef should have comment or be unexported (golint)
  • Line 149: warning: exported method Registry.ReplaceRegistryForClusterRef should have comment or be unexported (golint)

• tilt/internal/tiltfile/tiltfile.go
  • Line 41: warning: exported const FileName should have comment or be unexported (golint)
  • Line 43: warning: exported type TiltfileLoadResult should have comment or be unexported (golint)
  • Line 64: warning: exported method TiltfileLoadResult.Orchestrator should have comment or be unexported (golint)
  • Line 75: warning: exported type TiltfileLoader should have comment or be unexported (golint)
  • Line 85: warning: exported function ProvideTiltfileLoader should have comment or be unexported (golint)

• tilt/internal/k8s/object_selector.go
  • Line 14: warning: comment on exported type ObjectSelector should be of the form "ObjectSelector ..." (with optional leading article) (golint)
  • Line 24: warning: exported function ParseObjectSelector should have comment or be unexported (golint)
  • Line 53: warning: exported function SelectorStringFromParts should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function SelectorFromString should be of the form "SelectorFromString ..." (golint)
  • Line 85: warning: comment on exported function NewFullmatchCaseInsensitiveObjectSelector should be of the form "NewFullmatchCaseInsensitiveObjectSelector ..." (golint)
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 112: warning: comment on exported function MustKindSelector should be of the form "MustKindSelector ..." (golint)
  • Line 121: warning: comment on exported function MustNameSelector should be of the form "MustNameSelector ..." (golint)
  • Line 130: warning: comment on exported function NewPartialMatchObjectSelector should be of the form "NewPartialMatchObjectSelector ..." (golint)
  • Line 142: warning: exported method ObjectSelector.EqualsSelector should have comment or be unexported (golint)
  • Line 146: warning: exported method ObjectSelector.Matches should have comment or be unexported (golint)
  • Line 146: warning: receiver name k should be consistent with previous receiver name o1 for ObjectSelector (golint)
  • Line 154: warning: exported method ObjectSelector.ToSpec should have comment or be unexported (golint)
  • Line 154: warning: receiver name k should be consistent with previous receiver name o1 for ObjectSelector (golint)

• tilt/internal/engine/k8swatch/actions.go
  • Line 15: warning: exported type KubernetesDiscoveryUpdateStatusAction should have comment or be unexported (golint)
  • Line 20: warning: exported method KubernetesDiscoveryUpdateStatusAction.Action should have comment or be unexported (golint)
  • Line 22: warning: exported function NewKubernetesDiscoveryUpdateStatusAction should have comment or be unexported (golint)
  • Line 29: warning: exported type ServiceChangeAction should have comment or be unexported (golint)
  • Line 35: warning: exported method ServiceChangeAction.Action should have comment or be unexported (golint)
  • Line 37: warning: exported function NewServiceChangeAction should have comment or be unexported (golint)

• tilt/internal/cli/visitor/visitor.go
  • Line 10: warning: comment on exported type Interface should be of the form "Interface ..." (with optional leading article) (golint)
  • Line 17: warning: exported function Stdin should have comment or be unexported (golint)
  • Line 41: warning: exported function File should have comment or be unexported (golint)
  • Line 59: warning: exported type HTTPClient should have comment or be unexported (golint)
  • Line 63: warning: exported function URL should have comment or be unexported (golint)

• tilt/internal/hud/server/apiserver.go
  • Line 50: warning: exported type WebListener should have comment or be unexported (golint)
  • Line 51: warning: exported type APIServerPort should have comment or be unexported (golint)
  • Line 53: warning: exported type APIServerConfig should have comment or be unexported (golint)
  • Line 55: warning: exported type DynamicInterface should have comment or be unexported (golint)
  • Line 57: warning: exported function ProvideMemConn should have comment or be unexported (golint)
  • Line 61: warning: exported function ProvideKeyCert should have comment or be unexported (golint)
  • Line 65: warning: comment on exported function ProvideConfigAccess should be of the form "ProvideConfigAccess ..." (golint)
  • Line 84: warning: comment on exported function ProvideWebListener should be of the form "ProvideWebListener ..." (golint)
  • Line 96: warning: comment on exported function ProvideAPIServerPort should be of the form "ProvideAPIServerPort ..." (golint)
  • Line 115: warning: comment on exported function ProvideTiltServerOptions should be of the form "ProvideTiltServerOptions ..." (golint)
  • Line 169: warning: comment on exported function ProvideTiltServerOptionsForTesting should be of the form "ProvideTiltServerOptionsForTesting ..." (golint)
  • Line 189: warning: comment on exported function ProvideTiltDynamic should be of the form "ProvideTiltDynamic ..." (golint)

• tilt/internal/engine/upper.go
  • Line 39: warning: comment on exported type Upper should be of the form "Upper ..." (with optional leading article) (golint)
  • Line 45: warning: exported type ServiceWatcherMaker should have comment or be unexported (golint)
  • Line 46: warning: exported type PodWatcherMaker should have comment or be unexported (golint)
  • Line 48: warning: exported function NewUpper should have comment or be unexported (golint)
  • Line 63: warning: exported method Upper.Dispatch should have comment or be unexported (golint)
  • Line 67: warning: exported method Upper.Start should have comment or be unexported (golint)
  • Line 100: warning: exported method Upper.Init should have comment or be unexported (golint)
  • Line 184: warning: exported var UpperReducer should have comment or be unexported (golint)

• tilt/pkg/model/local_target.go
  • Line 11: warning: exported type LocalTarget should have comment or be unexported (golint)
  • Line 35: warning: exported function NewLocalTarget should have comment or be unexported (golint)
  • Line 53: warning: exported method LocalTarget.UpdateCmdName should have comment or be unexported (golint)
  • Line 60: warning: exported method LocalTarget.Empty should have comment or be unexported (golint)
  • Line 64: warning: exported method LocalTarget.WithAllowParallel should have comment or be unexported (golint)
  • Line 69: warning: exported method LocalTarget.WithRepos should have comment or be unexported (golint)
  • Line 74: warning: exported method LocalTarget.WithIgnores should have comment or be unexported (golint)
  • Line 79: warning: exported method LocalTarget.WithLinks should have comment or be unexported (golint)
  • Line 84: warning: exported method LocalTarget.WithIsTest should have comment or be unexported (golint)
  • Line 89: warning: exported method LocalTarget.WithTags should have comment or be unexported (golint)
  • Line 94: warning: exported method LocalTarget.WithReadinessProbe should have comment or be unexported (golint)
  • Line 99: warning: exported method LocalTarget.ID should have comment or be unexported (golint)
  • Line 106: warning: exported method LocalTarget.DependencyIDs should have comment or be unexported (golint)
  • Line 110: warning: exported method LocalTarget.Validate should have comment or be unexported (golint)
  • Line 120: warning: comment on exported method LocalTarget.Dependencies should be of the form "Dependencies ..." (golint)
  • Line 125: warning: exported method LocalTarget.LocalRepos should have comment or be unexported (golint)
  • Line 129: warning: exported method LocalTarget.Dockerignores should have comment or be unexported (golint)
  • Line 133: warning: exported method LocalTarget.IgnoredLocalDirectories should have comment or be unexported (golint)

• tilt/pkg/model/api.go
  • Line 8: warning: comment on exported type APIServerName should be of the form "APIServerName ..." (with optional leading article) (golint)
  • Line 14: warning: comment on exported function ValidateAPIServerName should be of the form "ValidateAPIServerName ..." (golint)
  • Line 22: warning: comment on exported function DefaultAPIServerName should be of the form "DefaultAPIServerName ..." (golint)
  • Line 30: warning: comment on exported function ProvideAPIServerName should be of the form "ProvideAPIServerName ..." (golint)

• tilt/pkg/model/manifest.go
  • Line 21: warning: comment on exported type ManifestName should be of the form "ManifestName ..." (with optional leading article) (golint)
  • Line 23: warning: exported type ManifestNameSet should have comment or be unexported (golint)
  • Line 25: warning: exported function ManifestNames should have comment or be unexported (golint)
  • Line 33: warning: exported const MainTiltfileManifestName should have comment or be unexported (golint)
  • Line 36: warning: exported method ManifestName.TargetName should have comment or be unexported (golint)
  • Line 38: warning: comment on exported type Manifest should be of the form "Manifest ..." (with optional leading article) (golint)
  • Line 63: warning: exported method Manifest.ID should have comment or be unexported (golint)
  • Line 70: warning: exported method Manifest.DependencyIDs should have comment or be unexported (golint)
  • Line 81: warning: comment on exported method Manifest.ReverseDependencyIDs should be of the form "ReverseDependencyIDs ..." (golint)
  • Line 97: warning: exported method Manifest.WithImageTarget should have comment or be unexported (golint)
  • Line 102: warning: exported method Manifest.WithImageTargets should have comment or be unexported (golint)
  • Line 107: warning: exported method Manifest.ImageTargetAt should have comment or be unexported (golint)
  • Line 114: warning: exported method Manifest.ImageTargetWithID should have comment or be unexported (golint)
  • Line 123: warning: exported type DockerBuildArgs should have comment or be unexported (golint)
  • Line 125: warning: exported method Manifest.LocalTarget should have comment or be unexported (golint)
  • Line 130: warning: exported method Manifest.IsLocal should have comment or be unexported (golint)
  • Line 135: warning: exported method Manifest.DockerComposeTarget should have comment or be unexported (golint)
  • Line 140: warning: exported method Manifest.IsDC should have comment or be unexported (golint)
  • Line 145: warning: exported method Manifest.K8sTarget should have comment or be unexported (golint)
  • Line 150: warning: exported method Manifest.IsK8s should have comment or be unexported (golint)
  • Line 155: warning: exported method Manifest.PodReadinessMode should have comment or be unexported (golint)
  • Line 162: warning: exported method Manifest.WithDeployTarget should have comment or be unexported (golint)
  • Line 175: warning: exported method Manifest.WithTriggerMode should have comment or be unexported (golint)
  • Line 180: warning: exported method Manifest.TargetIDSet should have comment or be unexported (golint)
  • Line 189: warning: exported method Manifest.TargetSpecs should have comment or be unexported (golint)
  • Line 200: warning: exported method Manifest.IsImageDeployed should have comment or be unexported (golint)
  • Line 210: warning: exported method Manifest.LocalPaths should have comment or be unexported (golint)
  • Line 227: warning: exported method Manifest.WithLabels should have comment or be unexported (golint)
  • Line 235: warning: exported method Manifest.Validate should have comment or be unexported (golint)
  • Line 271: warning: receiver name m1 should be consistent with previous receiver name m for Manifest (golint)
  • Line 289: warning: exported method Manifest.ManifestName should have comment or be unexported (golint)
  • Line 293: warning: exported function LocalRefSelectorsForManifests should have comment or be unexported (golint)
  • Line 306: warning: exported type Sync should have comment or be unexported (golint)
  • Line 311: warning: exported type LocalGitRepo should have comment or be unexported (golint)
  • Line 315: warning: exported method LocalGitRepo.IsRepo should have comment or be unexported (golint)
  • Line 317: warning: exported type Run should have comment or be unexported (golint)
  • Line 325: warning: exported method Run.WithTriggers should have comment or be unexported (golint)
  • Line 337: warning: exported type PortForward should have comment or be unexported (golint)
  • Line 359: warning: exported method PortForward.PathForAppend should have comment or be unexported (golint)
  • Line 366: warning: exported method PortForward.WithPath should have comment or be unexported (golint)
  • Line 371: warning: exported function MustPortForward should have comment or be unexported (golint)
  • Line 389: warning: comment on exported type Link should be of the form "Link ..." (with optional leading article) (golint)
  • Line 400: warning: exported method Link.URLString should have comment or be unexported (golint)
  • Line 402: warning: exported function NewLink should have comment or be unexported (golint)
  • Line 413: warning: exported function MustNewLink should have comment or be unexported (golint)
  • Line 428: warning: exported method PortForward.ToLink should have comment or be unexported (golint)
  • Line 440: warning: exported function LinksToURLStrings should have comment or be unexported (golint)

• tilt/internal/docker/env.go
  • Line 25: warning: comment on exported type Env should be of the form "Env ..." (with optional leading article) (golint)
  • Line 53: warning: comment on exported method Env.WillBuildToKubeContext should be of the form "WillBuildToKubeContext ..." (golint)
  • Line 63: warning: comment on exported method Env.AsEnviron should be of the form "AsEnviron ..." (golint)
  • Line 81: warning: comment on exported type ClusterEnv should be of the form "ClusterEnv ..." (with optional leading article) (golint)
  • Line 83: warning: exported type LocalEnv should have comment or be unexported (golint)
  • Line 85: warning: exported function ProvideLocalEnv should have comment or be unexported (golint)
  • Line 103: warning: exported function ProvideClusterEnv should have comment or be unexported (golint)

• tilt/internal/docker/switch.go
  • Line 26: warning: exported function ProvideSwitchCli should have comment or be unexported (golint)

• tilt/internal/tiltfile/config/config.go
  • Line 15: warning: exported const UserConfigFileName should have comment or be unexported (golint)
  • Line 17: warning: exported type Settings should have comment or be unexported (golint)
  • Line 28: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 33: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 37: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 46: warning: exported function MustState should have comment or be unexported (golint)
  • Line 54: warning: exported function GetState should have comment or be unexported (golint)
  • Line 60: warning: exported method Plugin.OnStart should have comment or be unexported (golint)

• tilt/internal/rty/render.go
  • Line 7: warning: exported function NewRTY should have comment or be unexported (golint)

• tilt/internal/tiltfile/docker.go
  • Line 77: warning: exported const UnknownBuild should have comment (or a comment on this block) or be unexported (golint)

• tilt/internal/controllers/core/kubernetesapply/reconciler.go
  • Line 35: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 50: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 60: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 196: warning: comment on exported method Reconciler.ForceApply should be of the form "ForceApply ..." (golint)
  • Line 501: warning: comment on exported type Result should be of the form "Result ..." (with optional leading article) (golint)

• tilt/internal/build/image_reaper.go
  • Line 20: warning: exported type ImageReaper should have comment or be unexported (golint)
  • Line 24: warning: exported function FilterByLabel should have comment or be unexported (golint)
  • Line 28: warning: exported function FilterByLabelValue should have comment or be unexported (golint)
  • Line 32: warning: exported function FilterByRefName should have comment or be unexported (golint)
  • Line 36: warning: exported function NewImageReaper should have comment or be unexported (golint)
  • Line 42: warning: comment on exported method ImageReaper.RemoveTiltImages should be of the form "RemoveTiltImages ..." (golint)

• tilt/internal/testutils/assert.go
  • Line 10: warning: exported function IsNotExistMessage should have comment or be unexported (golint)
  • Line 13: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 19: warning: comment on exported function AssertIsNotExist should be of the form "AssertIsNotExist ..." (golint)

• tilt/internal/docker/image.go
  • Line 7: warning: exported const TagLatest should have comment or be unexported (golint)
  • Line 9: warning: comment on exported type ImgNameAndTag should be of the form "ImgNameAndTag ..." (with optional leading article) (golint)
  • Line 16: warning: exported function ToImgNameAndTag should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/value.go
  • Line 16: warning: comment on exported function ValueOrSequenceToSlice should be of the form "ValueOrSequenceToSlice ..." (golint)
  • Line 36: warning: exported function ValueToAbsPath should have comment or be unexported (golint)
  • Line 50: warning: exported type PathMaker should have comment or be unexported (golint)
  • Line 57: warning: exported method StringSequence.Sequence should have comment or be unexported (golint)
  • Line 65: warning: exported method StringSequence.Unpack should have comment or be unexported (golint)
  • Line 82: warning: exported function SequenceToStringSlice should have comment or be unexported (golint)
  • Line 100: warning: exported function StringSliceToList should have comment or be unexported (golint)
  • Line 108: warning: comment on exported function ValueGroupToCmdHelper should be of the form "ValueGroupToCmdHelper ..." (golint)
  • Line 119: warning: comment on exported function ValueToHostCmd should be of the form "ValueToHostCmd ..." (golint)
  • Line 126: warning: exported function ValueToBatCmd should have comment or be unexported (golint)
  • Line 130: warning: exported function ValueToUnixCmd should have comment or be unexported (golint)
  • Line 211: warning: exported method Int32.Unpack should have comment or be unexported (golint)

• tilt/internal/controllers/core/tiltfile/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/controllers/core/cmd/probe.go
  • Line 20: warning: exported var ErrUnsupportedProbeType should have comment or be unexported (golint)
  • Line 22: warning: exported function ProvideProberManager should have comment or be unexported (golint)
  • Line 26: warning: exported type ProberManager should have comment or be unexported (golint)

• tilt/internal/watch/watcher_nonwin.go
  • Line 7: warning: exported function MaybeIncreaseBufferSize should have comment or be unexported (golint)

• tilt/internal/engine/telemetry/actions.go
  • Line 7: warning: exported type TelemetryScriptRanAction should have comment or be unexported (golint)
  • Line 11: warning: exported method TelemetryScriptRanAction.Action should have comment or be unexported (golint)

• tilt/internal/controllers/core/portforward/reconciler_test.go
  • Line 380: warning: context.Context should be the first parameter of a function (golint)
  • Line 386: warning: context.Context should be the first parameter of a function (golint)

• tilt/internal/k8s/testyaml/deleted.go
  • Line 3: warning: exported const OneDeleted should have comment or be unexported (golint)
  • Line 53: warning: exported const TwoDeleted should have comment or be unexported (golint)

• tilt/internal/xdg/fake.go
  • Line 9: warning: exported type FakeBase should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeBase.CacheFile should have comment or be unexported (golint)
  • Line 28: warning: exported method FakeBase.ConfigFile should have comment or be unexported (golint)
  • Line 31: warning: exported method FakeBase.DataFile should have comment or be unexported (golint)
  • Line 34: warning: exported method FakeBase.StateFile should have comment or be unexported (golint)
  • Line 37: warning: exported method FakeBase.RuntimeFile should have comment or be unexported (golint)

• tilt/internal/store/summary.go
  • Line 10: warning: comment on exported type ChangeSet should be of the form "ChangeSet ..." (with optional leading article) (golint)
  • Line 16: warning: exported function NewChangeSet should have comment or be unexported (golint)
  • Line 24: warning: exported method ChangeSet.Empty should have comment or be unexported (golint)
  • Line 36: warning: comment on exported method ChangeSet.AddAll should be of the form "AddAll ..." (golint)
  • Line 48: warning: comment on exported type ChangeSummary should be of the form "ChangeSummary ..." (with optional leading article) (golint)
  • Line 71: warning: exported method ChangeSummary.IsLogOnly should have comment or be unexported (golint)
  • Line 75: warning: exported method ChangeSummary.Add should have comment or be unexported (golint)
  • Line 87: warning: exported function LegacyChangeSummary should have comment or be unexported (golint)
  • Line 91: warning: exported type Summarizer should have comment or be unexported (golint)

• tilt/internal/k8s/jsonpath/value.go
  • Line 5: warning: comment on exported type Value should be of the form "Value ..." (with optional leading article) (golint)
  • Line 20: warning: exported function Wrap should have comment or be unexported (golint)
  • Line 24: warning: exported function ValueOf should have comment or be unexported (golint)
  • Line 28: warning: exported method Value.CanSet should have comment or be unexported (golint)
  • Line 35: warning: exported method Value.Set should have comment or be unexported (golint)
  • Line 44: warning: exported method Value.Sibling should have comment or be unexported (golint)

• tilt/internal/cli/up.go
  • Line 29: warning: exported const DefaultWebDevPort should have comment or be unexported (golint)
  • Line 170: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 204: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 249: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/output/output.go
  • Line 8: warning: exported var OriginalStderr should have comment or be unexported (golint)
  • Line 14: warning: exported function CaptureAllOutput should have comment or be unexported (golint)

• tilt/internal/docker/buildkit/secret.go
  • Line 34: warning: exported function ParseSecretSpecs should have comment or be unexported (golint)

• tilt/internal/tiltfile/metrics/metrics.go
  • Line 11: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 13: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 17: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 21: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 48: warning: exported function MustState should have comment or be unexported (golint)
  • Line 56: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/hud/components.go
  • Line 15: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/controllers/apiset/apiset.go
  • Line 9: warning: comment on exported type ObjectSet should be of the form "ObjectSet ..." (with optional leading article) (golint)
  • Line 12: warning: comment on exported type TypedObjectSet should be of the form "TypedObjectSet ..." (with optional leading article) (golint)
  • Line 15: warning: comment on exported type Object should be of the form "Object ..." (with optional leading article) (golint)

• tilt/pkg/apis/core/v1alpha1/imagemap_types.go
  • Line 64: warning: comment on exported type ImageMapList should be of the form "ImageMapList ..." (with optional leading article) (golint)
  • Line 110: warning: comment on exported type ImageMapOverrideCommand should be of the form "ImageMapOverrideCommand ..." (with optional leading article) (golint)
  • Line 120: warning: comment on exported type ImageMapOverrideArgs should be of the form "ImageMapOverrideArgs ..." (with optional leading article) (golint)
  • Line 134: warning: exported method ImageMap.GetSpec should have comment or be unexported (golint)
  • Line 138: warning: exported method ImageMap.GetObjectMeta should have comment or be unexported (golint)
  • Line 142: warning: exported method ImageMap.NamespaceScoped should have comment or be unexported (golint)
  • Line 146: warning: exported method ImageMap.ShortNames should have comment or be unexported (golint)
  • Line 150: warning: exported method ImageMap.New should have comment or be unexported (golint)
  • Line 154: warning: exported method ImageMap.NewList should have comment or be unexported (golint)
  • Line 158: warning: exported method ImageMap.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 166: warning: exported method ImageMap.IsStorageVersion should have comment or be unexported (golint)
  • Line 170: warning: exported method ImageMap.Validate should have comment or be unexported (golint)
  • Line 177: warning: exported method ImageMapList.GetListMeta should have comment or be unexported (golint)
  • Line 206: warning: exported method ImageMap.GetStatus should have comment or be unexported (golint)
  • Line 213: warning: exported method ImageMapStatus.CopyTo should have comment or be unexported (golint)

• tilt/pkg/logger/writer.go
  • Line 8: warning: exported type MutexWriter should have comment or be unexported (golint)
  • Line 13: warning: exported function NewMutexWriter should have comment or be unexported (golint)

• tilt/pkg/model/logstore/doc.go
  • Line 1: warning: package comment should be of the form "Package logstore ..." (golint)

• tilt/internal/k8s/container.go
  • Line 12: warning: exported const ContainerIDPrefix should have comment or be unexported (golint)
  • Line 14: warning: comment on exported function FixContainerStatusImages should be of the form "FixContainerStatusImages ..." (golint)
  • Line 56: warning: exported function NormalizeContainerID should have comment or be unexported (golint)
  • Line 68: warning: exported function ContainerSpecOf should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/fixture.go
  • Line 19: warning: comment on exported type Fixture should be of the form "Fixture ..." (with optional leading article) (golint)
  • Line 32: warning: exported function NewFixture should have comment or be unexported (golint)
  • Line 47: warning: exported method Fixture.SetContext should have comment or be unexported (golint)
  • Line 51: warning: exported method Fixture.SetOutput should have comment or be unexported (golint)
  • Line 55: warning: exported method Fixture.OnStart should have comment or be unexported (golint)
  • Line 67: warning: exported method Fixture.ExecFile should have comment or be unexported (golint)
  • Line 76: warning: exported method Fixture.SetLoadInterceptor should have comment or be unexported (golint)
  • Line 80: warning: exported method Fixture.PrintOutput should have comment or be unexported (golint)
  • Line 84: warning: exported method Fixture.Path should have comment or be unexported (golint)
  • Line 88: warning: exported method Fixture.JoinPath should have comment or be unexported (golint)
  • Line 92: warning: exported method Fixture.File should have comment or be unexported (golint)
  • Line 110: warning: exported method Fixture.Symlink should have comment or be unexported (golint)
  • Line 118: warning: exported method Fixture.UseRealFS should have comment or be unexported (golint)
  • Line 125: warning: exported method Fixture.TearDown should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/model.go
  • Line 11: warning: exported type Model should have comment or be unexported (golint)
  • Line 17: warning: exported function NewModel should have comment or be unexported (golint)
  • Line 34: warning: exported method Model.Load should have comment or be unexported (golint)
  • Line 50: warning: exported function ModelFromThread should have comment or be unexported (golint)
  • Line 58: warning: exported function ContextFromThread should have comment or be unexported (golint)

• tilt/internal/store/types.go
  • Line 5: warning: exported type Cmd should have comment or be unexported (golint)
  • Line 6: warning: exported type KubernetesDiscovery should have comment or be unexported (golint)
  • Line 7: warning: exported type PodLogStream should have comment or be unexported (golint)
  • Line 8: warning: exported type PortForward should have comment or be unexported (golint)

• tilt/internal/engine/local/types.go
  • Line 9: warning: exported type Cmd should have comment or be unexported (golint)
  • Line 10: warning: exported type CmdList should have comment or be unexported (golint)
  • Line 11: warning: exported type CmdStatus should have comment or be unexported (golint)
  • Line 12: warning: exported type CmdSpec should have comment or be unexported (golint)
  • Line 13: warning: exported type CmdStateWaiting should have comment or be unexported (golint)
  • Line 14: warning: exported type CmdStateTerminated should have comment or be unexported (golint)
  • Line 15: warning: exported type CmdStateRunning should have comment or be unexported (golint)
  • Line 16: warning: exported type ObjectMeta should have comment or be unexported (golint)

• tilt/internal/hud/webview/view.go
  • Line 41: warning: exported function ToAPITargetSpecs should have comment or be unexported (golint)
  • Line 54: warning: exported function ToBuildRunning should have comment or be unexported (golint)
  • Line 65: warning: exported function ToBuildTerminated should have comment or be unexported (golint)
  • Line 87: warning: exported function ToBuildsTerminated should have comment or be unexported (golint)
  • Line 95: warning: exported function ToAPILinks should have comment or be unexported (golint)

• tilt/pkg/model/extractors.go
  • Line 3: warning: exported function ExtractK8sTargets should have comment or be unexported (golint)
  • Line 15: warning: exported function ExtractImageTargets should have comment or be unexported (golint)
  • Line 27: warning: exported function ExtractDockerComposeTargets should have comment or be unexported (golint)

• tilt/internal/controllers/indexer/list.go
  • Line 13: warning: comment on exported function ListOwnedBy should be of the form "ListOwnedBy ..." (golint)

• tilt/internal/testutils/httptest/http_client.go
  • Line 10: warning: exported type FakeClient should have comment or be unexported (golint)
  • Line 19: warning: exported method FakeClient.Do should have comment or be unexported (golint)
  • Line 32: warning: exported method FakeClient.SetResponse should have comment or be unexported (golint)
  • Line 37: warning: exported method FakeClient.ClearRequests should have comment or be unexported (golint)
  • Line 44: warning: exported method FakeClient.Requests should have comment or be unexported (golint)
  • Line 52: warning: exported function NewFakeClient should have comment or be unexported (golint)
  • Line 59: warning: exported function NewFakeClientEmptyJSON should have comment or be unexported (golint)

• tilt/internal/docker/readcloser.go
  • Line 12: warning: exported function WrapReadCloserWithTearDown should have comment or be unexported (golint)

• tilt/internal/controllers/core/tiltfile/actions.go
  • Line 12: warning: exported type ConfigsReloadStartedAction should have comment or be unexported (golint)
  • Line 20: warning: exported method ConfigsReloadStartedAction.Action should have comment or be unexported (golint)
  • Line 22: warning: exported type ConfigsReloadedAction should have comment or be unexported (golint)
  • Line 49: warning: exported method ConfigsReloadedAction.Action should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/cmd_types.go
  • Line 49: warning: comment on exported type CmdList should be of the form "CmdList ..." (with optional leading article) (golint)
  • Line 109: warning: exported method Cmd.GetSpec should have comment or be unexported (golint)
  • Line 113: warning: exported method Cmd.GetObjectMeta should have comment or be unexported (golint)
  • Line 117: warning: exported method Cmd.NamespaceScoped should have comment or be unexported (golint)
  • Line 121: warning: exported method Cmd.New should have comment or be unexported (golint)
  • Line 125: warning: exported method Cmd.NewList should have comment or be unexported (golint)
  • Line 129: warning: exported method Cmd.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 137: warning: exported method Cmd.IsStorageVersion should have comment or be unexported (golint)
  • Line 141: warning: exported method Cmd.Validate should have comment or be unexported (golint)
  • Line 148: warning: exported method CmdList.GetListMeta should have comment or be unexported (golint)
  • Line 216: warning: exported method Cmd.GetStatus should have comment or be unexported (golint)
  • Line 223: warning: exported method CmdStatus.CopyTo should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/updatestatus_types.go
  • Line 8: warning: comment on exported const UpdateStatusNone should be of the form "UpdateStatusNone ..." (golint)
  • Line 12: warning: comment on exported const UpdateStatusInProgress should be of the form "UpdateStatusInProgress ..." (golint)
  • Line 15: warning: comment on exported const UpdateStatusOK should be of the form "UpdateStatusOK ..." (golint)
  • Line 18: warning: comment on exported const UpdateStatusPending should be of the form "UpdateStatusPending ..." (golint)
  • Line 21: warning: comment on exported const UpdateStatusError should be of the form "UpdateStatusError ..." (golint)
  • Line 24: warning: comment on exported const UpdateStatusNotApplicable should be of the form "UpdateStatusNotApplicable ..." (golint)

• tilt/internal/store/testing_store.go
  • Line 13: warning: exported type TestingStore should have comment or be unexported (golint)
  • Line 21: warning: exported function NewTestingStore should have comment or be unexported (golint)
  • Line 27: warning: exported method TestingStore.LockMutableStateForTesting should have comment or be unexported (golint)
  • Line 32: warning: exported method TestingStore.UnlockMutableState should have comment or be unexported (golint)
  • Line 36: warning: exported method TestingStore.SetState should have comment or be unexported (golint)
  • Line 42: warning: exported method TestingStore.WithState should have comment or be unexported (golint)
  • Line 48: warning: exported method TestingStore.StateMutex should have comment or be unexported (golint)
  • Line 52: warning: exported method TestingStore.RLockState should have comment or be unexported (golint)
  • Line 57: warning: exported method TestingStore.RUnlockState should have comment or be unexported (golint)
  • Line 61: warning: exported method TestingStore.Dispatch should have comment or be unexported (golint)
  • Line 68: warning: exported method TestingStore.ClearActions should have comment or be unexported (golint)
  • Line 75: warning: exported method TestingStore.Actions should have comment or be unexported (golint)
  • Line 82: warning: exported method TestingStore.AssertNoErrorActions should have comment or be unexported (golint)
  • Line 96: warning: exported method TestingStore.WaitForAction should have comment or be unexported (golint)
  • Line 100: warning: comment on exported function WaitForAction should be of the form "WaitForAction ..." (golint)
  • Line 124: warning: comment on exported function AssertNoActionOfType should be of the form "AssertNoActionOfType ..." (golint)

• tilt/internal/watch/temp.go
  • Line 19: warning: comment on exported function NewDirAtRoot should be of the form "NewDirAtRoot ..." (golint)
  • Line 43: warning: comment on exported method TempDir.NewDir should be of the form "NewDir ..." (golint)
  • Line 52: warning: exported method TempDir.NewDeterministicDir should have comment or be unexported (golint)
  • Line 63: warning: exported method TempDir.TearDown should have comment or be unexported (golint)
  • Line 67: warning: exported method TempDir.Path should have comment or be unexported (golint)

• tilt/internal/hud/webview/analytics_nudge.go
  • Line 9: warning: exported function NeedsNudge should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/image_builder.go
  • Line 20: warning: comment on exported var KeyImageRef should be of the form "KeyImageRef ..." (golint)
  • Line 24: warning: exported var KeyBuildError should have comment or be unexported (golint)
  • Line 26: warning: comment on exported var ImageBuildDuration should be of the form "ImageBuildDuration ..." (golint)
  • Line 34: warning: exported var ImageBuildDurationDistribution should have comment or be unexported (golint)
  • Line 39: warning: exported var ImageBuildDurationView should have comment or be unexported (golint)
  • Line 47: warning: exported var ImageBuildCount should have comment or be unexported (golint)
  • Line 55: warning: exported type ImageBuilder should have comment or be unexported (golint)
  • Line 61: warning: exported function NewImageBuilder should have comment or be unexported (golint)
  • Line 69: warning: exported method ImageBuilder.CanReuseRef should have comment or be unexported (golint)
  • Line 82: warning: exported method ImageBuilder.Build should have comment or be unexported (golint)

• tilt/pkg/tiltextension/name.go
  • Line 19: warning: exported function ValidateName should have comment or be unexported (golint)

• tilt/internal/engine/local/actions.go
  • Line 9: warning: exported type CmdCreateAction should have comment or be unexported (golint)
  • Line 13: warning: exported function NewCmdCreateAction should have comment or be unexported (golint)
  • Line 19: warning: exported method CmdCreateAction.Action should have comment or be unexported (golint)
  • Line 21: warning: exported method CmdCreateAction.Summarize should have comment or be unexported (golint)
  • Line 25: warning: exported type CmdUpdateStatusAction should have comment or be unexported (golint)
  • Line 29: warning: exported function NewCmdUpdateStatusAction should have comment or be unexported (golint)
  • Line 33: warning: exported method CmdUpdateStatusAction.Action should have comment or be unexported (golint)
  • Line 35: warning: exported type CmdDeleteAction should have comment or be unexported (golint)
  • Line 39: warning: exported method CmdDeleteAction.Action should have comment or be unexported (golint)
  • Line 41: warning: exported method CmdDeleteAction.Summarize should have comment or be unexported (golint)

• tilt/integration/doc.go
  • Line 1: warning: package comment should be of the form "Package integration ..." (golint)

• tilt/internal/hud/actions.go
  • Line 3: warning: exported type ExitAction should have comment or be unexported (golint)
  • Line 7: warning: exported method ExitAction.Action should have comment or be unexported (golint)
  • Line 9: warning: exported function NewExitAction should have comment or be unexported (golint)
  • Line 13: warning: exported type DumpEngineStateAction should have comment or be unexported (golint)
  • Line 16: warning: exported method DumpEngineStateAction.Action should have comment or be unexported (golint)

• tilt/pkg/model/squash.go
  • Line 7: warning: exported function TrySquash should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8s/readiness.go
  • Line 12: warning: comment on exported type PodReadinessMode should be of the form "PodReadinessMode ..." (with optional leading article) (golint)
  • Line 17: warning: exported method PodReadinessMode.Unpack should have comment or be unexported (golint)

• tilt/internal/testutils/fake_clock.go
  • Line 8: warning: exported type Clock should have comment or be unexported (golint)
  • Line 10: warning: exported type FakeClock should have comment or be unexported (golint)
  • Line 21: warning: exported method FakeClock.Clock should have comment or be unexported (golint)
  • Line 25: warning: exported function NewRandomFakeClock should have comment or be unexported (golint)

• tilt/internal/k8s/jsonpath/node.go
  • Line 34: warning: exported const NodeText should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported var NodeTypeName should have comment or be unexported (golint)
  • Line 63: warning: exported type Node should have comment or be unexported (golint)

• tilt/internal/tiltfile/config/config_def.go
  • Line 30: warning: exported type ConfigDef should have comment or be unexported (golint)
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/engine/buildcontrol/update_mode.go
  • Line 10: warning: exported type UpdateMode should have comment or be unexported (golint)
  • Line 12: warning: comment on exported type UpdateModeFlag should be of the form "UpdateModeFlag ..." (with optional leading article) (golint)
  • Line 16: warning: comment on exported var UpdateModeAuto should be of the form "UpdateModeAuto ..." (golint)
  • Line 19: warning: comment on exported var UpdateModeImage should be of the form "UpdateModeImage ..." (golint)
  • Line 22: warning: comment on exported var UpdateModeContainer should be of the form "UpdateModeContainer ..." (golint)
  • Line 26: warning: comment on exported var UpdateModeKubectlExec should be of the form "UpdateModeKubectlExec ..." (golint)
  • Line 30: warning: exported var AllUpdateModes should have comment or be unexported (golint)
  • Line 37: warning: exported function ProvideUpdateMode should have comment or be unexported (golint)

• tilt/internal/cli/visitor/decode.go
  • Line 15: warning: comment on exported function DecodeAll should be of the form "DecodeAll ..." (golint)
  • Line 30: warning: exported function Decode should have comment or be unexported (golint)
  • Line 44: warning: comment on exported function ParseStream should be of the form "ParseStream ..." (golint)

• tilt/internal/openurl/openurl.go
  • Line 10: warning: exported type OpenURL should have comment or be unexported (golint)
  • Line 12: warning: exported function BrowserOpen should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/target_queue.go
  • Line 16: warning: comment on exported type BuildHandler should be of the form "BuildHandler ..." (with optional leading article) (golint)
  • Line 21: warning: exported type ReuseRefChecker should have comment or be unexported (golint)
  • Line 23: warning: comment on exported type TargetQueue should be of the form "TargetQueue ..." (with optional leading article) (golint)
  • Line 47: warning: exported function NewImageTargetQueue should have comment or be unexported (golint)
  • Line 104: warning: comment on exported method TargetQueue.NewResults should be of the form "NewResults ..." (golint)
  • Line 118: warning: comment on exported method TargetQueue.ReusedResults should be of the form "ReusedResults ..." (golint)
  • Line 131: warning: comment on exported method TargetQueue.AllResults should be of the form "AllResults ..." (golint)
  • Line 144: warning: exported method TargetQueue.CountBuilds should have comment or be unexported (golint)
  • Line 170: warning: exported method TargetQueue.RunBuilds should have comment or be unexported (golint)

• tilt/internal/controllers/core/uibutton/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/internal/tiltfile/k8s/resource.go
  • Line 8: warning: exported type KindInfo should have comment or be unexported (golint)

• tilt/internal/tiltfile/watch/watch.go
  • Line 11: warning: exported type Plugin should have comment or be unexported (golint)
  • Line 14: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 18: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 22: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 51: warning: exported function MustState should have comment or be unexported (golint)
  • Line 59: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/map.go
  • Line 9: warning: exported type StringStringMap should have comment or be unexported (golint)
  • Line 13: warning: exported method StringStringMap.Unpack should have comment or be unexported (golint)
  • Line 39: warning: exported method StringStringMap.AsMap should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/extensionrepo_types.go
  • Line 47: warning: comment on exported type ExtensionRepoList should be of the form "ExtensionRepoList ..." (with optional leading article) (golint)
  • Line 74: warning: exported method ExtensionRepo.GetSpec should have comment or be unexported (golint)
  • Line 78: warning: exported method ExtensionRepo.GetObjectMeta should have comment or be unexported (golint)
  • Line 82: warning: exported method ExtensionRepo.NamespaceScoped should have comment or be unexported (golint)
  • Line 86: warning: exported method ExtensionRepo.New should have comment or be unexported (golint)
  • Line 90: warning: exported method ExtensionRepo.NewList should have comment or be unexported (golint)
  • Line 94: warning: exported method ExtensionRepo.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 102: warning: exported method ExtensionRepo.IsStorageVersion should have comment or be unexported (golint)
  • Line 106: warning: exported method ExtensionRepo.Validate should have comment or be unexported (golint)
  • Line 127: warning: exported method ExtensionRepoList.GetListMeta should have comment or be unexported (golint)
  • Line 151: warning: exported method ExtensionRepo.GetStatus should have comment or be unexported (golint)
  • Line 158: warning: exported method ExtensionRepoStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/cli/visitor/strings.go
  • Line 12: warning: comment on exported function FromStrings should be of the form "FromStrings ..." (golint)

• tilt/pkg/apis/core/v1alpha1/doc.go
  • Line 21: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• tilt/internal/tiltfile/k8s/locators.go
  • Line 14: warning: comment on exported type JSONPathImageLocatorListSpec should be of the form "JSONPathImageLocatorListSpec ..." (with optional leading article) (golint)
  • Line 19: warning: exported method JSONPathImageLocatorListSpec.IsEmpty should have comment or be unexported (golint)
  • Line 23: warning: exported method JSONPathImageLocatorListSpec.Unpack should have comment or be unexported (golint)
  • Line 36: warning: exported method JSONPathImageLocatorListSpec.ToImageLocators should have comment or be unexported (golint)
  • Line 48: warning: exported type JSONPathImageLocatorSpec should have comment or be unexported (golint)
  • Line 52: warning: exported method JSONPathImageLocatorSpec.Unpack should have comment or be unexported (golint)
  • Line 61: warning: exported method JSONPathImageLocatorSpec.ToImageLocator should have comment or be unexported (golint)
  • Line 65: warning: exported type JSONPathImageObjectLocatorSpec should have comment or be unexported (golint)
  • Line 71: warning: exported method JSONPathImageObjectLocatorSpec.IsEmpty should have comment or be unexported (golint)
  • Line 75: warning: exported method JSONPathImageObjectLocatorSpec.Unpack should have comment or be unexported (golint)
  • Line 90: warning: exported method JSONPathImageObjectLocatorSpec.ToImageLocator should have comment or be unexported (golint)

• tilt/internal/engine/telemetry/controller.go
  • Line 18: warning: exported type Controller should have comment or be unexported (golint)
  • Line 25: warning: exported function NewController should have comment or be unexported (golint)
  • Line 33: warning: exported method Controller.OnChange should have comment or be unexported (golint)

• tilt/internal/tiltfile/docker_compose.go
  • Line 215: warning: exported function DockerComposeConfigToService should have comment or be unexported (golint)
  • Line 265: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/k8s/owner_fetcher.go
  • Line 26: warning: exported method ObjectRefTree.UIDs should have comment or be unexported (golint)
  • Line 55: warning: exported type OwnerFetcher should have comment or be unexported (golint)
  • Line 65: warning: exported function ProvideOwnerFetcher should have comment or be unexported (golint)
  • Line 142: warning: exported method OwnerFetcher.OwnerTreeOfRef should have comment or be unexported (golint)
  • Line 186: warning: exported method OwnerFetcher.OwnerTreeOf should have comment or be unexported (golint)
  • Line 224: warning: exported function OwnerRefToObjectRef should have comment or be unexported (golint)
  • Line 234: warning: exported function RuntimeObjToOwnerRef should have comment or be unexported (golint)

• tilt/internal/tiltfile/secretsettings/secret_settings.go
  • Line 11: warning: comment on exported type Plugin should be of the form "Plugin ..." (with optional leading article) (golint)
  • Line 15: warning: exported function NewPlugin should have comment or be unexported (golint)
  • Line 19: warning: exported method Plugin.NewState should have comment or be unexported (golint)
  • Line 23: warning: exported method Plugin.OnStart should have comment or be unexported (golint)
  • Line 44: warning: exported function MustState should have comment or be unexported (golint)
  • Line 52: warning: exported function GetState should have comment or be unexported (golint)

• tilt/internal/tiltfile/starkit/set_state.go
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/internal/cli/client/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/pkg/apis/core/v1alpha1/extension_types.go
  • Line 45: warning: comment on exported type ExtensionList should be of the form "ExtensionList ..." (with optional leading article) (golint)
  • Line 72: warning: exported method Extension.GetSpec should have comment or be unexported (golint)
  • Line 76: warning: exported method Extension.GetObjectMeta should have comment or be unexported (golint)
  • Line 80: warning: exported method Extension.NamespaceScoped should have comment or be unexported (golint)
  • Line 84: warning: exported method Extension.New should have comment or be unexported (golint)
  • Line 88: warning: exported method Extension.NewList should have comment or be unexported (golint)
  • Line 92: warning: exported method Extension.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 100: warning: exported method Extension.IsStorageVersion should have comment or be unexported (golint)
  • Line 104: warning: exported method Extension.Validate should have comment or be unexported (golint)
  • Line 111: warning: exported method ExtensionList.GetListMeta should have comment or be unexported (golint)
  • Line 128: warning: exported method Extension.GetStatus should have comment or be unexported (golint)
  • Line 135: warning: exported method ExtensionStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/store/k8sconv/pod.go
  • Line 22: warning: exported function Pod should have comment or be unexported (golint)
  • Line 42: warning: exported function PodConditions should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function PodContainers should be of the form "PodContainers ..." (golint)
  • Line 74: warning: comment on exported function ContainerForStatus should be of the form "ContainerForStatus ..." (golint)
  • Line 117: warning: exported function ContainerStatusToRuntimeState should have comment or be unexported (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 142: warning: exported var ErrorWaitingReasons should have comment or be unexported (golint)
  • Line 160: warning: comment on exported function PodStatusToString should be of the form "PodStatusToString ..." (golint)
  • Line 217: warning: comment on exported function PodStatusErrorMessages should be of the form "PodStatusErrorMessages ..." (golint)

• tilt/internal/k8s/portforward/doc.go
  • Line 22: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)

• tilt/internal/user/file.go
  • Line 17: warning: exported function NewFilePrefs should have comment or be unexported (golint)

• tilt/internal/controllers/client_deferred.go
  • Line 14: warning: exported var ErrClientNotInitialized should have comment or be unexported (golint)
  • Line 16: warning: exported type DeferredClient should have comment or be unexported (golint)
  • Line 22: warning: exported function ProvideDeferredClient should have comment or be unexported (golint)
  • Line 42: warning: exported method DeferredClient.Get should have comment or be unexported (golint)
  • Line 50: warning: exported method DeferredClient.List should have comment or be unexported (golint)
  • Line 58: warning: exported method DeferredClient.Create should have comment or be unexported (golint)
  • Line 66: warning: exported method DeferredClient.Delete should have comment or be unexported (golint)
  • Line 74: warning: exported method DeferredClient.Update should have comment or be unexported (golint)
  • Line 82: warning: exported method DeferredClient.Patch should have comment or be unexported (golint)
  • Line 90: warning: exported method DeferredClient.DeleteAllOf should have comment or be unexported (golint)
  • Line 98: warning: exported method DeferredClient.Status should have comment or be unexported (golint)
  • Line 106: warning: exported method DeferredClient.Scheme should have comment or be unexported (golint)
  • Line 114: warning: exported method DeferredClient.RESTMapper should have comment or be unexported (golint)

• tilt/internal/controllers/core/extension/reconciler.go
  • Line 27: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 32: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 41: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 48: warning: comment on exported method Reconciler.Reconcile should be of the form "Reconcile ..." (golint)

• tilt/internal/container/selector.go
  • Line 11: warning: exported type MatchType should have comment or be unexported (golint)
  • Line 18: warning: exported type RefSelector should have comment or be unexported (golint)
  • Line 23: warning: exported function SelectorFromImageMap should have comment or be unexported (golint)
  • Line 38: warning: exported function NameSelector should have comment or be unexported (golint)
  • Line 42: warning: exported function NewRefSelector should have comment or be unexported (golint)
  • Line 54: warning: exported function MustParseSelector should have comment or be unexported (golint)
  • Line 58: warning: exported function MustParseTaggedSelector should have comment or be unexported (golint)
  • Line 62: warning: exported method RefSelector.RefsEqual should have comment or be unexported (golint)
  • Line 66: warning: exported method RefSelector.MatchExact should have comment or be unexported (golint)
  • Line 70: warning: exported method RefSelector.WithNameMatch should have comment or be unexported (golint)
  • Line 75: warning: exported method RefSelector.WithExactMatch should have comment or be unexported (golint)
  • Line 80: warning: exported method RefSelector.MatchesAny should have comment or be unexported (golint)
  • Line 89: warning: exported method RefSelector.Matches should have comment or be unexported (golint)
  • Line 100: warning: exported method RefSelector.Empty should have comment or be unexported (golint)
  • Line 104: warning: exported method RefSelector.RefName should have comment or be unexported (golint)
  • Line 108: warning: exported method RefSelector.RefFamiliarName should have comment or be unexported (golint)
  • Line 112: warning: exported method RefSelector.RefFamiliarString should have comment or be unexported (golint)
  • Line 128: warning: exported function AnyMatch should have comment or be unexported (golint)

• tilt/internal/hud/wire.go
  • Line 8: warning: exported var WireSet should have comment or be unexported (golint)
  • Line 15: warning: exported function ProvideStdout should have comment or be unexported (golint)

• tilt/internal/cli/build.go
  • Line 25: warning: exported function SetTiltInfo should have comment or be unexported (golint)

• tilt/internal/k8s/testyaml/testyaml.go
  • Line 7: warning: exported const BlorgBackendYAML should have comment or be unexported (golint)
  • Line 60: warning: exported const BlorgBackendAmbiguousYAML should have comment or be unexported (golint)
  • Line 113: warning: exported const BlorgJobYAML should have comment or be unexported (golint)
  • Line 128: warning: exported const SanchoImage should have comment or be unexported (golint)
  • Line 130: warning: exported const SanchoYAML should have comment or be unexported (golint)
  • Line 158: warning: exported const SanchoTwoContainersOneImageYAML should have comment or be unexported (golint)
  • Line 183: warning: exported const SanchoYAMLWithCommand should have comment or be unexported (golint)
  • Line 208: warning: exported const SanchoBeta1YAML should have comment or be unexported (golint)
  • Line 234: warning: exported const SanchoStatefulSetBeta1YAML should have comment or be unexported (golint)
  • Line 254: warning: exported const SanchoBeta2YAML should have comment or be unexported (golint)
  • Line 280: warning: exported const SanchoExtBeta1YAML should have comment or be unexported (golint)
  • Line 306: warning: exported const SanchoTwinYAML should have comment or be unexported (golint)
  • Line 335: warning: exported const SanchoSidecarYAML should have comment or be unexported (golint)
  • Line 365: warning: exported const SanchoSidecarImage should have comment or be unexported (golint)
  • Line 367: warning: exported const SanchoRedisSidecarYAML should have comment or be unexported (golint)
  • Line 398: warning: exported const SanchoImageInEnvYAML should have comment or be unexported (golint)
  • Line 426: warning: exported const TracerYAML should have comment or be unexported (golint)
  • Line 500: warning: exported const JobYAML should have comment or be unexported (golint)
  • Line 516: warning: exported const PodYAML should have comment or be unexported (golint)
  • Line 529: warning: exported const MultipleContainersYAML should have comment or be unexported (golint)
  • Line 548: warning: exported const MultipleContainersDeploymentYAML should have comment or be unexported (golint)
  • Line 583: warning: exported const SyncletYAML should have comment or be unexported (golint)
  • Line 635: warning: comment on exported const LonelyPodYAML should be of the form "LonelyPodYAML ..." (golint)
  • Line 652: warning: comment on exported const PostgresYAML should be of the form "PostgresYAML ..." (golint)
  • Line 745: warning: comment on exported const OutOfOrderYaml should be of the form "OutOfOrderYaml ..." (golint)
  • Line 865: warning: exported const DoggosDeploymentYaml should have comment or be unexported (golint)
  • Line 895: warning: exported const DoggosServiceYaml should have comment or be unexported (golint)
  • Line 911: warning: exported const CatsServiceYaml should have comment or be unexported (golint)
  • Line 929: warning: exported const DoggosName should have comment (or a comment on this block) or be unexported (golint)
  • Line 933: warning: exported const SnackYaml should have comment or be unexported (golint)
  • Line 955: warning: exported const SnackName should have comment (or a comment on this block) or be unexported (golint)
  • Line 959: warning: exported const SnackYAMLPostConfig should have comment or be unexported (golint)
  • Line 983: warning: exported const SecretName should have comment or be unexported (golint)
  • Line 984: warning: exported const SecretYaml should have comment or be unexported (golint)
  • Line 995: warning: comment on exported const HelmGeneratedRedisYAML should be of the form "HelmGeneratedRedisYAML ..." (golint)
  • Line 1402: warning: comment on exported const CRDYAML should be of the form "CRDYAML ..." (golint)
  • Line 1441: warning: exported const CRDImage should have comment or be unexported (golint)
  • Line 1443: warning: exported const CRDImageObjectYAML should have comment or be unexported (golint)
  • Line 1452: warning: exported const CRDContainerSpecYAML should have comment or be unexported (golint)
  • Line 1463: warning: exported const MyNamespaceYAML should have comment or be unexported (golint)
  • Line 1468: warning: exported const MyNamespaceName should have comment or be unexported (golint)
  • Line 1470: warning: exported const RedisStatefulSetYAML should have comment or be unexported (golint)
  • Line 1574: warning: exported function Deployment should have comment or be unexported (golint)
  • Line 1601: warning: exported const PodDisruptionBudgetYAML should have comment or be unexported (golint)
  • Line 1617: warning: exported const DoggosListYAML should have comment or be unexported (golint)
  • Line 1664: warning: exported const KnativeServingCore should have comment or be unexported (golint)

• tilt/internal/tiltfile/io/blob.go
  • Line 11: warning: exported type Blob should have comment or be unexported (golint)
  • Line 18: warning: exported function NewBlob should have comment or be unexported (golint)
  • Line 22: warning: exported method Blob.ImplicitString should have comment or be unexported (golint)
  • Line 30: warning: exported method Blob.Type should have comment or be unexported (golint)
  • Line 34: warning: exported method Blob.Freeze should have comment or be unexported (golint)
  • Line 36: warning: exported method Blob.Truth should have comment or be unexported (golint)
  • Line 40: warning: exported method Blob.Hash should have comment or be unexported (golint)

• tilt/internal/controllers/core/filewatch/fsevent/fake_watcher.go
  • Line 12: warning: exported type FakeMultiWatcher should have comment or be unexported (golint)
  • Line 22: warning: exported function NewFakeMultiWatcher should have comment or be unexported (golint)
  • Line 28: warning: exported method FakeMultiWatcher.NewSub should have comment or be unexported (golint)
  • Line 90: warning: exported type FakeWatcher should have comment or be unexported (golint)
  • Line 99: warning: exported function NewFakeWatcher should have comment or be unexported (golint)
  • Line 127: warning: exported method FakeWatcher.Start should have comment or be unexported (golint)
  • Line 132: warning: exported method FakeWatcher.Close should have comment or be unexported (golint)
  • Line 136: warning: exported method FakeWatcher.Errors should have comment or be unexported (golint)
  • Line 140: warning: exported method FakeWatcher.Events should have comment or be unexported (golint)

• tilt/internal/kustomize/dependencies.go
  • Line 124: warning: exported function Deps should have comment or be unexported (golint)

• tilt/internal/hud/server/controller.go
  • Line 36: warning: exported type HeadsUpServerController should have comment or be unexported (golint)
  • Line 50: warning: exported function ProvideHeadsUpServerController should have comment or be unexported (golint)
  • Line 74: warning: exported method HeadsUpServerController.TearDown should have comment or be unexported (golint)
  • Line 87: warning: exported method HeadsUpServerController.OnChange should have comment or be unexported (golint)
  • Line 91: warning: comment on exported method HeadsUpServerController.SetUp should be of the form "SetUp ..." (golint)

• tilt/internal/k8s/label_selector.go
  • Line 42: warning: exported function SelectorEqual should have comment or be unexported (golint)

• tilt/internal/k8s/ip.go
  • Line 10: warning: comment on exported type NodeIP should be of the form "NodeIP ..." (with optional leading article) (golint)
  • Line 45: warning: exported method K8sClient.NodeIP should have comment or be unexported (golint)

• tilt/internal/tiltfile/value/string.go
  • Line 9: warning: exported type Stringable should have comment or be unexported (golint)
  • Line 13: warning: exported method Stringable.Unpack should have comment or be unexported (golint)
  • Line 22: warning: exported type ImplicitStringer should have comment or be unexported (golint)
  • Line 26: warning: comment on exported function AsString should be of the form "AsString ..." (golint)
  • Line 35: warning: exported type StringOrStringList should have comment or be unexported (golint)

• tilt/internal/engine/metrics/meter.go
  • Line 11: warning: exported function NewDeferredExporter should have comment or be unexported (golint)
  • Line 15: warning: exported type RemoteExporter should have comment or be unexported (golint)
  • Line 21: warning: exported type DeferredExporter should have comment or be unexported (golint)
  • Line 27: warning: exported method DeferredExporter.Flush should have comment or be unexported (golint)
  • Line 39: warning: exported method DeferredExporter.Stop should have comment or be unexported (golint)
  • Line 49: warning: exported method DeferredExporter.SetRemote should have comment or be unexported (golint)
  • Line 68: warning: exported method DeferredExporter.ExportView should have comment or be unexported (golint)

• tilt/internal/engine/buildcontrol/build_control.go
  • Line 18: warning: comment on exported function NextTargetToBuild should be of the form "NextTargetToBuild ..." (golint)
  • Line 97: warning: exported function NextManifestNameToBuild should have comment or be unexported (golint)
  • Line 158: warning: exported function HoldTargetsWithBuildingComponents should have comment or be unexported (golint)
  • Line 200: warning: exported function HoldTargetsWaitingOnDependencies should have comment or be unexported (golint)
  • Line 208: warning: comment on exported function NextUnbuiltTargetToBuild should be of the form "NextUnbuiltTargetToBuild ..." (golint)
  • Line 235: warning: exported function FindUnresourcedYAML should have comment or be unexported (golint)
  • Line 244: warning: exported function FindDeployOnlyK8sManifestTargets should have comment or be unexported (golint)
  • Line 254: warning: exported function FindLocalTargets should have comment or be unexported (golint)
  • Line 264: warning: exported function HoldUnparallelizableLocalTargets should have comment or be unexported (golint)
  • Line 272: warning: exported function HoldK8sTargets should have comment or be unexported (golint)
  • Line 280: warning: exported function IsBuildingAnything should have comment or be unexported (golint)
  • Line 290: warning: exported function IsBuildingUnparallelizableLocalTarget should have comment or be unexported (golint)
  • Line 301: warning: exported function IsBuildingUncategorizedYAML should have comment or be unexported (golint)
  • Line 311: warning: comment on exported function EarliestPendingAutoTriggerTarget should be of the form "EarliestPendingAutoTriggerTarget ..." (golint)
  • Line 342: warning: exported function FindTargetsNeedingInitialBuild should have comment or be unexported (golint)
  • Line 352: warning: exported function HoldLiveUpdateTargetsWaitingOnDeploy should have comment or be unexported (golint)
  • Line 360: warning: exported function IsLiveUpdateTargetWaitingOnDeploy should have comment or be unexported (golint)

• tilt/internal/build/pipeline_state.go
  • Line 12: warning: exported type PipelineState should have comment or be unexported (golint)
  • Line 20: warning: exported type PipelineStep should have comment or be unexported (golint)
  • Line 26: warning: exported type Clock should have comment or be unexported (golint)
  • Line 34: warning: exported function ProvideClock should have comment or be unexported (golint)
  • Line 40: warning: exported function NewPipelineState should have comment or be unexported (golint)
  • Line 49: warning: comment on exported method PipelineState.End should be of the form "End ..." (golint)
  • Line 85: warning: exported method PipelineState.StartPipelineStep should have comment or be unexported (golint)
  • Line 97: warning: exported method PipelineState.EndPipelineStep should have comment or be unexported (golint)
  • Line 103: warning: exported method PipelineState.StartBuildStep should have comment or be unexported (golint)
  • Line 109: warning: exported method PipelineState.Printf should have comment or be unexported (golint)
  • Line 120: warning: exported method PipelineState.AttachLogger should have comment or be unexported (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• tilt/pkg/model/web.go
  • Line 11: warning: comment on exported type WebVersion should be of the form "WebVersion ..." (with optional leading article) (golint)
  • Line 15: warning: comment on exported type WebSHA should be of the form "WebSHA ..." (with optional leading article) (golint)
  • Line 24: warning: exported type WebMode should have comment or be unexported (golint)
  • Line 27: warning: comment on exported const DefaultWebMode should be of the form "DefaultWebMode ..." (golint)
  • Line 31: warning: comment on exported const LocalWebMode should be of the form "LocalWebMode ..." (golint)
  • Line 34: warning: comment on exported const ProdWebMode should be of the form "ProdWebMode ..." (golint)
  • Line 37: warning: comment on exported const PrecompiledWebMode should be of the form "PrecompiledWebMode ..." (golint)
  • Line 46: warning: exported method WebMode.Set should have comment or be unexported (golint)
  • Line 62: warning: exported method WebMode.Type should have comment or be unexported (golint)
  • Line 66: warning: exported function UnrecognizedWebModeError should have comment or be unexported (golint)
  • Line 76: warning: exported const DefaultWebPort should have comment or be unexported (golint)
  • Line 78: warning: exported type WebHost should have comment or be unexported (golint)
  • Line 79: warning: exported type WebPort should have comment or be unexported (golint)
  • Line 80: warning: exported type WebDevPort should have comment or be unexported (golint)
  • Line 81: warning: exported type WebURL should have comment or be unexported (golint)
  • Line 88: warning: exported method WebURL.Empty should have comment or be unexported (golint)

• tilt/internal/build/label.go
  • Line 6: warning: comment on exported const BuildMode should be of the form "BuildMode ..." (golint)
  • Line 12: warning: comment on exported const TestImage should be of the form "TestImage ..." (golint)
  • Line 15: warning: comment on exported const CacheImage should be of the form "CacheImage ..." (golint)
  • Line 20: warning: exported const BuildModeScratch should have comment (or a comment on this block) or be unexported (golint)

• tilt/internal/k8s/target.go
  • Line 23: warning: exported function MustTarget should have comment or be unexported (golint)
  • Line 37: warning: exported function NewTarget should have comment or be unexported (golint)
  • Line 109: warning: exported function NewK8sOnlyManifest should have comment or be unexported (golint)
  • Line 119: warning: exported function NewK8sOnlyManifestFromYAML should have comment or be unexported (golint)
  • Line 132: warning: exported function ParseImageLocators should have comment or be unexported (golint)
  • Line 176: warning: exported function SetsAsLabelSelectors should have comment or be unexported (golint)

• tilt/integration/stats_server.go
  • Line 16: warning: exported type MemoryStatsServer should have comment or be unexported (golint)
  • Line 22: warning: exported function StartMemoryStatsServer should have comment or be unexported (golint)
  • Line 46: warning: exported method MemoryStatsServer.TearDown should have comment or be unexported (golint)
  • Line 50: warning: exported type MemoryStatsReporter should have comment or be unexported (golint)
  • Line 56: warning: exported method MemoryStatsReporter.Close should have comment or be unexported (golint)
  • Line 60: warning: exported method MemoryStatsReporter.Timing should have comment or be unexported (golint)
  • Line 65: warning: exported method MemoryStatsReporter.Count should have comment or be unexported (golint)
  • Line 70: warning: exported method MemoryStatsReporter.Incr should have comment or be unexported (golint)
  • Line 77: warning: exported type StatsReporter should have comment or be unexported (golint)
  • Line 84: warning: comment on exported type StatsServer should be of the form "StatsServer ..." (with optional leading article) (golint)
  • Line 90: warning: exported function NewStatsServer should have comment or be unexported (golint)
  • Line 99: warning: exported method StatsServer.Router should have comment or be unexported (golint)
  • Line 103: warning: exported method StatsServer.Index should have comment or be unexported (golint)
  • Line 107: warning: exported method StatsServer.Report should have comment or be unexported (golint)
  • Line 143: warning: exported type Event should have comment or be unexported (golint)
  • Line 145: warning: exported method Event.Name should have comment or be unexported (golint)
  • Line 153: warning: exported method Event.Duration should have comment or be unexported (golint)
  • Line 162: warning: exported method Event.Tags should have comment or be unexported (golint)

• tilt/internal/controllers/core/uisession/reconciler.go
  • Line 18: warning: comment on exported type Reconciler should be of the form "Reconciler ..." (with optional leading article) (golint)
  • Line 31: warning: exported function NewReconciler should have comment or be unexported (golint)
  • Line 38: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
  • Line 59: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)

• tilt/internal/docker/fake_client.go
  • Line 23: warning: exported const ExampleBuildSHA1 should have comment or be unexported (golint)
  • Line 25: warning: exported const ExampleBuildOutput1 should have comment or be unexported (golint)
  • Line 32: warning: exported const ExampleBuildOutputV1_23 should have comment or be unexported (golint)
  • Line 39: warning: comment on exported const ExampleBuildOutput2 should be of the form "ExampleBuildOutput2 ..." (golint)
  • Line 48: warning: exported const ExamplePushSHA1 should have comment or be unexported (golint)
  • Line 50: warning: exported var ExamplePushOutput1 should have comment or be unexported (golint)
  • Line 65: warning: exported const TestPod should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported var DefaultContainerListOutput should have comment or be unexported (golint)
  • Line 79: warning: exported type ExecCall should have comment or be unexported (golint)
  • Line 84: warning: exported type FakeClient should have comment or be unexported (golint)
  • Line 136: warning: exported function NewFakeClient should have comment or be unexported (golint)
  • Line 146: warning: exported method FakeClient.SetOrchestrator should have comment or be unexported (golint)
  • Line 149: warning: exported method FakeClient.CheckConnected should have comment or be unexported (golint)
  • Line 152: warning: exported method FakeClient.Env should have comment or be unexported (golint)
  • Line 155: warning: exported method FakeClient.BuilderVersion should have comment or be unexported (golint)
  • Line 158: warning: exported method FakeClient.ServerVersion should have comment or be unexported (golint)
  • Line 162: warning: exported method FakeClient.SetExecError should have comment or be unexported (golint)
  • Line 166: warning: exported method FakeClient.ContainerInspect should have comment or be unexported (golint)
  • Line 176: warning: exported method FakeClient.SetContainerListOutput should have comment or be unexported (golint)
  • Line 180: warning: exported method FakeClient.SetDefaultContainerListOutput should have comment or be unexported (golint)
  • Line 184: warning: exported method FakeClient.ContainerList should have comment or be unexported (golint)
  • Line 201: warning: exported method FakeClient.ContainerRestartNoWait should have comment or be unexported (golint)
  • Line 206: warning: exported method FakeClient.ExecInContainer should have comment or be unexported (golint)
  • Line 231: warning: exported method FakeClient.ImagePush should have comment or be unexported (golint)
  • Line 237: warning: exported method FakeClient.ImageBuild should have comment or be unexported (golint)
  • Line 258: warning: exported method FakeClient.ImageTag should have comment or be unexported (golint)
  • Line 265: warning: exported method FakeClient.ImageInspectWithRaw should have comment or be unexported (golint)
  • Line 278: warning: exported method FakeClient.ImageList should have comment or be unexported (golint)
  • Line 290: warning: exported method FakeClient.ImageRemove should have comment or be unexported (golint)
  • Line 298: warning: exported method FakeClient.NewVersionError should have comment or be unexported (golint)
  • Line 306: warning: exported method FakeClient.VersionError should have comment or be unexported (golint)
  • Line 310: warning: exported method FakeClient.BuildCachePrune should have comment or be unexported (golint)
  • Line 329: warning: exported method FakeClient.ContainersPrune should have comment or be unexported (golint)
  • Line 350: warning: exported function NewFakeDockerResponse should have comment or be unexported (golint)

• tilt/internal/k8s/statefulset.go
  • Line 9: warning: comment on exported function InjectParallelPodManagementPolicy should be of the form "InjectParallelPodManagementPolicy ..." (golint)

• tilt/internal/controllers/core/tiltfile/reconciler.go
  • Line 35: warning: exported type Reconciler should have comment or be unexported (golint)
  • Line 48: warning: exported method Reconciler.CreateBuilder should have comment or be unexported (golint)
  • Line 58: warning: exported function NewReconciler should have comment or be unexported (golint)

• tilt/internal/controllers/core/cmd/wire.go
  • Line 5: warning: exported var WireSet should have comment or be unexported (golint)

• tilt/pkg/model/docker_compose_target.go
  • Line 9: warning: exported type DockerComposeTarget should have comment or be unexported (golint)
  • Line 35: warning: comment on exported method DockerComposeTarget.ManifestName should be of the form "ManifestName ..." (golint)
  • Line 41: warning: exported method DockerComposeTarget.Empty should have comment or be unexported (golint)
  • Line 43: warning: exported method DockerComposeTarget.ID should have comment or be unexported (golint)
  • Line 50: warning: exported method DockerComposeTarget.DependencyIDs should have comment or be unexported (golint)
  • Line 54: warning: exported method DockerComposeTarget.LocalPaths should have comment or be unexported (golint)
  • Line 61: warning: exported method DockerComposeTarget.PublishedPorts should have comment or be unexported (golint)
  • Line 65: warning: exported method DockerComposeTarget.WithLinks should have comment or be unexported (golint)
  • Line 70: warning: exported method DockerComposeTarget.WithPublishedPorts should have comment or be unexported (golint)
  • Line 75: warning: exported method DockerComposeTarget.WithBuildPath should have comment or be unexported (golint)
  • Line 80: warning: exported method DockerComposeTarget.WithDependencyIDs should have comment or be unexported (golint)
  • Line 85: warning: exported method DockerComposeTarget.WithRepos should have comment or be unexported (golint)
  • Line 90: warning: exported method DockerComposeTarget.WithDockerignores should have comment or be unexported (golint)
  • Line 95: warning: exported method DockerComposeTarget.Dockerignores should have comment or be unexported (golint)
  • Line 99: warning: exported method DockerComposeTarget.LocalRepos should have comment or be unexported (golint)
  • Line 103: warning: exported method DockerComposeTarget.IgnoredLocalDirectories should have comment or be unexported (golint)
  • Line 107: warning: exported method DockerComposeTarget.TiltFilename should have comment or be unexported (golint)
  • Line 111: warning: exported method DockerComposeTarget.WithTiltFilename should have comment or be unexported (golint)
  • Line 116: warning: exported method DockerComposeTarget.WithIgnoredLocalDirectories should have comment or be unexported (golint)
  • Line 121: warning: comment on exported method DockerComposeTarget.Dependencies should be of the form "Dependencies ..." (golint)
  • Line 127: warning: exported method DockerComposeTarget.Validate should have comment or be unexported (golint)
  • Line 127: warning: receiver name dc should be consistent with previous receiver name t for DockerComposeTarget (golint)

• tilt/pkg/apis/core/v1alpha1/uibutton_types.go
  • Line 36: warning: comment on exported type UIButton should be of the form "UIButton ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported type UIButtonList should be of the form "UIButtonList ..." (with optional leading article) (golint)
  • Line 104: warning: exported type ComponentType should have comment or be unexported (golint)
  • Line 107: warning: exported const ComponentTypeResource should have comment (or a comment on this block) or be unexported (golint)
  • Line 111: warning: exported type UIComponentLocationResource should have comment or be unexported (golint)
  • Line 118: warning: exported method UIButton.GetObjectMeta should have comment or be unexported (golint)
  • Line 122: warning: exported method UIButton.NamespaceScoped should have comment or be unexported (golint)
  • Line 126: warning: exported method UIButton.New should have comment or be unexported (golint)
  • Line 130: warning: exported method UIButton.NewList should have comment or be unexported (golint)
  • Line 134: warning: exported method UIButton.GetGroupVersionResource should have comment or be unexported (golint)
  • Line 142: warning: exported method UIButton.IsStorageVersion should have comment or be unexported (golint)
  • Line 146: warning: exported method UIButton.Validate should have comment or be unexported (golint)
  • Line 186: warning: exported method UIButtonList.GetListMeta should have comment or be unexported (golint)
  • Line 190: warning: exported type UITextInputSpec should have comment or be unexported (golint)
  • Line 202: warning: exported type UITextInputStatus should have comment or be unexported (golint)
  • Line 207: warning: comment on exported type UIInputSpec should be of the form "UIInputSpec ..." (with optional leading article) (golint)
  • Line 226: warning: exported method UIInputSpec.Validate should have comment or be unexported (golint)
  • Line 236: warning: comment on exported type UIInputStatus should be of the form "UIInputStatus ..." (with optional leading article) (golint)
  • Line 264: warning: exported method UIButton.GetStatus should have comment or be unexported (golint)
  • Line 271: warning: exported method UIButtonStatus.CopyTo should have comment or be unexported (golint)

• tilt/internal/tiltfile/os/environ.go
  • Line 14: warning: comment on exported type Environ should be of the form "Environ ..." (with optional leading article) (golint)
  • Line 18: warning: exported method Environ.Clear should have comment or be unexported (golint)
  • Line 23: warning: exported method Environ.Delete should have comment or be unexported (golint)
  • Line 39: warning: exported method Environ.Get should have comment or be unexported (golint)
  • Line 59: warning: exported method Environ.Items should have comment or be unexported (golint)
  • Line 60: warning: exported method Environ.Keys should have comment or be unexported (golint)
  • Line 61: warning: exported method Environ.Len should have comment or be unexported (golint)
  • Line 62: warning: exported method Environ.Iterate should have comment or be unexported (golint)
  • Line 64: warning: exported method Environ.SetKey should have comment or be unexported (golint)
  • Line 79: warning: exported method Environ.Type should have comment or be unexported (golint)
  • Line 80: warning: exported method Environ.Freeze should have comment or be unexported (golint)
  • Line 81: warning: exported method Environ.Truth should have comment or be unexported (golint)
  • Line 82: warning: exported method Environ.Hash should have comment or be unexported (golint)
  • Line 84: warning: exported method Environ.Attr should have comment or be unexported (golint)
  • Line 87: warning: exported method Environ.AttrNames should have comment or be unexported (golint)
  • Line 88: warning: exported method Environ.CompareSameType should have comment or be unexported (golint)

• tilt/internal/engine/dockerprune/docker_pruner.go
  • Line 27: warning: exported type DockerPruner should have comment or be unexported (golint)
  • Line 40: warning: exported function NewDockerPruner should have comment or be unexported (golint)
  • Line 44: warning: exported method DockerPruner.DisabledForTesting should have comment or be unexported (golint)
  • Line 48: warning: exported method DockerPruner.SetUp should have comment or be unexported (golint)
  • Line 66: warning: exported method DockerPruner.OnChange should have comment or be unexported (golint)
  • Line 121: warning: exported method DockerPruner.PruneAndRecordState should have comment or be unexported (golint)
  • Line 127: warning: exported method DockerPruner.Prune should have comment or be unexported (golint)

• tilt/internal/controllers/core/cmd/types.go
  • Line 9: warning: exported type Cmd should have comment or be unexported (golint)
  • Line 10: warning: exported type CmdList should have comment or be unexported (golint)
  • Line 11: warning: exported type CmdStatus should have comment or be unexported (golint)
  • Line 12: warning: exported type CmdSpec should have comment or be unexported (golint)
  • Line 13: warning: exported type CmdStateWaiting should have comment or be unexported (golint)
  • Line 14: warning: exported type CmdStateTerminated should have comment or be unexported (golint)
  • Line 15: warning: exported type CmdStateRunning should have comment or be unexported (golint)
  • Line 16: warning: exported type ObjectMeta should have comment or be unexported (golint)
  • Line 17: warning: exported type FileWatch should have comment or be unexported (golint)
  • Line 18: warning: exported type FileWatchSpec should have comment or be unexported (golint)
  • Line 19: warning: exported type StartOnSpec should have comment or be unexported (golint)
  • Line 20: warning: exported type RestartOnSpec should have comment or be unexported (golint)
  • Line 21: warning: exported type UIButton should have comment or be unexported (golint)
  • Line 22: warning: exported type UIButtonSpec should have comment or be unexported (golint)

• tilt/internal/k8s/ref.go
  • Line 8: warning: exported type ObjRefList should have comment or be unexported (golint)
  • Line 10: warning: exported method ObjRefList.ContainsUID should have comment or be unexported (golint)
  • Line 15: warning: exported method ObjRefList.GetByUID should have comment or be unexported (golint)
  • Line 24: warning: exported method ObjRefList.UIDSet should have comment or be unexported (golint)
  • Line 32: warning: exported function ToRefList should have comment or be unexported (golint)