Preparing report...

Report for github.com/xrfang/restique

A    Great!    Found 12 issues across 24 files

Tweet

gofmt79%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint54%

Golint is a linter for Go source code.

    • restique/src/restique/ui_sql.go
    • Line 15: warning: exported const QRY_RESULT should have comment (or a comment on this block) or be unexported (golint)
    • Line 119: warning: don't use underscores in Go names; var qry_res should be qryRes (golint)
    • Line 237: warning: don't use underscores in Go names; var xh_small should be xhSmall (golint)
    • Line 237: warning: don't use underscores in Go names; var xh_large should be xhLarge (golint)
    • Line 237: warning: don't use underscores in Go names; var xh_nolimit should be xhNolimit (golint)
    • restique/src/gopass/gopass.go
    • Line 3: warning: package comment should be of the form "Package gopass ..." (golint)
    • Line 27: warning: don't use underscores in Go names; const exec_cwdir should be execCwdir (golint)
    • restique/src/restique/dbop.go
    • Line 22: warning: exported function LoadDSNs should have comment or be unexported (golint)
    • Line 30: warning: exported function RangeRows should have comment or be unexported (golint)
    • Line 43: warning: exported function ExpandMultiDSN should have comment or be unexported (golint)
    • restique/src/restique/history.go
    • Line 16: warning: exported type CacheEntry should have comment or be unexported (golint)
    • Line 24: warning: exported type MfuCache should have comment or be unexported (golint)
    • Line 29: warning: exported method MfuCache.Initialize should have comment or be unexported (golint)
    • Line 33: warning: exported method MfuCache.Load should have comment or be unexported (golint)
    • Line 50: warning: exported method MfuCache.Save should have comment or be unexported (golint)
    • Line 64: warning: exported method MfuCache.Get should have comment or be unexported (golint)
    • Line 108: warning: exported method MfuCache.Update should have comment or be unexported (golint)
    • restique/src/restique/auth.go
    • Line 33: warning: don't use underscores in Go names; var allowed_cidrs should be allowedCidrs (golint)
    • Line 40: warning: exported function SetAuth should have comment or be unexported (golint)
    • Line 61: warning: exported function LoadAuthDb should have comment or be unexported (golint)
    • Line 71: warning: exported function AccessDenied should have comment or be unexported (golint)
    • restique/src/restique/main.go
    • Line 31: warning: don't use underscores in Go names; var dsn_init should be dsnInit (golint)
    • Line 85: warning: don't use underscores in Go names; var want_otp should be wantOtp (golint)

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign87%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell95%

Misspell Finds commonly misspelled English words