Preparing report...

Report for github.com/aptly-dev/aptly

(v1.5.0)

A+    Excellent!    Found 38 issues across 207 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo82%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • swift/public.go
    • Line 35: warning: cyclomatic complexity 16 of function NewPublishedStorage() is high (> 15) (gocyclo)
    • files/public.go
    • Line 126: warning: cyclomatic complexity 19 of function (*PublishedStorage).LinkFromPool() is high (> 15) (gocyclo)
    • query/lex.go
    • Line 145: warning: cyclomatic complexity 19 of function lexMain() is high (> 15) (gocyclo)
    • files/package_pool.go
    • Line 234: warning: cyclomatic complexity 29 of function (*PackagePool).Import() is high (> 15) (gocyclo)
    • Line 165: warning: cyclomatic complexity 16 of function (*PackagePool).Verify() is high (> 15) (gocyclo)
    • deb/package.go
    • Line 245: warning: cyclomatic complexity 26 of function (*Package).GetField() is high (> 15) (gocyclo)
    • Line 514: warning: cyclomatic complexity 25 of function (*Package).Stanza() is high (> 15) (gocyclo)
    • deb/changes.go
    • Line 290: warning: cyclomatic complexity 24 of function ImportChangesFiles() is high (> 15) (gocyclo)
    • api/db.go
    • Line 15: warning: cyclomatic complexity 22 of function apiDbCleanup() is high (> 15) (gocyclo)
    • api/publish.go
    • Line 82: warning: cyclomatic complexity 22 of function apiPublishRepoOrSnapshot() is high (> 15) (gocyclo)
    • Line 243: warning: cyclomatic complexity 21 of function apiPublishUpdateSwitch() is high (> 15) (gocyclo)
    • api/repos.go
    • Line 266: warning: cyclomatic complexity 18 of function apiReposPackageFromDir() is high (> 15) (gocyclo)
    • deb/version.go
    • Line 49: warning: cyclomatic complexity 16 of function compareLexicographic() is high (> 15) (gocyclo)
    • Line 251: warning: cyclomatic complexity 16 of function ParseDependency() is high (> 15) (gocyclo)
    • deb/list.go
    • Line 501: warning: cyclomatic complexity 20 of function (*PackageList).FilterWithProgress() is high (> 15) (gocyclo)
    • Line 312: warning: cyclomatic complexity 19 of function (*PackageList).VerifyDependencies() is high (> 15) (gocyclo)
    • api/mirror.go
    • Line 271: warning: cyclomatic complexity 39 of function apiMirrorsUpdate() is high (> 15) (gocyclo)
    • deb/remote.go
    • Line 431: warning: cyclomatic complexity 38 of function (*RemoteRepo).DownloadPackageIndexes() is high (> 15) (gocyclo)
    • Line 273: warning: cyclomatic complexity 28 of function (*RemoteRepo).Fetch() is high (> 15) (gocyclo)
    • pgp/internal.go
    • Line 71: warning: cyclomatic complexity 28 of function (*GoSigner).Init() is high (> 15) (gocyclo)
    • pgp/openpgp.go
    • Line 56: warning: cyclomatic complexity 20 of function checkDetachedSignature() is high (> 15) (gocyclo)
    • deb/graph.go
    • Line 11: warning: cyclomatic complexity 17 of function BuildGraph() is high (> 15) (gocyclo)
    • deb/publish.go
    • Line 517: warning: cyclomatic complexity 69 of function (*PublishedRepo).Publish() is high (> 15) (gocyclo)
    • Line 155: warning: cyclomatic complexity 31 of function NewPublishedRepo() is high (> 15) (gocyclo)
    • Line 1108: warning: cyclomatic complexity 17 of function (*PublishedRepoCollection).CleanupPrefixComponentFiles() is high (> 15) (gocyclo)
    • deb/reflist.go
    • Line 185: warning: cyclomatic complexity 21 of function (*PackageRefList).Diff() is high (> 15) (gocyclo)
    • Line 276: warning: cyclomatic complexity 16 of function (*PackageRefList).Merge() is high (> 15) (gocyclo)
    • deb/import.go
    • Line 67: warning: cyclomatic complexity 28 of function ImportPackageFiles() is high (> 15) (gocyclo)
    • Line 15: warning: cyclomatic complexity 17 of function CollectPackageFiles() is high (> 15) (gocyclo)
    • cmd/task_run.go
    • Line 13: warning: cyclomatic complexity 17 of function aptlyTaskRun() is high (> 15) (gocyclo)
    • cmd/repo_move.go
    • Line 13: warning: cyclomatic complexity 31 of function aptlyRepoMoveCopyImport() is high (> 15) (gocyclo)
    • http/download.go
    • Line 240: warning: cyclomatic complexity 23 of function (*downloaderImpl).download() is high (> 15) (gocyclo)
    • deb/deb.go
    • Line 151: warning: cyclomatic complexity 20 of function GetContentsFromDeb() is high (> 15) (gocyclo)
    • Line 33: warning: cyclomatic complexity 19 of function GetControlFileFromDeb() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!