Preparing report...

Report for github.com/codegangsta/cli

A+    Excellent!    Found 26 issues across 55 files

Tweet

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • cli/app.go
    • Line 131: warning: cyclomatic complexity 21 of function (*App).Setup() is high (> 15) (gocyclo)
    • Line 342: warning: cyclomatic complexity 20 of function (*App).RunAsSubcommand() is high (> 15) (gocyclo)
    • Line 230: warning: cyclomatic complexity 19 of function (*App).RunContext() is high (> 15) (gocyclo)
    • cli/command.go
    • Line 92: warning: cyclomatic complexity 17 of function (*Command).Run() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

    • cli/docs.go
    • Line 24: warning: comment on exported method App.ToManWithSection should be of the form "ToManWithSection ..." (golint)
    • cli/help.go
    • Line 162: warning: exported function DefaultCompleteWithFlags should have comment or be unexported (golint)
    • cli/context.go
    • Line 124: warning: receiver name ctx should be consistent with previous receiver name c for Context (golint)
    • Line 152: warning: receiver name ctx should be consistent with previous receiver name c for Context (golint)
    • Line 162: warning: receiver name context should be consistent with previous receiver name c for Context (golint)
    • cli/args.go
    • Line 3: warning: exported type Args should have comment or be unexported (golint)
    • cli/command.go
    • Line 66: warning: exported type Commands should have comment or be unexported (golint)
    • Line 68: warning: exported type CommandsByName should have comment or be unexported (golint)
    • cli/flag_timestamp.go
    • Line 16: warning: comment on exported function NewTimestamp should be of the form "NewTimestamp ..." (golint)
    • Line 21: warning: comment on exported method Timestamp.SetTimestamp should be of the form "SetTimestamp ..." (golint)
    • Line 29: warning: comment on exported method Timestamp.SetLayout should be of the form "SetLayout ..." (golint)
    • Line 34: warning: comment on exported method Timestamp.Set should be of the form "Set ..." (golint)
    • cli/template.go
    • Line 77: warning: exported var MarkdownDocTemplate should have comment or be unexported (golint)
    • Line 108: warning: exported var FishCompletionTemplate should have comment or be unexported (golint)
    • cli/internal/build/build.go
    • Line 66: warning: exported function VetActionFunc should have comment or be unexported (golint)
    • Line 70: warning: exported function TestActionFunc should have comment or be unexported (golint)
    • Line 135: warning: exported function GfmrunActionFunc should have comment or be unexported (golint)
    • Line 168: warning: exported function TocActionFunc should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign74%

IneffAssign detects ineffectual assignments in Go code.

    • cli/altsrc/json_command_test.go
    • Line 40: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 41: warning: StringFlag not declared by package cli (ineffassign)
    • Line 74: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 75: warning: StringFlag not declared by package cli (ineffassign)
    • Line 109: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 110: warning: StringFlag not declared by package cli (ineffassign)
    • Line 141: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 142: warning: StringFlag not declared by package cli (ineffassign)
    • Line 173: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 174: warning: StringFlag not declared by package cli (ineffassign)
    • Line 205: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 206: warning: StringFlag not declared by package cli (ineffassign)
    • Line 237: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 238: warning: StringFlag not declared by package cli (ineffassign)
    • Line 272: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 273: warning: StringFlag not declared by package cli (ineffassign)
    • Line 306: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 307: warning: StringFlag not declared by package cli (ineffassign)
    • cli/altsrc/yaml_command_test.go
    • Line 33: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 34: warning: StringFlag not declared by package cli (ineffassign)
    • Line 66: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 67: warning: StringFlag not declared by package cli (ineffassign)
    • Line 101: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 102: warning: StringFlag not declared by package cli (ineffassign)
    • Line 133: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 134: warning: StringFlag not declared by package cli (ineffassign)
    • Line 166: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 167: warning: StringFlag not declared by package cli (ineffassign)
    • Line 198: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 199: warning: StringFlag not declared by package cli (ineffassign)
    • Line 231: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 232: warning: StringFlag not declared by package cli (ineffassign)
    • Line 266: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 267: warning: StringFlag not declared by package cli (ineffassign)
    • Line 301: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 302: warning: StringFlag not declared by package cli (ineffassign)
    • cli/docs_test.go
    • Line 14: warning: undeclared name: StringFlag (ineffassign)
    • Line 21: warning: undeclared name: StringFlag (ineffassign)
    • Line 35: warning: undeclared name: StringFlag (ineffassign)
    • Line 51: warning: undeclared name: StringFlag (ineffassign)
    • Line 73: warning: undeclared name: StringFlag (ineffassign)
    • cli/flag_test.go
    • Line 107: warning: undeclared name: StringFlag (ineffassign)
    • Line 174: warning: undeclared name: StringFlag (ineffassign)
    • Line 184: warning: undeclared name: StringFlag (ineffassign)
    • Line 199: warning: undeclared name: StringFlag (ineffassign)
    • Line 242: warning: undeclared name: StringFlag (ineffassign)
    • Line 953: warning: undeclared name: StringFlag (ineffassign)
    • Line 956: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 959: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 971: warning: undeclared name: StringFlag (ineffassign)
    • Line 991: warning: undeclared name: StringFlag (ineffassign)
    • Line 994: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 997: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 1011: warning: undeclared name: StringFlag (ineffassign)
    • Line 1014: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 1017: warning: ctx.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 2012: warning: undeclared name: StringFlag (ineffassign)
    • cli/altsrc/toml_file_loader.go
    • Line 91: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 91: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • cli/altsrc/flag_test.go
    • Line 32: warning: undeclared name: NewGenericFlag (ineffassign)
    • Line 42: warning: undeclared name: NewGenericFlag (ineffassign)
    • Line 52: warning: undeclared name: NewGenericFlag (ineffassign)
    • Line 67: warning: undeclared name: NewStringSliceFlag (ineffassign)
    • Line 76: warning: undeclared name: NewStringSliceFlag (ineffassign)
    • Line 86: warning: undeclared name: NewStringSliceFlag (ineffassign)
    • Line 97: warning: undeclared name: NewIntSliceFlag (ineffassign)
    • Line 106: warning: undeclared name: NewIntSliceFlag (ineffassign)
    • Line 116: warning: undeclared name: NewIntSliceFlag (ineffassign)
    • Line 127: warning: undeclared name: NewBoolFlag (ineffassign)
    • Line 136: warning: undeclared name: NewBoolFlag (ineffassign)
    • Line 146: warning: undeclared name: NewBoolFlag (ineffassign)
    • Line 157: warning: undeclared name: NewStringFlag (ineffassign)
    • Line 157: warning: StringFlag not declared by package cli (ineffassign)
    • Line 161: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 166: warning: undeclared name: NewStringFlag (ineffassign)
    • Line 166: warning: StringFlag not declared by package cli (ineffassign)
    • Line 171: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 176: warning: undeclared name: NewStringFlag (ineffassign)
    • Line 176: warning: StringFlag not declared by package cli (ineffassign)
    • Line 182: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 186: warning: undeclared name: NewPathFlag (ineffassign)
    • Line 202: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 207: warning: undeclared name: NewPathFlag (ineffassign)
    • Line 213: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 218: warning: undeclared name: NewPathFlag (ineffassign)
    • Line 225: warning: c.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 230: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 239: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 249: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 260: warning: undeclared name: NewDurationFlag (ineffassign)
    • Line 269: warning: undeclared name: NewDurationFlag (ineffassign)
    • Line 279: warning: undeclared name: NewDurationFlag (ineffassign)
    • Line 290: warning: undeclared name: NewFloat64Flag (ineffassign)
    • Line 299: warning: undeclared name: NewFloat64Flag (ineffassign)
    • Line 309: warning: undeclared name: NewFloat64Flag (ineffassign)
    • cli/app_test.go
    • Line 40: warning: undeclared name: StringFlag (ineffassign)
    • Line 43: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 73: warning: undeclared name: StringFlag (ineffassign)
    • Line 80: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 107: warning: undeclared name: StringFlag (ineffassign)
    • Line 157: warning: undeclared name: StringFlag (ineffassign)
    • Line 241: warning: undeclared name: StringFlag (ineffassign)
    • Line 268: warning: undeclared name: StringFlag (ineffassign)
    • Line 272: warning: undeclared name: StringFlag (ineffassign)
    • Line 275: warning: undeclared name: StringFlag (ineffassign)
    • Line 296: warning: undeclared name: StringFlag (ineffassign)
    • Line 300: warning: undeclared name: StringFlag (ineffassign)
    • Line 303: warning: undeclared name: StringFlag (ineffassign)
    • Line 306: warning: undeclared name: StringFlag (ineffassign)
    • Line 459: warning: undeclared name: StringFlag (ineffassign)
    • Line 472: warning: context.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 479: warning: undeclared name: StringFlag (ineffassign)
    • Line 502: warning: undeclared name: StringFlag (ineffassign)
    • Line 505: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 625: warning: undeclared name: StringFlag (ineffassign)
    • Line 630: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 644: warning: undeclared name: StringFlag (ineffassign)
    • Line 663: warning: undeclared name: StringFlag (ineffassign)
    • Line 668: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 686: warning: undeclared name: StringFlag (ineffassign)
    • Line 710: warning: undeclared name: StringFlag (ineffassign)
    • Line 715: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 738: warning: undeclared name: StringFlag (ineffassign)
    • Line 978: warning: undeclared name: StringFlag (ineffassign)
    • Line 960: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 1069: warning: undeclared name: StringFlag (ineffassign)
    • Line 1051: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 1136: warning: undeclared name: StringFlag (ineffassign)
    • Line 1144: warning: undeclared name: StringFlag (ineffassign)
    • Line 1155: warning: undeclared name: StringFlag (ineffassign)
    • Line 1164: warning: undeclared name: StringFlag (ineffassign)
    • Line 1171: warning: undeclared name: StringFlag (ineffassign)
    • Line 1181: warning: undeclared name: StringFlag (ineffassign)
    • Line 1189: warning: undeclared name: StringFlag (ineffassign)
    • Line 1189: warning: undeclared name: StringFlag (ineffassign)
    • Line 1197: warning: undeclared name: StringFlag (ineffassign)
    • Line 1197: warning: undeclared name: StringFlag (ineffassign)
    • Line 1208: warning: undeclared name: StringFlag (ineffassign)
    • Line 1208: warning: undeclared name: StringFlag (ineffassign)
    • Line 1217: warning: undeclared name: StringFlag (ineffassign)
    • Line 1224: warning: undeclared name: StringFlag (ineffassign)
    • Line 1234: warning: undeclared name: StringFlag (ineffassign)
    • cli/altsrc/flag.go
    • Line 66: warning: undeclared name: GenericFlag (ineffassign)
    • Line 85: warning: undeclared name: StringSliceFlag (ineffassign)
    • Line 107: warning: undeclared name: IntSliceFlag (ineffassign)
    • Line 129: warning: undeclared name: BoolFlag (ineffassign)
    • Line 147: warning: undeclared name: StringFlag (ineffassign)
    • Line 165: warning: undeclared name: PathFlag (ineffassign)
    • Line 193: warning: undeclared name: IntFlag (ineffassign)
    • Line 211: warning: undeclared name: DurationFlag (ineffassign)
    • Line 229: warning: undeclared name: Float64Flag (ineffassign)
    • Line 66: warning: undeclared name: GenericFlag (ineffassign)
    • Line 85: warning: undeclared name: StringSliceFlag (ineffassign)
    • Line 107: warning: undeclared name: IntSliceFlag (ineffassign)
    • Line 129: warning: undeclared name: BoolFlag (ineffassign)
    • Line 147: warning: undeclared name: StringFlag (ineffassign)
    • Line 165: warning: undeclared name: PathFlag (ineffassign)
    • Line 193: warning: undeclared name: IntFlag (ineffassign)
    • Line 211: warning: undeclared name: DurationFlag (ineffassign)
    • Line 229: warning: undeclared name: Float64Flag (ineffassign)
    • cli/altsrc/yaml_file_loader.go
    • Line 37: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 37: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • cli/altsrc/json_source_context.go
    • Line 21: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • Line 21: warning: context.String undefined (type *cli.Context has no field or method String) (ineffassign)
    • cli/altsrc/toml_command_test.go
    • Line 33: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 34: warning: StringFlag not declared by package cli (ineffassign)
    • Line 66: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 67: warning: StringFlag not declared by package cli (ineffassign)
    • Line 100: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 101: warning: StringFlag not declared by package cli (ineffassign)
    • Line 132: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 133: warning: StringFlag not declared by package cli (ineffassign)
    • Line 165: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 166: warning: StringFlag not declared by package cli (ineffassign)
    • Line 197: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 198: warning: StringFlag not declared by package cli (ineffassign)
    • Line 229: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 230: warning: StringFlag not declared by package cli (ineffassign)
    • Line 264: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 265: warning: StringFlag not declared by package cli (ineffassign)
    • Line 298: warning: undeclared name: NewIntFlag (ineffassign)
    • Line 299: warning: StringFlag not declared by package cli (ineffassign)
    • cli/fish.go
    • Line 166: warning: undeclared name: StringFlag (ineffassign)
    • Line 166: warning: undeclared name: StringFlag (ineffassign)
    • cli/context_test.go
    • Line 113: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 114: warning: c.String undefined (type *Context has no field or method String) (ineffassign)
    • Line 205: warning: undeclared name: StringFlag (ineffassign)
    • Line 450: warning: undeclared name: StringFlag (ineffassign)
    • Line 456: warning: undeclared name: StringFlag (ineffassign)
    • Line 464: warning: undeclared name: StringFlag (ineffassign)
    • Line 471: warning: undeclared name: StringFlag (ineffassign)
    • Line 478: warning: undeclared name: StringFlag (ineffassign)
    • Line 479: warning: undeclared name: StringFlag (ineffassign)
    • Line 486: warning: undeclared name: StringFlag (ineffassign)
    • Line 487: warning: undeclared name: StringFlag (ineffassign)
    • Line 495: warning: undeclared name: StringFlag (ineffassign)
    • Line 496: warning: undeclared name: StringFlag (ineffassign)
    • Line 504: warning: undeclared name: StringFlag (ineffassign)
    • Line 505: warning: undeclared name: StringFlag (ineffassign)
    • Line 512: warning: undeclared name: StringFlag (ineffassign)
    • Line 513: warning: undeclared name: StringFlag (ineffassign)
    • Line 521: warning: undeclared name: StringFlag (ineffassign)
    • Line 522: warning: undeclared name: StringFlag (ineffassign)
    • Line 530: warning: undeclared name: StringFlag (ineffassign)
    • Line 531: warning: undeclared name: StringFlag (ineffassign)

misspell96%

Misspell Finds commonly misspelled English words