Report for ext.arhat.dev/runtimeutil
A+ Excellent! Found 19 issues across 31 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo93%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
/ext.arhat.dev/runtimeutil/storageutil/remove.go
- Line 33: warning: cyclomatic complexity 21 of function RemoveAllOneFilesystem() is high (> 15) (gocyclo)
-
-
/ext.arhat.dev/runtimeutil/actionutil/logs.go
- Line 315: warning: cyclomatic complexity 24 of function ReadLogs() is high (> 15) (gocyclo)
golint45%
Golint is a linter for Go source code.
-
-
/ext.arhat.dev/runtimeutil/storageutil/sshfs/sshfs_unix.go
- Line 42: warning: exported type Config should have comment or be unexported (golint)
- Line 46: warning: exported function New should have comment or be unexported (golint)
- Line 119: warning: exported type Driver should have comment or be unexported (golint)
- Line 123: warning: exported method Driver.GetMountCmd should have comment or be unexported (golint)
- Line 127: warning: exported method Driver.GetUnmountCmd should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/client_config_flags.go
- Line 27: warning: exported function FlagsForClient should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/general/general_unix.go
- Line 40: warning: exported function New should have comment or be unexported (golint)
- Line 49: warning: exported type Config should have comment or be unexported (golint)
- Line 56: warning: exported type Driver should have comment or be unexported (golint)
- Line 60: warning: exported method Driver.GetMountCmd should have comment or be unexported (golint)
- Line 66: warning: exported method Driver.GetUnmountCmd should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/networkutil/client.go
- Line 46: warning: exported function NewClient should have comment or be unexported (golint)
- Line 52: warning: exported type Client should have comment or be unexported (golint)
- Line 56: warning: exported method Client.CreateResolvConf should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/registry.go
- Line 24: warning: exported type ConfigFactoryFunc should have comment or be unexported (golint)
- Line 25: warning: exported type FactoryFunc should have comment or be unexported (golint)
- Line 46: warning: exported function Register should have comment or be unexported (golint)
- Line 62: warning: exported function NewConfig should have comment or be unexported (golint)
- Line 71: warning: exported function NewDriver should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/names.go
- Line 25: warning: exported function GetContainerName should have comment or be unexported (golint)
- Line 29: warning: comment on exported function SharedNamespaces should be of the form "SharedNamespaces ..." (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/client_config.go
- Line 29: warning: exported type DriverConfig should have comment or be unexported (golint)
- Line 34: warning: exported type ClientConfig should have comment or be unexported (golint)
- Line 44: warning: exported method ClientConfig.CreateClient should have comment or be unexported (golint)
- Line 53: warning: exported method DriverConfig.UnmarshalJSON should have comment or be unexported (golint)
- Line 64: warning: exported method DriverConfig.UnmarshalYAML should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/exec.go
- Line 28: warning: exported const StorageArgEnvRemotePath should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported function LookupUnmountUtil should have comment or be unexported (golint)
- Line 53: warning: exported function GenerateUnmountCmd should have comment or be unexported (golint)
- Line 73: warning: exported function ResolveStorageCommand should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/volume.go
- Line 27: warning: exported function CleanupPodData should have comment or be unexported (golint)
- Line 52: warning: exported function ResolveHostPathMountSource should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/constant.go
- Line 20: warning: exported const LabelRole should have comment (or a comment on this block) or be unexported (golint)
- Line 39: warning: exported const ContainerNamePause should have comment (or a comment on this block) or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/error.go
- Line 21: warning: exported function CollectErrors should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/image.go
- Line 24: warning: exported const DefaultDockerImageDomain should have comment (or a comment on this block) or be unexported (golint)
- Line 53: warning: exported function GetEnv should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/labels.go
- Line 23: warning: exported function AbbotMatchLabels should have comment or be unexported (golint)
- Line 32: warning: exported function IsPauseContainer should have comment or be unexported (golint)
- Line 40: warning: exported function IsAbbotPod should have comment or be unexported (golint)
- Line 57: warning: exported function IsHostNetwork should have comment or be unexported (golint)
- Line 66: warning: exported function ContainerLabels should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/containerutil/base_runtime.go
- Line 25: warning: exported function NewBaseRuntime should have comment or be unexported (golint)
- Line 46: warning: exported type BaseRuntime should have comment or be unexported (golint)
- Line 56: warning: exported method BaseRuntime.Name should have comment or be unexported (golint)
- Line 57: warning: exported method BaseRuntime.Version should have comment or be unexported (golint)
- Line 58: warning: exported method BaseRuntime.OS should have comment or be unexported (golint)
- Line 59: warning: exported method BaseRuntime.OSImage should have comment or be unexported (golint)
- Line 60: warning: exported method BaseRuntime.Arch should have comment or be unexported (golint)
- Line 61: warning: exported method BaseRuntime.KernelVersion should have comment or be unexported (golint)
- Line 63: warning: exported method BaseRuntime.ImageActionContext should have comment or be unexported (golint)
- Line 67: warning: exported method BaseRuntime.PodActionContext should have comment or be unexported (golint)
- Line 71: warning: exported method BaseRuntime.ActionContext should have comment or be unexported (golint)
- Line 75: warning: exported method BaseRuntime.PodDir should have comment or be unexported (golint)
- Line 83: warning: exported method BaseRuntime.PodRemoteVolumeDir should have comment or be unexported (golint)
- Line 87: warning: exported method BaseRuntime.PodBindVolumeDir should have comment or be unexported (golint)
- Line 91: warning: exported method BaseRuntime.PodTmpfsVolumeDir should have comment or be unexported (golint)
- Line 95: warning: exported method BaseRuntime.PodResolvConfFile should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/client.go
- Line 36: warning: exported var ErrMountpointInUse should have comment or be unexported (golint)
- Line 40: warning: exported function NewClient should have comment or be unexported (golint)
- Line 87: warning: exported type Client should have comment or be unexported (golint)
- Line 122: warning: exported method Client.Mount should have comment or be unexported (golint)
- Line 213: warning: exported method Client.Unmount should have comment or be unexported (golint)
- Line 236: warning: exported method Client.Close should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/nop.go
- Line 19: warning: exported type NopConfig should have comment or be unexported (golint)
- Line 20: warning: exported type NopDriver should have comment or be unexported (golint)
- Line 22: warning: exported method NopDriver.GetMountCmd should have comment or be unexported (golint)
- Line 23: warning: exported method NopDriver.GetUnmountCmd should have comment or be unexported (golint)
-
-
/ext.arhat.dev/runtimeutil/storageutil/types.go
- Line 19: warning: exported type ExitHandleFunc should have comment or be unexported (golint)
- Line 21: warning: exported type Interface should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!