Go Report Card

Preparing report...

Report for github.com/1lann/lol-replay

A+    Excellent!    Found 3 issues across 17 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • lol-replay/recording/recording_ffjson.go
    • Line 1292: warning: cyclomatic complexity 102 of function (*recordingHeader).UnmarshalJSONFFLexer() is high (> 15) (gocyclo)
    • Line 105: warning: cyclomatic complexity 96 of function (*ChunkInfo).UnmarshalJSONFFLexer() is high (> 15) (gocyclo)
    • Line 700: warning: cyclomatic complexity 61 of function (*GameInfo).UnmarshalJSONFFLexer() is high (> 15) (gocyclo)
    • Line 1924: warning: cyclomatic complexity 42 of function (*segment).UnmarshalJSONFFLexer() is high (> 15) (gocyclo)
    • Line 1054: warning: cyclomatic complexity 26 of function (*Recording).UnmarshalJSONFFLexer() is high (> 15) (gocyclo)

golint88%

Golint is a linter for Go source code.

    • lol-replay/record/retrieve_ffjson.go
    • Line 44: warning: don't use underscores in Go names; const ffj_t_metadatabase should be ffjTMetadatabase (golint)
    • Line 45: warning: don't use underscores in Go names; const ffj_t_metadatano_such_key should be ffjTMetadatanoSuchKey (golint)
    • Line 47: warning: don't use underscores in Go names; const ffj_t_metadata_StartupChunk should be ffjTMetadataStartupChunk (golint)
    • Line 49: warning: don't use underscores in Go names; const ffj_t_metadata_LastChunk should be ffjTMetadataLastChunk (golint)
    • Line 52: warning: don't use underscores in Go names; var ffj_key_metadata_StartupChunk should be ffjKeyMetadataStartupChunk (golint)
    • Line 54: warning: don't use underscores in Go names; var ffj_key_metadata_LastChunk should be ffjKeyMetadataLastChunk (golint)
    • Line 56: warning: receiver name uj should be consistent with previous receiver name mj for metadata (golint)
    • Line 61: warning: receiver name uj should be consistent with previous receiver name mj for metadata (golint)
    • lol-replay/recording/recording_ffjson.go
    • Line 16: warning: exported method ChunkInfo.MarshalJSON should have comment or be unexported (golint)
    • Line 28: warning: exported method ChunkInfo.MarshalJSONBuf should have comment or be unexported (golint)
    • Line 60: warning: don't use underscores in Go names; const ffj_t_ChunkInfobase should be ffjTChunkInfobase (golint)
    • Line 61: warning: don't use underscores in Go names; const ffj_t_ChunkInfono_such_key should be ffjTChunkInfonoSuchKey (golint)
    • Line 63: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_CurrentChunk should be ffjTChunkInfoCurrentChunk (golint)
    • Line 65: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_AvailableSince should be ffjTChunkInfoAvailableSince (golint)
    • Line 67: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_NextUpdate should be ffjTChunkInfoNextUpdate (golint)
    • Line 69: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_CurrentKeyFrame should be ffjTChunkInfoCurrentKeyFrame (golint)
    • Line 71: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_NextChunk should be ffjTChunkInfoNextChunk (golint)
    • Line 73: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_EndStartupChunk should be ffjTChunkInfoEndStartupChunk (golint)
    • Line 75: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_StartGameChunk should be ffjTChunkInfoStartGameChunk (golint)
    • Line 77: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_EndGameChunk should be ffjTChunkInfoEndGameChunk (golint)
    • Line 79: warning: don't use underscores in Go names; const ffj_t_ChunkInfo_Duration should be ffjTChunkInfoDuration (golint)
    • Line 82: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_CurrentChunk should be ffjKeyChunkInfoCurrentChunk (golint)
    • Line 84: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_AvailableSince should be ffjKeyChunkInfoAvailableSince (golint)
    • Line 86: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_NextUpdate should be ffjKeyChunkInfoNextUpdate (golint)
    • Line 88: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_CurrentKeyFrame should be ffjKeyChunkInfoCurrentKeyFrame (golint)
    • Line 90: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_NextChunk should be ffjKeyChunkInfoNextChunk (golint)
    • Line 92: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_EndStartupChunk should be ffjKeyChunkInfoEndStartupChunk (golint)
    • Line 94: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_StartGameChunk should be ffjKeyChunkInfoStartGameChunk (golint)
    • Line 96: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_EndGameChunk should be ffjKeyChunkInfoEndGameChunk (golint)
    • Line 98: warning: don't use underscores in Go names; var ffj_key_ChunkInfo_Duration should be ffjKeyChunkInfoDuration (golint)
    • Line 100: warning: exported method ChunkInfo.UnmarshalJSON should have comment or be unexported (golint)
    • Line 100: warning: receiver name uj should be consistent with previous receiver name mj for ChunkInfo (golint)
    • Line 105: warning: exported method ChunkInfo.UnmarshalJSONFFLexer should have comment or be unexported (golint)
    • Line 105: warning: receiver name uj should be consistent with previous receiver name mj for ChunkInfo (golint)
    • Line 626: warning: exported method GameInfo.MarshalJSON should have comment or be unexported (golint)
    • Line 638: warning: exported method GameInfo.MarshalJSONBuf should have comment or be unexported (golint)
    • Line 671: warning: don't use underscores in Go names; const ffj_t_GameInfobase should be ffjTGameInfobase (golint)
    • Line 672: warning: don't use underscores in Go names; const ffj_t_GameInfono_such_key should be ffjTGameInfonoSuchKey (golint)
    • Line 674: warning: don't use underscores in Go names; const ffj_t_GameInfo_Platform should be ffjTGameInfoPlatform (golint)
    • Line 676: warning: don't use underscores in Go names; const ffj_t_GameInfo_Version should be ffjTGameInfoVersion (golint)
    • Line 678: warning: don't use underscores in Go names; const ffj_t_GameInfo_GameID should be ffjTGameInfoGameID (golint)
    • Line 680: warning: don't use underscores in Go names; const ffj_t_GameInfo_EncryptionKey should be ffjTGameInfoEncryptionKey (golint)
    • Line 682: warning: don't use underscores in Go names; const ffj_t_GameInfo_RecordTime should be ffjTGameInfoRecordTime (golint)
    • Line 685: warning: don't use underscores in Go names; var ffj_key_GameInfo_Platform should be ffjKeyGameInfoPlatform (golint)
    • Line 687: warning: don't use underscores in Go names; var ffj_key_GameInfo_Version should be ffjKeyGameInfoVersion (golint)
    • Line 689: warning: don't use underscores in Go names; var ffj_key_GameInfo_GameID should be ffjKeyGameInfoGameID (golint)
    • Line 691: warning: don't use underscores in Go names; var ffj_key_GameInfo_EncryptionKey should be ffjKeyGameInfoEncryptionKey (golint)
    • Line 693: warning: don't use underscores in Go names; var ffj_key_GameInfo_RecordTime should be ffjKeyGameInfoRecordTime (golint)
    • Line 695: warning: exported method GameInfo.UnmarshalJSON should have comment or be unexported (golint)
    • Line 695: warning: receiver name uj should be consistent with previous receiver name mj for GameInfo (golint)
    • Line 700: warning: exported method GameInfo.UnmarshalJSONFFLexer should have comment or be unexported (golint)
    • Line 700: warning: receiver name uj should be consistent with previous receiver name mj for GameInfo (golint)
    • Line 1019: warning: exported method Recording.MarshalJSON should have comment or be unexported (golint)
    • Line 1031: warning: exported method Recording.MarshalJSONBuf should have comment or be unexported (golint)
    • Line 1045: warning: don't use underscores in Go names; const ffj_t_Recordingbase should be ffjTRecordingbase (golint)
    • Line 1046: warning: don't use underscores in Go names; const ffj_t_Recordingno_such_key should be ffjTRecordingnoSuchKey (golint)
    • Line 1049: warning: exported method Recording.UnmarshalJSON should have comment or be unexported (golint)
    • Line 1049: warning: receiver name uj should be consistent with previous receiver name mj for Recording (golint)
    • Line 1054: warning: exported method Recording.UnmarshalJSONFFLexer should have comment or be unexported (golint)
    • Line 1054: warning: receiver name uj should be consistent with previous receiver name mj for Recording (golint)
    • Line 1251: warning: don't use underscores in Go names; const ffj_t_recordingHeaderbase should be ffjTRecordingHeaderbase (golint)
    • Line 1252: warning: don't use underscores in Go names; const ffj_t_recordingHeaderno_such_key should be ffjTRecordingHeadernoSuchKey (golint)
    • Line 1254: warning: don't use underscores in Go names; const ffj_t_recordingHeader_GameMetadata should be ffjTRecordingHeaderGameMetadata (golint)
    • Line 1256: warning: don't use underscores in Go names; const ffj_t_recordingHeader_FirstChunkInfo should be ffjTRecordingHeaderFirstChunkInfo (golint)
    • Line 1258: warning: don't use underscores in Go names; const ffj_t_recordingHeader_LastChunkInfo should be ffjTRecordingHeaderLastChunkInfo (golint)
    • Line 1260: warning: don't use underscores in Go names; const ffj_t_recordingHeader_KeyFrameMap should be ffjTRecordingHeaderKeyFrameMap (golint)
    • Line 1262: warning: don't use underscores in Go names; const ffj_t_recordingHeader_ChunkMap should be ffjTRecordingHeaderChunkMap (golint)
    • Line 1264: warning: don't use underscores in Go names; const ffj_t_recordingHeader_Info should be ffjTRecordingHeaderInfo (golint)
    • Line 1266: warning: don't use underscores in Go names; const ffj_t_recordingHeader_UserMetadata should be ffjTRecordingHeaderUserMetadata (golint)
    • Line 1268: warning: don't use underscores in Go names; const ffj_t_recordingHeader_IsComplete should be ffjTRecordingHeaderIsComplete (golint)
    • Line 1271: warning: don't use underscores in Go names; var ffj_key_recordingHeader_GameMetadata should be ffjKeyRecordingHeaderGameMetadata (golint)
    • Line 1273: warning: don't use underscores in Go names; var ffj_key_recordingHeader_FirstChunkInfo should be ffjKeyRecordingHeaderFirstChunkInfo (golint)
    • Line 1275: warning: don't use underscores in Go names; var ffj_key_recordingHeader_LastChunkInfo should be ffjKeyRecordingHeaderLastChunkInfo (golint)
    • Line 1277: warning: don't use underscores in Go names; var ffj_key_recordingHeader_KeyFrameMap should be ffjKeyRecordingHeaderKeyFrameMap (golint)
    • Line 1279: warning: don't use underscores in Go names; var ffj_key_recordingHeader_ChunkMap should be ffjKeyRecordingHeaderChunkMap (golint)
    • Line 1281: warning: don't use underscores in Go names; var ffj_key_recordingHeader_Info should be ffjKeyRecordingHeaderInfo (golint)
    • Line 1283: warning: don't use underscores in Go names; var ffj_key_recordingHeader_UserMetadata should be ffjKeyRecordingHeaderUserMetadata (golint)
    • Line 1285: warning: don't use underscores in Go names; var ffj_key_recordingHeader_IsComplete should be ffjKeyRecordingHeaderIsComplete (golint)
    • Line 1287: warning: receiver name uj should be consistent with previous receiver name mj for recordingHeader (golint)
    • Line 1292: warning: receiver name uj should be consistent with previous receiver name mj for recordingHeader (golint)
    • Line 1599: warning: don't use underscores in Go names; var tmp_uj__KeyFrameMap should be tmpUjKeyFrameMap (golint)
    • Line 1703: warning: don't use underscores in Go names; var tmp_uj__ChunkMap should be tmpUjChunkMap (golint)
    • Line 1907: warning: don't use underscores in Go names; const ffj_t_segmentbase should be ffjTSegmentbase (golint)
    • Line 1908: warning: don't use underscores in Go names; const ffj_t_segmentno_such_key should be ffjTSegmentnoSuchKey (golint)
    • Line 1910: warning: don't use underscores in Go names; const ffj_t_segment_Position should be ffjTSegmentPosition (golint)
    • Line 1912: warning: don't use underscores in Go names; const ffj_t_segment_Length should be ffjTSegmentLength (golint)
    • Line 1915: warning: don't use underscores in Go names; var ffj_key_segment_Position should be ffjKeySegmentPosition (golint)
    • Line 1917: warning: don't use underscores in Go names; var ffj_key_segment_Length should be ffjKeySegmentLength (golint)
    • Line 1919: warning: receiver name uj should be consistent with previous receiver name mj for segment (golint)
    • Line 1924: warning: receiver name uj should be consistent with previous receiver name mj for segment (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign82%

IneffAssign detects ineffectual assignments in Go code.

    • lol-replay/recording/recording_ffjson.go
    • Line 106: warning: ineffectual assignment to err (ineffassign)
    • Line 701: warning: ineffectual assignment to err (ineffassign)
    • Line 996: warning: ineffectual assignment to state (ineffassign)
    • Line 1055: warning: ineffectual assignment to err (ineffassign)
    • Line 1293: warning: ineffectual assignment to err (ineffassign)
    • Line 1527: warning: ineffectual assignment to state (ineffassign)
    • Line 1548: warning: ineffectual assignment to state (ineffassign)
    • Line 1569: warning: ineffectual assignment to state (ineffassign)
    • Line 1617: warning: ineffectual assignment to wantVal (ineffassign)
    • Line 1665: warning: ineffectual assignment to state (ineffassign)
    • Line 1721: warning: ineffectual assignment to wantVal (ineffassign)
    • Line 1769: warning: ineffectual assignment to state (ineffassign)
    • Line 1798: warning: ineffectual assignment to state (ineffassign)
    • Line 1819: warning: ineffectual assignment to state (ineffassign)
    • Line 1925: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!