Preparing report...

Report for github.com/90poe/connectctl

A+    Excellent!    Found 15 issues across 58 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint75%

Golint is a linter for Go source code.

    • connectctl/internal/ctl/tasks/list.go
    • Line 11: warning: exported type ListOptions should have comment or be unexported (golint)
    • Line 22: warning: exported function NewListCommand should have comment or be unexported (golint)
    • Line 43: warning: exported method ListOptions.Run should have comment or be unexported (golint)
    • connectctl/internal/ctl/tasks/status.go
    • Line 11: warning: exported type StatusOptions should have comment or be unexported (golint)
    • Line 18: warning: exported function NewStatusCommand should have comment or be unexported (golint)
    • Line 42: warning: exported method StatusOptions.Run should have comment or be unexported (golint)
    • connectctl/internal/ctl/tasks/get.go
    • Line 12: warning: exported type GetOptions should have comment or be unexported (golint)
    • Line 19: warning: exported function NewGetCommand should have comment or be unexported (golint)
    • Line 43: warning: exported method GetOptions.Run should have comment or be unexported (golint)
    • connectctl/pkg/client/connect/plugins.go
    • Line 19: warning: exported type FieldDefinition should have comment or be unexported (golint)
    • Line 33: warning: exported type FieldValue should have comment or be unexported (golint)
    • Line 41: warning: exported type FieldValidation should have comment or be unexported (golint)
    • Line 46: warning: exported type ConfigValidation should have comment or be unexported (golint)
    • connectctl/internal/ctl/tasks/output.go
    • Line 11: warning: exported type OutputType should have comment or be unexported (golint)
    • Line 14: warning: exported const OutputTypeJSON should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported type TaskListOutputFn should have comment or be unexported (golint)
    • Line 20: warning: exported function OutputTaskListAsJSON should have comment or be unexported (golint)
    • Line 28: warning: exported function OutputTaskListAsTable should have comment or be unexported (golint)
    • Line 45: warning: exported function DefaultMarshalIndent should have comment or be unexported (golint)
    • Line 49: warning: exported type TaskStateOutputFn should have comment or be unexported (golint)
    • Line 51: warning: exported function OutputTaskStateAsJSON should have comment or be unexported (golint)
    • Line 59: warning: exported function OutputTaskStateAsTable should have comment or be unexported (golint)
    • connectctl/internal/ctl/tasks/restart.go
    • Line 8: warning: exported type RestartOptions should have comment or be unexported (golint)
    • Line 14: warning: exported function NewRestartCommand should have comment or be unexported (golint)
    • Line 36: warning: exported method RestartOptions.Run should have comment or be unexported (golint)
    • connectctl/internal/ctl/tasks/tasks.go
    • Line 12: warning: exported type ClientFn should have comment or be unexported (golint)
    • Line 14: warning: exported type Client should have comment or be unexported (golint)
    • Line 20: warning: exported type GenericOptions should have comment or be unexported (golint)
    • Line 28: warning: exported function Command should have comment or be unexported (golint)
    • Line 64: warning: exported method GenericOptions.Validate should have comment or be unexported (golint)
    • connectctl/internal/ctl/flags.go
    • Line 12: warning: exported function AddClusterFlag should have comment or be unexported (golint)
    • Line 22: warning: exported function AddCommonConnectorsFlags should have comment or be unexported (golint)
    • Line 26: warning: exported function AddOutputFlags should have comment or be unexported (golint)
    • Line 30: warning: exported function AddQuietFlag should have comment or be unexported (golint)
    • Line 34: warning: exported function AddInputFlag should have comment or be unexported (golint)
    • Line 44: warning: exported function AddDefinitionFilesFlags should have comment or be unexported (golint)
    • Line 50: warning: exported function AddConnectorNamesFlags should have comment or be unexported (golint)
    • Line 54: warning: exported function BindDurationVarP should have comment or be unexported (golint)
    • Line 60: warning: exported function BindDurationVar should have comment or be unexported (golint)
    • Line 66: warning: exported function BindBoolVar should have comment or be unexported (golint)
    • Line 72: warning: exported function BindBoolVarP should have comment or be unexported (golint)
    • Line 78: warning: exported function BindStringVarP should have comment or be unexported (golint)
    • Line 84: warning: exported function BindStringVar should have comment or be unexported (golint)
    • Line 90: warning: exported function BindStringArrayVarP should have comment or be unexported (golint)
    • Line 96: warning: exported function BindIntVar should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!