Report for github.com/DOSNetwork/core
A+ Excellent! Found 22 issues across 93 files
gofmt98%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
core/dosnode/dos_chain_handler.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint82%
Golint is a linter for Go source code.
-
-
core/main.go
- Line 29: warning: exported var Version should have comment or be unexported (golint)
- Line 291: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
core/onchain/eth_get.go
- Line 351: warning: exported type PendingGroupT should have comment or be unexported (golint)
- Line 658: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
core/onchain/eth_proxy.go
- Line 212: warning: should not use basic type string as key in context.WithValue (golint)
-
-
core/dosnode/dos_chain_handler.go
- Line 33: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
- Line 203: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
-
-
core/share/dkg/pedersen/errorrs.go
- Line 10: warning: exported var ErrDupPubKey should have comment or be unexported (golint)
- Line 22: warning: exported type DKGError should have comment or be unexported (golint)
- Line 27: warning: exported method DKGError.Format should have comment or be unexported (golint)
- Line 31: warning: exported method DKGError.FormatError should have comment or be unexported (golint)
-
-
core/onchain/errors.go
- Line 9: warning: exported type OnchainError should have comment or be unexported (golint)
- Line 15: warning: exported method OnchainError.Format should have comment or be unexported (golint)
- Line 19: warning: exported method OnchainError.FormatError should have comment or be unexported (golint)
-
-
core/onchain/eth_helpers.go
- Line 27: warning: exported type DialResult should have comment or be unexported (golint)
- Line 115: warning: exported function GenEthkey should have comment or be unexported (golint)
- Line 128: warning: exported function NumOfAccounts should have comment or be unexported (golint)
- Line 311: warning: exported function GetChainId should have comment or be unexported (golint)
-
-
core/dosnode/dosnode.go
- Line 147: warning: exported method DosNode.Start should have comment or be unexported (golint)
-
-
core/configuration/config.go
- Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
core/p2p/error.go
- Line 11: warning: exported var ErrNoRemoteID should have comment or be unexported (golint)
- Line 19: warning: exported type P2PError should have comment or be unexported (golint)
- Line 26: warning: exported method P2PError.Format should have comment or be unexported (golint)
- Line 30: warning: exported method P2PError.FormatError should have comment or be unexported (golint)
-
-
core/p2p/request.go
- Line 30: warning: exported function NewP2pRequest should have comment or be unexported (golint)
-
-
core/onchain/chain_adaptor.go
- Line 20: warning: exported const HECO should have comment (or a comment on this block) or be unexported (golint)
-
-
core/p2p/discover/membership.go
- Line 25: warning: exported type P2PEvent should have comment or be unexported (golint)
-
-
core/p2p/discover/simulator.go
- Line 8: warning: comment on exported function NewSimulator should be of the form "NewSimulator ..." (golint)
-
-
core/utils/utils.go
- Line 10: warning: exported function AllowConnection should have comment or be unexported (golint)
- Line 21: warning: exported function ResetConnList should have comment or be unexported (golint)
- Line 49: warning: exported function ReportError should have comment or be unexported (golint)
- Line 57: warning: exported function ReportResult should have comment or be unexported (golint)
- Line 65: warning: exported function MergeErrors should have comment or be unexported (golint)
-
-
core/onchain/eventMsg.go
- Line 10: warning: exported type LogCommon should have comment or be unexported (golint)
gocyclo91%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
core/share/dkg/pedersen/pdkg.go
- Line 110: warning: cyclomatic complexity 17 of function (*pdkg).Loop() is high (> 15) (gocyclo)
-
-
core/p2p/client.go
- Line 295: warning: cyclomatic complexity 23 of function (*client).dispatch() is high (> 15) (gocyclo)
-
-
core/p2p/server.go
- Line 420: warning: cyclomatic complexity 17 of function (*server).messageDispatch() is high (> 15) (gocyclo)
-
-
core/onchain/eth_proxy.go
- Line 131: warning: cyclomatic complexity 17 of function (*ethAdaptor).Connect() is high (> 15) (gocyclo)
-
-
core/dosnode/dos_chain_handler.go
- Line 21: warning: cyclomatic complexity 46 of function (*DosNode).onchainLoop() is high (> 15) (gocyclo)
- Line 350: warning: cyclomatic complexity 20 of function (*DosNode).handleGroupFormation() is high (> 15) (gocyclo)
-
-
core/dosnode/dos_query_handler.go
- Line 15: warning: cyclomatic complexity 19 of function (*DosNode).queryLoop() is high (> 15) (gocyclo)
-
-
core/dosnode/dosnode.go
- Line 147: warning: cyclomatic complexity 17 of function (*DosNode).Start() is high (> 15) (gocyclo)
-
-
core/dosnode/dos_restapis.go
- Line 217: warning: cyclomatic complexity 17 of function (*DosNode).dkgTest() is high (> 15) (gocyclo)
ineffassign93%
IneffAssign detects ineffectual assignments in Go code.
-
-
core/dosnode/dos_chain_handler.go
- Line 324: warning: ineffectual assignment to waitRandom (ineffassign)
-
-
core/dosnode/dosnode.go
- Line 209: warning: ineffectual assignment to handled (ineffassign)
- Line 261: warning: ineffectual assignment to err (ineffassign)
- Line 268: warning: ineffectual assignment to err (ineffassign)
-
-
core/p2p/client.go
- Line 122: warning: ineffectual assignment to err (ineffassign)
-
-
core/p2p/discover/membership.go
- Line 127: warning: ineffectual assignment to port (ineffassign)
-
-
core/share/dkg/pedersen/pdkg.go
- Line 205: warning: ineffectual assignment to errc (ineffassign)
-
-
core/group/edwards25519/scalar.go
- Line 339: warning: ineffectual assignment to s23 (ineffassign)
- Line 347: warning: ineffectual assignment to s22 (ineffassign)
- Line 355: warning: ineffectual assignment to s21 (ineffassign)
- Line 363: warning: ineffectual assignment to s20 (ineffassign)
- Line 371: warning: ineffectual assignment to s19 (ineffassign)
- Line 379: warning: ineffectual assignment to s18 (ineffassign)
- Line 422: warning: ineffectual assignment to s17 (ineffassign)
- Line 430: warning: ineffectual assignment to s16 (ineffassign)
- Line 438: warning: ineffectual assignment to s15 (ineffassign)
- Line 446: warning: ineffectual assignment to s14 (ineffassign)
- Line 454: warning: ineffectual assignment to s13 (ineffassign)
- Line 553: warning: ineffectual assignment to s12 (ineffassign)
- Line 762: warning: ineffectual assignment to s23 (ineffassign)
- Line 770: warning: ineffectual assignment to s22 (ineffassign)
- Line 778: warning: ineffectual assignment to s21 (ineffassign)
- Line 786: warning: ineffectual assignment to s20 (ineffassign)
- Line 794: warning: ineffectual assignment to s19 (ineffassign)
- Line 802: warning: ineffectual assignment to s18 (ineffassign)
- Line 845: warning: ineffectual assignment to s17 (ineffassign)
- Line 853: warning: ineffectual assignment to s16 (ineffassign)
- Line 861: warning: ineffectual assignment to s15 (ineffassign)
- Line 869: warning: ineffectual assignment to s14 (ineffassign)
- Line 877: warning: ineffectual assignment to s13 (ineffassign)
- Line 976: warning: ineffectual assignment to s12 (ineffassign)
- Line 1185: warning: ineffectual assignment to s23 (ineffassign)
- Line 1193: warning: ineffectual assignment to s22 (ineffassign)
- Line 1201: warning: ineffectual assignment to s21 (ineffassign)
- Line 1209: warning: ineffectual assignment to s20 (ineffassign)
- Line 1217: warning: ineffectual assignment to s19 (ineffassign)
- Line 1225: warning: ineffectual assignment to s18 (ineffassign)
- Line 1268: warning: ineffectual assignment to s17 (ineffassign)
- Line 1276: warning: ineffectual assignment to s16 (ineffassign)
- Line 1284: warning: ineffectual assignment to s15 (ineffassign)
- Line 1292: warning: ineffectual assignment to s14 (ineffassign)
- Line 1300: warning: ineffectual assignment to s13 (ineffassign)
- Line 1399: warning: ineffectual assignment to s12 (ineffassign)
- Line 1619: warning: ineffectual assignment to s23 (ineffassign)
- Line 1627: warning: ineffectual assignment to s22 (ineffassign)
- Line 1635: warning: ineffectual assignment to s21 (ineffassign)
- Line 1643: warning: ineffectual assignment to s20 (ineffassign)
- Line 1651: warning: ineffectual assignment to s19 (ineffassign)
- Line 1659: warning: ineffectual assignment to s18 (ineffassign)
- Line 1702: warning: ineffectual assignment to s17 (ineffassign)
- Line 1710: warning: ineffectual assignment to s16 (ineffassign)
- Line 1718: warning: ineffectual assignment to s15 (ineffassign)
- Line 1726: warning: ineffectual assignment to s14 (ineffassign)
- Line 1734: warning: ineffectual assignment to s13 (ineffassign)
- Line 1833: warning: ineffectual assignment to s12 (ineffassign)
- Line 1941: warning: ineffectual assignment to s23 (ineffassign)
- Line 1949: warning: ineffectual assignment to s22 (ineffassign)
- Line 1957: warning: ineffectual assignment to s21 (ineffassign)
- Line 1965: warning: ineffectual assignment to s20 (ineffassign)
- Line 1973: warning: ineffectual assignment to s19 (ineffassign)
- Line 1981: warning: ineffectual assignment to s18 (ineffassign)
- Line 2026: warning: ineffectual assignment to s17 (ineffassign)
- Line 2034: warning: ineffectual assignment to s16 (ineffassign)
- Line 2042: warning: ineffectual assignment to s15 (ineffassign)
- Line 2050: warning: ineffectual assignment to s14 (ineffassign)
- Line 2058: warning: ineffectual assignment to s13 (ineffassign)
- Line 2157: warning: ineffectual assignment to s12 (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
core/dosnode/dos_chain_handler.go
- Line 461: warning: "settlment" is a misspelling of "settlement" (misspell)
-
-
core/onchain/errors.go
- Line 20: warning: "Ocurred" is a misspelling of "Occurred" (misspell)