Preparing report...

Report for github.com/Dilshat/sms-sender

A+    Excellent!    Found 11 issues across 20 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint45%

Golint is a linter for Go source code.

    • sms-sender/dao/recipient.go
    • Line 11: warning: exported type RecipientDao should have comment or be unexported (golint)
    • Line 28: warning: exported function NewRecipientDao should have comment or be unexported (golint)
    • sms-sender/service/service.go
    • Line 20: warning: exported type InvalidPayloadErr should have comment or be unexported (golint)
    • Line 28: warning: exported function NewInvalidPayloadError should have comment or be unexported (golint)
    • Line 32: warning: exported type Service should have comment or be unexported (golint)
    • Line 48: warning: exported function NewService should have comment or be unexported (golint)
    • sms-sender/sms/smpp.go
    • Line 21: warning: exported type RateLimiter should have comment or be unexported (golint)
    • Line 26: warning: exported type TransceiverWrapper should have comment or be unexported (golint)
    • Line 35: warning: exported type TransceiverWrapperFactory should have comment or be unexported (golint)
    • Line 80: warning: exported type SmppClient should have comment or be unexported (golint)
    • Line 116: warning: exported function NewClient should have comment or be unexported (golint)
    • sms-sender/service/dto/dto.go
    • Line 3: warning: exported type Id should have comment or be unexported (golint)
    • Line 7: warning: exported type Message should have comment or be unexported (golint)
    • Line 13: warning: exported type MessageStatus should have comment or be unexported (golint)
    • Line 20: warning: exported type RecipientStatus should have comment or be unexported (golint)
    • sms-sender/model/recipient.go
    • Line 6: warning: comment on exported const NEW should be of the form "NEW ..." (golint)
    • Line 8: warning: exported const SUBMIT_OK should have comment (or a comment on this block) or be unexported (golint)
    • Line 11: warning: comment on exported const DELIVRD should be of the form "DELIVRD ..." (golint)
    • Line 22: warning: exported type Recipient should have comment or be unexported (golint)
    • sms-sender/dao/message.go
    • Line 9: warning: exported type MessageDao should have comment or be unexported (golint)
    • Line 20: warning: exported function NewMessageDao should have comment or be unexported (golint)
    • sms-sender/dao/db.go
    • Line 14: warning: exported type Db should have comment or be unexported (golint)
    • Line 31: warning: exported function GetClient should have comment or be unexported (golint)
    • sms-sender/util/util.go
    • Line 11: warning: exported function FileExists should have comment or be unexported (golint)
    • Line 23: warning: exported function GetEnv should have comment or be unexported (golint)
    • Line 31: warning: exported function GetEnvAsInt should have comment or be unexported (golint)
    • Line 40: warning: exported function IsASCII should have comment or be unexported (golint)
    • Line 49: warning: exported function IsBlank should have comment or be unexported (golint)
    • Line 53: warning: exported function IsDecimal should have comment or be unexported (golint)
    • Line 59: warning: exported function DecimalToHexString should have comment or be unexported (golint)
    • Line 64: warning: exported function HexToDecimalString should have comment or be unexported (golint)
    • sms-sender/controller/controllers.go
    • Line 14: warning: comment on exported function GetSendSmsFunc should be of the form "GetSendSmsFunc ..." (golint)
    • Line 46: warning: comment on exported function GetCheckSmsFunc should be of the form "GetCheckSmsFunc ..." (golint)
    • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 83: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • sms-sender/sms/sender.go
    • Line 12: warning: exported const OUT should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported type Response should have comment or be unexported (golint)
    • Line 25: warning: exported type Sender should have comment or be unexported (golint)
    • Line 38: warning: exported function NewSender should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!