Report for github.com/ExchangeUnion/xud-docker
A Great! Found 39 issues across 57 files
gofmt94%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
xud-docker/launcher/service/errors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
xud-docker/launcher/service/bitcoind/service.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
xud-docker/launcher/types/network.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
xud-docker/launcher/core/setup.go
- Line 250: warning: cyclomatic complexity 20 of function (*Launcher).upService() is high (> 15) (gocyclo)
-
-
xud-docker/launcher/core/launcher.go
- Line 322: warning: cyclomatic complexity 20 of function initServices() is high (> 15) (gocyclo)
golint31%
Golint is a linter for Go source code.
-
-
xud-docker/launcher/service/errors.go
- Line 6: warning: exported var ErrForbiddenService should have comment or be unexported (golint)
- Line 10: warning: exported type ErrExec should have comment or be unexported (golint)
-
-
xud-docker/launcher/types/context.go
- Line 3: warning: exported type Context should have comment or be unexported (golint)
-
-
xud-docker/launcher/log/formatter.go
- Line 10: warning: exported type Formatter should have comment or be unexported (golint)
- Line 13: warning: exported method Formatter.Format should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/arby/service.go
- Line 12: warning: exported type Base should have comment or be unexported (golint)
- Line 13: warning: exported type Xud should have comment or be unexported (golint)
- Line 14: warning: exported type XudRpcParams should have comment or be unexported (golint)
- Line 16: warning: exported type Service should have comment or be unexported (golint)
- Line 20: warning: exported function New should have comment or be unexported (golint)
- Line 43: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 86: warning: exported method Service.GetStatus should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/gen.go
- Line 65: warning: exported method Launcher.GenDockerComposeYaml should have comment or be unexported (golint)
- Line 91: warning: exported type ExportedConfig should have comment or be unexported (golint)
- Line 97: warning: exported type ServiceConfig should have comment or be unexported (golint)
- Line 134: warning: exported method Launcher.GenConfigJson should have comment or be unexported (golint)
- Line 161: warning: exported method Launcher.Gen should have comment or be unexported (golint)
-
-
xud-docker/launcher/types/network.go
- Line 3: warning: exported type Network should have comment or be unexported (golint)
- Line 6: warning: exported const Simnet should have comment (or a comment on this block) or be unexported (golint)
-
-
xud-docker/launcher/service/arby/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 28: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/boltz/service.go
- Line 11: warning: exported type Base should have comment or be unexported (golint)
- Line 13: warning: exported type Service should have comment or be unexported (golint)
- Line 17: warning: exported function New should have comment or be unexported (golint)
- Line 32: warning: exported type Info should have comment or be unexported (golint)
- Line 37: warning: exported method Service.GetInfo should have comment or be unexported (golint)
- Line 58: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 79: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 104: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
-
-
xud-docker/launcher/cmd/root.go
- Line 36: warning: exported function Execute should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/base/config.go
- Line 3: warning: exported type Config should have comment or be unexported (golint)
- Line 10: warning: exported method Service.GetBranchImage should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/cleanup.go
- Line 53: warning: exported method Launcher.Create should have comment or be unexported (golint)
- Line 57: warning: exported method Launcher.Start should have comment or be unexported (golint)
- Line 61: warning: exported method Launcher.Restart should have comment or be unexported (golint)
- Line 65: warning: exported method Launcher.Stop should have comment or be unexported (golint)
- Line 97: warning: exported method Launcher.Down should have comment or be unexported (golint)
- Line 185: warning: exported method Launcher.Cleanup should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/setup.go
- Line 26: warning: exported const DefaultWalletPassword should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported method Launcher.Pull should have comment or be unexported (golint)
- Line 41: warning: exported method Launcher.Setup should have comment or be unexported (golint)
- Line 174: warning: exported type ApiError should have comment or be unexported (golint)
- Line 368: warning: exported type Request should have comment or be unexported (golint)
- Line 405: warning: exported type WalletsInfo should have comment or be unexported (golint)
- Line 410: warning: exported type BackupInfo should have comment or be unexported (golint)
- Line 415: warning: exported type Info should have comment or be unexported (golint)
- Line 420: warning: exported method Launcher.GetInfo should have comment or be unexported (golint)
- Line 438: warning: exported method Launcher.BackupTo should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/update.go
- Line 8: warning: exported method Launcher.Update should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/litecoind/service.go
- Line 8: warning: exported type Base should have comment or be unexported (golint)
- Line 10: warning: exported type Service should have comment or be unexported (golint)
- Line 14: warning: exported function New should have comment or be unexported (golint)
- Line 26: warning: exported method Service.Apply should have comment or be unexported (golint)
-
-
xud-docker/launcher/utils/run.go
- Line 14: warning: exported function Run should have comment or be unexported (golint)
- Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
xud-docker/launcher/service/connext/service.go
- Line 14: warning: exported type Base should have comment or be unexported (golint)
- Line 22: warning: exported type Service should have comment or be unexported (golint)
- Line 26: warning: exported function New should have comment or be unexported (golint)
- Line 37: warning: exported method Service.IsHealthy should have comment or be unexported (golint)
- Line 52: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 68: warning: exported method Service.UseVector should have comment or be unexported (golint)
- Line 72: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 144: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
-
-
xud-docker/launcher/cmd/setup.go
- Line 21: warning: should not use basic type string as key in context.WithValue (golint)
-
-
xud-docker/launcher/service/proxy/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 17: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/attach.go
- Line 3: warning: exported method Launcher.Attach should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/webui/service.go
- Line 8: warning: exported type Base should have comment or be unexported (golint)
- Line 10: warning: exported type Service should have comment or be unexported (golint)
- Line 14: warning: exported function New should have comment or be unexported (golint)
- Line 25: warning: exported method Service.Apply should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/boltz/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 15: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/proxy/service.go
- Line 13: warning: exported type Base should have comment or be unexported (golint)
- Line 15: warning: exported type Service should have comment or be unexported (golint)
- Line 20: warning: exported function New should have comment or be unexported (golint)
- Line 57: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 73: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 99: warning: exported type RpcParams should have comment or be unexported (golint)
- Line 105: warning: exported method RpcParams.ToUri should have comment or be unexported (golint)
- Line 109: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/webui/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 15: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/log/root.go
- Line 15: warning: exported function SetOutput should have comment or be unexported (golint)
- Line 19: warning: exported function NewLogger should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/bitcoind/config.go
- Line 9: warning: exported type Mode should have comment or be unexported (golint)
- Line 12: warning: exported const Native should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 20: warning: exported type Config should have comment or be unexported (golint)
- Line 32: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/geth/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 24: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/geth/service.go
- Line 9: warning: exported type Base should have comment or be unexported (golint)
- Line 11: warning: exported type Mode should have comment or be unexported (golint)
- Line 14: warning: exported const Native should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported type RpcParams should have comment or be unexported (golint)
- Line 28: warning: exported method RpcParams.ToUri should have comment or be unexported (golint)
- Line 35: warning: exported type Service should have comment or be unexported (golint)
- Line 42: warning: exported function New should have comment or be unexported (golint)
- Line 53: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 111: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
- Line 115: warning: exported method Service.GetMode should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/lnd/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Mode should have comment or be unexported (golint)
- Line 14: warning: exported const Native should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: exported type Config should have comment or be unexported (golint)
- Line 26: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/types/service.go
- Line 5: warning: exported type Service should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/connext/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 15: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/launcher.go
- Line 34: warning: exported type Launcher should have comment or be unexported (golint)
- Line 148: warning: exported function NewLauncher should have comment or be unexported (golint)
- Line 293: warning: exported method Launcher.AddServiceFlags should have comment or be unexported (golint)
- Line 326: warning: don't use underscores in Go names; var proxy_ should be proxy (golint)
- Line 341: warning: don't use underscores in Go names; var connext_ should be connext (golint)
- Line 346: warning: don't use underscores in Go names; var xud_ should be xud (golint)
- Line 351: warning: don't use underscores in Go names; var arby_ should be arby (golint)
- Line 356: warning: don't use underscores in Go names; var webui_ should be webui (golint)
- Line 382: warning: don't use underscores in Go names; var bitcoind_ should be bitcoind (golint)
- Line 387: warning: don't use underscores in Go names; var litecoind_ should be litecoind (golint)
- Line 392: warning: don't use underscores in Go names; var geth_ should be geth (golint)
- Line 397: warning: don't use underscores in Go names; var boltz_ should be boltz (golint)
- Line 429: warning: don't use underscores in Go names; var bitcoind_ should be bitcoind (golint)
- Line 434: warning: don't use underscores in Go names; var litecoind_ should be litecoind (golint)
- Line 439: warning: don't use underscores in Go names; var geth_ should be geth (golint)
- Line 444: warning: don't use underscores in Go names; var boltz_ should be boltz (golint)
- Line 485: warning: exported method Launcher.Run should have comment or be unexported (golint)
- Line 493: warning: exported method Launcher.GetService should have comment or be unexported (golint)
- Line 500: warning: comment on exported method Launcher.Apply should be of the form "Apply ..." (golint)
- Line 512: warning: exported method Launcher.GetNetwork should have comment or be unexported (golint)
- Line 516: warning: exported method Launcher.GetExternalIp should have comment or be unexported (golint)
- Line 520: warning: exported method Launcher.GetNetworkDir should have comment or be unexported (golint)
- Line 524: warning: exported method Launcher.GetBackupDir should have comment or be unexported (golint)
- Line 528: warning: exported method Launcher.GetDataDir should have comment or be unexported (golint)
- Line 532: warning: exported method Launcher.Close should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/bitcoind/service.go
- Line 10: warning: exported type Base should have comment or be unexported (golint)
- Line 12: warning: exported type Service should have comment or be unexported (golint)
- Line 19: warning: exported type RpcParams should have comment or be unexported (golint)
- Line 29: warning: exported function New should have comment or be unexported (golint)
- Line 46: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 84: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
- Line 88: warning: exported method Service.GetMode should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/lnd/service.go
- Line 17: warning: exported type Base should have comment or be unexported (golint)
- Line 19: warning: exported type Chain should have comment or be unexported (golint)
- Line 22: warning: exported const Bitcoin should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported type Service should have comment or be unexported (golint)
- Line 38: warning: exported function New should have comment or be unexported (golint)
- Line 50: warning: exported type Info should have comment or be unexported (golint)
- Line 55: warning: exported method Service.GetInfo should have comment or be unexported (golint)
- Line 176: warning: exported method Service.UseNeutrino should have comment or be unexported (golint)
- Line 201: warning: exported method Service.GetLndPid should have comment or be unexported (golint)
- Line 214: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 246: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 256: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 359: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
- Line 370: warning: exported method Service.Rescue should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/xud/service.go
- Line 16: warning: exported type Base should have comment or be unexported (golint)
- Line 18: warning: exported type Service should have comment or be unexported (golint)
- Line 23: warning: exported function New should have comment or be unexported (golint)
- Line 35: warning: exported type LndInfo should have comment or be unexported (golint)
- Line 39: warning: exported type ConnextInfo should have comment or be unexported (golint)
- Line 43: warning: exported type Info should have comment or be unexported (golint)
- Line 49: warning: exported method Service.GetInfo should have comment or be unexported (golint)
- Line 83: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 142: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 195: warning: exported type RpcParams should have comment or be unexported (golint)
- Line 202: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/base/service.go
- Line 22: warning: exported type Service should have comment or be unexported (golint)
- Line 41: warning: exported function New should have comment or be unexported (golint)
- Line 65: warning: exported method Service.GetName should have comment or be unexported (golint)
- Line 69: warning: exported method Service.GetStatus should have comment or be unexported (golint)
- Line 77: warning: exported method Service.Start should have comment or be unexported (golint)
- Line 84: warning: exported method Service.Stop should have comment or be unexported (golint)
- Line 91: warning: exported method Service.Restart should have comment or be unexported (golint)
- Line 98: warning: exported method Service.Create should have comment or be unexported (golint)
- Line 103: warning: exported method Service.Up should have comment or be unexported (golint)
- Line 117: warning: exported method Service.GetLogs should have comment or be unexported (golint)
- Line 144: warning: exported method Service.FollowLogs should have comment or be unexported (golint)
- Line 176: warning: exported method Service.Exec should have comment or be unexported (golint)
- Line 205: warning: don't use underscores in Go names; var exec_ should be exec (golint)
- Line 224: warning: exported method Service.Apply should have comment or be unexported (golint)
- Line 236: warning: exported method Service.GetImage should have comment or be unexported (golint)
- Line 240: warning: exported method Service.GetHostname should have comment or be unexported (golint)
- Line 244: warning: exported method Service.GetCommand should have comment or be unexported (golint)
- Line 248: warning: exported method Service.GetEnvironment should have comment or be unexported (golint)
- Line 252: warning: exported method Service.GetPorts should have comment or be unexported (golint)
- Line 256: warning: exported method Service.GetVolumes should have comment or be unexported (golint)
- Line 260: warning: exported method Service.IsDisabled should have comment or be unexported (golint)
- Line 264: warning: exported method Service.GetRpcParams should have comment or be unexported (golint)
- Line 268: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
- Line 280: warning: exported method Service.GetStartedAt should have comment or be unexported (golint)
- Line 288: warning: exported method Service.GetDataDir should have comment or be unexported (golint)
- Line 292: warning: exported method Service.GetMode should have comment or be unexported (golint)
- Line 296: warning: exported method Service.Rescue should have comment or be unexported (golint)
- Line 300: warning: exported method Service.Remove should have comment or be unexported (golint)
- Line 308: warning: exported method Service.RemoveData should have comment or be unexported (golint)
- Line 318: warning: exported method Service.IsRunning should have comment or be unexported (golint)
-
-
xud-docker/launcher/core/status.go
- Line 5: warning: exported method Launcher.Status should have comment or be unexported (golint)
-
-
xud-docker/launcher/build/version.go
- Line 4: warning: exported var Version should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/litecoind/config.go
- Line 8: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 10: warning: exported type Config should have comment or be unexported (golint)
- Line 14: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
-
-
xud-docker/launcher/service/xud/config.go
- Line 9: warning: exported type BaseConfig should have comment or be unexported (golint)
- Line 11: warning: exported type Config should have comment or be unexported (golint)
- Line 17: warning: exported method Service.GetDefaultConfig should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!