Preparing report...

Report for github.com/FedeDP/golight

A    Great!    Found 23 issues across 24 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint4%

Golint is a linter for Go source code.

    • golight/internal/app/golight/dimmer/dimmer.go
    • Line 16: warning: exported function Subscribe should have comment or be unexported (golint)
    • Line 20: warning: exported function UpdateTimer should have comment or be unexported (golint)
    • Line 24: warning: exported function Update should have comment or be unexported (golint)
    • Line 37: warning: exported function Close should have comment or be unexported (golint)
    • golight/pkg/go-clightd/backlight.go
    • Line 7: warning: exported type BacklightSmooth should have comment or be unexported (golint)
    • Line 29: warning: exported type BacklightStruct should have comment or be unexported (golint)
    • Line 34: warning: exported type BacklightApi should have comment or be unexported (golint)
    • Line 54: warning: exported function NewBacklightApi should have comment or be unexported (golint)
    • golight/internal/app/golight/dpms/dpms.go
    • Line 15: warning: exported function Subscribe should have comment or be unexported (golint)
    • Line 19: warning: exported function UpdateTimer should have comment or be unexported (golint)
    • Line 23: warning: exported function Update should have comment or be unexported (golint)
    • Line 35: warning: exported function Close should have comment or be unexported (golint)
    • golight/internal/pkg/idlelib/idler.go
    • Line 9: warning: exported function Subscribe should have comment or be unexported (golint)
    • Line 23: warning: exported function Update should have comment or be unexported (golint)
    • Line 27: warning: exported function Close should have comment or be unexported (golint)
    • golight/pkg/go-clightd/gamma.go
    • Line 7: warning: exported type GammaSmooth should have comment or be unexported (golint)
    • Line 22: warning: exported type GammaApi should have comment or be unexported (golint)
    • Line 31: warning: exported function NewGammaApi should have comment or be unexported (golint)
    • golight/internal/app/golight/state/display.go
    • Line 3: warning: exported type DisplayState should have comment or be unexported (golint)
    • Line 5: warning: exported const DisplayON should have comment (or a comment on this block) or be unexported (golint)
    • Line 10: warning: exported function DisplaySet should have comment or be unexported (golint)
    • Line 11: warning: exported function DisplayClear should have comment or be unexported (golint)
    • golight/internal/app/golight/backlight/backlight.go
    • Line 14: warning: exported var BlFitParams should have comment or be unexported (golint)
    • Line 21: warning: exported function Subscribe should have comment or be unexported (golint)
    • Line 25: warning: exported function Update should have comment or be unexported (golint)
    • Line 30: warning: exported function Set should have comment or be unexported (golint)
    • Line 54: warning: exported function Close should have comment or be unexported (golint)
    • golight/pkg/go-clightd/idle.go
    • Line 21: warning: exported type IdleClientApi should have comment or be unexported (golint)
    • Line 32: warning: exported function NewIdleClientApi should have comment or be unexported (golint)
    • golight/pkg/go-clightd/sensor.go
    • Line 17: warning: exported type SensType should have comment or be unexported (golint)
    • Line 20: warning: exported const SensAny should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported type SensorApi should have comment or be unexported (golint)
    • Line 38: warning: exported function NewSensorApi should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!