Preparing report...

Report for github.com/FourthState/plasma-mvp-sidechain

A+    Excellent!    Found 33 issues across 97 files

Tweet

gofmt88%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint82%

Golint is a linter for Go source code.

    • plasma-mvp-sidechain/plasma/output.go
    • Line 23: warning: exported function NewOutput should have comment or be unexported (golint)
    • Line 34: warning: exported method Output.EncodeRLP should have comment or be unexported (golint)
    • Line 40: warning: exported method Output.DecodeRLP should have comment or be unexported (golint)
    • Line 67: warning: exported method Output.Bytes should have comment or be unexported (golint)
    • plasma-mvp-sidechain/handlers/errors.go
    • Line 29: warning: comment on exported function ErrSignatureVerificationFailure should be of the form "ErrSignatureVerificationFailure ..." (golint)
    • Line 45: warning: comment on exported function ErrInvalidInput should be of the form "ErrInvalidInput ..." (golint)
    • plasma-mvp-sidechain/store/outputs_test.go
    • Line 172: warning: should omit 2nd value from range; this loop is equivalent to `for j := range ...` (golint)
    • Line 182: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
    • Line 189: warning: should omit 2nd value from range; this loop is equivalent to `for j := range ...` (golint)
    • Line 203: warning: should omit 2nd value from range; this loop is equivalent to `for j := range ...` (golint)
    • plasma-mvp-sidechain/store/querier.go
    • Line 16: warning: comment on exported const QuerierRouteName should be of the form "QuerierRouteName ..." (golint)
    • Line 24: warning: comment on exported const QueryBlock should be of the form "QueryBlock ..." (golint)
    • plasma-mvp-sidechain/store/datastore.go
    • Line 10: warning: comment on exported const DataStoreName should be of the form "DataStoreName ..." (golint)
    • Line 14: warning: comment on exported type DataStore should be of the form "DataStore ..." (with optional leading article) (golint)
    • plasma-mvp-sidechain/plasma/position.go
    • Line 11: warning: exported type Position should have comment or be unexported (golint)
    • Line 23: warning: exported function NewPosition should have comment or be unexported (golint)
    • Line 39: warning: exported method Position.Bytes should have comment or be unexported (golint)
    • Line 68: warning: exported method Position.IsDeposit should have comment or be unexported (golint)
    • Line 72: warning: exported method Position.IsFee should have comment or be unexported (golint)
    • Line 76: warning: exported method Position.IsNilPosition should have comment or be unexported (golint)
    • Line 80: warning: exported method Position.Priority should have comment or be unexported (golint)
    • Line 95: warning: exported method Position.ToBigIntArray should have comment or be unexported (golint)
    • Line 110: warning: exported function FromPositionString should have comment or be unexported (golint)
    • Line 163: warning: comment on exported function FromExitKey should be of the form "FromExitKey ..." (golint)
    • Line 167: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign92%

IneffAssign detects ineffectual assignments in Go code.


misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 3)