Preparing report...

Report for github.com/FreifunkBremen/yanic

A+    Excellent!    Found 43 issues across 114 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint64%

Golint is a linter for Go source code.

    • yanic/database/graphite/global.go
    • Line 10: warning: exported method Connection.InsertGlobals should have comment or be unexported (golint)
    • Line 36: warning: exported function GlobalStatsFields should have comment or be unexported (golint)
    • yanic/output/raw/raw.go
    • Line 9: warning: comment on exported type RawNode should be of the form "RawNode ..." (with optional leading article) (golint)
    • Line 20: warning: exported type NodeList should have comment or be unexported (golint)
    • yanic/respond/config.go
    • Line 5: warning: exported type Config should have comment or be unexported (golint)
    • Line 14: warning: exported method Config.SitesDomains should have comment or be unexported (golint)
    • Line 22: warning: exported type SiteConfig should have comment or be unexported (golint)
    • Line 26: warning: exported type InterfaceConfig should have comment or be unexported (golint)
    • Line 34: warning: exported type CustomFieldConfig should have comment or be unexported (golint)
    • yanic/output/nodelist/output.go
    • Line 10: warning: exported type Output should have comment or be unexported (golint)
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 28: warning: exported function Register should have comment or be unexported (golint)
    • Line 41: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/output/raw-jsonl/output.go
    • Line 10: warning: exported type Output should have comment or be unexported (golint)
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 28: warning: exported function Register should have comment or be unexported (golint)
    • Line 41: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/output/meshviewer-ffrgb/struct.go
    • Line 1: warning: don't use MixedCaps in package name; meshviewerFFRGB should be meshviewerffrgb (golint)
    • Line 10: warning: exported type Meshviewer should have comment or be unexported (golint)
    • Line 16: warning: exported type Node should have comment or be unexported (golint)
    • Line 53: warning: comment on exported type Autoupdater should be of the form "Autoupdater ..." (with optional leading article) (golint)
    • Line 65: warning: comment on exported type Link should be of the form "Link ..." (with optional leading article) (golint)
    • Line 76: warning: exported function NewNode should have comment or be unexported (golint)
    • yanic/output/all/output.go
    • Line 13: warning: exported type Output should have comment or be unexported (golint)
    • Line 19: warning: exported function Register should have comment or be unexported (golint)
    • Line 67: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/database/influxdb/database.go
    • Line 15: warning: exported const MeasurementLink should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported type Connection should have comment or be unexported (golint)
    • Line 34: warning: exported type Config should have comment or be unexported (golint)
    • Line 36: warning: exported method Config.Address should have comment or be unexported (golint)
    • Line 39: warning: exported method Config.Database should have comment or be unexported (golint)
    • Line 42: warning: exported method Config.Username should have comment or be unexported (golint)
    • Line 45: warning: exported method Config.Password should have comment or be unexported (golint)
    • Line 48: warning: exported method Config.InsecureSkipVerify should have comment or be unexported (golint)
    • Line 54: warning: exported method Config.Tags should have comment or be unexported (golint)
    • Line 64: warning: exported function Connect should have comment or be unexported (golint)
    • yanic/runtime/nodes.go
    • Line 43: warning: exported method Nodes.AddNode should have comment or be unexported (golint)
    • Line 105: warning: exported method Nodes.GetNodeIDbyAddress should have comment or be unexported (golint)
    • Line 277: warning: comment on exported function SaveJSONL should be of the form "SaveJSONL ..." (golint)
    • yanic/database/respondd/main.go
    • Line 20: warning: exported type Connection should have comment or be unexported (golint)
    • Line 26: warning: exported type Config should have comment or be unexported (golint)
    • Line 28: warning: exported method Config.Type should have comment or be unexported (golint)
    • Line 32: warning: exported method Config.Address should have comment or be unexported (golint)
    • Line 40: warning: exported function Connect should have comment or be unexported (golint)
    • Line 52: warning: exported method Connection.InsertNode should have comment or be unexported (golint)
    • Line 86: warning: exported method Connection.InsertLink should have comment or be unexported (golint)
    • Line 89: warning: exported method Connection.InsertGlobals should have comment or be unexported (golint)
    • Line 92: warning: exported method Connection.PruneNodes should have comment or be unexported (golint)
    • Line 95: warning: exported method Connection.Close should have comment or be unexported (golint)
    • yanic/output/raw/output.go
    • Line 10: warning: exported type Output should have comment or be unexported (golint)
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 28: warning: exported function Register should have comment or be unexported (golint)
    • Line 41: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/database/all/internal.go
    • Line 10: warning: exported var Conn should have comment or be unexported (golint)
    • Line 14: warning: exported function Start should have comment or be unexported (golint)
    • Line 25: warning: exported function Close should have comment or be unexported (golint)
    • yanic/output/geojson/output.go
    • Line 10: warning: exported type Output should have comment or be unexported (golint)
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 28: warning: exported function Register should have comment or be unexported (golint)
    • Line 41: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/runtime/stats.go
    • Line 4: warning: exported const DISABLED_AUTOUPDATER should have comment (or a comment on this block) or be unexported (golint)
    • yanic/respond/respond.go
    • Line 18: warning: comment on exported const MulticastAddressDefault should be of the form "MulticastAddressDefault ..." (golint)
    • Line 21: warning: comment on exported const PortDefault should be of the form "PortDefault ..." (golint)
    • Line 24: warning: comment on exported const MaxDataGramSize should be of the form "MaxDataGramSize ..." (golint)
    • Line 34: warning: exported function NewRespone should have comment or be unexported (golint)
    • yanic/database/graphite/node.go
    • Line 10: warning: comment on exported method Connection.PruneNodes should be of the form "PruneNodes ..." (golint)
    • Line 27: warning: don't use underscores in Go names; var node_prefix should be nodePrefix (golint)
    • yanic/output/meshviewer/output.go
    • Line 12: warning: exported type Output should have comment or be unexported (golint)
    • Line 18: warning: exported type Config should have comment or be unexported (golint)
    • Line 20: warning: exported method Config.Version should have comment or be unexported (golint)
    • Line 26: warning: exported method Config.NodesPath should have comment or be unexported (golint)
    • Line 32: warning: exported method Config.GraphPath should have comment or be unexported (golint)
    • Line 47: warning: exported function Register should have comment or be unexported (golint)
    • Line 62: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/output/meshviewer-ffrgb/output.go
    • Line 1: warning: don't use MixedCaps in package name; meshviewerFFRGB should be meshviewerffrgb (golint)
    • Line 10: warning: exported type Output should have comment or be unexported (golint)
    • Line 15: warning: exported type Config should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 28: warning: exported function Register should have comment or be unexported (golint)
    • Line 41: warning: exported method Output.Save should have comment or be unexported (golint)
    • yanic/database/graphite/database.go
    • Line 13: warning: exported const MeasurementNode should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported type Connection should have comment or be unexported (golint)
    • Line 27: warning: exported type Config should have comment or be unexported (golint)
    • Line 29: warning: exported method Config.Address should have comment or be unexported (golint)
    • Line 33: warning: exported method Config.Prefix should have comment or be unexported (golint)
    • Line 37: warning: exported function Connect should have comment or be unexported (golint)
    • Line 60: warning: exported method Connection.Close should have comment or be unexported (golint)
    • yanic/database/all/connection.go
    • Line 13: warning: exported type Connection should have comment or be unexported (golint)
    • Line 18: warning: exported function Connect should have comment or be unexported (golint)
    • Line 52: warning: exported method Connection.InsertNode should have comment or be unexported (golint)
    • Line 58: warning: exported method Connection.InsertLink should have comment or be unexported (golint)
    • Line 64: warning: exported method Connection.InsertGlobals should have comment or be unexported (golint)
    • Line 70: warning: exported method Connection.PruneNodes should have comment or be unexported (golint)
    • Line 76: warning: exported method Connection.Close should have comment or be unexported (golint)
    • yanic/output/nodelist/nodelist.go
    • Line 15: warning: exported type Node should have comment or be unexported (golint)
    • Line 26: warning: exported type Position should have comment or be unexported (golint)
    • Line 31: warning: exported function NewNode should have comment or be unexported (golint)
    • yanic/database/logging/file.go
    • Line 17: warning: exported type Connection should have comment or be unexported (golint)
    • Line 23: warning: exported type Config should have comment or be unexported (golint)
    • Line 25: warning: exported method Config.Path should have comment or be unexported (golint)
    • Line 33: warning: exported function Connect should have comment or be unexported (golint)
    • Line 44: warning: exported method Connection.InsertNode should have comment or be unexported (golint)
    • Line 48: warning: exported method Connection.InsertLink should have comment or be unexported (golint)
    • Line 52: warning: exported method Connection.InsertGlobals should have comment or be unexported (golint)
    • Line 56: warning: exported method Connection.PruneNodes should have comment or be unexported (golint)
    • Line 60: warning: exported method Connection.Close should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!