go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• pkg/apis/sparkoperator.k8s.io/v1beta1/zz_generated.deepcopy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/controller/sparkapplication/controller.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• hack/api-docs/api-docs-template/placeholder.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/apis/sparkoperator.k8s.io/v1beta2/defaults_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pkg/apis/sparkoperator.k8s.io/v1beta2/zz_generated.deepcopy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pkg/apis/sparkoperator.k8s.io/v1beta1/zz_generated.deepcopy.go
  • Line 667: warning: cyclomatic complexity 30 of function (*SparkPodSpec).DeepCopyInto() is high (> 15) (gocyclo)
  • Line 517: warning: cyclomatic complexity 24 of function (*SparkApplicationSpec).DeepCopyInto() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/sparkui_test.go
  • Line 325: warning: cyclomatic complexity 27 of function TestCreateSparkUIIngress() is high (> 15) (gocyclo)

• pkg/webhook/patch_test.go
  • Line 1190: warning: cyclomatic complexity 18 of function TestPatchSparkPod_GPU() is high (> 15) (gocyclo)

• pkg/webhook/webhook.go
  • Line 246: warning: cyclomatic complexity 16 of function (*WebHook).serve() is high (> 15) (gocyclo)

• pkg/apis/sparkoperator.k8s.io/v1beta2/zz_generated.deepcopy.go
  • Line 810: warning: cyclomatic complexity 42 of function (*SparkPodSpec).DeepCopyInto() is high (> 15) (gocyclo)
  • Line 640: warning: cyclomatic complexity 28 of function (*SparkApplicationSpec).DeepCopyInto() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/sparkapp_metrics.go
  • Line 189: warning: cyclomatic complexity 32 of function (*sparkAppMetrics).exportMetrics() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/monitoring_config_test.go
  • Line 31: warning: cyclomatic complexity 29 of function TestConfigPrometheusMonitoring() is high (> 15) (gocyclo)

• main.go
  • Line 81: warning: cyclomatic complexity 28 of function main() is high (> 15) (gocyclo)

• test/e2e/framework/framework.go
  • Line 103: warning: cyclomatic complexity 26 of function (*Framework).setupOperator() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/submission.go
  • Line 87: warning: cyclomatic complexity 23 of function buildSubmissionCommandArgs() is high (> 15) (gocyclo)
  • Line 249: warning: cyclomatic complexity 16 of function addDriverConfOptions() is high (> 15) (gocyclo)
  • Line 335: warning: cyclomatic complexity 16 of function addExecutorConfOptions() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/monitoring_config.go
  • Line 42: warning: cyclomatic complexity 16 of function configPrometheusMonitoring() is high (> 15) (gocyclo)

• pkg/controller/sparkapplication/controller.go
  • Line 521: warning: cyclomatic complexity 35 of function (*Controller).syncSparkApplication() is high (> 15) (gocyclo)
  • Line 367: warning: cyclomatic complexity 17 of function (*Controller).getAndUpdateExecutorState() is high (> 15) (gocyclo)

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• pkg/batchscheduler/volcano/volcano_scheduler.go
  • Line 151: warning: ineffectual assignment to err (ineffassign)
  • Line 155: warning: ineffectual assignment to err (ineffassign)
  • Line 151: warning: ineffectual assignment to err (ineffassign)
  • Line 155: warning: ineffectual assignment to err (ineffassign)

• pkg/controller/sparkapplication/controller_test.go
  • Line 278: warning: ineffectual assignment to err (ineffassign)
  • Line 279: warning: ineffectual assignment to err (ineffassign)
  • Line 299: warning: ineffectual assignment to err (ineffassign)
  • Line 318: warning: ineffectual assignment to err (ineffassign)
  • Line 1480: warning: ineffectual assignment to err (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• pkg/controller/sparkapplication/controller.go
  • Line 837: warning: "nto" is a misspelling of "not" (misspell)