Report for github.com/IBM/ubiquity
B Not bad! Found 76 issues across 96 files
gofmt63%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
ubiquity/utils/utils.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/connectors/rest_v2.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/database/connection_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/database/suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/clients.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/scbe/resources.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/remote_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/datamodel.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/datamodel_wrapper.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/spectrumscale.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/spectrumscale_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/errors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/clients_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/utils/logs/go_logging_logger.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/utils/logger_utils.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/spectrumscale.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/block_device_utils/errors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/web_server/storage_api_handler.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/database/connection.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/database/init.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/block_device_mounter_utils/errors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/connectors/resources.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/block_device_utils/multipath_utils.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/fakes/fake_spectrum_data_model_wrapper.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/database/migrate.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/utils/logs/global_logger_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/local_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/utils/executor.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/block_device_utils/fs.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/scbe/scbe_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/remote/mounter/errors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/datamodel_wrapper_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/spectrumscale_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/connectors/connectors.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
ubiquity/local/spectrumscale/connectors/rest_v2_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint36%
Golint is a linter for Go source code.
-
-
ubiquity/database/volume.go
- Line 25: warning: exported const DBVolumeNameSuffix should have comment or be unexported (golint)
- Line 27: warning: exported var VolumeNameSuffix should have comment or be unexported (golint)
- Line 29: warning: exported function IsDatabaseVolume should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/mounter_factory.go
- Line 10: warning: comment on exported type MounterFactory should be of the form "MounterFactory ..." (with optional leading article) (golint)
- Line 19: warning: exported function NewMounterFactory should have comment or be unexported (golint)
-
-
ubiquity/utils/logs/go_logging_logger.go
- Line 37: warning: exported type LoggerParams should have comment or be unexported (golint)
- Line 50: warning: don't use underscores in Go names; var format_string should be formatString (golint)
- Line 65: warning: exported function GetGoID should have comment or be unexported (golint)
- Line 74: warning: exported var GoIdToRequestIdMap should have comment or be unexported (golint)
- Line 77: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 83: warning: don't use underscores in Go names; var new_context should be newContext (golint)
- Line 93: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 98: warning: exported function GetDeleteFromMapFunc should have comment or be unexported (golint)
- Line 103: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 108: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 113: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 118: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 124: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 129: warning: don't use underscores in Go names; var goid_context_string should be goidContextString (golint)
- Line 130: warning: don't use underscores in Go names; var log_string_enter should be logStringEnter (golint)
- Line 131: warning: don't use underscores in Go names; var log_string_exit should be logStringExit (golint)
- Line 160: warning: exported function GetNewRequestContext should have comment or be unexported (golint)
- Line 161: warning: don't use underscores in Go names; var request_uuid should be requestUUID (golint)
-
-
ubiquity/local/scbe/simple_rest_client.go
- Line 44: warning: don't use underscores in Go names; interface method parameter resource_url should be resourceURL (golint)
- Line 47: warning: don't use underscores in Go names; interface method parameter resource_url should be resourceURL (golint)
- Line 50: warning: don't use underscores in Go names; interface method parameter resource_url should be resourceURL (golint)
- Line 54: warning: exported const HTTP_SUCCEED should have comment (or a comment on this block) or be unexported (golint)
- Line 73: warning: exported function NewSimpleRestClient should have comment or be unexported (golint)
- Line 113: warning: don't use underscores in Go names; method parameter resource_url should be resourceURL (golint)
- Line 117: warning: don't use underscores in Go names; method parameter resource_url should be resourceURL (golint)
- Line 192: warning: don't use underscores in Go names; method parameter resource_url should be resourceURL (golint)
- Line 201: warning: don't use underscores in Go names; method parameter resource_url should be resourceURL (golint)
- Line 210: warning: don't use underscores in Go names; method parameter resource_url should be resourceURL (golint)
-
-
ubiquity/utils/heartbeat.go
- Line 28: warning: comment on exported type Heartbeat should be of the form "Heartbeat ..." (with optional leading article) (golint)
- Line 40: warning: exported function NewHeartbeat should have comment or be unexported (golint)
- Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/fakes/fake_heartbeat.go
- Line 17: warning: package comment should be of the form "Package fakes ..." (golint)
- Line 27: warning: exported type FakeHeartbeat should have comment or be unexported (golint)
- Line 72: warning: exported method FakeHeartbeat.Exists should have comment or be unexported (golint)
- Line 87: warning: exported method FakeHeartbeat.ExistsCallCount should have comment or be unexported (golint)
- Line 93: warning: exported method FakeHeartbeat.ExistsReturns should have comment or be unexported (golint)
- Line 101: warning: exported method FakeHeartbeat.ExistsReturnsOnCall should have comment or be unexported (golint)
- Line 115: warning: exported method FakeHeartbeat.Create should have comment or be unexported (golint)
- Line 130: warning: exported method FakeHeartbeat.CreateCallCount should have comment or be unexported (golint)
- Line 136: warning: exported method FakeHeartbeat.CreateReturns should have comment or be unexported (golint)
- Line 143: warning: exported method FakeHeartbeat.CreateReturnsOnCall should have comment or be unexported (golint)
- Line 155: warning: exported method FakeHeartbeat.Update should have comment or be unexported (golint)
- Line 170: warning: exported method FakeHeartbeat.UpdateCallCount should have comment or be unexported (golint)
- Line 176: warning: exported method FakeHeartbeat.UpdateReturns should have comment or be unexported (golint)
- Line 183: warning: exported method FakeHeartbeat.UpdateReturnsOnCall should have comment or be unexported (golint)
- Line 195: warning: exported method FakeHeartbeat.GetLastUpdateTimestamp should have comment or be unexported (golint)
- Line 210: warning: exported method FakeHeartbeat.GetLastUpdateTimestampCallCount should have comment or be unexported (golint)
- Line 216: warning: exported method FakeHeartbeat.GetLastUpdateTimestampReturns should have comment or be unexported (golint)
- Line 224: warning: exported method FakeHeartbeat.GetLastUpdateTimestampReturnsOnCall should have comment or be unexported (golint)
- Line 238: warning: exported method FakeHeartbeat.Invocations should have comment or be unexported (golint)
-
-
ubiquity/database/connection.go
- Line 21: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 36: warning: exported type ConnectionFactory should have comment or be unexported (golint)
- Line 66: warning: exported type Connection should have comment or be unexported (golint)
- Line 72: warning: exported function NewConnection should have comment or be unexported (golint)
- Line 76: warning: exported method Connection.Open should have comment or be unexported (golint)
- Line 99: warning: exported method Connection.Close should have comment or be unexported (golint)
- Line 118: warning: exported method Connection.GetDb should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/initiator/linuxscsi.go
- Line 14: warning: exported const FlushTimeout should have comment or be unexported (golint)
- Line 15: warning: exported const FlushRetries should have comment or be unexported (golint)
- Line 17: warning: exported var SYS_BLOCK_PATH should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/errors.go
- Line 23: warning: exported type NoMounterForVolumeError should have comment or be unexported (golint)
- Line 31: warning: exported type DirecotryIsNotEmptyError should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/initiator/linuxiscsi.go
- Line 13: warning: exported function NewLinuxISCSI should have comment or be unexported (golint)
- Line 17: warning: exported function NewLinuxISCSIWithExecutor should have comment or be unexported (golint)
-
-
ubiquity/local/spectrumscale/datamodel.go
- Line 27: warning: comment on exported type SpectrumDataModel should be of the form "SpectrumDataModel ..." (with optional leading article) (golint)
- Line 45: warning: exported type VolumeType should have comment or be unexported (golint)
- Line 48: warning: exported const Fileset should have comment (or a comment on this block) or be unexported (golint)
- Line 54: warning: exported const UserSpecifiedUID should have comment (or a comment on this block) or be unexported (golint)
- Line 58: warning: exported type SpectrumScaleVolume should have comment or be unexported (golint)
- Line 73: warning: exported function NewSpectrumDataModel should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/scbe.go
- Line 43: warning: exported const OptionNameForServiceName should have comment (or a comment on this block) or be unexported (golint)
- Line 55: warning: exported var SupportedFSTypes should have comment or be unexported (golint)
- Line 58: warning: exported function NewScbeLocalClient should have comment or be unexported (golint)
- Line 67: warning: exported function NewScbeLocalClientWithNewScbeRestClientAndDataModel should have comment or be unexported (golint)
- Line 323: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/utils/utils.go
- Line 31: warning: exported function ReadAndUnmarshal should have comment or be unexported (golint)
- Line 47: warning: exported function MarshalAndRecord should have comment or be unexported (golint)
- Line 59: warning: exported function ReadFile should have comment or be unexported (golint)
- Line 75: warning: exported function WriteFile should have comment or be unexported (golint)
- Line 84: warning: exported function GetPath should have comment or be unexported (golint)
- Line 101: warning: exported function Exists should have comment or be unexported (golint)
- Line 108: warning: exported function MkDir should have comment or be unexported (golint)
- Line 120: warning: exported function PrintResponse should have comment or be unexported (golint)
- Line 129: warning: exported function SetupConfigDirectory should have comment or be unexported (golint)
- Line 143: warning: exported function StringInSlice should have comment or be unexported (golint)
- Line 152: warning: exported function ConvertToBytes should have comment or be unexported (golint)
- Line 210: warning: exported function LoadConfig should have comment or be unexported (golint)
- Line 270: warning: exported function GetEnv should have comment or be unexported (golint)
-
-
ubiquity/database/init.go
- Line 28: warning: exported const KeyPsqlHost should have comment (or a comment on this block) or be unexported (golint)
- Line 39: warning: exported function GetPsqlConnectionParams should have comment or be unexported (golint)
- Line 73: warning: exported function GetPsqlSslParams should have comment or be unexported (golint)
- Line 90: warning: exported function GetPsqlWithPassowrdStarred should have comment or be unexported (golint)
- Line 103: warning: exported function InitPostgres should have comment or be unexported (golint)
- Line 109: warning: exported function InitTestError should have comment or be unexported (golint)
- Line 114: warning: exported function InitTestCorrect should have comment or be unexported (golint)
- Line 119: warning: exported function Initialize should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/resources.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 23: warning: exported type Protocol should have comment or be unexported (golint)
- Line 26: warning: exported const SCSI should have comment (or a comment on this block) or be unexported (golint)
- Line 30: warning: comment on exported type BlockDeviceUtils should be of the form "BlockDeviceUtils ..." (with optional leading article) (golint)
-
-
ubiquity/utils/error.go
- Line 23: warning: exported type NoENVKeyError should have comment or be unexported (golint)
- Line 31: warning: exported type CommandExecuteError should have comment or be unexported (golint)
- Line 40: warning: exported type CommandNotFoundError should have comment or be unexported (golint)
-
-
ubiquity/utils/mpath.go
- Line 13: warning: exported const MultipathTimeout should have comment or be unexported (golint)
- Line 14: warning: exported const WarningNoTargetPortGroup should have comment or be unexported (golint)
- Line 111: warning: exported function ExcludeNoTargetPortGroupMessagesFromMultipathOutput should have comment or be unexported (golint)
-
-
ubiquity/local/clients.go
- Line 27: warning: exported var NewScbeLocalClient should have comment or be unexported (golint)
- Line 28: warning: exported var NewSpectrumLocalClient should have comment or be unexported (golint)
- Line 30: warning: exported function GetLocalClients should have comment or be unexported (golint)
- Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/model/datamodel.go
- Line 26: warning: exported function GetVolume should have comment or be unexported (golint)
- Line 31: warning: exported function GetBackendForVolume should have comment or be unexported (golint)
- Line 39: warning: exported function VolumeExists should have comment or be unexported (golint)
- Line 47: warning: exported function DeleteVolume should have comment or be unexported (golint)
- Line 51: warning: exported function UpdateVolumeMountpoint should have comment or be unexported (golint)
-
-
ubiquity/database/migrate.go
- Line 27: warning: exported function RegisterMigration should have comment or be unexported (golint)
- Line 32: warning: exported function UnregisterAllMigrations should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/initiator/resources.go
- Line 5: warning: comment on exported type BaseInitiator should be of the form "BaseInitiator ..." (with optional leading article) (golint)
- Line 11: warning: comment on exported type Initiator should be of the form "Initiator ..." (with optional leading article) (golint)
- Line 18: warning: comment on exported type Connector should be of the form "Connector ..." (with optional leading article) (golint)
-
-
ubiquity/remote/mounter/block_device_utils/rescan.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 32: warning: exported var FcHostDir should have comment or be unexported (golint)
- Line 33: warning: exported var ScsiHostDir should have comment or be unexported (golint)
- Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/utils/http_utils.go
- Line 33: warning: exported function ExtractErrorResponse should have comment or be unexported (golint)
- Line 42: warning: exported function UnmarshalResponse should have comment or be unexported (golint)
- Line 56: warning: exported function FormatURL should have comment or be unexported (golint)
- Line 68: warning: exported function HttpExecuteUserAuth should have comment or be unexported (golint)
- Line 94: warning: exported function HttpExecute should have comment or be unexported (golint)
- Line 94: warning: don't use underscores in Go names; func parameter request_context should be requestContext (golint)
- Line 113: warning: exported function WriteResponse should have comment or be unexported (golint)
- Line 124: warning: exported function Unmarshal should have comment or be unexported (golint)
- Line 138: warning: exported function UnmarshalDataFromRequest should have comment or be unexported (golint)
- Line 152: warning: exported function ExtractVarsFromRequest should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_mounter_utils/errors.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 21: warning: exported type DeviceAlreadyMountedToWrongMountpoint should have comment or be unexported (golint)
- Line 30: warning: exported type DirPathAlreadyMountedToWrongDevice should have comment or be unexported (golint)
-
-
ubiquity/utils/locker.go
- Line 26: warning: comment on exported type Locker should be of the form "Locker ..." (with optional leading article) (golint)
- Line 34: warning: exported function NewLocker should have comment or be unexported (golint)
- Line 39: warning: exported const STALE_LOCK_TIMEOUT should have comment (or a comment on this block) or be unexported (golint)
-
-
ubiquity/fakes/fake_locker.go
- Line 17: warning: package comment should be of the form "Package fakes ..." (golint)
- Line 26: warning: exported type FakeLocker should have comment or be unexported (golint)
- Line 51: warning: exported method FakeLocker.WriteLock should have comment or be unexported (golint)
- Line 63: warning: exported method FakeLocker.WriteLockCallCount should have comment or be unexported (golint)
- Line 69: warning: exported method FakeLocker.WriteLockArgsForCall should have comment or be unexported (golint)
- Line 75: warning: exported method FakeLocker.WriteUnlock should have comment or be unexported (golint)
- Line 87: warning: exported method FakeLocker.WriteUnlockCallCount should have comment or be unexported (golint)
- Line 93: warning: exported method FakeLocker.WriteUnlockArgsForCall should have comment or be unexported (golint)
- Line 99: warning: exported method FakeLocker.ReadLock should have comment or be unexported (golint)
- Line 111: warning: exported method FakeLocker.ReadLockCallCount should have comment or be unexported (golint)
- Line 117: warning: exported method FakeLocker.ReadLockArgsForCall should have comment or be unexported (golint)
- Line 123: warning: exported method FakeLocker.ReadUnlock should have comment or be unexported (golint)
- Line 135: warning: exported method FakeLocker.ReadUnlockCallCount should have comment or be unexported (golint)
- Line 141: warning: exported method FakeLocker.ReadUnlockArgsForCall should have comment or be unexported (golint)
- Line 147: warning: exported method FakeLocker.Invocations should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_mounter_utils/block_device_mounter_utils.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 31: warning: exported const WarningMessageIdempotentDeviceAlreadyMounted should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported function NewBlockDeviceMounterUtilsWithBlockDeviceUtils should have comment or be unexported (golint)
- Line 45: warning: exported function NewBlockDeviceMounterUtils should have comment or be unexported (golint)
- Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/remote/mounter/block_device_mounter_utils/resources.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 21: warning: comment on exported type BlockDeviceMounterUtils should be of the form "BlockDeviceMounterUtils ..." (with optional leading article) (golint)
-
-
ubiquity/local/spectrumscale/datamodel_wrapper.go
- Line 24: warning: exported type SpectrumDataModelWrapper should have comment or be unexported (golint)
- Line 41: warning: exported function NewSpectrumDataModelWrapper should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/datamodel.go
- Line 27: warning: comment on exported type ScbeDataModel should be of the form "ScbeDataModel ..." (with optional leading article) (golint)
- Line 41: warning: exported type ScbeVolume should have comment or be unexported (golint)
- Line 49: warning: exported function NewScbeDataModel should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/datamodel_wrapper.go
- Line 25: warning: comment on exported type ScbeDataModelWrapper should be of the form "ScbeDataModelWrapper ..." (with optional leading article) (golint)
- Line 39: warning: exported function NewScbeDataModelWrapper should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/resources.go
- Line 21: warning: exported type LoginResponse should have comment or be unexported (golint)
- Line 26: warning: exported const ScName should have comment (or a comment on this block) or be unexported (golint)
- Line 29: warning: exported type ScbeStorageService should have comment or be unexported (golint)
- Line 78: warning: exported type ScbeResponseVolume should have comment or be unexported (golint)
- Line 85: warning: don't use underscores in Go names; struct field MaxExtendable_size should be MaxExtendableSize (golint)
- Line 105: warning: don't use underscores in Go names; struct field Snapshot_time should be SnapshotTime (golint)
- Line 178: warning: exported type ScbeCreateVolumePostParams should have comment or be unexported (golint)
- Line 185: warning: exported type ScbeMapVolumePostParams should have comment or be unexported (golint)
- Line 190: warning: comment on exported type ScbeUnMapVolumePostParams should be of the form "ScbeUnMapVolumePostParams ..." (with optional leading article) (golint)
- Line 196: warning: exported type ScbeResponseMapping should have comment or be unexported (golint)
- Line 203: warning: exported type ScbeResponseMappings should have comment or be unexported (golint)
- Line 211: warning: exported type ScbeVolumeInfo should have comment or be unexported (golint)
- Line 223: warning: exported type ScbeResponseHost should have comment or be unexported (golint)
- Line 233: warning: exported type ScbeVolumeMapInfo should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/mpath.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 32: warning: exported const MultipathTimeout should have comment or be unexported (golint)
- Line 33: warning: exported const DiscoverTimeout should have comment or be unexported (golint)
- Line 34: warning: exported const CleanupTimeout should have comment or be unexported (golint)
- Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 271: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/local/spectrumscale/connectors/resources.go
- Line 19: warning: exported type GetClusterResponse should have comment or be unexported (golint)
- Line 23: warning: exported type Cluster should have comment or be unexported (golint)
- Line 31: warning: exported type CesSummary should have comment or be unexported (golint)
- Line 37: warning: exported type ClusterSummary should have comment or be unexported (golint)
- Line 48: warning: exported type CnfsSummary should have comment or be unexported (golint)
- Line 57: warning: exported type ClusterNode should have comment or be unexported (golint)
- Line 70: warning: exported type CESNode should have comment or be unexported (golint)
- Line 75: warning: exported type CNFSNode should have comment or be unexported (golint)
- Line 81: warning: exported type Status should have comment or be unexported (golint)
- Line 86: warning: exported type Job should have comment or be unexported (golint)
- Line 95: warning: exported type Respresult should have comment or be unexported (golint)
- Line 103: warning: exported type Resprequest should have comment or be unexported (golint)
- Line 109: warning: exported type GetFilesystemResponse should have comment or be unexported (golint)
- Line 114: warning: exported type FileSystem should have comment or be unexported (golint)
- Line 161: warning: exported type Pool should have comment or be unexported (golint)
- Line 166: warning: exported type GetFilesetResponse should have comment or be unexported (golint)
- Line 171: warning: exported type Fileset should have comment or be unexported (golint)
- Line 178: warning: exported type AFM should have comment or be unexported (golint)
- Line 198: warning: exported type FilesetConfig should have comment or be unexported (golint)
- Line 211: warning: exported type FilesetState should have comment or be unexported (golint)
- Line 226: warning: exported type CreateFilesetResquest should have comment or be unexported (golint)
- Line 230: warning: exported type GenericResponse should have comment or be unexported (golint)
- Line 240: warning: exported type GetQuotaResponse should have comment or be unexported (golint)
- Line 245: warning: exported type SetQuotaRequest should have comment or be unexported (golint)
- Line 259: warning: exported type Quota should have comment or be unexported (golint)
- Line 279: warning: exported type GetNodesResponse should have comment or be unexported (golint)
- Line 283: warning: exported type Node should have comment or be unexported (golint)
- Line 306: warning: don't use underscores in Go names; type GetFilesystemResponse_v2 should be GetFilesystemResponseV2 (golint)
- Line 306: warning: exported type GetFilesystemResponse_v2 should have comment or be unexported (golint)
- Line 312: warning: exported type OwnerInfo should have comment or be unexported (golint)
- Line 319: warning: don't use underscores in Go names; type OwnerResp_v2 should be OwnerRespV2 (golint)
- Line 319: warning: exported type OwnerResp_v2 should have comment or be unexported (golint)
- Line 324: warning: exported type BlockInfo should have comment or be unexported (golint)
- Line 336: warning: exported type MountInfo should have comment or be unexported (golint)
- Line 346: warning: exported type QuotaInfo should have comment or be unexported (golint)
- Line 354: warning: exported type SettingInfo should have comment or be unexported (golint)
- Line 371: warning: exported type ReplicationInfo should have comment or be unexported (golint)
- Line 380: warning: don't use underscores in Go names; type FileSystem_v2 should be FileSystemV2 (golint)
- Line 380: warning: exported type FileSystem_v2 should have comment or be unexported (golint)
- Line 394: warning: exported type Pages should have comment or be unexported (golint)
- Line 398: warning: don't use underscores in Go names; type GetNodesResponse_v2 should be GetNodesResponseV2 (golint)
- Line 398: warning: exported type GetNodesResponse_v2 should have comment or be unexported (golint)
- Line 404: warning: exported type NodeConfig should have comment or be unexported (golint)
- Line 410: warning: exported type NodeStatus should have comment or be unexported (golint)
- Line 417: warning: exported type Network should have comment or be unexported (golint)
- Line 424: warning: exported type NodeRoles should have comment or be unexported (golint)
- Line 437: warning: don't use underscores in Go names; type Node_v2 should be NodeV2 (golint)
- Line 437: warning: exported type Node_v2 should have comment or be unexported (golint)
- Line 448: warning: don't use underscores in Go names; type Fileset_v2 should be FilesetV2 (golint)
- Line 448: warning: exported type Fileset_v2 should have comment or be unexported (golint)
- Line 453: warning: don't use underscores in Go names; type GetFilesetResponse_v2 should be GetFilesetResponseV2 (golint)
- Line 453: warning: exported type GetFilesetResponse_v2 should have comment or be unexported (golint)
- Line 459: warning: don't use underscores in Go names; type FilesetConfig_v2 should be FilesetConfigV2 (golint)
- Line 459: warning: exported type FilesetConfig_v2 should have comment or be unexported (golint)
- Line 479: warning: don't use underscores in Go names; type GetQuotaResponse_v2 should be GetQuotaResponseV2 (golint)
- Line 479: warning: exported type GetQuotaResponse_v2 should have comment or be unexported (golint)
- Line 485: warning: don't use underscores in Go names; type Quota_v2 should be QuotaV2 (golint)
- Line 485: warning: exported type Quota_v2 should have comment or be unexported (golint)
- Line 504: warning: don't use underscores in Go names; type SetQuotaRequest_v2 should be SetQuotaRequestV2 (golint)
- Line 504: warning: exported type SetQuotaRequest_v2 should have comment or be unexported (golint)
- Line 516: warning: exported type LinkFilesetRequest should have comment or be unexported (golint)
- Line 520: warning: exported type UnlinkFilesetRequest should have comment or be unexported (golint)
- Line 524: warning: exported type CreateFilesetRequest should have comment or be unexported (golint)
- Line 555: warning: exported const UserSpecifiedUID should have comment (or a comment on this block) or be unexported (golint)
-
-
ubiquity/remote/client.go
- Line 17: warning: package comment should be of the form "Package remote ..." (golint)
- Line 17: warning: package comment should not have leading space (golint)
-
-
ubiquity/local/scbe/scbe_rest_client.go
- Line 28: warning: comment on exported type ScbeRestClient should be of the form "ScbeRestClient ..." (with optional leading article) (golint)
- Line 47: warning: exported const DefaultScbePort should have comment (or a comment on this block) or be unexported (golint)
- Line 60: warning: exported function NewScbeRestClient should have comment or be unexported (golint)
- Line 64: warning: comment on exported function NewScbeRestClientWithSimpleRestClient should be of the form "NewScbeRestClientWithSimpleRestClient ..." (golint)
-
-
ubiquity/remote/mounter/initiator/connectors/iscsi.go
- Line 14: warning: exported function NewISCSIConnector should have comment or be unexported (golint)
- Line 18: warning: exported function NewISCSIConnectorWithExecutor should have comment or be unexported (golint)
- Line 23: warning: exported function NewISCSIConnectorWithAllFields should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/spectrumscale.go
- Line 30: warning: exported function NewSpectrumScaleMounter should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/block_device_utils.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 20: warning: exported function NewBlockDeviceUtils should have comment or be unexported (golint)
- Line 24: warning: exported function NewBlockDeviceUtilsWithExecutor should have comment or be unexported (golint)
- Line 28: warning: exported function NewBlockDeviceUtilsWithExecutorAndConnector should have comment or be unexported (golint)
-
-
ubiquity/local/spectrumscale/errors.go
- Line 23: warning: exported type SpectrumScaleConfigError should have comment or be unexported (golint)
- Line 31: warning: exported const SpectrumScaleGetClusterIdErrorStr should have comment or be unexported (golint)
- Line 33: warning: exported type SpectrumScaleGetClusterIdError should have comment or be unexported (golint)
- Line 41: warning: exported type SpectrumScaleFileSystemNotPresent should have comment or be unexported (golint)
- Line 49: warning: exported type SpectrumScaleFileSystemNotMounted should have comment or be unexported (golint)
- Line 57: warning: exported type SpectrumScaleQuotaNotEnabledError should have comment or be unexported (golint)
- Line 65: warning: exported type SpectrumScaleFileSystemMountError should have comment or be unexported (golint)
- Line 73: warning: exported type SpectrumScaleFileSetLinkError should have comment or be unexported (golint)
- Line 82: warning: exported type SpectrumScaleFileSetNotLinkError should have comment or be unexported (golint)
-
-
ubiquity/local/spectrumscale/connectors/connectors.go
- Line 24: warning: comment on exported type SpectrumScaleConnector should be of the form "SpectrumScaleConnector ..." (with optional leading article) (golint)
- Line 47: warning: exported const UserSpecifiedFilesetType should have comment (or a comment on this block) or be unexported (golint)
- Line 53: warning: exported function GetSpectrumScaleConnector should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/scbe_volume_info.go
- Line 21: warning: exported function NewScbeVolumeInfo should have comment or be unexported (golint)
-
-
ubiquity/utils/logger_utils.go
- Line 27: warning: exported function SetupOldLogger should have comment or be unexported (golint)
- Line 32: warning: exported function InitUbiquityServerLogger should have comment or be unexported (golint)
- Line 37: warning: exported function InitUbiquityServerTestLogger should have comment or be unexported (golint)
-
-
ubiquity/resources/resources.go
- Line 26: warning: exported const SpectrumScale should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported type UbiquityServerConfig should have comment or be unexported (golint)
- Line 44: warning: comment on exported type SpectrumScaleConfig should be of the form "SpectrumScaleConfig ..." (with optional leading article) (golint)
- Line 52: warning: exported type CredentialInfo should have comment or be unexported (golint)
- Line 58: warning: exported type ConnectionInfo should have comment or be unexported (golint)
- Line 64: warning: exported type ScbeConfig should have comment or be unexported (golint)
- Line 74: warning: exported const UbiquityInstanceNameMaxSize should have comment or be unexported (golint)
- Line 75: warning: exported const DefaultForScbeConfigParamDefaultVolumeSize should have comment or be unexported (golint)
- Line 76: warning: exported const DefaultForScbeConfigParamDefaultFilesystem should have comment or be unexported (golint)
- Line 77: warning: exported const PathToMountUbiquityBlockDevices should have comment or be unexported (golint)
- Line 78: warning: exported const OptionNameForVolumeFsType should have comment or be unexported (golint)
- Line 79: warning: exported const ScbeKeyVolAttachToHost should have comment or be unexported (golint)
- Line 80: warning: exported const ScbeKeyVolAttachLunNumToHost should have comment or be unexported (golint)
- Line 81: warning: exported const ScbeDefaultPort should have comment or be unexported (golint)
- Line 82: warning: exported const SslModeRequire should have comment or be unexported (golint)
- Line 83: warning: exported const SslModeVerifyFull should have comment or be unexported (golint)
- Line 84: warning: exported const KeySslMode should have comment or be unexported (golint)
- Line 85: warning: exported const KeyScbeSslMode should have comment or be unexported (golint)
- Line 86: warning: exported const DefaultDbSslMode should have comment or be unexported (golint)
- Line 87: warning: exported const DefaultScbeSslMode should have comment or be unexported (golint)
- Line 88: warning: exported const DefaultPluginsSslMode should have comment or be unexported (golint)
- Line 89: warning: exported const SpectrumscaleDefaultPort should have comment or be unexported (golint)
- Line 90: warning: exported const SpectrumScaleParamPrefix should have comment or be unexported (golint)
- Line 91: warning: exported const KeySpectrumScaleSslMode should have comment or be unexported (golint)
- Line 92: warning: exported const DefaultSpectrumScaleSslMode should have comment or be unexported (golint)
- Line 94: warning: exported type SshConfig should have comment or be unexported (golint)
- Line 100: warning: exported type RestConfig should have comment or be unexported (golint)
- Line 108: warning: exported type SpectrumNfsRemoteConfig should have comment or be unexported (golint)
- Line 112: warning: exported type BrokerConfig should have comment or be unexported (golint)
- Line 117: warning: exported type UbiquityPluginConfig should have comment or be unexported (golint)
- Line 129: warning: exported type UbiquityDockerPluginConfig should have comment or be unexported (golint)
- Line 135: warning: exported type UbiquityServerConnectionInfo should have comment or be unexported (golint)
- Line 140: warning: exported type UbiquityPluginSslConfig should have comment or be unexported (golint)
- Line 148: warning: exported type StorageClient should have comment or be unexported (golint)
- Line 159: warning: comment on exported const VolumeNotFoundErrorMsg should be of the form "VolumeNotFoundErrorMsg ..." (golint)
- Line 162: warning: exported type VolumeNotFoundError should have comment or be unexported (golint)
- Line 170: warning: comment on exported type VolAlreadyExistsError should be of the form "VolAlreadyExistsError ..." (with optional leading article) (golint)
- Line 179: warning: exported type BackendInitializationError should have comment or be unexported (golint)
- Line 188: warning: exported const ClientInitializationErrorStr should have comment or be unexported (golint)
- Line 192: warning: exported type Mounter should have comment or be unexported (golint)
- Line 198: warning: exported type VolumeConfigGetter should have comment or be unexported (golint)
- Line 202: warning: exported type ActivateRequest should have comment or be unexported (golint)
- Line 209: warning: exported type CreateVolumeRequest should have comment or be unexported (golint)
- Line 217: warning: exported type RemoveVolumeRequest should have comment or be unexported (golint)
- Line 223: warning: exported type ListVolumesRequest should have comment or be unexported (golint)
- Line 230: warning: exported type AttachRequest should have comment or be unexported (golint)
- Line 237: warning: exported type DetachRequest should have comment or be unexported (golint)
- Line 243: warning: exported type GetVolumeRequest should have comment or be unexported (golint)
- Line 248: warning: exported type GetVolumeConfigRequest should have comment or be unexported (golint)
- Line 253: warning: exported type ActivateResponse should have comment or be unexported (golint)
- Line 258: warning: exported type GenericResponse should have comment or be unexported (golint)
- Line 262: warning: exported type MountRequest should have comment or be unexported (golint)
- Line 268: warning: exported method MountRequest.GetVolumeConfig should have comment or be unexported (golint)
- Line 274: warning: exported type UnmountRequest should have comment or be unexported (golint)
- Line 279: warning: exported type AfterDetachRequest should have comment or be unexported (golint)
- Line 284: warning: exported method AfterDetachRequest.GetVolumeConfig should have comment or be unexported (golint)
- Line 290: warning: exported type AttachResponse should have comment or be unexported (golint)
- Line 295: warning: exported type MountResponse should have comment or be unexported (golint)
- Line 300: warning: exported type GetResponse should have comment or be unexported (golint)
- Line 305: warning: exported type DockerGetResponse should have comment or be unexported (golint)
- Line 310: warning: exported type Volume should have comment or be unexported (golint)
- Line 317: warning: exported type GetConfigResponse should have comment or be unexported (golint)
- Line 322: warning: exported type ListResponse should have comment or be unexported (golint)
- Line 327: warning: exported type FlexVolumeResponse should have comment or be unexported (golint)
- Line 333: warning: exported type FlexVolumeMountRequest should have comment or be unexported (golint)
- Line 339: warning: exported type FlexVolumeUnmountRequest should have comment or be unexported (golint)
- Line 343: warning: exported type FlexVolumeAttachRequest should have comment or be unexported (golint)
- Line 349: warning: exported type FlexVolumeDetachRequest should have comment or be unexported (golint)
- Line 354: warning: exported type RequestContext should have comment or be unexported (golint)
- Line 359: warning: exported type VolumeMountProperties should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/errors.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 30: warning: exported type CommandExecuteError should have comment or be unexported (golint)
- Line 39: warning: exported type VolumeNotFoundError should have comment or be unexported (golint)
- Line 77: warning: exported type FaultyDeviceError should have comment or be unexported (golint)
- Line 85: warning: exported type MultipathDeviceNotFoundError should have comment or be unexported (golint)
- Line 93: warning: exported const NoIscsiadmCommnadWarningMessage should have comment or be unexported (golint)
-
-
ubiquity/utils/logs/logger.go
- Line 23: warning: exported type Level should have comment or be unexported (golint)
- Line 26: warning: exported const DEBUG should have comment (or a comment on this block) or be unexported (golint)
-
-
ubiquity/web_server/storage_api_handler.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 30: warning: exported type StorageApiHandler should have comment or be unexported (golint)
- Line 37: warning: exported function NewStorageApiHandler should have comment or be unexported (golint)
- Line 41: warning: exported method StorageApiHandler.Activate should have comment or be unexported (golint)
- Line 45: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 72: warning: exported method StorageApiHandler.CreateVolume should have comment or be unexported (golint)
- Line 76: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 116: warning: exported method StorageApiHandler.RemoveVolume should have comment or be unexported (golint)
- Line 120: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 155: warning: exported method StorageApiHandler.AttachVolume should have comment or be unexported (golint)
- Line 159: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 189: warning: exported method StorageApiHandler.DetachVolume should have comment or be unexported (golint)
- Line 193: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 220: warning: exported method StorageApiHandler.GetVolumeConfig should have comment or be unexported (golint)
- Line 224: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 256: warning: exported method StorageApiHandler.GetVolume should have comment or be unexported (golint)
- Line 260: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 292: warning: exported method StorageApiHandler.ListVolumes should have comment or be unexported (golint)
- Line 296: warning: don't use underscores in Go names; var go_id should be goID (golint)
- Line 385: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/remote/client_init.go
- Line 35: warning: exported const KeyUseSsl should have comment or be unexported (golint)
- Line 36: warning: exported const KeyVerifyCA should have comment or be unexported (golint)
- Line 39: warning: exported type SslModeValueInvalid should have comment or be unexported (golint)
- Line 48: warning: exported type SslModeFullVerifyWithoutCAfile should have comment or be unexported (golint)
- Line 57: warning: exported function NewRemoteClientSecure should have comment or be unexported (golint)
- Line 113: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/local/scbe/scbe_rest_client_gen.go
- Line 23: warning: comment on exported type ScbeRestClientGen should be of the form "ScbeRestClientGen ..." (with optional leading article) (golint)
- Line 29: warning: comment on exported function InitScbeRestClientGen should be of the form "InitScbeRestClientGen ..." (golint)
-
-
ubiquity/remote/mounter/initiator/connectors/fibre_channel.go
- Line 14: warning: exported function NewFibreChannelConnector should have comment or be unexported (golint)
- Line 18: warning: exported function NewFibreChannelConnectorWithExecutor should have comment or be unexported (golint)
- Line 23: warning: exported function NewFibreChannelConnectorWithAllFields should have comment or be unexported (golint)
-
-
ubiquity/main.go
- Line 36: warning: exported const HeartbeatInterval should have comment (or a comment on this block) or be unexported (golint)
-
-
ubiquity/remote/mounter/initiator/linuxfc.go
- Line 14: warning: exported const SYSTOOL should have comment or be unexported (golint)
- Line 15: warning: exported const SYSTOOL_TIMEOUT should have comment or be unexported (golint)
- Line 16: warning: exported const KeyResetLIP should have comment or be unexported (golint)
- Line 18: warning: exported var FC_HOST_SYSFS_PATH should have comment or be unexported (golint)
- Line 19: warning: exported var SCSI_HOST_SYSFS_PATH should have comment or be unexported (golint)
- Line 25: warning: exported function NewLinuxFibreChannel should have comment or be unexported (golint)
- Line 29: warning: exported function NewLinuxFibreChannelWithExecutor should have comment or be unexported (golint)
-
-
ubiquity/local/spectrumscale/spectrumscale.go
- Line 40: warning: exported const Type should have comment (or a comment on this block) or be unexported (golint)
- Line 56: warning: exported function NewSpectrumLocalClient should have comment or be unexported (golint)
- Line 64: warning: exported function NewSpectrumLocalClientWithConnectors should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/multipath_utils.go
- Line 1: warning: package comment should be of the form "Package block_device_utils ..." (golint)
- Line 16: warning: don't use an underscore in package name (golint)
- Line 76: warning: don't use underscores in Go names; var split_a1 should be splitA1 (golint)
-
-
ubiquity/remote/mounter/block_device_utils/multipath_utils_test.go
- Line 1: warning: don't use an underscore in package name (golint)
-
-
ubiquity/local/spectrumscale/connectors/rest_v2.go
- Line 43: warning: exported type SslModeValueInvalid should have comment or be unexported (golint)
- Line 52: warning: exported type SslModeFullVerifyWithoutCAfile should have comment or be unexported (golint)
- Line 133: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 138: warning: exported function NewSpectrumRestV2 should have comment or be unexported (golint)
- Line 183: warning: exported function NewspectrumRestV2WithClient should have comment or be unexported (golint)
- Line 210: warning: don't use underscores in Go names; var cid_str should be cidStr (golint)
- Line 265: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 550: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/remote/mounter/scbe.go
- Line 44: warning: exported function NewScbeMounter should have comment or be unexported (golint)
- Line 49: warning: exported function NewScbeMounterWithExecuter should have comment or be unexported (golint)
-
-
ubiquity/local/scbe/errors.go
- Line 73: warning: exported type FsTypeNotSupportedError should have comment or be unexported (golint)
- Line 103: warning: exported type CannotDeleteVolWhichAttachedToHostError should have comment or be unexported (golint)
- Line 121: warning: exported type ConfigDefaultSizeNotNumError should have comment or be unexported (golint)
- Line 130: warning: exported type ConfigDefaultFilesystemTypeNotSupported should have comment or be unexported (golint)
- Line 140: warning: exported type ConfigScbeUbiquityInstanceNameWrongSize should have comment or be unexported (golint)
- Line 148: warning: exported type VolumeNameExceededMaxLengthError should have comment or be unexported (golint)
- Line 158: warning: exported type InValidRequestError should have comment or be unexported (golint)
- Line 174: warning: exported type SslModeValueInvalid should have comment or be unexported (golint)
- Line 183: warning: exported type SslModeFullVerifyWithoutCAfile should have comment or be unexported (golint)
- Line 192: warning: exported type InvalidMappingsForVolume should have comment or be unexported (golint)
- Line 200: warning: exported const VolumeNotFoundOnArrayErrorMsg should have comment or be unexported (golint)
- Line 202: warning: exported type VolumeNotFoundOnArrayError should have comment or be unexported (golint)
- Line 210: warning: exported type BadHttpStatusCodeError should have comment or be unexported (golint)
-
-
ubiquity/web_server/storage_api_server.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 36: warning: exported type StorageApiServer should have comment or be unexported (golint)
- Line 42: warning: exported function NewStorageApiServer should have comment or be unexported (golint)
- Line 46: warning: exported method StorageApiServer.InitializeHandler should have comment or be unexported (golint)
- Line 59: warning: exported method StorageApiServer.Start should have comment or be unexported (golint)
- Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 77: warning: exported method StorageApiServer.StartNonSsl should have comment or be unexported (golint)
- Line 84: warning: exported method StorageApiServer.StartSsl should have comment or be unexported (golint)
-
-
ubiquity/remote/mounter/block_device_utils/fs.go
- Line 17: warning: don't use an underscore in package name (golint)
- Line 31: warning: exported const NotMountedErrorMessage should have comment (or a comment on this block) or be unexported (golint)
- Line 182: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 225: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
ubiquity/utils/executor.go
- Line 33: warning: comment on exported type Executor should be of the form "Executor ..." (with optional leading article) (golint)
- Line 50: warning: don't use underscores in Go names; interface method parameter file_pattern should be filePattern (golint)
- Line 61: warning: exported function NewExecutor should have comment or be unexported (golint)
- Line 170: warning: don't use underscores in Go names; method parameter file_pattern should be filePattern (golint)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
ubiquity/utils/locker.go
- Line 109: warning: ineffectual assignment to stat (ineffassign)
-
-
ubiquity/local/spectrumscale/connectors/rest_v2_test.go
- Line 76: warning: ineffectual assignment to err (ineffassign)
-
-
ubiquity/local/scbe/scbe_rest_client_integration_test.go
- Line 215: warning: ineffectual assignment to exist (ineffassign)
- Line 237: warning: ineffectual assignment to exist (ineffassign)
misspell92%
Misspell Finds commonly misspelled English words
-
-
ubiquity/local/scbe/scbe_test.go
- Line 635: warning: "retuns" is a misspelling of "returns" (misspell)
-
-
ubiquity/remote/mounter/initiator/linuxfc.go
- Line 142: warning: "analysises" is a misspelling of "analyses" (misspell)
-
-
ubiquity/utils/mpath.go
- Line 17: warning: "analysises" is a misspelling of "analyses" (misspell)
-
-
ubiquity/remote/mounter/block_device_mounter_utils/block_device_utils_mounter_test.go
- Line 280: warning: "succees" is a misspelling of "succeeds" (misspell)
-
-
ubiquity/remote/mounter/block_device_utils/mpath.go
- Line 191: warning: "occured" is a misspelling of "occurred" (misspell)
-
-
ubiquity/remote/mounter/scbe_test.go
- Line 71: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 89: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 99: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 110: warning: "occured" is a misspelling of "occurred" (misspell)
- Line 132: warning: "occured" is a misspelling of "occurred" (misspell)
-
-
ubiquity/local/clients_test.go
- Line 127: warning: "successfull" is a misspelling of "successful" (misspell)