Preparing report...

Report for github.com/Mellanox/rdma-cni

A+    Excellent!    Found 7 issues across 13 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint46%

Golint is a linter for Go source code.

    • rdma-cni/pkg/cache/cache.go
    • Line 15: warning: exported type StateRef should have comment or be unexported (golint)
    • Line 17: warning: exported type StateCache should have comment or be unexported (golint)
    • Line 28: warning: comment on exported function NewStateCache should be of the form "NewStateCache ..." (golint)
    • Line 33: warning: exported type FsStateCache should have comment or be unexported (golint)
    • Line 38: warning: exported method FsStateCache.GetStateRef should have comment or be unexported (golint)
    • Line 42: warning: exported method FsStateCache.Save should have comment or be unexported (golint)
    • Line 63: warning: exported method FsStateCache.Load should have comment or be unexported (golint)
    • Line 73: warning: exported method FsStateCache.Delete should have comment or be unexported (golint)
    • rdma-cni/pkg/types/types.go
    • Line 7: warning: exported type RdmaNetConf should have comment or be unexported (golint)
    • Line 13: warning: exported type CNIArgs should have comment or be unexported (golint)
    • Line 17: warning: exported type RdmaCNIArgs should have comment or be unexported (golint)
    • Line 22: warning: comment on exported const RdmaNetStateVersion should be of the form "RdmaNetStateVersion ..." (golint)
    • Line 27: warning: exported function NewRdmaNetState should have comment or be unexported (golint)
    • Line 31: warning: exported type RdmaNetState should have comment or be unexported (golint)
    • rdma-cni/pkg/rdma/rdma.go
    • Line 10: warning: exported const RdmaSysModeExclusive should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported function NewRdmaManager should have comment or be unexported (golint)
    • Line 18: warning: exported type Manager should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!