gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• virtlet/pkg/client/clientset/versioned/clientset.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• virtlet/tests/e2e/framework/pod_interface.go
  • Line 80: warning: cyclomatic complexity 19 of function (*PodInterface).WaitForPodStatus() is high (> 15) (gocyclo)

• virtlet/pkg/libvirttools/virtualization.go
  • Line 780: warning: cyclomatic complexity 18 of function (*VirtualizationTool).ListContainers() is high (> 15) (gocyclo)

• virtlet/pkg/dhcp/server.go
  • Line 166: warning: cyclomatic complexity 19 of function (*Server).prepareResponse() is high (> 15) (gocyclo)

• virtlet/pkg/image/image.go
  • Line 479: warning: cyclomatic complexity 17 of function (*FileStore).GetImagePathDigestAndVirtualSize() is high (> 15) (gocyclo)

• virtlet/pkg/api/virtlet.k8s/v1/zz_generated.deepcopy.go
  • Line 145: warning: cyclomatic complexity 41 of function (*VirtletConfig).DeepCopyInto() is high (> 15) (gocyclo)

• virtlet/pkg/utils/merge.go
  • Line 39: warning: cyclomatic complexity 22 of function mergeRecursive() is high (> 15) (gocyclo)

• virtlet/pkg/tapmanager/fdserver.go
  • Line 334: warning: cyclomatic complexity 17 of function (*FDServer).serveConn() is high (> 15) (gocyclo)
  • Line 451: warning: cyclomatic complexity 16 of function (*FDClient).request() is high (> 15) (gocyclo)

• virtlet/tests/network/vm_network_test.go
  • Line 383: warning: cyclomatic complexity 25 of function TestTapFDSource() is high (> 15) (gocyclo)

• virtlet/pkg/flexvolume/flexvolume_test.go
  • Line 37: warning: cyclomatic complexity 17 of function TestFlexVolume() is high (> 15) (gocyclo)

• virtlet/pkg/metadata/containers.go
  • Line 73: warning: cyclomatic complexity 17 of function (containerMeta).Save() is high (> 15) (gocyclo)

• virtlet/pkg/tapmanager/tapfdsource.go
  • Line 137: warning: cyclomatic complexity 16 of function (*TapFDSource).GetFDs() is high (> 15) (gocyclo)

• virtlet/tests/gm/git_test.go
  • Line 37: warning: cyclomatic complexity 23 of function TestGitDiff() is high (> 15) (gocyclo)

• virtlet/pkg/libvirttools/virtualization_test.go
  • Line 200: warning: cyclomatic complexity 17 of function TestContainerLifecycle() is high (> 15) (gocyclo)

• virtlet/pkg/nettools/nettools.go
  • Line 781: warning: cyclomatic complexity 17 of function Teardown() is high (> 15) (gocyclo)

• virtlet/cmd/vmwrapper/vmwrapper.go
  • Line 54: warning: cyclomatic complexity 19 of function main() is high (> 15) (gocyclo)

• virtlet/pkg/metadata/types/annotations.go
  • Line 202: warning: cyclomatic complexity 37 of function (*VirtletAnnotations).parsePodAnnotations() is high (> 15) (gocyclo)

• virtlet/pkg/tools/md_docs.go
  • Line 150: warning: cyclomatic complexity 22 of function printFlagUsages() is high (> 15) (gocyclo)

golint95%

Golint is a linter for Go source code.

• virtlet/tests/e2e/framework/utils.go
  • Line 8: warning: exported function Curl should have comment or be unexported (golint)

• virtlet/pkg/metadata/types/types.go
  • Line 33: warning: don't use underscores in Go names; const PodSandboxState_SANDBOX_READY should be PodSandboxStateSANDBOXREADY (golint)
  • Line 34: warning: comment on exported const PodSandboxState_SANDBOX_NOTREADY should be of the form "PodSandboxState_SANDBOX_NOTREADY ..." (golint)
  • Line 36: warning: don't use underscores in Go names; const PodSandboxState_SANDBOX_NOTREADY should be PodSandboxStateSANDBOXNOTREADY (golint)
  • Line 44: warning: don't use underscores in Go names; const Protocol_TCP should be ProtocolTCP (golint)
  • Line 45: warning: comment on exported const Protocol_UDP should be of the form "Protocol_UDP ..." (golint)
  • Line 46: warning: don't use underscores in Go names; const Protocol_UDP should be ProtocolUDP (golint)
  • Line 54: warning: don't use underscores in Go names; const ContainerState_CONTAINER_CREATED should be ContainerStateCONTAINERCREATED (golint)
  • Line 55: warning: comment on exported const ContainerState_CONTAINER_RUNNING should be of the form "ContainerState_CONTAINER_RUNNING ..." (golint)
  • Line 56: warning: don't use underscores in Go names; const ContainerState_CONTAINER_RUNNING should be ContainerStateCONTAINERRUNNING (golint)
  • Line 57: warning: comment on exported const ContainerState_CONTAINER_EXITED should be of the form "ContainerState_CONTAINER_EXITED ..." (golint)
  • Line 58: warning: don't use underscores in Go names; const ContainerState_CONTAINER_EXITED should be ContainerStateCONTAINEREXITED (golint)
  • Line 59: warning: comment on exported const ContainerState_CONTAINER_UNKNOWN should be of the form "ContainerState_CONTAINER_UNKNOWN ..." (golint)
  • Line 60: warning: don't use underscores in Go names; const ContainerState_CONTAINER_UNKNOWN should be ContainerStateCONTAINERUNKNOWN (golint)
  • Line 224: warning: receiver name dev should be consistent with previous receiver name d for VMVolumeDevice (golint)

• virtlet/tests/integration/manager.go
  • Line 77: warning: exported type VirtletManager should have comment or be unexported (golint)
  • Line 86: warning: exported function NewVirtletManager should have comment or be unexported (golint)
  • Line 100: warning: exported method VirtletManager.Run should have comment or be unexported (golint)
  • Line 148: warning: exported method VirtletManager.Close should have comment or be unexported (golint)
  • Line 158: warning: exported function Dial should have comment or be unexported (golint)

• virtlet/tests/e2e/framework/common.go
  • Line 28: warning: exported const NginxImage should have comment (or a comment on this block) or be unexported (golint)

• virtlet/tests/gm/data.go
  • Line 70: warning: exported type JSONVerifier should have comment or be unexported (golint)
  • Line 76: warning: exported function NewJSONVerifier should have comment or be unexported (golint)
  • Line 80: warning: exported method JSONVerifier.Suffix should have comment or be unexported (golint)
  • Line 84: warning: exported method JSONVerifier.Verify should have comment or be unexported (golint)
  • Line 106: warning: exported method JSONVerifier.Marshal should have comment or be unexported (golint)

• virtlet/tests/longevity/vmcontoller.go
  • Line 29: warning: exported type VMInstance should have comment or be unexported (golint)
  • Line 41: warning: exported method VMInstance.Test should have comment or be unexported (golint)
  • Line 73: warning: exported method VMInstance.Create should have comment or be unexported (golint)
  • Line 91: warning: exported method VMInstance.Delete should have comment or be unexported (golint)
  • Line 99: warning: exported method VMInstance.ReCreate should have comment or be unexported (golint)
  • Line 107: warning: error should be the last type when returning multiple items (golint)
  • Line 125: warning: exported method VMInstance.Stop should have comment or be unexported (golint)

• virtlet/tests/e2e/ginkgo-ext/scopes.go
  • Line 56: warning: exported var Context should have comment or be unexported (golint)
  • Line 82: warning: exported type Done should have comment or be unexported (golint)
  • Line 141: warning: comment on exported function AfterFailed should be of the form "AfterFailed ..." (golint)

• virtlet/pkg/utils/testing/runprocess.go
  • Line 24: warning: exported type TestCommand should have comment or be unexported (golint)
  • Line 42: warning: exported method TestCommand.Stop should have comment or be unexported (golint)
  • Line 57: warning: exported method TestCommand.Pid should have comment or be unexported (golint)

• virtlet/tests/e2e/common.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 34: warning: should not use dot imports (golint)
  • Line 58: warning: comment on exported function UsingCirros should be of the form "UsingCirros ..." (golint)
  • Line 171: warning: exported type VMOptions should have comment or be unexported (golint)
  • Line 173: warning: exported method VMOptions.ApplyDefaults should have comment or be unexported (golint)

• virtlet/tests/e2e/constants.go
  • Line 21: warning: exported const DefaultSSHUser should have comment (or a comment on this block) or be unexported (golint)

• virtlet/tests/longevity/runner.go
  • Line 31: warning: exported function GetBaseTests should have comment or be unexported (golint)
  • Line 42: warning: exported function GetStressTests should have comment or be unexported (golint)
  • Line 77: warning: exported function Run should have comment or be unexported (golint)

• virtlet/tests/e2e/framework/controller.go
  • Line 61: warning: exported var ClusterURL should have comment or be unexported (golint)
  • Line 150: warning: exported method Controller.CreateVirtletImageMapping should have comment or be unexported (golint)
  • Line 154: warning: exported method Controller.DeleteVirtletImageMapping should have comment or be unexported (golint)
  • Line 158: warning: exported method Controller.CreateVirtletConfigMapping should have comment or be unexported (golint)
  • Line 162: warning: exported method Controller.DeleteVirtletConfigMapping should have comment or be unexported (golint)
  • Line 327: warning: exported method Controller.WaitForVirtletPodOnTheNode should have comment or be unexported (golint)
  • Line 353: warning: exported method Controller.WaitForVirtletPodToDisappearFromTheNode should have comment or be unexported (golint)

• virtlet/tests/e2e/framework/localcmd_interface.go
  • Line 11: warning: exported type LocalCmd should have comment or be unexported (golint)
  • Line 15: warning: exported function LocalExecutor should have comment or be unexported (golint)
  • Line 21: warning: exported method LocalCmd.Run should have comment or be unexported (golint)
  • Line 39: warning: exported method LocalCmd.Start should have comment or be unexported (golint)
  • Line 52: warning: exported method LocalCmd.Close should have comment or be unexported (golint)

• virtlet/pkg/utils/testing/https.go
  • Line 31: warning: exported function GenerateCert should have comment or be unexported (golint)
  • Line 78: warning: exported function EncodePEMCert should have comment or be unexported (golint)
  • Line 84: warning: exported function EncodePEMKey should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• virtlet/pkg/metadata/fake_client.go
  • Line 40: warning: ineffectual assignment to err (ineffassign)

• virtlet/pkg/stream/utils_test.go
  • Line 35: warning: ineffectual assignment to err (ineffassign)

• virtlet/tests/gm/git.go
  • Line 52: warning: ineffectual assignment to out (ineffassign)

• virtlet/tests/e2e/cni_test.go
  • Line 49: warning: ineffectual assignment to err (ineffassign)
  • Line 55: warning: ineffectual assignment to err (ineffassign)

• virtlet/pkg/libvirttools/qcow2_flexvolume_test.go
  • Line 73: warning: ineffectual assignment to err (ineffassign)

• virtlet/pkg/libvirttools/virtualization.go
  • Line 627: warning: ineffectual assignment to errs (ineffassign)

misspell96%

Misspell Finds commonly misspelled English words

• virtlet/pkg/manager/runtime.go
  • Line 119: warning: "disappered" is a misspelling of "disappeared" (misspell)

• virtlet/pkg/libvirttools/cloudinit_test.go
  • Line 985: warning: "diffrent" is a misspelling of "different" (misspell)

• virtlet/pkg/libvirttools/cpusets_test.go
  • Line 41: warning: "proces" is a misspelling of "process" (misspell)

• virtlet/pkg/nettools/sriov.go
  • Line 201: warning: "occuring" is a misspelling of "occurring" (misspell)

• virtlet/pkg/virt/fake/fake_domain.go
  • Line 314: warning: "interace" is a misspelling of "interacted" (misspell)

• virtlet/pkg/fs/fs.go
  • Line 69: warning: "occured" is a misspelling of "occurred" (misspell)
  • Line 148: warning: "acording" is a misspelling of "according" (misspell)

• virtlet/pkg/image/image.go
  • Line 550: warning: "nmae" is a misspelling of "name" (misspell)

• virtlet/pkg/stream/listener.go
  • Line 247: warning: "manualy" is a misspelling of "manually" (misspell)

• virtlet/pkg/manager/cri.go
  • Line 229: warning: "convers" is a misspelling of "converts" (misspell)

• virtlet/pkg/libvirttools/extdata.go
  • Line 203: warning: "unkonwn" is a misspelling of "unknown" (misspell)