Preparing report...

Report for github.com/RediSearch/ftsb

A    Great!    Found 9 issues across 10 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint20%

Golint is a linter for Go source code.

    • ftsb/benchmark_runner/stat.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 10: warning: exported method Stat.CmdStats should have comment or be unexported (golint)
    • Line 14: warning: exported method Stat.SetCmdStats should have comment or be unexported (golint)
    • Line 18: warning: exported type CmdStat should have comment or be unexported (golint)
    • Line 29: warning: exported method CmdStat.StartTs should have comment or be unexported (golint)
    • Line 33: warning: exported method CmdStat.SetStartTs should have comment or be unexported (golint)
    • Line 37: warning: exported method CmdStat.Tx should have comment or be unexported (golint)
    • Line 41: warning: exported method CmdStat.SetTx should have comment or be unexported (golint)
    • Line 45: warning: exported method CmdStat.Rx should have comment or be unexported (golint)
    • Line 49: warning: exported method CmdStat.SetRx should have comment or be unexported (golint)
    • Line 53: warning: exported method CmdStat.Latency should have comment or be unexported (golint)
    • Line 57: warning: exported method CmdStat.SetLatency should have comment or be unexported (golint)
    • Line 61: warning: exported method CmdStat.Label should have comment or be unexported (golint)
    • Line 65: warning: exported method CmdStat.SetLabel should have comment or be unexported (golint)
    • Line 69: warning: exported method CmdStat.CmdQueryId should have comment or be unexported (golint)
    • Line 73: warning: exported function NewCmdStat should have comment or be unexported (golint)
    • Line 77: warning: exported function NewStat should have comment or be unexported (golint)
    • Line 84: warning: exported method Stat.AddEntry should have comment or be unexported (golint)
    • Line 91: warning: exported method Stat.GetCmdsCount should have comment or be unexported (golint)
    • Line 95: warning: exported method Stat.Merge should have comment or be unexported (golint)
    • Line 100: warning: exported method Stat.AddCmdStatEntry should have comment or be unexported (golint)
    • ftsb/benchmark_runner/test_result.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 3: warning: exported type DataPoint should have comment or be unexported (golint)
    • Line 8: warning: exported method DataPoint.AddValue should have comment or be unexported (golint)
    • Line 12: warning: exported function NewDataPoint should have comment or be unexported (golint)
    • Line 24: warning: exported type TestResult should have comment or be unexported (golint)
    • ftsb/benchmark_runner/benchmark_runner.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 28: warning: exported const CurrentResultFormatVersion should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: don't use underscores in Go names; struct field inst_setupWriteHistogram should be instSetupWriteHistogram (golint)
    • Line 65: warning: don't use underscores in Go names; struct field inst_writeHistogram should be instWriteHistogram (golint)
    • Line 70: warning: don't use underscores in Go names; struct field inst_updateHistogram should be instUpdateHistogram (golint)
    • Line 74: warning: don't use underscores in Go names; struct field inst_readHistogram should be instReadHistogram (golint)
    • Line 78: warning: don't use underscores in Go names; struct field inst_readCursorHistogram should be instReadCursorHistogram (golint)
    • Line 82: warning: don't use underscores in Go names; struct field inst_deleteHistogram should be instDeleteHistogram (golint)
    • Line 86: warning: don't use underscores in Go names; struct field inst_totalHistogram should be instTotalHistogram (golint)
    • Line 95: warning: exported method BenchmarkRunner.GetTotalsMap should have comment or be unexported (golint)
    • Line 132: warning: exported method BenchmarkRunner.GetMeasuredRatiosMap should have comment or be unexported (golint)
    • Line 159: warning: exported method BenchmarkRunner.GetOverallRatesMap should have comment or be unexported (golint)
    • Line 159: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 221: warning: exported method BenchmarkRunner.GetTimeSeriesMap should have comment or be unexported (golint)
    • Line 241: warning: exported method BenchmarkRunner.GetPerSecondEncodedHistogramsMap should have comment or be unexported (golint)
    • Line 299: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 350: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 371: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 396: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 408: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 490: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 570: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 670: warning: receiver name l should be consistent with previous receiver name b for BenchmarkRunner (golint)
    • Line 702: warning: exported method BenchmarkRunner.GetOverallQuantiles should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign90%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!