Preparing report...

Report for github.com/RoboCup-SSL/ssl-game-controller

A+    Excellent!    Found 34 issues across 83 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint60%

Golint is a linter for Go source code.

    • ssl-game-controller/internal/app/config/config.go
    • Line 109: warning: exported type Engine should have comment or be unexported (golint)
    • Line 122: warning: exported type TimeAcquisitionMode should have comment or be unexported (golint)
    • Line 125: warning: exported const TimeAcquisitionModeSystem should have comment (or a comment on this block) or be unexported (golint)
    • Line 152: warning: exported method Controller.WriteTo should have comment or be unexported (golint)
    • Line 255: warning: comment on exported function LoadConfig should be of the form "LoadConfig ..." (golint)
    • ssl-game-controller/internal/app/rcon/server.go
    • Line 21: warning: exported type Server should have comment or be unexported (golint)
    • Line 33: warning: exported type Client should have comment or be unexported (golint)
    • Line 41: warning: exported type SignedMessage should have comment or be unexported (golint)
    • Line 46: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 54: warning: exported method Server.Start should have comment or be unexported (golint)
    • Line 70: warning: exported method Server.Stop should have comment or be unexported (golint)
    • Line 86: warning: exported method Server.GetClient should have comment or be unexported (golint)
    • Line 93: warning: exported method Server.PutClient should have comment or be unexported (golint)
    • Line 99: warning: exported method Server.GetClientIds should have comment or be unexported (golint)
    • Line 158: warning: exported method Server.CloseConnection should have comment or be unexported (golint)
    • Line 165: warning: exported method Client.Ok should have comment or be unexported (golint)
    • Line 186: warning: exported method Client.Reject should have comment or be unexported (golint)
    • Line 197: warning: exported method Server.LoadTrustedKeys should have comment or be unexported (golint)
    • Line 245: warning: exported function VerifySignature should have comment or be unexported (golint)
    • ssl-game-controller/internal/app/config/division.go
    • Line 3: warning: exported type Division should have comment or be unexported (golint)
    • Line 6: warning: exported const DivA should have comment (or a comment on this block) or be unexported (golint)
    • Line 10: warning: comment on exported var Divisions should be of the form "Divisions ..." (golint)
    • ssl-game-controller/internal/app/rcon/server_team.go
    • Line 17: warning: exported type TeamServer should have comment or be unexported (golint)
    • Line 22: warning: exported type TeamClient should have comment or be unexported (golint)
    • Line 28: warning: exported function NewTeamServer should have comment or be unexported (golint)
    • Line 159: warning: exported method TeamServer.SendRequest should have comment or be unexported (golint)
    • ssl-game-controller/internal/app/engine/config.go
    • Line 13: warning: exported function DefaultConfig should have comment or be unexported (golint)
    • Line 76: warning: exported method Config.StringJson should have comment or be unexported (golint)
    • Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • ssl-game-controller/internal/app/geom/rectangle.go
    • Line 5: warning: exported type Rectangle should have comment or be unexported (golint)
    • Line 46: warning: comment on exported method Rectangle.MinX should be of the form "MinX ..." (golint)
    • Line 51: warning: comment on exported method Rectangle.MaxY should be of the form "MaxY ..." (golint)
    • Line 56: warning: comment on exported method Rectangle.MinY should be of the form "MinY ..." (golint)
    • ssl-game-controller/internal/app/ci/ci.go
    • Line 15: warning: exported type Handler should have comment or be unexported (golint)
    • Line 17: warning: exported type Server should have comment or be unexported (golint)
    • Line 28: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 32: warning: exported method Server.SetEngine should have comment or be unexported (golint)
    • Line 36: warning: exported method Server.Start should have comment or be unexported (golint)
    • Line 41: warning: exported method Server.Stop should have comment or be unexported (golint)
    • Line 126: warning: exported method Server.SendMessage should have comment or be unexported (golint)
    • Line 138: warning: exported method Server.Time should have comment or be unexported (golint)
    • Line 144: warning: exported method Server.TickChanProvider should have comment or be unexported (golint)
    • ssl-game-controller/pkg/sslnet/multicast_server.go
    • Line 12: warning: exported type MulticastServer should have comment or be unexported (golint)
    • Line 21: warning: exported function NewMulticastServer should have comment or be unexported (golint)
    • Line 27: warning: exported method MulticastServer.Start should have comment or be unexported (golint)
    • Line 32: warning: exported method MulticastServer.Stop should have comment or be unexported (golint)
    • ssl-game-controller/internal/app/state/state.go
    • Line 38: warning: exported method State.Clone should have comment or be unexported (golint)
    • Line 59: warning: exported method State.StringJson should have comment or be unexported (golint)
    • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • ssl-game-controller/internal/app/api/server.go
    • Line 19: warning: exported type Server should have comment or be unexported (golint)
    • Line 24: warning: exported type ServerConnection should have comment or be unexported (golint)
    • Line 35: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 42: warning: exported function NewServerConnection should have comment or be unexported (golint)
    • ssl-game-controller/internal/app/rcon/server_remotecontrol.go
    • Line 18: warning: exported type RemoteControlServer should have comment or be unexported (golint)
    • Line 23: warning: exported type RemoteControlClient should have comment or be unexported (golint)
    • Line 29: warning: exported function NewRemoteControlServer should have comment or be unexported (golint)
    • Line 132: warning: exported method RemoteControlServer.SendRequest should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!