Preparing report...

Report for github.com/SAP/sap-btp-service-operator

A+    Excellent!    Found 14 issues across 37 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint62%

Golint is a linter for Go source code.

    • sap-btp-service-operator/internal/secrets/resolver.go
    • Line 17: warning: exported const SAPBTPOperatorSecretName should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: exported type SecretResolver should have comment or be unexported (golint)
    • Line 27: warning: exported method SecretResolver.GetSecretForResource should have comment or be unexported (golint)
    • sap-btp-service-operator/client/sm/client.go
    • Line 66: warning: exported type ServiceManagerError should have comment or be unexported (golint)
    • Line 81: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
    • Line 383: warning: exported function ExtractInstanceID should have comment or be unexported (golint)
    • Line 392: warning: exported function ExtractBindingID should have comment or be unexported (golint)
    • Line 401: warning: exported function BuildOperationURL should have comment or be unexported (golint)
    • sap-btp-service-operator/api/v1alpha1/servicebinding_types.go
    • Line 118: warning: exported method ServiceBinding.GetConditions should have comment or be unexported (golint)
    • Line 122: warning: exported method ServiceBinding.SetConditions should have comment or be unexported (golint)
    • Line 126: warning: exported method ServiceBinding.GetControllerName should have comment or be unexported (golint)
    • Line 130: warning: exported method ServiceBinding.GetParameters should have comment or be unexported (golint)
    • Line 134: warning: exported method ServiceBinding.GetStatus should have comment or be unexported (golint)
    • Line 138: warning: exported method ServiceBinding.SetStatus should have comment or be unexported (golint)
    • Line 142: warning: exported method ServiceBinding.GetObservedGeneration should have comment or be unexported (golint)
    • Line 146: warning: exported method ServiceBinding.SetObservedGeneration should have comment or be unexported (golint)
    • Line 150: warning: exported method ServiceBinding.DeepClone should have comment or be unexported (golint)
    • Line 154: warning: exported method ServiceBinding.GetReady should have comment or be unexported (golint)
    • Line 158: warning: exported method ServiceBinding.SetReady should have comment or be unexported (golint)
    • sap-btp-service-operator/api/v1alpha1/serviceinstance_types.go
    • Line 116: warning: exported method ServiceInstance.GetConditions should have comment or be unexported (golint)
    • Line 120: warning: exported method ServiceInstance.SetConditions should have comment or be unexported (golint)
    • Line 124: warning: exported method ServiceInstance.GetControllerName should have comment or be unexported (golint)
    • Line 128: warning: exported method ServiceInstance.GetParameters should have comment or be unexported (golint)
    • Line 132: warning: exported method ServiceInstance.GetStatus should have comment or be unexported (golint)
    • Line 136: warning: exported method ServiceInstance.SetStatus should have comment or be unexported (golint)
    • Line 140: warning: exported method ServiceInstance.GetObservedGeneration should have comment or be unexported (golint)
    • Line 144: warning: exported method ServiceInstance.SetObservedGeneration should have comment or be unexported (golint)
    • Line 148: warning: exported method ServiceInstance.DeepClone should have comment or be unexported (golint)
    • Line 152: warning: exported method ServiceInstance.GetReady should have comment or be unexported (golint)
    • Line 156: warning: exported method ServiceInstance.SetReady should have comment or be unexported (golint)
    • sap-btp-service-operator/api/v1alpha1/types.go
    • Line 9: warning: exported type ControllerName should have comment or be unexported (golint)
    • Line 12: warning: exported const ServiceInstanceController should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: comment on exported type SAPBTPResource should be of the form "SAPBTPResource ..." (with optional leading article) (golint)

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!