gofmt87%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• unifiedpush-operator/pkg/controller/unifiedpushserver/enmasse.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• unifiedpush-operator/pkg/controller/unifiedpushserver/postgresql.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver_controller_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• unifiedpush-operator/cmd/manager/main.go
  • Line 62: warning: cyclomatic complexity 20 of function main() is high (> 15) (gocyclo)

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver_controller.go
  • Line 237: warning: cyclomatic complexity 143 of function (*ReconcileUnifiedPushServer).Reconcile() is high (> 15) (gocyclo)
  • Line 77: warning: cyclomatic complexity 22 of function add() is high (> 15) (gocyclo)

golint70%

Golint is a linter for Go source code.

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver.go
  • Line 343: warning: don't use underscores in Go names; var sop_url should be sopURL (golint)

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver_controller.go
  • Line 799: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• unifiedpush-operator/pkg/controller/unifiedpushserver/postgresql.go
  • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 209: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• unifiedpush-operator/pkg/constants/constants.go
  • Line 4: warning: exported const UPSImage should have comment (or a comment on this block) or be unexported (golint)

• unifiedpush-operator/pkg/apis/push/v1alpha1/unifiedpushserver_types.go
  • Line 102: warning: comment on exported type UnifiedPushServerBackup should be of the form "UnifiedPushServerBackup ..." (with optional leading article) (golint)
  • Line 146: warning: exported type StatusPhase should have comment or be unexported (golint)
  • Line 149: warning: exported var PhaseEmpty should have comment or be unexported (golint)

• unifiedpush-operator/pkg/apis/push/v1alpha1/zz_generated.openapi.go
  • Line 12: warning: exported function GetOpenAPIDefinitions should have comment or be unexported (golint)
  • Line 20: warning: don't use underscores in Go names; func schema_pkg_apis_push_v1alpha1_UnifiedPushServer should be schemaPkgApisPushV1alpha1UnifiedPushServer (golint)
  • Line 63: warning: don't use underscores in Go names; func schema_pkg_apis_push_v1alpha1_UnifiedPushServerSpec should be schemaPkgApisPushV1alpha1UnifiedPushServerSpec (golint)
  • Line 156: warning: don't use underscores in Go names; func schema_pkg_apis_push_v1alpha1_UnifiedPushServerStatus should be schemaPkgApisPushV1alpha1UnifiedPushServerStatus (golint)

• unifiedpush-operator/version/version.go
  • Line 4: warning: exported var Version should have comment or be unexported (golint)

• unifiedpush-operator/pkg/config/config.go
  • Line 5: warning: exported type Config should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)

• unifiedpush-operator/cmd/manager/main.go
  • Line 280: warning: don't use underscores in Go names; var sop_url should be sopURL (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver_controller.go
  • Line 569: warning: ineffectual assignment to err (ineffassign)
  • Line 700: warning: ineffectual assignment to err (ineffassign)

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver_controller_test.go
  • Line 96: warning: ineffectual assignment to err (ineffassign)

misspell96%

Misspell Finds commonly misspelled English words

• unifiedpush-operator/pkg/controller/unifiedpushserver/unifiedpushserver.go
  • Line 990: warning: "commited" is a misspelling of "committed" (misspell)