gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• redis-operator/pkg/redis/slot_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• redis-operator/pkg/controller/checks_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• redis-operator/pkg/controller/actions.go
  • Line 157: warning: cyclomatic complexity 28 of function (*Controller).managePodScaleDown() is high (> 15) (gocyclo)
  • Line 389: warning: cyclomatic complexity 26 of function (*Controller).applyConfiguration() is high (> 15) (gocyclo)
  • Line 70: warning: cyclomatic complexity 16 of function (*Controller).manageRollingUpdate() is high (> 15) (gocyclo)

• redis-operator/pkg/controller/controller.go
  • Line 253: warning: cyclomatic complexity 27 of function (*Controller).syncCluster() is high (> 15) (gocyclo)

• redis-operator/pkg/controller/checks.go
  • Line 14: warning: cyclomatic complexity 17 of function compareStatus() is high (> 15) (gocyclo)

• redis-operator/pkg/controller/clustering/cluster-placement.go
  • Line 69: warning: cyclomatic complexity 30 of function PlaceSlaves() is high (> 15) (gocyclo)

• redis-operator/pkg/controller/clustering/cluster-migration.go
  • Line 54: warning: cyclomatic complexity 18 of function DispatchSlotToNewMasters() is high (> 15) (gocyclo)

• redis-operator/cmd/kubectl-plugin/main.go
  • Line 26: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• redis-operator/pkg/redis/fake/redis.go
  • Line 192: warning: cyclomatic complexity 30 of function writeTo() is high (> 15) (gocyclo)

• redis-operator/pkg/redisnode/node.go
  • Line 47: warning: cyclomatic complexity 17 of function (*Node).UpdateNodeConfigFile() is high (> 15) (gocyclo)

golint85%

Golint is a linter for Go source code.

• redis-operator/pkg/client/clientset/versioned/fake/doc.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/fake/fake_redis_client.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 32: warning: exported type FakeRedisoperatorV1 should have comment or be unexported (golint)
  • Line 36: warning: exported method FakeRedisoperatorV1.RedisClusters should have comment or be unexported (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/redis_client.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 33: warning: exported type RedisoperatorV1Interface should have comment or be unexported (golint)
  • Line 43: warning: exported method RedisoperatorV1Client.RedisClusters should have comment or be unexported (golint)

• redis-operator/pkg/api/redis/v1/zz_generated.deepcopy.go
  • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• redis-operator/pkg/client/clientset/versioned/fake/clientset_generated.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)
  • Line 64: warning: exported method Clientset.Discovery should have comment or be unexported (golint)

• redis-operator/pkg/client/clientset/versioned/scheme/doc.go
  • Line 1: warning: package comment should be of the form "Package scheme ..." (golint)

• redis-operator/pkg/client/clientset/versioned/doc.go
  • Line 1: warning: package comment should be of the form "Package versioned ..." (golint)

• redis-operator/pkg/client/informers/externalversions/internalinterfaces/factory_interfaces.go
  • Line 37: warning: exported type NewInformerFunc should have comment or be unexported (golint)
  • Line 45: warning: exported type TweakListOptionsFunc should have comment or be unexported (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/generated_expansion.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)
  • Line 26: warning: exported type RedisClusterExpansion should have comment or be unexported (golint)

• redis-operator/pkg/client/clientset/versioned/fake/register.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)

• redis-operator/pkg/client/clientset/versioned/scheme/register.go
  • Line 1: warning: package comment should be of the form "Package scheme ..." (golint)
  • Line 34: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 35: warning: exported var Codecs should have comment or be unexported (golint)
  • Line 36: warning: exported var ParameterCodec should have comment or be unexported (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/doc.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/rediscluster.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)

• redis-operator/pkg/client/clientset/versioned/clientset.go
  • Line 1: warning: package comment should be of the form "Package versioned ..." (golint)
  • Line 34: warning: exported type Interface should have comment or be unexported (golint)
  • Line 53: warning: comment on exported method Clientset.Redisoperator should be of the form "Redisoperator ..." (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/fake/doc.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)

• redis-operator/pkg/client/clientset/versioned/typed/redis/v1/fake/fake_rediscluster.go
  • Line 1: warning: package comment should be of the form "Package fake ..." (golint)

• redis-operator/test/e2e/operator.go
  • Line 9: warning: should not use dot imports (golint)
  • Line 11: warning: should not use dot imports (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell91%

Misspell Finds commonly misspelled English words

• redis-operator/pkg/garbagecollector/garbagecollector.go
  • Line 24: warning: "Garabge" is a misspelling of "Garbage" (misspell)

• redis-operator/pkg/redis/node_test.go
  • Line 311: warning: "sould" is a misspelling of "could" (misspell)
  • Line 322: warning: "sould" is a misspelling of "could" (misspell)
  • Line 333: warning: "sould" is a misspelling of "could" (misspell)

• redis-operator/pkg/controller/clustering/cluster-migration.go
  • Line 92: warning: "absolutly" is a misspelling of "absolutely" (misspell)

• redis-operator/pkg/controller/sanitycheck/clustersplit.go
  • Line 89: warning: "independant" is a misspelling of "independent" (misspell)

• redis-operator/pkg/api/redis/v1/types.go
  • Line 162: warning: "currenlty" is a misspelling of "currently" (misspell)
  • Line 164: warning: "currenlty" is a misspelling of "currently" (misspell)
  • Line 166: warning: "currenlty" is a misspelling of "currently" (misspell)

• redis-operator/pkg/controller/actions.go
  • Line 235: warning: "avalaible" is a misspelling of "available" (misspell)

• redis-operator/pkg/redis/fake/admin/connection.go
  • Line 28: warning: "adress" is a misspelling of "address" (misspell)
  • Line 55: warning: "adress" is a misspelling of "address" (misspell)

• redis-operator/pkg/redis/admin.go
  • Line 345: warning: "occured" is a misspelling of "occurred" (misspell)

• redis-operator/pkg/redis/clusterinfo.go
  • Line 27: warning: "targetted" is a misspelling of "targeted" (misspell)
  • Line 28: warning: "targetted" is a misspelling of "targeted" (misspell)

• redis-operator/pkg/redis/connections.go
  • Line 44: warning: "adress" is a misspelling of "address" (misspell)
  • Line 120: warning: "adress" is a misspelling of "address" (misspell)
  • Line 137: warning: "adress" is a misspelling of "address" (misspell)
  • Line 195: warning: "adress" is a misspelling of "address" (misspell)