Preparing report...

Report for github.com/apache/dubbo-go-hessian2

A+    Excellent!    Found 123 issues across 165 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint25%

Golint is a linter for Go source code.

    • dubbo-go-hessian2/java_exception/unmodifiable_class_exception.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 20: warning: comment on exported type UnmodifiableClassException should be of the form "UnmodifiableClassException ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported method UnmodifiableClassException.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • dubbo-go-hessian2/java_util/uuid.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 24: warning: comment on exported type UUID should be of the form "UUID ..." (with optional leading article) (golint)
    • Line 30: warning: exported method UUID.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_collection.go
    • Line 28: warning: exported type JavaCollectionObject should have comment or be unexported (golint)
    • Line 36: warning: exported function SetCollectionSerialize should have comment or be unexported (golint)
    • Line 61: warning: exported type JavaCollectionSerializer should have comment or be unexported (golint)
    • Line 63: warning: exported method JavaCollectionSerializer.EncObject should have comment or be unexported (golint)
    • Line 88: warning: exported method JavaCollectionSerializer.DecObject should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_sql_time/date.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 22: warning: exported type Date should have comment or be unexported (golint)
    • Line 26: warning: exported method Date.GetTime should have comment or be unexported (golint)
    • Line 30: warning: exported method Date.SetTime should have comment or be unexported (golint)
    • Line 34: warning: exported method Date.JavaClassName should have comment or be unexported (golint)
    • Line 38: warning: exported method Date.ValueOf should have comment or be unexported (golint)
    • Line 47: warning: comment on exported method Date.Year should be of the form "Year ..." (golint)
    • Line 52: warning: comment on exported method Date.Month should be of the form "Month ..." (golint)
    • Line 57: warning: comment on exported method Date.Day should be of the form "Day ..." (golint)
    • dubbo-go-hessian2/java_util_test.go
    • Line 72: warning: don't use underscores in Go names; var simplified_chinese should be simplifiedChinese (golint)
    • Line 73: warning: don't use underscores in Go names; var traditional_chinese should be traditionalChinese (golint)
    • dubbo-go-hessian2/serialize.go
    • Line 38: warning: exported type Serializer should have comment or be unexported (golint)
    • Line 45: warning: exported function SetSerializer should have comment or be unexported (golint)
    • Line 49: warning: exported function GetSerializer should have comment or be unexported (golint)
    • Line 54: warning: exported type IntegerSerializer should have comment or be unexported (golint)
    • Line 56: warning: exported method IntegerSerializer.DecObject should have comment or be unexported (golint)
    • Line 71: warning: exported method IntegerSerializer.EncObject should have comment or be unexported (golint)
    • Line 80: warning: exported type DecimalSerializer should have comment or be unexported (golint)
    • Line 82: warning: exported method DecimalSerializer.EncObject should have comment or be unexported (golint)
    • Line 91: warning: exported method DecimalSerializer.DecObject should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_exception/lambda_conversion_exception.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 20: warning: comment on exported type LambdaConversionException should be of the form "LambdaConversionException ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported method LambdaConversionException.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • dubbo-go-hessian2/java8_time/year.go
    • Line 1: warning: package comment should be of the form "Package java8_time ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 17: warning: don't use an underscore in package name (golint)
    • Line 19: warning: comment on exported type Year should be of the form "Year ..." (with optional leading article) (golint)
    • Line 24: warning: exported method Year.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_util/locale.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 57: warning: exported method Locale.County should have comment or be unexported (golint)
    • Line 61: warning: exported method Locale.Lang should have comment or be unexported (golint)
    • Line 77: warning: exported method LocaleHandle.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/java8_time/period.go
    • Line 1: warning: package comment should be of the form "Package java8_time ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 17: warning: don't use an underscore in package name (golint)
    • Line 19: warning: comment on exported type Period should be of the form "Period ..." (with optional leading article) (golint)
    • Line 26: warning: exported method Period.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_exception/exception.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 31: warning: comment on exported type Throwable should be of the form "Throwable ..." (with optional leading article) (golint)
    • Line 58: warning: comment on exported method Throwable.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • Line 67: warning: exported type Exception should have comment or be unexported (golint)
    • Line 75: warning: exported function NewException should have comment or be unexported (golint)
    • Line 88: warning: comment on exported method Exception.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • Line 97: warning: exported type StackTraceElement should have comment or be unexported (golint)
    • Line 109: warning: exported type Class should have comment or be unexported (golint)
    • Line 113: warning: exported type Method should have comment or be unexported (golint)
    • Line 122: warning: exported method Class.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/decode.go
    • Line 52: warning: comment on exported function NewDecoderSize should be of the form "NewDecoderSize ..." (golint)
    • Line 57: warning: comment on exported function NewDecoderWithSkip should be of the form "NewDecoderWithSkip ..." (golint)
    • Line 93: warning: exported method Decoder.Reset should have comment or be unexported (golint)
    • Line 217: warning: exported method Decoder.Buffered should have comment or be unexported (golint)
    • Line 292: warning: comment on exported type TypeRefs should be of the form "TypeRefs ..." (with optional leading article) (golint)
    • Line 309: warning: exported method TypeRefs.Get should have comment or be unexported (golint)
    • dubbo-go-hessian2/java_sql_time.go
    • Line 49: warning: comment on exported method JavaSqlTimeSerializer.EncObject should be of the form "EncObject ..." (golint)
    • Line 116: warning: comment on exported method JavaSqlTimeSerializer.DecObject should be of the form "DecObject ..." (golint)
    • dubbo-go-hessian2/java_exception/interrupted_io_exception.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 20: warning: comment on exported type InterruptedIOException should be of the form "InterruptedIOException ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported method InterruptedIOException.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • dubbo-go-hessian2/java_exception/interrupted_exception.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 20: warning: comment on exported type InterruptedException should be of the form "InterruptedException ..." (with optional leading article) (golint)
    • Line 47: warning: comment on exported method InterruptedException.GetStackTrace should be of the form "GetStackTrace ..." (golint)
    • dubbo-go-hessian2/request.go
    • Line 156: warning: exported type Request should have comment or be unexported (golint)
    • Line 172: warning: exported function EnsureRequest should have comment or be unexported (golint)
    • Line 340: warning: exported function ToMapStringString should have comment or be unexported (golint)
    • dubbo-go-hessian2/const.go
    • Line 162: warning: don't use underscores in Go names; const Response_OK should be ResponseOK (golint)
    • Line 163: warning: don't use underscores in Go names; const Response_CLIENT_TIMEOUT should be ResponseCLIENTTIMEOUT (golint)
    • Line 164: warning: don't use underscores in Go names; const Response_SERVER_TIMEOUT should be ResponseSERVERTIMEOUT (golint)
    • Line 165: warning: don't use underscores in Go names; const Response_BAD_REQUEST should be ResponseBADREQUEST (golint)
    • Line 166: warning: don't use underscores in Go names; const Response_BAD_RESPONSE should be ResponseBADRESPONSE (golint)
    • Line 167: warning: don't use underscores in Go names; const Response_SERVICE_NOT_FOUND should be ResponseSERVICENOTFOUND (golint)
    • Line 168: warning: don't use underscores in Go names; const Response_SERVICE_ERROR should be ResponseSERVICEERROR (golint)
    • Line 169: warning: don't use underscores in Go names; const Response_SERVER_ERROR should be ResponseSERVERERROR (golint)
    • Line 170: warning: don't use underscores in Go names; const Response_CLIENT_ERROR should be ResponseCLIENTERROR (golint)
    • Line 241: warning: exported var NilValue should have comment or be unexported (golint)
    • dubbo-go-hessian2/java8_time/year_month.go
    • Line 1: warning: package comment should be of the form "Package java8_time ..." (golint)
    • Line 1: warning: package comment should not have leading space (golint)
    • Line 17: warning: don't use an underscore in package name (golint)
    • Line 19: warning: comment on exported type YearMonth should be of the form "YearMonth ..." (with optional leading article) (golint)
    • Line 25: warning: exported method YearMonth.JavaClassName should have comment or be unexported (golint)
    • dubbo-go-hessian2/hessian.go
    • Line 36: warning: don't use underscores in Go names; const PackageRequest_TwoWay should be PackageRequestTwoWay (golint)
    • Line 37: warning: don't use underscores in Go names; const PackageResponse_Exception should be PackageResponseException (golint)
    • Line 38: warning: don't use underscores in Go names; const PackageType_BitSize should be PackageTypeBitSize (golint)
    • Line 77: warning: comment on exported function NewHessianCodecCustom should be of the form "NewHessianCodecCustom ..." (golint)
    • Line 215: warning: comment on exported method HessianCodec.ReadAttachments should be of the form "ReadAttachments ..." (golint)
    • dubbo-go-hessian2/java_sql_time/time.go
    • Line 18: warning: don't use an underscore in package name (golint)
    • Line 22: warning: exported type Time should have comment or be unexported (golint)
    • Line 26: warning: exported method Time.JavaClassName should have comment or be unexported (golint)
    • Line 30: warning: exported method Time.GetTime should have comment or be unexported (golint)
    • Line 34: warning: comment on exported method Time.Hour should be of the form "Hour ..." (golint)
    • Line 39: warning: comment on exported method Time.Minute should be of the form "Minute ..." (golint)
    • Line 44: warning: comment on exported method Time.Second should be of the form "Second ..." (golint)
    • Line 49: warning: exported method Time.SetTime should have comment or be unexported (golint)
    • Line 53: warning: exported method Time.ValueOf should have comment or be unexported (golint)

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!