Go Report Card

Preparing report...

Report for github.com/apache/servicecomb-mesher

A+    Excellent!    Found 41 issues across 110 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint79%

Golint is a linter for Go source code.

    • servicecomb-mesher/proxy/protocol/dubbo/server/server.go
    • Line 36: warning: exported const NAME should have comment (or a comment on this block) or be unexported (golint)
    • Line 54: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 63: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/utils/msgqueue.go
    • Line 26: warning: exported const MaxBufferMsg should have comment (or a comment on this block) or be unexported (golint)
    • Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 88: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 91: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 97: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 106: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 120: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/utils/typeutil.go
    • Line 30: warning: exported const JavaString should have comment (or a comment on this block) or be unexported (golint)
    • Line 75: warning: exported const SchemaString should have comment (or a comment on this block) or be unexported (golint)
    • Line 257: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/schema/schema.go
    • Line 29: warning: exported const InQuery should have comment (or a comment on this block) or be unexported (golint)
    • Line 55: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 65: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 80: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 274: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/server/dubbo_conn.go
    • Line 34: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 59: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 92: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 98: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 110: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 159: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 167: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 198: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/client/dubbo_client.go
    • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 94: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 138: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 144: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 172: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 187: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 196: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 205: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 211: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 241: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 247: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 263: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/utils/thrmgr.go
    • Line 40: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 47: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 57: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 86: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 91: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 97: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/client/client_conn.go
    • Line 33: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 58: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 117: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 168: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 176: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 181: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 190: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • Line 210: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
    • servicecomb-mesher/proxy/protocol/dubbo/utils/buffer.go
    • Line 45: warning: exported const DefaultGrowSize should have comment (or a comment on this block) or be unexported (golint)
    • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 205: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign83%

IneffAssign detects ineffectual assignments in Go code.

    • servicecomb-mesher/proxy/resolver/destination_test.go
    • Line 44: warning: ineffectual assignment to destinationString (ineffassign)
    • Line 45: warning: ineffectual assignment to destinationString (ineffassign)
    • Line 49: warning: ineffectual assignment to destinationString (ineffassign)
    • Line 53: warning: ineffectual assignment to destinationString (ineffassign)
    • Line 57: warning: ineffectual assignment to destinationString (ineffassign)
    • Line 57: warning: ineffectual assignment to p (ineffassign)
    • servicecomb-mesher/proxy/protocol/dubbo/utils/typeutil_test.go
    • Line 49: warning: ineffectual assignment to str (ineffassign)
    • Line 88: warning: ineffectual assignment to str (ineffassign)
    • Line 91: warning: ineffectual assignment to str (ineffassign)
    • Line 100: warning: ineffectual assignment to str (ineffassign)
    • Line 103: warning: ineffectual assignment to str (ineffassign)
    • Line 107: warning: ineffectual assignment to str (ineffassign)
    • Line 144: warning: ineffectual assignment to str (ineffassign)
    • Line 144: warning: ineffectual assignment to err (ineffassign)
    • Line 155: warning: ineffectual assignment to str (ineffassign)
    • Line 164: warning: ineffectual assignment to str (ineffassign)
    • Line 173: warning: ineffectual assignment to str (ineffassign)
    • Line 182: warning: ineffectual assignment to str (ineffassign)
    • Line 186: warning: ineffectual assignment to str (ineffassign)
    • Line 188: warning: ineffectual assignment to str (ineffassign)
    • Line 192: warning: ineffectual assignment to str (ineffassign)
    • Line 194: warning: ineffectual assignment to str (ineffassign)
    • Line 216: warning: ineffectual assignment to str (ineffassign)

misspell96%

Misspell Finds commonly misspelled English words