gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• trireme-lib/controller/internal/enforcer/applicationproxy/servicecache/servicecache_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• trireme-lib/controller/internal/enforcer/applicationproxy/serviceregistry/serviceregistry_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• trireme-lib/controller/internal/enforcer/apiauth/apiauth_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• trireme-lib/controller/internal/enforcer/envoyauthorizer/envoyproxy/sds_server.go
  • Line 267: warning: cyclomatic complexity 23 of function (*SdsServer).StreamSecrets() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/nfqdatapath/nfq_windows.go
  • Line 20: warning: cyclomatic complexity 25 of function (*Datapath).startFrontmanPacketFilter() is high (> 15) (gocyclo)

• trireme-lib/monitor/internal/pod/resync.go
  • Line 23: warning: cyclomatic complexity 18 of function ResyncWithAllPods() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/nfqdatapath/nfq_linux.go
  • Line 194: warning: cyclomatic complexity 20 of function (*Datapath).processApplicationPacketsFromNFQ() is high (> 15) (gocyclo)
  • Line 69: warning: cyclomatic complexity 20 of function (*Datapath).processNetworkPacketsFromNFQ() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/envoyauthorizer/envoyproxy/auth_server.go
  • Line 193: warning: cyclomatic complexity 16 of function (*AuthServer).ingressCheck() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/lookup/lookup.go
  • Line 184: warning: cyclomatic complexity 19 of function (*PolicyDB).Search() is high (> 15) (gocyclo)

• trireme-lib/controller/pkg/aclprovider/iptablesprovider_windows.go
  • Line 123: warning: cyclomatic complexity 25 of function (*BatchProvider).Append() is high (> 15) (gocyclo)

• trireme-lib/controller/pkg/tokens/binarycodec.go
  • Line 649: warning: cyclomatic complexity 132 of function (*JWTClaims).CodecEncodeSelf() is high (> 15) (gocyclo)
  • Line 1443: warning: cyclomatic complexity 92 of function (*JWTClaims).codecDecodeSelfFromArray() is high (> 15) (gocyclo)
  • Line 1243: warning: cyclomatic complexity 75 of function (*JWTClaims).codecDecodeSelfFromMap() is high (> 15) (gocyclo)
  • Line 55: warning: cyclomatic complexity 64 of function (*BinaryJWTClaims).CodecEncodeSelf() is high (> 15) (gocyclo)
  • Line 466: warning: cyclomatic complexity 32 of function (*BinaryJWTClaims).codecDecodeSelfFromArray() is high (> 15) (gocyclo)
  • Line 404: warning: cyclomatic complexity 22 of function (*BinaryJWTClaims).codecDecodeSelfFromMap() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/nfqdatapath/datapath_tcp.go
  • Line 387: warning: cyclomatic complexity 22 of function (*Datapath).clientIdentityAllowed() is high (> 15) (gocyclo)
  • Line 38: warning: cyclomatic complexity 18 of function (*Datapath).processNetworkTCPPackets() is high (> 15) (gocyclo)
  • Line 743: warning: cyclomatic complexity 18 of function (*Datapath).processNetworkAckPacket() is high (> 15) (gocyclo)
  • Line 114: warning: cyclomatic complexity 17 of function (*Datapath).processApplicationTCPPackets() is high (> 15) (gocyclo)
  • Line 565: warning: cyclomatic complexity 16 of function (*Datapath).processNetworkSynAckPacket() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/applicationproxy/applicationproxy.go
  • Line 96: warning: cyclomatic complexity 16 of function (*AppProxy).Enforce() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/apiauth/apiauth.go
  • Line 162: warning: cyclomatic complexity 25 of function (*Processor).NetworkRequest() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/dnsproxy/dns_linux.go
  • Line 91: warning: cyclomatic complexity 18 of function forwardDNSReq() is high (> 15) (gocyclo)

• trireme-lib/controller/pkg/usertokens/pkitokens/publickeys.go
  • Line 22: warning: cyclomatic complexity 18 of function parsePublicKeysFromPEM() is high (> 15) (gocyclo)

• trireme-lib/utils/fqdn/fqdn.go
  • Line 53: warning: cyclomatic complexity 16 of function Find() is high (> 15) (gocyclo)

• trireme-lib/cmd/systemdutil/systemdutil.go
  • Line 125: warning: cyclomatic complexity 23 of function (*RequestProcessor).ParseCommand() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/processmon/processmon.go
  • Line 113: warning: cyclomatic complexity 16 of function (*RemoteMonitor).LaunchRemoteEnforcer() is high (> 15) (gocyclo)

• trireme-lib/monitor/internal/pod/controller.go
  • Line 138: warning: cyclomatic complexity 35 of function (*ReconcilePod).Reconcile() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/nfqdatapath/datapath_udp.go
  • Line 48: warning: cyclomatic complexity 32 of function (*Datapath).ProcessNetworkUDPPacket() is high (> 15) (gocyclo)
  • Line 423: warning: cyclomatic complexity 17 of function (*Datapath).triggerNegotiation() is high (> 15) (gocyclo)
  • Line 251: warning: cyclomatic complexity 17 of function (*Datapath).processNetUDPPacket() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/utils/packetgen/packet_gen.go
  • Line 397: warning: cyclomatic complexity 17 of function (*PacketFlow).GenerateTCPFlow() is high (> 15) (gocyclo)

• trireme-lib/monitor/internal/pod/monitor_test.go
  • Line 77: warning: cyclomatic complexity 47 of function TestPodMonitor_startManager() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/nfqdatapath/datapath_test.go
  • Line 1250: warning: cyclomatic complexity 19 of function TestFlowReportingUptoInvalidSynAck() is high (> 15) (gocyclo)
  • Line 626: warning: cyclomatic complexity 19 of function TestConnectionTrackerStateLocalContainer() is high (> 15) (gocyclo)
  • Line 123: warning: cyclomatic complexity 16 of function TestPacketHandlingFirstThreePacketsHavePayload() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/supervisor/iptablesctrl/acls_windows.go
  • Line 69: warning: cyclomatic complexity 19 of function (*iptables).platformInit() is high (> 15) (gocyclo)
  • Line 284: warning: cyclomatic complexity 19 of function transformACLRules() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/applicationproxy/tcp/verifier/verifier.go
  • Line 88: warning: cyclomatic complexity 19 of function (*verifier).VerifyPeerCertificate() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/applicationproxy/http/http.go
  • Line 216: warning: cyclomatic complexity 22 of function (*Config).RunNetworkServer() is high (> 15) (gocyclo)
  • Line 616: warning: cyclomatic complexity 18 of function (*Config).processNetRequest() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/windows/rulespec_windows.go
  • Line 486: warning: cyclomatic complexity 96 of function ParseRuleSpec() is high (> 15) (gocyclo)
  • Line 73: warning: cyclomatic complexity 47 of function MakeRuleSpecText() is high (> 15) (gocyclo)
  • Line 834: warning: cyclomatic complexity 42 of function (*WindowsRuleSpec).Equal() is high (> 15) (gocyclo)
  • Line 252: warning: cyclomatic complexity 34 of function ReduceIcmpProtoString() is high (> 15) (gocyclo)
  • Line 424: warning: cyclomatic complexity 19 of function ParseIcmpTypeCode() is high (> 15) (gocyclo)

• trireme-lib/monitor/internal/pod/monitor.go
  • Line 185: warning: cyclomatic complexity 16 of function (*PodMonitor).startManager() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/enforcer/applicationproxy/tcp/verifier/verifier_test.go
  • Line 86: warning: cyclomatic complexity 21 of function Test_verifier_VerifyPeerCertificate() is high (> 15) (gocyclo)

• trireme-lib/utils/frontman/rulecleanup_windows_test.go
  • Line 82: warning: cyclomatic complexity 25 of function Test_ruleCleaner() is high (> 15) (gocyclo)

• trireme-lib/controller/internal/supervisor/iptablesctrl/acls.go
  • Line 670: warning: cyclomatic complexity 37 of function (*iptables).generateACLRules() is high (> 15) (gocyclo)
  • Line 429: warning: cyclomatic complexity 18 of function (*iptables).sortACLsInBuckets() is high (> 15) (gocyclo)

golint99%

Golint is a linter for Go source code.

• trireme-lib/controller/internal/enforcer/applicationproxy/http/ping_http.go
  • Line 162: warning: should not use basic type string as key in context.WithValue (golint)

• trireme-lib/controller/internal/enforcer/nfqdatapath/datapath_tcp.go
  • Line 873: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 947: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• trireme-lib/controller/internal/enforcer/envoyauthorizer/envoyproxy/sds_server.go
  • Line 392: warning: ineffectual assignment to pemCert (ineffassign)

• trireme-lib/controller/pkg/tokens/binarycodec.go
  • Line 209: warning: ineffectual assignment to yynn2 (ineffassign)
  • Line 926: warning: ineffectual assignment to yynn2 (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!