Preparing report...

Report for github.com/argoproj-labs/argocd-vault-plugin

(v1.6.0)

A+    Excellent!    Found 14 issues across 40 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo82%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • cmd/generate.go
    • Line 18: warning: cyclomatic complexity 16 of function NewGenerateCommand() is high (> 15) (gocyclo)

golint82%

Golint is a linter for Go source code.

    • pkg/auth/vault/token.go
    • Line 7: warning: comment on exported type TokenAuth should be of the form "TokenAuth ..." (with optional leading article) (golint)
    • Line 10: warning: comment on exported method TokenAuth.Authenticate should be of the form "Authenticate ..." (golint)
    • pkg/types/constants.go
    • Line 4: warning: comment on exported const EnvAvpType should be of the form "EnvAvpType ..." (golint)
    • Line 6: warning: exported const EnvAvpRoleID should have comment (or a comment on this block) or be unexported (golint)
    • Line 20: warning: comment on exported const VaultBackend should be of the form "VaultBackend ..." (golint)
    • Line 40: warning: comment on exported const AVPPathAnnotation should be of the form "AVPPathAnnotation ..." (golint)
    • pkg/helpers/test_helpers.go
    • Line 290: warning: comment on exported function CreateTestAuthVault should be of the form "CreateTestAuthVault ..." (golint)
    • Line 349: warning: exported method MockVault.Login should have comment or be unexported (golint)
    • Line 352: warning: exported method MockVault.LoadData should have comment or be unexported (golint)
    • Line 355: warning: exported method MockVault.GetSecrets should have comment or be unexported (golint)
    • Line 366: warning: exported method MockVault.GetIndividualSecret should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell95%

Misspell Finds commonly misspelled English words