gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• atomix-controller/pkg/apis/sidecar/v2beta1/proxy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• atomix-controller/pkg/controller/core/v2beta1/store.go
  • Line 95: warning: cyclomatic complexity 39 of function (*StoreReconciler).reconcileProtocol() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/cloud/v1beta3/membership.go
  • Line 38: warning: cyclomatic complexity 22 of function (*Controller).JoinGroup() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/cloud/v1beta3/primitive.go
  • Line 139: warning: cyclomatic complexity 22 of function (*Controller).GetPrimitives() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/util/leader/leader.go
  • Line 46: warning: cyclomatic complexity 18 of function Become() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/sidecar/v2beta1/pod.go
  • Line 491: warning: cyclomatic complexity 51 of function (*PodReconciler).getPermissions() is high (> 15) (gocyclo)
  • Line 166: warning: cyclomatic complexity 44 of function (*PodReconciler).reconcilePrimitive() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/sidecar/v2beta1/proxy.go
  • Line 107: warning: cyclomatic complexity 25 of function (*ProxyReconciler).reconcileCreate() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/sidecar/v2beta1/agent.go
  • Line 100: warning: cyclomatic complexity 21 of function (*AgentReconciler).reconcileCreate() is high (> 15) (gocyclo)

• atomix-controller/pkg/controller/sidecar/v2beta1/driver.go
  • Line 66: warning: cyclomatic complexity 18 of function (*DriverInjector).Handle() is high (> 15) (gocyclo)

golint78%

Golint is a linter for Go source code.

• atomix-controller/pkg/controller/primitives/v2beta1/reconciler.go
  • Line 31: warning: exported type PrimitiveReconciler should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/broker.go
  • Line 70: warning: exported type BrokerInjector should have comment or be unexported (golint)
  • Line 76: warning: exported method BrokerInjector.InjectDecoder should have comment or be unexported (golint)
  • Line 81: warning: exported method BrokerInjector.Handle should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/controller.go
  • Line 24: warning: exported function AddControllers should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/primitive.go
  • Line 65: warning: exported method PrimitiveReconciler.Reconcile should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/proxy.go
  • Line 89: warning: exported method ProxyReconciler.Reconcile should have comment or be unexported (golint)
  • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/store.go
  • Line 65: warning: exported method StoreReconciler.Reconcile should have comment or be unexported (golint)
  • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/driver.go
  • Line 55: warning: exported type DriverInjector should have comment or be unexported (golint)
  • Line 61: warning: exported method DriverInjector.InjectDecoder should have comment or be unexported (golint)
  • Line 66: warning: exported method DriverInjector.Handle should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/pod.go
  • Line 114: warning: exported method PodReconciler.Reconcile should have comment or be unexported (golint)

• atomix-controller/pkg/controller/util/log/log.go
  • Line 46: warning: exported method ControllerLogger.Enabled should have comment or be unexported (golint)
  • Line 50: warning: exported method ControllerLogger.Info should have comment or be unexported (golint)
  • Line 58: warning: exported method ControllerLogger.V should have comment or be unexported (golint)
  • Line 62: warning: exported method ControllerLogger.WithValues should have comment or be unexported (golint)
  • Line 68: warning: exported method ControllerLogger.WithName should have comment or be unexported (golint)

• atomix-controller/pkg/controller/primitives/v2beta1/controller.go
  • Line 33: warning: exported function AddControllers should have comment or be unexported (golint)

• atomix-controller/pkg/controller/util/k8s/finalizers.go
  • Line 17: warning: exported function HasFinalizer should have comment or be unexported (golint)
  • Line 26: warning: exported function AddFinalizer should have comment or be unexported (golint)
  • Line 30: warning: exported function RemoveFinalizer should have comment or be unexported (golint)

• atomix-controller/pkg/controller/sidecar/v2beta1/agent.go
  • Line 82: warning: exported method AgentReconciler.Reconcile should have comment or be unexported (golint)
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• atomix-controller/pkg/controller/core/v2beta1/controller.go
  • Line 24: warning: exported function AddControllers should have comment or be unexported (golint)

• atomix-controller/pkg/controller/core/v2beta1/store.go
  • Line 72: warning: exported method StoreReconciler.Reconcile should have comment or be unexported (golint)
  • Line 158: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 165: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 220: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• atomix-controller/pkg/controller/core/v2beta1/store.go
  • Line 149: warning: ineffectual assignment to err (ineffassign)
  • Line 211: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!